)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2c94b6c0efc075a6d5601092f6b92850761e1e53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2356ceaf_f9ecab76","updated":"2024-02-08 21:01:16.000000000","message":"I don\u0027t +1 because I don\u0027t understand why the comment about order in requirements.txt is removed here.","commit_id":"0f9b9588bb61f61bf18352368457ca3606b57ca5"}],"neutron_fwaas/services/firewall/service_drivers/driver_api.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"89a212cb738f9e96c8fa9781b8ee8f6cbd93dac8","unresolved":true,"context_lines":[{"line_number":441,"context_line":"    related records in the databases."},{"line_number":442,"context_line":"    \"\"\""},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    # Firewal Group"},{"line_number":445,"context_line":"    def create_firewall_group_precommit(self, context, firewall_group):"},{"line_number":446,"context_line":"        pass"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"126b6b69_16ad573f","line":444,"range":{"start_line":444,"start_character":6,"end_line":444,"end_character":13},"updated":"2024-02-08 15:38:23.000000000","message":"nit: still a typo, but not important","commit_id":"0f9b9588bb61f61bf18352368457ca3606b57ca5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a821f271f5b75e400577fdda9e388f510dabf8c6","unresolved":true,"context_lines":[{"line_number":441,"context_line":"    related records in the databases."},{"line_number":442,"context_line":"    \"\"\""},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    # Firewal Group"},{"line_number":445,"context_line":"    def create_firewall_group_precommit(self, context, firewall_group):"},{"line_number":446,"context_line":"        pass"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f8c25332_81ba383a","line":444,"range":{"start_line":444,"start_character":6,"end_line":444,"end_character":13},"in_reply_to":"126b6b69_16ad573f","updated":"2024-02-09 09:58:47.000000000","message":"Done","commit_id":"0f9b9588bb61f61bf18352368457ca3606b57ca5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bb24526ef91d999692ddb867b5f0f78c3eb6d20a","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    related records in the databases."},{"line_number":442,"context_line":"    \"\"\""},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    # Firewal Group"},{"line_number":445,"context_line":"    def create_firewall_group_precommit(self, context, firewall_group):"},{"line_number":446,"context_line":"        pass"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e1db4237_373df0ad","line":444,"range":{"start_line":444,"start_character":6,"end_line":444,"end_character":13},"in_reply_to":"f8c25332_81ba383a","updated":"2024-02-09 16:49:49.000000000","message":"Done","commit_id":"0f9b9588bb61f61bf18352368457ca3606b57ca5"}],"neutron_fwaas/tests/unit/services/firewall/service_drivers/agents/test_agents.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2c94b6c0efc075a6d5601092f6b92850761e1e53","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class FakeAgentApi(agents.FirewallAgentCallbacks):"},{"line_number":43,"context_line":"    \"\"\"This class used to mock the AgentAPI delete method"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    It inherits from FirewallCallbacks because it needs access to"},{"line_number":46,"context_line":"    the firewall_deleted method."}],"source_content_type":"text/x-python","patch_set":1,"id":"1433ac59_69f60a29","line":43,"range":{"start_line":43,"start_character":7,"end_line":43,"end_character":30},"updated":"2024-02-08 21:01:16.000000000","message":"(no action required) from English grammar perspective, this communicates that \"this class - in the past - mocked the delete method\" but it probably means \"this class is used to mock the delete method.\" This wording should be adjusted accordingly, but since it comes from the original version, it\u0027s not a requirement to fix it here.","commit_id":"0f9b9588bb61f61bf18352368457ca3606b57ca5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3d39f72615168652b92c2173d756ac89383d8ce9","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class FakeAgentApi(agents.FirewallAgentCallbacks):"},{"line_number":43,"context_line":"    \"\"\"This class used to mock the AgentAPI delete method"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    It inherits from FirewallCallbacks because it needs access to"},{"line_number":46,"context_line":"    the firewall_deleted method."}],"source_content_type":"text/x-python","patch_set":1,"id":"7b2d98ce_5bdb2022","line":43,"range":{"start_line":43,"start_character":7,"end_line":43,"end_character":30},"in_reply_to":"1433ac59_69f60a29","updated":"2024-02-13 15:43:24.000000000","message":"Done","commit_id":"0f9b9588bb61f61bf18352368457ca3606b57ca5"}],"requirements.txt":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"89a212cb738f9e96c8fa9781b8ee8f6cbd93dac8","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":6,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":7,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":8,"context_line":"pbr\u003e\u003d4.0.0 # Apache-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"eventlet!\u003d0.18.3,!\u003d0.20.1,\u003e\u003d0.18.2 # MIT"},{"line_number":11,"context_line":"netaddr\u003e\u003d0.7.18 # BSD"}],"source_content_type":"text/plain","patch_set":1,"id":"9a5d0bb6_577c0702","side":"PARENT","line":8,"updated":"2024-02-08 15:38:23.000000000","message":"Should pbr be removed?","commit_id":"3fe92291f257a09607e31c949a08fca13a2110d1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a821f271f5b75e400577fdda9e388f510dabf8c6","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":6,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":7,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":8,"context_line":"pbr\u003e\u003d4.0.0 # Apache-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"eventlet!\u003d0.18.3,!\u003d0.20.1,\u003e\u003d0.18.2 # MIT"},{"line_number":11,"context_line":"netaddr\u003e\u003d0.7.18 # BSD"}],"source_content_type":"text/plain","patch_set":1,"id":"c83d961d_1dc3c101","side":"PARENT","line":8,"in_reply_to":"9a5d0bb6_577c0702","updated":"2024-02-09 09:58:47.000000000","message":"It should","commit_id":"3fe92291f257a09607e31c949a08fca13a2110d1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bb24526ef91d999692ddb867b5f0f78c3eb6d20a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":6,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":7,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":8,"context_line":"pbr\u003e\u003d4.0.0 # Apache-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"eventlet!\u003d0.18.3,!\u003d0.20.1,\u003e\u003d0.18.2 # MIT"},{"line_number":11,"context_line":"netaddr\u003e\u003d0.7.18 # BSD"}],"source_content_type":"text/plain","patch_set":1,"id":"5cde27df_0c13b122","side":"PARENT","line":8,"in_reply_to":"c83d961d_1dc3c101","updated":"2024-02-09 16:49:49.000000000","message":"Done","commit_id":"3fe92291f257a09607e31c949a08fca13a2110d1"}]}
