)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b8fc8a99d9bbdd77f68b1b555f1101ad8a1bbf18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5aff7ddd_766b0a4b","updated":"2026-01-27 08:27:46.000000000","message":"Minor comments","commit_id":"38c6ea9529a993c50bdd4e7b84264a3156cdb5fa"}],"neutron_fwaas/services/firewall/service_drivers/ovn/ovn_db_sync.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b8fc8a99d9bbdd77f68b1b555f1101ad8a1bbf18","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        # Neutron DB"},{"line_number":145,"context_line":"        for fw_group in groups_to_remove.values():"},{"line_number":146,"context_line":"            pg_name \u003d ovn_utils.ovn_port_group_name(fw_group[\u0027id\u0027])"},{"line_number":147,"context_line":"            with self.ovn_nb_api.transaction(check_error\u003dTrue) as txn:"},{"line_number":148,"context_line":"                if self.ovn_nb_api.get_port_group(pg_name):"},{"line_number":149,"context_line":"                    txn.add("},{"line_number":150,"context_line":"                        self.ovn_nb_api.pg_del(name\u003dpg_name, if_exists\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7b1a55_b6ed8dd4","line":147,"range":{"start_line":147,"start_character":12,"end_line":147,"end_character":69},"updated":"2026-01-27 08:27:46.000000000","message":"just asking: would be better to create the txn context before the `for fw_group in...` loop? Just to create one single txn with several operations.\n\nSame comment in the previous loop.","commit_id":"38c6ea9529a993c50bdd4e7b84264a3156cdb5fa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dd4f4357a3cdb6956d7c45d18cd7a69dd9f0ceef","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        # Neutron DB"},{"line_number":145,"context_line":"        for fw_group in groups_to_remove.values():"},{"line_number":146,"context_line":"            pg_name \u003d ovn_utils.ovn_port_group_name(fw_group[\u0027id\u0027])"},{"line_number":147,"context_line":"            with self.ovn_nb_api.transaction(check_error\u003dTrue) as txn:"},{"line_number":148,"context_line":"                if self.ovn_nb_api.get_port_group(pg_name):"},{"line_number":149,"context_line":"                    txn.add("},{"line_number":150,"context_line":"                        self.ovn_nb_api.pg_del(name\u003dpg_name, if_exists\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":6,"id":"84234234_d6905df9","line":147,"range":{"start_line":147,"start_character":12,"end_line":147,"end_character":69},"in_reply_to":"ba7b1a55_b6ed8dd4","updated":"2026-01-27 09:58:06.000000000","message":"done","commit_id":"38c6ea9529a993c50bdd4e7b84264a3156cdb5fa"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"511a606f1c65c28788a1f455c25c006b62f498da","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# TODO(slaweq): use base class from neutron-lib once"},{"line_number":37,"context_line":"# https://review.opendev.org/c/openstack/neutron-lib/+/970267 will be merged"},{"line_number":38,"context_line":"# and released"},{"line_number":39,"context_line":"class OvnNbDbSync(base_ovn_db_sync.BaseOvnDbSynchronizer):"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"eef6d46d_405f8454","line":37,"range":{"start_line":37,"start_character":2,"end_line":37,"end_character":61},"updated":"2026-01-28 11:17:59.000000000","message":"as I see it is already released as 3.23.0, so as a follow-up can be handled later","commit_id":"918acde5f16054a3c3db7782ff480d074a4408cf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"029120713362accdda4d9c294c93cf7b3c84e61f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# TODO(slaweq): use base class from neutron-lib once"},{"line_number":37,"context_line":"# https://review.opendev.org/c/openstack/neutron-lib/+/970267 will be merged"},{"line_number":38,"context_line":"# and released"},{"line_number":39,"context_line":"class OvnNbDbSync(base_ovn_db_sync.BaseOvnDbSynchronizer):"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"10044fe3_ff63c7cc","line":37,"range":{"start_line":37,"start_character":2,"end_line":37,"end_character":61},"in_reply_to":"eef6d46d_405f8454","updated":"2026-01-28 11:44:50.000000000","message":"yes, but it will be easier for me to merge it like that and backport in downstream and then do follow up in master branch. That\u0027s why I left this TODO here for now","commit_id":"918acde5f16054a3c3db7782ff480d074a4408cf"}],"neutron_fwaas/tests/functional/services/firewall/ovn/test_ovn_db_sync.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b8fc8a99d9bbdd77f68b1b555f1101ad8a1bbf18","unresolved":true,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def test_ovn_db_sync_port_group_deleted_no_restart_ovsdb(self):"},{"line_number":300,"context_line":"        self._test_ovn_db_sync_port_group_deleted("},{"line_number":301,"context_line":"            restart_ovsdb_processes\u003dFalse)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def test_ovn_db_sync_port_group_deleted_restart_ovsdb(self):"},{"line_number":304,"context_line":"        self._test_ovn_db_sync_port_group_deleted(restart_ovsdb_processes\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"69a93d9d_a4c1a42e","line":301,"range":{"start_line":301,"start_character":12,"end_line":301,"end_character":41},"updated":"2026-01-27 08:27:46.000000000","message":"nit: restart_ovsdb_processes\u003dFalse is the default value","commit_id":"38c6ea9529a993c50bdd4e7b84264a3156cdb5fa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dd4f4357a3cdb6956d7c45d18cd7a69dd9f0ceef","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def test_ovn_db_sync_port_group_deleted_no_restart_ovsdb(self):"},{"line_number":300,"context_line":"        self._test_ovn_db_sync_port_group_deleted("},{"line_number":301,"context_line":"            restart_ovsdb_processes\u003dFalse)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def test_ovn_db_sync_port_group_deleted_restart_ovsdb(self):"},{"line_number":304,"context_line":"        self._test_ovn_db_sync_port_group_deleted(restart_ovsdb_processes\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"74fd5bff_b35d6851","line":301,"range":{"start_line":301,"start_character":12,"end_line":301,"end_character":41},"in_reply_to":"69a93d9d_a4c1a42e","updated":"2026-01-27 09:58:06.000000000","message":"Done","commit_id":"38c6ea9529a993c50bdd4e7b84264a3156cdb5fa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"36f7c8ed96286fcf7910b779ffea035be73d9b06","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def test_ovn_db_sync_port_group_deleted_no_restart_ovsdb(self):"},{"line_number":300,"context_line":"        self._test_ovn_db_sync_port_group_deleted("},{"line_number":301,"context_line":"            restart_ovsdb_processes\u003dFalse)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def test_ovn_db_sync_port_group_deleted_restart_ovsdb(self):"},{"line_number":304,"context_line":"        self._test_ovn_db_sync_port_group_deleted(restart_ovsdb_processes\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"a9ed0984_f8ca8bbf","line":301,"range":{"start_line":301,"start_character":12,"end_line":301,"end_character":41},"in_reply_to":"74fd5bff_b35d6851","updated":"2026-01-27 11:57:53.000000000","message":"actually it is not for that helper methods so I had to restore setting it here 😊","commit_id":"38c6ea9529a993c50bdd4e7b84264a3156cdb5fa"}],"pyproject.toml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b8fc8a99d9bbdd77f68b1b555f1101ad8a1bbf18","unresolved":true,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"[project.entry-points.\"neutron.status.upgrade.checks\"]"},{"line_number":83,"context_line":"neutron_fwaas \u003d \"neutron_fwaas.cmd.upgrade_checks.checks:Checks\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"[project.entry-points.\"neutron.ovn.db_sync\"]"},{"line_number":86,"context_line":"neutron_fwaas_nb_sync \u003d \"neutron_fwaas.services.firewall.service_drivers.ovn.ovn_db_sync:OvnNbDbSync\""}],"source_content_type":"text/x-toml","patch_set":6,"id":"d7a10172_887ad80a","line":84,"updated":"2026-01-27 08:27:46.000000000","message":"nit: add a new line at the end","commit_id":"38c6ea9529a993c50bdd4e7b84264a3156cdb5fa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dd4f4357a3cdb6956d7c45d18cd7a69dd9f0ceef","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"[project.entry-points.\"neutron.status.upgrade.checks\"]"},{"line_number":83,"context_line":"neutron_fwaas \u003d \"neutron_fwaas.cmd.upgrade_checks.checks:Checks\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"[project.entry-points.\"neutron.ovn.db_sync\"]"},{"line_number":86,"context_line":"neutron_fwaas_nb_sync \u003d \"neutron_fwaas.services.firewall.service_drivers.ovn.ovn_db_sync:OvnNbDbSync\""}],"source_content_type":"text/x-toml","patch_set":6,"id":"02c1a461_4854c67d","line":84,"in_reply_to":"d7a10172_887ad80a","updated":"2026-01-27 09:58:06.000000000","message":"Done","commit_id":"38c6ea9529a993c50bdd4e7b84264a3156cdb5fa"}]}