)]}'
{"neutron_lbaas/drivers/haproxy/namespace_driver.py":[{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"41c302e52c9582bd389b2c9e39869cbd99516299","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        # send gratuitous ARP to flush the ARP cache in the Router."},{"line_number":322,"context_line":"        if gw_ip and self.conf.haproxy.send_gratuitous_arp \u003e 0:"},{"line_number":323,"context_line":"            gratuitous_arp \u003d self.conf.haproxy.send_gratuitous_arp"},{"line_number":324,"context_line":"            # TODO(ANILVENKATA) should we send garp for only vip address"},{"line_number":325,"context_line":"            for ip in port.fixed_ips:"},{"line_number":326,"context_line":"                # when IPv6 address is added, it will send neighbour"},{"line_number":327,"context_line":"                # solicitation, so not required this for IPv6."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_424bec59","line":324,"updated":"2015-05-29 21:32:47.000000000","message":"What do you need to do to resolve to TODO?  It seems to me like we should be OK only sending the garp for the VIP, re-adding the vip shouldn\u0027t have affected the fixed ips, correct?   But one good test is worth 1000 opinions....","commit_id":"58fc9b2323ecb2e4ffe5f6ae6aaafae69cadb8ed"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"c516170866b757f6a912de740618ede453b0a5a1","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        # send gratuitous ARP to flush the ARP cache in the Router."},{"line_number":322,"context_line":"        if gw_ip and self.conf.haproxy.send_gratuitous_arp \u003e 0:"},{"line_number":323,"context_line":"            gratuitous_arp \u003d self.conf.haproxy.send_gratuitous_arp"},{"line_number":324,"context_line":"            # TODO(ANILVENKATA) should we send garp for only vip address"},{"line_number":325,"context_line":"            for ip in port.fixed_ips:"},{"line_number":326,"context_line":"                # when IPv6 address is added, it will send neighbour"},{"line_number":327,"context_line":"                # solicitation, so not required this for IPv6."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_13a14594","line":324,"in_reply_to":"7a016987_424bec59","updated":"2015-06-01 12:18:55.000000000","message":"Yes, only sending the garp for the VIP. \nIf a port has many fixed_ips, then the spec \n\nhttp://specs.openstack.org/openstack/neutron-specs/specs/juno-incubator/lbaas-api-and-objmodel-improvement.html\n\nsays - \"If a neutron port is encountered that has many fixed_ips then a load balancer should be created for each fixed_ip with each being a deep copy of each other.\"\n\nBut this is not yet implemented.\n \nMay be we should take care of this TODO while enhancing LBaaS for \"port with many fixed_ips\" use case.\n \nI will remove this TODO from the code, as it is creating confusion.","commit_id":"58fc9b2323ecb2e4ffe5f6ae6aaafae69cadb8ed"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1607c34be1dca6c9086082119d4add9774fda7d0","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def create(self, loadbalancer):"},{"line_number":200,"context_line":"        namespace \u003d get_ns_name(loadbalancer.id)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        self._plug(namespace, loadbalancer.vip_port, loadbalancer.vip_address)"},{"line_number":203,"context_line":"        self._spawn(loadbalancer)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def deployable(self, loadbalancer):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_3486b9db","line":202,"updated":"2015-06-04 12:06:02.000000000","message":"This same change is done in https://review.openstack.org/185556\n\nIt would make more sense to base this patch on that one.","commit_id":"fb528a75e1f55f1955f48611e2615107742cd263"}]}