)]}'
{"neutron_lbaas/tests/unit/drivers/octavia/test_octavia_driver.py":[{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e73b624abcc7bda60bab0ced30c532c37fdcc4dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a4dcd0f_70e4ccab","updated":"2015-08-08 05:36:17.000000000","message":"Please add Apache license as shown here http://docs.openstack.org/developer/hacking/#openstack-licensing","commit_id":"3f2fcd2480951e05bec7ef2b658e3cfc5dd8d8b2"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e73b624abcc7bda60bab0ced30c532c37fdcc4dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import sys"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import mock"},{"line_number":4,"context_line":"from neutron import context"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_10d548b8","line":1,"updated":"2015-08-08 05:36:17.000000000","message":"Remove this import. You are not using it anywhere.","commit_id":"3f2fcd2480951e05bec7ef2b658e3cfc5dd8d8b2"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e73b624abcc7bda60bab0ced30c532c37fdcc4dd","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"from neutron_lbaas.tests.unit.db.loadbalancer import test_db_loadbalancerv2"},{"line_number":7,"context_line":"from neutron_lbaas.services.loadbalancer import data_models"},{"line_number":8,"context_line":"from neutron_lbaas.drivers.octavia import driver"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"class ManagerTest(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_30ede48e","line":8,"updated":"2015-08-08 05:36:17.000000000","message":"Reorder imports according to alphabetical order\n\nfrom neutron_lbaas.drivers.octavia import driver\n\nfrom neutron_lbaas.services.loadbalancer import data_models\n\nfrom neutron_lbaas.tests.unit.db.loadbalancer import test_db_loadbalancerv2\n\n\nThere is no driver named \"octavia\" in master. https://github.com/openstack/neutron-lbaas/tree/master/neutron_lbaas/drivers","commit_id":"3f2fcd2480951e05bec7ef2b658e3cfc5dd8d8b2"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e73b624abcc7bda60bab0ced30c532c37fdcc4dd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.manager.delete(self.context, model)"},{"line_number":29,"context_line":"        self.mocked_req.delete.assert_called_with(url)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # TODO"},{"line_number":32,"context_line":"    def refresh(self):"},{"line_number":33,"context_line":"        pass"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_b001f43b","line":31,"updated":"2015-08-08 05:36:17.000000000","message":"What TODO??\nPlease complete this line.\nhttp://docs.openstack.org/developer/hacking/#general\n\nLike\n\n#TODO(your_launchpad_name): Blah blah blah","commit_id":"3f2fcd2480951e05bec7ef2b658e3cfc5dd8d8b2"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e73b624abcc7bda60bab0ced30c532c37fdcc4dd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def refresh(self):"},{"line_number":33,"context_line":"        pass"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # TODO"},{"line_number":36,"context_line":"    def stats(self):"},{"line_number":37,"context_line":"        pass"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_70fb6c48","line":35,"updated":"2015-08-08 05:36:17.000000000","message":"What TODO?? Please complete this line. http://docs.openstack.org/developer/hacking/#general\n\nLike\n\n#TODO(your_launchpad_name): Blah blah blah","commit_id":"3f2fcd2480951e05bec7ef2b658e3cfc5dd8d8b2"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e73b624abcc7bda60bab0ced30c532c37fdcc4dd","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # urls for assert test."},{"line_number":113,"context_line":"        list_url \u003d \u0027/v1/loadbalancers/%s/listeners\u0027 % listener.loadbalancer.id"},{"line_number":114,"context_line":"        list_url_id \u003d list_url +\u0027/%s\u0027 % (listener.id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Create Listener test."},{"line_number":117,"context_line":"        # args for create and update assert."}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_309404e7","line":114,"updated":"2015-08-08 05:36:17.000000000","message":"Please add a whitespace after \u0027+\u0027 operator.","commit_id":"3f2fcd2480951e05bec7ef2b658e3cfc5dd8d8b2"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e73b624abcc7bda60bab0ced30c532c37fdcc4dd","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        pool \u003d self.lb.listeners[0].default_pool"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        # urls for assert test."},{"line_number":144,"context_line":"        pool_url  \u003d \u0027/v1/loadbalancers/%s/listeners/%s/pools\u0027 % ("},{"line_number":145,"context_line":"            pool.listener.loadbalancer.id,"},{"line_number":146,"context_line":"            pool.listener.id)"},{"line_number":147,"context_line":"        pool_url_id \u003d pool_url + \"/%s\" % pool.id"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_5099901e","line":144,"updated":"2015-08-08 05:36:17.000000000","message":"Please remove one whitespace after pool_url","commit_id":"3f2fcd2480951e05bec7ef2b658e3cfc5dd8d8b2"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"bf9aa7fd624a0ef6f1cdba71bd92f9ae6843b900","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015, Banashankar Veerad, Copyright IBM Corporation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4dcd0f_9e96593d","line":1,"updated":"2015-08-13 16:30:11.000000000","message":"Please remove this copyright(Refer PEP8 rules). :)","commit_id":"a0316c51445debabfb3e10b4b019665c25a2d6ed"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"2df4db6f357aff78049568e5cec0be3a7540cb9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015, Banashankar Veerad, Copyright IBM Corporation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4dcd0f_84204cb2","line":1,"in_reply_to":"1a4dcd0f_613df22b","updated":"2015-08-13 17:13:48.000000000","message":"Apologies for incomplete comment,\nAdd proper Copyright like this https://github.com/openstack/neutron-lbaas/blob/8d4e6a44d4553b9242b7973c6d89bf182c4774a3/neutron_lbaas/tests/tempest/lib/common/tempest_fixtures.py#L1-Lundefined\nor remove it.","commit_id":"a0316c51445debabfb3e10b4b019665c25a2d6ed"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"9e277ee7abbf919e86795404745fa3bd813a7207","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015, Banashankar Veerad, Copyright IBM Corporation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4dcd0f_55fe6caf","line":1,"in_reply_to":"1a4dcd0f_84204cb2","updated":"2015-08-13 18:03:39.000000000","message":"I followed this https://github.com/openstack/neutron-lbaas/blob/8d4e6a44d4553b9242b7973c6d89bf182c4774a3/neutron_lbaas/tests/unit/drivers/a10networks/test_driver_v2.py","commit_id":"a0316c51445debabfb3e10b4b019665c25a2d6ed"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"76332425c75aff216bdf27ec5024f9aaaa4c5b7c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015, Banashankar Veerad, Copyright IBM Corporation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4dcd0f_613df22b","line":1,"in_reply_to":"1a4dcd0f_9e96593d","updated":"2015-08-13 16:45:58.000000000","message":"Why should the copyright line be removed?  What PEP8 rule specifies that?","commit_id":"a0316c51445debabfb3e10b4b019665c25a2d6ed"}]}