)]}'
{"neutron_lbaas/drivers/common/agent_callbacks.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"1b2f3d22bfc7cab6a954c7675591f955f23764ce","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            return"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        port[\u0027admin_state_up\u0027] \u003d True"},{"line_number":167,"context_line":"        port[\u0027device_owner\u0027] \u003d \u0027neutron:\u0027 + constants.LOADBALANCERV2"},{"line_number":168,"context_line":"        port[portbindings.HOST_ID] \u003d host"},{"line_number":169,"context_line":"        self.plugin.db._core_plugin.update_port("},{"line_number":170,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_2526f568","line":167,"updated":"2015-09-14 17:41:17.000000000","message":"thsi should probably be removed as well since that is also done (and has a different value). could you remove this piece too?  I know its a bit outside of the scope of your review but i think its still similar enough to do.","commit_id":"2e6641f922d066c6745b75da0215df1dd2e3fce2"},{"author":{"_account_id":11701,"name":"Divya ChanneGowda","email":"divya.hc@gmail.com","username":"divyahc"},"change_message_id":"56c4594d88f04847b600e34b3be52ca76cd4d147","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            return"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        port[\u0027admin_state_up\u0027] \u003d True"},{"line_number":167,"context_line":"        port[\u0027device_owner\u0027] \u003d \u0027neutron:\u0027 + constants.LOADBALANCERV2"},{"line_number":168,"context_line":"        port[portbindings.HOST_ID] \u003d host"},{"line_number":169,"context_line":"        self.plugin.db._core_plugin.update_port("},{"line_number":170,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_26759cf8","line":167,"in_reply_to":"ba15a1d1_2526f568","updated":"2015-09-14 18:35:45.000000000","message":"Done","commit_id":"2e6641f922d066c6745b75da0215df1dd2e3fce2"}],"neutron_lbaas/drivers/haproxy/synchronous_namespace_driver.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"1b2f3d22bfc7cab6a954c7675591f955f23764ce","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def _build_port_dict(self):"},{"line_number":149,"context_line":"        return {\u0027admin_state_up\u0027: True,"},{"line_number":150,"context_line":"                \u0027device_owner\u0027: \u0027neutron:{0}\u0027.format("},{"line_number":151,"context_line":"                    constants.LOADBALANCER),"},{"line_number":152,"context_line":"                portbindings.HOST_ID: self.conf.host}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _get_state_file_path(self, loadbalancer_id, kind,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_e520fd4b","line":151,"updated":"2015-09-14 17:41:17.000000000","message":"same as other file.","commit_id":"2e6641f922d066c6745b75da0215df1dd2e3fce2"},{"author":{"_account_id":11701,"name":"Divya ChanneGowda","email":"divya.hc@gmail.com","username":"divyahc"},"change_message_id":"56c4594d88f04847b600e34b3be52ca76cd4d147","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def _build_port_dict(self):"},{"line_number":149,"context_line":"        return {\u0027admin_state_up\u0027: True,"},{"line_number":150,"context_line":"                \u0027device_owner\u0027: \u0027neutron:{0}\u0027.format("},{"line_number":151,"context_line":"                    constants.LOADBALANCER),"},{"line_number":152,"context_line":"                portbindings.HOST_ID: self.conf.host}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _get_state_file_path(self, loadbalancer_id, kind,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_a65f6c71","line":151,"in_reply_to":"ba15a1d1_e520fd4b","updated":"2015-09-14 18:35:45.000000000","message":"Done","commit_id":"2e6641f922d066c6745b75da0215df1dd2e3fce2"}],"neutron_lbaas/services/loadbalancer/drivers/common/agent_driver_base.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"3ed2cd209442a2f622ef640c6df01e12b37f1af1","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        port[\u0027admin_state_up\u0027] \u003d True"},{"line_number":194,"context_line":"        port[\u0027device_owner\u0027] \u003d \u0027neutron:\u0027 + constants.LOADBALANCER"},{"line_number":195,"context_line":"        port[\u0027device_id\u0027] \u003d str(uuid.uuid5(uuid.NAMESPACE_DNS, str(host)))"},{"line_number":196,"context_line":"        port[portbindings.HOST_ID] \u003d host"},{"line_number":197,"context_line":"        self.plugin._core_plugin.update_port("},{"line_number":198,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_70d1ffcc","side":"PARENT","line":195,"updated":"2015-09-14 23:32:15.000000000","message":"sorry i didnt catch this earlier, but this is for lbaas v1 and will remove the device_id from ever being populated when using the namespace driver.  I would suggest just leaving the line here and not removing it.  I suppose the right thing to do would be to also fix the v1 code so that device_id and device_owner are populated immediately on the vip creation, but I\u0027d rather get this in for v2.\n\nfor future refernce, anything in the service/loadbalancer/drivers is a v1 driver and will eventually be deprecated and removed.","commit_id":"5e1aaf39cb3c23000ed1e380d5aaeaeaaefcc05e"},{"author":{"_account_id":11701,"name":"Divya ChanneGowda","email":"divya.hc@gmail.com","username":"divyahc"},"change_message_id":"3c680cc434123ea7c621ad8bfe5534c25df8651b","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        port[\u0027admin_state_up\u0027] \u003d True"},{"line_number":194,"context_line":"        port[\u0027device_owner\u0027] \u003d \u0027neutron:\u0027 + constants.LOADBALANCER"},{"line_number":195,"context_line":"        port[\u0027device_id\u0027] \u003d str(uuid.uuid5(uuid.NAMESPACE_DNS, str(host)))"},{"line_number":196,"context_line":"        port[portbindings.HOST_ID] \u003d host"},{"line_number":197,"context_line":"        self.plugin._core_plugin.update_port("},{"line_number":198,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_b6af6493","side":"PARENT","line":195,"in_reply_to":"ba15a1d1_70d1ffcc","updated":"2015-09-15 18:51:06.000000000","message":"Done","commit_id":"5e1aaf39cb3c23000ed1e380d5aaeaeaaefcc05e"}],"neutron_lbaas/tests/unit/drivers/common/test_agent_callbacks.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2826d1b11a87f4b9c30585bff26d5eb7ae3c66d7","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def _update_port_test_helper(self, expected, func, **kwargs):"},{"line_number":161,"context_line":"        core \u003d self.plugin_instance.db._core_plugin"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        with self.loadbalancer() as loadbalancer:"},{"line_number":164,"context_line":"            lb_id \u003d loadbalancer[\u0027loadbalancer\u0027][\u0027id\u0027]"},{"line_number":165,"context_line":"            self.plugin_instance.db.update_loadbalancer_provisioning_status("},{"line_number":166,"context_line":"                context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_d1174352","line":163,"updated":"2015-09-11 19:24:30.000000000","message":"Perhaps update the expected[\u0027device_id\u0027] with the loadbalancer[\u0027loadbalancer\u0027][\u0027id\u0027] here, just to make sure it\u0027s set in the output?","commit_id":"2bad371bf19bb4ad1ab5e51b8995bf86eb4ba980"},{"author":{"_account_id":11701,"name":"Divya ChanneGowda","email":"divya.hc@gmail.com","username":"divyahc"},"change_message_id":"76be6d81d5cffd8cea2460aec1a3688e6d934931","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def _update_port_test_helper(self, expected, func, **kwargs):"},{"line_number":161,"context_line":"        core \u003d self.plugin_instance.db._core_plugin"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        with self.loadbalancer() as loadbalancer:"},{"line_number":164,"context_line":"            lb_id \u003d loadbalancer[\u0027loadbalancer\u0027][\u0027id\u0027]"},{"line_number":165,"context_line":"            self.plugin_instance.db.update_loadbalancer_provisioning_status("},{"line_number":166,"context_line":"                context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ddb512d0","line":163,"in_reply_to":"da20952f_d1174352","updated":"2015-09-11 21:53:49.000000000","message":"_update_port_test_helper also called in  test_unplug_vip_port.\nin case of test_unplug, device_id is empty and setting the device_id to lb_id, aseert fails for unplug_vip test case. Added to update expected only for plug_vip case.","commit_id":"2bad371bf19bb4ad1ab5e51b8995bf86eb4ba980"}]}