)]}'
{"neutron_lbaas/_i18n.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8632bb08465390aeb955708bc2800716a1534a18","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Translators for log levels."},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# The abbreviated names are meant to reflect the usual use of a short"},{"line_number":33,"context_line":"# name like \u0027_\u0027. The \"L\" is for \"log\" and the other letter comes from"},{"line_number":34,"context_line":"# the level."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_3f568308","line":32,"updated":"2017-05-03 19:28:11.000000000","message":"the comment should go","commit_id":"623b3748a2c423143baf755cd7c26e15877b21b5"}],"neutron_lbaas/agent/agent_manager.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"95fc128f314b4079c058746b05201e8855d566f3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            self.state_rpc.report_state(self.context, self.agent_state)"},{"line_number":124,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":125,"context_line":"        except Exception:"},{"line_number":126,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def initialize_service_hook(self, started_by):"},{"line_number":129,"context_line":"        self.sync_state()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_427be226","line":126,"range":{"start_line":126,"start_character":26,"end_line":126,"end_character":28},"updated":"2017-04-29 02:07:15.000000000","message":"why do you use _() in some places and not in others?","commit_id":"623b3748a2c423143baf755cd7c26e15877b21b5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8632bb08465390aeb955708bc2800716a1534a18","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            self.state_rpc.report_state(self.context, self.agent_state)"},{"line_number":124,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":125,"context_line":"        except Exception:"},{"line_number":126,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def initialize_service_hook(self, started_by):"},{"line_number":129,"context_line":"        self.sync_state()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_bf6293d7","line":126,"range":{"start_line":126,"start_character":26,"end_line":126,"end_character":28},"in_reply_to":"5ff73747_427be226","updated":"2017-05-03 19:28:11.000000000","message":"+","commit_id":"623b3748a2c423143baf755cd7c26e15877b21b5"}],"neutron_lbaas/agent_scheduler.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d891b50fa216140cd0295c07bb478dda4b3bb7eb","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            active_agents \u003d plugin.db.get_lbaas_agents(context, active\u003dTrue)"},{"line_number":133,"context_line":"            if not active_agents:"},{"line_number":134,"context_line":"                LOG.warning("},{"line_number":135,"context_line":"                    \u0027No active lbaas agents for load balancer %s\u0027,"},{"line_number":136,"context_line":"                    loadbalancer.id)"},{"line_number":137,"context_line":"                return"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            candidates \u003d plugin.db.get_lbaas_agent_candidates(device_driver,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_fc4f2468","line":136,"range":{"start_line":135,"start_character":19,"end_line":136,"end_character":36},"updated":"2017-03-23 08:15:48.000000000","message":"can we use _() here?","commit_id":"1250abbd25ce89dc7b224bc440f24abfdfac18fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d891b50fa216140cd0295c07bb478dda4b3bb7eb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            candidates \u003d plugin.db.get_lbaas_agent_candidates(device_driver,"},{"line_number":140,"context_line":"                                                              active_agents)"},{"line_number":141,"context_line":"            if not candidates:"},{"line_number":142,"context_line":"                LOG.warning(\u0027No lbaas agent supporting device driver %s\u0027,"},{"line_number":143,"context_line":"                            device_driver)"},{"line_number":144,"context_line":"                return"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_3c561c06","line":142,"range":{"start_line":142,"start_character":26,"end_line":142,"end_character":39},"updated":"2017-03-23 08:15:48.000000000","message":"ditto","commit_id":"1250abbd25ce89dc7b224bc440f24abfdfac18fe"}],"neutron_lbaas/common/cert_manager/local_cert_manager.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        filename_base \u003d os.path.join(CONF.certificates.storage_path, cert_ref)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        LOG.info("},{"line_number":88,"context_line":"            \"Storing certificate data on the local filesystem.\""},{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":"        try:"},{"line_number":91,"context_line":"            filename_certificate \u003d \"{0}.crt\".format(filename_base)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_46a96a79","line":88,"updated":"2017-05-04 16:54:02.000000000","message":"would prolly fit single line","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"}],"neutron_lbaas/drivers/common/agent_callbacks.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            if not agents:"},{"line_number":44,"context_line":"                return []"},{"line_number":45,"context_line":"            elif len(agents) \u003e 1:"},{"line_number":46,"context_line":"                LOG.warning(\u0027Multiple lbaas agents found on host %s\u0027,"},{"line_number":47,"context_line":"                            host)"},{"line_number":48,"context_line":"            loadbalancers \u003d self.plugin.db.list_loadbalancers_on_lbaas_agent("},{"line_number":49,"context_line":"                context, agents[0].id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_e6e636e9","line":46,"updated":"2017-05-04 16:54:02.000000000","message":"would fit single line","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def update_status(self, context, obj_type, obj_id,"},{"line_number":121,"context_line":"                      provisioning_status\u003dNone, operating_status\u003dNone):"},{"line_number":122,"context_line":"        if not provisioning_status and not operating_status:"},{"line_number":123,"context_line":"            LOG.warning((\u0027update_status for %(obj_type)s %(obj_id)s called \u0027"},{"line_number":124,"context_line":"                         \u0027without specifying provisioning_status or \u0027"},{"line_number":125,"context_line":"                         \u0027operating_status\u0027) % {\u0027obj_type\u0027: obj_type,"},{"line_number":126,"context_line":"                                                \u0027obj_id\u0027: obj_id})"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_26065e88","line":123,"range":{"start_line":123,"start_character":24,"end_line":123,"end_character":25},"updated":"2017-05-04 16:54:02.000000000","message":"those are redundant","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"}],"neutron_lbaas/drivers/radware/exceptions.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class RadwareLBaasV2Exception(exceptions.LbaasException):"},{"line_number":20,"context_line":"    message \u003d _(\u0027An unknown exception occurred in \u0027"},{"line_number":21,"context_line":"               \u0027Radware LBaaS v2 provider.\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_c6045a7e","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":15},"updated":"2017-05-04 16:54:02.000000000","message":"and where do you import it?","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"}],"neutron_lbaas/drivers/radware/rest_client.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _flip_servers(self):"},{"line_number":65,"context_line":"        LOG.warning(\u0027Flipping servers. Current is: %(server)s, \u0027"},{"line_number":66,"context_line":"                 \u0027switching to %(secondary)s\u0027,"},{"line_number":67,"context_line":"                 {\u0027server\u0027: self.server,"},{"line_number":68,"context_line":"                 \u0027secondary\u0027: self.secondary_server})"},{"line_number":69,"context_line":"        self.server, self.secondary_server \u003d self.secondary_server, self.server"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_86f6528f","line":66,"updated":"2017-05-04 16:54:02.000000000","message":"could fix wrapping here while at it","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"}],"neutron_lbaas/drivers/radware/v2_driver.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                LOG.debug(\u0027Proxy port for LB %s was deleted\u0027, lb.id)"},{"line_number":308,"context_line":"            except Exception:"},{"line_number":309,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":310,"context_line":"                    LOG.error(\u0027Proxy port deletion for LB %s \u0027"},{"line_number":311,"context_line":"                              \u0027failed\u0027, lb.id)"},{"line_number":312,"context_line":"            manager.successful_completion(ctx, lb, delete\u003dTrue)"},{"line_number":313,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_6648e6cb","line":310,"updated":"2017-05-04 16:54:02.000000000","message":"could probably join the string on a single line now","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        proxy_port \u003d self._get_proxy_port(ctx, lb)"},{"line_number":482,"context_line":"        if proxy_port:"},{"line_number":483,"context_line":"            LOG.info(\u0027LB %(lb_id)s proxy port exists on subnet \\"},{"line_number":484,"context_line":"                     %(subnet_id)s with ip address %(ip_address)s\u0027 %"},{"line_number":485,"context_line":"                     {\u0027lb_id\u0027: lb.id, \u0027subnet_id\u0027: proxy_port[\u0027subnet_id\u0027],"},{"line_number":486,"context_line":"                      \u0027ip_address\u0027: proxy_port[\u0027ip_address\u0027]})"},{"line_number":487,"context_line":"            return proxy_port"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_c6121ab2","line":484,"range":{"start_line":484,"start_character":0,"end_line":484,"end_character":21},"updated":"2017-05-04 16:54:02.000000000","message":"(No action required) this is messed, it means all those spaces are part of the message!","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        proxy_port_ip_data \u003d proxy_port[\u0027fixed_ips\u0027][0]"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        LOG.info(\u0027LB %(lb_id)s proxy port created on subnet %(subnet_id)s \\"},{"line_number":507,"context_line":"                 with ip address %(ip_address)s\u0027 %"},{"line_number":508,"context_line":"                 {\u0027lb_id\u0027: lb.id, \u0027subnet_id\u0027: proxy_port_ip_data[\u0027subnet_id\u0027],"},{"line_number":509,"context_line":"                  \u0027ip_address\u0027: proxy_port_ip_data[\u0027ip_address\u0027]})"},{"line_number":510,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_461e0abb","line":507,"updated":"2017-05-04 16:54:02.000000000","message":"(No action required) ditto","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":530,"context_line":"            proxy_port_ip_data \u003d proxy_port[\u0027fixed_ips\u0027][0]"},{"line_number":531,"context_line":"            try:"},{"line_number":532,"context_line":"                LOG.info(\u0027Deleting LB %(lb_id)s proxy port on subnet  \\"},{"line_number":533,"context_line":"                             %(subnet_id)s with ip address %(ip_address)s\u0027 %"},{"line_number":534,"context_line":"                         {\u0027lb_id\u0027: lb.id,"},{"line_number":535,"context_line":"                          \u0027subnet_id\u0027: proxy_port_ip_data[\u0027subnet_id\u0027],"},{"line_number":536,"context_line":"                          \u0027ip_address\u0027: proxy_port_ip_data[\u0027ip_address\u0027]})"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_067ec2e3","line":533,"updated":"2017-05-04 16:54:02.000000000","message":"ditto","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"}],"neutron_lbaas/services/loadbalancer/plugin.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        except KeyError:"},{"line_number":138,"context_line":"            # raise if not associated (should never be reached)"},{"line_number":139,"context_line":"            raise n_exc.Invalid(_(\"Error retrieving driver for provider \""},{"line_number":140,"context_line":"                                \"%s\") % provider)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _get_driver_for_loadbalancer(self, context, loadbalancer_id):"},{"line_number":143,"context_line":"        lb \u003d self.db.get_loadbalancer(context, loadbalancer_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_6676a609","line":140,"updated":"2017-05-04 16:54:02.000000000","message":"(No action required) would be nice to join strings in single line","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"}],"neutron_lbaas/tests/tempest/v2/api/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        super(BaseTestCase, cls).setUpClass()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def setUp(cls):"},{"line_number":135,"context_line":"        cls.LOG.info((\u0027Starting: {0}\u0027).format(cls._testMethodName))"},{"line_number":136,"context_line":"        super(BaseTestCase, cls).setUp()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def tearDown(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_e65bd684","line":135,"range":{"start_line":135,"start_character":21,"end_line":135,"end_character":22},"updated":"2017-05-04 16:54:02.000000000","message":"nit: those are not needed","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def tearDown(cls):"},{"line_number":139,"context_line":"        super(BaseTestCase, cls).tearDown()"},{"line_number":140,"context_line":"        cls.LOG.info((\u0027Finished: {0}\\n\u0027).format(cls._testMethodName))"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @classmethod"},{"line_number":143,"context_line":"    def _create_load_balancer(cls, wait\u003dTrue, **lb_kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_a655ce52","line":140,"range":{"start_line":140,"start_character":21,"end_line":140,"end_character":22},"updated":"2017-05-04 16:54:02.000000000","message":"ditto","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"}],"tox.ini":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf9d3b550cca5e8601ff2997750f054d94180b2c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# N524 contextlib.nested is deprecated"},{"line_number":50,"context_line":"# TODO(dougwig) -- uncomment this to test for remaining linkages"},{"line_number":51,"context_line":"# N530 direct neutron imports not allowed"},{"line_number":52,"context_line":"ignore \u003d E125,E126,E128,E129,E265,H404,H405,N524,N530,N531"},{"line_number":53,"context_line":"show-source \u003d true"},{"line_number":54,"context_line":"builtins \u003d _"},{"line_number":55,"context_line":"exclude \u003d .venv,.git,.tox,dist,doc,*lib/python*,*egg,build,tools,.tmp,.ropeproject,rally-scenarios,neutron_lbaas/tests/tempest/lib,neutron_lbaas/tests/tempest/v1/api"}],"source_content_type":"text/x-properties","patch_set":8,"id":"3f044301_e6e99680","line":52,"range":{"start_line":52,"start_character":53,"end_line":52,"end_character":58},"updated":"2017-05-04 16:54:02.000000000","message":"so what is it? you should describe in a comment above. And why?","commit_id":"4ddafdb8f09e3f40411335972c1efe6a7b940b72"}]}
