)]}'
{"neutron_lbaas/drivers/haproxy/namespace_driver.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"5010a919a1d01bb5d278eca92c899c5442348516","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            return"},{"line_number":458,"context_line":"        self.refresh(loadbalancer)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def get_stats(self, loadbalancer_id):"},{"line_number":461,"context_line":"        stats \u003d self.driver.get_stats(loadbalancer_id)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        # NOTE(cgoncalves): haproxy stats include member status which maps to"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_877cddb5","line":460,"range":{"start_line":460,"start_character":8,"end_line":460,"end_character":17},"updated":"2017-11-23 11:53:57.000000000","message":"I\u0027m still testing this and I will follow up with an additional comment, but one thing I want to say here is that I think it would be valuable to have a debug level log here for operators.","commit_id":"a4cb82ef8100ce0de3856d31bcbbf876b4c67f1d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"7e3fc578163d544e2e68514533100c5f2677207a","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            return"},{"line_number":458,"context_line":"        self.refresh(loadbalancer)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def get_stats(self, loadbalancer_id):"},{"line_number":461,"context_line":"        stats \u003d self.driver.get_stats(loadbalancer_id)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        # NOTE(cgoncalves): haproxy stats include member status which maps to"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_c2d653c4","line":460,"range":{"start_line":460,"start_character":8,"end_line":460,"end_character":17},"in_reply_to":"ff82abbf_877cddb5","updated":"2017-11-23 12:37:53.000000000","message":"We don\u0027t want to clog the log every periodic stats collection task regardless if the status has changed or not. I\u0027d rather suggest adding a log debug message in [1] and [2]. \n\n\n[1] https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/db/loadbalancer/loadbalancer_dbv2.py#L261 \n\n[2] https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/db/loadbalancer/loadbalancer_dbv2.py#L264","commit_id":"a4cb82ef8100ce0de3856d31bcbbf876b4c67f1d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"3326e233697b470aad9df12ec3abbcc45bf4a860","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            return"},{"line_number":458,"context_line":"        self.refresh(loadbalancer)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def get_stats(self, loadbalancer_id):"},{"line_number":461,"context_line":"        stats \u003d self.driver.get_stats(loadbalancer_id)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        # NOTE(cgoncalves): haproxy stats include member status which maps to"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_a0eb9275","line":460,"range":{"start_line":460,"start_character":8,"end_line":460,"end_character":17},"in_reply_to":"ff82abbf_c2d653c4","updated":"2017-11-29 12:56:33.000000000","message":"Agreed.\nMy idea was to debug log the member status and you make a valid point. Logging the changes makes more sense here.","commit_id":"a4cb82ef8100ce0de3856d31bcbbf876b4c67f1d"}]}