)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7aff935e113351b12380d62044c547dc9e2c773b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0aba64cb_8363cd86","updated":"2026-08-13 15:18:23.000000000","message":"recheck","commit_id":"98e77d851493e731eaac7af9407e414da5d3d95b"}],"neutron_lib/services/qos/base.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4df1a210a75f7bb4d0c8cf6ada47b8bac47cfe39","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            # trigger is the QosServiceDriverManager"},{"line_number":53,"context_line":"            trigger.register_driver(self)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def is_loaded(self):"},{"line_number":57,"context_line":"        \"\"\"True if the driver is active for the Neutron Server."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"276ac889_e26a0cfe","line":55,"updated":"2026-08-10 09:27:30.000000000","message":"thanks, it is already a property in the OVN driver for example:\nhttps://opendev.org/openstack/neutron/src/branch/master/neutron/services/qos/drivers/ovn/driver.py#L61\n\nQuestion: why not the other is_xy methods?","commit_id":"98e77d851493e731eaac7af9407e414da5d3d95b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6a7697119d8ccf9325d70df819761ca51ca30276","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            # trigger is the QosServiceDriverManager"},{"line_number":53,"context_line":"            trigger.register_driver(self)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def is_loaded(self):"},{"line_number":57,"context_line":"        \"\"\"True if the driver is active for the Neutron Server."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"92f15311_a599f81a","line":55,"in_reply_to":"276ac889_e26a0cfe","updated":"2026-08-11 02:27:33.000000000","message":"The other is_xy methods take an argument so can\u0027t be property.","commit_id":"98e77d851493e731eaac7af9407e414da5d3d95b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"51fb55d126944b9b68943055ca39a87b05f7f16c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            # trigger is the QosServiceDriverManager"},{"line_number":53,"context_line":"            trigger.register_driver(self)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def is_loaded(self):"},{"line_number":57,"context_line":"        \"\"\"True if the driver is active for the Neutron Server."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8f8b8210_8278e49f","line":55,"in_reply_to":"2a36aee6_bcb5bf4f","updated":"2026-08-13 07:56:18.000000000","message":"Acknowledged","commit_id":"98e77d851493e731eaac7af9407e414da5d3d95b"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"5535f96475f202724316783c8ff83130c387bc51","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            # trigger is the QosServiceDriverManager"},{"line_number":53,"context_line":"            trigger.register_driver(self)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def is_loaded(self):"},{"line_number":57,"context_line":"        \"\"\"True if the driver is active for the Neutron Server."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2a36aee6_bcb5bf4f","line":55,"in_reply_to":"92f15311_a599f81a","updated":"2026-08-12 00:51:04.000000000","message":"I think it makes sense. It can be used as a property or a method then.","commit_id":"98e77d851493e731eaac7af9407e414da5d3d95b"}]}
