)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9e37885a54d9c68a185ba40bab155a0f9f34e638","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"So, for example, if we call notify as follows:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_61197179","line":17,"range":{"start_line":17,"start_character":50,"end_line":17,"end_character":55},"updated":"2016-01-16 02:33:39.000000000","message":"This is Python we\u0027re talking about. I think this patch can be safely abandoned, because going to dictionaries is not solving anything.","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bdc2b1570cfabf3395157cc35efaffea6953fa4b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"So, for example, if we call notify as follows:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_b441970d","line":17,"range":{"start_line":17,"start_character":50,"end_line":17,"end_character":55},"in_reply_to":"9a68dd71_18bd5168","updated":"2016-01-21 19:56:06.000000000","message":"Oh my apologies, I was simply making an assertion that the issue you mention has to do with the way the language works, there\u0027s nothing wrong with this specific signature, all signatures that expose **kwargs alongside positional arguments are affected by this, but that\u0027s not enough for us to go and switch to dictionaries everywhere, that\u0027s insane!","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3e73f461a5c836fdbf50b015b1a6c760e9c49961","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"So, for example, if we call notify as follows:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_18bd5168","line":17,"range":{"start_line":17,"start_character":50,"end_line":17,"end_character":55},"in_reply_to":"9a68dd71_24c5a28d","updated":"2016-01-21 12:31:46.000000000","message":"\"This is the Python we\u0027re talking about\". I\u0027m assuming there was some discussion about dicts.","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2934b9be4895a5f11f3f2792ed85db801d5ac6f0","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"So, for example, if we call notify as follows:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_24c5a28d","line":17,"range":{"start_line":17,"start_character":50,"end_line":17,"end_character":55},"in_reply_to":"da6ed579_345f2b77","updated":"2016-01-21 07:26:36.000000000","message":"I did not reference any discussion. What am I missing?","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f04bb57f519fee1847ec4c47fdaf15d54dc33d4b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"So, for example, if we call notify as follows:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_345f2b77","line":17,"range":{"start_line":17,"start_character":50,"end_line":17,"end_character":55},"in_reply_to":"da6ed579_61197179","updated":"2016-01-16 19:45:33.000000000","message":"Which discussion? Can you provide a link to it, so that I can understand what the discussion was about?","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9e37885a54d9c68a185ba40bab155a0f9f34e638","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid this, the approach taken in this commit is to use a dict for"},{"line_number":22,"context_line":"the parameters to pass to the callback, in the same way that the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_6147314c","line":19,"range":{"start_line":19,"start_character":34,"end_line":19,"end_character":35},"updated":"2016-01-16 02:33:39.000000000","message":"so what? event is a positional argument of a well defined API. When you test your callback you find that out and fix the damn signature.","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2934b9be4895a5f11f3f2792ed85db801d5ac6f0","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid this, the approach taken in this commit is to use a dict for"},{"line_number":22,"context_line":"the parameters to pass to the callback, in the same way that the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_04ef3ee9","line":19,"range":{"start_line":19,"start_character":34,"end_line":19,"end_character":35},"in_reply_to":"da6ed579_148787d8","updated":"2016-01-21 07:26:36.000000000","message":"Let\u0027s get Kevin to chime in, because the naming conflict is a non-issue.","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f04bb57f519fee1847ec4c47fdaf15d54dc33d4b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid this, the approach taken in this commit is to use a dict for"},{"line_number":22,"context_line":"the parameters to pass to the callback, in the same way that the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_148787d8","line":19,"range":{"start_line":19,"start_character":34,"end_line":19,"end_character":35},"in_reply_to":"da6ed579_6147314c","updated":"2016-01-16 19:45:33.000000000","message":"From the original commit, I thought the naming conflict with kwargs, was the issue that Kevin B was complaining about. This patch is to address that issue.","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f04bb57f519fee1847ec4c47fdaf15d54dc33d4b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid this, the approach taken in this commit is to use a dict for"},{"line_number":22,"context_line":"the parameters to pass to the callback, in the same way that the"},{"line_number":23,"context_line":"Requests package does for get()."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_b4531b6c","line":20,"updated":"2016-01-16 19:45:33.000000000","message":"The main question I have for you is... what do we need to do or address, so that this feature can be made public (it is marked as private currently)?\n\nI know there was some concerns with it, and I *thought* that was with having kwargs. This commit was an attempt to try to move the ball forward - without coming up with a complex solution.","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bdc2b1570cfabf3395157cc35efaffea6953fa4b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid this, the approach taken in this commit is to use a dict for"},{"line_number":22,"context_line":"the parameters to pass to the callback, in the same way that the"},{"line_number":23,"context_line":"Requests package does for get()."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_d4444b1c","line":20,"in_reply_to":"9a68dd71_5807491c","updated":"2016-01-21 19:56:06.000000000","message":"Oslo Versioned Objects","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3e73f461a5c836fdbf50b015b1a6c760e9c49961","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid this, the approach taken in this commit is to use a dict for"},{"line_number":22,"context_line":"the parameters to pass to the callback, in the same way that the"},{"line_number":23,"context_line":"Requests package does for get()."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_5807491c","line":20,"in_reply_to":"9a68dd71_e4ad4a89","updated":"2016-01-21 12:31:46.000000000","message":"OVO?","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2934b9be4895a5f11f3f2792ed85db801d5ac6f0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    registry.notify(\u0027foo\u0027, \u0027bar\u0027, \u0027trig\u0027, port\u003d2, event\u003d5)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid this, the approach taken in this commit is to use a dict for"},{"line_number":22,"context_line":"the parameters to pass to the callback, in the same way that the"},{"line_number":23,"context_line":"Requests package does for get()."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_e4ad4a89","line":20,"in_reply_to":"da6ed579_b4531b6c","updated":"2016-01-21 07:26:36.000000000","message":"I think the objective is to move away from kwargs and swap it with a payload object with a well defined interface. I never got to do it back then because kwargs is so pervasive in the Neutron codebase and we lacked adoption of OVO or any equivalent mechanism.","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e0be4ad906cf55720354f2f3a041ff26537924e1","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid this, the approach taken in this commit is to use a dict for"},{"line_number":22,"context_line":"the parameters to pass to the callback, in the same way that the"},{"line_number":23,"context_line":"Requests package does for get()."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_1b06eb20","line":21,"range":{"start_line":21,"start_character":61,"end_line":21,"end_character":65},"updated":"2016-01-20 13:22:12.000000000","message":"Essentially, this is using a positional argument to indicate the payload. I suggested a dict, for easy conversion to what we have today, but this could be an object instead.","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2934b9be4895a5f11f3f2792ed85db801d5ac6f0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid this, the approach taken in this commit is to use a dict for"},{"line_number":22,"context_line":"the parameters to pass to the callback, in the same way that the"},{"line_number":23,"context_line":"Requests package does for get()."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_a4b672da","line":21,"range":{"start_line":21,"start_character":61,"end_line":21,"end_character":65},"in_reply_to":"9a68dd71_1b06eb20","updated":"2016-01-21 07:26:36.000000000","message":"I think that using a dictionary would fall short.","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3e73f461a5c836fdbf50b015b1a6c760e9c49961","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We\u0027ll get an error of multiple values for keyword argument \u0027event\u0027."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid this, the approach taken in this commit is to use a dict for"},{"line_number":22,"context_line":"the parameters to pass to the callback, in the same way that the"},{"line_number":23,"context_line":"Requests package does for get()."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_b808c52e","line":21,"range":{"start_line":21,"start_character":61,"end_line":21,"end_character":65},"in_reply_to":"9a68dd71_a4b672da","updated":"2016-01-21 12:31:46.000000000","message":"The positional arg doesn\u0027t have to refer to a dict, and could be anything (obviously).","commit_id":"db1900d6cfb5b5dd7004dc2b314fa0f3d70f2b44"}]}
