)]}'
{"neutron_lib/_context.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"82d7f0c532f96b3d2ff84b1f426630d605219548","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # TODO(akamyshnikova): checking for session attribute won\u0027t be needed"},{"line_number":134,"context_line":"        # when reader and writer will be used"},{"line_number":135,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":136,"context_line":"            return super(Context, self).session"},{"line_number":137,"context_line":"        if self._session is None:"},{"line_number":138,"context_line":"            self._session \u003d _get_session()"},{"line_number":139,"context_line":"        return self._session"}],"source_content_type":"text/x-python","patch_set":14,"id":"1aa78d24_1ebc39ba","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":47},"updated":"2016-07-11 17:25:10.000000000","message":"Not covered in UTs as per coverage report.","commit_id":"acdc1c10883d84e5466389fabe999d9d5470a2bb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5a03ee3265470eed63c37afb9f90271f4594eb91","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # TODO(akamyshnikova): checking for session attribute won\u0027t be needed"},{"line_number":134,"context_line":"        # when reader and writer will be used"},{"line_number":135,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":136,"context_line":"            return super(Context, self).session"},{"line_number":137,"context_line":"        if self._session is None:"},{"line_number":138,"context_line":"            self._session \u003d _get_session()"},{"line_number":139,"context_line":"        return self._session"}],"source_content_type":"text/x-python","patch_set":14,"id":"1aa78d24_b35433fe","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":47},"in_reply_to":"1aa78d24_1ebc39ba","updated":"2016-07-11 22:25:43.000000000","message":"Because the enginefacade work is not yet complete, the parent class will never have a \u0027session\u0027 attribute. I am planning to do 100% test coverage when we get the finalized enginefacade work from neutron, and then we\u0027ll be able to make this module non-private.","commit_id":"acdc1c10883d84e5466389fabe999d9d5470a2bb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"51b2b185be8afca2702b0cdb325b8e1e7b0545ff","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron_lib import policy"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(HenryG): use context_manager from db_api.py when it is brought in"},{"line_number":25,"context_line":"_context_manager \u003d enginefacade.transaction_context()"},{"line_number":26,"context_line":"_context_manager.configure(sqlite_fk\u003dTrue)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_session(autocommit\u003dTrue, expire_on_commit\u003dFalse, use_slave\u003dFalse):"},{"line_number":30,"context_line":"    \"\"\"Helper method to grab session.\"\"\""},{"line_number":31,"context_line":"    return _context_manager.get_legacy_facade().get_session("},{"line_number":32,"context_line":"        autocommit\u003dautocommit, expire_on_commit\u003dexpire_on_commit,"},{"line_number":33,"context_line":"        use_slave\u003duse_slave)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class ContextBase(oslo_context.RequestContext):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_947438cf","line":33,"range":{"start_line":24,"start_character":0,"end_line":33,"end_character":28},"updated":"2016-07-13 03:27:10.000000000","message":"Temporary until db/api.py is available in neutron-lib.","commit_id":"6e870b1dab6003547864db5682d2c9866df02304"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8b90da86b9a2752fd760a780927fda22c8e27b3e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron_lib import policy"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(HenryG): use context_manager from db_api.py when it is brought in"},{"line_number":25,"context_line":"_context_manager \u003d enginefacade.transaction_context()"},{"line_number":26,"context_line":"_context_manager.configure(sqlite_fk\u003dTrue)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_session(autocommit\u003dTrue, expire_on_commit\u003dFalse, use_slave\u003dFalse):"},{"line_number":30,"context_line":"    \"\"\"Helper method to grab session.\"\"\""},{"line_number":31,"context_line":"    return _context_manager.get_legacy_facade().get_session("},{"line_number":32,"context_line":"        autocommit\u003dautocommit, expire_on_commit\u003dexpire_on_commit,"},{"line_number":33,"context_line":"        use_slave\u003duse_slave)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class ContextBase(oslo_context.RequestContext):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_a8f2946c","line":33,"range":{"start_line":24,"start_character":0,"end_line":33,"end_character":28},"in_reply_to":"1aa78d24_400ddbe6","updated":"2016-07-13 15:53:25.000000000","message":"Done","commit_id":"6e870b1dab6003547864db5682d2c9866df02304"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d7295e7de17fbaf5a3b9c9642d7c377f00cae8fb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron_lib import policy"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(HenryG): use context_manager from db_api.py when it is brought in"},{"line_number":25,"context_line":"_context_manager \u003d enginefacade.transaction_context()"},{"line_number":26,"context_line":"_context_manager.configure(sqlite_fk\u003dTrue)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_session(autocommit\u003dTrue, expire_on_commit\u003dFalse, use_slave\u003dFalse):"},{"line_number":30,"context_line":"    \"\"\"Helper method to grab session.\"\"\""},{"line_number":31,"context_line":"    return _context_manager.get_legacy_facade().get_session("},{"line_number":32,"context_line":"        autocommit\u003dautocommit, expire_on_commit\u003dexpire_on_commit,"},{"line_number":33,"context_line":"        use_slave\u003duse_slave)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class ContextBase(oslo_context.RequestContext):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_400ddbe6","line":33,"range":{"start_line":24,"start_character":0,"end_line":33,"end_character":28},"in_reply_to":"1aa78d24_947438cf","updated":"2016-07-13 11:11:37.000000000","message":"Maybe add TODO for both of these comments you have here?","commit_id":"6e870b1dab6003547864db5682d2c9866df02304"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"51b2b185be8afca2702b0cdb325b8e1e7b0545ff","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # TODO(akamyshnikova): checking for session attribute won\u0027t be needed"},{"line_number":134,"context_line":"        # when reader and writer will be used"},{"line_number":135,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":136,"context_line":"            return super(Context, self).session"},{"line_number":137,"context_line":"        if self._session is None:"},{"line_number":138,"context_line":"            self._session \u003d _get_session()"},{"line_number":139,"context_line":"        return self._session"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_942278b7","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":47},"updated":"2016-07-13 03:27:10.000000000","message":"This path is not covered by unit tests. It will be covered when we get the finalized enginefacade work from neutron.","commit_id":"6e870b1dab6003547864db5682d2c9866df02304"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"babead1c133d70b7d18923dba54afda2fc2b3b03","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # TODO(akamyshnikova): checking for session attribute won\u0027t be needed"},{"line_number":124,"context_line":"        # when reader and writer will be used"},{"line_number":125,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":126,"context_line":"            return super(Context, self).session"},{"line_number":127,"context_line":"        if self._session is None:"},{"line_number":128,"context_line":"            self._session \u003d db_api.get_session()"},{"line_number":129,"context_line":"        return self._session"}],"source_content_type":"text/x-python","patch_set":20,"id":"dada55a8_a43f3b24","line":126,"updated":"2016-07-18 16:23:36.000000000","message":"This LOC is not tested as per coverage report.","commit_id":"a4795fa1699de2a1d5f3e89ba09e62c909ac9207"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"93560be16918157038a6bb52d8544389ae8dedb5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron_lib import policy"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ContextBase(oslo_context.RequestContext):"},{"line_number":27,"context_line":"    \"\"\"Security context and request information."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    Represents the user taking a given action within the system."}],"source_content_type":"text/x-python","patch_set":25,"id":"bacf61ea_57346f48","line":26,"updated":"2016-08-02 04:02:42.000000000","message":"do you think this is ever going to change? This is possibly the most stable class we\u0027ve ever had in Neutron.","commit_id":"0c29ef7ffe9a7f8fb561d41152c1eb4aebc7ad69"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7df5693a4a0da697f681f901849dc904f5a0c881","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron_lib import policy"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ContextBase(oslo_context.RequestContext):"},{"line_number":27,"context_line":"    \"\"\"Security context and request information."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    Represents the user taking a given action within the system."}],"source_content_type":"text/x-python","patch_set":25,"id":"bacf61ea_977a67bb","line":26,"in_reply_to":"bacf61ea_57346f48","updated":"2016-08-02 04:16:17.000000000","message":"Well, things like https://review.openstack.org/302329 can happen.\n\nBut the reason why this module is private for now is because of line 22. It\u0027s a chicken and egg problem. Once db/api.py is in lib I will fix the imports and make it public.","commit_id":"0c29ef7ffe9a7f8fb561d41152c1eb4aebc7ad69"}],"neutron_lib/constants.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"82d7f0c532f96b3d2ff84b1f426630d605219548","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"ATTR_NOT_SPECIFIED \u003d Sentinel()"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"ATTRIBUTES_TO_UPDATE \u003d \u0027attributes_to_update\u0027"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"HEX_ELEM \u003d \u0027[0-9A-Fa-f]\u0027"},{"line_number":270,"context_line":"UUID_PATTERN \u003d \u0027-\u0027.join([HEX_ELEM + \u0027{8}\u0027, HEX_ELEM + \u0027{4}\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1aa78d24_1e3d598f","line":267,"range":{"start_line":267,"start_character":0,"end_line":267,"end_character":20},"updated":"2016-07-11 17:25:10.000000000","message":"Maybe I\u0027m missing something, but I don\u0027t see this used anywhere. Is there a reason to bring it over as part of this change?","commit_id":"acdc1c10883d84e5466389fabe999d9d5470a2bb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5a03ee3265470eed63c37afb9f90271f4594eb91","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"ATTR_NOT_SPECIFIED \u003d Sentinel()"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"ATTRIBUTES_TO_UPDATE \u003d \u0027attributes_to_update\u0027"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"HEX_ELEM \u003d \u0027[0-9A-Fa-f]\u0027"},{"line_number":270,"context_line":"UUID_PATTERN \u003d \u0027-\u0027.join([HEX_ELEM + \u0027{8}\u0027, HEX_ELEM + \u0027{4}\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1aa78d24_f3699bbf","line":267,"range":{"start_line":267,"start_character":0,"end_line":267,"end_character":20},"in_reply_to":"1aa78d24_1e3d598f","updated":"2016-07-11 22:25:43.000000000","message":"No, it snuck in when I wasn\u0027t looking. Naughty ATTRIBUTES_TO_UPDATE!","commit_id":"acdc1c10883d84e5466389fabe999d9d5470a2bb"}],"neutron_lib/context.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5c3125f36529214c63be53892893785a6216d2f3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    @property"},{"line_number":116,"context_line":"    def session(self):"},{"line_number":117,"context_line":"        if self._session is None:"},{"line_number":118,"context_line":"            self._session \u003d db_api.get_session()"},{"line_number":119,"context_line":"        return self._session"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_2a6fa793","line":118,"range":{"start_line":118,"start_character":28,"end_line":118,"end_character":34},"updated":"2016-04-10 23:51:27.000000000","message":"This is a problem because db/_api is private.","commit_id":"09222e57b04cecd78b96e2164fd11d2dc3920126"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d846b4e0f919bfaadb30872dc6538e9b5e0fba2a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.roles \u003d roles or []"},{"line_number":55,"context_line":"        self.is_advsvc \u003d is_advsvc"},{"line_number":56,"context_line":"        if self.is_advsvc is None:"},{"line_number":57,"context_line":"            self.is_advsvc \u003d self.is_admin or policy.check_is_advsvc(self)"},{"line_number":58,"context_line":"        if self.is_admin is None:"},{"line_number":59,"context_line":"            self.is_admin \u003d policy.check_is_admin(self)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_70f30ea0","line":57,"updated":"2016-04-22 17:24:17.000000000","message":"I\u0027m not a fan of this magic role, but we can generalize later without breaking it.","commit_id":"760b992e01de4ca2afc024b8d81602f4b2fd3975"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2a492d7ed73d3e67935951f41f38f57ef0802c24","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, user_id, tenant_id, is_admin\u003dNone, roles\u003dNone,"},{"line_number":32,"context_line":"                 timestamp\u003dNone, request_id\u003dNone, tenant_name\u003dNone,"},{"line_number":33,"context_line":"                 user_name\u003dNone, overwrite\u003dTrue, auth_token\u003dNone,"},{"line_number":34,"context_line":"                 is_advsvc\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_f226a2b8","line":31,"range":{"start_line":31,"start_character":58,"end_line":31,"end_character":68},"updated":"2016-05-16 15:59:01.000000000","message":"In the current code (not part of this patch), there\u0027s a call to the super constructor right below this __init__() def. However it appears our context call in neutron_lib is not passing up the \u0027roles\u0027 to the parent constructor...\n\nShould it be?\n\ne.g. this call:\n\n\nsuper(ContextBase, self).__init__(auth_token\u003dauth_token,\n                                          user\u003duser_id, tenant\u003dtenant_id,\n                                          is_admin\u003dis_admin,\n                                          request_id\u003drequest_id,\n                                          overwrite\u003doverwrite)\n\n\nDoes not pass up roles\u003droles as a kwarg.","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"340555b117e941f6d653ca41f25bcab86ff27cc9","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, user_id, tenant_id, is_admin\u003dNone, roles\u003dNone,"},{"line_number":32,"context_line":"                 timestamp\u003dNone, request_id\u003dNone, tenant_name\u003dNone,"},{"line_number":33,"context_line":"                 user_name\u003dNone, overwrite\u003dTrue, auth_token\u003dNone,"},{"line_number":34,"context_line":"                 is_advsvc\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_024e9d95","line":31,"range":{"start_line":31,"start_character":58,"end_line":31,"end_character":68},"in_reply_to":"dab17558_f226a2b8","updated":"2016-05-20 02:03:48.000000000","message":"Yes, this is because https://review.openstack.org/302329 was done in neutron after I copied context.py over here.","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2a492d7ed73d3e67935951f41f38f57ef0802c24","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        return context"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class Context(ContextBase):"},{"line_number":111,"context_line":"    def __init__(self, user_id, tenant_id, *args, **kwargs):"},{"line_number":112,"context_line":"        super(Context, self).__init__(user_id, tenant_id, *args, **kwargs)"},{"line_number":113,"context_line":"        self._session \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_926636b9","line":110,"range":{"start_line":110,"start_character":14,"end_line":110,"end_character":25},"updated":"2016-05-16 15:59:01.000000000","message":"Looks like a recent patch to neutron\u0027s context now uses a ContextBaseWithSession. Shouldn\u0027t we be following suit here?\n\nSee: https://github.com/openstack/neutron/commit/aa630f2ac88bfb4a9828b432bddfed1f04e077d3","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"340555b117e941f6d653ca41f25bcab86ff27cc9","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        return context"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class Context(ContextBase):"},{"line_number":111,"context_line":"    def __init__(self, user_id, tenant_id, *args, **kwargs):"},{"line_number":112,"context_line":"        super(Context, self).__init__(user_id, tenant_id, *args, **kwargs)"},{"line_number":113,"context_line":"        self._session \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_6047a277","line":110,"range":{"start_line":110,"start_character":14,"end_line":110,"end_character":25},"in_reply_to":"dab17558_926636b9","updated":"2016-05-20 02:03:48.000000000","message":"ack, another recent change in neutron","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2a492d7ed73d3e67935951f41f38f57ef0802c24","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @property"},{"line_number":116,"context_line":"    def session(self):"},{"line_number":117,"context_line":"        if self._session is None:"},{"line_number":118,"context_line":"            self._session \u003d db_api.get_session()"},{"line_number":119,"context_line":"        return self._session"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_12b6c6f8","line":117,"updated":"2016-05-16 15:59:01.000000000","message":"There is an extra check in neutron\u0027c context here: https://github.com/openstack/neutron/blob/master/neutron/context.py#L127\n\nJust wanted to make sure we removed that (and the TODO comment) on purpose and it\u0027s not needed.","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"340555b117e941f6d653ca41f25bcab86ff27cc9","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @property"},{"line_number":116,"context_line":"    def session(self):"},{"line_number":117,"context_line":"        if self._session is None:"},{"line_number":118,"context_line":"            self._session \u003d db_api.get_session()"},{"line_number":119,"context_line":"        return self._session"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_c0600e04","line":117,"in_reply_to":"dab17558_12b6c6f8","updated":"2016-05-20 02:03:48.000000000","message":"ack, ditto","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f9761a58c156eba3ae16f7646b293f9cb69d6ffa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron_lib import policy_base as policy"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(HenryG): use context_manager from db_api.py when it is brought in"},{"line_number":25,"context_line":"_context_manager \u003d enginefacade.transaction_context()"},{"line_number":26,"context_line":"_context_manager.configure(sqlite_fk\u003dTrue)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_70a9b024","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":72},"updated":"2016-05-23 19:34:05.000000000","message":"So _get_session() will change as per your TODO I assume?\n\n\nThe 2 things I was wondering about here are:\n(a) The neutron impl seems to use a lazily instantiated singleton (global) facade. I assume that\u0027s removed here on purpose and consumers handle such constructs themselves?\n\n\n(b) In neutron it appears we also pass in **cfg.CONF.database to context_manager.configure(). How do consumers account for that?","commit_id":"2e5036bf031440729fb19a7a6f9a7e85bcf906a7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9ed4f2a028b45b86152ceb0d3692b010bfcdc7e1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron_lib import policy_base as policy"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(HenryG): use context_manager from db_api.py when it is brought in"},{"line_number":25,"context_line":"_context_manager \u003d enginefacade.transaction_context()"},{"line_number":26,"context_line":"_context_manager.configure(sqlite_fk\u003dTrue)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_16abfcd7","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":72},"in_reply_to":"bab6814e_70a9b024","updated":"2016-05-23 20:02:40.000000000","message":"I am waiting for https://review.openstack.org/312393 to merge, then I will bring that into neutron-lib. Does that answer your questions?","commit_id":"2e5036bf031440729fb19a7a6f9a7e85bcf906a7"}],"neutron_lib/exceptions.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2a492d7ed73d3e67935951f41f38f57ef0802c24","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class PolicyInitError(NeutronException):"},{"line_number":246,"context_line":"    message \u003d _(\"Failed to init policy %(policy)s because %(reason)s.\")"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"class PolicyCheckError(NeutronException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_d27efee2","line":246,"range":{"start_line":246,"start_character":27,"end_line":246,"end_character":31},"updated":"2016-05-16 15:59:01.000000000","message":"Nit: \"Initialize\" (vs \"init\") might be more user friendly.","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"340555b117e941f6d653ca41f25bcab86ff27cc9","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class PolicyInitError(NeutronException):"},{"line_number":246,"context_line":"    message \u003d _(\"Failed to init policy %(policy)s because %(reason)s.\")"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"class PolicyCheckError(NeutronException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_a05d0a49","line":246,"range":{"start_line":246,"start_character":27,"end_line":246,"end_character":31},"in_reply_to":"dab17558_d27efee2","updated":"2016-05-20 02:03:48.000000000","message":"Done","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"}],"neutron_lib/policy.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"51b2b185be8afca2702b0cdb325b8e1e7b0545ff","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"_ENFORCER \u003d None"},{"line_number":18,"context_line":"_ADMIN_CTX_POLICY \u003d \u0027context_is_admin\u0027"},{"line_number":19,"context_line":"_ADVSVC_CTX_POLICY \u003d \u0027context_is_advsvc\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def reset():"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_7ff1a500","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":40},"updated":"2016-07-13 03:27:10.000000000","message":"These two are not private in Neutron core. But I could not find any use of them outside policy.py, so I made them private in neutron-lib.","commit_id":"6e870b1dab6003547864db5682d2c9866df02304"}],"neutron_lib/policy_base.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2a492d7ed73d3e67935951f41f38f57ef0802c24","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_policy import policy"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"_ENFORCER \u003d None"},{"line_number":21,"context_line":"_ADMIN_CTX_POLICY \u003d \u0027context_is_admin\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_5c450041","line":18,"updated":"2016-05-16 15:59:01.000000000","message":"Nit: LOG isn\u0027t used here (yet).","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"340555b117e941f6d653ca41f25bcab86ff27cc9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_policy import policy"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"_ENFORCER \u003d None"},{"line_number":21,"context_line":"_ADMIN_CTX_POLICY \u003d \u0027context_is_admin\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_002e96a4","line":18,"in_reply_to":"dab17558_5c450041","updated":"2016-05-20 02:03:48.000000000","message":"Done","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"}],"neutron_lib/policy_enforcer.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"82d7f0c532f96b3d2ff84b1f426630d605219548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1aa78d24_7eda9d4c","updated":"2016-07-11 17:25:10.000000000","message":"I may have missed this discussion, but are we planning to rehome neutron\u0027s policy.py in a more modular fashion here in neutron-lib? e.g. what\u0027s the motivation for the name \u0027policy_enforcer.py\u0027 vs \u0027policy.py\u0027?","commit_id":"acdc1c10883d84e5466389fabe999d9d5470a2bb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"4dee4ef5bc8d9b28456bfc162d277cf68900318c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1aa78d24_14bb28c5","in_reply_to":"1aa78d24_336a0382","updated":"2016-07-13 03:24:34.000000000","message":"OK, after giving this some more thought, I will stick to just one policy.py in neutron-lib and not split it up.\n\nHowever, I will rehome only this subset of the functions from policy.py because otherwise too many dependencies will be pulled in and this patch will get too big. More functions from neutron\u0027s policy.py can be add to neutron-lib\u0027s policy.py in later patches.","commit_id":"acdc1c10883d84e5466389fabe999d9d5470a2bb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5a03ee3265470eed63c37afb9f90271f4594eb91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1aa78d24_336a0382","in_reply_to":"1aa78d24_7eda9d4c","updated":"2016-07-11 22:25:43.000000000","message":"It hasn\u0027t really been discussed, but I am proposing it with this patch. (I made a similar proposal earlier in patches that I abandoned.) Please feel free to discuss it here.\n\nI named it \u0027policy_enforcer.py\u0027 because this is just those related bits from neutron\u0027s policy.py.\n\nOne motivation for splitting is less code per patch (easier to review). Another is that I generally like small modules.","commit_id":"acdc1c10883d84e5466389fabe999d9d5470a2bb"}],"neutron_lib/policy_roles.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5c3125f36529214c63be53892893785a6216d2f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a1b2928_ca0433c8","updated":"2016-04-10 23:51:27.000000000","message":"A better name for this module might be policy_base.py ?","commit_id":"09222e57b04cecd78b96e2164fd11d2dc3920126"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3d0c9e922921ac99b66a6937712262181f62b712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a18252c_c6f230d2","in_reply_to":"7a1b2928_ca0433c8","updated":"2016-04-13 03:18:11.000000000","message":"+1","commit_id":"09222e57b04cecd78b96e2164fd11d2dc3920126"}],"neutron_lib/tests/_base.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f765b885c678c624bbbccfd82cdec656895af89a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    @staticmethod"},{"line_number":104,"context_line":"    def config_parse(conf\u003dNone, args\u003dNone):"},{"line_number":105,"context_line":"        \"\"\"Create the default configurations.\"\"\""},{"line_number":106,"context_line":"        # neutron.conf includes rpc_backend which needs to be cleaned up"},{"line_number":107,"context_line":"        if args is None:"},{"line_number":108,"context_line":"            args \u003d []"},{"line_number":109,"context_line":"        args +\u003d [\u0027--config-file\u0027, etcdir(\u0027neutron_lib.conf\u0027)]"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_828023f9","line":106,"updated":"2016-07-14 13:19:41.000000000","message":"is this comment relevant?","commit_id":"a598c7eb4075f73a436a0f1525fd27318a8b417a"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0a27028bd640ad5b3eb9fe54585867e3dc776c1a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    @staticmethod"},{"line_number":104,"context_line":"    def config_parse(conf\u003dNone, args\u003dNone):"},{"line_number":105,"context_line":"        \"\"\"Create the default configurations.\"\"\""},{"line_number":106,"context_line":"        # neutron.conf includes rpc_backend which needs to be cleaned up"},{"line_number":107,"context_line":"        if args is None:"},{"line_number":108,"context_line":"            args \u003d []"},{"line_number":109,"context_line":"        args +\u003d [\u0027--config-file\u0027, etcdir(\u0027neutron_lib.conf\u0027)]"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_a7028c70","line":106,"in_reply_to":"1aa78d24_828023f9","updated":"2016-07-14 14:34:50.000000000","message":"No. Done.","commit_id":"a598c7eb4075f73a436a0f1525fd27318a8b417a"}],"neutron_lib/tests/unit/db/test_model_base.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2a492d7ed73d3e67935951f41f38f57ef0802c24","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import testtools"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron_lib import context"},{"line_number":18,"context_line":"from neutron_lib.db import model_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron_lib.tests import _base as base"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_c9d3f036","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":37},"updated":"2016-05-16 15:59:01.000000000","message":"Newbie question -- where is model_base coming from? I don\u0027t see it in neutron_lib.","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"17ad31d9d24ad1e324be72f7ad59af70fb00d34d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import testtools"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron_lib import context"},{"line_number":18,"context_line":"from neutron_lib.db import model_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron_lib.tests import _base as base"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_64f3849f","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":37},"in_reply_to":"dab17558_c9d3f036","updated":"2016-05-18 17:44:41.000000000","message":"It comes from the dependent patch, https://review.openstack.org/303864","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"}],"neutron_lib/tests/unit/test_context.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f9761a58c156eba3ae16f7646b293f9cb69d6ffa","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_neutron_context_create_is_advsvc(self):"},{"line_number":72,"context_line":"        ctx \u003d context.Context(\u0027user_id\u0027, \u0027tenant_id\u0027, is_advsvc\u003dTrue)"},{"line_number":73,"context_line":"        self.assertEqual(False, ctx.is_admin)"},{"line_number":74,"context_line":"        self.assertEqual(True, ctx.is_advsvc)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_neutron_context_create_with_auth_token(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_93853e5b","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":24},"updated":"2016-05-23 19:34:05.000000000","message":"assertFalse()","commit_id":"2e5036bf031440729fb19a7a6f9a7e85bcf906a7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9ed4f2a028b45b86152ceb0d3692b010bfcdc7e1","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_neutron_context_create_is_advsvc(self):"},{"line_number":72,"context_line":"        ctx \u003d context.Context(\u0027user_id\u0027, \u0027tenant_id\u0027, is_advsvc\u003dTrue)"},{"line_number":73,"context_line":"        self.assertEqual(False, ctx.is_admin)"},{"line_number":74,"context_line":"        self.assertEqual(True, ctx.is_advsvc)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_neutron_context_create_with_auth_token(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_36956088","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":24},"in_reply_to":"bab6814e_93853e5b","updated":"2016-05-23 20:02:40.000000000","message":"Done","commit_id":"2e5036bf031440729fb19a7a6f9a7e85bcf906a7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f9761a58c156eba3ae16f7646b293f9cb69d6ffa","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_neutron_context_create_is_advsvc(self):"},{"line_number":72,"context_line":"        ctx \u003d context.Context(\u0027user_id\u0027, \u0027tenant_id\u0027, is_advsvc\u003dTrue)"},{"line_number":73,"context_line":"        self.assertEqual(False, ctx.is_admin)"},{"line_number":74,"context_line":"        self.assertEqual(True, ctx.is_advsvc)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_neutron_context_create_with_auth_token(self):"},{"line_number":77,"context_line":"        ctx \u003d context.Context(\u0027user_id\u0027, \u0027tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_33957288","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":24},"updated":"2016-05-23 19:34:05.000000000","message":"assertTrue()","commit_id":"2e5036bf031440729fb19a7a6f9a7e85bcf906a7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9ed4f2a028b45b86152ceb0d3692b010bfcdc7e1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_neutron_context_create_is_advsvc(self):"},{"line_number":72,"context_line":"        ctx \u003d context.Context(\u0027user_id\u0027, \u0027tenant_id\u0027, is_advsvc\u003dTrue)"},{"line_number":73,"context_line":"        self.assertEqual(False, ctx.is_admin)"},{"line_number":74,"context_line":"        self.assertEqual(True, ctx.is_advsvc)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_neutron_context_create_with_auth_token(self):"},{"line_number":77,"context_line":"        ctx \u003d context.Context(\u0027user_id\u0027, \u0027tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_768fe875","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":24},"in_reply_to":"bab6814e_33957288","updated":"2016-05-23 20:02:40.000000000","message":"Done","commit_id":"2e5036bf031440729fb19a7a6f9a7e85bcf906a7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f9761a58c156eba3ae16f7646b293f9cb69d6ffa","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertIsNone(ctx_dict[\u0027user_id\u0027])"},{"line_number":119,"context_line":"        self.assertIsNone(ctx_dict[\u0027tenant_id\u0027])"},{"line_number":120,"context_line":"        self.assertIsNone(ctx_dict[\u0027auth_token\u0027])"},{"line_number":121,"context_line":"        self.assertEqual(True, ctx_dict[\u0027is_admin\u0027])"},{"line_number":122,"context_line":"        self.assertIsNotNone(ctx.session)"},{"line_number":123,"context_line":"        self.assertNotIn(\u0027session\u0027, ctx_dict)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_b3e7a245","line":121,"range":{"start_line":121,"start_character":13,"end_line":121,"end_character":24},"updated":"2016-05-23 19:34:05.000000000","message":"assertTrue()","commit_id":"2e5036bf031440729fb19a7a6f9a7e85bcf906a7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9ed4f2a028b45b86152ceb0d3692b010bfcdc7e1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertIsNone(ctx_dict[\u0027user_id\u0027])"},{"line_number":119,"context_line":"        self.assertIsNone(ctx_dict[\u0027tenant_id\u0027])"},{"line_number":120,"context_line":"        self.assertIsNone(ctx_dict[\u0027auth_token\u0027])"},{"line_number":121,"context_line":"        self.assertEqual(True, ctx_dict[\u0027is_admin\u0027])"},{"line_number":122,"context_line":"        self.assertIsNotNone(ctx.session)"},{"line_number":123,"context_line":"        self.assertNotIn(\u0027session\u0027, ctx_dict)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_568c647f","line":121,"range":{"start_line":121,"start_character":13,"end_line":121,"end_character":24},"in_reply_to":"bab6814e_b3e7a245","updated":"2016-05-23 20:02:40.000000000","message":"Done","commit_id":"2e5036bf031440729fb19a7a6f9a7e85bcf906a7"}],"neutron_lib/tests/unit/test_policy_roles.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d95a1b64c24654698b6ef318d0429fe01363c19e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def test_check_is_admin_user(self):"},{"line_number":38,"context_line":"        ctx \u003d context.Context(\u0027me\u0027, \u0027my_project\u0027)"},{"line_number":39,"context_line":"        is_admin \u003d policy.check_is_admin(ctx)"},{"line_number":40,"context_line":"        self.assertEqual(False, is_admin)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_check_is_admin_admin(self):"},{"line_number":43,"context_line":"        ctx \u003d context.Context(\u0027me\u0027, \u0027my_project\u0027).elevated()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_34132a5e","line":40,"range":{"start_line":40,"start_character":13,"end_line":40,"end_character":24},"updated":"2016-05-04 12:05:46.000000000","message":"assertFalse here and several others.","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"340555b117e941f6d653ca41f25bcab86ff27cc9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def test_check_is_admin_user(self):"},{"line_number":38,"context_line":"        ctx \u003d context.Context(\u0027me\u0027, \u0027my_project\u0027)"},{"line_number":39,"context_line":"        is_admin \u003d policy.check_is_admin(ctx)"},{"line_number":40,"context_line":"        self.assertEqual(False, is_admin)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_check_is_admin_admin(self):"},{"line_number":43,"context_line":"        ctx \u003d context.Context(\u0027me\u0027, \u0027my_project\u0027).elevated()"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_3ad7814c","line":40,"range":{"start_line":40,"start_character":13,"end_line":40,"end_character":24},"in_reply_to":"1a122d0e_34132a5e","updated":"2016-05-20 02:03:48.000000000","message":"Done","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d95a1b64c24654698b6ef318d0429fe01363c19e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def test_check_is_admin_admin(self):"},{"line_number":43,"context_line":"        ctx \u003d context.Context(\u0027me\u0027, \u0027my_project\u0027).elevated()"},{"line_number":44,"context_line":"        is_admin \u003d policy.check_is_admin(ctx)"},{"line_number":45,"context_line":"        self.assertEqual(True, is_admin)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_check_is_admin_no_roles_no_admin(self):"},{"line_number":48,"context_line":"        policy.init(policy_file\u003d\u0027no_policy.json\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_343a0ace","line":45,"updated":"2016-05-04 12:05:46.000000000","message":"assertTrue","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"340555b117e941f6d653ca41f25bcab86ff27cc9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def test_check_is_admin_admin(self):"},{"line_number":43,"context_line":"        ctx \u003d context.Context(\u0027me\u0027, \u0027my_project\u0027).elevated()"},{"line_number":44,"context_line":"        is_admin \u003d policy.check_is_admin(ctx)"},{"line_number":45,"context_line":"        self.assertEqual(True, is_admin)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_check_is_admin_no_roles_no_admin(self):"},{"line_number":48,"context_line":"        policy.init(policy_file\u003d\u0027no_policy.json\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_5ad2455d","line":45,"in_reply_to":"1a122d0e_343a0ace","updated":"2016-05-20 02:03:48.000000000","message":"Done","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d95a1b64c24654698b6ef318d0429fe01363c19e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        is_admin \u003d policy.check_is_admin(ctx)"},{"line_number":51,"context_line":"        self.assertEqual(False, is_admin)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_check_is_advsvc_user(self):"},{"line_number":54,"context_line":"        ctx \u003d context.Context(\u0027me\u0027, \u0027my_project\u0027)"},{"line_number":55,"context_line":"        is_advsvc \u003d policy.check_is_advsvc(ctx)"},{"line_number":56,"context_line":"        self.assertEqual(False, is_advsvc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_74e76240","line":53,"updated":"2016-05-04 12:05:46.000000000","message":"Add positive test case of advanced service?","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"340555b117e941f6d653ca41f25bcab86ff27cc9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        is_admin \u003d policy.check_is_admin(ctx)"},{"line_number":51,"context_line":"        self.assertEqual(False, is_admin)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_check_is_advsvc_user(self):"},{"line_number":54,"context_line":"        ctx \u003d context.Context(\u0027me\u0027, \u0027my_project\u0027)"},{"line_number":55,"context_line":"        is_advsvc \u003d policy.check_is_advsvc(ctx)"},{"line_number":56,"context_line":"        self.assertEqual(False, is_advsvc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_1ae6fd43","line":53,"in_reply_to":"1a122d0e_74e76240","updated":"2016-05-20 02:03:48.000000000","message":"Done","commit_id":"29ba91b9137ba1ddf2204e7cc37badc7f272e7f4"}],"requirements.txt":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"babead1c133d70b7d18923dba54afda2fc2b3b03","unresolved":false,"context_lines":[{"line_number":11,"context_line":"oslo.i18n\u003e\u003d2.1.0 # Apache-2.0"},{"line_number":12,"context_line":"oslo.log\u003e\u003d1.14.0 # Apache-2.0"},{"line_number":13,"context_line":"oslo.messaging\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":14,"context_line":"oslo.policy\u003e\u003d1.9.0 # Apache-2.0"},{"line_number":15,"context_line":"oslo.service\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":16,"context_line":"oslo.utils\u003e\u003d3.15.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":20,"id":"dada55a8_a4a3bb9d","line":14,"updated":"2016-07-18 16:23:36.000000000","message":"Unless I\u0027m missing something, we also need olso.context","commit_id":"a4795fa1699de2a1d5f3e89ba09e62c909ac9207"}]}
