)]}'
{"neutron_lib/hacking/checks.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"e2b0cd910ef417df6f21ac06ced08edabc65907d","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def check_raised_localized_exceptions(logical_line, filename):"},{"line_number":146,"context_line":"    if \"neutron_lib/tests\" in filename:"},{"line_number":147,"context_line":"        return"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    raised_search \u003d re.compile("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_3ff43a59","line":146,"updated":"2016-06-08 17:47:24.000000000","message":"this should be done via an exclusion in tox.ini","commit_id":"996e518b2e743b26915b908e0c9e0dc340dca514"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4fd5dd921b156090db0dea9951005d903a9488f2","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def check_raised_localized_exceptions(logical_line, filename):"},{"line_number":146,"context_line":"    if \"neutron_lib/tests\" in filename:"},{"line_number":147,"context_line":"        return"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    raised_search \u003d re.compile("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_8966d1ea","line":146,"in_reply_to":"7aa08908_3ff43a59","updated":"2016-06-08 20:30:05.000000000","message":"I assume you mean to add it to [1] correct?\n\nThe problem with that is then no pep checks are done on our unit test code; including style checks (import ordering, indentation, etc.). I\u0027d assert we do want these checks running on our UT code, but just not this specific check.\n\nDo you know of another way to specify exclusion on a per check basis in tox.ini?\n\n[1] https://github.com/openstack/neutron-lib/blob/master/tox.ini#L39","commit_id":"996e518b2e743b26915b908e0c9e0dc340dca514"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"eea5e81275475ccfbd2fa51051834bfc79b186b6","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def check_raised_localized_exceptions(logical_line, filename):"},{"line_number":146,"context_line":"    # NOTE(boden): tox.ini doesn\u0027t permit per check exclusion"},{"line_number":147,"context_line":"    if \"neutron_lib/tests\" in filename:"},{"line_number":148,"context_line":"        return"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    raised_search \u003d re.compile("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_1ca02ca5","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":19},"updated":"2016-06-09 16:54:02.000000000","message":"This won\u0027t work for subprojects using this. My recommendation is,\n\n  if \"/tests/\" in filename:","commit_id":"fed70d5c57f74cff0b83d75d76804e4fd865d96a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4cd4a12bf2ce130f4ee56669f6bdd3ea35527820","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def check_raised_localized_exceptions(logical_line, filename):"},{"line_number":146,"context_line":"    # NOTE(boden): tox.ini doesn\u0027t permit per check exclusion"},{"line_number":147,"context_line":"    if \"neutron_lib/tests\" in filename:"},{"line_number":148,"context_line":"        return"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    raised_search \u003d re.compile("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9753556c","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":19},"in_reply_to":"7aa08908_1ca02ca5","updated":"2016-06-09 17:13:17.000000000","message":"good point","commit_id":"fed70d5c57f74cff0b83d75d76804e4fd865d96a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f4441d6d197b22c65fd049f98def9546edd180a5","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    if x is not None:"},{"line_number":148,"context_line":"        yield x"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def check_raised_localized_exceptions(logical_line, filename):"},{"line_number":152,"context_line":"    # NOTE(boden): tox.ini doesn\u0027t permit per check exclusion"},{"line_number":153,"context_line":"    if \"/tests/\" in filename:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_a28e18ce","line":150,"updated":"2016-06-15 13:10:59.000000000","message":"Could you move this to translation_checks.py?","commit_id":"e4735b958b01a7ab7b8a62eb93e799fbb236c031"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f306a6a13bf7b0cf90aec27a28c63aa85433bf50","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    if x is not None:"},{"line_number":148,"context_line":"        yield x"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def check_raised_localized_exceptions(logical_line, filename):"},{"line_number":152,"context_line":"    # NOTE(boden): tox.ini doesn\u0027t permit per check exclusion"},{"line_number":153,"context_line":"    if \"/tests/\" in filename:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_d947d6ba","line":150,"in_reply_to":"7aa08908_a28e18ce","updated":"2016-06-15 15:06:59.000000000","message":"Done","commit_id":"e4735b958b01a7ab7b8a62eb93e799fbb236c031"}],"neutron_lib/tests/unit/hacking/test_checks.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"80d615287e3c748229c393c88755ac3ecc05d277","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_check_localized_exception_messages(self):"},{"line_number":101,"context_line":"        f \u003d checks.check_raised_localized_exceptions"},{"line_number":102,"context_line":"        self.assertLineFails(f, \"     raise KeyError(\\\u0027Error text\\\u0027)\", \u0027\u0027)"},{"line_number":103,"context_line":"        self.assertLineFails(f, \" raise KeyError(\\\"Error text\\\")\", \u0027\u0027)"},{"line_number":104,"context_line":"        self.assertLinePasses(f, \" raise KeyError(_(\\\"Error text\\\"))\", \u0027\u0027)"},{"line_number":105,"context_line":"        self.assertLinePasses(f, \" raise KeyError(_ERR(\\\"Error text\\\"))\", \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_f45a7e4f","line":102,"range":{"start_line":102,"start_character":53,"end_line":102,"end_character":55},"updated":"2016-06-10 03:20:32.000000000","message":"nit: It is inside of double quotes, so a backslash is unnecessary.","commit_id":"3296a66e8a34b40e477f7f4608fa955447d82407"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b8a990256e575f3f5de80f115f607eb2c20b5b72","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_check_localized_exception_messages(self):"},{"line_number":101,"context_line":"        f \u003d checks.check_raised_localized_exceptions"},{"line_number":102,"context_line":"        self.assertLineFails(f, \"     raise KeyError(\\\u0027Error text\\\u0027)\", \u0027\u0027)"},{"line_number":103,"context_line":"        self.assertLineFails(f, \" raise KeyError(\\\"Error text\\\")\", \u0027\u0027)"},{"line_number":104,"context_line":"        self.assertLinePasses(f, \" raise KeyError(_(\\\"Error text\\\"))\", \u0027\u0027)"},{"line_number":105,"context_line":"        self.assertLinePasses(f, \" raise KeyError(_ERR(\\\"Error text\\\"))\", \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_a301c508","line":102,"range":{"start_line":102,"start_character":53,"end_line":102,"end_character":55},"in_reply_to":"7aa08908_f45a7e4f","updated":"2016-06-10 12:25:16.000000000","message":"Done","commit_id":"3296a66e8a34b40e477f7f4608fa955447d82407"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"80d615287e3c748229c393c88755ac3ecc05d277","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def test_check_localized_exception_messages(self):"},{"line_number":101,"context_line":"        f \u003d checks.check_raised_localized_exceptions"},{"line_number":102,"context_line":"        self.assertLineFails(f, \"     raise KeyError(\\\u0027Error text\\\u0027)\", \u0027\u0027)"},{"line_number":103,"context_line":"        self.assertLineFails(f, \" raise KeyError(\\\"Error text\\\")\", \u0027\u0027)"},{"line_number":104,"context_line":"        self.assertLinePasses(f, \" raise KeyError(_(\\\"Error text\\\"))\", \u0027\u0027)"},{"line_number":105,"context_line":"        self.assertLinePasses(f, \" raise KeyError(_ERR(\\\"Error text\\\"))\", \u0027\u0027)"},{"line_number":106,"context_line":"        self.assertLinePasses(f, \" raise KeyError(translated_msg)\", \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_7435eef5","line":103,"updated":"2016-06-10 03:20:32.000000000","message":"If you use a single quote to quote a string, you don\u0027t need to use a backslash.\n\n \u0027 raise KeyError(\"Error text\")\u0027","commit_id":"3296a66e8a34b40e477f7f4608fa955447d82407"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b8a990256e575f3f5de80f115f607eb2c20b5b72","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def test_check_localized_exception_messages(self):"},{"line_number":101,"context_line":"        f \u003d checks.check_raised_localized_exceptions"},{"line_number":102,"context_line":"        self.assertLineFails(f, \"     raise KeyError(\\\u0027Error text\\\u0027)\", \u0027\u0027)"},{"line_number":103,"context_line":"        self.assertLineFails(f, \" raise KeyError(\\\"Error text\\\")\", \u0027\u0027)"},{"line_number":104,"context_line":"        self.assertLinePasses(f, \" raise KeyError(_(\\\"Error text\\\"))\", \u0027\u0027)"},{"line_number":105,"context_line":"        self.assertLinePasses(f, \" raise KeyError(_ERR(\\\"Error text\\\"))\", \u0027\u0027)"},{"line_number":106,"context_line":"        self.assertLinePasses(f, \" raise KeyError(translated_msg)\", \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_06ff0702","line":103,"in_reply_to":"7aa08908_7435eef5","updated":"2016-06-10 12:25:16.000000000","message":"Done","commit_id":"3296a66e8a34b40e477f7f4608fa955447d82407"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"965fe0b3d969f9bae9b9f7cccdc62dee3df232a3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.assertLineFails(f, \u0027 raise KeyError(\"Error text\")\u0027, \u0027\u0027)"},{"line_number":104,"context_line":"        self.assertLinePasses(f, \u0027 raise KeyError(_(\"Error text\"))\u0027, \u0027\u0027)"},{"line_number":105,"context_line":"        self.assertLinePasses(f, \u0027 raise KeyError(_ERR(\"Error text\"))\u0027, \u0027\u0027)"},{"line_number":106,"context_line":"        self.assertLinePasses(f, \" raise KeyError(translated_msg)\", \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_fa7b6b79","line":106,"updated":"2016-06-10 14:32:59.000000000","message":"Please add tests for:\n\n* a valid raise statement, but in a comment\n* a valid raise statement, but inside a string\n* a file path containing /tests/","commit_id":"f1c79314acc1ba6aaeeca76d7659ca226900fb06"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"bdf91008b4ec321dfbe7063ae4cc4efb10e5fe44","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.assertLineFails(f, \u0027 raise KeyError(\"Error text\")\u0027, \u0027\u0027)"},{"line_number":104,"context_line":"        self.assertLinePasses(f, \u0027 raise KeyError(_(\"Error text\"))\u0027, \u0027\u0027)"},{"line_number":105,"context_line":"        self.assertLinePasses(f, \u0027 raise KeyError(_ERR(\"Error text\"))\u0027, \u0027\u0027)"},{"line_number":106,"context_line":"        self.assertLinePasses(f, \" raise KeyError(translated_msg)\", \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_949f935e","line":106,"in_reply_to":"7aa08908_fa7b6b79","updated":"2016-06-10 17:06:25.000000000","message":"Done","commit_id":"f1c79314acc1ba6aaeeca76d7659ca226900fb06"}],"tox.ini":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"80d615287e3c748229c393c88755ac3ecc05d277","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[hacking]"},{"line_number":42,"context_line":"import_exceptions \u003d neutron_lib._i18n"},{"line_number":43,"context_line":"local-check-factory \u003d neutron_lib.hacking.checks.factory"}],"source_content_type":"text/x-properties","patch_set":4,"id":"7aa08908_74c04ee1","line":43,"updated":"2016-06-10 03:20:32.000000000","message":"It has been added in the recent review. Could you rebase?","commit_id":"3296a66e8a34b40e477f7f4608fa955447d82407"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b8a990256e575f3f5de80f115f607eb2c20b5b72","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[hacking]"},{"line_number":42,"context_line":"import_exceptions \u003d neutron_lib._i18n"},{"line_number":43,"context_line":"local-check-factory \u003d neutron_lib.hacking.checks.factory"}],"source_content_type":"text/x-properties","patch_set":4,"id":"7aa08908_a618b376","line":43,"in_reply_to":"7aa08908_74c04ee1","updated":"2016-06-10 12:25:16.000000000","message":"Done","commit_id":"3296a66e8a34b40e477f7f4608fa955447d82407"}]}
