)]}'
{"neutron_lib/hacking/checks.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f3dfebea8896adf0c11a56d02d755b6b1cd8f1f1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027reserved\u0027: \u0027_\u0027,  # this should never be used with a log unless"},{"line_number":41,"context_line":"                      # it is a variable used for a log message and"},{"line_number":42,"context_line":"                      # a exception"},{"line_number":43,"context_line":"    \u0027error\u0027: \u0027_LE\u0027,"},{"line_number":44,"context_line":"    \u0027info\u0027: \u0027_LI\u0027,"},{"line_number":45,"context_line":"    \u0027warning\u0027: \u0027_LW\u0027,"},{"line_number":46,"context_line":"    \u0027critical\u0027: \u0027_LC\u0027,"},{"line_number":47,"context_line":"    \u0027exception\u0027: \u0027_LE\u0027,"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":50,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_4160a4a5","line":47,"range":{"start_line":43,"start_character":4,"end_line":47,"end_character":23},"updated":"2016-06-07 15:08:50.000000000","message":"Could you sort these by priority or alphabetical order?\nThe current order looks random :(","commit_id":"a19efd29c171c805b7a592b278c296c54e656e28"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1275cd6654ad16bdbaba4011551a26db49d5c0ac","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027reserved\u0027: \u0027_\u0027,  # this should never be used with a log unless"},{"line_number":41,"context_line":"                      # it is a variable used for a log message and"},{"line_number":42,"context_line":"                      # a exception"},{"line_number":43,"context_line":"    \u0027error\u0027: \u0027_LE\u0027,"},{"line_number":44,"context_line":"    \u0027info\u0027: \u0027_LI\u0027,"},{"line_number":45,"context_line":"    \u0027warning\u0027: \u0027_LW\u0027,"},{"line_number":46,"context_line":"    \u0027critical\u0027: \u0027_LC\u0027,"},{"line_number":47,"context_line":"    \u0027exception\u0027: \u0027_LE\u0027,"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":50,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_07618cd3","line":47,"range":{"start_line":43,"start_character":4,"end_line":47,"end_character":23},"in_reply_to":"7aa08908_4160a4a5","updated":"2016-06-07 15:33:42.000000000","message":"Done","commit_id":"a19efd29c171c805b7a592b278c296c54e656e28"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"52c098f891988a33200b26d9d907b36716baaa1b","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"},{"line_number":68,"context_line":"    # Translations are not required in the test directory"},{"line_number":69,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":70,"context_line":"        return"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_c954c022","line":68,"range":{"start_line":68,"start_character":6,"end_line":68,"end_character":57},"updated":"2016-06-07 14:51:56.000000000","message":"This comment refers to a check that exists in neutron core but you removed:\n\n    if \"neutron/tests\" in filename:\n\n\nI think we can use the following for neutron-lib:\n\n    if \"/tests/\" in filename:\n\n\nThat should work for any project that for their test directories.","commit_id":"a19efd29c171c805b7a592b278c296c54e656e28"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2b6d7beb85a694a235b30c091ef69adc7a7a311d","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"},{"line_number":68,"context_line":"    # Translations are not required in the test directory"},{"line_number":69,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":70,"context_line":"        return"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_6db95179","line":68,"range":{"start_line":68,"start_character":6,"end_line":68,"end_character":57},"in_reply_to":"7aa08908_076b4c86","updated":"2016-06-07 16:03:45.000000000","message":"Well, I don\u0027t agree that we should enforce translations in test code.","commit_id":"a19efd29c171c805b7a592b278c296c54e656e28"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f3dfebea8896adf0c11a56d02d755b6b1cd8f1f1","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"},{"line_number":68,"context_line":"    # Translations are not required in the test directory"},{"line_number":69,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":70,"context_line":"        return"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_e118b077","line":68,"range":{"start_line":68,"start_character":6,"end_line":68,"end_character":57},"in_reply_to":"7aa08908_c954c022","updated":"2016-06-07 15:08:50.000000000","message":"In my understanding we plan to use these checks for all neutron related projects. In this case, there are two ways.\n\nThe one is what Henry suggested.\n\nThe other way is to get modulename from filename:\n\n  modulename \u003d os.path.normpath(filename).split(\u0027/\u0027)[0]","commit_id":"a19efd29c171c805b7a592b278c296c54e656e28"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1275cd6654ad16bdbaba4011551a26db49d5c0ac","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"},{"line_number":68,"context_line":"    # Translations are not required in the test directory"},{"line_number":69,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":70,"context_line":"        return"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_076b4c86","line":68,"range":{"start_line":68,"start_character":6,"end_line":68,"end_character":57},"in_reply_to":"7aa08908_e118b077","updated":"2016-06-07 15:33:42.000000000","message":"i think that we should enforce the rules across the code base. i\u0027ll blow away the comment.","commit_id":"a19efd29c171c805b7a592b278c296c54e656e28"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee418f094a56157ad7ac518591a59fec33edc5e9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \u0027warning\u0027: \u0027_LW\u0027,"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":50,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":51,"context_line":"log_warn \u003d re.compile("},{"line_number":52,"context_line":"    r\"(.)*LOG\\.(warn)\\(\\s*(\u0027|\\\"|_)\")"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_34fb0d49","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":20},"updated":"2016-06-07 18:09:14.000000000","message":"This is already defined on line 32. TBH I\u0027m not sure why its public to begin with; seems it should be private as its only accessed within this file and likely only should be.","commit_id":"31aa9752f9b6abb032f580a432598a1a2c4f6142"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b7a9f12e533bd3800961342a474f1761bbffee4b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \u0027warning\u0027: \u0027_LW\u0027,"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":50,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":51,"context_line":"log_warn \u003d re.compile("},{"line_number":52,"context_line":"    r\"(.)*LOG\\.(warn)\\(\\s*(\u0027|\\\"|_)\")"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_acd4d1bc","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":20},"in_reply_to":"7aa08908_34fb0d49","updated":"2016-06-07 19:03:12.000000000","message":"good catch","commit_id":"31aa9752f9b6abb032f580a432598a1a2c4f6142"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee418f094a56157ad7ac518591a59fec33edc5e9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":50,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":51,"context_line":"log_warn \u003d re.compile("},{"line_number":52,"context_line":"    r\"(.)*LOG\\.(warn)\\(\\s*(\u0027|\\\"|_)\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_94b9217c","line":51,"updated":"2016-06-07 18:09:14.000000000","message":"Do we really want this public? Seems like it should be private and not accessible outside this file.","commit_id":"31aa9752f9b6abb032f580a432598a1a2c4f6142"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b7a9f12e533bd3800961342a474f1761bbffee4b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":50,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":51,"context_line":"log_warn \u003d re.compile("},{"line_number":52,"context_line":"    r\"(.)*LOG\\.(warn)\\(\\s*(\u0027|\\\"|_)\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_0cdec5dc","line":51,"in_reply_to":"7aa08908_94b9217c","updated":"2016-06-07 19:03:12.000000000","message":"Done","commit_id":"31aa9752f9b6abb032f580a432598a1a2c4f6142"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee418f094a56157ad7ac518591a59fec33edc5e9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"log_translation_hint \u003d re.compile("},{"line_number":63,"context_line":"    \u0027|\u0027.join(\u0027(?:%s)\u0027 % _regex_for_level(level, hint)"},{"line_number":64,"context_line":"             for level, hint in six.iteritems(_all_log_levels)))"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_54517935","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":20},"updated":"2016-06-07 18:09:14.000000000","message":"Same comment as above W/R/T why we have this as public.","commit_id":"31aa9752f9b6abb032f580a432598a1a2c4f6142"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b7a9f12e533bd3800961342a474f1761bbffee4b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"log_translation_hint \u003d re.compile("},{"line_number":63,"context_line":"    \u0027|\u0027.join(\u0027(?:%s)\u0027 % _regex_for_level(level, hint)"},{"line_number":64,"context_line":"             for level, hint in six.iteritems(_all_log_levels)))"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_ecda59e7","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":20},"in_reply_to":"7aa08908_54517935","updated":"2016-06-07 19:03:12.000000000","message":"Done","commit_id":"31aa9752f9b6abb032f580a432598a1a2c4f6142"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e907bcbc6e1fef9980f9b0b77483d624e2b09147","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import re"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import pep8"},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Guidelines for writing new hacking checks"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_60be3300","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":10},"updated":"2016-06-08 13:43:09.000000000","message":"Not needed (see below).","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b62f0c8120f9186be348f33b0ac08ecd9a0bf05","unresolved":false,"context_lines":[{"line_number":35,"context_line":"namespace_imports_from_dot \u003d re.compile(r\"from[\\s]+([\\w]+)[.]\")"},{"line_number":36,"context_line":"namespace_imports_from_root \u003d re.compile(r\"from[\\s]+([\\w]+)[\\s]+import[\\s]+\")"},{"line_number":37,"context_line":"contextlib_nested \u003d re.compile(r\"^with (contextlib\\.)?nested\\(\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"_all_log_levels \u003d {"},{"line_number":40,"context_line":"    \u0027critical\u0027: \u0027_LC\u0027,"},{"line_number":41,"context_line":"    \u0027error\u0027: \u0027_LE\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_208d4bd6","line":38,"updated":"2016-06-08 13:53:36.000000000","message":"This module is becoming large and we have various constant definitions here. How about splitting the contents to multiple modules? In this case, check_log_translations.py or check_translations.py.","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f9e6288cc8a6214b8d78178b3b637601bc4fd912","unresolved":false,"context_lines":[{"line_number":35,"context_line":"namespace_imports_from_dot \u003d re.compile(r\"from[\\s]+([\\w]+)[.]\")"},{"line_number":36,"context_line":"namespace_imports_from_root \u003d re.compile(r\"from[\\s]+([\\w]+)[\\s]+import[\\s]+\")"},{"line_number":37,"context_line":"contextlib_nested \u003d re.compile(r\"^with (contextlib\\.)?nested\\(\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"_all_log_levels \u003d {"},{"line_number":40,"context_line":"    \u0027critical\u0027: \u0027_LC\u0027,"},{"line_number":41,"context_line":"    \u0027error\u0027: \u0027_LE\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_590e898c","line":38,"in_reply_to":"7aa08908_208d4bd6","updated":"2016-06-08 16:25:22.000000000","message":"nice idea","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e907bcbc6e1fef9980f9b0b77483d624e2b09147","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"_log_translation_hint \u003d re.compile("},{"line_number":62,"context_line":"    \u0027|\u0027.join(\u0027(?:%s)\u0027 % _regex_for_level(level, hint)"},{"line_number":63,"context_line":"             for level, hint in six.iteritems(_all_log_levels)))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_80d6bf4c","line":63,"range":{"start_line":63,"start_character":32,"end_line":63,"end_character":62},"updated":"2016-06-08 13:43:09.000000000","message":"Please change this to _all_log_levels.items()","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f9e6288cc8a6214b8d78178b3b637601bc4fd912","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"_log_translation_hint \u003d re.compile("},{"line_number":62,"context_line":"    \u0027|\u0027.join(\u0027(?:%s)\u0027 % _regex_for_level(level, hint)"},{"line_number":63,"context_line":"             for level, hint in six.iteritems(_all_log_levels)))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_397c5deb","line":63,"range":{"start_line":63,"start_character":32,"end_line":63,"end_character":62},"in_reply_to":"7aa08908_6093d3fa","updated":"2016-06-08 16:25:22.000000000","message":"Done","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b62f0c8120f9186be348f33b0ac08ecd9a0bf05","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"_log_translation_hint \u003d re.compile("},{"line_number":62,"context_line":"    \u0027|\u0027.join(\u0027(?:%s)\u0027 % _regex_for_level(level, hint)"},{"line_number":63,"context_line":"             for level, hint in six.iteritems(_all_log_levels)))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_6093d3fa","line":63,"range":{"start_line":63,"start_character":32,"end_line":63,"end_character":62},"in_reply_to":"7aa08908_80d6bf4c","updated":"2016-06-08 13:53:36.000000000","message":"+1","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b62f0c8120f9186be348f33b0ac08ecd9a0bf05","unresolved":false,"context_lines":[{"line_number":90,"context_line":"def check_log_warn_deprecated(logical_line, filename):"},{"line_number":91,"context_line":"    msg \u003d \"N532: Use LOG.warning due to compatibility with py3\""},{"line_number":92,"context_line":"    if _log_warn.match(logical_line):"},{"line_number":93,"context_line":"        yield (0, msg)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def use_jsonutils(logical_line, filename):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_6081138f","line":93,"updated":"2016-06-08 13:53:36.000000000","message":"N53x checks are placed before N52x. How about sort check methods in the order of the hacking rule number (if we keep having all checks in this file)?","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f9e6288cc8a6214b8d78178b3b637601bc4fd912","unresolved":false,"context_lines":[{"line_number":90,"context_line":"def check_log_warn_deprecated(logical_line, filename):"},{"line_number":91,"context_line":"    msg \u003d \"N532: Use LOG.warning due to compatibility with py3\""},{"line_number":92,"context_line":"    if _log_warn.match(logical_line):"},{"line_number":93,"context_line":"        yield (0, msg)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def use_jsonutils(logical_line, filename):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_9952b165","line":93,"in_reply_to":"7aa08908_6081138f","updated":"2016-06-08 16:25:22.000000000","message":"Done","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e907bcbc6e1fef9980f9b0b77483d624e2b09147","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"def check_python3_no_iteritems(logical_line):"},{"line_number":182,"context_line":"    if re.search(r\".*\\.iteritems\\(\\)\", logical_line):"},{"line_number":183,"context_line":"        msg \u003d (\"N527: Use six.iteritems() instead of dict.iteritems().\")"},{"line_number":184,"context_line":"        yield(0, msg)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_c0a72709","line":183,"updated":"2016-06-08 13:43:09.000000000","message":"This should end with \" for very large dictionaries. Use dict.items() unless you can prove that you need the optimization of an iterator for Python 2.\"\n\n\nBut that should be fixed in a separate patch.","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f9e6288cc8a6214b8d78178b3b637601bc4fd912","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"def check_python3_no_iteritems(logical_line):"},{"line_number":182,"context_line":"    if re.search(r\".*\\.iteritems\\(\\)\", logical_line):"},{"line_number":183,"context_line":"        msg \u003d (\"N527: Use six.iteritems() instead of dict.iteritems().\")"},{"line_number":184,"context_line":"        yield(0, msg)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_39661d2a","line":183,"in_reply_to":"7aa08908_c0a72709","updated":"2016-06-08 16:25:22.000000000","message":"i\u0027ll do this","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"}],"neutron_lib/hacking/translation_checks.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"29495e95436fd1e291237931592d19bd635a02e6","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"_log_translation_hint \u003d re.compile("},{"line_number":42,"context_line":"    \u0027|\u0027.join(\u0027(?:%s)\u0027 % _regex_for_level(level, hint)"},{"line_number":43,"context_line":"             for level, hint in _all_log_levels.iteritems()))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_50cad31b","line":43,"range":{"start_line":43,"start_character":48,"end_line":43,"end_character":57},"updated":"2016-06-08 18:50:39.000000000","message":"items! (in Python 3 dicts don\u0027t have iteritems)\n\n\nIt seems hacking checks do not check hacking checks code?","commit_id":"f0b2edde68cf767d028a36a021002358a76a6b11"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"bdb0601e2c266ba541ed8f24f7cb7cc5c6231a58","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"_log_translation_hint \u003d re.compile("},{"line_number":42,"context_line":"    \u0027|\u0027.join(\u0027(?:%s)\u0027 % _regex_for_level(level, hint)"},{"line_number":43,"context_line":"             for level, hint in _all_log_levels.iteritems()))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_9afbb978","line":43,"range":{"start_line":43,"start_character":48,"end_line":43,"end_character":57},"in_reply_to":"7aa08908_50cad31b","updated":"2016-06-08 18:55:21.000000000","message":"Please add this to the [hacking] section of tox.ini:\n\n\n  local-check-factory \u003d neutron_lib.hacking.checks.factory","commit_id":"f0b2edde68cf767d028a36a021002358a76a6b11"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1501e177cc88ae347fa47695ef248338a1084968","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"_log_translation_hint \u003d re.compile("},{"line_number":42,"context_line":"    \u0027|\u0027.join(\u0027(?:%s)\u0027 % _regex_for_level(level, hint)"},{"line_number":43,"context_line":"             for level, hint in _all_log_levels.iteritems()))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_25db6b7d","line":43,"range":{"start_line":43,"start_character":48,"end_line":43,"end_character":57},"in_reply_to":"7aa08908_9afbb978","updated":"2016-06-09 07:55:24.000000000","message":"Nice. Silly mistake on my behalf.","commit_id":"f0b2edde68cf767d028a36a021002358a76a6b11"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"090a2e353c4d9d17ecbd87d08181b8df4a97f51c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"             for level, hint in _all_log_levels.items()))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"},{"line_number":47,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":48,"context_line":"        return"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_1c45d716","line":46,"updated":"2016-06-09 14:39:39.000000000","message":"As mentioned in PS3, I too don\u0027t think we should check translation in test modules. Should we even be doing logging with translations in test modules?","commit_id":"fe203b454ceb7e0775d4941ce7b5bb5ff69010a5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8406389284b8f091345337386d7f4e37344fd59c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"             for level, hint in _all_log_levels.items()))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"},{"line_number":47,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":48,"context_line":"        return"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_1b78ddf1","line":46,"in_reply_to":"7aa08908_17c9f079","updated":"2016-06-11 07:21:08.000000000","message":"Done","commit_id":"fe203b454ceb7e0775d4941ce7b5bb5ff69010a5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b03634a44f12a081a8ae679459a9fcef2124a123","unresolved":false,"context_lines":[{"line_number":43,"context_line":"             for level, hint in _all_log_levels.items()))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"},{"line_number":47,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":48,"context_line":"        return"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_54fc323e","line":46,"in_reply_to":"7aa08908_1c45d716","updated":"2016-06-10 03:14:31.000000000","message":"+1\n\nI don\u0027t think we need to check translations in tests. There is no value to do so (from translator perspective).\n\nIn addition, it is better to keep compatibility in the current neutron hacking code.","commit_id":"fe203b454ceb7e0775d4941ce7b5bb5ff69010a5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"12e81a63aab16092c7c060b58759da77922d2444","unresolved":false,"context_lines":[{"line_number":43,"context_line":"             for level, hint in _all_log_levels.items()))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_log_translations(logical_line, physical_line, filename):"},{"line_number":47,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":48,"context_line":"        return"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_17c9f079","line":46,"in_reply_to":"7aa08908_54fc323e","updated":"2016-06-10 14:17:24.000000000","message":"OK, I agree, please use the same logic as https://review.openstack.org/#/c/325494/5/neutron_lib/hacking/checks.py","commit_id":"fe203b454ceb7e0775d4941ce7b5bb5ff69010a5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"10706f475fcc633ec3ba368cdcd8726371ae0de0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def _regex_for_level(level, hint):"},{"line_number":35,"context_line":"    return r\".*LOG\\.%(level)s\\(\\s*((%(wrong_hints)s)\\(|\u0027|\\\")\" % {"},{"line_number":36,"context_line":"        \u0027level\u0027: level,"},{"line_number":37,"context_line":"        \u0027wrong_hints\u0027: \u0027|\u0027.join(_all_hints - set([hint])),"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_41cccb34","line":37,"range":{"start_line":37,"start_character":45,"end_line":37,"end_character":56},"updated":"2016-06-14 14:37:06.000000000","message":"Nit: set([hint]) can be written as {hint}","commit_id":"b82347d5354e06d2497af66c8034db249bcdba47"}],"neutron_lib/tests/unit/hacking/test_checks.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"52c098f891988a33200b26d9d907b36716baaa1b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                1, len(list(checks.no_translate_debug_logs(bad, \u0027f\u0027))))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_check_log_warn_deprecated(self):"},{"line_number":140,"context_line":"        bad \u003d \"LOG.warn(_LW(\u0027i am zlatan!\u0027))\""},{"line_number":141,"context_line":"        self.assertEqual("},{"line_number":142,"context_line":"            1, len(list(checks.check_log_warn_deprecated(bad, \u0027f\u0027))))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_04086d90","line":140,"updated":"2016-06-07 14:51:56.000000000","message":"Are you a fan?","commit_id":"a19efd29c171c805b7a592b278c296c54e656e28"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1275cd6654ad16bdbaba4011551a26db49d5c0ac","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                1, len(list(checks.no_translate_debug_logs(bad, \u0027f\u0027))))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_check_log_warn_deprecated(self):"},{"line_number":140,"context_line":"        bad \u003d \"LOG.warn(_LW(\u0027i am zlatan!\u0027))\""},{"line_number":141,"context_line":"        self.assertEqual("},{"line_number":142,"context_line":"            1, len(list(checks.check_log_warn_deprecated(bad, \u0027f\u0027))))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_67ea10ae","line":140,"in_reply_to":"7aa08908_04086d90","updated":"2016-06-07 15:33:42.000000000","message":":) - he makes me laugh - and you know sometimes one needs a good laugh - https://www.youtube.com/watch?v\u003d6OZguv2uDoE","commit_id":"a19efd29c171c805b7a592b278c296c54e656e28"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2b6d7beb85a694a235b30c091ef69adc7a7a311d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                1, len(list(checks.no_translate_debug_logs(bad, \u0027f\u0027))))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_check_log_warn_deprecated(self):"},{"line_number":140,"context_line":"        bad \u003d \"LOG.warn(_LW(\u0027i am zlatan!\u0027))\""},{"line_number":141,"context_line":"        self.assertEqual("},{"line_number":142,"context_line":"            1, len(list(checks.check_log_warn_deprecated(bad, \u0027f\u0027))))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_ede0a198","line":140,"in_reply_to":"7aa08908_67ea10ae","updated":"2016-06-07 16:03:45.000000000","message":":) He is certainly a big fan of himself. :)","commit_id":"a19efd29c171c805b7a592b278c296c54e656e28"}],"requirements.txt":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a8e65a5f000aece44d6ff0d84093e10f0ec616b1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"pbr\u003e\u003d1.6 # Apache-2.0"},{"line_number":6,"context_line":"Babel\u003e\u003d2.3.4 # BSD"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":9,"context_line":"debtcollector\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.config\u003e\u003d3.9.0 # Apache-2.0"},{"line_number":11,"context_line":"oslo.db\u003e\u003d4.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7aa08908_05e99de6","line":8,"updated":"2016-06-07 10:32:14.000000000","message":"Isn\u0027t it better to use the alphabetical order?","commit_id":"f1b456cbfb6b471eff9c13790c1be625c9ad2560"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3f3c16ebd59ed829fd4fc9222ad0304ca1e4a052","unresolved":false,"context_lines":[{"line_number":5,"context_line":"pbr\u003e\u003d1.6 # Apache-2.0"},{"line_number":6,"context_line":"Babel\u003e\u003d2.3.4 # BSD"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":9,"context_line":"debtcollector\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.config\u003e\u003d3.9.0 # Apache-2.0"},{"line_number":11,"context_line":"oslo.db\u003e\u003d4.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7aa08908_fec4df5f","line":8,"in_reply_to":"7aa08908_05e99de6","updated":"2016-06-07 12:08:32.000000000","message":"Done","commit_id":"f1b456cbfb6b471eff9c13790c1be625c9ad2560"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee418f094a56157ad7ac518591a59fec33edc5e9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"oslo.log\u003e\u003d1.14.0 # Apache-2.0"},{"line_number":13,"context_line":"oslo.messaging\u003e\u003d4.5.0 # Apache-2.0"},{"line_number":14,"context_line":"oslo.utils\u003e\u003d3.5.0 # Apache-2.0"},{"line_number":15,"context_line":"six\u003e\u003d1.9.0 # MIT"}],"source_content_type":"text/plain","patch_set":4,"id":"7aa08908_7484755d","line":15,"updated":"2016-06-07 18:09:14.000000000","message":"Neutron requirements have six before oslo, does it matter?\nSee:\nhttps://github.com/openstack/neutron/blob/master/requirements.txt#L28","commit_id":"31aa9752f9b6abb032f580a432598a1a2c4f6142"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b7a9f12e533bd3800961342a474f1761bbffee4b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"oslo.log\u003e\u003d1.14.0 # Apache-2.0"},{"line_number":13,"context_line":"oslo.messaging\u003e\u003d4.5.0 # Apache-2.0"},{"line_number":14,"context_line":"oslo.utils\u003e\u003d3.5.0 # Apache-2.0"},{"line_number":15,"context_line":"six\u003e\u003d1.9.0 # MIT"}],"source_content_type":"text/plain","patch_set":4,"id":"7aa08908_6cce692f","line":15,"in_reply_to":"7aa08908_7484755d","updated":"2016-06-07 19:03:12.000000000","message":"i originally did it in that order and akihiro asked me to do in alphabetical order.\nwhen the background job updates when there is a change it will write this in the \"correct\" place","commit_id":"31aa9752f9b6abb032f580a432598a1a2c4f6142"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e907bcbc6e1fef9980f9b0b77483d624e2b09147","unresolved":false,"context_lines":[{"line_number":12,"context_line":"oslo.log\u003e\u003d1.14.0 # Apache-2.0"},{"line_number":13,"context_line":"oslo.messaging\u003e\u003d4.5.0 # Apache-2.0"},{"line_number":14,"context_line":"oslo.utils\u003e\u003d3.5.0 # Apache-2.0"},{"line_number":15,"context_line":"six\u003e\u003d1.9.0 # MIT"}],"source_content_type":"text/plain","patch_set":5,"id":"7aa08908_a03adb96","line":15,"updated":"2016-06-08 13:43:09.000000000","message":"Not needed.","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f9e6288cc8a6214b8d78178b3b637601bc4fd912","unresolved":false,"context_lines":[{"line_number":12,"context_line":"oslo.log\u003e\u003d1.14.0 # Apache-2.0"},{"line_number":13,"context_line":"oslo.messaging\u003e\u003d4.5.0 # Apache-2.0"},{"line_number":14,"context_line":"oslo.utils\u003e\u003d3.5.0 # Apache-2.0"},{"line_number":15,"context_line":"six\u003e\u003d1.9.0 # MIT"}],"source_content_type":"text/plain","patch_set":5,"id":"7aa08908_392e1dfb","line":15,"in_reply_to":"7aa08908_a03adb96","updated":"2016-06-08 16:25:22.000000000","message":"Done","commit_id":"42900d80c8ec12e3ea4d563e2cb66e8e84d10de5"}],"tox.ini":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"23c1d442de940da894dfbe48429682d9952d1a32","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[hacking]"},{"line_number":42,"context_line":"import_exceptions \u003d neutron_lib._i18n"},{"line_number":43,"context_line":"local-check-factory \u003d neutron_lib.hacking.checks.factory"}],"source_content_type":"text/x-properties","patch_set":7,"id":"7aa08908_e2b94e7b","line":43,"updated":"2016-06-09 11:12:24.000000000","message":"I see Akihiro submitted a separate patch for this, https://review.openstack.org/327508\n\nI think it is better to have it separate as it is not strictly part of your patch. Do you mind reverting this?","commit_id":"f88009f83538c28e5153a29a6b1c19e70c70928e"}]}
