)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"32264c797d953d5a6381c442fa6f6d86be7c6a04","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Henry Gessau \u003cgessau@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-15 15:18:47 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make the constant Sentinal() class public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This pattern can be useful so make it publicly available."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_272ea4a5","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":26},"updated":"2016-06-15 19:22:59.000000000","message":"*Sentinel","commit_id":"c3b23e39adcdf98772a4936b96443626f31151bc"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7b373c02adc50296d375e22e12548bd1136af8fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Henry Gessau \u003cgessau@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-15 15:18:47 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make the constant Sentinal() class public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This pattern can be useful so make it publicly available."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_193af098","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":26},"in_reply_to":"7aa08908_272ea4a5","updated":"2016-06-15 19:28:11.000000000","message":"Done","commit_id":"c3b23e39adcdf98772a4936b96443626f31151bc"}],"neutron_lib/constants.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f28e0fa85008948968a6eadda0a8653966a8c974","unresolved":false,"context_lines":[{"line_number":241,"context_line":"ISO8601_TIME_FORMAT \u003d \u0027%Y-%m-%dT%H:%M:%S.%f\u0027"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"class Sentinel(object):"},{"line_number":245,"context_line":"    \"\"\"A constant object that does not change even when copied.\"\"\""},{"line_number":246,"context_line":"    def __deepcopy__(self, memo):"},{"line_number":247,"context_line":"        # Always return the same object because this is essentially a constant."}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d44870b5","line":244,"range":{"start_line":244,"start_character":6,"end_line":244,"end_character":14},"updated":"2016-06-08 21:03:14.000000000","message":"I noticed we don\u0027t have any unit tests for this class.\nDo you think it\u0027s trivial enough that it doesn\u0027t need a UT or 2, or should we add them for good measures?","commit_id":"eb53d11977f50a5b3337f425cd26985932fec6a9"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1f427d67a7d6bc81bab938bd372ebdfa4d71f72f","unresolved":false,"context_lines":[{"line_number":241,"context_line":"ISO8601_TIME_FORMAT \u003d \u0027%Y-%m-%dT%H:%M:%S.%f\u0027"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"class Sentinel(object):"},{"line_number":245,"context_line":"    \"\"\"A constant object that does not change even when copied.\"\"\""},{"line_number":246,"context_line":"    def __deepcopy__(self, memo):"},{"line_number":247,"context_line":"        # Always return the same object because this is essentially a constant."}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_6f7ba57b","line":244,"range":{"start_line":244,"start_character":6,"end_line":244,"end_character":14},"in_reply_to":"7aa08908_d44870b5","updated":"2016-06-08 21:11:26.000000000","message":"Definitely needs unit tests.","commit_id":"eb53d11977f50a5b3337f425cd26985932fec6a9"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"56dd8e5f5eba505c7c00b0c7f6ccfdbec7dabf1f","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"class Sentinel(object):"},{"line_number":245,"context_line":"    \"\"\"A constant object that does not change even when copied.\"\"\""},{"line_number":246,"context_line":"    def __deepcopy__(self, memo):"},{"line_number":247,"context_line":"        # Always return the same object because this is essentially a constant."},{"line_number":248,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_762659bb","line":245,"updated":"2016-06-11 03:16:05.000000000","message":"Does this class deserve to be in its own module? Importing constants for this seems odd.","commit_id":"eb53d11977f50a5b3337f425cd26985932fec6a9"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7f4dab33c46c591ea6862b4f5fa551d0b71744cb","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"class Sentinel(object):"},{"line_number":245,"context_line":"    \"\"\"A constant object that does not change even when copied.\"\"\""},{"line_number":246,"context_line":"    def __deepcopy__(self, memo):"},{"line_number":247,"context_line":"        # Always return the same object because this is essentially a constant."},{"line_number":248,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_24de1411","line":245,"in_reply_to":"7aa08908_474a8284","updated":"2016-06-13 22:49:23.000000000","message":"My vote is to leave it here publicly defined since its primary use case is for defining a constant.","commit_id":"eb53d11977f50a5b3337f425cd26985932fec6a9"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c65bbd5bf110ca3623d924464b5f1bf1ddd0e6b1","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"class Sentinel(object):"},{"line_number":245,"context_line":"    \"\"\"A constant object that does not change even when copied.\"\"\""},{"line_number":246,"context_line":"    def __deepcopy__(self, memo):"},{"line_number":247,"context_line":"        # Always return the same object because this is essentially a constant."},{"line_number":248,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_474a8284","line":245,"in_reply_to":"7aa08908_762659bb","updated":"2016-06-11 18:27:18.000000000","message":"Currently this module (constants.py) does not import anything. I think it would be good to keep it that way. Moving Sentinel to another module would require an import here.\n\n\nWhich option should we pick?\n* Move Sentinel to another module and import it here.\n* Allow Sentinel to be publicly defined here.\n* Just leave _Sentinel private here?\n\n\nEither way, it needs tests.","commit_id":"eb53d11977f50a5b3337f425cd26985932fec6a9"}],"neutron_lib/tests/unit/test_neutron_lib.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"32264c797d953d5a6381c442fa6f6d86be7c6a04","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestNeutronLib(base.BaseTestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_sentinal_constant(self):"},{"line_number":25,"context_line":"        foo \u003d constants.Sentinel()"},{"line_number":26,"context_line":"        bar \u003d copy.deepcopy(foo)"},{"line_number":27,"context_line":"        self.assertEqual(id(foo), id(bar))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_6716ec59","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":21},"updated":"2016-06-15 19:22:59.000000000","message":"*sentinel","commit_id":"c3b23e39adcdf98772a4936b96443626f31151bc"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7b373c02adc50296d375e22e12548bd1136af8fc","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestNeutronLib(base.BaseTestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_sentinal_constant(self):"},{"line_number":25,"context_line":"        foo \u003d constants.Sentinel()"},{"line_number":26,"context_line":"        bar \u003d copy.deepcopy(foo)"},{"line_number":27,"context_line":"        self.assertEqual(id(foo), id(bar))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_5944781a","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":21},"in_reply_to":"7aa08908_6716ec59","updated":"2016-06-15 19:28:11.000000000","message":"Done","commit_id":"c3b23e39adcdf98772a4936b96443626f31151bc"}]}
