)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ca82ae6b180cd1b1a3182633f43134abfe1af98","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Forbid eventlet hacking check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As per [1] we are not allowing eventlet based code in neutron-lib."},{"line_number":10,"context_line":"This patch adds a hacking check to ensure no eventlet based imports"},{"line_number":11,"context_line":"are brought into neutron-lib. This check is added to the neutron-lib"},{"line_number":12,"context_line":"internal checks as consumers are not likely to forbid eventlet yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_1d1daebd","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":11},"updated":"2016-08-03 10:09:10.000000000","message":"There is no real reference for [1].","commit_id":"36474c7409c4b95c096bf5a39d41c6c3cb25e6d8"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fdf0b7b18b2a889683d7a359218c90323235c93f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Forbid eventlet hacking check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As per [1] we are not allowing eventlet based code in neutron-lib."},{"line_number":10,"context_line":"This patch adds a hacking check to ensure no eventlet based imports"},{"line_number":11,"context_line":"are brought into neutron-lib. This check is added to the neutron-lib"},{"line_number":12,"context_line":"internal checks as consumers are not likely to forbid eventlet yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_76304708","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":11},"in_reply_to":"bacf61ea_1d1daebd","updated":"2016-08-03 10:54:40.000000000","message":"Done","commit_id":"36474c7409c4b95c096bf5a39d41c6c3cb25e6d8"}],"neutron_lib/hacking/checks.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4fe56023caa7162fd394c0992d8d91e5792e4eff","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def check_no_eventlet_imports(logical_line):"},{"line_number":152,"context_line":"    \"\"\"N535 - Usage of Python eventlet module not allowed.\"\"\""},{"line_number":153,"context_line":"    words \u003d logical_line.split()"},{"line_number":154,"context_line":"    if logical_line.startswith((\u0027import\u0027, \u0027from\u0027)) and len(words) \u003e 1:"},{"line_number":155,"context_line":"        pkg \u003d words[1].split(\u0027.\u0027) if words[1].find(\u0027.\u0027) \u003e 0 else [words[1]]"},{"line_number":156,"context_line":"        if pkg[0] \u003d\u003d \u0027eventlet\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_e58203fe","line":153,"updated":"2016-07-01 12:01:20.000000000","message":"Maybe replace all this with...\n    if re.match(r\u0027(import|from)\\s+[(]?eventlet\u0027, logical_line):\n        msg \u003d ...","commit_id":"42882216c361040625bcffa937242cc08c10d76e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ec5d623ef9882a3e3b616db6e4b9197f983b6586","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def check_no_eventlet_imports(logical_line):"},{"line_number":152,"context_line":"    \"\"\"N535 - Usage of Python eventlet module not allowed.\"\"\""},{"line_number":153,"context_line":"    words \u003d logical_line.split()"},{"line_number":154,"context_line":"    if logical_line.startswith((\u0027import\u0027, \u0027from\u0027)) and len(words) \u003e 1:"},{"line_number":155,"context_line":"        pkg \u003d words[1].split(\u0027.\u0027) if words[1].find(\u0027.\u0027) \u003e 0 else [words[1]]"},{"line_number":156,"context_line":"        if pkg[0] \u003d\u003d \u0027eventlet\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_7dc9cc58","line":153,"in_reply_to":"3aaa91ec_e58203fe","updated":"2016-07-06 19:27:53.000000000","message":"Nice; thanks!","commit_id":"42882216c361040625bcffa937242cc08c10d76e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"aedf4380dfc02b5890949bcc1961aee17654e26e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    \"\"\"N535 - Usage of Python eventlet module not allowed.\"\"\""},{"line_number":153,"context_line":"    words \u003d logical_line.split()"},{"line_number":154,"context_line":"    if logical_line.startswith((\u0027import\u0027, \u0027from\u0027)) and len(words) \u003e 1:"},{"line_number":155,"context_line":"        pkg \u003d words[1].split(\u0027.\u0027) if words[1].find(\u0027.\u0027) \u003e 0 else [words[1]]"},{"line_number":156,"context_line":"        if pkg[0] \u003d\u003d \u0027eventlet\u0027:"},{"line_number":157,"context_line":"            msg \u003d \u0027N535: Usage of Python eventlet module not allowed\u0027"},{"line_number":158,"context_line":"            yield logical_line.index(\u0027eventlet\u0027), msg"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_accbf170","line":155,"range":{"start_line":155,"start_character":33,"end_line":155,"end_character":75},"updated":"2016-06-30 17:53:24.000000000","message":"You don\u0027t need the if ... stuff.\n\n \u003e\u003e\u003e \"foo\".split(\u0027.\u0027)\n [\u0027foo\u0027]","commit_id":"42882216c361040625bcffa937242cc08c10d76e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ec5d623ef9882a3e3b616db6e4b9197f983b6586","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    \"\"\"N535 - Usage of Python eventlet module not allowed.\"\"\""},{"line_number":153,"context_line":"    words \u003d logical_line.split()"},{"line_number":154,"context_line":"    if logical_line.startswith((\u0027import\u0027, \u0027from\u0027)) and len(words) \u003e 1:"},{"line_number":155,"context_line":"        pkg \u003d words[1].split(\u0027.\u0027) if words[1].find(\u0027.\u0027) \u003e 0 else [words[1]]"},{"line_number":156,"context_line":"        if pkg[0] \u003d\u003d \u0027eventlet\u0027:"},{"line_number":157,"context_line":"            msg \u003d \u0027N535: Usage of Python eventlet module not allowed\u0027"},{"line_number":158,"context_line":"            yield logical_line.index(\u0027eventlet\u0027), msg"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_ddc28033","line":155,"range":{"start_line":155,"start_character":33,"end_line":155,"end_character":75},"in_reply_to":"3aaa91ec_accbf170","updated":"2016-07-06 19:27:53.000000000","message":"Done","commit_id":"42882216c361040625bcffa937242cc08c10d76e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ca82ae6b180cd1b1a3182633f43134abfe1af98","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    if re.match(r\u0027(import|from)\\s+[(]?eventlet\u0027, logical_line):"},{"line_number":185,"context_line":"        msg \u003d \u0027N535: Usage of Python eventlet module not allowed\u0027"},{"line_number":186,"context_line":"        yield logical_line.index(\u0027eventlet\u0027), msg"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"ALL_CHECKS \u003d set([use_jsonutils,"},{"line_number":189,"context_line":"                  check_no_contextlib_nested,"},{"line_number":190,"context_line":"                  check_python3_xrange,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_c0f20d06","line":187,"updated":"2016-08-03 10:09:10.000000000","message":"nit question: don\u0027t we need two blank lines here?","commit_id":"36474c7409c4b95c096bf5a39d41c6c3cb25e6d8"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fdf0b7b18b2a889683d7a359218c90323235c93f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    if re.match(r\u0027(import|from)\\s+[(]?eventlet\u0027, logical_line):"},{"line_number":185,"context_line":"        msg \u003d \u0027N535: Usage of Python eventlet module not allowed\u0027"},{"line_number":186,"context_line":"        yield logical_line.index(\u0027eventlet\u0027), msg"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"ALL_CHECKS \u003d set([use_jsonutils,"},{"line_number":189,"context_line":"                  check_no_contextlib_nested,"},{"line_number":190,"context_line":"                  check_python3_xrange,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_76bb2776","line":187,"in_reply_to":"bacf61ea_c0f20d06","updated":"2016-08-03 10:54:40.000000000","message":"Done","commit_id":"36474c7409c4b95c096bf5a39d41c6c3cb25e6d8"}],"neutron_lib/tests/unit/hacking/test_checks.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4fe56023caa7162fd394c0992d8d91e5792e4eff","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_check_eventlet_imports(self):"},{"line_number":171,"context_line":"        f \u003d checks.check_no_eventlet_imports"},{"line_number":172,"context_line":"        self.assertLineFails(f, \"import eventlet\")"},{"line_number":173,"context_line":"        self.assertLineFails(f, \"import eventlet.timeout\")"},{"line_number":174,"context_line":"        self.assertLineFails(f, \"from eventlet import timeout\")"},{"line_number":175,"context_line":"        self.assertLineFails(f, \"from eventlet.timeout import Timeout\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_a5e11bd2","line":172,"updated":"2016-07-01 12:01:20.000000000","message":"Maybe add an example with parenthesis (probably won\u0027t have one for this import, though).","commit_id":"42882216c361040625bcffa937242cc08c10d76e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ec5d623ef9882a3e3b616db6e4b9197f983b6586","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_check_eventlet_imports(self):"},{"line_number":171,"context_line":"        f \u003d checks.check_no_eventlet_imports"},{"line_number":172,"context_line":"        self.assertLineFails(f, \"import eventlet\")"},{"line_number":173,"context_line":"        self.assertLineFails(f, \"import eventlet.timeout\")"},{"line_number":174,"context_line":"        self.assertLineFails(f, \"from eventlet import timeout\")"},{"line_number":175,"context_line":"        self.assertLineFails(f, \"from eventlet.timeout import Timeout\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_3db3c4ea","line":172,"in_reply_to":"3aaa91ec_a5e11bd2","updated":"2016-07-06 19:27:53.000000000","message":"Done","commit_id":"42882216c361040625bcffa937242cc08c10d76e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ef1a097460a349713f61e2a805fe345d83f3061b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                              \u0027neutron_lib/tests/unit/mytest.py\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_check_eventlet_imports(self):"},{"line_number":171,"context_line":"        f \u003d checks.check_no_eventlet_imports"},{"line_number":172,"context_line":"        self.assertLineFails(f, \"import eventlet\")"},{"line_number":173,"context_line":"        self.assertLineFails(f, \"import eventlet.timeout\")"},{"line_number":174,"context_line":"        self.assertLineFails(f, \"from eventlet import timeout\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_d1b6a4f8","line":171,"range":{"start_line":171,"start_character":18,"end_line":171,"end_character":19},"updated":"2016-07-13 18:04:58.000000000","message":"I personally don\u0027t like asserting multiple conditions in a single test case, but I see this done all over the place.","commit_id":"b81ac16f2e4ae9541dbd7b3b09f7617dff840681"}]}
