)]}'
{"api-ref/source/v2/networks.inc":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"62f79c5ac5a6b513ec42cda6d6d6fd22b67d7606","unresolved":false,"context_lines":[{"line_number":191,"context_line":"another tenant UUID, which is the tenant who owns the network, in"},{"line_number":192,"context_line":"the request body."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Normal response codes:201"},{"line_number":195,"context_line":"Error response codes:400,401,"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Request"},{"line_number":198,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1aa78d24_5b5d8a78","line":195,"range":{"start_line":194,"start_character":0,"end_line":195,"end_character":29},"updated":"2016-07-15 00:10:27.000000000","message":"This is RST document, so you need to add a blank line between L.194 and 195.\n\nWe need to check the rendered version of API ref too.","commit_id":"3b8c94463d3a21a3b7fc982b2c7be1c232835597"},{"author":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"change_message_id":"398b9a34625605ec70ad9f9a88542385bbd7e674","unresolved":false,"context_lines":[{"line_number":191,"context_line":"another tenant UUID, which is the tenant who owns the network, in"},{"line_number":192,"context_line":"the request body."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Normal response codes:201"},{"line_number":195,"context_line":"Error response codes:400,401,"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Request"},{"line_number":198,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"dada55a8_576edc96","line":195,"range":{"start_line":194,"start_character":0,"end_line":195,"end_character":29},"in_reply_to":"1aa78d24_5b5d8a78","updated":"2016-07-19 03:43:33.000000000","message":"You also want to delete the trailing comma, it\u0027s not needed.","commit_id":"3b8c94463d3a21a3b7fc982b2c7be1c232835597"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"023356cb28c0b067e26e81968c53d7361ed3c06c","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"   - router:external: router:external"},{"line_number":203,"context_line":"   - name: name"},{"line_number":204,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":205,"context_line":"   - tenant_id: tenant_id"},{"line_number":206,"context_line":"   - qos_policy_id: qos_policy_id"},{"line_number":207,"context_line":"   - shared: shared"},{"line_number":208,"context_line":"   - networks: network"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Request Example"},{"line_number":211,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1aa78d24_62a84ddc","line":208,"range":{"start_line":202,"start_character":0,"end_line":208,"end_character":22},"updated":"2016-07-11 14:50:27.000000000","message":"Is the ordering irrelevant here; or might it make sense to list alphabetically?","commit_id":"3b8c94463d3a21a3b7fc982b2c7be1c232835597"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"023356cb28c0b067e26e81968c53d7361ed3c06c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"   - tenant_id: tenant_id"},{"line_number":206,"context_line":"   - qos_policy_id: qos_policy_id"},{"line_number":207,"context_line":"   - shared: shared"},{"line_number":208,"context_line":"   - networks: network"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Request Example"},{"line_number":211,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1aa78d24_ee7c29b7","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":13},"updated":"2016-07-11 14:50:27.000000000","message":"Should this \u0027s\u0027 be there? (e.g. should \u0027networks\u0027 really be \u0027network\u0027)","commit_id":"3b8c94463d3a21a3b7fc982b2c7be1c232835597"},{"author":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"change_message_id":"398b9a34625605ec70ad9f9a88542385bbd7e674","unresolved":false,"context_lines":[{"line_number":205,"context_line":"   - tenant_id: tenant_id"},{"line_number":206,"context_line":"   - qos_policy_id: qos_policy_id"},{"line_number":207,"context_line":"   - shared: shared"},{"line_number":208,"context_line":"   - networks: network"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Request Example"},{"line_number":211,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"dada55a8_1713c40e","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":13},"in_reply_to":"1aa78d24_3bc51e0a","updated":"2016-07-19 03:43:33.000000000","message":"I think the tool requires these parameter names to be alphabetical now.","commit_id":"3b8c94463d3a21a3b7fc982b2c7be1c232835597"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"62f79c5ac5a6b513ec42cda6d6d6fd22b67d7606","unresolved":false,"context_lines":[{"line_number":205,"context_line":"   - tenant_id: tenant_id"},{"line_number":206,"context_line":"   - qos_policy_id: qos_policy_id"},{"line_number":207,"context_line":"   - shared: shared"},{"line_number":208,"context_line":"   - networks: network"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Request Example"},{"line_number":211,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1aa78d24_3bc51e0a","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":13},"in_reply_to":"1aa78d24_ee7c29b7","updated":"2016-07-15 00:10:27.000000000","message":"nteworks -\u003e network\n\n\"network\" should be placed first because it is a container of the other attributes.","commit_id":"3b8c94463d3a21a3b7fc982b2c7be1c232835597"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d36b15d5334118f13655931082061eb730df56d8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"   - tenant_id: tenant_id"},{"line_number":206,"context_line":"   - qos_policy_id: qos_policy_id"},{"line_number":207,"context_line":"   - shared: shared"},{"line_number":208,"context_line":"   - networks: network"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Request Example"},{"line_number":211,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"dada55a8_f7a1d0aa","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":13},"in_reply_to":"dada55a8_1713c40e","updated":"2016-07-19 03:48:02.000000000","message":"It sounds odd just to sort parameters in the alphabetical order\nbecause \u0027network\u0027 (in this case) is the top level object.\nPlacing \u0027network\u0027 in the middle of parameters confuses the readers of the API ref.","commit_id":"3b8c94463d3a21a3b7fc982b2c7be1c232835597"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"83f865ccd36e176e2c2962bb35b42ff912135a05","unresolved":false,"context_lines":[{"line_number":191,"context_line":"another tenant UUID, which is the tenant who owns the network, in"},{"line_number":192,"context_line":"the request body."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Normal response codes:201"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Error response codes:400,401"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dada55a8_dc9acd62","line":194,"range":{"start_line":194,"start_character":22,"end_line":194,"end_character":25},"updated":"2016-07-19 15:59:31.000000000","message":"Should we have a space after the \u0027:\u0027 ?","commit_id":"7898bc62e92c562b5d2784a0383e66f7c16059fe"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"83f865ccd36e176e2c2962bb35b42ff912135a05","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Normal response codes:201"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Error response codes:400,401"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Request"},{"line_number":199,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dada55a8_bc9d595b","line":196,"range":{"start_line":196,"start_character":20,"end_line":196,"end_character":21},"updated":"2016-07-19 15:59:31.000000000","message":"Should we have a space after the \u0027:\u0027 ?","commit_id":"7898bc62e92c562b5d2784a0383e66f7c16059fe"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4dca767d1da19d6879c6cdb6d07e73cd04d552ed","unresolved":false,"context_lines":[{"line_number":207,"context_line":"   - router:external: router:external"},{"line_number":208,"context_line":"   - shared: shared"},{"line_number":209,"context_line":"   - tenant_id: tenant_id"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Request Example"},{"line_number":212,"context_line":"---------------"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dada55a8_efc05e52","line":210,"updated":"2016-07-21 01:00:20.000000000","message":"I noticed some missing pieces, which are availability_zone_hints, provider:network_type, provider:physical_network, provider:segmentation_id, port_security_enabled, and so on. These are extensions so I\u0027m not sure they should be described as default. However, at least we should make it consitent.","commit_id":"7898bc62e92c562b5d2784a0383e66f7c16059fe"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"997bed98c32e72bc673923056417094889e16f99","unresolved":false,"context_lines":[{"line_number":207,"context_line":"   - router:external: router:external"},{"line_number":208,"context_line":"   - shared: shared"},{"line_number":209,"context_line":"   - tenant_id: tenant_id"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Request Example"},{"line_number":212,"context_line":"---------------"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dada55a8_28084791","line":210,"in_reply_to":"dada55a8_06a134f8","updated":"2016-07-22 16:42:20.000000000","message":"As a user, I\u0027d like to see the ext attributes listed here as a link to the corresponding v2-ext for it (if applicable). That way I see all the attrs here and also understand which are extensions and I can follow the link to get more info on a particular ext attr if needed.\n\n\nIsn\u0027t nova listing all attrs [1]?\n\n[1] https://github.com/openstack/nova/blob/master/api-ref/source/servers.inc","commit_id":"7898bc62e92c562b5d2784a0383e66f7c16059fe"},{"author":{"_account_id":12362,"name":"Danny Choi","email":"dannchoi@cisco.com","username":"dannychoi-cisco"},"change_message_id":"eae5a177159828e1a0aeaa61c9c4abf45d66e379","unresolved":false,"context_lines":[{"line_number":207,"context_line":"   - router:external: router:external"},{"line_number":208,"context_line":"   - shared: shared"},{"line_number":209,"context_line":"   - tenant_id: tenant_id"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Request Example"},{"line_number":212,"context_line":"---------------"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dada55a8_c7939f59","line":210,"in_reply_to":"dada55a8_2cf1c0cd","updated":"2016-07-21 14:51:21.000000000","message":"If they are extensions, they should be handled in v2-ext/, just like the provider network related attributes.  They are probably missing now.  However, if everyone agreed they should be included here, I have no problem adding them.","commit_id":"7898bc62e92c562b5d2784a0383e66f7c16059fe"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"437b3a4f1febb316c2b340b228001392e393da84","unresolved":false,"context_lines":[{"line_number":207,"context_line":"   - router:external: router:external"},{"line_number":208,"context_line":"   - shared: shared"},{"line_number":209,"context_line":"   - tenant_id: tenant_id"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Request Example"},{"line_number":212,"context_line":"---------------"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dada55a8_06a134f8","line":210,"in_reply_to":"dada55a8_bd431bae","updated":"2016-07-21 16:27:42.000000000","message":"It\u0027s what I want to discuss. IMO, I would prefer to describe network API here without extensions and it\u0027s better to put all API with extensions parameter into v2-ext. On the other hand, I think that most users doesn\u0027t use Neutron without extensions, for instance, external_net(router:external).","commit_id":"7898bc62e92c562b5d2784a0383e66f7c16059fe"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5fc6c3d0704548f9d07eb93d3ce119721f66a26a","unresolved":false,"context_lines":[{"line_number":207,"context_line":"   - router:external: router:external"},{"line_number":208,"context_line":"   - shared: shared"},{"line_number":209,"context_line":"   - tenant_id: tenant_id"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Request Example"},{"line_number":212,"context_line":"---------------"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dada55a8_bd431bae","line":210,"in_reply_to":"dada55a8_c7939f59","updated":"2016-07-21 15:41:07.000000000","message":"This brings up a philosophical question of how to document extension attributes. Should we list all network extension attributes here? Or provide a list of refs to extensions that extend network? How do other projects do it?","commit_id":"7898bc62e92c562b5d2784a0383e66f7c16059fe"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"63645c8b9d31f9d1c7de11ec17d42a053c51f3de","unresolved":false,"context_lines":[{"line_number":207,"context_line":"   - router:external: router:external"},{"line_number":208,"context_line":"   - shared: shared"},{"line_number":209,"context_line":"   - tenant_id: tenant_id"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Request Example"},{"line_number":212,"context_line":"---------------"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dada55a8_2cf1c0cd","line":210,"in_reply_to":"dada55a8_db3f00b2","updated":"2016-07-21 14:32:53.000000000","message":"Right! The others?","commit_id":"7898bc62e92c562b5d2784a0383e66f7c16059fe"},{"author":{"_account_id":12362,"name":"Danny Choi","email":"dannchoi@cisco.com","username":"dannychoi-cisco"},"change_message_id":"971b87c88806eeb58866e8f9ec6e017075667d3c","unresolved":false,"context_lines":[{"line_number":207,"context_line":"   - router:external: router:external"},{"line_number":208,"context_line":"   - shared: shared"},{"line_number":209,"context_line":"   - tenant_id: tenant_id"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Request Example"},{"line_number":212,"context_line":"---------------"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dada55a8_db3f00b2","line":210,"in_reply_to":"dada55a8_efc05e52","updated":"2016-07-21 13:43:21.000000000","message":"provider network related attributes are covered in v2-ext/network-provider.inc","commit_id":"7898bc62e92c562b5d2784a0383e66f7c16059fe"}]}
