)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0d5b998f0661593c666818f62713de983cd34419","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pablo Iranzo Gómez \u003cPablo.Iranzo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-15 17:50:15 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add validation of data within values to validators"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change validates that the \u0027data\u0027 provided to each validator is within the"},{"line_number":10,"context_line":"list of valid values for some functions which were just ignoring it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I035d08f57f8f57f276d764715e4ac35d32e1d99d"},{"line_number":13,"context_line":"Partial-Bug: 1603212"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fad55976_b4302da0","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":68},"updated":"2016-07-15 17:07:38.000000000","message":"For validate_integer() only","commit_id":"311911e7b04826f65fbc22b38cca9370efe51326"}],"neutron_lib/api/validators.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0d5b998f0661593c666818f62713de983cd34419","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    integer and returns a message with the error if it\u0027s not"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    :param data: The string or number to validate as integer"},{"line_number":150,"context_line":"    :param valid_values: None (for future usage)"},{"line_number":151,"context_line":"    :return: Message if not an integer."},{"line_number":152,"context_line":"    \"\"\""},{"line_number":153,"context_line":"    # If data is not within approved valid_values, return error"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_34927d58","line":150,"range":{"start_line":150,"start_character":4,"end_line":150,"end_character":48},"updated":"2016-07-15 17:07:38.000000000","message":"This needs to be updated.","commit_id":"311911e7b04826f65fbc22b38cca9370efe51326"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0d5b998f0661593c666818f62713de983cd34419","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    :return: Message if not an integer."},{"line_number":152,"context_line":"    \"\"\""},{"line_number":153,"context_line":"    # If data is not within approved valid_values, return error"},{"line_number":154,"context_line":"    if valid_values and (data not in valid_values):"},{"line_number":155,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not within \u0027%s\u0027\") % (data, valid_values)"},{"line_number":156,"context_line":"        return msg"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_d48e8126","line":154,"range":{"start_line":154,"start_character":7,"end_line":154,"end_character":19},"updated":"2016-07-15 17:07:38.000000000","message":"Only \u0027None\u0027 means do not check. Other falsey values should probably be rejected.","commit_id":"311911e7b04826f65fbc22b38cca9370efe51326"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0d5b998f0661593c666818f62713de983cd34419","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    \"\"\""},{"line_number":153,"context_line":"    # If data is not within approved valid_values, return error"},{"line_number":154,"context_line":"    if valid_values and (data not in valid_values):"},{"line_number":155,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not within \u0027%s\u0027\") % (data, valid_values)"},{"line_number":156,"context_line":"        return msg"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    msg \u003d _(\"\u0027%s\u0027 is not an integer\") % data"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_27652de1","line":155,"range":{"start_line":155,"start_character":52,"end_line":155,"end_character":64},"updated":"2016-07-15 17:07:38.000000000","message":"If valid_values is a huge list or range, do we want to include it in the msg?\n\nFor example, in python 2, range(1,65536) will give a pretty nasty blob. Using six.moves.range would work, but we can\u0027t control it from here.","commit_id":"311911e7b04826f65fbc22b38cca9370efe51326"}]}
