)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"125ff704a4c2cbdad53ddebc1a6dc04e1912fa46","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-07-28 23:45:13 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance valid_values validations to check that valid_values has method __contains__"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1604073"},{"line_number":10,"context_line":"Change-Id: I47a6f7d58d6cbeb8fd245620d187c4c565497290"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_0847671e","line":8,"updated":"2016-08-02 12:08:14.000000000","message":"Could you add messages to explain the isseu and this patch?","commit_id":"ede4a9e52ddcce54721078da6f285aaae880cf11"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"8c06951be8b4692147673593104d635f590edd66","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-07-28 23:45:13 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance valid_values validations to check that valid_values has method __contains__"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1604073"},{"line_number":10,"context_line":"Change-Id: I47a6f7d58d6cbeb8fd245620d187c4c565497290"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_6ec38b39","line":8,"in_reply_to":"bacf61ea_0847671e","updated":"2016-08-02 12:43:54.000000000","message":"Done","commit_id":"ede4a9e52ddcce54721078da6f285aaae880cf11"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"83cea042857d0f296e3c7667971bd65237a39497","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pablo Iranzo Gómez \u003cPablo.Iranzo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-03 09:27:10 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance valid_values validations to check that valid_values has method __contains__"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Actually valid_values doesn\u0027t cover many of the use cases or validates that the"},{"line_number":10,"context_line":"value and valid_values provided can be used with \u0027in\u0027 call. This patch tries to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bacf61ea_50e70e40","line":7,"updated":"2016-08-03 09:15:00.000000000","message":"I think you have to break this line according to https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"a4f7997ce8c85a91dd66d02bdfe7694c207cbc0a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e57bff849c7e9dc10b9ee8d9cc607d984c466d67","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pablo Iranzo Gómez \u003cPablo.Iranzo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-23 13:06:55 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance valid_values validations to check that valid_values has method __contains__"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\tActually valid_values doesn\u0027t cover many of the use cases or validates"},{"line_number":10,"context_line":"\tthat the value and valid_values provided can be used with \u0027in\u0027 call."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1ac06dbe_c95007d7","line":7,"updated":"2016-08-23 12:02:47.000000000","message":"please fix this - the commit message should not execeed too many characters\n\nplease see https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines","commit_id":"4895c5fad8e0a67cb8ceb5cca9081cc1e409797e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"72dcaa2639c179a9ceae34e74ca51e1515260dd0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Actually valid_values doesn\u0027t cover many of the use cases or validates"},{"line_number":10,"context_line":"that the value and valid_values provided can be used with \u0027in\u0027 call."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"his patch tries to improve this situation to ensure that both are valid"},{"line_number":13,"context_line":"for being checked or fail otherwise plus validating that valid_values"},{"line_number":14,"context_line":"contains the value provided."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"5a8bc5a2_325ab5f2","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":3},"updated":"2016-09-27 11:41:05.000000000","message":"This","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"}],"neutron_lib/api/validators.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"42baa5f4db2db1eba28b21c32e688c6f76f2526e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            return msg"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def validate_values(data, valid_values\u003dNone):"},{"line_number":91,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"},{"line_number":92,"context_line":"    if callable(contains):"},{"line_number":93,"context_line":"        if data not in valid_values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_1955c94f","line":90,"range":{"start_line":90,"start_character":4,"end_line":90,"end_character":19},"updated":"2016-07-18 19:17:55.000000000","message":"Can you please add some sourcedoc here? For example: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/validators.py#L600","commit_id":"d9e7ac20ffe1721c13fcabd625d0fcfb00eb5091"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"42baa5f4db2db1eba28b21c32e688c6f76f2526e","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def validate_values(data, valid_values\u003dNone):"},{"line_number":91,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"},{"line_number":92,"context_line":"    if callable(contains):"},{"line_number":93,"context_line":"        if data not in valid_values:"},{"line_number":94,"context_line":"            msg \u003d (_(\"\u0027%(data)s\u0027 is not in %(valid_values)s\") %"},{"line_number":95,"context_line":"                   {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_3956cd29","line":92,"updated":"2016-07-18 19:17:55.000000000","message":"I don\u0027t see all of Henry\u0027s comments from https://review.openstack.org/#/c/337237/27/neutron_lib/api/validators.py  addressed. e.g what about a huge valid_values len, and also handling of empty valid_values.","commit_id":"d9e7ac20ffe1721c13fcabd625d0fcfb00eb5091"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"42baa5f4db2db1eba28b21c32e688c6f76f2526e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            LOG.debug(msg)"},{"line_number":97,"context_line":"            return msg"},{"line_number":98,"context_line":"    else:"},{"line_number":99,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 can\u0027t be checked for %(data)s\") %"},{"line_number":100,"context_line":"               {\u0027valid_values\u0027: valid_values, \u0027data\u0027: data})"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_59fd8139","line":99,"range":{"start_line":99,"start_character":37,"end_line":99,"end_character":57},"updated":"2016-07-18 19:17:55.000000000","message":"I might opt some something more specific like -- \"doesn\u0027t support membership operations\"","commit_id":"d9e7ac20ffe1721c13fcabd625d0fcfb00eb5091"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"125ff704a4c2cbdad53ddebc1a6dc04e1912fa46","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":100,"context_line":"    if valid_values is None:"},{"line_number":101,"context_line":"        return None"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":104,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_c87f0f65","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":19},"updated":"2016-08-02 12:08:14.000000000","message":"It\u0027s better to write just \"return\".","commit_id":"ede4a9e52ddcce54721078da6f285aaae880cf11"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"8c06951be8b4692147673593104d635f590edd66","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":100,"context_line":"    if valid_values is None:"},{"line_number":101,"context_line":"        return None"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":104,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_ae2903f5","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":19},"in_reply_to":"bacf61ea_c87f0f65","updated":"2016-08-02 12:43:54.000000000","message":"Done","commit_id":"ede4a9e52ddcce54721078da6f285aaae880cf11"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"125ff704a4c2cbdad53ddebc1a6dc04e1912fa46","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            msg \u003d None"},{"line_number":119,"context_line":"            # check for other \u0027corner case values\u0027"},{"line_number":120,"context_line":"            # huge list"},{"line_number":121,"context_line":"            # range"},{"line_number":122,"context_line":"            # []"},{"line_number":123,"context_line":"            # {}"},{"line_number":124,"context_line":"            return msg"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_e8a3f3fe","line":123,"range":{"start_line":120,"start_character":12,"end_line":123,"end_character":16},"updated":"2016-08-02 12:08:14.000000000","message":"It seems it doesn\u0027t need to consume 4 lines for this comment.","commit_id":"ede4a9e52ddcce54721078da6f285aaae880cf11"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"8c06951be8b4692147673593104d635f590edd66","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            msg \u003d None"},{"line_number":119,"context_line":"            # check for other \u0027corner case values\u0027"},{"line_number":120,"context_line":"            # huge list"},{"line_number":121,"context_line":"            # range"},{"line_number":122,"context_line":"            # []"},{"line_number":123,"context_line":"            # {}"},{"line_number":124,"context_line":"            return msg"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_8e151f9d","line":123,"range":{"start_line":120,"start_character":12,"end_line":123,"end_character":16},"in_reply_to":"bacf61ea_e8a3f3fe","updated":"2016-08-02 12:43:54.000000000","message":"This was done this way to consider the different options, merging into one line for next patch set","commit_id":"ede4a9e52ddcce54721078da6f285aaae880cf11"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"11e73dc90b910e115269caf5d5ba05a69f027152","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                LOG.debug(msg)"},{"line_number":111,"context_line":"                return msg"},{"line_number":112,"context_line":"        except TypeError:"},{"line_number":113,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 or \u0027%(valid_values)s\u0027 are not \""},{"line_number":114,"context_line":"                         \"compatible for comparision\") %"},{"line_number":115,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":116,"context_line":"                return msg"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_17dc8917","line":113,"range":{"start_line":113,"start_character":37,"end_line":113,"end_character":39},"updated":"2016-08-02 18:55:50.000000000","message":"and","commit_id":"c9cbc1e62b5213e3068b7965bee5cb75c943f869"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c6144dc97a739ff75d260c2dc09967b2c3209fac","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                LOG.debug(msg)"},{"line_number":111,"context_line":"                return msg"},{"line_number":112,"context_line":"        except TypeError:"},{"line_number":113,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 or \u0027%(valid_values)s\u0027 are not \""},{"line_number":114,"context_line":"                         \"compatible for comparision\") %"},{"line_number":115,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":116,"context_line":"                return msg"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_da80588e","line":113,"range":{"start_line":113,"start_character":37,"end_line":113,"end_character":39},"in_reply_to":"bacf61ea_17dc8917","updated":"2016-08-02 19:29:11.000000000","message":"Done","commit_id":"c9cbc1e62b5213e3068b7965bee5cb75c943f869"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"11e73dc90b910e115269caf5d5ba05a69f027152","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                return msg"},{"line_number":112,"context_line":"        except TypeError:"},{"line_number":113,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 or \u0027%(valid_values)s\u0027 are not \""},{"line_number":114,"context_line":"                         \"compatible for comparision\") %"},{"line_number":115,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":116,"context_line":"                return msg"},{"line_number":117,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_f7e0d5ce","line":114,"range":{"start_line":114,"start_character":41,"end_line":114,"end_character":52},"updated":"2016-08-02 18:55:50.000000000","message":"comparison","commit_id":"c9cbc1e62b5213e3068b7965bee5cb75c943f869"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c6144dc97a739ff75d260c2dc09967b2c3209fac","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                return msg"},{"line_number":112,"context_line":"        except TypeError:"},{"line_number":113,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 or \u0027%(valid_values)s\u0027 are not \""},{"line_number":114,"context_line":"                         \"compatible for comparision\") %"},{"line_number":115,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":116,"context_line":"                return msg"},{"line_number":117,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_1a49508f","line":114,"range":{"start_line":114,"start_character":41,"end_line":114,"end_character":52},"in_reply_to":"bacf61ea_f7e0d5ce","updated":"2016-08-02 19:29:11.000000000","message":"Done","commit_id":"c9cbc1e62b5213e3068b7965bee5cb75c943f869"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"75d7ec9056f1df1ad4abbf5abcd3b3e62c92997f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                return msg"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            msg \u003d None"},{"line_number":119,"context_line":"            # check for other \u0027corner case values\u0027 like huge list, range,"},{"line_number":120,"context_line":"            # [] and {}"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"            return msg"},{"line_number":123,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_23b5217e","line":120,"range":{"start_line":119,"start_character":0,"end_line":120,"end_character":23},"updated":"2016-08-02 15:01:58.000000000","message":"Please put TODO here, or mark the review as WIP until you address this.","commit_id":"c9cbc1e62b5213e3068b7965bee5cb75c943f869"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"62c89c9ad5f9650effcb4a4477ceb9845f5b4f94","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                return msg"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            msg \u003d None"},{"line_number":119,"context_line":"            # check for other \u0027corner case values\u0027 like huge list, range,"},{"line_number":120,"context_line":"            # [] and {}"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"            return msg"},{"line_number":123,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_393b903a","line":120,"range":{"start_line":119,"start_character":0,"end_line":120,"end_character":23},"in_reply_to":"bacf61ea_23b5217e","updated":"2016-08-02 15:23:18.000000000","message":"+1\n\nOtherwise, you can just remove L117-L122.","commit_id":"c9cbc1e62b5213e3068b7965bee5cb75c943f869"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c6144dc97a739ff75d260c2dc09967b2c3209fac","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                return msg"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            msg \u003d None"},{"line_number":119,"context_line":"            # check for other \u0027corner case values\u0027 like huge list, range,"},{"line_number":120,"context_line":"            # [] and {}"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"            return msg"},{"line_number":123,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_7a216cb4","line":120,"range":{"start_line":119,"start_character":0,"end_line":120,"end_character":23},"in_reply_to":"bacf61ea_23b5217e","updated":"2016-08-02 19:29:11.000000000","message":"Following boden comments and Hirofumi, removing this part","commit_id":"c9cbc1e62b5213e3068b7965bee5cb75c943f869"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c6144dc97a739ff75d260c2dc09967b2c3209fac","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                return msg"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            msg \u003d None"},{"line_number":119,"context_line":"            # check for other \u0027corner case values\u0027 like huge list, range,"},{"line_number":120,"context_line":"            # [] and {}"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"            return msg"},{"line_number":123,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_1a303007","line":120,"range":{"start_line":119,"start_character":0,"end_line":120,"end_character":23},"in_reply_to":"bacf61ea_393b903a","updated":"2016-08-02 19:29:11.000000000","message":"Done","commit_id":"c9cbc1e62b5213e3068b7965bee5cb75c943f869"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3b87f4d8aec7895b8f04b45b9876b2d81f9366d8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    \"\"\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":100,"context_line":"    if valid_values is None:"},{"line_number":101,"context_line":"        return"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # TODO(iranzo): limit len of data or valid_values to avoid overflow"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_9346a64d","line":101,"range":{"start_line":100,"start_character":4,"end_line":101,"end_character":14},"updated":"2016-08-03 12:37:48.000000000","message":"Hmm: seems like this should be a programming error too and generate a raise","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"0a152e065bd8272192199bf786b0be66fe3b5cc2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    \"\"\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":100,"context_line":"    if valid_values is None:"},{"line_number":101,"context_line":"        return"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # TODO(iranzo): limit len of data or valid_values to avoid overflow"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_e41aba7b","line":101,"range":{"start_line":100,"start_character":4,"end_line":101,"end_character":14},"in_reply_to":"bacf61ea_9346a64d","updated":"2016-08-03 13:33:10.000000000","message":"If we allow to send \u0027None\u0027 all subfunctions could always call validate_values(value,valid_values) without further checks within each function, if not, a check will be required on each function, adding extra code.\n\n(my 2 cents)","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3b87f4d8aec7895b8f04b45b9876b2d81f9366d8","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    if valid_values is None:"},{"line_number":101,"context_line":"        return"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # TODO(iranzo): limit len of data or valid_values to avoid overflow"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":106,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_13f636f9","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":71},"updated":"2016-08-03 12:37:48.000000000","message":"Do we really need to test a limit here? I can see some benefit, but at the same time seems like overkill","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2ee351745a4291cf40af0d08d8ad875c8f48e46a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    if valid_values is None:"},{"line_number":101,"context_line":"        return"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # TODO(iranzo): limit len of data or valid_values to avoid overflow"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":106,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_e53d8ade","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":71},"in_reply_to":"bacf61ea_02b094dc","updated":"2016-08-03 16:58:32.000000000","message":"Actually I am beginning to think this is too much magic. Perhaps we should add an additional optional parameter, like valid_values_display, and rely on code review instead.","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"0a152e065bd8272192199bf786b0be66fe3b5cc2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    if valid_values is None:"},{"line_number":101,"context_line":"        return"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # TODO(iranzo): limit len of data or valid_values to avoid overflow"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":106,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_6407ea1d","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":71},"in_reply_to":"bacf61ea_13f636f9","updated":"2016-08-03 13:33:10.000000000","message":"The idea is not to do overflow when printing the \u0027msg\u0027 with big strings, am I right Henry et al?","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"768903d3ba3cd33a2a2dcf7681a5b20628f07f02","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    if valid_values is None:"},{"line_number":101,"context_line":"        return"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # TODO(iranzo): limit len of data or valid_values to avoid overflow"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":106,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_02b094dc","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":71},"in_reply_to":"bacf61ea_6407ea1d","updated":"2016-08-03 16:50:29.000000000","message":"Right. Something like:\n\n  print_vv \u003d str(valid_values)\n  if len(print_vv) \u003e 80:\n      print_vv \u003d print_vv[:77] + \u0027...\u0027","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3b87f4d8aec7895b8f04b45b9876b2d81f9366d8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":112,"context_line":"                LOG.debug(msg)"},{"line_number":113,"context_line":"                return msg"},{"line_number":114,"context_line":"        except TypeError:"},{"line_number":115,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":116,"context_line":"                         \"compatible for comparison\") %"},{"line_number":117,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_3341ba0c","line":114,"range":{"start_line":114,"start_character":15,"end_line":114,"end_character":24},"updated":"2016-08-03 12:37:48.000000000","message":"I\u0027m tempted to say let this error raise; it\u0027s a programming error","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"768903d3ba3cd33a2a2dcf7681a5b20628f07f02","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":112,"context_line":"                LOG.debug(msg)"},{"line_number":113,"context_line":"                return msg"},{"line_number":114,"context_line":"        except TypeError:"},{"line_number":115,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":116,"context_line":"                         \"compatible for comparison\") %"},{"line_number":117,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_e5ad8a9c","line":114,"range":{"start_line":114,"start_character":15,"end_line":114,"end_character":24},"in_reply_to":"bacf61ea_3341ba0c","updated":"2016-08-03 16:50:29.000000000","message":"OK, data is user input and valid_values is developer coded. If the error is due to developer code we can raise. So as long as we are sure that the user input has been properly checked before we reach here we can raise for TypeError.","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"0a152e065bd8272192199bf786b0be66fe3b5cc2","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":112,"context_line":"                LOG.debug(msg)"},{"line_number":113,"context_line":"                return msg"},{"line_number":114,"context_line":"        except TypeError:"},{"line_number":115,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":116,"context_line":"                         \"compatible for comparison\") %"},{"line_number":117,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_df281f88","line":114,"range":{"start_line":114,"start_character":15,"end_line":114,"end_character":24},"in_reply_to":"bacf61ea_3341ba0c","updated":"2016-08-03 13:33:10.000000000","message":"So a traceback is preferred, would this probably just remove the requirement to check if it has \"__contains__\" or not, isn\u0027t it?","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3b87f4d8aec7895b8f04b45b9876b2d81f9366d8","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":118,"context_line":"                return msg"},{"line_number":119,"context_line":"    else:"},{"line_number":120,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"},{"line_number":121,"context_line":"               {\u0027valid_values\u0027: valid_values})"},{"line_number":122,"context_line":"        return msg"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_733a12cf","line":120,"updated":"2016-08-03 12:37:48.000000000","message":"IMO this should raise an exception; its a programming error","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"768903d3ba3cd33a2a2dcf7681a5b20628f07f02","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":118,"context_line":"                return msg"},{"line_number":119,"context_line":"    else:"},{"line_number":120,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"},{"line_number":121,"context_line":"               {\u0027valid_values\u0027: valid_values})"},{"line_number":122,"context_line":"        return msg"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_05825e00","line":120,"in_reply_to":"bacf61ea_733a12cf","updated":"2016-08-03 16:50:29.000000000","message":"Yes.","commit_id":"e86d26a4e24a2654d43f67f0b0096696e52a0d97"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e57bff849c7e9dc10b9ee8d9cc607d984c466d67","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    :param data: The data to check within valid_values."},{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if he values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"},{"line_number":99,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_a9d02b20","line":96,"range":{"start_line":96,"start_character":46,"end_line":96,"end_character":48},"updated":"2016-08-23 12:02:47.000000000","message":"the","commit_id":"4895c5fad8e0a67cb8ceb5cca9081cc1e409797e"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c1c5b8277579811b267c157430d00e7719f5f108","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    :param data: The data to check within valid_values."},{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if he values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"},{"line_number":99,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_5d568dce","line":96,"range":{"start_line":96,"start_character":46,"end_line":96,"end_character":48},"in_reply_to":"1ac06dbe_a9d02b20","updated":"2016-08-23 12:54:45.000000000","message":"Done","commit_id":"4895c5fad8e0a67cb8ceb5cca9081cc1e409797e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e57bff849c7e9dc10b9ee8d9cc607d984c466d67","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if he values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_49aed798","line":97,"updated":"2016-08-23 12:02:47.000000000","message":"why is this not always shown","commit_id":"4895c5fad8e0a67cb8ceb5cca9081cc1e409797e"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c1c5b8277579811b267c157430d00e7719f5f108","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if he values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_5d0dede6","line":97,"in_reply_to":"1ac06dbe_49aed798","updated":"2016-08-23 12:54:45.000000000","message":"According to last comment by Henry, the idea is to avoid overflow if valid_values or data is too big without having to validate in this function","commit_id":"4895c5fad8e0a67cb8ceb5cca9081cc1e409797e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e57bff849c7e9dc10b9ee8d9cc607d984c466d67","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                LOG.debug(msg)"},{"line_number":115,"context_line":"                return msg"},{"line_number":116,"context_line":"        except TypeError:"},{"line_number":117,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":118,"context_line":"                         \"compatible for comparison\") %"},{"line_number":119,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":120,"context_line":"                if not valid_values_display:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_49853705","line":117,"updated":"2016-08-23 12:02:47.000000000","message":"indentation here is dodgy - it should be 4 spaces","commit_id":"4895c5fad8e0a67cb8ceb5cca9081cc1e409797e"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c1c5b8277579811b267c157430d00e7719f5f108","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                LOG.debug(msg)"},{"line_number":115,"context_line":"                return msg"},{"line_number":116,"context_line":"        except TypeError:"},{"line_number":117,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":118,"context_line":"                         \"compatible for comparison\") %"},{"line_number":119,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":120,"context_line":"                if not valid_values_display:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_7df8a9c3","line":117,"in_reply_to":"1ac06dbe_49853705","updated":"2016-08-23 12:54:45.000000000","message":"Fixed, when I idented for adding the comparision I messed it up :/","commit_id":"4895c5fad8e0a67cb8ceb5cca9081cc1e409797e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d1233d153a07b194b0a941f93dae01be222cc7f1","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    :param data: The data to check within valid_values."},{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_965c437e","line":95,"range":{"start_line":95,"start_character":19,"end_line":95,"end_character":26},"updated":"2016-08-23 20:26:37.000000000","message":"Nit: period at the end of sentence.","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c7c3dbd87e58fe5ab1a88a8459d3f14a5e96d63f","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    :param data: The data to check within valid_values."},{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_d3334912","line":95,"range":{"start_line":95,"start_character":19,"end_line":95,"end_character":26},"in_reply_to":"1ac06dbe_965c437e","updated":"2016-08-24 12:29:27.000000000","message":"Done","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d1233d153a07b194b0a941f93dae01be222cc7f1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_56664b51","line":97,"range":{"start_line":97,"start_character":23,"end_line":97,"end_character":31},"updated":"2016-08-23 20:26:37.000000000","message":"Nit: period at the end of sentence.","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d1233d153a07b194b0a941f93dae01be222cc7f1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_f6d497ec","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":8},"updated":"2016-08-23 20:26:37.000000000","message":"Not covered in the style guide but I think we should be consistent and left align here like we did in: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/converters.py#L50","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c7c3dbd87e58fe5ab1a88a8459d3f14a5e96d63f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_f313e562","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":8},"in_reply_to":"1ac06dbe_f6d497ec","updated":"2016-08-24 12:29:27.000000000","message":"Done","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d1233d153a07b194b0a941f93dae01be222cc7f1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    # Make all checks with default valid_values to return without error"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_a2ae5e2b","line":98,"range":{"start_line":98,"start_character":5,"end_line":98,"end_character":11},"updated":"2016-08-23 20:26:37.000000000","message":"As per [1] it should be \u0027returns\u0027.\n\n[1] http://docs.openstack.org/developer/hacking/#docstrings","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c7c3dbd87e58fe5ab1a88a8459d3f14a5e96d63f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        success or failure"},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"        shown on error messages"},{"line_number":98,"context_line":"    :return: The message to return if data not in valid_values"},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    # Make all checks with default valid_values to return without error"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_73525536","line":98,"range":{"start_line":98,"start_character":5,"end_line":98,"end_character":11},"in_reply_to":"1ac06dbe_a2ae5e2b","updated":"2016-08-24 12:29:27.000000000","message":"Done","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d1233d153a07b194b0a941f93dae01be222cc7f1","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":102,"context_line":"    if valid_values is None:"},{"line_number":103,"context_line":"        return"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":106,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_d63d1b2c","line":103,"updated":"2016-08-23 20:26:37.000000000","message":"Not covered in UTs.","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c7c3dbd87e58fe5ab1a88a8459d3f14a5e96d63f","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":102,"context_line":"    if valid_values is None:"},{"line_number":103,"context_line":"        return"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":106,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_93571125","line":103,"in_reply_to":"1ac06dbe_d63d1b2c","updated":"2016-08-24 12:29:27.000000000","message":"Done","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d1233d153a07b194b0a941f93dae01be222cc7f1","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    if valid_values is None:"},{"line_number":103,"context_line":"        return"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":106,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"},{"line_number":107,"context_line":"    if callable(contains):"},{"line_number":108,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_16d693f0","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":8},"updated":"2016-08-23 20:26:37.000000000","message":"tab back pls.","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c7c3dbd87e58fe5ab1a88a8459d3f14a5e96d63f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    if valid_values is None:"},{"line_number":103,"context_line":"        return"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":106,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"},{"line_number":107,"context_line":"    if callable(contains):"},{"line_number":108,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_530f5936","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":8},"in_reply_to":"1ac06dbe_16d693f0","updated":"2016-08-24 12:29:27.000000000","message":"Done","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d1233d153a07b194b0a941f93dae01be222cc7f1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                         \"compatible for comparison\") %"},{"line_number":119,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":120,"context_line":"                if not valid_values_display:"},{"line_number":121,"context_line":"                    msg \u003d (_(\"\u0027data\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":122,"context_line":"                             \"compatible for comparison\"))"},{"line_number":123,"context_line":"                return msg"},{"line_number":124,"context_line":"    else:"},{"line_number":125,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_d624fb0d","line":122,"range":{"start_line":121,"start_character":20,"end_line":122,"end_character":58},"updated":"2016-08-23 20:26:37.000000000","message":"Not covered in UTs.","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c7c3dbd87e58fe5ab1a88a8459d3f14a5e96d63f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                         \"compatible for comparison\") %"},{"line_number":119,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":120,"context_line":"                if not valid_values_display:"},{"line_number":121,"context_line":"                    msg \u003d (_(\"\u0027data\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":122,"context_line":"                             \"compatible for comparison\"))"},{"line_number":123,"context_line":"                return msg"},{"line_number":124,"context_line":"    else:"},{"line_number":125,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_8e8fe873","line":122,"range":{"start_line":121,"start_character":20,"end_line":122,"end_character":58},"in_reply_to":"1ac06dbe_d624fb0d","updated":"2016-08-24 12:29:27.000000000","message":"Done","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d1233d153a07b194b0a941f93dae01be222cc7f1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                if not valid_values_display:"},{"line_number":121,"context_line":"                    msg \u003d (_(\"\u0027data\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":122,"context_line":"                             \"compatible for comparison\"))"},{"line_number":123,"context_line":"                return msg"},{"line_number":124,"context_line":"    else:"},{"line_number":125,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"},{"line_number":126,"context_line":"               {\u0027valid_values\u0027: valid_values})"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_56f1306a","line":123,"range":{"start_line":123,"start_character":16,"end_line":123,"end_character":26},"updated":"2016-08-23 20:26:37.000000000","message":"Back in patch 10 I thought we discussed raising here since it\u0027s a programming error. Did I miss something?","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c7c3dbd87e58fe5ab1a88a8459d3f14a5e96d63f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                if not valid_values_display:"},{"line_number":121,"context_line":"                    msg \u003d (_(\"\u0027data\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":122,"context_line":"                             \"compatible for comparison\"))"},{"line_number":123,"context_line":"                return msg"},{"line_number":124,"context_line":"    else:"},{"line_number":125,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"},{"line_number":126,"context_line":"               {\u0027valid_values\u0027: valid_values})"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_0922cd01","line":123,"range":{"start_line":123,"start_character":16,"end_line":123,"end_character":26},"in_reply_to":"1ac06dbe_56f1306a","updated":"2016-08-24 12:29:27.000000000","message":"Done","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d1233d153a07b194b0a941f93dae01be222cc7f1","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                    msg \u003d (_(\"\u0027data\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":122,"context_line":"                             \"compatible for comparison\"))"},{"line_number":123,"context_line":"                return msg"},{"line_number":124,"context_line":"    else:"},{"line_number":125,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"},{"line_number":126,"context_line":"               {\u0027valid_values\u0027: valid_values})"},{"line_number":127,"context_line":"        if not valid_values_display:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_56cad01b","line":124,"range":{"start_line":124,"start_character":4,"end_line":124,"end_character":8},"updated":"2016-08-23 20:26:37.000000000","message":"Back in patch 10 I thought we discussed raising here since it\u0027s a programming error. Did I miss something?","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"c7c3dbd87e58fe5ab1a88a8459d3f14a5e96d63f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                    msg \u003d (_(\"\u0027data\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":122,"context_line":"                             \"compatible for comparison\"))"},{"line_number":123,"context_line":"                return msg"},{"line_number":124,"context_line":"    else:"},{"line_number":125,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"},{"line_number":126,"context_line":"               {\u0027valid_values\u0027: valid_values})"},{"line_number":127,"context_line":"        if not valid_values_display:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_691f01b8","line":124,"range":{"start_line":124,"start_character":4,"end_line":124,"end_character":8},"in_reply_to":"1ac06dbe_56cad01b","updated":"2016-08-24 12:29:27.000000000","message":"Done","commit_id":"feece331d08b29579f185363db18619c45ee04e0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a6f3c5785ec27eb0dde101af9a679bebc397b169","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"    shown on error messages."},{"line_number":98,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":99,"context_line":"    :raises:"},{"line_number":100,"context_line":"    \"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # Make all checks with default valid_values to return without error"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_356c2e08","line":99,"range":{"start_line":99,"start_character":5,"end_line":99,"end_character":11},"updated":"2016-08-24 15:37:34.000000000","message":"Based on [1] raises should include the exceptions thrown and a description of when. For example [2].\n\n\n[1] http://docs.openstack.org/developer/hacking/#docstrings\n[2] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/converters.py#L26","commit_id":"1a3239941c1019e7e1538213f9221f947eff1ed2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"a98f8c3df196cbee3dff25874322e1342c4c2740","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"    shown on error messages."},{"line_number":98,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":99,"context_line":"    :raises:"},{"line_number":100,"context_line":"    \"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # Make all checks with default valid_values to return without error"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_29fe8005","line":99,"range":{"start_line":99,"start_character":5,"end_line":99,"end_character":11},"in_reply_to":"1ac06dbe_356c2e08","updated":"2016-08-24 22:31:47.000000000","message":"Done","commit_id":"1a3239941c1019e7e1538213f9221f947eff1ed2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a6f3c5785ec27eb0dde101af9a679bebc397b169","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    msg \u003d (_(\"\u0027data\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":123,"context_line":"                             \"compatible for comparison\"))"},{"line_number":124,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"},{"line_number":127,"context_line":"               {\u0027valid_values\u0027: valid_values})"},{"line_number":128,"context_line":"        if not valid_values_display:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_d89eafb7","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":9},"updated":"2016-08-24 15:37:34.000000000","message":"Based on the coverage report [1] we are still missing a UT to cover this else block.\n\n\n[1] http://logs.openstack.org/99/343799/13/check/neutron-lib-coverage-ubuntu-xenial/63d61f7/cover/neutron_lib_api_validators_py.html#n125","commit_id":"1a3239941c1019e7e1538213f9221f947eff1ed2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"a98f8c3df196cbee3dff25874322e1342c4c2740","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    msg \u003d (_(\"\u0027data\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":123,"context_line":"                             \"compatible for comparison\"))"},{"line_number":124,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"},{"line_number":127,"context_line":"               {\u0027valid_values\u0027: valid_values})"},{"line_number":128,"context_line":"        if not valid_values_display:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_89f5f4cc","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":9},"in_reply_to":"1ac06dbe_d89eafb7","updated":"2016-08-24 22:31:47.000000000","message":"Done","commit_id":"1a3239941c1019e7e1538213f9221f947eff1ed2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c9f0f5289318a62fef3fe9891520d48666510b0f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                             \"compatible for comparison\"))"},{"line_number":125,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":126,"context_line":"    else:"},{"line_number":127,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"},{"line_number":128,"context_line":"               {\u0027valid_values\u0027: valid_values})"},{"line_number":129,"context_line":"        if not valid_values_display:"},{"line_number":130,"context_line":"            msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t support membership operations\"))"},{"line_number":131,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ac06dbe_ed1454a0","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":46},"updated":"2016-08-25 10:23:37.000000000","message":"I think Python builds the string with the valid_values before it is displayed, so I would prefer if this is avoided if valid_values_display is False.","commit_id":"164aee4ab68ceaa76dbcd52c6dc5450a4ef700e3"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"37853c4b6e12307b93c48c8e74d1008fb21e7f62","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                             \"compatible for comparison\"))"},{"line_number":125,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":126,"context_line":"    else:"},{"line_number":127,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t support membership operations\") %"},{"line_number":128,"context_line":"               {\u0027valid_values\u0027: valid_values})"},{"line_number":129,"context_line":"        if not valid_values_display:"},{"line_number":130,"context_line":"            msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t support membership operations\"))"},{"line_number":131,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ac06dbe_e3e7453e","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":46},"in_reply_to":"1ac06dbe_ed1454a0","updated":"2016-08-25 10:45:44.000000000","message":"Done","commit_id":"164aee4ab68ceaa76dbcd52c6dc5450a4ef700e3"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"4bcc41925c7fd4873505f7a10711ab95175fe039","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"    success or failure."},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"    shown on error messages."},{"line_number":98,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":99,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":100,"context_line":"    compatible for comparision or doesn\u0027t have __contains__"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa7ab95a_090f2ae2","line":97,"updated":"2016-08-25 22:31:47.000000000","message":"What about making valid_values_display a string? So it can be called this this:\n\n  validate_values(x, range(65536), \u0027range(65536)\u0027)\n\nor\n\n  validate_values(x, range(65536), \u0027[0..65535]\u0027)\n\nThis would rely code review to catch that the string matches valid_values but I think that is easy enough to be robust.","commit_id":"e108f7c28aa03fcf08355078df6a669405f90109"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"db3de49d2d14ba26cf84c9ae17354f500c68febb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"    success or failure."},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"    shown on error messages."},{"line_number":98,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":99,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":100,"context_line":"    compatible for comparision or doesn\u0027t have __contains__"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa7ab95a_6c1eddbb","line":97,"in_reply_to":"fa7ab95a_090f2ae2","updated":"2016-08-26 13:49:22.000000000","message":"+1\nI agree it\u0027d be more robust to be able to pass in your own string to display rather than a bool flag. Should be easy enough for callers to construct such a str.","commit_id":"e108f7c28aa03fcf08355078df6a669405f90109"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"4a2376362d7ea2d375cfb4fcc4ca2579b407a879","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"    success or failure."},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"    shown on error messages."},{"line_number":98,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":99,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":100,"context_line":"    compatible for comparision or doesn\u0027t have __contains__"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa7ab95a_95608437","line":97,"in_reply_to":"fa7ab95a_090f2ae2","updated":"2016-08-26 14:25:40.000000000","message":"Done","commit_id":"e108f7c28aa03fcf08355078df6a669405f90109"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"4a2376362d7ea2d375cfb4fcc4ca2579b407a879","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"    success or failure."},{"line_number":96,"context_line":"    :param valid_values_display: Specifies if the values provided should be"},{"line_number":97,"context_line":"    shown on error messages."},{"line_number":98,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":99,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":100,"context_line":"    compatible for comparision or doesn\u0027t have __contains__"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa7ab95a_d55a0c83","line":97,"in_reply_to":"fa7ab95a_6c1eddbb","updated":"2016-08-26 14:25:40.000000000","message":"Done","commit_id":"e108f7c28aa03fcf08355078df6a669405f90109"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b2385bb6808506983e0cd748c72cf1c191437ce5","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    msg \u003d (_(\"\u0027%(data)s\u0027 is not in %(valid_values)s\") %"},{"line_number":114,"context_line":"                           {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":115,"context_line":"                else:"},{"line_number":116,"context_line":"                    msg \u003d (_(\"\u0027data\u0027 is not in \u0027valid_values\u0027\"))"},{"line_number":117,"context_line":"                LOG.debug(msg)"},{"line_number":118,"context_line":"                return msg"},{"line_number":119,"context_line":"        except TypeError:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_92d2105a","line":116,"range":{"start_line":116,"start_character":31,"end_line":116,"end_character":35},"updated":"2016-08-25 13:13:14.000000000","message":"Should we display the value of \u0027data\u0027 here? While valid_values_display clearly gates if we show valid_values, it seems maybe we should always show data??\n\n\nWhat do you think?","commit_id":"e108f7c28aa03fcf08355078df6a669405f90109"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"4a2376362d7ea2d375cfb4fcc4ca2579b407a879","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    msg \u003d (_(\"\u0027%(data)s\u0027 is not in %(valid_values)s\") %"},{"line_number":114,"context_line":"                           {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values})"},{"line_number":115,"context_line":"                else:"},{"line_number":116,"context_line":"                    msg \u003d (_(\"\u0027data\u0027 is not in \u0027valid_values\u0027\"))"},{"line_number":117,"context_line":"                LOG.debug(msg)"},{"line_number":118,"context_line":"                return msg"},{"line_number":119,"context_line":"        except TypeError:"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa7ab95a_b5366801","line":116,"range":{"start_line":116,"start_character":31,"end_line":116,"end_character":35},"in_reply_to":"1ac06dbe_92d2105a","updated":"2016-08-26 14:25:40.000000000","message":"Theoretically if we put \u0027valid_values_display\u0027, it will show data and valid_values_display, if valid_values_display\u003dFalse, just the string \u0027data\u0027 and \u0027valid_values\u0027 will be displayed\n\nIf data is too big, we can fall in the same issue as we\u0027re trying to fix with that new parameter, isn\u0027t it?","commit_id":"e108f7c28aa03fcf08355078df6a669405f90109"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"fe8c9bd7d9595d4091cb6c91f2fcf8e71bfaaf9a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            return msg"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def validate_values(data, valid_values\u003dNone, valid_values_display\u003dFalse):"},{"line_number":91,"context_line":"    \"\"\"Validate that the provided \u0027data\u0027 is within \u0027valid_values\u0027."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    :param data: The data to check within valid_values."}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_240661ce","line":90,"range":{"start_line":90,"start_character":66,"end_line":90,"end_character":71},"updated":"2016-08-29 08:57:46.000000000","message":"This should be None otherwise it looks like it should be a boolean.","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"a3c66bef92456c43380693af27eac34c1c4b8491","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            return msg"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def validate_values(data, valid_values\u003dNone, valid_values_display\u003dFalse):"},{"line_number":91,"context_line":"    \"\"\"Validate that the provided \u0027data\u0027 is within \u0027valid_values\u0027."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    :param data: The data to check within valid_values."}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_bfc0be7d","line":90,"range":{"start_line":90,"start_character":66,"end_line":90,"end_character":71},"in_reply_to":"fa7ab95a_240661ce","updated":"2016-08-29 09:52:35.000000000","message":"Done","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"fe8c9bd7d9595d4091cb6c91f2fcf8e71bfaaf9a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    :param data: The data to check within valid_values."},{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"    success or failure."},{"line_number":96,"context_line":"    :param valid_values_display: Specifies the values that should be"},{"line_number":97,"context_line":"    shown on error messages or null for \u0027valid_values\u0027 string."},{"line_number":98,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":99,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":100,"context_line":"    compatible for comparision or doesn\u0027t have __contains__"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_a47d111e","line":97,"range":{"start_line":96,"start_character":33,"end_line":97,"end_character":62},"updated":"2016-08-29 08:57:46.000000000","message":"\u0027A string to display that describes the valid values. This string is only displayed when an invalid value is encountered. If no string is provided, the string \"valid_values\" will be used.\u0027","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"a3c66bef92456c43380693af27eac34c1c4b8491","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    :param data: The data to check within valid_values."},{"line_number":94,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":95,"context_line":"    success or failure."},{"line_number":96,"context_line":"    :param valid_values_display: Specifies the values that should be"},{"line_number":97,"context_line":"    shown on error messages or null for \u0027valid_values\u0027 string."},{"line_number":98,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":99,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":100,"context_line":"    compatible for comparision or doesn\u0027t have __contains__"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_dfbf42f9","line":97,"range":{"start_line":96,"start_character":33,"end_line":97,"end_character":62},"in_reply_to":"fa7ab95a_a47d111e","updated":"2016-08-29 09:52:35.000000000","message":"Done","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"fe8c9bd7d9595d4091cb6c91f2fcf8e71bfaaf9a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    shown on error messages or null for \u0027valid_values\u0027 string."},{"line_number":98,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":99,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":100,"context_line":"    compatible for comparision or doesn\u0027t have __contains__"},{"line_number":101,"context_line":"    \"\"\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # Make all checks with default valid_values to return without error"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_04aa3d70","line":100,"range":{"start_line":100,"start_character":19,"end_line":100,"end_character":30},"updated":"2016-08-29 08:57:46.000000000","message":"comparison","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"a3c66bef92456c43380693af27eac34c1c4b8491","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    shown on error messages or null for \u0027valid_values\u0027 string."},{"line_number":98,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":99,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":100,"context_line":"    compatible for comparision or doesn\u0027t have __contains__"},{"line_number":101,"context_line":"    \"\"\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # Make all checks with default valid_values to return without error"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_1f38ca9f","line":100,"range":{"start_line":100,"start_character":19,"end_line":100,"end_character":30},"in_reply_to":"fa7ab95a_04aa3d70","updated":"2016-08-29 09:52:35.000000000","message":"Done","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"fe8c9bd7d9595d4091cb6c91f2fcf8e71bfaaf9a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":104,"context_line":"    if valid_values is None:"},{"line_number":105,"context_line":"        return"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":108,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"},{"line_number":109,"context_line":"    if callable(contains):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_6436a953","line":106,"updated":"2016-08-29 08:57:46.000000000","message":"I would set up the display string here:\n\n  valid_values_display \u003d valid_values_display or \u0027valid_values\u0027\n\nThen you don\u0027t need all the checks below.","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"ad14ba72cff5cccee12d086d32ff34224b790693","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":104,"context_line":"    if valid_values is None:"},{"line_number":105,"context_line":"        return"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":108,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"},{"line_number":109,"context_line":"    if callable(contains):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_29fa8a75","line":106,"in_reply_to":"fa7ab95a_5153026b","updated":"2016-08-29 21:06:37.000000000","message":"Done","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"a3c66bef92456c43380693af27eac34c1c4b8491","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":104,"context_line":"    if valid_values is None:"},{"line_number":105,"context_line":"        return"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":108,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"},{"line_number":109,"context_line":"    if callable(contains):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_7f13960d","line":106,"in_reply_to":"fa7ab95a_6436a953","updated":"2016-08-29 09:52:35.000000000","message":"Should I also mask \u0027data\u0027 as I do right now or just valid_values ??","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ca3a11db8cfbbd5b51bd7d0c1cd5699a49c9e378","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":104,"context_line":"    if valid_values is None:"},{"line_number":105,"context_line":"        return"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":108,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"},{"line_number":109,"context_line":"    if callable(contains):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_5153026b","line":106,"in_reply_to":"fa7ab95a_7f13960d","updated":"2016-08-29 17:49:30.000000000","message":"No, I think you can always print the value of data.","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"fe8c9bd7d9595d4091cb6c91f2fcf8e71bfaaf9a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                LOG.debug(msg)"},{"line_number":119,"context_line":"                return msg"},{"line_number":120,"context_line":"        except TypeError:"},{"line_number":121,"context_line":"                if valid_values_display:"},{"line_number":122,"context_line":"                    msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":123,"context_line":"                             \"compatible for comparison\") %"},{"line_number":124,"context_line":"                           {\u0027data\u0027: data,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_24bd8168","line":121,"updated":"2016-08-29 08:57:46.000000000","message":"I don\u0027t think this is useful in this case, since the string is not programmatically related to the type error.","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"a3c66bef92456c43380693af27eac34c1c4b8491","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                LOG.debug(msg)"},{"line_number":119,"context_line":"                return msg"},{"line_number":120,"context_line":"        except TypeError:"},{"line_number":121,"context_line":"                if valid_values_display:"},{"line_number":122,"context_line":"                    msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":123,"context_line":"                             \"compatible for comparison\") %"},{"line_number":124,"context_line":"                           {\u0027data\u0027: data,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_f0a9937c","line":121,"in_reply_to":"fa7ab95a_24bd8168","updated":"2016-08-29 09:52:35.000000000","message":"The TypeError should raise in case we cannot do \u0027data\u0027 in \u0027valid_values\u0027 to raise that data and values are not compatible","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"ad14ba72cff5cccee12d086d32ff34224b790693","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                LOG.debug(msg)"},{"line_number":119,"context_line":"                return msg"},{"line_number":120,"context_line":"        except TypeError:"},{"line_number":121,"context_line":"                if valid_values_display:"},{"line_number":122,"context_line":"                    msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":123,"context_line":"                             \"compatible for comparison\") %"},{"line_number":124,"context_line":"                           {\u0027data\u0027: data,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_e9fb4279","line":121,"in_reply_to":"fa7ab95a_518862c5","updated":"2016-08-29 21:06:37.000000000","message":"Done","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ca3a11db8cfbbd5b51bd7d0c1cd5699a49c9e378","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                LOG.debug(msg)"},{"line_number":119,"context_line":"                return msg"},{"line_number":120,"context_line":"        except TypeError:"},{"line_number":121,"context_line":"                if valid_values_display:"},{"line_number":122,"context_line":"                    msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":123,"context_line":"                             \"compatible for comparison\") %"},{"line_number":124,"context_line":"                           {\u0027data\u0027: data,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_518862c5","line":121,"in_reply_to":"fa7ab95a_f0a9937c","updated":"2016-08-29 17:49:30.000000000","message":"What I mean is if you end up here you should print:\n\n  \"%(data)s and \u0027valid_values\u0027 are not valid for comparison\"","commit_id":"9caafd9b057295686b6785649b5a12eaff09723f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7e5053098bc693f43a1a97935a1f078c9ee87fe4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    if valid_values is None:"},{"line_number":106,"context_line":"        return"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    valid_values_display \u003d valid_values_display or \u0027valid_values\u0027"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":111,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_08ae8e80","line":108,"updated":"2016-08-30 06:20:25.000000000","message":"Given my other comments below, this line can now go to line 115.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"6045f824f966c3917b3574e24a2a78d583419b6f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    if valid_values is None:"},{"line_number":106,"context_line":"        return"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    valid_values_display \u003d valid_values_display or \u0027valid_values\u0027"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":111,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_f03dd02b","line":108,"in_reply_to":"fa7ab95a_08ae8e80","updated":"2016-08-30 07:30:26.000000000","message":"If we do just this change to validate that nothing changes, some tests fail like:\n\n\n        response \u003d \"Invalid input for operation: \u00271\u0027 and \u0027valid_values\u0027 \" \\\n                   \"are not compatible for comparison\"\n        self.assertRaisesRegex(n_exc.InvalidInput, response,\n                               validators.validate_values, data\u003d1,\n                               valid_values\u003d\u0027[2, 3, 4, 5]\u0027,\n                               valid_values_display\u003dFalse)\n\n\nWhere in the past it should match, by changing the line we get \nAssertionError: \"Invalid input for operation: \u00271\u0027 and \u0027valid_values\u0027 are not compatible for comparison\" does not match \"Invalid input for operation: \u00271\u0027 and \u0027False\u0027 are not compatible for comparison.\"","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b186a78fe91073c6610eca6e06ad6bdc7f3e4adb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    if valid_values is None:"},{"line_number":106,"context_line":"        return"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    valid_values_display \u003d valid_values_display or \u0027valid_values\u0027"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Check if we can use \u0027in\u0027 to find membership of data in valid_values"},{"line_number":111,"context_line":"    contains \u003d getattr(valid_values, \"__contains__\", None)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_fef761d0","line":108,"in_reply_to":"fa7ab95a_f03dd02b","updated":"2016-08-30 08:09:18.000000000","message":"See my comments in the tests.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e380d2a5f23d647bb96534520da0000f331484a6","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values_display})"},{"line_number":117,"context_line":"                LOG.debug(msg)"},{"line_number":118,"context_line":"                return msg"},{"line_number":119,"context_line":"        except TypeError:"},{"line_number":120,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":121,"context_line":"                         \"compatible for comparison\") %"},{"line_number":122,"context_line":"                       {\u0027data\u0027: data,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_18aaf919","line":119,"updated":"2016-08-31 13:10:20.000000000","message":"I think this error should result in an internal error (with no details) back to the neutron API user, since it is not the user\u0027s fault.\n\nWe should check with Akihiro what is the best exception to raise and what else we may need to consider for this case.\n\nSame for line 126-129 below.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"606dcc1d69c359b2f7888deba8d627533bf0cf81","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values_display})"},{"line_number":117,"context_line":"                LOG.debug(msg)"},{"line_number":118,"context_line":"                return msg"},{"line_number":119,"context_line":"        except TypeError:"},{"line_number":120,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":121,"context_line":"                         \"compatible for comparison\") %"},{"line_number":122,"context_line":"                       {\u0027data\u0027: data,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_1b090532","line":119,"in_reply_to":"fa7ab95a_18aaf919","updated":"2016-08-31 16:42:32.000000000","message":"The current interface of API validators is:\n- when no validation error is detected, None is returned\n- when some validation error is detected, non-empty string which describe an error reason is returned.\n\nA validator is called from neutron.api.v2.attributes.convert_value() [1].\nThe expected behavior of a validator is that no exception is raised.\n\nOn the other hand, the API layer converts an exception which occurs during processing to webeb exception based on FAULT_MAP [2]. This converts neutron_lib.exceptions.BadRequest into webob. exc.HTTPBadRequest. InvalidInput inherits BadRequest, so as a result InvalidInput raised here will be caught in the API layer and converted into webob.exc.BadRequest which means 400 response code.\n\nNote that my understanding is this behavior is not an expected behavior when the API layer was designed. IMHO we should not depend on a mechanism to catch an exception globally.\n\n----\n\nI agree that it is not a common pattern to return non-empty string when some validation error is detected, but if you want to change the validator interface you first need to modify neutron API layer to accept both the current and new validator interfaces.\n\n----\n\nThus my suggestion is to return non-empty string from here at the moment. As a next step, we can change the validator interface in the API layer to more pythonic way (i.e. to raise an exception), but we need to change the API layer first.\n\n----\n\n[1] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/api/v2/attributes.py#n418\n\n[2] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/api/v2/base.py#n44","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5ac962d77f7d2045b4936a45bfc3f42b339f41b3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values_display})"},{"line_number":117,"context_line":"                LOG.debug(msg)"},{"line_number":118,"context_line":"                return msg"},{"line_number":119,"context_line":"        except TypeError:"},{"line_number":120,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":121,"context_line":"                         \"compatible for comparison\") %"},{"line_number":122,"context_line":"                       {\u0027data\u0027: data,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_ca54e955","line":119,"in_reply_to":"fa7ab95a_1b090532","updated":"2016-09-01 13:18:06.000000000","message":"While these are very good points, what about the fact that we already have validators that raise [1]? This ([1]) is called from validate_{ip_address mac_address subnet}. How is [1] different than what we are trying to do here?\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/validators.py#L211","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f66225d740e22550316b12bd492f18423eb07cf","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values_display})"},{"line_number":117,"context_line":"                LOG.debug(msg)"},{"line_number":118,"context_line":"                return msg"},{"line_number":119,"context_line":"        except TypeError:"},{"line_number":120,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":121,"context_line":"                         \"compatible for comparison\") %"},{"line_number":122,"context_line":"                       {\u0027data\u0027: data,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_53ca541b","line":119,"in_reply_to":"fa7ab95a_ca54e955","updated":"2016-09-01 13:58:12.000000000","message":"I believe it is not a good idea to add more exception even when we have existing exceptions without special and strong reasons. In this case, we should fix the existing validator raising InvalidInput for consistency.\n\nIMHO if we raise InvalidInput without a consensus and appropriate documentation this will bring us more confusion and some others may try to raise a different exception.\n\nLet\u0027s first clarify the protocol of validators and follow it.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7e5053098bc693f43a1a97935a1f078c9ee87fe4","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                LOG.debug(msg)"},{"line_number":118,"context_line":"                return msg"},{"line_number":119,"context_line":"        except TypeError:"},{"line_number":120,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027%(valid_values)s\u0027 are not \""},{"line_number":121,"context_line":"                         \"compatible for comparison\") %"},{"line_number":122,"context_line":"                       {\u0027data\u0027: data,"},{"line_number":123,"context_line":"                        \u0027valid_values\u0027: valid_values_display})"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_28851206","line":120,"range":{"start_line":120,"start_character":42,"end_line":120,"end_character":58},"updated":"2016-08-30 06:20:25.000000000","message":"Just \u0027valid_values\u0027 here, because any string passed by the caller is irrelevant.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7e5053098bc693f43a1a97935a1f078c9ee87fe4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                        \u0027valid_values\u0027: valid_values_display})"},{"line_number":124,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t \""},{"line_number":127,"context_line":"                 \"support membership operations\") %"},{"line_number":128,"context_line":"               {\u0027valid_values\u0027: valid_values_display})"},{"line_number":129,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_88745e36","line":126,"range":{"start_line":126,"start_character":19,"end_line":126,"end_character":35},"updated":"2016-08-30 06:20:25.000000000","message":"Just \u0027valid_values\u0027 here.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"6045f824f966c3917b3574e24a2a78d583419b6f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                        \u0027valid_values\u0027: valid_values_display})"},{"line_number":124,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t \""},{"line_number":127,"context_line":"                 \"support membership operations\") %"},{"line_number":128,"context_line":"               {\u0027valid_values\u0027: valid_values_display})"},{"line_number":129,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_d0de0cdc","line":126,"range":{"start_line":126,"start_character":19,"end_line":126,"end_character":35},"in_reply_to":"fa7ab95a_88745e36","updated":"2016-08-30 07:30:26.000000000","message":"Using above changes too, we also fail:\n\n AssertionError: \"Invalid input for operation: \u00271\u0027 and \u0027test\u0027 are not compatible for comparison\" does not match \"Invalid input for operation: \u00271\u0027 and \u0027valid_values\u0027 are not compatible for comparison.\"\n\n\n\n\nfrom the test:\n\nresponse \u003d \"Invalid input for operation: \u00271\u0027 and \u0027test\u0027 \" \\\n                   \"are not compatible for comparison\"\n        self.assertRaisesRegex(n_exc.InvalidInput, response,\n                               validators.validate_values, data\u003d1,\n                               valid_values\u003d\u0027test\u0027,\n                               valid_values_display\u003d\"test\")","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b186a78fe91073c6610eca6e06ad6bdc7f3e4adb","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                        \u0027valid_values\u0027: valid_values_display})"},{"line_number":124,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        msg \u003d (_(\"\u0027%(valid_values)s\u0027 doesn\u0027t \""},{"line_number":127,"context_line":"                 \"support membership operations\") %"},{"line_number":128,"context_line":"               {\u0027valid_values\u0027: valid_values_display})"},{"line_number":129,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_5e2f6d3e","line":126,"range":{"start_line":126,"start_character":19,"end_line":126,"end_character":35},"in_reply_to":"fa7ab95a_d0de0cdc","updated":"2016-08-30 08:09:18.000000000","message":"See my comments in the tests.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"72dcaa2639c179a9ceae34e74ca51e1515260dd0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    :param data: The data to check within valid_values."},{"line_number":100,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":101,"context_line":"    success or failure."},{"line_number":102,"context_line":"    :param valid_values_display: A string to display that describes the valid"},{"line_number":103,"context_line":"    values. This string is only displayed when an invalid value is encountered."},{"line_number":104,"context_line":"    If no string is provided, the string \"valid_values\" will be used."},{"line_number":105,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":106,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a8bc5a2_726b5d1e","line":103,"range":{"start_line":102,"start_character":33,"end_line":103,"end_character":12},"updated":"2016-09-27 11:41:05.000000000","message":"Thinking about this more, my preference would be to have valid_values_display as a boolean to indicate whether to show or not, and then to display the valid values, as a comma separated list, encoded as a string, AND, if more than 4 values, use ... to indicate more values. For example, with range(65536), use \"0,1,2,...65535\", built from the range, rather than a hard-coded string \"[0..65535]\". It\u0027s not as descriptive, but you don\u0027t have the issue of the display values getting out of sync with the actual valid values.","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d51617a491f898c01a56bceede7d1e3a2c2deb8a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    :param data: The data to check within valid_values."},{"line_number":100,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":101,"context_line":"    success or failure."},{"line_number":102,"context_line":"    :param valid_values_display: A string to display that describes the valid"},{"line_number":103,"context_line":"    values. This string is only displayed when an invalid value is encountered."},{"line_number":104,"context_line":"    If no string is provided, the string \"valid_values\" will be used."},{"line_number":105,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":106,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_d93689e6","line":103,"range":{"start_line":102,"start_character":33,"end_line":103,"end_character":12},"in_reply_to":"5a8bc5a2_06f49758","updated":"2016-09-30 08:13:10.000000000","message":"I\u0027m with boden here. IMHO it\u0027s better to have a descriptive valid_values_display which could be None-able.\n\nYou could still generate a more or less detailed string from the values. (You could tune that for a range if you want, but that will be expected to be done by valid_values_display for now). Programmers have many (infinite) ways to shot themselves on the feet, no matter how cautious we are.","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d239ec406e1ff8ab7dbf6fede9e113b39b3a67a0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    :param data: The data to check within valid_values."},{"line_number":100,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":101,"context_line":"    success or failure."},{"line_number":102,"context_line":"    :param valid_values_display: A string to display that describes the valid"},{"line_number":103,"context_line":"    values. This string is only displayed when an invalid value is encountered."},{"line_number":104,"context_line":"    If no string is provided, the string \"valid_values\" will be used."},{"line_number":105,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":106,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a8bc5a2_06f49758","line":103,"range":{"start_line":102,"start_character":33,"end_line":103,"end_character":12},"in_reply_to":"5a8bc5a2_726b5d1e","updated":"2016-09-27 12:40:37.000000000","message":"IMHO it\u0027s best to just let the caller pass in the string to display here. There are a number of ways we could handle formatting the string, but our internal way of handling may not cater to all consumers. By letting consumers pass this in, IMO we\u0027ve made this more generic.","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d239ec406e1ff8ab7dbf6fede9e113b39b3a67a0","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":126,"context_line":"                         \"compatible for comparison\") %"},{"line_number":127,"context_line":"                       {\u0027data\u0027: data})"},{"line_number":128,"context_line":"                raise TypeError(error_message\u003dmsg)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a8bc5a2_e64c0ba0","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":21},"updated":"2016-09-27 12:40:37.000000000","message":"Looking back at Akihiro comments on raising; IMHO we should still be raising in the case of a programming error. Other validators in here do so, and I think we need to differentiate between data that\u0027s not in valid values and some programming error not passing in the right params. If we just return an empty string in these cases; the programming error is masked.","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f80e1275c48f0a686c3151df8fd9b4ccaef7efea","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":126,"context_line":"                         \"compatible for comparison\") %"},{"line_number":127,"context_line":"                       {\u0027data\u0027: data})"},{"line_number":128,"context_line":"                raise TypeError(error_message\u003dmsg)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_92984cc2","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":21},"in_reply_to":"3a98d1f4_111a856e","updated":"2016-09-30 11:14:11.000000000","message":"Done","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f0968d81b121b13a2a3c371923b5755bf34de268","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":126,"context_line":"                         \"compatible for comparison\") %"},{"line_number":127,"context_line":"                       {\u0027data\u0027: data})"},{"line_number":128,"context_line":"                raise TypeError(error_message\u003dmsg)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_111a856e","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":21},"in_reply_to":"3a98d1f4_39ef6d88","updated":"2016-09-30 08:47:38.000000000","message":"Oh, and TypeError does not accept error_message as we talked in IRC..\n\nYou can do TypeError(msg)","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f80e1275c48f0a686c3151df8fd9b4ccaef7efea","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":126,"context_line":"                         \"compatible for comparison\") %"},{"line_number":127,"context_line":"                       {\u0027data\u0027: data})"},{"line_number":128,"context_line":"                raise TypeError(error_message\u003dmsg)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_b2954888","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":21},"in_reply_to":"3a98d1f4_39ef6d88","updated":"2016-09-30 11:14:11.000000000","message":"This was suggested as something to discard as valid_values can be a big list that could clog output","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d51617a491f898c01a56bceede7d1e3a2c2deb8a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":126,"context_line":"                         \"compatible for comparison\") %"},{"line_number":127,"context_line":"                       {\u0027data\u0027: data})"},{"line_number":128,"context_line":"                raise TypeError(error_message\u003dmsg)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_39ef6d88","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":21},"in_reply_to":"3a98d1f4_f029b38a","updated":"2016-09-30 08:13:10.000000000","message":"IMO this shall be enough, the traceback will be sufficiently indicative of why the error happened. I\u0027d add %(valid_values)s to the exception message btw.","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9d4ecd14c5911e010b4005060a90b6b63169a3d4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":126,"context_line":"                         \"compatible for comparison\") %"},{"line_number":127,"context_line":"                       {\u0027data\u0027: data})"},{"line_number":128,"context_line":"                raise TypeError(error_message\u003dmsg)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_f029b38a","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":21},"in_reply_to":"5a8bc5a2_32c3768c","updated":"2016-09-29 17:43:09.000000000","message":"I\u0027d like to hear from HenryG (and other cores) on this. I don\u0027t have +2 power so my opinion only counts a little bit ;)","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"8da66d718f41c0b03ce02cd6cb6073f61c4a63af","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 and \u0027valid_values\u0027 are not \""},{"line_number":126,"context_line":"                         \"compatible for comparison\") %"},{"line_number":127,"context_line":"                       {\u0027data\u0027: data})"},{"line_number":128,"context_line":"                raise TypeError(error_message\u003dmsg)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a8bc5a2_32c3768c","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":21},"in_reply_to":"5a8bc5a2_e64c0ba0","updated":"2016-09-27 20:03:01.000000000","message":"So, can we come back to what I put in one on the initial submissions, that used a neutron internal exception (I think it was INPUT) that allows to output a message with the error?\n\nIf I do, will be anyone against? or will get this finally merged?\n\nThanks,\nPablo","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"3f18c303a5e699f933aeb7b3db68ed96b547dba5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                       {\u0027data\u0027: data})"},{"line_number":128,"context_line":"                raise TypeError(error_message\u003dmsg)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"},{"line_number":132,"context_line":"        raise TypeError(error_message\u003dmsg)"},{"line_number":133,"context_line":"        LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_3f2cad01","line":130,"updated":"2016-09-30 08:37:06.000000000","message":"may be you can explain the type of valid_values you have. \n\n\u0027valid_values\u0027 of type %(valid_values_type)s doesn\u0027t...)\n\n% {\u0027valid_values_type\u0027: type(valid_values)}","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f80e1275c48f0a686c3151df8fd9b4ccaef7efea","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                       {\u0027data\u0027: data})"},{"line_number":128,"context_line":"                raise TypeError(error_message\u003dmsg)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"},{"line_number":132,"context_line":"        raise TypeError(error_message\u003dmsg)"},{"line_number":133,"context_line":"        LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_72ae6099","line":130,"in_reply_to":"3a98d1f4_3f2cad01","updated":"2016-09-30 11:14:11.000000000","message":"Done","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"cdd0e603ee58f64ea38dc7e0ffad8e264f628b0d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"},{"line_number":132,"context_line":"        raise TypeError(error_message\u003dmsg)"},{"line_number":133,"context_line":"        LOG.debug(msg)"},{"line_number":134,"context_line":"        return msg"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_5f8c1935","line":133,"updated":"2016-09-30 08:34:17.000000000","message":"you can remove L133 y L134 as those won\u0027t be triggered (exception is raised in L132)","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f80e1275c48f0a686c3151df8fd9b4ccaef7efea","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":131,"context_line":"                 \"support membership operations\"))"},{"line_number":132,"context_line":"        raise TypeError(error_message\u003dmsg)"},{"line_number":133,"context_line":"        LOG.debug(msg)"},{"line_number":134,"context_line":"        return msg"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_727f4066","line":133,"in_reply_to":"3a98d1f4_5f8c1935","updated":"2016-09-30 11:14:11.000000000","message":"Done","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8e2a1904d951830fd139a53beb8c9231e9499b31","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        \u0027typevalues\u0027: type(valid_values)})"},{"line_number":130,"context_line":"                raise TypeError(msg)"},{"line_number":131,"context_line":"    else:"},{"line_number":132,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":133,"context_line":"                 \"support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3a98d1f4_d92c9b9b","line":132,"updated":"2016-09-30 20:30:10.000000000","message":"Looks like this still isn\u0027t tested based on coverage report: http://logs.openstack.org/99/343799/22/check/neutron-lib-coverage-ubuntu-xenial/7a4e221/cover/neutron_lib_api_validators_py.html","commit_id":"a971e419857cc5feae745bcdd3748bb0f72539c2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"855de29f594d4cf66ead3930746447db79ca3a77","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    \"\"\"Validate that the provided \u0027data\u0027 is within \u0027valid_values\u0027."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    :param data: The data to check within valid_values."},{"line_number":100,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":101,"context_line":"    success or failure."},{"line_number":102,"context_line":"    :param valid_values_display: A string to display that describes the valid"},{"line_number":103,"context_line":"    values. This string is only displayed when an invalid value is encountered."},{"line_number":104,"context_line":"    If no string is provided, the string \"valid_values\" will be used."}],"source_content_type":"text/x-python","patch_set":23,"id":"3a98d1f4_e6506f0d","line":101,"range":{"start_line":100,"start_character":25,"end_line":101,"end_character":23},"updated":"2016-10-04 14:11:50.000000000","message":"\"A collection of values that \u0027data\u0027 must be in to be valid. The collection can be any type that supports the \u0027in\u0027 operation.\"","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f5dbea68a1990f7c92129cc1d6b9c1a637de98de","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    \"\"\"Validate that the provided \u0027data\u0027 is within \u0027valid_values\u0027."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    :param data: The data to check within valid_values."},{"line_number":100,"context_line":"    :param valid_values: The values among \u0027data\u0027 should be present to return"},{"line_number":101,"context_line":"    success or failure."},{"line_number":102,"context_line":"    :param valid_values_display: A string to display that describes the valid"},{"line_number":103,"context_line":"    values. This string is only displayed when an invalid value is encountered."},{"line_number":104,"context_line":"    If no string is provided, the string \"valid_values\" will be used."}],"source_content_type":"text/x-python","patch_set":23,"id":"1a95cdbc_4172e4e6","line":101,"range":{"start_line":100,"start_character":25,"end_line":101,"end_character":23},"in_reply_to":"3a98d1f4_e6506f0d","updated":"2016-10-04 20:17:15.000000000","message":"Done","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"855de29f594d4cf66ead3930746447db79ca3a77","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    If no string is provided, the string \"valid_values\" will be used."},{"line_number":105,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":106,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":107,"context_line":"    compatible for comparison or doesn\u0027t have __contains__"},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Make all checks with default valid_values to return without error"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a98d1f4_e307817f","line":107,"updated":"2016-10-04 14:11:50.000000000","message":"Nit: Indent the continued lines in the docstring. That will visually separate the arguments and make the docstring easier to read, I think.","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f5dbea68a1990f7c92129cc1d6b9c1a637de98de","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    If no string is provided, the string \"valid_values\" will be used."},{"line_number":105,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":106,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":107,"context_line":"    compatible for comparison or doesn\u0027t have __contains__"},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Make all checks with default valid_values to return without error"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a95cdbc_6177e0d4","line":107,"in_reply_to":"3a98d1f4_e307817f","updated":"2016-10-04 20:17:15.000000000","message":"Done","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"855de29f594d4cf66ead3930746447db79ca3a77","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    compatible for comparison or doesn\u0027t have __contains__"},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":111,"context_line":"    if valid_values is None:"},{"line_number":112,"context_line":"        return"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"3a98d1f4_c33525a9","line":110,"range":{"start_line":110,"start_character":6,"end_line":110,"end_character":71},"updated":"2016-10-04 14:11:50.000000000","message":"Nit: \"If valid_values is not specified we don\u0027t check against it.\"","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f5dbea68a1990f7c92129cc1d6b9c1a637de98de","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    compatible for comparison or doesn\u0027t have __contains__"},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Make all checks with default valid_values to return without error"},{"line_number":111,"context_line":"    if valid_values is None:"},{"line_number":112,"context_line":"        return"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a95cdbc_a181e891","line":110,"range":{"start_line":110,"start_character":6,"end_line":110,"end_character":71},"in_reply_to":"3a98d1f4_c33525a9","updated":"2016-10-04 20:17:15.000000000","message":"Done","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"855de29f594d4cf66ead3930746447db79ca3a77","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            if data not in valid_values:"},{"line_number":119,"context_line":"                valid_values_display \u003d valid_values_display or \u0027valid_values\u0027"},{"line_number":120,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 is not in %(valid_values)s\") %"},{"line_number":121,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values_display})"},{"line_number":122,"context_line":"                LOG.debug(msg)"},{"line_number":123,"context_line":"                return msg"},{"line_number":124,"context_line":"        except TypeError:"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a95cdbc_db34334c","line":121,"updated":"2016-10-04 14:11:50.000000000","message":"Note the following call:\n\n  validate_values(4, [\u00274\u0027, \u00276\u0027], \"[\u00274\u0027, \u00276\u0027]\")\n\nwill display:\n\n  \u00274\u0027 is not in [\u00274\u0027, \u00276\u0027]\n\nWhich is misleading. Maybe we should not put quotes around \u0027%(data)\u0027?","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f5dbea68a1990f7c92129cc1d6b9c1a637de98de","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            if data not in valid_values:"},{"line_number":119,"context_line":"                valid_values_display \u003d valid_values_display or \u0027valid_values\u0027"},{"line_number":120,"context_line":"                msg \u003d (_(\"\u0027%(data)s\u0027 is not in %(valid_values)s\") %"},{"line_number":121,"context_line":"                       {\u0027data\u0027: data, \u0027valid_values\u0027: valid_values_display})"},{"line_number":122,"context_line":"                LOG.debug(msg)"},{"line_number":123,"context_line":"                return msg"},{"line_number":124,"context_line":"        except TypeError:"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a95cdbc_7c3ea3b9","line":121,"in_reply_to":"1a95cdbc_db34334c","updated":"2016-10-04 20:17:15.000000000","message":"Done","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"855de29f594d4cf66ead3930746447db79ca3a77","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        \u0027typevalues\u0027: type(valid_values)})"},{"line_number":130,"context_line":"                raise TypeError(msg)"},{"line_number":131,"context_line":"    else:"},{"line_number":132,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":133,"context_line":"                 \"support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"3a98d1f4_a372d947","line":132,"range":{"start_line":132,"start_character":33,"end_line":132,"end_character":40},"updated":"2016-10-04 14:11:50.000000000","message":"Nit: does not","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f5dbea68a1990f7c92129cc1d6b9c1a637de98de","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        \u0027typevalues\u0027: type(valid_values)})"},{"line_number":130,"context_line":"                raise TypeError(msg)"},{"line_number":131,"context_line":"    else:"},{"line_number":132,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":133,"context_line":"                 \"support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a95cdbc_fc78f391","line":132,"range":{"start_line":132,"start_character":33,"end_line":132,"end_character":40},"in_reply_to":"3a98d1f4_a372d947","updated":"2016-10-04 20:17:15.000000000","message":"Done","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2c6f21b9b6ab5e68ded50d88eb681a5caba51f32","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        \u0027typevalues\u0027: type(valid_values)})"},{"line_number":130,"context_line":"                raise TypeError(msg)"},{"line_number":131,"context_line":"    else:"},{"line_number":132,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":133,"context_line":"                 \"support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a95cdbc_e602eb0a","line":132,"range":{"start_line":132,"start_character":33,"end_line":132,"end_character":40},"in_reply_to":"3a98d1f4_a372d947","updated":"2016-10-05 20:43:14.000000000","message":"why not embrace contractions?? :)","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"855de29f594d4cf66ead3930746447db79ca3a77","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                raise TypeError(msg)"},{"line_number":131,"context_line":"    else:"},{"line_number":132,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":133,"context_line":"                 \"support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"3a98d1f4_83a95d27","line":133,"updated":"2016-10-04 14:11:50.000000000","message":"Nit: This msg fits on one line.","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f5dbea68a1990f7c92129cc1d6b9c1a637de98de","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                raise TypeError(msg)"},{"line_number":131,"context_line":"    else:"},{"line_number":132,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 doesn\u0027t \""},{"line_number":133,"context_line":"                 \"support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a95cdbc_1c6e7fc9","line":133,"in_reply_to":"3a98d1f4_83a95d27","updated":"2016-10-04 20:17:15.000000000","message":"Done","commit_id":"c3715b25648acf0a94c1e65a7768edd31562b9bf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"816da357c80913d84de41da7fd49e3c218efc2f8","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        values. This string is only displayed when an invalid value is"},{"line_number":104,"context_line":"        encountered."},{"line_number":105,"context_line":"        If no string is provided, the string \"valid_values\" will be used."},{"line_number":106,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":107,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":108,"context_line":"        compatible for comparison or doesn\u0027t have __contains__"},{"line_number":109,"context_line":"    \"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    # If valid_values is not specified we don\u0027t check against it."}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_5f79c392","line":108,"range":{"start_line":106,"start_character":4,"end_line":108,"end_character":62},"updated":"2016-10-11 13:12:15.000000000","message":"This docstring needs to be updated accordingly.","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"57385a1a2fba67ea16c0fc9c402c419440ed0b9c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        values. This string is only displayed when an invalid value is"},{"line_number":104,"context_line":"        encountered."},{"line_number":105,"context_line":"        If no string is provided, the string \"valid_values\" will be used."},{"line_number":106,"context_line":"    :returns: The message to return if data not in valid_values."},{"line_number":107,"context_line":"    :raises: InvalidInput if the values for \u0027data\u0027 or \u0027valid_values\u0027 are not"},{"line_number":108,"context_line":"        compatible for comparison or doesn\u0027t have __contains__"},{"line_number":109,"context_line":"    \"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    # If valid_values is not specified we don\u0027t check against it."}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_6ad5e341","line":108,"range":{"start_line":106,"start_character":4,"end_line":108,"end_character":62},"in_reply_to":"fa6399be_5f79c392","updated":"2016-10-11 13:31:23.000000000","message":"+1\n\nIn fact, we should emphasize that if this returns a TypeError, the developer must fix the programming error in the validator that caused it. Also that developers must have thorough tests that ensure that TypeError is never raised for any input to the validation.","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f57a90fa8f57d19b1d607860cbcc798bab4b0154","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                LOG.debug(msg)"},{"line_number":124,"context_line":"                return msg"},{"line_number":125,"context_line":"        except TypeError:"},{"line_number":126,"context_line":"                msg \u003d (_(\"\u0027data\u0027 of type \u0027%(typedata)s\u0027 and \u0027valid_values\u0027\""},{"line_number":127,"context_line":"                         \"of type \u0027%(typevalues)s\u0027 are not \""},{"line_number":128,"context_line":"                         \"compatible for comparison\") %"},{"line_number":129,"context_line":"                       {\u0027typedata\u0027: type(data),"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_79fea76c","line":126,"updated":"2016-10-11 12:41:31.000000000","message":"It may be good have a comment before this msg: \"# This is a programming error\".","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f57a90fa8f57d19b1d607860cbcc798bab4b0154","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                        \u0027typevalues\u0027: type(valid_values)})"},{"line_number":131,"context_line":"                raise TypeError(msg)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 does not support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_59300357","line":133,"updated":"2016-10-11 12:41:31.000000000","message":"It may be good have a comment before this msg: \"# This is a programming error\".","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"70dddb2cceb92028c4050362719a3ecfa39e8533","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise TypeError(msg)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 does not support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def validate_not_empty_string_or_none(data, max_len\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_b96cc29d","line":134,"updated":"2016-10-11 11:38:36.000000000","message":"Workflow -1 because I\u0027d like Akihiro to confirm that it is OK that we raise TypeError here and line 131.","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b392ab2dfc9fe23602b0b5b7551f2a94942bfb77","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise TypeError(msg)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 does not support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def validate_not_empty_string_or_none(data, max_len\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_f4bb9f73","line":134,"in_reply_to":"fa6399be_14657344","updated":"2016-10-11 12:07:33.000000000","message":"If you want to check what happens if TypeError is raised from a validator, the easiest way is to change the existing validate_string validator to raise TypeError, restart neutron-server and create a network with a name longer than 255 chars. You will get 500 error.","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f57a90fa8f57d19b1d607860cbcc798bab4b0154","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise TypeError(msg)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 does not support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def validate_not_empty_string_or_none(data, max_len\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_39126fb5","line":134,"in_reply_to":"fa6399be_36ba7ce2","updated":"2016-10-11 12:41:31.000000000","message":"To be clear: replace \"raise TypeError(msg)\" with \"return msg\" here and line 131. Adjust the tests accordingly.","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"816da357c80913d84de41da7fd49e3c218efc2f8","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise TypeError(msg)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 does not support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def validate_not_empty_string_or_none(data, max_len\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_ff90d797","line":134,"in_reply_to":"fa6399be_39126fb5","updated":"2016-10-11 13:12:15.000000000","message":"Is TypeError raised only when an programing error? If so, I don\u0027t think TypeError is a problem because it is truely a bug of neutorn-server side and there is no fault in user request.","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ad457490b8a028858abd8903060b04c308005a2b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise TypeError(msg)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 does not support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def validate_not_empty_string_or_none(data, max_len\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_14657344","line":134,"in_reply_to":"fa6399be_b4b92731","updated":"2016-10-11 12:05:33.000000000","message":"Even though raising TypeError makes sense as a validator code, the current neutron API layer cannot handle TypeError and it leads to an internal error (500) response.\n\n--\n\nAs I commented before, the current official interface of API validators is:\n- when no validation error is detected, None is returned\n- when some validation error is detected, non-empty string which describe an error reason is returned.\n\nA validator is called from neutron.api.v2.attributes.convert_value().\nThe expected behavior of a validator is that no exception is raised.\n\nIn addition, as the side effect of exception handling of the API layer, we can also raise InvalidInput **by accident** now.\n\n--\n\nThus, my suggestion to this patch is to follow the convention to return an non-empty string with error message when a validator detects an error.\n\nThen, update the behavior of neutron API layer if you want to raise TypeError.\n\n(If you want to raise some exception anyway, you can raise InvalidInput but I don\u0027t think it is a good way from the above reason).","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"15ee035d1f77961304ddd1cc691ec3850d75bc3d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise TypeError(msg)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 does not support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def validate_not_empty_string_or_none(data, max_len\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_b4b92731","line":134,"in_reply_to":"fa6399be_b96cc29d","updated":"2016-10-11 11:54:51.000000000","message":"I believe it\u0027s not only ok, but the right thing to do, since it\u0027s a programming error: programmer tries to use the validator with a wrong \"valid_values\"  vs...  something that is not valid (return msg..)","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"baa9be1402463206094eb24eaa08a31a3686ee87","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise TypeError(msg)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 does not support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def validate_not_empty_string_or_none(data, max_len\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_36ba7ce2","line":134,"in_reply_to":"fa6399be_f4bb9f73","updated":"2016-10-11 12:17:26.000000000","message":"Thanks Akihiro for the detailed explanation. It seems that the current behavior of the API layer could do with some tweaking, but for now we must stick to returning a msg.\n\nUntil the, when using validate_values() we must hope that developers do sufficient testing so that these internal type errors do not make it to the user.","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f36ec181f0b75e93b28c3d0dfcb2ffda3b2fdb4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise TypeError(msg)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 does not support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def validate_not_empty_string_or_none(data, max_len\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_0abaa723","line":134,"in_reply_to":"fa6399be_ff90d797","updated":"2016-10-11 13:30:59.000000000","message":"After discussing with Henry, I confirmed the current TypeError is only raised when there is a programming error. If so, 500 is fine because it is a programming error. You don\u0027t need to change the logic. Sorry for confusion.\n\nOn the other hand, it is better to update the docstring L.107-108 and add comments Henry suggested (L.126 and L.134). Considering these, I keep my -1.","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7f1cb5976f0199e065f5e33c144f3b094e00c11b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise TypeError(msg)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        msg \u003d (_(\"\u0027valid_values\u0027 does not support membership operations\"))"},{"line_number":134,"context_line":"        raise TypeError(msg)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def validate_not_empty_string_or_none(data, max_len\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_0abf07fc","line":134,"in_reply_to":"fa6399be_ff90d797","updated":"2016-10-11 13:31:49.000000000","message":"Exactly, that was my point, TypeError is only raised when the declaration of the API validator has been done incorrectly.\n\nSo, in that case an error 500, and a trace for the programmer to see makes perfect sense.\n\nTypeError in current implementation won\u0027t be thrown for invalid inputs, just for invalid code/api definitions.","commit_id":"2186ba45a7325b8bd63a5d982b9b1e6815b23cbd"}],"neutron_lib/tests/unit/api/test_validators.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"42baa5f4db2db1eba28b21c32e688c6f76f2526e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        # TODO(iranzo) What it should be?"},{"line_number":117,"context_line":"        self.assertEqual(\"Provided \u00271\u0027or \u0027[2, 3, 4, 5]\u0027 with wrong type\", msg)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_validate_not_empty_string(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_b972bde3","line":119,"updated":"2016-07-18 19:17:55.000000000","message":"what about: validators.validate_values(\"1\", [\"2\", \"1\", \"3\"])","commit_id":"d9e7ac20ffe1721c13fcabd625d0fcfb00eb5091"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a6f3c5785ec27eb0dde101af9a679bebc397b169","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                               valid_values\u003d\u0027[2, 3, 4, 5]\u0027,"},{"line_number":143,"context_line":"                               valid_values_display\u003dFalse)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # msg \u003d validators.validate_values(1, \"[2, 3, 4, 5]\")"},{"line_number":146,"context_line":"        # response \u003d \"\u0027data\u0027 and \u0027valid_values\u0027 \" \\"},{"line_number":147,"context_line":"        #           \"are not compatible for comparison\""},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_b505be15","line":145,"updated":"2016-08-24 15:37:34.000000000","message":"We should remove these commented out lines IMO.","commit_id":"1a3239941c1019e7e1538213f9221f947eff1ed2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"a98f8c3df196cbee3dff25874322e1342c4c2740","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                               valid_values\u003d\u0027[2, 3, 4, 5]\u0027,"},{"line_number":143,"context_line":"                               valid_values_display\u003dFalse)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # msg \u003d validators.validate_values(1, \"[2, 3, 4, 5]\")"},{"line_number":146,"context_line":"        # response \u003d \"\u0027data\u0027 and \u0027valid_values\u0027 \" \\"},{"line_number":147,"context_line":"        #           \"are not compatible for comparison\""},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_6925185b","line":145,"in_reply_to":"1ac06dbe_b505be15","updated":"2016-08-24 22:31:47.000000000","message":"Done","commit_id":"1a3239941c1019e7e1538213f9221f947eff1ed2"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3bbc5409f654f2517ddfbedbb3dd2bb6b4f1bf55","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                   \"are not compatible for comparison\""},{"line_number":133,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":134,"context_line":"                               validators.validate_values, data\u003d1,"},{"line_number":135,"context_line":"                               valid_values\u003d\u0027[2, 3, 4, 5]\u0027,"},{"line_number":136,"context_line":"                               valid_values_display\u003dTrue)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        response \u003d \"Invalid input for operation: \u0027data\u0027 and \u0027valid_values\u0027 \" \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_2b77623c","line":135,"range":{"start_line":135,"start_character":44,"end_line":135,"end_character":58},"updated":"2016-08-25 14:52:23.000000000","message":"Would it be clearer if you just put \"some string\" instead of a string that looks like a list?","commit_id":"e108f7c28aa03fcf08355078df6a669405f90109"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"377232012050058cee7831b78a99c9793d32b4ad","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                   \"are not compatible for comparison\""},{"line_number":133,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":134,"context_line":"                               validators.validate_values, data\u003d1,"},{"line_number":135,"context_line":"                               valid_values\u003d\u0027[2, 3, 4, 5]\u0027,"},{"line_number":136,"context_line":"                               valid_values_display\u003dTrue)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        response \u003d \"Invalid input for operation: \u0027data\u0027 and \u0027valid_values\u0027 \" \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_ef6d559a","line":135,"range":{"start_line":135,"start_character":44,"end_line":135,"end_character":58},"in_reply_to":"1ac06dbe_2b77623c","updated":"2016-08-25 15:03:17.000000000","message":"Hi Paul,\nIt was done like that, because at one point during the conversations on this review or the one that implemented validate_integer it was mentioned that the arguments should be converted and compared (for example, int to list of ints, etc), so I did keep the comparisions like they were.\n\nIt\u0027s similar to what we\u0027ve in line #127  the random  string one it\u0027s on line 113/115","commit_id":"e108f7c28aa03fcf08355078df6a669405f90109"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3bbc5409f654f2517ddfbedbb3dd2bb6b4f1bf55","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                   \"are not compatible for comparison\""},{"line_number":140,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":141,"context_line":"                               validators.validate_values, data\u003d1,"},{"line_number":142,"context_line":"                               valid_values\u003d\u0027[2, 3, 4, 5]\u0027,"},{"line_number":143,"context_line":"                               valid_values_display\u003dFalse)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        response \u003d \"Invalid input for operation: \u0027valid_values\u0027 doesn\u0027t \" \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_6b715a44","line":142,"updated":"2016-08-25 14:52:23.000000000","message":"ditto","commit_id":"e108f7c28aa03fcf08355078df6a669405f90109"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b186a78fe91073c6610eca6e06ad6bdc7f3e4adb","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                         valid_values_display\u003d\"(4, 6)\")"},{"line_number":113,"context_line":"        self.assertEqual(\"\u00277\u0027 is not in (4, 6)\", msg)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        response \u003d \"Invalid input for operation: \u00271\u0027 and \u0027test\u0027 \" \\"},{"line_number":116,"context_line":"                   \"are not compatible for comparison\""},{"line_number":117,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":118,"context_line":"                               validators.validate_values, data\u003d1,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_533a069a","line":115,"range":{"start_line":115,"start_character":58,"end_line":115,"end_character":62},"updated":"2016-08-30 08:09:18.000000000","message":"Not a good test case, IMO. Which \u0027test\u0027 is being checked for here? valid_values or valid_values_display?","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"3217b2e0c43a9ad614c6bb84578d51e341c085ff","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                         valid_values_display\u003d\"(4, 6)\")"},{"line_number":113,"context_line":"        self.assertEqual(\"\u00277\u0027 is not in (4, 6)\", msg)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        response \u003d \"Invalid input for operation: \u00271\u0027 and \u0027test\u0027 \" \\"},{"line_number":116,"context_line":"                   \"are not compatible for comparison\""},{"line_number":117,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":118,"context_line":"                               validators.validate_values, data\u003d1,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_ca642ce7","line":115,"range":{"start_line":115,"start_character":58,"end_line":115,"end_character":62},"in_reply_to":"fa7ab95a_42d69928","updated":"2016-08-31 14:38:06.000000000","message":"Done","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"3217b2e0c43a9ad614c6bb84578d51e341c085ff","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                         valid_values_display\u003d\"(4, 6)\")"},{"line_number":113,"context_line":"        self.assertEqual(\"\u00277\u0027 is not in (4, 6)\", msg)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        response \u003d \"Invalid input for operation: \u00271\u0027 and \u0027test\u0027 \" \\"},{"line_number":116,"context_line":"                   \"are not compatible for comparison\""},{"line_number":117,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":118,"context_line":"                               validators.validate_values, data\u003d1,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_2a9af8c5","line":115,"range":{"start_line":115,"start_character":58,"end_line":115,"end_character":62},"in_reply_to":"fa7ab95a_533a069a","updated":"2016-08-31 14:38:06.000000000","message":"Done","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"890ebea85e4eddc6b56c9fd858648815cfad3f6b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                         valid_values_display\u003d\"(4, 6)\")"},{"line_number":113,"context_line":"        self.assertEqual(\"\u00277\u0027 is not in (4, 6)\", msg)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        response \u003d \"Invalid input for operation: \u00271\u0027 and \u0027test\u0027 \" \\"},{"line_number":116,"context_line":"                   \"are not compatible for comparison\""},{"line_number":117,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":118,"context_line":"                               validators.validate_values, data\u003d1,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_6dd393d5","line":115,"range":{"start_line":115,"start_character":58,"end_line":115,"end_character":62},"in_reply_to":"fa7ab95a_533a069a","updated":"2016-08-30 12:43:08.000000000","message":"valid_values is always the one tested, the one in valid_values_display is just what is shown to end user.\n\nLike in the example you provided after this with \u0027Uno\u0027 or with \u00270 to 255\u0027, the values being tested are the ones provided, but still we need to ensure that we get the string we provide as \u0027pretty print\u0027 string, isn\u0027t it?","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"40f86dc32feff0d651940223da5c969df28b9855","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                         valid_values_display\u003d\"(4, 6)\")"},{"line_number":113,"context_line":"        self.assertEqual(\"\u00277\u0027 is not in (4, 6)\", msg)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        response \u003d \"Invalid input for operation: \u00271\u0027 and \u0027test\u0027 \" \\"},{"line_number":116,"context_line":"                   \"are not compatible for comparison\""},{"line_number":117,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":118,"context_line":"                               validators.validate_values, data\u003d1,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_42d69928","line":115,"range":{"start_line":115,"start_character":58,"end_line":115,"end_character":62},"in_reply_to":"fa7ab95a_6dd393d5","updated":"2016-08-30 13:04:09.000000000","message":"In this test case, both valid_values and valid_values_display have the same value (\u0027test\u0027). So it is unclear which one of them the response above is verifying.\n\nThe only case where we want to verify the \u0027pretty print\u0027 string in the response is for the cases above (lines 109 and 113). In fact, I would add a test case where the string differs from the python type:\n\n  validate_values(8, range(8), valid_values_display\u003d\"[0..7]\")","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b186a78fe91073c6610eca6e06ad6bdc7f3e4adb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":118,"context_line":"                               validators.validate_values, data\u003d1,"},{"line_number":119,"context_line":"                               valid_values\u003d\u0027test\u0027,"},{"line_number":120,"context_line":"                               valid_values_display\u003d\"test\")"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        msg \u003d validators.validate_values(1, [2, 3, 4, 5],"},{"line_number":123,"context_line":"                                         valid_values_display\u003d\"[2, 3, 4, 5]\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_53d68628","line":120,"updated":"2016-08-30 08:09:18.000000000","message":"Consider the following:\n\n  validate_values(1, valid_values\u003d\u00271\u0027, valid_values_display\u003d\u0027Uno\u0027)\n\nor\n\n  validate_values(1, valid_values\u003d\u00271-256\u0027, valid_values_display\u003d\u00270 to 255\u0027)\n\nMy point here is that \"not compatible for comparison\" is about the relationship between the data and valid_values arguments, and has nothing to do with the display string argument.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"3217b2e0c43a9ad614c6bb84578d51e341c085ff","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":118,"context_line":"                               validators.validate_values, data\u003d1,"},{"line_number":119,"context_line":"                               valid_values\u003d\u0027test\u0027,"},{"line_number":120,"context_line":"                               valid_values_display\u003d\"test\")"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        msg \u003d validators.validate_values(1, [2, 3, 4, 5],"},{"line_number":123,"context_line":"                                         valid_values_display\u003d\"[2, 3, 4, 5]\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_aa39a8da","line":120,"in_reply_to":"fa7ab95a_53d68628","updated":"2016-08-31 14:38:06.000000000","message":"Done","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b186a78fe91073c6610eca6e06ad6bdc7f3e4adb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":145,"context_line":"                               validators.validate_values, data\u003d1,"},{"line_number":146,"context_line":"                               valid_values\u003d\u0027[2, 3, 4, 5]\u0027,"},{"line_number":147,"context_line":"                               valid_values_display\u003dFalse)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        response \u003d \"Invalid input for operation: \u0027valid_values\u0027 doesn\u0027t \" \\"},{"line_number":150,"context_line":"                   \"support membership operations\""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_f3aeba2c","line":147,"range":{"start_line":147,"start_character":31,"end_line":147,"end_character":57},"updated":"2016-08-30 08:09:18.000000000","message":"This is no longer a relevant test case. The docstring says this must be a string, so testing for any non-string value is just confusing.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"3217b2e0c43a9ad614c6bb84578d51e341c085ff","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":145,"context_line":"                               validators.validate_values, data\u003d1,"},{"line_number":146,"context_line":"                               valid_values\u003d\u0027[2, 3, 4, 5]\u0027,"},{"line_number":147,"context_line":"                               valid_values_display\u003dFalse)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        response \u003d \"Invalid input for operation: \u0027valid_values\u0027 doesn\u0027t \" \\"},{"line_number":150,"context_line":"                   \"support membership operations\""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_0a1a946e","line":147,"range":{"start_line":147,"start_character":31,"end_line":147,"end_character":57},"in_reply_to":"fa7ab95a_f3aeba2c","updated":"2016-08-31 14:38:06.000000000","message":"Done","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b186a78fe91073c6610eca6e06ad6bdc7f3e4adb","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":153,"context_line":"                               validators.validate_values, data\u003d\"a\","},{"line_number":154,"context_line":"                               valid_values\u003d3, valid_values_display\u003dFalse)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        response \u003d \"Invalid input for operation: \u00273\u0027 doesn\u0027t \" \\"},{"line_number":157,"context_line":"                   \"support membership operations\""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_936c8e09","line":154,"range":{"start_line":154,"start_character":47,"end_line":154,"end_character":73},"updated":"2016-08-30 08:09:18.000000000","message":"ditto","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b186a78fe91073c6610eca6e06ad6bdc7f3e4adb","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                               valid_values\u003d3, valid_values_display\u003dFalse)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        response \u003d \"Invalid input for operation: \u00273\u0027 doesn\u0027t \" \\"},{"line_number":157,"context_line":"                   \"support membership operations\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":160,"context_line":"                               validators.validate_values, data\u003d\"a\","}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_1e1de565","line":157,"updated":"2016-08-30 08:09:18.000000000","message":"Same comment as line 115.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"3217b2e0c43a9ad614c6bb84578d51e341c085ff","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                               valid_values\u003d3, valid_values_display\u003dFalse)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        response \u003d \"Invalid input for operation: \u00273\u0027 doesn\u0027t \" \\"},{"line_number":157,"context_line":"                   \"support membership operations\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":160,"context_line":"                               validators.validate_values, data\u003d\"a\","}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_cffefe37","line":157,"in_reply_to":"fa7ab95a_1e1de565","updated":"2016-08-31 14:38:06.000000000","message":"Done","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b186a78fe91073c6610eca6e06ad6bdc7f3e4adb","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":160,"context_line":"                               validators.validate_values, data\u003d\"a\","},{"line_number":161,"context_line":"                               valid_values\u003d3, valid_values_display\u003d\"3\")"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_validate_not_empty_string(self):"},{"line_number":164,"context_line":"        msg \u003d validators.validate_not_empty_string(\u0027    \u0027, None)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_3ee2a92f","line":161,"updated":"2016-08-30 08:09:18.000000000","message":"Consider the following:\n\n  validate_values(\u00273\u0027, valid_values\u003d3, valid_values_display\u003d\u0027Three\u0027)\n\nor\n\n  validate_values(1, valid_values\u003d1-256, valid_values_display\u003d\u00271 to 256\u0027)\n\nThe error \"doesn\u0027t support membership operations\" is only about the valid_values argument, and has nothing to do with the data or the display string argument.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9c6cf80e6016333af2d859e5a853d92a0644e34a","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":160,"context_line":"                               validators.validate_values, data\u003d\"a\","},{"line_number":161,"context_line":"                               valid_values\u003d3, valid_values_display\u003d\"3\")"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_validate_not_empty_string(self):"},{"line_number":164,"context_line":"        msg \u003d validators.validate_not_empty_string(\u0027    \u0027, None)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_771fc8b6","line":161,"in_reply_to":"fa7ab95a_333ac999","updated":"2016-08-30 18:16:15.000000000","message":"Yes, it\u0027s OK.\n\nHowever, I am beginning to rethink the choice of InvalidInput for the exception. \u0027Input\u0027 kind of implies that we are referring to the data (first arg), while the error is due to valid_values being bad. This is a programming error, a bit like a syntax error. Consider SyntaxError, TypeError, RuntimeError, etc. instead.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"e7b73a2d7bb675dfc16902b91a9eebe01790c38a","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":160,"context_line":"                               validators.validate_values, data\u003d\"a\","},{"line_number":161,"context_line":"                               valid_values\u003d3, valid_values_display\u003d\"3\")"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_validate_not_empty_string(self):"},{"line_number":164,"context_line":"        msg \u003d validators.validate_not_empty_string(\u0027    \u0027, None)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_333ac999","line":161,"in_reply_to":"fa7ab95a_3ee2a92f","updated":"2016-08-30 13:41:34.000000000","message":"response \u003d \"Invalid input for operation: \u00273\u0027 doesn\u0027t \" \\\n                   \"support membership operations\"\n\n        self.assertRaisesRegex(n_exc.InvalidInput, response,\n                               validators.validate_values, data\u003d\"a\",\n                               valid_values\u003d3, valid_values_display\u003d\"3\")\n\n\nyielded:\n\n\"Invalid input for operation: \u00273\u0027 doesn\u0027t support membership operations\" \n\nAnd now, it outputs: \"Invalid input for operation: \u0027valid_values\u0027 doesn\u0027t support membership operations.\"\n\n\nIf that\u0027s ok, we can go with the changes on the function, and let me work the cases as commented above.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"3217b2e0c43a9ad614c6bb84578d51e341c085ff","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":160,"context_line":"                               validators.validate_values, data\u003d\"a\","},{"line_number":161,"context_line":"                               valid_values\u003d3, valid_values_display\u003d\"3\")"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_validate_not_empty_string(self):"},{"line_number":164,"context_line":"        msg \u003d validators.validate_not_empty_string(\u0027    \u0027, None)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_ea33b0f4","line":161,"in_reply_to":"fa7ab95a_7351660e","updated":"2016-08-31 14:38:06.000000000","message":"Done","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"3859ad5e1427d824caed033fdba22af84fbc3f19","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":160,"context_line":"                               validators.validate_values, data\u003d\"a\","},{"line_number":161,"context_line":"                               valid_values\u003d3, valid_values_display\u003d\"3\")"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_validate_not_empty_string(self):"},{"line_number":164,"context_line":"        msg \u003d validators.validate_not_empty_string(\u0027    \u0027, None)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_963b4e38","line":161,"in_reply_to":"fa7ab95a_771fc8b6","updated":"2016-08-31 08:33:32.000000000","message":"Type, etc are not among https://github.com/openstack/neutron-lib/blob/master/neutron_lib/exceptions.py\n\nShould we stick to those?","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e380d2a5f23d647bb96534520da0000f331484a6","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.assertRaisesRegex(n_exc.InvalidInput, response,"},{"line_number":160,"context_line":"                               validators.validate_values, data\u003d\"a\","},{"line_number":161,"context_line":"                               valid_values\u003d3, valid_values_display\u003d\"3\")"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_validate_not_empty_string(self):"},{"line_number":164,"context_line":"        msg \u003d validators.validate_not_empty_string(\u0027    \u0027, None)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_7351660e","line":161,"in_reply_to":"fa7ab95a_963b4e38","updated":"2016-08-31 13:10:20.000000000","message":"See my comment in the validator line 119.","commit_id":"522d67563c8d0b6c7f606c8cb2fb41da82699fe2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d51617a491f898c01a56bceede7d1e3a2c2deb8a","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        msg \u003d validators.validate_values(4, (4, 6))"},{"line_number":105,"context_line":"        self.assertIsNone(msg)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        msg \u003d validators.validate_values(7, [4, 6],"},{"line_number":108,"context_line":"                                         valid_values_display\u003d\"[4, 6]\")"},{"line_number":109,"context_line":"        self.assertEqual(\"\u00277\u0027 is not in [4, 6]\", msg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_440610cf","line":106,"updated":"2016-09-30 08:13:10.000000000","message":"I\u0027d split test cases in a few separate functions:\n\nvalidate_values_list/tuple/with_values_display\n\nor at least de-limit each specific case with comments (see lines 161-181)","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"},{"author":{"_account_id":16448,"name":"Pablo","email":"Pablo.Iranzo@gmail.com","username":"iranzo"},"change_message_id":"f80e1275c48f0a686c3151df8fd9b4ccaef7efea","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        msg \u003d validators.validate_values(4, (4, 6))"},{"line_number":105,"context_line":"        self.assertIsNone(msg)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        msg \u003d validators.validate_values(7, [4, 6],"},{"line_number":108,"context_line":"                                         valid_values_display\u003d\"[4, 6]\")"},{"line_number":109,"context_line":"        self.assertEqual(\"\u00277\u0027 is not in [4, 6]\", msg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_12843c5c","line":106,"in_reply_to":"3a98d1f4_440610cf","updated":"2016-09-30 11:14:11.000000000","message":"Done separation + description on next commit","commit_id":"80b290c1ae1f628a698868000344c2e4d19107d1"}]}
