)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c31b4ac77978c9fc33ab97e45e35e3638493f260","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[1]: http://tools.ietf.org/html/rfc5952"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1531103"},{"line_number":18,"context_line":"Depends-On: I664e55883bbd714e31b49b278060e625fc5e6ea4"},{"line_number":19,"context_line":"Change-Id: Ic9afa5f90fba783748f7c56e8fba02e06af69748"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"7a77a97e_82f2e998","line":18,"updated":"2016-11-22 19:25:49.000000000","message":"Since what you depend on is in the same repo, you don\u0027t need to use Depends-On but should just base this patch on your dependency [1]. \n\n\n[1] http://docs.openstack.org/infra/manual/developers.html#adding-a-dependency","commit_id":"a74479832edeccc786e9fc24402f7fe6e01c9f3c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"80088e542428450e735efdc330bd7fe64078a71b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[1]: http://tools.ietf.org/html/rfc5952"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1531103"},{"line_number":18,"context_line":"Depends-On: I664e55883bbd714e31b49b278060e625fc5e6ea4"},{"line_number":19,"context_line":"Change-Id: Ic9afa5f90fba783748f7c56e8fba02e06af69748"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"5a74a57a_b48e9925","line":18,"in_reply_to":"7a77a97e_82f2e998","updated":"2016-11-23 05:09:45.000000000","message":"Doesnt need it anymore, as the previous patch got merged :)","commit_id":"a74479832edeccc786e9fc24402f7fe6e01c9f3c"}],"doc/source/devref/api_converters.rst":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f80bc0296003ff4b52e7a8fde27f12c71699e0bd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"of the multifaceted style of writing an IPv6 address, it is proposed that"},{"line_number":93,"context_line":"the IPv6 address in Neutron should be saved in the canonical format."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"If a user passes an IPv6 address, it will be saved in the canonical format"},{"line_number":96,"context_line":"by Neutron and displayed to the user during list/show operations in the"},{"line_number":97,"context_line":"same format."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The full document is found at : http://tools.ietf.org/html/rfc5952"}],"source_content_type":"text/x-rst","patch_set":32,"id":"5a74a57a_7134ef49","line":97,"range":{"start_line":95,"start_character":0,"end_line":97,"end_character":12},"updated":"2016-11-30 12:13:39.000000000","message":"Back to my comment on PS26; I don\u0027t see why we are talking about how neutron uses this converter here in lib. IMO lib should remain agnostic to how consumers use its function and let them document as such.\n\n\nWith that in mind I\u0027d opt to remove this sentence that makes assumption about how neutron uses the converter.","commit_id":"7f1c94040011c598d8b975b1eb877a2452504d80"}],"doc/source/devref/index.rst":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"96789fafa35bfcfc31c15f0ffbb273a056401f60","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   api_converters"},{"line_number":36,"context_line":"   api_validators"},{"line_number":37,"context_line":"   callbacks"},{"line_number":38,"context_line":"   ipv6_address_usage"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Module Reference"}],"source_content_type":"text/x-rst","patch_set":17,"id":"9a629dbe_c2f10503","line":38,"range":{"start_line":38,"start_character":3,"end_line":38,"end_character":21},"updated":"2016-11-10 03:14:35.000000000","message":"I am not sure if we need a separate devref for this.. How about adding this section inside api_validators Or create a new file for capturing all the particulars related to usage?\n\nMy worry is if we start having separate files for each functionality then we will end up having lot of files which might result to maintenance difficulties going forward.","commit_id":"90a0d19289fbae60acdf07d12adc42cfd286a7ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c2e43a3c1b2c1f9685176b3d39ae548f74593c2d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   api_converters"},{"line_number":36,"context_line":"   api_validators"},{"line_number":37,"context_line":"   callbacks"},{"line_number":38,"context_line":"   ipv6_address_usage"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Module Reference"}],"source_content_type":"text/x-rst","patch_set":17,"id":"9a629dbe_2c046b48","line":38,"range":{"start_line":38,"start_character":3,"end_line":38,"end_character":21},"in_reply_to":"9a629dbe_c2f10503","updated":"2016-11-10 09:52:02.000000000","message":"We can create a new file related to usage if you think that ius correct, but it would involve renaming this file, isnt it?","commit_id":"90a0d19289fbae60acdf07d12adc42cfd286a7ed"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"59062c6612bd84360fe9ba67bdf50f7cfaed9a8a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   api_converters"},{"line_number":36,"context_line":"   api_validators"},{"line_number":37,"context_line":"   callbacks"},{"line_number":38,"context_line":"   ipv6_address_usage"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Module Reference"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9a629dbe_979e1b61","line":38,"range":{"start_line":38,"start_character":3,"end_line":38,"end_character":21},"updated":"2016-11-11 17:27:05.000000000","message":"I agree with the comment made earlier; I think the usage of this validator makes more sense in the api_converters.rst, not because of maintenance, but more-so because this now looks like a new top-level topic when in fact its just the usage of a specific API converter.","commit_id":"87d3cb8618eedf2c5dad3b4e6f846edfc7080fc4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6baaeebdb706c22931369ffca92acbfb5a9eb73a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   api_converters"},{"line_number":36,"context_line":"   api_validators"},{"line_number":37,"context_line":"   callbacks"},{"line_number":38,"context_line":"   ipv6_address_usage"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Module Reference"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9a629dbe_acdf490b","line":38,"range":{"start_line":38,"start_character":3,"end_line":38,"end_character":21},"in_reply_to":"9a629dbe_979e1b61","updated":"2016-11-12 00:56:47.000000000","message":"Done, and also added the try-except clause, because I felt it to be a popular opinion!","commit_id":"87d3cb8618eedf2c5dad3b4e6f846edfc7080fc4"}],"doc/source/devref/ipv6_address_usage.rst":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c35e5dd1bae84944a7d8d8686ddc8d5ea2aeb9ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ac06dbe_cf9430ea","updated":"2016-08-19 12:40:39.000000000","message":"So we already have a devref for converters [1]. Might this better live as a section within that ref [1]?\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/doc/source/devref/api_converters.rst","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c35e5dd1bae84944a7d8d8686ddc8d5ea2aeb9ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"      Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"      not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"      a copy of the License at"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ac06dbe_22935ba5","line":2,"updated":"2016-08-19 12:40:39.000000000","message":"This fails to build with: tox -e docs:\n\n\nWarning, treated as error:\n/home/boden/src/neutron-lib/doc/source/devref/ipv6_address_usage.rst:: WARNING: document isn\u0027t included in any toctree","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c35e5dd1bae84944a7d8d8686ddc8d5ea2aeb9ae","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"As there are several ways to mention an IPv6 address, it can lead to a lot of confusion"},{"line_number":28,"context_line":"or problems for user, engineers and operators alike. To reduce the impact of the"},{"line_number":29,"context_line":"mutli-faceted style of writing an IPv6 address, it is proposed that the IPv6 address"},{"line_number":30,"context_line":"in Neutron should be saved in the compressed format."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ac06dbe_6f7edcaf","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":20},"updated":"2016-08-19 12:40:39.000000000","message":"users","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c35e5dd1bae84944a7d8d8686ddc8d5ea2aeb9ae","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"As there are several ways to mention an IPv6 address, it can lead to a lot of confusion"},{"line_number":28,"context_line":"or problems for user, engineers and operators alike. To reduce the impact of the"},{"line_number":29,"context_line":"mutli-faceted style of writing an IPv6 address, it is proposed that the IPv6 address"},{"line_number":30,"context_line":"in Neutron should be saved in the compressed format."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"If user passes the IPv6 in the expanded format, it will be compressed at neutron and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ac06dbe_cf30b00a","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":13},"updated":"2016-08-19 12:40:39.000000000","message":"multifaceted","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eab91a74b5ea5a60cc1033e7dd3d666d044cde9f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"mutli-faceted style of writing an IPv6 address, it is proposed that the IPv6 address"},{"line_number":30,"context_line":"in Neutron should be saved in the compressed format."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"If user passes the IPv6 in the expanded format, it will be compressed at neutron and"},{"line_number":33,"context_line":"demonstrated to the user during the list/show operations in the same compressed format."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ac06dbe_c9c0a3e3","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":30},"updated":"2016-08-19 14:49:04.000000000","message":"If the user passes the IPv6 address in ...","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c35e5dd1bae84944a7d8d8686ddc8d5ea2aeb9ae","unresolved":false,"context_lines":[{"line_number":29,"context_line":"mutli-faceted style of writing an IPv6 address, it is proposed that the IPv6 address"},{"line_number":30,"context_line":"in Neutron should be saved in the compressed format."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"If user passes the IPv6 in the expanded format, it will be compressed at neutron and"},{"line_number":33,"context_line":"demonstrated to the user during the list/show operations in the same compressed format."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ac06dbe_2f098432","line":32,"range":{"start_line":32,"start_character":70,"end_line":32,"end_character":80},"updated":"2016-08-19 12:40:39.000000000","message":"Maybe we should remove this part since it\u0027s confusing now that we\u0027re in neutron-lib?","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c35e5dd1bae84944a7d8d8686ddc8d5ea2aeb9ae","unresolved":false,"context_lines":[{"line_number":30,"context_line":"in Neutron should be saved in the compressed format."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"If user passes the IPv6 in the expanded format, it will be compressed at neutron and"},{"line_number":33,"context_line":"demonstrated to the user during the list/show operations in the same compressed format."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ac06dbe_cf171053","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":12},"updated":"2016-08-19 12:40:39.000000000","message":"displayed?","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c35e5dd1bae84944a7d8d8686ddc8d5ea2aeb9ae","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Client command extension support"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"As there are several ways to mention an IPv6 address, it can lead to a lot of confusion"},{"line_number":41,"context_line":"or problems for user, engineers and operators alike. To reduce the impact of the"},{"line_number":42,"context_line":"mutli-faceted style of writing an IPv6 address, it is proposed that the IPv6 address"},{"line_number":43,"context_line":"in Neutron should be saved in the compressed format."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If user passes the IPv6 in the expanded format, it will be compressed at neutron and"},{"line_number":46,"context_line":"demonstrated to the user during the list/show operations in the same compressed format."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The full document is found at : http://tools.ietf.org/html/rfc5952"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ac06dbe_e2a943e1","line":48,"range":{"start_line":37,"start_character":0,"end_line":48,"end_character":66},"updated":"2016-08-19 12:40:39.000000000","message":"Isn\u0027t this a repeat of the above section?","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"799e3f9637f19a3977ec31545216ce0186b43736","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      Convention for heading levels in Neutron devref:"},{"line_number":16,"context_line":"      \u003d\u003d\u003d\u003d\u003d\u003d\u003d  Heading 0 (reserved for the title in a document)"},{"line_number":17,"context_line":"      -------  Heading 1"},{"line_number":18,"context_line":"      ~~~~~~~  Heading 2"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5da102_5a6066cf","line":15,"updated":"2016-11-02 13:16:17.000000000","message":"removed howto info from .rst file.","commit_id":"7f098cc8333063c896558d225336bb9d6b208bbf"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1ae58ce5f6d7c1dcca925198dba40ebc7775762c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ba5da102_d1de0d10","updated":"2016-11-02 17:39:39.000000000","message":"This fails to build with \u0027tox -e docs\u0027","commit_id":"3cfca248d74e070313e58275bd1e0d2d2bbca0dc"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"082e82e92b80f5c61968786e3fa9bf93ec496908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ba5da102_3346437b","updated":"2016-11-03 15:35:49.000000000","message":"This is still failing to build with \u0027tox -e docs\u0027... Here\u0027s the fix::\n\n\ndiff --git a/doc/source/devref/index.rst b/doc/source/devref/index.rst\nindex 948445d..1bd5764 100644\n--- a/doc/source/devref/index.rst\n+++ b/doc/source/devref/index.rst\n@@ -35,6 +35,7 @@ Neutron Lib Internals\n    api_converters\n    api_validators\n    callbacks\n+   ipv6_address_usage.rst","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b99230aabd72784b04e90672a47421a6fefc1ec9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ba5da102_5419cb20","in_reply_to":"ba5da102_3346437b","updated":"2016-11-04 02:33:55.000000000","message":"It passes mine, dont know why.\nBTW do I need to put \".rst\" extension in the end ?\nThe other rst files mentioned do not have the extension","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"7120ab8de3b314dc11b8f2369bcb5a844ecf19e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ba5da102_a44ae7aa","in_reply_to":"ba5da102_5419cb20","updated":"2016-11-04 13:49:43.000000000","message":"Appears to be building fine with PS14 changes.","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"903fa0e3b2c0509dcee6ad622da73d19f9daa06f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      Convention for heading levels in Neutron devref:"},{"line_number":16,"context_line":"      \u003d\u003d\u003d\u003d\u003d\u003d\u003d  Heading 0 (reserved for the title in a document)"},{"line_number":17,"context_line":"      -------  Heading 1"},{"line_number":18,"context_line":"      ~~~~~~~  Heading 2"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5da102_1df79a59","line":15,"updated":"2016-11-03 11:57:43.000000000","message":"comment from PS9?","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b99230aabd72784b04e90672a47421a6fefc1ec9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      Convention for heading levels in Neutron devref:"},{"line_number":16,"context_line":"      \u003d\u003d\u003d\u003d\u003d\u003d\u003d  Heading 0 (reserved for the title in a document)"},{"line_number":17,"context_line":"      -------  Heading 1"},{"line_number":18,"context_line":"      ~~~~~~~  Heading 2"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5da102_94060384","line":15,"in_reply_to":"ba5da102_1df79a59","updated":"2016-11-04 02:33:55.000000000","message":"I actually checked other rsts as well, and I considered keeping this, for now.","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d7fb9d3c20b1d2307e009a84d6770a3ec227ba93","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      Convention for heading levels in Neutron devref:"},{"line_number":16,"context_line":"      \u003d\u003d\u003d\u003d\u003d\u003d\u003d  Heading 0 (reserved for the title in a document)"},{"line_number":17,"context_line":"      -------  Heading 1"},{"line_number":18,"context_line":"      ~~~~~~~  Heading 2"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5da102_36847109","line":15,"in_reply_to":"ba5da102_1df79a59","updated":"2016-11-03 15:41:36.000000000","message":"It appears some relnotes in neutron actually do include this header (ex [1]). It doesn\u0027t appear to render in the actual HTMl. That said maybe it\u0027s fine to leave here?\n\n\n[1] https://raw.githubusercontent.com/openstack/neutron/master/doc/source/devref/callbacks.rst","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f53c680d577912b70cd0e613d037e2c09e34256b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      Convention for heading levels in Neutron devref:"},{"line_number":16,"context_line":"      \u003d\u003d\u003d\u003d\u003d\u003d\u003d  Heading 0 (reserved for the title in a document)"},{"line_number":17,"context_line":"      -------  Heading 1"},{"line_number":18,"context_line":"      ~~~~~~~  Heading 2"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5da102_ec878c5e","line":15,"in_reply_to":"ba5da102_36847109","updated":"2016-11-03 16:16:32.000000000","message":"Line 1 starts an RST comment block. The block ends right before the next un-indented line (23)","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4ead43298dc5cfb8dc8fec93953cee9f506e554c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      Convention for heading levels in Neutron devref:"},{"line_number":16,"context_line":"      \u003d\u003d\u003d\u003d\u003d\u003d\u003d  Heading 0 (reserved for the title in a document)"},{"line_number":17,"context_line":"      -------  Heading 1"},{"line_number":18,"context_line":"      ~~~~~~~  Heading 2"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5da102_932e0ba4","line":15,"updated":"2016-11-04 12:27:52.000000000","message":"Can delete L15-22","commit_id":"0b4c6c34b7b40fa8f7390a7b3b35b84927369240"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"63b8e7bfa875b66c217d65cb2ee1cbdf379c2004","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      (Avoid deeper levels because they do not render well.)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Client command extension support"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"There are several ways to display an IPv6 address, which can lead to a lot"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5da102_493e862a","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":32},"updated":"2016-11-04 13:47:51.000000000","message":"I must be missing something; why are we titling this section \u0027Client command extension support\u0027? Shouldn\u0027t the title be related to IPv6 canonical format?","commit_id":"0b4c6c34b7b40fa8f7390a7b3b35b84927369240"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"96789fafa35bfcfc31c15f0ffbb273a056401f60","unresolved":false,"context_lines":[{"line_number":19,"context_line":"There are several ways to display an IPv6 address, which can lead to a lot"},{"line_number":20,"context_line":"of confusion for users, engineers and operators alike. To reduce the impact"},{"line_number":21,"context_line":"of the multifaceted style of writing an IPv6 address, it is proposed that"},{"line_number":22,"context_line":"the IPv6 address in Neutron should be saved in the canonical format."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If a user passes an IPv6 address, it will be saved in the canonical format"},{"line_number":25,"context_line":"by Neutron and displayed to the user during list/show operations in the"}],"source_content_type":"text/x-rst","patch_set":17,"id":"9a629dbe_0275bd62","line":22,"range":{"start_line":22,"start_character":17,"end_line":22,"end_character":27},"updated":"2016-11-10 03:14:35.000000000","message":"Why to mention Neutron particularly? I think it\u0027s valid for OpenStack env...","commit_id":"90a0d19289fbae60acdf07d12adc42cfd286a7ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c2e43a3c1b2c1f9685176b3d39ae548f74593c2d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"There are several ways to display an IPv6 address, which can lead to a lot"},{"line_number":20,"context_line":"of confusion for users, engineers and operators alike. To reduce the impact"},{"line_number":21,"context_line":"of the multifaceted style of writing an IPv6 address, it is proposed that"},{"line_number":22,"context_line":"the IPv6 address in Neutron should be saved in the canonical format."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If a user passes an IPv6 address, it will be saved in the canonical format"},{"line_number":25,"context_line":"by Neutron and displayed to the user during list/show operations in the"}],"source_content_type":"text/x-rst","patch_set":17,"id":"9a629dbe_2cb2ab94","line":22,"range":{"start_line":22,"start_character":17,"end_line":22,"end_character":27},"in_reply_to":"9a629dbe_0275bd62","updated":"2016-11-10 09:52:02.000000000","message":"When this fix is proposed in the oslo.lib, I think then mentioning Openstack would be correct.\nElse as for now, this fix is targeted for neutron-lib., I thought of mentioning Neutron","commit_id":"90a0d19289fbae60acdf07d12adc42cfd286a7ed"}],"neutron_lib/api/converters.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6df5f8ed5c399b5f9411c8845acb0f4d24628494","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        return [data]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def convert_ipv6_compress_fmt(data):"},{"line_number":124,"context_line":"    try:"},{"line_number":125,"context_line":"        ip \u003d netaddr.IPAddress(data)"},{"line_number":126,"context_line":"        if ip.version \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_77907896","line":123,"updated":"2016-08-19 11:16:35.000000000","message":"IMO this function name does not read well. Either follow the naming convention: \u0027convert_ipv6_addr_to_compressed_format\u0027, or break convention and make it readable: \u0027compress_ipv6_addr\u0027.","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6df5f8ed5c399b5f9411c8845acb0f4d24628494","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            return six.u(str(ip.format(dialect\u003dnetaddr.ipv6_compact)))"},{"line_number":128,"context_line":"        else:"},{"line_number":129,"context_line":"            return data"},{"line_number":130,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":131,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_976254ac","line":130,"updated":"2016-08-19 11:16:35.000000000","message":"Which operation is expected to raise this exception, netaddr.IPAddress() or ip.format()? Please put only that operation inside the try clause.","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c35e5dd1bae84944a7d8d8686ddc8d5ea2aeb9ae","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            return six.u(str(ip.format(dialect\u003dnetaddr.ipv6_compact)))"},{"line_number":128,"context_line":"        else:"},{"line_number":129,"context_line":"            return data"},{"line_number":130,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":131,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_a2510b11","line":130,"in_reply_to":"1ac06dbe_976254ac","updated":"2016-08-19 12:40:39.000000000","message":"This except clause is not covered in the UTs.","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"02949dc1201c6dd02ee3418da779193bb38ba70b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"def convert_ip_to_canonical_format(data):"},{"line_number":169,"context_line":"    \"\"\"IP Address is validated and then converted to canonical format"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        If IP Address is None or IPv4, then no conversion is necessary,"},{"line_number":172,"context_line":"        else the IPv6 Address is compressed and returned, removing the"},{"line_number":173,"context_line":"        leading zeroes."},{"line_number":174,"context_line":"    \"\"\""},{"line_number":175,"context_line":"    if data:"},{"line_number":176,"context_line":"        ip \u003d netaddr.IPAddress(data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_cb23d256","line":173,"range":{"start_line":171,"start_character":0,"end_line":173,"end_character":23},"updated":"2016-11-02 11:00:50.000000000","message":"Unindent by 4 spaces. Use :param: and :return: notation.","commit_id":"67d6ffdf8d848df4cdb16896a12a7bc14dcb7396"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7871ae74c6a4a6636cb0cebf6c4f191b037fdbce","unresolved":false,"context_lines":[{"line_number":168,"context_line":"def convert_ip_to_canonical_format(value):"},{"line_number":169,"context_line":"    \"\"\"IP Address is validated and then converted to canonical format"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    : param value: The IP Address which needs to be checked"},{"line_number":172,"context_line":"    : returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":173,"context_line":"               or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is "},{"line_number":174,"context_line":"               IPv6 address."}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_e1ad159c","line":171,"range":{"start_line":171,"start_character":5,"end_line":171,"end_character":6},"updated":"2016-11-02 11:54:37.000000000","message":"There is no space after the colon in this notation.","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bbad3c4bcdc561bdd0b35546f86937c757b31f27","unresolved":false,"context_lines":[{"line_number":168,"context_line":"def convert_ip_to_canonical_format(value):"},{"line_number":169,"context_line":"    \"\"\"IP Address is validated and then converted to canonical format"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    : param value: The IP Address which needs to be checked"},{"line_number":172,"context_line":"    : returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":173,"context_line":"               or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is "},{"line_number":174,"context_line":"               IPv6 address."}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_a4532b16","line":171,"range":{"start_line":171,"start_character":5,"end_line":171,"end_character":6},"in_reply_to":"ba5da102_e1ad159c","updated":"2016-11-02 12:07:07.000000000","message":"Done","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7871ae74c6a4a6636cb0cebf6c4f191b037fdbce","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    \"\"\"IP Address is validated and then converted to canonical format"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    : param value: The IP Address which needs to be checked"},{"line_number":172,"context_line":"    : returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":173,"context_line":"               or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is "},{"line_number":174,"context_line":"               IPv6 address."},{"line_number":175,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_21946d41","line":172,"range":{"start_line":172,"start_character":5,"end_line":172,"end_character":6},"updated":"2016-11-02 11:54:37.000000000","message":"ditto","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bbad3c4bcdc561bdd0b35546f86937c757b31f27","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    \"\"\"IP Address is validated and then converted to canonical format"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    : param value: The IP Address which needs to be checked"},{"line_number":172,"context_line":"    : returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":173,"context_line":"               or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is "},{"line_number":174,"context_line":"               IPv6 address."},{"line_number":175,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_c4549fff","line":172,"range":{"start_line":172,"start_character":5,"end_line":172,"end_character":6},"in_reply_to":"ba5da102_21946d41","updated":"2016-11-02 12:07:07.000000000","message":"Done","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"799e3f9637f19a3977ec31545216ce0186b43736","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        return [data]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"def convert_ip_to_canonical_format(value):"},{"line_number":169,"context_line":"    \"\"\"IP Address is validated and then converted to canonical format"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    :param value: The IP Address which needs to be checked"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5da102_7ab44a34","line":168,"range":{"start_line":168,"start_character":35,"end_line":168,"end_character":40},"updated":"2016-11-02 13:16:17.000000000","message":"data?  How is this passing UT?","commit_id":"7f098cc8333063c896558d225336bb9d6b208bbf"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"799e3f9637f19a3977ec31545216ce0186b43736","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    if data:"},{"line_number":177,"context_line":"        ip \u003d netaddr.IPAddress(data)"},{"line_number":178,"context_line":"        if ip.version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":179,"context_line":"            return six.text_type(str(ip.format(dialect\u003dnetaddr.ipv6_compact)))"},{"line_number":180,"context_line":"    return data"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5da102_d55527c2","line":179,"range":{"start_line":179,"start_character":33,"end_line":179,"end_character":36},"updated":"2016-11-02 13:16:17.000000000","message":"Is str() needed, when using six.text_type()?","commit_id":"7f098cc8333063c896558d225336bb9d6b208bbf"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1ae58ce5f6d7c1dcca925198dba40ebc7775762c","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"def convert_ip_to_canonical_format(value):"},{"line_number":170,"context_line":"    \"\"\"IP Address is validated and then converted to canonical format"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    :param value: The IP Address which needs to be checked"},{"line_number":173,"context_line":"    :returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5da102_d1052d7a","line":170,"range":{"start_line":170,"start_character":63,"end_line":170,"end_character":69},"updated":"2016-11-02 17:39:39.000000000","message":"Nit: Period at end.","commit_id":"3cfca248d74e070313e58275bd1e0d2d2bbca0dc"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1ae58ce5f6d7c1dcca925198dba40ebc7775762c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"def convert_ip_to_canonical_format(value):"},{"line_number":170,"context_line":"    \"\"\"IP Address is validated and then converted to canonical format"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    :param value: The IP Address which needs to be checked"},{"line_number":173,"context_line":"    :returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":174,"context_line":"              or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is"},{"line_number":175,"context_line":"              IPv6 address."}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5da102_b1d6f9ee","line":172,"range":{"start_line":172,"start_character":51,"end_line":172,"end_character":58},"updated":"2016-11-02 17:39:39.000000000","message":"Nit: Period at end.","commit_id":"3cfca248d74e070313e58275bd1e0d2d2bbca0dc"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1ae58ce5f6d7c1dcca925198dba40ebc7775762c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"              IPv6 address."},{"line_number":176,"context_line":"    \"\"\""},{"line_number":177,"context_line":"    if value:"},{"line_number":178,"context_line":"        ip \u003d netaddr.IPAddress(value)"},{"line_number":179,"context_line":"        if ip.version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":180,"context_line":"            return six.text_type(str(ip.format(dialect\u003dnetaddr.ipv6_compact)))"},{"line_number":181,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5da102_d1136db6","line":178,"range":{"start_line":178,"start_character":21,"end_line":178,"end_character":30},"updated":"2016-11-02 17:39:39.000000000","message":"I\u0027m guessing this might raise with some bad values? I\u0027m wondering if it\u0027s worth noting in the docstring?","commit_id":"3cfca248d74e070313e58275bd1e0d2d2bbca0dc"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"082e82e92b80f5c61968786e3fa9bf93ec496908","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    :param value: The IP Address which needs to be checked."},{"line_number":173,"context_line":"    :returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":174,"context_line":"              or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is"},{"line_number":175,"context_line":"              IPv6 address."},{"line_number":176,"context_line":"    \"\"\""},{"line_number":177,"context_line":"    if value:"},{"line_number":178,"context_line":"        ip \u003d netaddr.IPAddress(value)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5da102_563d65c2","line":175,"updated":"2016-11-03 15:35:49.000000000","message":"From my comment on PS11, I guess you don\u0027t think we should mention the potential raised exceptions from the calls herein?","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b99230aabd72784b04e90672a47421a6fefc1ec9","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    :param value: The IP Address which needs to be checked."},{"line_number":173,"context_line":"    :returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":174,"context_line":"              or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is"},{"line_number":175,"context_line":"              IPv6 address."},{"line_number":176,"context_line":"    \"\"\""},{"line_number":177,"context_line":"    if value:"},{"line_number":178,"context_line":"        ip \u003d netaddr.IPAddress(value)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5da102_74a7afa6","line":175,"in_reply_to":"ba5da102_563d65c2","updated":"2016-11-04 02:33:55.000000000","message":"Hi boden,\nThe \"convert_XYZ\" function will be called for API Endpoints, after the validation is done.\nThis was what Henry suggested me in one of our discussions and I believe he is pretty correct.\nIdeally exception will be raised if \"value\" is not in IP Address format.\nBut if that is so, then it means that the IP Validation failed before it was converted, consequentially meaning the developer may have missed IP validation in an earlier step.","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"7120ab8de3b314dc11b8f2369bcb5a844ecf19e2","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    :param value: The IP Address which needs to be checked."},{"line_number":173,"context_line":"    :returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":174,"context_line":"              or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is"},{"line_number":175,"context_line":"              IPv6 address."},{"line_number":176,"context_line":"    \"\"\""},{"line_number":177,"context_line":"    if value:"},{"line_number":178,"context_line":"        ip \u003d netaddr.IPAddress(value)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5da102_84e403ad","line":175,"in_reply_to":"ba5da102_74a7afa6","updated":"2016-11-04 13:49:43.000000000","message":"While it may be called with certain assumptions today, in the future other consumers may use this function and hence I\u0027d opt to mention the exception... However this isn\u0027t a show stopper, but probably rather a nit.","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a152cd89ffeae2c672f122d48518081cd2099358","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    :param value: The IP Address which needs to be checked."},{"line_number":173,"context_line":"    :returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":174,"context_line":"              or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is"},{"line_number":175,"context_line":"              IPv6 address."},{"line_number":176,"context_line":"    \"\"\""},{"line_number":177,"context_line":"    if value:"},{"line_number":178,"context_line":"        ip \u003d netaddr.IPAddress(value)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5da102_c9f8bdc7","line":175,"in_reply_to":"ba5da102_84e403ad","updated":"2016-11-10 09:52:09.000000000","message":"Agreed.\nI can mention the information as a note here, if you think it would work ?","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"903fa0e3b2c0509dcee6ad622da73d19f9daa06f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    if value:"},{"line_number":178,"context_line":"        ip \u003d netaddr.IPAddress(value)"},{"line_number":179,"context_line":"        if ip.version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":180,"context_line":"            return six.text_type(str(ip.format(dialect\u003dnetaddr.ipv6_compact)))"},{"line_number":181,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5da102_bd05ce46","line":180,"range":{"start_line":180,"start_character":33,"end_line":180,"end_character":36},"updated":"2016-11-03 11:57:43.000000000","message":"comment from PS9?","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b99230aabd72784b04e90672a47421a6fefc1ec9","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    if value:"},{"line_number":178,"context_line":"        ip \u003d netaddr.IPAddress(value)"},{"line_number":179,"context_line":"        if ip.version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":180,"context_line":"            return six.text_type(str(ip.format(dialect\u003dnetaddr.ipv6_compact)))"},{"line_number":181,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5da102_f4849fd3","line":180,"range":{"start_line":180,"start_character":33,"end_line":180,"end_character":36},"in_reply_to":"ba5da102_bd05ce46","updated":"2016-11-04 02:33:55.000000000","message":"Confirmed from https://pythonhosted.org/netaddr/api.html#netaddr.IPAddress.format that ip.format would return STR only, so no need of typecasting here.\nThanks :)","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f7df514e58aaa6cc8d90a6ab544b0d04cf57efe6","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    :param value: The IP Address which needs to be checked."},{"line_number":173,"context_line":"    :returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":174,"context_line":"              or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is"},{"line_number":175,"context_line":"              IPv6 address."},{"line_number":176,"context_line":"    \"\"\""},{"line_number":177,"context_line":"    if value:"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_139aad63","line":174,"updated":"2016-11-08 21:39:58.000000000","message":"as I checked locally if value will be not IPAddress, this function will raise exception netaddr.core.AddrFormatError\n\nIMHO it should be documented or catched","commit_id":"7f00b781b0706e22fbef7eb2d006f02558f871fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"eb92a30d2b14cf376a1160653e4a8f357ff3e5c0","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    :param value: The IP Address which needs to be checked."},{"line_number":173,"context_line":"    :returns: None if \u0027value\u0027 is None, \u0027value\u0027 if \u0027value\u0027 is IPv4 address"},{"line_number":174,"context_line":"              or not an IPAddress and canonical IPv6 address if \u0027value\u0027 is"},{"line_number":175,"context_line":"              IPv6 address."},{"line_number":176,"context_line":"    \"\"\""},{"line_number":177,"context_line":"    if value:"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_49ef04b0","line":174,"in_reply_to":"9a629dbe_139aad63","updated":"2016-11-09 09:50:45.000000000","message":"I have added the documentation and corrected the values which are returned by the convertor.\nThe additional test case may not be required now.","commit_id":"7f00b781b0706e22fbef7eb2d006f02558f871fc"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"96789fafa35bfcfc31c15f0ffbb273a056401f60","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    # then the function can raise exceptions like netaddr.core.AddrFormatError"},{"line_number":180,"context_line":"    if value:"},{"line_number":181,"context_line":"        ip \u003d netaddr.IPAddress(value)"},{"line_number":182,"context_line":"        if ip.version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":183,"context_line":"            return six.text_type(ip.format(dialect\u003dnetaddr.ipv6_compact))"},{"line_number":184,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a629dbe_a2c17156","line":182,"range":{"start_line":182,"start_character":11,"end_line":182,"end_character":47},"updated":"2016-11-10 03:14:35.000000000","message":"Why we don\u0027t have to validate an invalid version other than IPv4 \u0026 IPv6? I think since it\u0027s a common lib it would be better to verify an invalid version as well.","commit_id":"90a0d19289fbae60acdf07d12adc42cfd286a7ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c2e43a3c1b2c1f9685176b3d39ae548f74593c2d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    # then the function can raise exceptions like netaddr.core.AddrFormatError"},{"line_number":180,"context_line":"    if value:"},{"line_number":181,"context_line":"        ip \u003d netaddr.IPAddress(value)"},{"line_number":182,"context_line":"        if ip.version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":183,"context_line":"            return six.text_type(ip.format(dialect\u003dnetaddr.ipv6_compact))"},{"line_number":184,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a629dbe_f754fcfe","line":182,"range":{"start_line":182,"start_character":11,"end_line":182,"end_character":47},"in_reply_to":"9a629dbe_585ec212","updated":"2016-11-10 09:52:02.000000000","message":"Hi Vikram , \nThe above NOTE section in Line 177 tells the assumption that we would have a validator before this converter is called.\nThat converter essentially should take care of validating if the IP is v4 or v6.\nIf not, then the validator will fail itself.\nOnce the validator works, this converter will only have IPv4/IPv6 address in the \"value\"","commit_id":"90a0d19289fbae60acdf07d12adc42cfd286a7ed"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8f5b87d3645b1235e0532db43b143cb60d94f3a1","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    # then the function can raise exceptions like netaddr.core.AddrFormatError"},{"line_number":180,"context_line":"    if value:"},{"line_number":181,"context_line":"        ip \u003d netaddr.IPAddress(value)"},{"line_number":182,"context_line":"        if ip.version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":183,"context_line":"            return six.text_type(ip.format(dialect\u003dnetaddr.ipv6_compact))"},{"line_number":184,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a629dbe_585ec212","line":182,"range":{"start_line":182,"start_character":11,"end_line":182,"end_character":47},"in_reply_to":"9a629dbe_a2c17156","updated":"2016-11-10 04:51:56.000000000","message":"I don\u0027t think netaddr will ever return anything but 4 or 6","commit_id":"90a0d19289fbae60acdf07d12adc42cfd286a7ed"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"76ce1ff00d02fe16ae6d0ef93158d2ffb09a328c","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            if ip.version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":182,"context_line":"                return six.text_type(ip.format(dialect\u003dnetaddr.ipv6_compact))"},{"line_number":183,"context_line":"        except netaddr.core.AddrFormatError:"},{"line_number":184,"context_line":"            return value"},{"line_number":185,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_3ce6c7b4","line":184,"range":{"start_line":184,"start_character":12,"end_line":184,"end_character":24},"updated":"2016-11-15 17:28:15.000000000","message":"It seems odd that we return the value even if its not an IP address. I\u0027d probably opt to return None or just let the AddrFormatError fly here, but it appears others think this is the most useful approach so I guess I\u0027m OK with it.","commit_id":"741ff17e163e418b9be957ca89bc27984cfe784b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"aff3bc407500cd7996704c7394fe90e2f0786da3","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    \"\"\"IP Address is validated and then converted to canonical format."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    :param value: The IP Address which needs to be checked."},{"line_number":173,"context_line":"    :returns: - None if \u0027value\u0027 is None,"},{"line_number":174,"context_line":"              - \u0027value\u0027 if \u0027value\u0027 is IPv4 address,"},{"line_number":175,"context_line":"              - \u0027value\u0027 if \u0027value\u0027 is not an IP Address"},{"line_number":176,"context_line":"              - canonical IPv6 address if \u0027value\u0027 is IPv6 address."},{"line_number":177,"context_line":"    \"\"\""},{"line_number":178,"context_line":"    if value:"},{"line_number":179,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a74a57a_8ed16bd0","line":176,"range":{"start_line":173,"start_character":0,"end_line":176,"end_character":66},"updated":"2016-11-23 16:23:00.000000000","message":"Haven\u0027t seen this list style docstring used, but I guess its ok.","commit_id":"839c668c28d7a57bd46603523c9d6a8193cb9a1d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"04a932484ca504a4064575a502a2ce236f76cd6f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            if ip.version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":182,"context_line":"                return six.text_type(ip.format(dialect\u003dnetaddr.ipv6_compact))"},{"line_number":183,"context_line":"        except netaddr.core.AddrFormatError:"},{"line_number":184,"context_line":"            return value"},{"line_number":185,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_2eec2029","line":184,"range":{"start_line":184,"start_character":12,"end_line":184,"end_character":24},"updated":"2016-11-29 02:26:54.000000000","message":"Can be \u0027pass\u0027 that way we just fall through to L185","commit_id":"27fbce554b4c2312cdde08c7fb8ad2619c16b019"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"028dcef63efa95133e30735d5a857160a06bf769","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            if ip.version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":182,"context_line":"                return six.text_type(ip.format(dialect\u003dnetaddr.ipv6_compact))"},{"line_number":183,"context_line":"        except netaddr.core.AddrFormatError:"},{"line_number":184,"context_line":"            return value"},{"line_number":185,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_53949289","line":184,"range":{"start_line":184,"start_character":12,"end_line":184,"end_character":24},"in_reply_to":"5a74a57a_2eec2029","updated":"2016-11-29 12:30:24.000000000","message":"Done","commit_id":"27fbce554b4c2312cdde08c7fb8ad2619c16b019"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4d909f3ae8ff0575812e4ad4f135bf9261b4369f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"              - \u0027value\u0027 if \u0027value\u0027 is not an IP Address"},{"line_number":176,"context_line":"              - canonical IPv6 address if \u0027value\u0027 is IPv6 address."},{"line_number":177,"context_line":"    \"\"\""},{"line_number":178,"context_line":"    if value:"},{"line_number":179,"context_line":"        try:"},{"line_number":180,"context_line":"            ip \u003d netaddr.IPAddress(value)"},{"line_number":181,"context_line":"            if ip.version \u003d\u003d constants.IP_VERSION_6:"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a74a57a_6bf18e94","line":178,"updated":"2016-11-29 14:10:50.000000000","message":"If \u0027value\u0027 is None, or \u0027\u0027, or \u0027junk\u0027 then netaddr will throw an AddrFormatError, so there is no need to check if it\u0027s set since we\u0027re catching this.\n\nI\u0027ll keep noticing things until this is merged :)","commit_id":"1ad2aad0963e64c2342c38a541dd7591922204ac"}],"neutron_lib/tests/unit/api/test_conversions.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eab91a74b5ea5a60cc1033e7dd3d666d044cde9f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"class TestConvertIPv6Compressed(base.BaseTestCase):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_compressed_address(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ipv6_compress_fmt(u\u0027fe8::1\u0027)"},{"line_number":176,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_49f5d381","line":175,"updated":"2016-08-19 14:49:04.000000000","message":"nit: fe80 ?","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eab91a74b5ea5a60cc1033e7dd3d666d044cde9f","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ipv6_compress_fmt("},{"line_number":180,"context_line":"            u\"fe8:0:0:0:0:0:0:1\")"},{"line_number":181,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_convert_ipv4_address(self):"},{"line_number":184,"context_line":"        result \u003d converters.convert_ipv6_compress_fmt("}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_c97d43e9","line":181,"updated":"2016-08-19 14:49:04.000000000","message":"Since these tests are quick, should probably add an address of global scope as well, like 2001:db8:0:0:0:0:0:1","commit_id":"a87ae4da204ccb8500f36c0cb5b1684e18489380"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3ece8bf882afd82c3032d0b6e6d2858f8c7ec3f9","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            self.assertEqual([item], converters.convert_to_list(item))"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class TestConvertIPv6Compressed(base.BaseTestCase):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_compressed_address(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00270fe8::1\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_4ebc3006","line":172,"updated":"2016-11-02 11:20:18.000000000","message":"I\u0027d rather use \"Canonical\" instead of \"Compressed\" here and in the test names, for better matching the name of the function being tested.\n\nAs you have special handling for the data\u003dNone case, that should also get a dedicated test.","commit_id":"67d6ffdf8d848df4cdb16896a12a7bc14dcb7396"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d58f65a7b1496c461a25b6139d652b8d0c4c32b2","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            self.assertEqual([item], converters.convert_to_list(item))"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class TestConvertIPv6Compressed(base.BaseTestCase):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_compressed_address(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00270fe8::1\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_ee8504cf","line":172,"in_reply_to":"ba5da102_4ebc3006","updated":"2016-11-02 11:32:00.000000000","message":"Done","commit_id":"67d6ffdf8d848df4cdb16896a12a7bc14dcb7396"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3ece8bf882afd82c3032d0b6e6d2858f8c7ec3f9","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":180,"context_line":"            u\"fe8:0:0:0:0:0:0:1\")"},{"line_number":181,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_convert_ipv4_address(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_6e6734b7","line":180,"updated":"2016-11-02 11:20:18.000000000","message":"Part of the canonicalization is lowercasing the input, so some test case (either this one or an additional one) should also include upper case input.","commit_id":"67d6ffdf8d848df4cdb16896a12a7bc14dcb7396"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d58f65a7b1496c461a25b6139d652b8d0c4c32b2","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":180,"context_line":"            u\"fe8:0:0:0:0:0:0:1\")"},{"line_number":181,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_convert_ipv4_address(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_8e7ac8ef","line":180,"in_reply_to":"ba5da102_6e6734b7","updated":"2016-11-02 11:32:00.000000000","message":"Done","commit_id":"67d6ffdf8d848df4cdb16896a12a7bc14dcb7396"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4b0c11daa4816ab68b46d10e2c842c2dca727c42","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":185,"context_line":"            u\"192.168.1.1\")"},{"line_number":186,"context_line":"        self.assertEqual(u\u0027192.168.1.1\u0027, result)"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_193e03da","line":187,"updated":"2016-11-02 10:44:17.000000000","message":"please remove this line","commit_id":"67d6ffdf8d848df4cdb16896a12a7bc14dcb7396"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d58f65a7b1496c461a25b6139d652b8d0c4c32b2","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":185,"context_line":"            u\"192.168.1.1\")"},{"line_number":186,"context_line":"        self.assertEqual(u\u0027192.168.1.1\u0027, result)"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_0e6f982b","line":187,"in_reply_to":"ba5da102_193e03da","updated":"2016-11-02 11:32:00.000000000","message":"Done","commit_id":"67d6ffdf8d848df4cdb16896a12a7bc14dcb7396"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"082e82e92b80f5c61968786e3fa9bf93ec496908","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    def test_convert_None_address(self):"},{"line_number":189,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":190,"context_line":"            None)"},{"line_number":191,"context_line":"        self.assertEqual(None, result)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5da102_56448548","line":191,"range":{"start_line":191,"start_character":13,"end_line":191,"end_character":24},"updated":"2016-11-03 15:35:49.000000000","message":"better to use assertIsNone(result)","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b99230aabd72784b04e90672a47421a6fefc1ec9","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    def test_convert_None_address(self):"},{"line_number":189,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":190,"context_line":"            None)"},{"line_number":191,"context_line":"        self.assertEqual(None, result)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5da102_54762b06","line":191,"range":{"start_line":191,"start_character":13,"end_line":191,"end_character":24},"in_reply_to":"ba5da102_56448548","updated":"2016-11-04 02:33:55.000000000","message":"Yeah, missed it . Sorry","commit_id":"d64ba25e7150c08640960e260e1b4df4821a16fe"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cd08441db0d3fd4f1adfbfbdccff538d15cedcf9","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_compressed_address(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00270fe8::1\u0027)"},{"line_number":176,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_9572537b","line":176,"updated":"2016-11-08 03:27:32.000000000","message":"I\u0027m not a fan of this address that looks like a link-local, can you use the examples cited in the RFC?\n\n2001:0db8::0001 -\u003e 2001:db8::1\n2001:db8:0:0:0:0:2:1 -\u003e 2001:db8::2:1\n2001:db8:0:0:1:0:0:1 -\u003e 2001:db8::1:0:0:1\n2001:0:0:1:0:0:0:1 -\u003e 2001:0:0:1::1\n2001:db8:0:1:1:1:1:1 -\u003e 2001:db8:0:1:1:1:1:1 (same)","commit_id":"3c69a673c5fe6f0df10b097f46361d47173dad4f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"be9159bcef2e2686882f78cfe36c54d15e11559e","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_compressed_address(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00270fe8::1\u0027)"},{"line_number":176,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_4b0adcd3","line":176,"in_reply_to":"9a629dbe_9572537b","updated":"2016-11-08 05:07:03.000000000","message":"Done","commit_id":"3c69a673c5fe6f0df10b097f46361d47173dad4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cd08441db0d3fd4f1adfbfbdccff538d15cedcf9","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":180,"context_line":"            u\"Fe8:0:0:0:0:0:0:1\")"},{"line_number":181,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_convert_ipv4_address(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_d54beb57","line":180,"updated":"2016-11-08 03:27:32.000000000","message":"I would recommend making this an actual link-local address, Fe80:0...","commit_id":"3c69a673c5fe6f0df10b097f46361d47173dad4f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"be9159bcef2e2686882f78cfe36c54d15e11559e","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":180,"context_line":"            u\"Fe8:0:0:0:0:0:0:1\")"},{"line_number":181,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_convert_ipv4_address(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_2b05a8c1","line":180,"in_reply_to":"9a629dbe_d54beb57","updated":"2016-11-08 05:07:03.000000000","message":"I think this would work","commit_id":"3c69a673c5fe6f0df10b097f46361d47173dad4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cd08441db0d3fd4f1adfbfbdccff538d15cedcf9","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_convert_None_address(self):"},{"line_number":189,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":190,"context_line":"            None)"},{"line_number":191,"context_line":"        self.assertIsNone(result)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_d56ccb9e","line":190,"updated":"2016-11-08 03:27:32.000000000","message":"I think the None can fit on the previous line.","commit_id":"3c69a673c5fe6f0df10b097f46361d47173dad4f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"be9159bcef2e2686882f78cfe36c54d15e11559e","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_convert_None_address(self):"},{"line_number":189,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":190,"context_line":"            None)"},{"line_number":191,"context_line":"        self.assertIsNone(result)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_0b01c4ae","line":190,"in_reply_to":"9a629dbe_d56ccb9e","updated":"2016-11-08 05:07:03.000000000","message":"Done","commit_id":"3c69a673c5fe6f0df10b097f46361d47173dad4f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f7df514e58aaa6cc8d90a6ab544b0d04cf57efe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"9a629dbe_73f4c986","line":202,"updated":"2016-11-08 21:39:58.000000000","message":"As is described in https://review.openstack.org/#/c/357670/16/neutron_lib/api/converters.py in L174 if value is not IPAddress then it should return \"value\" so such UT should be also added IMHO:\n\n    def test_convert_no_address(self):\n        result \u003d converters.convert_ip_to_canonical_format(\"abcd\")\n        self.assertIsNone(result)\n\nAnd unfortunatelly this test would fails currently because it will raise exception as I wrote in my previous comment.","commit_id":"7f00b781b0706e22fbef7eb2d006f02558f871fc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8f5b87d3645b1235e0532db43b143cb60d94f3a1","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":191,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":192,"context_line":"            u\"Fe8:0:0:0:0:0:0:1\")"},{"line_number":193,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_convert_ipv4_address(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a629dbe_18afeae2","line":192,"updated":"2016-11-10 04:51:56.000000000","message":"nit: Fe80","commit_id":"90a0d19289fbae60acdf07d12adc42cfd286a7ed"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"96789fafa35bfcfc31c15f0ffbb273a056401f60","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            u\"Fe8:0:0:0:0:0:0:1\")"},{"line_number":193,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_convert_ipv4_address(self):"},{"line_number":196,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\"192.168.1.1\")"},{"line_number":197,"context_line":"        self.assertEqual(u\u0027192.168.1.1\u0027, result)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9a629dbe_42c7b563","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":33},"updated":"2016-11-10 03:14:35.000000000","message":"How about test_convert_invalid_ipvX_address?","commit_id":"90a0d19289fbae60acdf07d12adc42cfd286a7ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c2e43a3c1b2c1f9685176b3d39ae548f74593c2d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            u\"Fe8:0:0:0:0:0:0:1\")"},{"line_number":193,"context_line":"        self.assertEqual(u\u0027fe8::1\u0027, result)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_convert_ipv4_address(self):"},{"line_number":196,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\"192.168.1.1\")"},{"line_number":197,"context_line":"        self.assertEqual(u\u0027192.168.1.1\u0027, result)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9a629dbe_177170a8","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":33},"in_reply_to":"9a629dbe_42c7b563","updated":"2016-11-10 09:52:02.000000000","message":"Invalid address is not in the scope of the test cases, because of the assumption mentioned earlier","commit_id":"90a0d19289fbae60acdf07d12adc42cfd286a7ed"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"25b49878c0f7fd0585c7808c80bb26203c22e16b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.assertEqual(u\u00272001:0:0:1::1\u0027, result)"},{"line_number":186,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":187,"context_line":"            u\u00272001:db8:0:1:1:1:1:1\u0027)"},{"line_number":188,"context_line":"        self.assertEqual(u\u00272001:db8:0:1:1:1:1:1\u0027, result)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":191,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_14e8f70f","line":188,"updated":"2016-11-15 21:52:04.000000000","message":"This last one fails on OSX/BSD, as it treats addresses a little differently - it actually removes the zero and uses ::, against the MUST NOT in Section 4.2.2 :(\n\nIt can be skipped, see is_bsd() in the neutron tree, commit 2f6279e3e9a8561e74026ab3f3e639903014081b","commit_id":"741ff17e163e418b9be957ca89bc27984cfe784b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8c10f458c7e9ea9256ce4fdc59de9b2adc66b891","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.assertEqual(u\u00272001:0:0:1::1\u0027, result)"},{"line_number":186,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":187,"context_line":"            u\u00272001:db8:0:1:1:1:1:1\u0027)"},{"line_number":188,"context_line":"        self.assertEqual(u\u00272001:db8:0:1:1:1:1:1\u0027, result)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":191,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_ed12c9b3","line":188,"in_reply_to":"7a77a97e_14e8f70f","updated":"2016-11-16 02:14:39.000000000","message":"Hi Brian , \nThanks for the input, didnt know this.\nI have added the check for test_convert_ipv6_extended_addr_to_compressed() , please let me know if this is ok ?","commit_id":"741ff17e163e418b9be957ca89bc27984cfe784b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2d37817e31325d3dbb23476c66acbf98283896ba","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.assertEqual(u\u00272001:0:0:1::1\u0027, result)"},{"line_number":186,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":187,"context_line":"            u\u00272001:db8:0:1:1:1:1:1\u0027)"},{"line_number":188,"context_line":"        self.assertEqual(u\u00272001:db8:0:1:1:1:1:1\u0027, result)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @testtools.skipIf(tools.is_bsd(), \u0027bug/1484837\u0027)"},{"line_number":191,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_f3d38a36","line":188,"updated":"2016-11-16 03:05:24.000000000","message":"It was actually this one above on L188 that was failing.","commit_id":"2f99805028bad2a866ccc2978f270ce942188d24"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2d37817e31325d3dbb23476c66acbf98283896ba","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            u\u00272001:db8:0:1:1:1:1:1\u0027)"},{"line_number":188,"context_line":"        self.assertEqual(u\u00272001:db8:0:1:1:1:1:1\u0027, result)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @testtools.skipIf(tools.is_bsd(), \u0027bug/1484837\u0027)"},{"line_number":191,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":192,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":193,"context_line":"            u\"Fe80:0:0:0:0:0:0:1\")"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_93ca566d","line":190,"updated":"2016-11-16 03:05:24.000000000","message":"I didn\u0027t see is_bsd in _tools.py, I believe it\u0027s over in the neutron repo, needs to get copied here.","commit_id":"2f99805028bad2a866ccc2978f270ce942188d24"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"1b0266c257ac9ba1549222f04ca77133fa674277","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class TestConvertIPv6CanonicalFormat(base.BaseTestCase):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_compressed_address(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00272001:0db8::0001\u0027)"},{"line_number":176,"context_line":"        self.assertEqual(u\u00272001:db8::1\u0027, result)"},{"line_number":177,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("}],"source_content_type":"text/x-python","patch_set":29,"id":"5a74a57a_17332aac","line":174,"range":{"start_line":174,"start_character":8,"end_line":174,"end_character":44},"updated":"2016-11-28 09:50:07.000000000","message":"nit, should this be broken into multiple small tests?\nIf one of these were to fail it wouldn\u0027t be clear which caused the test to fail.\n\nIf these all used the same input I\u0027d say this is fine, but this is multiple values and their outputs being tested.","commit_id":"2882e028dccd941d9c43b6fc4f00ef80a464acd0"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"cdb35907fb8de0b5689f4727469cafae4df2007d","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class TestConvertIPv6CanonicalFormat(base.BaseTestCase):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_compressed_address(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00272001:0db8::0001\u0027)"},{"line_number":176,"context_line":"        self.assertEqual(u\u00272001:db8::1\u0027, result)"},{"line_number":177,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("}],"source_content_type":"text/x-python","patch_set":29,"id":"5a74a57a_e0a16747","line":174,"range":{"start_line":174,"start_character":8,"end_line":174,"end_character":44},"in_reply_to":"5a74a57a_17332aac","updated":"2016-11-28 18:51:24.000000000","message":"I\u0027m not sure I\u0027d be confused by a failure, that doesn\u0027t give me much heartburn. It could be traced back to a specific line number so you can see which assertion failed. At first glance though it\u0027s not clear what the point of these assertions is. This could still be broken out for readability and maintenance purposes.","commit_id":"2882e028dccd941d9c43b6fc4f00ef80a464acd0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c6584294c3de240af0e26cd78eb87e7a7c5ce003","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class TestConvertIPv6CanonicalFormat(base.BaseTestCase):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_compressed_address(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00272001:0db8::0001\u0027)"},{"line_number":176,"context_line":"        self.assertEqual(u\u00272001:db8::1\u0027, result)"},{"line_number":177,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("}],"source_content_type":"text/x-python","patch_set":29,"id":"5a74a57a_faa90a25","line":174,"range":{"start_line":174,"start_character":8,"end_line":174,"end_character":44},"in_reply_to":"5a74a57a_e0a16747","updated":"2016-11-29 00:13:14.000000000","message":"For the lack of innovative names at 5am in the morning, I have came up with the names in the next PS.\nPlease let me know if they are fine ?","commit_id":"2882e028dccd941d9c43b6fc4f00ef80a464acd0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"22ab0205de09796fc2308c3fbeeb25b069a38d9d","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class TestConvertIPv6CanonicalFormat(base.BaseTestCase):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_address_prepended_zeroes(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00272001:0db8::0001\u0027)"},{"line_number":176,"context_line":"        self.assertEqual(u\u00272001:db8::1\u0027, result)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_address_padded_zeroes(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":180,"context_line":"            u\u00272001:db8:0:0:0:0:2:1\u0027)"},{"line_number":181,"context_line":"        self.assertEqual(u\u00272001:db8::2:1\u0027, result)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_convert_ipv6_address_extended_add_with_zeroes(self):"},{"line_number":184,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":185,"context_line":"            u\u00272001:db8:0:0:1:0:0:1\u0027)"},{"line_number":186,"context_line":"        self.assertEqual(u\u00272001:db8::1:0:0:1\u0027, result)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_convert_ipv6_address_extended_add_with_padded_zeroes(self):"},{"line_number":189,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":190,"context_line":"            u\u00272001:0:0:1:0:0:0:1\u0027)"},{"line_number":191,"context_line":"        self.assertEqual(u\u00272001:0:0:1::1\u0027, result)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @testtools.skipIf(tools.is_bsd(), \u0027bug/1484837\u0027)"},{"line_number":194,"context_line":"    def test_convert_ipv6_compressed_address_OSX_skip(self):"},{"line_number":195,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":196,"context_line":"            u\u00272001:db8:0:1:1:1:1:1\u0027)"},{"line_number":197,"context_line":"        self.assertEqual(u\u00272001:db8:0:1:1:1:1:1\u0027, result)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":200,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":201,"context_line":"            u\"Fe80:0:0:0:0:0:0:1\")"},{"line_number":202,"context_line":"        self.assertEqual(u\u0027fe80::1\u0027, result)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_convert_ipv4_address(self):"},{"line_number":205,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\"192.168.1.1\")"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_0ebf64aa","line":202,"range":{"start_line":173,"start_character":0,"end_line":202,"end_character":44},"updated":"2016-11-29 02:41:42.000000000","message":"These are all testing netaddr.IPAddress().format(ipv6_compact) and that belongs in netaddr unit tests, not neutron-lib IMO.","commit_id":"27fbce554b4c2312cdde08c7fb8ad2619c16b019"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"028dcef63efa95133e30735d5a857160a06bf769","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class TestConvertIPv6CanonicalFormat(base.BaseTestCase):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_address_prepended_zeroes(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00272001:0db8::0001\u0027)"},{"line_number":176,"context_line":"        self.assertEqual(u\u00272001:db8::1\u0027, result)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_address_padded_zeroes(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":180,"context_line":"            u\u00272001:db8:0:0:0:0:2:1\u0027)"},{"line_number":181,"context_line":"        self.assertEqual(u\u00272001:db8::2:1\u0027, result)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_convert_ipv6_address_extended_add_with_zeroes(self):"},{"line_number":184,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":185,"context_line":"            u\u00272001:db8:0:0:1:0:0:1\u0027)"},{"line_number":186,"context_line":"        self.assertEqual(u\u00272001:db8::1:0:0:1\u0027, result)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_convert_ipv6_address_extended_add_with_padded_zeroes(self):"},{"line_number":189,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":190,"context_line":"            u\u00272001:0:0:1:0:0:0:1\u0027)"},{"line_number":191,"context_line":"        self.assertEqual(u\u00272001:0:0:1::1\u0027, result)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @testtools.skipIf(tools.is_bsd(), \u0027bug/1484837\u0027)"},{"line_number":194,"context_line":"    def test_convert_ipv6_compressed_address_OSX_skip(self):"},{"line_number":195,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":196,"context_line":"            u\u00272001:db8:0:1:1:1:1:1\u0027)"},{"line_number":197,"context_line":"        self.assertEqual(u\u00272001:db8:0:1:1:1:1:1\u0027, result)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":200,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":201,"context_line":"            u\"Fe80:0:0:0:0:0:0:1\")"},{"line_number":202,"context_line":"        self.assertEqual(u\u0027fe80::1\u0027, result)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_convert_ipv4_address(self):"},{"line_number":205,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\"192.168.1.1\")"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_73b8ae2a","line":202,"range":{"start_line":173,"start_character":0,"end_line":202,"end_character":44},"in_reply_to":"5a74a57a_0ebf64aa","updated":"2016-11-29 12:30:24.000000000","message":"Then should I keep these tests or move them somewhere else?","commit_id":"27fbce554b4c2312cdde08c7fb8ad2619c16b019"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"3194f43556865b778d9b20bb501cafc3580eab08","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class TestConvertIPv6CanonicalFormat(base.BaseTestCase):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_address_prepended_zeroes(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00272001:0db8::0001\u0027)"},{"line_number":176,"context_line":"        self.assertEqual(u\u00272001:db8::1\u0027, result)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_address_padded_zeroes(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":180,"context_line":"            u\u00272001:db8:0:0:0:0:2:1\u0027)"},{"line_number":181,"context_line":"        self.assertEqual(u\u00272001:db8::2:1\u0027, result)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_convert_ipv6_address_extended_add_with_zeroes(self):"},{"line_number":184,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":185,"context_line":"            u\u00272001:db8:0:0:1:0:0:1\u0027)"},{"line_number":186,"context_line":"        self.assertEqual(u\u00272001:db8::1:0:0:1\u0027, result)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_convert_ipv6_address_extended_add_with_padded_zeroes(self):"},{"line_number":189,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":190,"context_line":"            u\u00272001:0:0:1:0:0:0:1\u0027)"},{"line_number":191,"context_line":"        self.assertEqual(u\u00272001:0:0:1::1\u0027, result)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @testtools.skipIf(tools.is_bsd(), \u0027bug/1484837\u0027)"},{"line_number":194,"context_line":"    def test_convert_ipv6_compressed_address_OSX_skip(self):"},{"line_number":195,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":196,"context_line":"            u\u00272001:db8:0:1:1:1:1:1\u0027)"},{"line_number":197,"context_line":"        self.assertEqual(u\u00272001:db8:0:1:1:1:1:1\u0027, result)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":200,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":201,"context_line":"            u\"Fe80:0:0:0:0:0:0:1\")"},{"line_number":202,"context_line":"        self.assertEqual(u\u0027fe80::1\u0027, result)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_convert_ipv4_address(self):"},{"line_number":205,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\"192.168.1.1\")"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_e1569fcc","line":202,"range":{"start_line":173,"start_character":0,"end_line":202,"end_character":44},"in_reply_to":"5a74a57a_73b8ae2a","updated":"2016-11-29 14:33:44.000000000","message":"We have to assume netaddr has unit tests. I would keep just the first test here.","commit_id":"27fbce554b4c2312cdde08c7fb8ad2619c16b019"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8a8900797e9a72a289d896f099f69ae5007f5b1b","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class TestConvertIPv6CanonicalFormat(base.BaseTestCase):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_convert_ipv6_address_prepended_zeroes(self):"},{"line_number":175,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\u00272001:0db8::0001\u0027)"},{"line_number":176,"context_line":"        self.assertEqual(u\u00272001:db8::1\u0027, result)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_convert_ipv6_address_padded_zeroes(self):"},{"line_number":179,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":180,"context_line":"            u\u00272001:db8:0:0:0:0:2:1\u0027)"},{"line_number":181,"context_line":"        self.assertEqual(u\u00272001:db8::2:1\u0027, result)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_convert_ipv6_address_extended_add_with_zeroes(self):"},{"line_number":184,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":185,"context_line":"            u\u00272001:db8:0:0:1:0:0:1\u0027)"},{"line_number":186,"context_line":"        self.assertEqual(u\u00272001:db8::1:0:0:1\u0027, result)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_convert_ipv6_address_extended_add_with_padded_zeroes(self):"},{"line_number":189,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":190,"context_line":"            u\u00272001:0:0:1:0:0:0:1\u0027)"},{"line_number":191,"context_line":"        self.assertEqual(u\u00272001:0:0:1::1\u0027, result)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @testtools.skipIf(tools.is_bsd(), \u0027bug/1484837\u0027)"},{"line_number":194,"context_line":"    def test_convert_ipv6_compressed_address_OSX_skip(self):"},{"line_number":195,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":196,"context_line":"            u\u00272001:db8:0:1:1:1:1:1\u0027)"},{"line_number":197,"context_line":"        self.assertEqual(u\u00272001:db8:0:1:1:1:1:1\u0027, result)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_convert_ipv6_extended_addr_to_compressed(self):"},{"line_number":200,"context_line":"        result \u003d converters.convert_ip_to_canonical_format("},{"line_number":201,"context_line":"            u\"Fe80:0:0:0:0:0:0:1\")"},{"line_number":202,"context_line":"        self.assertEqual(u\u0027fe80::1\u0027, result)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_convert_ipv4_address(self):"},{"line_number":205,"context_line":"        result \u003d converters.convert_ip_to_canonical_format(u\"192.168.1.1\")"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_be9918d3","line":202,"range":{"start_line":173,"start_character":0,"end_line":202,"end_character":44},"in_reply_to":"5a74a57a_e1569fcc","updated":"2016-11-29 18:03:04.000000000","message":"+1","commit_id":"27fbce554b4c2312cdde08c7fb8ad2619c16b019"}],"releasenotes/notes/ipv6_address_usage-ef3d65ad5aa5798b.yaml":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7871ae74c6a4a6636cb0cebf6c4f191b037fdbce","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  -|"},{"line_number":4,"context_line":"   IPv6 addresses in Neutron will now be stored and displayed in"},{"line_number":5,"context_line":"   canonical address format. Any address provided by the user in"},{"line_number":6,"context_line":"   an expanded format will be converted to canonical format first."},{"line_number":7,"context_line":"   During Upgrade, no changes will be done to the addresses already"},{"line_number":8,"context_line":"   saved in the database, only newly entered addresses would be"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5da102_61a82578","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":20},"updated":"2016-11-02 11:54:37.000000000","message":"Remove \u0027address\u0027 here.","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bbad3c4bcdc561bdd0b35546f86937c757b31f27","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  -|"},{"line_number":4,"context_line":"   IPv6 addresses in Neutron will now be stored and displayed in"},{"line_number":5,"context_line":"   canonical address format. Any address provided by the user in"},{"line_number":6,"context_line":"   an expanded format will be converted to canonical format first."},{"line_number":7,"context_line":"   During Upgrade, no changes will be done to the addresses already"},{"line_number":8,"context_line":"   saved in the database, only newly entered addresses would be"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5da102_0443f742","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":20},"in_reply_to":"ba5da102_61a82578","updated":"2016-11-02 12:07:07.000000000","message":"Done","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7871ae74c6a4a6636cb0cebf6c4f191b037fdbce","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  -|"},{"line_number":4,"context_line":"   IPv6 addresses in Neutron will now be stored and displayed in"},{"line_number":5,"context_line":"   canonical address format. Any address provided by the user in"},{"line_number":6,"context_line":"   an expanded format will be converted to canonical format first."},{"line_number":7,"context_line":"   During Upgrade, no changes will be done to the addresses already"},{"line_number":8,"context_line":"   saved in the database, only newly entered addresses would be"},{"line_number":9,"context_line":"   impacted."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5da102_01ccc968","line":6,"range":{"start_line":5,"start_character":62,"end_line":6,"end_character":21},"updated":"2016-11-02 11:54:37.000000000","message":"Remove \u0027in an expanded format\u0027","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bbad3c4bcdc561bdd0b35546f86937c757b31f27","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  -|"},{"line_number":4,"context_line":"   IPv6 addresses in Neutron will now be stored and displayed in"},{"line_number":5,"context_line":"   canonical address format. Any address provided by the user in"},{"line_number":6,"context_line":"   an expanded format will be converted to canonical format first."},{"line_number":7,"context_line":"   During Upgrade, no changes will be done to the addresses already"},{"line_number":8,"context_line":"   saved in the database, only newly entered addresses would be"},{"line_number":9,"context_line":"   impacted."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5da102_2440fb33","line":6,"range":{"start_line":5,"start_character":62,"end_line":6,"end_character":21},"in_reply_to":"ba5da102_01ccc968","updated":"2016-11-02 12:07:07.000000000","message":"Done","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7871ae74c6a4a6636cb0cebf6c4f191b037fdbce","unresolved":false,"context_lines":[{"line_number":4,"context_line":"   IPv6 addresses in Neutron will now be stored and displayed in"},{"line_number":5,"context_line":"   canonical address format. Any address provided by the user in"},{"line_number":6,"context_line":"   an expanded format will be converted to canonical format first."},{"line_number":7,"context_line":"   During Upgrade, no changes will be done to the addresses already"},{"line_number":8,"context_line":"   saved in the database, only newly entered addresses would be"},{"line_number":9,"context_line":"   impacted."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5da102_61ed85b6","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":59},"updated":"2016-11-02 11:54:37.000000000","message":"will be made to addresses","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bbad3c4bcdc561bdd0b35546f86937c757b31f27","unresolved":false,"context_lines":[{"line_number":4,"context_line":"   IPv6 addresses in Neutron will now be stored and displayed in"},{"line_number":5,"context_line":"   canonical address format. Any address provided by the user in"},{"line_number":6,"context_line":"   an expanded format will be converted to canonical format first."},{"line_number":7,"context_line":"   During Upgrade, no changes will be done to the addresses already"},{"line_number":8,"context_line":"   saved in the database, only newly entered addresses would be"},{"line_number":9,"context_line":"   impacted."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5da102_64467350","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":59},"in_reply_to":"ba5da102_61ed85b6","updated":"2016-11-02 12:07:07.000000000","message":"Done","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7871ae74c6a4a6636cb0cebf6c4f191b037fdbce","unresolved":false,"context_lines":[{"line_number":5,"context_line":"   canonical address format. Any address provided by the user in"},{"line_number":6,"context_line":"   an expanded format will be converted to canonical format first."},{"line_number":7,"context_line":"   During Upgrade, no changes will be done to the addresses already"},{"line_number":8,"context_line":"   saved in the database, only newly entered addresses would be"},{"line_number":9,"context_line":"   impacted."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5da102_a1315d5c","line":8,"range":{"start_line":8,"start_character":55,"end_line":8,"end_character":60},"updated":"2016-11-02 11:54:37.000000000","message":"will","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bbad3c4bcdc561bdd0b35546f86937c757b31f27","unresolved":false,"context_lines":[{"line_number":5,"context_line":"   canonical address format. Any address provided by the user in"},{"line_number":6,"context_line":"   an expanded format will be converted to canonical format first."},{"line_number":7,"context_line":"   During Upgrade, no changes will be done to the addresses already"},{"line_number":8,"context_line":"   saved in the database, only newly entered addresses would be"},{"line_number":9,"context_line":"   impacted."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5da102_84754799","line":8,"range":{"start_line":8,"start_character":55,"end_line":8,"end_character":60},"in_reply_to":"ba5da102_a1315d5c","updated":"2016-11-02 12:07:07.000000000","message":"Done","commit_id":"70b29da0f05acc58b630a1968cb407d56ba36707"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1ae58ce5f6d7c1dcca925198dba40ebc7775762c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  -|"},{"line_number":4,"context_line":"   IPv6 addresses in Neutron will now be stored and displayed in"},{"line_number":5,"context_line":"   canonical format. Any IPv6 address provided by the user will be"},{"line_number":6,"context_line":"   converted to canonical format first."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba5da102_516f5d2a","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":3},"updated":"2016-11-02 17:39:39.000000000","message":"Needs to be on same line as text (do a \u0027tox -e releasenotes\u0027 and check the resulting HTML) .. e.g.::\n\n\nother:\n   - Start relnote here...","commit_id":"3cfca248d74e070313e58275bd1e0d2d2bbca0dc"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"64a4b80cb4688eebcb4feb88d6056da1f4bf2af1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  -|"},{"line_number":4,"context_line":"   IPv6 addresses in Neutron will now be stored and displayed in"},{"line_number":5,"context_line":"   canonical format. Any IPv6 address provided by the user will be"},{"line_number":6,"context_line":"   converted to canonical format first."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba5da102_d1960def","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":3},"in_reply_to":"ba5da102_516f5d2a","updated":"2016-11-02 17:41:01.000000000","message":"Or just check the resulting HTML here: http://docs-draft.openstack.org/70/357670/11/check/gate-neutron-lib-releasenotes/04205fc//releasenotes/build/html/unreleased.html","commit_id":"3cfca248d74e070313e58275bd1e0d2d2bbca0dc"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"aff3bc407500cd7996704c7394fe90e2f0786da3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IPv6 addresses in Neutron will now be stored and displayed in"},{"line_number":5,"context_line":"    canonical format. Any IPv6 address provided by the user will be"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5a74a57a_6e1def72","line":2,"updated":"2016-11-23 16:23:00.000000000","message":"I would opt to make this a new feature rather than other","commit_id":"839c668c28d7a57bd46603523c9d6a8193cb9a1d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"aff3bc407500cd7996704c7394fe90e2f0786da3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IPv6 addresses in Neutron will now be stored and displayed in"},{"line_number":5,"context_line":"    canonical format. Any IPv6 address provided by the user will be"},{"line_number":6,"context_line":"    converted to canonical format first."},{"line_number":7,"context_line":"    During Upgrade, no changes will be made to the addresses already"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5a74a57a_a2dd5b72","line":4,"updated":"2016-11-23 16:23:00.000000000","message":"Maybe I\u0027m missing something, but I\u0027m not sure why we are referring to neutron here and/or upgrade info; these details seem like they should live in neutron. I\u0027d opt to change this releasenote to something simple along the lines of \"A new converter was introduced named X that does Y\".","commit_id":"839c668c28d7a57bd46603523c9d6a8193cb9a1d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f228ce358d0f58d8fc9e19764a6f270a653bc759","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"     - |"},{"line_number":4,"context_line":"       Converter has been added to the neutron-lib which allows"},{"line_number":5,"context_line":"       IPv6 addresses to be stored and displayed in canonical format."},{"line_number":6,"context_line":"       Any IPv6 address provided by the user will be converted to"},{"line_number":7,"context_line":"       canonical format first."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_51d53341","line":4,"updated":"2016-11-23 18:03:02.000000000","message":"Nits:\n\n- \u0027A converter has...\u0027\n- Might be nice to give the converter name: ``convert_ip_to_canonical_format``","commit_id":"c7cedd0d781f2bb2d68d25a416c063aea8664b4f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f228ce358d0f58d8fc9e19764a6f270a653bc759","unresolved":false,"context_lines":[{"line_number":3,"context_line":"     - |"},{"line_number":4,"context_line":"       Converter has been added to the neutron-lib which allows"},{"line_number":5,"context_line":"       IPv6 addresses to be stored and displayed in canonical format."},{"line_number":6,"context_line":"       Any IPv6 address provided by the user will be converted to"},{"line_number":7,"context_line":"       canonical format first."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_717cef72","line":6,"updated":"2016-11-23 18:03:02.000000000","message":"Sorry to nit, but I\u0027d opt just remove this last sentence. IMHO we should not make any assumptions about how consumers will use this. If neutron or others want to call out how they convert stuff, let them do it as necessary.\n\n\nThoughts?","commit_id":"c7cedd0d781f2bb2d68d25a416c063aea8664b4f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"6dbe686536a2c7628329ee51ae9f87d94be8a519","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"     - |"},{"line_number":4,"context_line":"       A converter ``convert_to_canonical_format`` has been added to"},{"line_number":5,"context_line":"       the neutron-lib which allows IPv6 addresses to be stored and"},{"line_number":6,"context_line":"       displayed in canonical format."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5a74a57a_20399fd7","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":48},"updated":"2016-11-28 18:24:43.000000000","message":"Unless I\u0027m missing something the function name is convert_ip_to_canonical_format","commit_id":"2882e028dccd941d9c43b6fc4f00ef80a464acd0"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"cdb35907fb8de0b5689f4727469cafae4df2007d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"     - |"},{"line_number":4,"context_line":"       A converter ``convert_to_canonical_format`` has been added to"},{"line_number":5,"context_line":"       the neutron-lib which allows IPv6 addresses to be stored and"},{"line_number":6,"context_line":"       displayed in canonical format."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5a74a57a_bb6de2cd","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":48},"in_reply_to":"5a74a57a_20399fd7","updated":"2016-11-28 18:51:24.000000000","message":"+1","commit_id":"2882e028dccd941d9c43b6fc4f00ef80a464acd0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c6584294c3de240af0e26cd78eb87e7a7c5ce003","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"     - |"},{"line_number":4,"context_line":"       A converter ``convert_to_canonical_format`` has been added to"},{"line_number":5,"context_line":"       the neutron-lib which allows IPv6 addresses to be stored and"},{"line_number":6,"context_line":"       displayed in canonical format."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5a74a57a_1a9a466e","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":48},"in_reply_to":"5a74a57a_bb6de2cd","updated":"2016-11-29 00:13:14.000000000","message":"The code underwen changes, the reno however didnt move :(","commit_id":"2882e028dccd941d9c43b6fc4f00ef80a464acd0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"04a932484ca504a4064575a502a2ce236f76cd6f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"     - |"},{"line_number":4,"context_line":"       A converter ``convert_ip_to_canonical_format`` has been added to"},{"line_number":5,"context_line":"       the neutron-lib which allows IPv6 addresses to be stored and"},{"line_number":6,"context_line":"       displayed in canonical format."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"5a74a57a_6ec9b8ab","line":5,"updated":"2016-11-29 02:26:54.000000000","message":"s/the neutron-lib/neutron-lib","commit_id":"27fbce554b4c2312cdde08c7fb8ad2619c16b019"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"028dcef63efa95133e30735d5a857160a06bf769","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"     - |"},{"line_number":4,"context_line":"       A converter ``convert_ip_to_canonical_format`` has been added to"},{"line_number":5,"context_line":"       the neutron-lib which allows IPv6 addresses to be stored and"},{"line_number":6,"context_line":"       displayed in canonical format."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"5a74a57a_b3eb2612","line":5,"in_reply_to":"5a74a57a_6ec9b8ab","updated":"2016-11-29 12:30:24.000000000","message":"Done","commit_id":"27fbce554b4c2312cdde08c7fb8ad2619c16b019"}]}
