)]}'
{"neutron_lib/exceptions.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"114884ad844239c44e38444a68c3fa6bea474bfc","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def __init__(self, **kwargs):"},{"line_number":274,"context_line":"        # Convert vlan_range tuple to \u0027start:end\u0027 format for display"},{"line_number":275,"context_line":"        if isinstance(kwargs[\u0027vlan_range\u0027], tuple):"},{"line_number":276,"context_line":"            kwargs[\u0027vlan_range\u0027] \u003d \"%d:%d\" % kwargs[\u0027vlan_range\u0027]"},{"line_number":277,"context_line":"        super(NetworkVlanRangeError, self).__init__(**kwargs)"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_99532b6b","line":275,"updated":"2016-08-22 18:37:21.000000000","message":"We need a test for this logic.","commit_id":"da072f5cf30b4e789867d79a4f5fe212ddd17a66"}],"neutron_lib/plugins/constants.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"114884ad844239c44e38444a68c3fa6bea474bfc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \u0027revisions\u0027: \u0027revisions\u0027,"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Service operation status constants"},{"line_number":52,"context_line":"ACTIVE \u003d \"ACTIVE\""},{"line_number":53,"context_line":"DOWN \u003d \"DOWN\""},{"line_number":54,"context_line":"CREATED \u003d \"CREATED\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_b928a7e3","line":51,"updated":"2016-08-22 18:37:21.000000000","message":"These appear to already be defined [1]; do we really want to duplicate them here?\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L33","commit_id":"da072f5cf30b4e789867d79a4f5fe212ddd17a66"}],"neutron_lib/plugins/utils.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"114884ad844239c44e38444a68c3fa6bea474bfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ac06dbe_d9e00399","updated":"2016-08-22 18:37:21.000000000","message":"Lots of missing UTs (coverage) in here. We are looking for 100% coverage.","commit_id":"da072f5cf30b4e789867d79a4f5fe212ddd17a66"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"114884ad844239c44e38444a68c3fa6bea474bfc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron_lib import exceptions"},{"line_number":28,"context_line":"from neutron_lib.plugins import constants as p_const"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"INTERFACE_HASH_LEN \u003d 6"},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_394cb79d","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":18},"updated":"2016-08-22 18:37:21.000000000","message":"Does this really need to be public?","commit_id":"da072f5cf30b4e789867d79a4f5fe212ddd17a66"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"114884ad844239c44e38444a68c3fa6bea474bfc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def get_deployment_physnet_mtu():"},{"line_number":35,"context_line":"    \"\"\"Retrieves global physical network MTU setting."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Plugins should use this function to retrieve the MTU set by the operator"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_fc1b2d71","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":30},"updated":"2016-08-22 18:37:21.000000000","message":"If you get bored it would be nice to have docstrings for all these public APIs [1]. But I suspect you won\u0027t get that bored, so I can follow-up with another patch for that.\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/doc/source/review-guidelines.rst","commit_id":"da072f5cf30b4e789867d79a4f5fe212ddd17a66"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"114884ad844239c44e38444a68c3fa6bea474bfc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    Note that it is the responsibility of the plugin to deduct the value of"},{"line_number":40,"context_line":"    any encapsulation overhead required before advertising it to VMs."},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":"    return cfg.CONF.global_physnet_mtu"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def is_valid_vlan_tag(vlan):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_f9fa1f42","line":42,"range":{"start_line":42,"start_character":11,"end_line":42,"end_character":38},"updated":"2016-08-22 18:37:21.000000000","message":"Perhaps we should accept a kwarg for the conf, defaulting to cfg.CONF??\n\ne.g.\n\ndef get_deployment_physnet_mtu(conf\u003dcfg.CONF):\n...","commit_id":"da072f5cf30b4e789867d79a4f5fe212ddd17a66"}],"neutron_lib/tests/unit/plugins/test_utils.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"edb1b6184a7c7b18c401d30176883957102653b0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import hashlib"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron_lib.plugins import utils"},{"line_number":21,"context_line":"from neutron_lib.tests import _base as base"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_89af2f29","line":18,"updated":"2016-08-23 12:07:37.000000000","message":"this should be in the same group as below","commit_id":"da072f5cf30b4e789867d79a4f5fe212ddd17a66"}]}