)]}'
{"neutron_lib/api/validators.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"77d1ea14cf5cbc5260aec6f512b7da14ee492910","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    \"\"\"Validate data is a list of UUID like values."},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    :param data: The data to validate."},{"line_number":656,"context_line":"    :param valid_values: Not used!"},{"line_number":657,"context_line":"    :returns: None if data is an iterable that contains valid UUID values,"},{"line_number":658,"context_line":"    otherwise a message is returned indicating why validation failed."},{"line_number":659,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_6dee72b5","line":656,"range":{"start_line":656,"start_character":4,"end_line":656,"end_character":34},"updated":"2016-09-07 09:40:31.000000000","message":"If `valid_values` is not used, should it be exposed? `validate_uuid` function accepts this keyword, but does nothing with it.\nWouldn\u0027t it be simpler to refactor it, and just get rid of `valid_values` everywhere?","commit_id":"3d043c0ebc0528508a7a7393388c674afd44bae1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"756a1add260b01dce92aaa750d33de5af809f793","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    \"\"\"Validate data is a list of UUID like values."},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    :param data: The data to validate."},{"line_number":656,"context_line":"    :param valid_values: Not used!"},{"line_number":657,"context_line":"    :returns: None if data is an iterable that contains valid UUID values,"},{"line_number":658,"context_line":"    otherwise a message is returned indicating why validation failed."},{"line_number":659,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_99513439","line":656,"range":{"start_line":656,"start_character":4,"end_line":656,"end_character":34},"in_reply_to":"9a89bdaa_6dee72b5","updated":"2016-09-07 10:41:31.000000000","message":"Validators are always called with a valid_values argument even though it may not be used:\nhttps://github.com/openstack/neutron/blob/9.0.0.0b3/neutron/api/v2/attributes.py#L431","commit_id":"3d043c0ebc0528508a7a7393388c674afd44bae1"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c336793374d7f16a5ef152db21d54b829f3c3a92","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    \"\"\"Validate data is a list of UUID like values."},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    :param data: The data to validate."},{"line_number":656,"context_line":"    :param valid_values: Not used!"},{"line_number":657,"context_line":"    :returns: None if data is an iterable that contains valid UUID values,"},{"line_number":658,"context_line":"    otherwise a message is returned indicating why validation failed."},{"line_number":659,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_190c4440","line":656,"range":{"start_line":656,"start_character":4,"end_line":656,"end_character":34},"in_reply_to":"9a89bdaa_99513439","updated":"2016-09-07 10:43:33.000000000","message":"OK, I get it. Validators are not imported one by one, but just like generic function, which should accept `valid_values`.\n\nThanks","commit_id":"3d043c0ebc0528508a7a7393388c674afd44bae1"}]}