)]}'
{"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":159,"context_line":"  type: string"},{"line_number":160,"context_line":"segment_id-path:"},{"line_number":161,"context_line":"  description: |"},{"line_number":162,"context_line":"    The UUID of the segment."},{"line_number":163,"context_line":"  in: path"},{"line_number":164,"context_line":"  required: true"},{"line_number":165,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_851ca578","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":12},"updated":"2016-10-12 20:06:26.000000000","message":"UUID needs to be replaced by ID as mentioned in [1].\n\n[1] https://etherpad.openstack.org/p/neutron-api-ref-sprint","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"49c354de77855871f1b25d4e7388b89ee10b65cd","unresolved":false,"context_lines":[{"line_number":159,"context_line":"  type: string"},{"line_number":160,"context_line":"segment_id-path:"},{"line_number":161,"context_line":"  description: |"},{"line_number":162,"context_line":"    The UUID of the segment."},{"line_number":163,"context_line":"  in: path"},{"line_number":164,"context_line":"  required: true"},{"line_number":165,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_a22ded96","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":12},"in_reply_to":"fa6399be_6f004a02","updated":"2016-10-13 16:30:27.000000000","message":"I understand what you are saying but this will add more tech debt for the api-ref and we will have to clean it up later. There is an ongoing effort for cleaning up the api-ref\u0027s  as mentioned in the etherpad in my previous comment. So it would be nice to have the new changes being conformant with the guidelines in the etherpad.","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":159,"context_line":"  type: string"},{"line_number":160,"context_line":"segment_id-path:"},{"line_number":161,"context_line":"  description: |"},{"line_number":162,"context_line":"    The UUID of the segment."},{"line_number":163,"context_line":"  in: path"},{"line_number":164,"context_line":"  required: true"},{"line_number":165,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_6f004a02","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":12},"in_reply_to":"fa6399be_851ca578","updated":"2016-10-12 23:10:30.000000000","message":"I\u0027d rather be consistent with the rest of the rest of this file and let someone make a wholesale change later. I think it would be worse to use ID here when the file uses UUID everywhere.","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":3445,"context_line":"  type: array"},{"line_number":3446,"context_line":"segment_id:"},{"line_number":3447,"context_line":"  description: |"},{"line_number":3448,"context_line":"    The UUID of the segment."},{"line_number":3449,"context_line":"  in: body"},{"line_number":3450,"context_line":"  required: true"},{"line_number":3451,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_05097531","line":3448,"range":{"start_line":3448,"start_character":8,"end_line":3448,"end_character":12},"updated":"2016-10-12 20:06:26.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":3445,"context_line":"  type: array"},{"line_number":3446,"context_line":"segment_id:"},{"line_number":3447,"context_line":"  description: |"},{"line_number":3448,"context_line":"    The UUID of the segment."},{"line_number":3449,"context_line":"  in: body"},{"line_number":3450,"context_line":"  required: true"},{"line_number":3451,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_8f03de0c","line":3448,"range":{"start_line":3448,"start_character":8,"end_line":3448,"end_character":12},"in_reply_to":"fa6399be_05097531","updated":"2016-10-12 23:10:30.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"49c354de77855871f1b25d4e7388b89ee10b65cd","unresolved":false,"context_lines":[{"line_number":3445,"context_line":"  type: array"},{"line_number":3446,"context_line":"segment_id:"},{"line_number":3447,"context_line":"  description: |"},{"line_number":3448,"context_line":"    The UUID of the segment."},{"line_number":3449,"context_line":"  in: body"},{"line_number":3450,"context_line":"  required: true"},{"line_number":3451,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_223abdcc","line":3448,"range":{"start_line":3448,"start_character":8,"end_line":3448,"end_character":12},"in_reply_to":"fa6399be_8f03de0c","updated":"2016-10-13 16:30:27.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"}],"api-ref/source/v2/samples/segments/segment-create-response.json":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"9159ebed6e6cff631e6d8cc42bd988e5b2561ee0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \"segmentation_id\": 2000,"},{"line_number":6,"context_line":"    \"network_type\": \"vlan\","},{"line_number":7,"context_line":"    \"physical_network\": \"segment-1\","},{"line_number":8,"context_line":"    \"id\": \"6e507ee8-234d-4f79-9fd4-b109ca1aea5b\","},{"line_number":9,"context_line":"    \"description\": null"},{"line_number":10,"context_line":"  }"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"5a8bc5a2_8dd224ff","line":8,"range":{"start_line":8,"start_character":11,"end_line":8,"end_character":47},"updated":"2016-09-23 09:31:55.000000000","message":"Not sure if it\u0027s important in context, but this doesn\u0027t match the segment_id used elsewhere:\n\n 57fe85e4-ca2f-4192-b3cd-d5c249d7a21f","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3a0cd7fbbbd87bdaeff5953ae6f500a7db98182b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \"segmentation_id\": 2000,"},{"line_number":6,"context_line":"    \"network_type\": \"vlan\","},{"line_number":7,"context_line":"    \"physical_network\": \"segment-1\","},{"line_number":8,"context_line":"    \"id\": \"6e507ee8-234d-4f79-9fd4-b109ca1aea5b\","},{"line_number":9,"context_line":"    \"description\": null"},{"line_number":10,"context_line":"  }"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"1a95cdbc_0d678a4d","line":8,"range":{"start_line":8,"start_character":11,"end_line":8,"end_character":47},"in_reply_to":"5a8bc5a2_8dd224ff","updated":"2016-10-07 22:33:43.000000000","message":"I might have taken these from different runs. I\u0027ll fix it.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"}],"api-ref/source/v2/samples/segments/segments-list-response.json":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"588361d9f6528fc9467f39fc5950cc2091ef3c6e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"segments\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"      \"name\": null,"},{"line_number":5,"context_line":"      \"network_id\": \"5c0cb560-4089-41dd-be29-469907a23b49\","},{"line_number":6,"context_line":"      \"segmentation_id\": 2000,"},{"line_number":7,"context_line":"      \"network_type\": \"vlan\","}],"source_content_type":"application/json","patch_set":7,"id":"fa6399be_3a981dc0","line":4,"updated":"2016-10-13 21:15:57.000000000","message":"is really the API returning null? yuk","commit_id":"0c3959d3453eaa0872e3a6ff4eec89cc9ac27fb5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c7f988e659e88f5232e03955080c60f445d4e61c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"segments\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"      \"name\": null,"},{"line_number":5,"context_line":"      \"network_id\": \"5c0cb560-4089-41dd-be29-469907a23b49\","},{"line_number":6,"context_line":"      \"segmentation_id\": 2000,"},{"line_number":7,"context_line":"      \"network_type\": \"vlan\","}],"source_content_type":"application/json","patch_set":7,"id":"fa6399be_611ba881","line":4,"in_reply_to":"fa6399be_21c8d073","updated":"2016-10-14 14:55:12.000000000","message":"I guess another alternative is for the api to only include it when it is non-null. Maybe you can tell me what you don\u0027t like about it.","commit_id":"0c3959d3453eaa0872e3a6ff4eec89cc9ac27fb5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9115fe0dc318d48ba53e6d596c10a988dcf8e2ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"segments\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"      \"name\": null,"},{"line_number":5,"context_line":"      \"network_id\": \"5c0cb560-4089-41dd-be29-469907a23b49\","},{"line_number":6,"context_line":"      \"segmentation_id\": 2000,"},{"line_number":7,"context_line":"      \"network_type\": \"vlan\","}],"source_content_type":"application/json","patch_set":7,"id":"fa6399be_21c8d073","line":4,"in_reply_to":"fa6399be_3a981dc0","updated":"2016-10-14 14:45:02.000000000","message":"I don\u0027t have a problem with that. To me, it just means that the segment doesn\u0027t have a name. The alternative is an empty string. I\u0027m not sure why that is much better.","commit_id":"0c3959d3453eaa0872e3a6ff4eec89cc9ac27fb5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ff7a8801f7ebd3769410d2e8f12b17c276da5969","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"segments\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"      \"name\": null,"},{"line_number":5,"context_line":"      \"network_id\": \"5c0cb560-4089-41dd-be29-469907a23b49\","},{"line_number":6,"context_line":"      \"segmentation_id\": 2000,"},{"line_number":7,"context_line":"      \"network_type\": \"vlan\","}],"source_content_type":"application/json","patch_set":7,"id":"fa6399be_a853dc15","line":4,"in_reply_to":"fa6399be_611ba881","updated":"2016-10-14 17:42:51.000000000","message":"What I don\u0027t like about it is that GUI clients may render the null value as a \u0027null\u0027 string, which is ok, if it wasn\u0027t for some other GUI clients that may erroneously go and take the \u0027null\u0027 string and pass it back into an update body and now the null value becomes a \u0027null\u0027 value.\n\nNothing to complain here, someone should have complained at the time the API was defined.","commit_id":"0c3959d3453eaa0872e3a6ff4eec89cc9ac27fb5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"74117b67d39297d5e755676a5da43722eeadfcee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"segments\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"      \"name\": null,"},{"line_number":5,"context_line":"      \"network_id\": \"5c0cb560-4089-41dd-be29-469907a23b49\","},{"line_number":6,"context_line":"      \"segmentation_id\": 2000,"},{"line_number":7,"context_line":"      \"network_type\": \"vlan\","}],"source_content_type":"application/json","patch_set":7,"id":"fa6399be_8d1b8a80","line":4,"in_reply_to":"fa6399be_611ba881","updated":"2016-10-14 17:40:13.000000000","message":"that\u0027s the virtual default everywhere you see in the API. You created a singularity!! :)","commit_id":"0c3959d3453eaa0872e3a6ff4eec89cc9ac27fb5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"270cbfbbe56630df1a4389571dc7a51f43768a9b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"segments\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"      \"name\": null,"},{"line_number":5,"context_line":"      \"network_id\": \"5c0cb560-4089-41dd-be29-469907a23b49\","},{"line_number":6,"context_line":"      \"segmentation_id\": 2000,"},{"line_number":7,"context_line":"      \"network_type\": \"vlan\","}],"source_content_type":"application/json","patch_set":7,"id":"fa6399be_88029808","line":4,"in_reply_to":"fa6399be_8d1b8a80","updated":"2016-10-14 17:40:35.000000000","message":"I mean the empty string.","commit_id":"0c3959d3453eaa0872e3a6ff4eec89cc9ac27fb5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"74117b67d39297d5e755676a5da43722eeadfcee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      \"network_type\": \"vlan\","},{"line_number":8,"context_line":"      \"physical_network\": \"segment-1\","},{"line_number":9,"context_line":"      \"id\": \"57fe85e4-ca2f-4192-b3cd-d5c249d7a21f\","},{"line_number":10,"context_line":"      \"description\": null"},{"line_number":11,"context_line":"    },"},{"line_number":12,"context_line":"    {"},{"line_number":13,"context_line":"      \"name\": null,"}],"source_content_type":"application/json","patch_set":7,"id":"fa6399be_ad1e8e6d","line":10,"updated":"2016-10-14 17:40:13.000000000","message":"same here","commit_id":"0c3959d3453eaa0872e3a6ff4eec89cc9ac27fb5"}],"api-ref/source/v2/samples/subnets/subnet-create-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"78c183d729cde86700a789508bc20b9f55bab0b6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\": \"\","},{"line_number":4,"context_line":"        \"enable_dhcp\": true,"},{"line_number":5,"context_line":"        \"network_id\": \"d32019d3-bc6e-4319-9c1d-6722fc136a22\","},{"line_number":6,"context_line":"        \"segment_id\": null,"},{"line_number":7,"context_line":"        \"project_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":8,"context_line":"        \"tenant_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":9,"context_line":"        \"dns_nameservers\": [],"}],"source_content_type":"application/json","patch_set":4,"id":"1a95cdbc_75009f34","line":6,"updated":"2016-10-10 15:34:21.000000000","message":"Maybe I\u0027m missing something. Is this supposed to show up in the  POST\n/v2.0/subnets\nCreate subnet\nrespose??\nI\u0027m not seeing it in the build: http://docs-draft.openstack.org/34/374434/4/check/gate-neutron-lib-api-ref/f56edc9//api-ref/build/html/v2/index.html?expanded\u003dupdate-subnet-detail#subnets","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fb739c26ba4950bbf3ef69949f58810fe6aac9b0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\": \"\","},{"line_number":4,"context_line":"        \"enable_dhcp\": true,"},{"line_number":5,"context_line":"        \"network_id\": \"d32019d3-bc6e-4319-9c1d-6722fc136a22\","},{"line_number":6,"context_line":"        \"segment_id\": null,"},{"line_number":7,"context_line":"        \"project_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":8,"context_line":"        \"tenant_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":9,"context_line":"        \"dns_nameservers\": [],"}],"source_content_type":"application/json","patch_set":4,"id":"fa6399be_76b074de","line":6,"in_reply_to":"1a95cdbc_75009f34","updated":"2016-10-11 12:39:14.000000000","message":"Maybe, It\u0027s just bug. It will be fixed in another patch[1].\n\n[1]: https://review.openstack.org/#/c/358282/22/api-ref/source/v2/subnets.inc","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6c05e8f6e33e6eec7a3ae0392719cfa417a86a0e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\": \"\","},{"line_number":4,"context_line":"        \"enable_dhcp\": true,"},{"line_number":5,"context_line":"        \"network_id\": \"d32019d3-bc6e-4319-9c1d-6722fc136a22\","},{"line_number":6,"context_line":"        \"segment_id\": null,"},{"line_number":7,"context_line":"        \"project_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":8,"context_line":"        \"tenant_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":9,"context_line":"        \"dns_nameservers\": [],"}],"source_content_type":"application/json","patch_set":4,"id":"fa6399be_a14e0494","line":6,"in_reply_to":"fa6399be_76b074de","updated":"2016-10-12 17:41:33.000000000","message":"Good catch. Yes, it should appear but I agree that this is a bug that should be fixed in another patch.","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"}],"api-ref/source/v2/samples/subnets/subnets-create-bulk-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"78c183d729cde86700a789508bc20b9f55bab0b6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            \"ip_version\": 4,"},{"line_number":17,"context_line":"            \"name\": \"\","},{"line_number":18,"context_line":"            \"network_id\": \"e6031bc2-901a-4c66-82da-f4c32ed89406\","},{"line_number":19,"context_line":"            \"segment_id\": null,"},{"line_number":20,"context_line":"            \"project_id\": \"d19231fc08ec4bc4829b668040d34512\","},{"line_number":21,"context_line":"            \"tenant_id\": \"d19231fc08ec4bc4829b668040d34512\""},{"line_number":22,"context_line":"        },"}],"source_content_type":"application/json","patch_set":4,"id":"1a95cdbc_156cbb06","line":19,"range":{"start_line":19,"start_character":12,"end_line":19,"end_character":31},"updated":"2016-10-10 15:34:21.000000000","message":"Ditto; not seeing this used in the api-ref build output.","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6c05e8f6e33e6eec7a3ae0392719cfa417a86a0e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            \"ip_version\": 4,"},{"line_number":17,"context_line":"            \"name\": \"\","},{"line_number":18,"context_line":"            \"network_id\": \"e6031bc2-901a-4c66-82da-f4c32ed89406\","},{"line_number":19,"context_line":"            \"segment_id\": null,"},{"line_number":20,"context_line":"            \"project_id\": \"d19231fc08ec4bc4829b668040d34512\","},{"line_number":21,"context_line":"            \"tenant_id\": \"d19231fc08ec4bc4829b668040d34512\""},{"line_number":22,"context_line":"        },"}],"source_content_type":"application/json","patch_set":4,"id":"fa6399be_215bd455","line":19,"range":{"start_line":19,"start_character":12,"end_line":19,"end_character":31},"in_reply_to":"1a95cdbc_156cbb06","updated":"2016-10-12 17:41:33.000000000","message":"ditto","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"78c183d729cde86700a789508bc20b9f55bab0b6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            \"ip_version\": 4,"},{"line_number":37,"context_line":"            \"name\": \"\","},{"line_number":38,"context_line":"            \"network_id\": \"64239a54-dcc4-4b39-920b-b37c2144effa\","},{"line_number":39,"context_line":"            \"segment_id\": null,"},{"line_number":40,"context_line":"            \"project_id\": \"d19231fc08ec4bc4829b668040d34512\","},{"line_number":41,"context_line":"            \"tenant_id\": \"d19231fc08ec4bc4829b668040d34512\""},{"line_number":42,"context_line":"        }"}],"source_content_type":"application/json","patch_set":4,"id":"1a95cdbc_9580cb8c","line":39,"updated":"2016-10-10 15:34:21.000000000","message":"Ditto.","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6c05e8f6e33e6eec7a3ae0392719cfa417a86a0e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            \"ip_version\": 4,"},{"line_number":37,"context_line":"            \"name\": \"\","},{"line_number":38,"context_line":"            \"network_id\": \"64239a54-dcc4-4b39-920b-b37c2144effa\","},{"line_number":39,"context_line":"            \"segment_id\": null,"},{"line_number":40,"context_line":"            \"project_id\": \"d19231fc08ec4bc4829b668040d34512\","},{"line_number":41,"context_line":"            \"tenant_id\": \"d19231fc08ec4bc4829b668040d34512\""},{"line_number":42,"context_line":"        }"}],"source_content_type":"application/json","patch_set":4,"id":"fa6399be_8132e00e","line":39,"in_reply_to":"1a95cdbc_9580cb8c","updated":"2016-10-12 17:41:33.000000000","message":"ditto","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"}],"api-ref/source/v2/segments.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9bf49c93c1d77e2a127daa1a021ed1e5ad6e62d2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Normal response codes: 200"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Error response codes: 404,401"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Request"},{"line_number":32,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5a8bc5a2_31ddcf0e","line":29,"range":{"start_line":29,"start_character":22,"end_line":29,"end_character":29},"updated":"2016-09-23 18:32:41.000000000","message":"Nit: spaces between comma list items.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3a0cd7fbbbd87bdaeff5953ae6f500a7db98182b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Normal response codes: 200"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Error response codes: 404,401"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Request"},{"line_number":32,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1a95cdbc_2de606b0","line":29,"range":{"start_line":29,"start_character":22,"end_line":29,"end_character":29},"in_reply_to":"5a8bc5a2_31ddcf0e","updated":"2016-10-07 22:33:43.000000000","message":"Please see the other existing *.inc files in this directory. I followed convention.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9bf49c93c1d77e2a127daa1a021ed1e5ad6e62d2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   - physical_network: provider:physical_network"},{"line_number":46,"context_line":"   - network_type: network_type"},{"line_number":47,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":48,"context_line":"   - name: name"},{"line_number":49,"context_line":"   - description: description"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Response Example"},{"line_number":52,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5a8bc5a2_b1847fd4","line":49,"range":{"start_line":48,"start_character":5,"end_line":49,"end_character":29},"updated":"2016-09-23 18:32:41.000000000","message":"name and description are showing up as required, but in the same request/responses they are not always there so I suspect they are in fact optional??\n\n\nThis applies to all response parameters in your patch for the segments api.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3a0cd7fbbbd87bdaeff5953ae6f500a7db98182b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   - physical_network: provider:physical_network"},{"line_number":46,"context_line":"   - network_type: network_type"},{"line_number":47,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":48,"context_line":"   - name: name"},{"line_number":49,"context_line":"   - description: description"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Response Example"},{"line_number":52,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1a95cdbc_c02f2986","line":49,"range":{"start_line":48,"start_character":5,"end_line":49,"end_character":29},"in_reply_to":"5a8bc5a2_b1847fd4","updated":"2016-10-07 22:33:43.000000000","message":"Does required actually mean anything in responses? I see tons of inconsistencies throughout the documentation.\n\nI changed the these to name-request and description-request when used in the context of a request because they are optional.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9bf49c93c1d77e2a127daa1a021ed1e5ad6e62d2","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Normal response codes: 200"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Error response codes: 404,403,401,400"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Request"},{"line_number":69,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5a8bc5a2_11a0d38f","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":37},"updated":"2016-09-23 18:32:41.000000000","message":"Ditto.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3a0cd7fbbbd87bdaeff5953ae6f500a7db98182b","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Normal response codes: 200"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Error response codes: 404,403,401,400"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Request"},{"line_number":69,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1a95cdbc_6d048e49","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":37},"in_reply_to":"5a8bc5a2_11a0d38f","updated":"2016-10-07 22:33:43.000000000","message":"ditto","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9bf49c93c1d77e2a127daa1a021ed1e5ad6e62d2","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"   - id: id"},{"line_number":88,"context_line":"   - network_id: network_id"},{"line_number":89,"context_line":"   - physical_network: provider:physical_network"},{"line_number":90,"context_line":"   - network_type: network_type"},{"line_number":91,"context_line":"   - segmentation_id: provider:segmentation_id"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5a8bc5a2_31feaf37","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":27},"updated":"2016-09-23 18:32:41.000000000","message":"These both show up with a description of \"The UUID of the network.\". I suspect the \u0027id\u0027 needs to be the UUID of the segment?","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3a0cd7fbbbd87bdaeff5953ae6f500a7db98182b","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"   - id: id"},{"line_number":88,"context_line":"   - network_id: network_id"},{"line_number":89,"context_line":"   - physical_network: provider:physical_network"},{"line_number":90,"context_line":"   - network_type: network_type"},{"line_number":91,"context_line":"   - segmentation_id: provider:segmentation_id"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1a95cdbc_e0750598","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":27},"in_reply_to":"5a8bc5a2_31feaf37","updated":"2016-10-07 22:33:43.000000000","message":"You are correct.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9bf49c93c1d77e2a127daa1a021ed1e5ad6e62d2","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Normal response codes: 204"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Error response codes: 409,404,401"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Request"},{"line_number":113,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5a8bc5a2_91ba23bf","line":110,"range":{"start_line":110,"start_character":22,"end_line":110,"end_character":33},"updated":"2016-09-23 18:32:41.000000000","message":"Ditto","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3a0cd7fbbbd87bdaeff5953ae6f500a7db98182b","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Normal response codes: 204"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Error response codes: 409,404,401"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Request"},{"line_number":113,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1a95cdbc_8d01da3a","line":110,"range":{"start_line":110,"start_character":22,"end_line":110,"end_character":33},"in_reply_to":"5a8bc5a2_91ba23bf","updated":"2016-10-07 22:33:43.000000000","message":"ditto","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9bf49c93c1d77e2a127daa1a021ed1e5ad6e62d2","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   - segment_id: segment_id"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"List segments"},{"line_number":120,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5a8bc5a2_91678324","line":117,"range":{"start_line":117,"start_character":5,"end_line":117,"end_character":27},"updated":"2016-09-23 18:32:41.000000000","message":"This shows as \"segment_id (Optional)\tbody\tstring\tThe UUID of the segment.\" \n\nBut the URI is: DELETE /v2.0/segments/{segment_id}\n\n\nSo the UUID can be in the body but is required in the URI? It\u0027s not clear to me.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3a0cd7fbbbd87bdaeff5953ae6f500a7db98182b","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   - segment_id: segment_id"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"List segments"},{"line_number":120,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1a95cdbc_206c4dcf","line":117,"range":{"start_line":117,"start_character":5,"end_line":117,"end_character":27},"in_reply_to":"5a8bc5a2_91678324","updated":"2016-10-07 22:33:43.000000000","message":"I really needed to add another segment_id parameter that can be in the path instead of the body. Done.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"9159ebed6e6cff631e6d8cc42bd988e5b2561ee0","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":".. rest_method::  GET /v2.0/segments"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Lists segments to which the tenant has access."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Use the ``fields`` query parameter to filter the response. For"},{"line_number":127,"context_line":"information, see `Filtering and Column Selection \u003chttps://wiki.open"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5a8bc5a2_8842123d","line":124,"range":{"start_line":124,"start_character":28,"end_line":124,"end_character":34},"updated":"2016-09-23 09:31:55.000000000","message":"Should this be project? I\u0027m not sure how far along we are with that migration.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3cc6585ae2b44f15a9d4b38d38ea84cdcc6e24fa","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":".. rest_method::  GET /v2.0/segments"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Lists segments to which the tenant has access."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Use the ``fields`` query parameter to filter the response. For"},{"line_number":127,"context_line":"information, see `Filtering and Column Selection \u003chttps://wiki.open"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5a8bc5a2_911ce378","line":124,"range":{"start_line":124,"start_character":28,"end_line":124,"end_character":34},"in_reply_to":"5a8bc5a2_8842123d","updated":"2016-09-23 18:34:50.000000000","message":"Can probably ask Henry here: https://review.openstack.org/#/c/372857/","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3a0cd7fbbbd87bdaeff5953ae6f500a7db98182b","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":".. rest_method::  GET /v2.0/segments"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Lists segments to which the tenant has access."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Use the ``fields`` query parameter to filter the response. For"},{"line_number":127,"context_line":"information, see `Filtering and Column Selection \u003chttps://wiki.open"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1a95cdbc_edbdfe68","line":124,"range":{"start_line":124,"start_character":28,"end_line":124,"end_character":34},"in_reply_to":"5a8bc5a2_911ce378","updated":"2016-10-07 22:33:43.000000000","message":"I\u0027ll change it to project after I\u0027ve rebased to that commit.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9bf49c93c1d77e2a127daa1a021ed1e5ad6e62d2","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Creates a segment."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Error response codes: 201,401,400"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Request"},{"line_number":167,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5a8bc5a2_d1b4abd2","line":164,"range":{"start_line":164,"start_character":22,"end_line":164,"end_character":33},"updated":"2016-09-23 18:32:41.000000000","message":"Ditto.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3a0cd7fbbbd87bdaeff5953ae6f500a7db98182b","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Creates a segment."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Error response codes: 201,401,400"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Request"},{"line_number":167,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1a95cdbc_4db99278","line":164,"range":{"start_line":164,"start_character":22,"end_line":164,"end_character":33},"in_reply_to":"5a8bc5a2_d1b4abd2","updated":"2016-10-07 22:33:43.000000000","message":"ditto","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fb739c26ba4950bbf3ef69949f58810fe6aac9b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":".. needs:method_verification"},{"line_number":3,"context_line":".. needs:parameter_verification"},{"line_number":4,"context_line":".. needs:example_verification"},{"line_number":5,"context_line":".. needs:body_verification"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Segments"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fa6399be_36635c1c","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":26},"updated":"2016-10-11 12:39:14.000000000","message":"Do we still need thes checks? These points should be supplied in this patch. If this patch satisfies, we can remove the lines!","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6c05e8f6e33e6eec7a3ae0392719cfa417a86a0e","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":".. needs:method_verification"},{"line_number":3,"context_line":".. needs:parameter_verification"},{"line_number":4,"context_line":".. needs:example_verification"},{"line_number":5,"context_line":".. needs:body_verification"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Segments"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fa6399be_e13f1cd4","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":26},"in_reply_to":"fa6399be_36635c1c","updated":"2016-10-12 17:41:33.000000000","message":"I forgot about these, thanks for pointing them out.","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"78c183d729cde86700a789508bc20b9f55bab0b6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   - physical_network: provider:physical_network"},{"line_number":46,"context_line":"   - network_type: network_type"},{"line_number":47,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":48,"context_line":"   - name: name"},{"line_number":49,"context_line":"   - description: description"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"1a95cdbc_794a5956","line":48,"range":{"start_line":48,"start_character":5,"end_line":48,"end_character":15},"updated":"2016-10-10 15:34:21.000000000","message":"This shows up as \"Human-readable name of the resource. Default is an empty string.\"\n\n\nIs the default really the empty string instead of None/null?","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6c05e8f6e33e6eec7a3ae0392719cfa417a86a0e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   - physical_network: provider:physical_network"},{"line_number":46,"context_line":"   - network_type: network_type"},{"line_number":47,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":48,"context_line":"   - name: name"},{"line_number":49,"context_line":"   - description: description"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fa6399be_64487a5c","line":48,"range":{"start_line":48,"start_character":5,"end_line":48,"end_character":15},"in_reply_to":"1a95cdbc_794a5956","updated":"2016-10-12 17:41:33.000000000","message":"This one doesn\u0027t but the ones where I used \"name-request\" do. I\u0027ll fix it.","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fb739c26ba4950bbf3ef69949f58810fe6aac9b0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":48,"context_line":"   - name: name"},{"line_number":49,"context_line":"   - description: description"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Response Example"},{"line_number":52,"context_line":"----------------"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fa6399be_19ef6be9","line":50,"updated":"2016-10-11 12:39:14.000000000","message":"In this patch, all field of parameters lacks tenant_id and project_id.","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6c05e8f6e33e6eec7a3ae0392719cfa417a86a0e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":48,"context_line":"   - name: name"},{"line_number":49,"context_line":"   - description: description"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Response Example"},{"line_number":52,"context_line":"----------------"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fa6399be_04741e66","line":50,"in_reply_to":"fa6399be_19ef6be9","updated":"2016-10-12 17:41:33.000000000","message":"segments don\u0027t really have their own project_id. Segments are owned by the same tenant as the network. The tenant_id / project_id is currently not visible in responses.","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fb739c26ba4950bbf3ef69949f58810fe6aac9b0","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Creates a segment."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Error response codes: 201,401,400"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Request"},{"line_number":168,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fa6399be_59a643c2","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":33},"updated":"2016-10-11 12:39:14.000000000","message":"Normal response codes: 201\n\nError response codes: 401,400","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fbd63e3dc88b4486cec61a9359c1622291a9eb84","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Creates a segment."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Error response codes: 201,401,400"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Request"},{"line_number":168,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fa6399be_6f4e8797","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":33},"in_reply_to":"fa6399be_44bb7627","updated":"2016-10-13 00:06:42.000000000","message":"I know it and I tried to fix[1] :) but now I think that the bug will be fixed in [2] series. If anything isn\u0027t fixed in [2], I will try to fix it in [1].\n\n[1]: https://review.openstack.org/#/c/349538/\n[2]: https://review.openstack.org/#/q/status:open+project:openstack/neutron-lib+branch:master+topic:bp/neutron-in-tree-api-ref","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6c05e8f6e33e6eec7a3ae0392719cfa417a86a0e","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Creates a segment."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Error response codes: 201,401,400"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Request"},{"line_number":168,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fa6399be_44bb7627","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":33},"in_reply_to":"fa6399be_59a643c2","updated":"2016-10-12 17:41:33.000000000","message":"Good catch, I copied this from networks.inc where it is also wrong. Do you want to post a patch to fix that? You can get credit for finding the mistake there too.","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fb739c26ba4950bbf3ef69949f58810fe6aac9b0","unresolved":false,"context_lines":[{"line_number":174,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":175,"context_line":"   - name: name-request"},{"line_number":176,"context_line":"   - description: description-request"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Request Example"},{"line_number":179,"context_line":"---------------"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fa6399be_5909e394","line":177,"updated":"2016-10-11 12:39:14.000000000","message":"It looks like this field lacks network_id.","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6c05e8f6e33e6eec7a3ae0392719cfa417a86a0e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":175,"context_line":"   - name: name-request"},{"line_number":176,"context_line":"   - description: description-request"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Request Example"},{"line_number":179,"context_line":"---------------"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fa6399be_67e23ca1","line":177,"in_reply_to":"fa6399be_5909e394","updated":"2016-10-12 17:41:33.000000000","message":"You\u0027re right, it needs that. I think I looked over it quickly, saw \"network_type\" and mistakenly moved on thinking it already had network_id.","commit_id":"4e1ee98523c28e49b8efb3afd655a42258214ced"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Normal response codes: 200"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Error response codes: 404,401"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Request"},{"line_number":28,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_08cb4c73","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":26},"updated":"2016-10-12 20:06:26.000000000","message":"nit: space after the comma","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Normal response codes: 200"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Error response codes: 404,401"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Request"},{"line_number":28,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_af2182a1","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":26},"in_reply_to":"fa6399be_08cb4c73","updated":"2016-10-12 23:10:30.000000000","message":"Again, I\u0027d rather be consistent. Nearly every .inc file in this directory does it this way.","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"49c354de77855871f1b25d4e7388b89ee10b65cd","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Normal response codes: 200"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Error response codes: 404,401"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Request"},{"line_number":28,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_2241dd38","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":26},"in_reply_to":"fa6399be_af2182a1","updated":"2016-10-13 16:30:27.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"   - id: segment_id"},{"line_number":40,"context_line":"   - network_id: network_id"},{"line_number":41,"context_line":"   - physical_network: provider:physical_network"},{"line_number":42,"context_line":"   - network_type: network_type"},{"line_number":43,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":44,"context_line":"   - name: name"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_c85eb475","line":41,"range":{"start_line":41,"start_character":5,"end_line":41,"end_character":22},"updated":"2016-10-12 20:06:26.000000000","message":"This is showing as an optional parameter in all the responses. It\u0027s optional in the  request but I do not think it\u0027s optional in the response. A new response variable needs to be introduced for this in the parameters.yaml","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"   - id: segment_id"},{"line_number":40,"context_line":"   - network_id: network_id"},{"line_number":41,"context_line":"   - physical_network: provider:physical_network"},{"line_number":42,"context_line":"   - network_type: network_type"},{"line_number":43,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":44,"context_line":"   - name: name"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_ace18d00","line":41,"range":{"start_line":41,"start_character":5,"end_line":41,"end_character":22},"in_reply_to":"fa6399be_c85eb475","updated":"2016-10-12 23:10:30.000000000","message":"I also did this for consistency. This is the way it is documented in the multi-provider extension API is documented. I\u0027d rather maintain consistency and propose new fixes for these things that get everything.","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   - network_id: network_id"},{"line_number":41,"context_line":"   - physical_network: provider:physical_network"},{"line_number":42,"context_line":"   - network_type: network_type"},{"line_number":43,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":44,"context_line":"   - name: name"},{"line_number":45,"context_line":"   - description: description"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_88cbdc1d","line":43,"range":{"start_line":43,"start_character":5,"end_line":43,"end_character":20},"updated":"2016-10-12 20:06:26.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   - network_id: network_id"},{"line_number":41,"context_line":"   - physical_network: provider:physical_network"},{"line_number":42,"context_line":"   - network_type: network_type"},{"line_number":43,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":44,"context_line":"   - name: name"},{"line_number":45,"context_line":"   - description: description"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_2cee5dec","line":43,"range":{"start_line":43,"start_character":5,"end_line":43,"end_character":20},"in_reply_to":"fa6399be_88cbdc1d","updated":"2016-10-12 23:10:30.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   - network_type: network_type"},{"line_number":43,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":44,"context_line":"   - name: name"},{"line_number":45,"context_line":"   - description: description"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Response Example"},{"line_number":48,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_88303ca0","line":45,"updated":"2016-10-12 20:06:26.000000000","message":"Following attributes are missing:\n is_dynamic\n segment_index\n standard_attr_id\n\nSame needs to be added to the corresponding json","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   - network_type: network_type"},{"line_number":43,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":44,"context_line":"   - name: name"},{"line_number":45,"context_line":"   - description: description"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Response Example"},{"line_number":48,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_0a489c2c","line":45,"in_reply_to":"fa6399be_88303ca0","updated":"2016-10-12 23:10:30.000000000","message":"This is what I\u0027m documenting: https://github.com/openstack/neutron/blob/9806288cd70a73972acd60eecd59e175543baf7e/neutron/extensions/segment.py#L40-L79\n\nNone of the attributes you mention appears in the API specification. I can also attest that they do not appear in the responses on a live system.","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Normal response codes: 200"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Error response codes: 404,403,401,400"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Request"},{"line_number":65,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_88a59cb6","line":62,"range":{"start_line":62,"start_character":22,"end_line":62,"end_character":37},"updated":"2016-10-12 20:06:26.000000000","message":"nit: space after each comma","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Normal response codes: 200"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Error response codes: 404,403,401,400"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Request"},{"line_number":65,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_8f511e11","line":62,"range":{"start_line":62,"start_character":22,"end_line":62,"end_character":37},"in_reply_to":"fa6399be_88a59cb6","updated":"2016-10-12 23:10:30.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":87,"context_line":"   - network_type: network_type"},{"line_number":88,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":89,"context_line":"   - name: name"},{"line_number":90,"context_line":"   - description: description"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Response Example"},{"line_number":93,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_481704ed","line":90,"updated":"2016-10-12 20:06:26.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":87,"context_line":"   - network_type: network_type"},{"line_number":88,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":89,"context_line":"   - name: name"},{"line_number":90,"context_line":"   - description: description"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Response Example"},{"line_number":93,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_ef429a3d","line":90,"in_reply_to":"fa6399be_481704ed","updated":"2016-10-12 23:10:30.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Normal response codes: 204"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Error response codes: 409,404,401"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Request"},{"line_number":110,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_68892826","line":107,"range":{"start_line":107,"start_character":22,"end_line":107,"end_character":33},"updated":"2016-10-12 20:06:26.000000000","message":"nit: space after each comma","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Normal response codes: 204"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Error response codes: 409,404,401"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Request"},{"line_number":110,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_0f3eeeb7","line":107,"range":{"start_line":107,"start_character":22,"end_line":107,"end_character":33},"in_reply_to":"fa6399be_68892826","updated":"2016-10-12 23:10:30.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":112,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"   - segment_id: segment_id-path"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"List segments"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_a89a6061","line":115,"updated":"2016-10-12 20:06:26.000000000","message":"Add a Response section as in [1]\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L292","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":112,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"   - segment_id: segment_id-path"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"List segments"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_acceedb1","line":115,"in_reply_to":"fa6399be_a89a6061","updated":"2016-10-12 23:10:30.000000000","message":"ok","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Request"},{"line_number":133,"context_line":"-------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Response Parameters"},{"line_number":136,"context_line":"-------------------"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_682cc802","line":134,"updated":"2016-10-12 20:06:26.000000000","message":"Add the fields parameter in this section as in [1]\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L39","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Request"},{"line_number":133,"context_line":"-------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Response Parameters"},{"line_number":136,"context_line":"-------------------"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_ec47051b","line":134,"in_reply_to":"fa6399be_682cc802","updated":"2016-10-12 23:10:30.000000000","message":"Done","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":143,"context_line":"   - network_type: network_type"},{"line_number":144,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":145,"context_line":"   - name: name"},{"line_number":146,"context_line":"   - description: description"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Response Example"},{"line_number":149,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_68d4c81f","line":146,"updated":"2016-10-12 20:06:26.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":143,"context_line":"   - network_type: network_type"},{"line_number":144,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":145,"context_line":"   - name: name"},{"line_number":146,"context_line":"   - description: description"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Response Example"},{"line_number":149,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_0a6fbc92","line":146,"in_reply_to":"fa6399be_68d4c81f","updated":"2016-10-12 23:10:30.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Normal response codes: 201"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Error response codes: 401,400"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Request"},{"line_number":166,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_a8834003","line":163,"range":{"start_line":163,"start_character":22,"end_line":163,"end_character":29},"updated":"2016-10-12 20:06:26.000000000","message":"nit: space after comma","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Normal response codes: 201"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Error response codes: 401,400"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Request"},{"line_number":166,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_6f75aa96","line":163,"range":{"start_line":163,"start_character":22,"end_line":163,"end_character":29},"in_reply_to":"fa6399be_a8834003","updated":"2016-10-12 23:10:30.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f8c2f76694a91c6ec168786ecd811b9a8bf86112","unresolved":false,"context_lines":[{"line_number":191,"context_line":"   - network_type: network_type"},{"line_number":192,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":193,"context_line":"   - name: name"},{"line_number":194,"context_line":"   - description: description"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Response Example"},{"line_number":197,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_c8e15400","line":194,"updated":"2016-10-12 20:06:26.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e6e3c52a0802962164dc5a4d32611437a53f9b64","unresolved":false,"context_lines":[{"line_number":191,"context_line":"   - network_type: network_type"},{"line_number":192,"context_line":"   - segmentation_id: provider:segmentation_id"},{"line_number":193,"context_line":"   - name: name"},{"line_number":194,"context_line":"   - description: description"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Response Example"},{"line_number":197,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa6399be_6a0678cf","line":194,"in_reply_to":"fa6399be_c8e15400","updated":"2016-10-12 23:10:30.000000000","message":"ditto","commit_id":"3ce964f9869a5f3c50e0b339040bf1d733b36095"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e8924106ad97782451fc382275448e124283632e","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Request"},{"line_number":138,"context_line":"-------"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"   - fields: fields"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"fa6399be_4f2c6302","line":139,"updated":"2016-10-12 23:55:04.000000000","message":"You miss \".. rest_parameters:: parameters.yaml\".","commit_id":"5092dea24927c6701da3be5ccd568a2fded93cc0"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"afe429952a5bc94b3e3e60fa2ce6de39482abda2","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Request"},{"line_number":138,"context_line":"-------"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"   - fields: fields"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"fa6399be_b2b382e8","line":139,"in_reply_to":"fa6399be_4f2c6302","updated":"2016-10-13 15:41:15.000000000","message":"Yikes! Thanks.","commit_id":"5092dea24927c6701da3be5ccd568a2fded93cc0"}],"api-ref/source/v2/subnets.inc":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"9159ebed6e6cff631e6d8cc42bd988e5b2561ee0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"is created by specifying the ``segment_id`` of a valid segment on the"},{"line_number":77,"context_line":"specified network. A network with subnets associated in this way is"},{"line_number":78,"context_line":"called a routed network. Currently, these are only supported for"},{"line_number":79,"context_line":"provider networks."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Error response codes: 201,404,403,401,400,409"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5a8bc5a2_88cf727e","line":79,"updated":"2016-09-23 09:31:55.000000000","message":"Would it be worth mentioning the all-or-nothing nature of segment/subnet associations here?","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"cc027e63676f1d109a717a2a13effb0894934419","unresolved":false,"context_lines":[{"line_number":76,"context_line":"is created by specifying the ``segment_id`` of a valid segment on the"},{"line_number":77,"context_line":"specified network. A network with subnets associated in this way is"},{"line_number":78,"context_line":"called a routed network. Currently, these are only supported for"},{"line_number":79,"context_line":"provider networks."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Error response codes: 201,404,403,401,400,409"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1a95cdbc_c05d6916","line":79,"in_reply_to":"5a8bc5a2_88cf727e","updated":"2016-10-07 22:33:59.000000000","message":"Yes, I\u0027ll mention it.","commit_id":"f04b30121d694063379099d041f2ffcc01a9a616"}]}