)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"fca355683b80915eb3c252246ae37c4a1ffbf913","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add missing tenant_id/project_id request parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the create metering label detail, \u0027tenant_id\u0027 (now project_id)"},{"line_number":10,"context_line":"is missing as a request parameter. This change add the missing"},{"line_number":11,"context_line":"paramater to the detail. Both \u0027tenant_id\u0027 and \u0027project_id\u0027 are"},{"line_number":12,"context_line":"options in this case as reference in [1]"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a98d1f4_0db016dd","line":10,"range":{"start_line":10,"start_character":47,"end_line":10,"end_character":50},"updated":"2016-09-28 15:52:56.000000000","message":"nit: add -\u003e adds","commit_id":"5b557a365df3fdd8154c72f70e3ba0a3cc681fa4"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"fca355683b80915eb3c252246ae37c4a1ffbf913","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the create metering label detail, \u0027tenant_id\u0027 (now project_id)"},{"line_number":10,"context_line":"is missing as a request parameter. This change add the missing"},{"line_number":11,"context_line":"paramater to the detail. Both \u0027tenant_id\u0027 and \u0027project_id\u0027 are"},{"line_number":12,"context_line":"options in this case as reference in [1]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://review.openstack.org/#/c/372857/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a98d1f4_6dc7da45","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"updated":"2016-09-28 15:52:56.000000000","message":"nit: paramater -\u003e parameter","commit_id":"5b557a365df3fdd8154c72f70e3ba0a3cc681fa4"}],"api-ref/source/v2/metering.inc":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"fca355683b80915eb3c252246ae37c4a1ffbf913","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Request Example"},{"line_number":71,"context_line":"---------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. literalinclude:: samples/metering/metering-label-create-request.json"},{"line_number":74,"context_line":"   :language: javascript"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3a98d1f4_6d6a7a1c","line":73,"range":{"start_line":73,"start_character":37,"end_line":73,"end_character":71},"updated":"2016-09-28 15:52:56.000000000","message":"How about updating the example as well. Probably with only one of the parameters since I think you generally would use one or the other but not both.","commit_id":"5b557a365df3fdd8154c72f70e3ba0a3cc681fa4"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"046544fefac1e070576d9b0a602d933ec32b8e00","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Request Example"},{"line_number":71,"context_line":"---------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. literalinclude:: samples/metering/metering-label-create-request.json"},{"line_number":74,"context_line":"   :language: javascript"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3a98d1f4_0b04747c","line":73,"range":{"start_line":73,"start_character":37,"end_line":73,"end_character":71},"in_reply_to":"3a98d1f4_38f34475","updated":"2016-09-28 18:39:41.000000000","message":"I guess it doesn\u0027t really matter as long as the example includes all the non-optional fields. I don\u0027t think there\u0027s actually anything preventing the inclusion of multiple examples, but assuming only one example is given my guideline would be that it ought to represent the most likely usage. But of course it\u0027s open to opinion what optional fields are most likely to be used.","commit_id":"5b557a365df3fdd8154c72f70e3ba0a3cc681fa4"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c09956388459a01e4a263b091deeb48a1112c729","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Request Example"},{"line_number":71,"context_line":"---------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. literalinclude:: samples/metering/metering-label-create-request.json"},{"line_number":74,"context_line":"   :language: javascript"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3a98d1f4_94234a05","line":73,"range":{"start_line":73,"start_character":37,"end_line":73,"end_character":71},"in_reply_to":"3a98d1f4_6d6a7a1c","updated":"2016-09-28 16:53:22.000000000","message":"@Paul, metering-label-create-request doesn\u0027t need tenant/project. If I understood you correctly, you were talking about response. It\u0027s already done by HenryG in his patchset [1] so I think, there is nothing to do here by Darla.\n\n[1] https://review.openstack.org/#/c/372857/6/api-ref/source/v2/samples/metering/metering-label-create-response.json","commit_id":"5b557a365df3fdd8154c72f70e3ba0a3cc681fa4"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c217f5014665173b7b0527153c245f0b3307e735","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Request Example"},{"line_number":71,"context_line":"---------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. literalinclude:: samples/metering/metering-label-create-request.json"},{"line_number":74,"context_line":"   :language: javascript"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3a98d1f4_38f34475","line":73,"range":{"start_line":73,"start_character":37,"end_line":73,"end_character":71},"in_reply_to":"3a98d1f4_886fad91","updated":"2016-09-28 18:24:46.000000000","message":"@Paul, ah OK. Thanks for pointing my mistake. I was under impression, that this is response (shame on me).  tenant/project are optional, so they\u0027re not required in example. Of course, it can be added, but shouldn\u0027t the example be as least as possible to fulfill correct request?\nWhat do you think?","commit_id":"5b557a365df3fdd8154c72f70e3ba0a3cc681fa4"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"7b5472ee462d5eb5f54c9c99d48c083ba5a55b97","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Request Example"},{"line_number":71,"context_line":"---------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. literalinclude:: samples/metering/metering-label-create-request.json"},{"line_number":74,"context_line":"   :language: javascript"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3a98d1f4_886fad91","line":73,"range":{"start_line":73,"start_character":37,"end_line":73,"end_character":71},"in_reply_to":"3a98d1f4_94234a05","updated":"2016-09-28 17:21:18.000000000","message":"Lines 67 and 68 are specifically listing fields in the request. The tenant_id and project_id fields for the response are already included on lines 82-83. My suggestion is that if these fields are valid in the request that at least one of them ought to be shown in the example. Line 73 is supposed to be an example of using the parameters on lines 63-68 (though it doesn\u0027t have to show every possible combination.","commit_id":"5b557a365df3fdd8154c72f70e3ba0a3cc681fa4"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1d381e07ef7ee03fbbbfb4ee7d107cf60d70cbcf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   - metering_label: metering_label"},{"line_number":65,"context_line":"   - description: description"},{"line_number":66,"context_line":"   - name: name"},{"line_number":67,"context_line":"   - tenant_id: project_id"},{"line_number":68,"context_line":"   - project_id: project_id"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Request Example"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3a98d1f4_2eacb39f","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":26},"updated":"2016-09-29 13:18:43.000000000","message":"Did you intend to use project_id here? Seems like we should note something about tenant_id vs project_id?","commit_id":"307035beb45175e66f13f9f3ea98e90a3822e9bf"},{"author":{"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},"change_message_id":"472b44c6a660425434f01a72fdfd9ed69e123443","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   - metering_label: metering_label"},{"line_number":65,"context_line":"   - description: description"},{"line_number":66,"context_line":"   - name: name"},{"line_number":67,"context_line":"   - tenant_id: project_id"},{"line_number":68,"context_line":"   - project_id: project_id"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Request Example"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3a98d1f4_030dfb8f","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":26},"in_reply_to":"3a98d1f4_2eacb39f","updated":"2016-09-29 18:17:32.000000000","message":"Yes, it is intentional. Similar changes can be found here: https://review.openstack.org/#/c/372857/","commit_id":"307035beb45175e66f13f9f3ea98e90a3822e9bf"}]}