)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"1d09055e9dfcc7a3f0fa6420203fb78529d39886","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa6399be_eb4d409a","updated":"2016-10-12 15:13:15.000000000","message":"I would prefer to see Neutron capitalized when written in paragraph form except when specifically referencing a file name or occurrence in code where the filename or line of code is lowercase. But that\u0027s just a matter of personal preference.","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2f4c300a580e2329467ca5e837e1f8b4605051b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nate Johnston \u003cnate_johnston@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-11 17:01:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Migrate neutron agent extensions to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Migrate neutron agent extensions to neutron-lib.  This includes both the"},{"line_number":10,"context_line":"common abstract objects as well as the l2 and l3-specific objects, for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_bd34cbfb","line":7,"updated":"2016-10-17 14:35:16.000000000","message":"which other projects are using the agent extensions? to be honest I am not sure that this should reside in neutron-lib unless there is very good justification","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"111995d3be50a0270b3cab1b08cf06ea9301af71","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nate Johnston \u003cnate_johnston@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-11 17:01:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Migrate neutron agent extensions to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Migrate neutron agent extensions to neutron-lib.  This includes both the"},{"line_number":10,"context_line":"common abstract objects as well as the l2 and l3-specific objects, for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_4efe9339","line":7,"in_reply_to":"fa6399be_bd34cbfb","updated":"2016-10-17 15:25:42.000000000","message":"neutron-fwaas is using this code in Newton.  I am not sure, but I think networking-sfc might be as well.","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":16934,"name":"Martin Roy","email":"lindycoder@gmail.com","username":"lindycoder"},"change_message_id":"be5579c2085398daafb71202fbfebbaa7ac00ed5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Migrate neutron agent extensions to neutron-lib.  This includes both the"},{"line_number":10,"context_line":"common abstract objects as well as the l2 and l3-specific objects, for"},{"line_number":11,"context_line":"both agent extension and agent extensions manager."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This functionality is used by neutron-fwaas and networking-sfc."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a77a97e_99cca6bc","line":11,"range":{"start_line":11,"start_character":21,"end_line":11,"end_character":49},"updated":"2016-11-18 16:38:40.000000000","message":"Following PS8 the commit message doesn\u0027t seem all relevant anymore","commit_id":"51a1178738de5ef5ff6c025eb01a95c0145bb2b2"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"7577e89d109b4af1a90d2d3892d0ff4350626782","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Migrate neutron agent extensions to neutron-lib.  This includes both the"},{"line_number":10,"context_line":"common abstract objects as well as the l2 and l3-specific objects, for"},{"line_number":11,"context_line":"both agent extension and agent extensions manager."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This functionality is used by neutron-fwaas and networking-sfc."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a77a97e_59d92e56","line":11,"range":{"start_line":11,"start_character":21,"end_line":11,"end_character":49},"in_reply_to":"7a77a97e_99cca6bc","updated":"2016-11-18 16:40:38.000000000","message":"good point.","commit_id":"51a1178738de5ef5ff6c025eb01a95c0145bb2b2"}],"neutron_lib/agent/agent_extension.py":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"1d09055e9dfcc7a3f0fa6420203fb78529d39886","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        No resource (port, policy, router, etc.) handling will be called before"},{"line_number":37,"context_line":"        this method."},{"line_number":38,"context_line":"        \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def consume_api(self, agent_api):"},{"line_number":41,"context_line":"        \"\"\"Consume the AgentAPI instance from the AgentExtensionsManager."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_c64dd173","line":39,"updated":"2016-10-12 15:13:15.000000000","message":"I\u0027m weak on the concept of abstract methods, so this is just a question. Is it correct that initialize is an abstract method but consume_api is not? I see there\u0027s a decorator on one but not the other.","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e3f29cc35332c091ecafac5b9265959e4bdd86d0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        No resource (port, policy, router, etc.) handling will be called before"},{"line_number":37,"context_line":"        this method."},{"line_number":38,"context_line":"        \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def consume_api(self, agent_api):"},{"line_number":41,"context_line":"        \"\"\"Consume the AgentAPI instance from the AgentExtensionsManager."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_811bc31a","line":39,"in_reply_to":"fa6399be_c64dd173","updated":"2016-10-12 15:35:45.000000000","message":"Yes, that\u0027s right--initialize is an abc.abstractmethod but consume_api is not.  This means that if a subclass doesn\u0027t override consume_api, a trace will occur at runtime.\n\nconsume_api is not an abc.abstractmethod for historical reasons.  Extant agent extensions at the time the this method was put in place would have broken if we had made it an abc.abstractmethod.  (Extant agent extensions were known to all have initialize.).","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dac7ebd9978574b445611dc9d85cc1e3b1429fd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_5cd10e22","line":1,"updated":"2016-11-19 00:44:06.000000000","message":"I\u0027d drop the agent_ neutron_lib.agent.extension suffices IMO and neutron_lib.agent.agent_extension seems redundant.","commit_id":"11ce4a5e64878de41c01db7aad4e228b6cccf69d"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"52aefd5c0a48923270a9604511fb44a0c9e68031","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_7f0bea2b","line":1,"in_reply_to":"7a77a97e_53a2b09b","updated":"2016-11-21 17:59:36.000000000","message":"Done","commit_id":"11ce4a5e64878de41c01db7aad4e228b6cccf69d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ab43e734083ba55845b74ff3637d36e3120953dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_53a2b09b","line":1,"in_reply_to":"7a77a97e_5cd10e22","updated":"2016-11-21 14:51:24.000000000","message":"+1. \n\nOn the same token if we don\u0027t plan to have much l2/l3 specific functionality in lib, we could do away with the l2 and l3 sub-packages and just leave neutron_lib/agent/{l2,l3}_extensions.py or something. Not sure how much sense it would make to have the l2/l3 sub-packages with only a single file in each.","commit_id":"11ce4a5e64878de41c01db7aad4e228b6cccf69d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ab43e734083ba55845b74ff3637d36e3120953dd","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param connection: RPC connection that can be reused by the extension"},{"line_number":30,"context_line":"                           to define its RPC endpoints"},{"line_number":31,"context_line":"        :param driver_type: a string that defines the agent type to the"},{"line_number":32,"context_line":"                            extension. Can be used to choose the right backend"},{"line_number":33,"context_line":"                            implementation."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_33029470","line":31,"range":{"start_line":31,"start_character":28,"end_line":31,"end_character":29},"updated":"2016-11-21 14:51:24.000000000","message":"Nit: we *could* clean up some of these docstrings (e.g. Start with CAPS, end with period, include :returns: etc.. but not a show-stopper.","commit_id":"11ce4a5e64878de41c01db7aad4e228b6cccf69d"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"52aefd5c0a48923270a9604511fb44a0c9e68031","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param connection: RPC connection that can be reused by the extension"},{"line_number":30,"context_line":"                           to define its RPC endpoints"},{"line_number":31,"context_line":"        :param driver_type: a string that defines the agent type to the"},{"line_number":32,"context_line":"                            extension. Can be used to choose the right backend"},{"line_number":33,"context_line":"                            implementation."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_151c9576","line":31,"range":{"start_line":31,"start_character":28,"end_line":31,"end_character":29},"in_reply_to":"7a77a97e_33029470","updated":"2016-11-21 17:59:36.000000000","message":"Cleaned up the capitalization; I did not add :returns because none of these are expected to return anything.","commit_id":"11ce4a5e64878de41c01db7aad4e228b6cccf69d"}],"neutron_lib/agent/agent_extensions_manager.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7961bb7603c96861b10a4049454edf098069778e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            # If the agent has provided an agent_api object, this object will"},{"line_number":59,"context_line":"            # be passed to all interested extensions.  This object must be"},{"line_number":60,"context_line":"            # consumed by each such extension before the extension\u0027s"},{"line_number":61,"context_line":"            # intialize() method is called, as the initilization step"},{"line_number":62,"context_line":"            # relies on the agent_api already being available."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"            extension.obj.consume_api(agent_api)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_21a2f74b","line":61,"range":{"start_line":61,"start_character":51,"end_line":61,"end_character":64},"updated":"2016-10-19 12:26:41.000000000","message":"initialization\n\n(Are these misspellings some kind check to see who is paying attention?)","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7961bb7603c96861b10a4049454edf098069778e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            # If the agent has provided an agent_api object, this object will"},{"line_number":59,"context_line":"            # be passed to all interested extensions.  This object must be"},{"line_number":60,"context_line":"            # consumed by each such extension before the extension\u0027s"},{"line_number":61,"context_line":"            # intialize() method is called, as the initilization step"},{"line_number":62,"context_line":"            # relies on the agent_api already being available."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"            extension.obj.consume_api(agent_api)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_c194dbe9","line":61,"range":{"start_line":61,"start_character":14,"end_line":61,"end_character":23},"updated":"2016-10-19 12:26:41.000000000","message":"initialize","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"b8fb8bad8dc15745b467406ce7589387279a81a9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            # If the agent has provided an agent_api object, this object will"},{"line_number":59,"context_line":"            # be passed to all interested extensions.  This object must be"},{"line_number":60,"context_line":"            # consumed by each such extension before the extension\u0027s"},{"line_number":61,"context_line":"            # intialize() method is called, as the initilization step"},{"line_number":62,"context_line":"            # relies on the agent_api already being available."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"            extension.obj.consume_api(agent_api)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_f3c43d41","line":61,"range":{"start_line":61,"start_character":14,"end_line":61,"end_character":23},"in_reply_to":"fa6399be_c194dbe9","updated":"2016-10-19 21:46:16.000000000","message":"Wow that is odd.  Fixed.","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2ecc596a54fa413114057618c700524b1d36778c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"AGENT_EXT_MANAGER_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027extensions\u0027,"},{"line_number":25,"context_line":"                default\u003d[],"},{"line_number":26,"context_line":"                help\u003d_(\u0027Extensions list to use\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_9bf89d4b","line":23,"updated":"2016-10-30 08:23:58.000000000","message":"i am not sure about having this configuration options in neutron-lib.Do we need this or can we add an API call to pass this information?","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"9df445a1bad4cad3d407a84f10eb2f99ad5d2a09","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"AGENT_EXT_MANAGER_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027extensions\u0027,"},{"line_number":25,"context_line":"                default\u003d[],"},{"line_number":26,"context_line":"                help\u003d_(\u0027Extensions list to use\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_c6fb9977","line":23,"in_reply_to":"ba5da102_0c106e58","updated":"2016-11-18 16:32:16.000000000","message":"I decided that the manager doesn\u0027t really need to move to neutron-lib at all, so it can stay in neutron.  That makes these issues moot.","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ec2ccbb6bb71b8d41d8279e31595abf59b29f95a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"AGENT_EXT_MANAGER_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027extensions\u0027,"},{"line_number":25,"context_line":"                default\u003d[],"},{"line_number":26,"context_line":"                help\u003d_(\u0027Extensions list to use\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_d4f8e9c5","line":23,"in_reply_to":"ba5da102_9bf89d4b","updated":"2016-11-01 17:56:45.000000000","message":"I thought that this was a good point, so I moved this code to https://review.openstack.org/#/c/391584/2/neutron/agent/common/config.py - but the problem is that the unit tests to exercise this functionality, like: https://review.openstack.org/#/c/385045/7/neutron_lib/tests/unit/agent/test_l2_agent_extensions_manager.py@27\n\nWe don\u0027t want to have two sources to keep in sync, but for testing the agent we want to avoid the \"oslo_config.cfg.NoSuchGroupError: no such group [agent]\" error if we try to run the tests with this all ripped out.","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f8de36809582ebe705950f772a74e292126b27cd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"AGENT_EXT_MANAGER_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027extensions\u0027,"},{"line_number":25,"context_line":"                default\u003d[],"},{"line_number":26,"context_line":"                help\u003d_(\u0027Extensions list to use\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_0c106e58","line":23,"in_reply_to":"ba5da102_d4f8e9c5","updated":"2016-11-02 18:13:58.000000000","message":"I too am a little concerned with moving opts over quite yet given:\n- A neutron patch [1] in review moves the option in neutron.\n- We have a \"work item\" to hash out an API and try to rehome common opts to lib (see \u0027comomon config options\u0027 in [2]).\n\n\n\n[1] https://review.openstack.org/#/c/348513/\n[2] https://etherpad.openstack.org/p/ocata-neutron-lib-next-steps","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"}],"neutron_lib/agent/extension.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"31d5ab12383fe5650b6e028c943da2a7b5e2e2cb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @abc.abstractmethod"},{"line_number":26,"context_line":"    def initialize(self, connection, driver_type):"},{"line_number":27,"context_line":"        \"\"\"Perform agent core resource extension initialization."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param connection: RPC connection that can be reused by the extension"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a74a57a_61314aec","line":26,"range":{"start_line":26,"start_character":37,"end_line":26,"end_character":48},"updated":"2016-11-24 16:31:53.000000000","message":"should we also define some constants for known driver types?","commit_id":"3cc27afaa1f8086ecaf28c8b4fd74bd3e82e6790"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4e016c62e3d5b8d0fa8fbe12ba85a47cd966a763","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @abc.abstractmethod"},{"line_number":26,"context_line":"    def initialize(self, connection, driver_type):"},{"line_number":27,"context_line":"        \"\"\"Perform agent core resource extension initialization."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param connection: RPC connection that can be reused by the extension"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a74a57a_c040eb09","line":26,"range":{"start_line":26,"start_character":37,"end_line":26,"end_character":48},"in_reply_to":"5a74a57a_221c87c0","updated":"2016-11-28 18:29:24.000000000","message":"If we have a finite set of driver_types that sounds like a good idea. That could probably come as part of this patch, or a subsequent as adding constants isn\u0027t modifying any behavior of the existing public API.","commit_id":"3cc27afaa1f8086ecaf28c8b4fd74bd3e82e6790"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9d64bf06be6f75917d9d1eb03b00bde48eec7968","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @abc.abstractmethod"},{"line_number":26,"context_line":"    def initialize(self, connection, driver_type):"},{"line_number":27,"context_line":"        \"\"\"Perform agent core resource extension initialization."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param connection: RPC connection that can be reused by the extension"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a74a57a_221c87c0","line":26,"range":{"start_line":26,"start_character":37,"end_line":26,"end_character":48},"in_reply_to":"5a74a57a_61314aec","updated":"2016-11-25 17:17:54.000000000","message":"I agree, maybe we can add some in constants.\nBut I guess that would a different PS","commit_id":"3cc27afaa1f8086ecaf28c8b4fd74bd3e82e6790"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"def4f91a0813f3a556b45abfbf98f293d2eb3704","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                           to define its RPC endpoints"},{"line_number":31,"context_line":"        :param driver_type: String that defines the agent type to the"},{"line_number":32,"context_line":"                            extension. Can be used to choose the right backend"},{"line_number":33,"context_line":"                            implementation."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        Called after all extensions have been loaded."},{"line_number":36,"context_line":"        No resource (port, policy, router, etc.) handling will be called before"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a6eadb0_6b08ca28","line":33,"updated":"2016-12-16 13:14:26.000000000","message":"Nit: it\u0027d be nice to doc the returns so it\u0027s obvious to new consumers what return behavior is expected.","commit_id":"c223a6e839a1cf44d93efa42c1da525e1f21b066"}],"neutron_lib/agent/l2/l2_agent_extensions_manager.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7961bb7603c96861b10a4049454edf098069778e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, conf):"},{"line_number":37,"context_line":"        super(L2AgentExtensionsManager,"},{"line_number":38,"context_line":"              self).__init__(conf,"},{"line_number":39,"context_line":"                             L2_AGENT_EXT_MANAGER_NAMESPACE)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def handle_port(self, context, data):"},{"line_number":42,"context_line":"        \"\"\"Notify all agent extensions to handle port.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_fc7b4879","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":60},"updated":"2016-10-19 12:26:41.000000000","message":"Not sure why you changed the formatting from the way it is in neutron core, but OK.","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b2b83f6818d647492efb1bd429aab6656c04871e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, conf):"},{"line_number":37,"context_line":"        super(L2AgentExtensionsManager,"},{"line_number":38,"context_line":"              self).__init__(conf,"},{"line_number":39,"context_line":"                             L2_AGENT_EXT_MANAGER_NAMESPACE)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def handle_port(self, context, data):"},{"line_number":42,"context_line":"        \"\"\"Notify all agent extensions to handle port.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_e7ad5389","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":60},"in_reply_to":"fa6399be_8c0cbe3c","updated":"2016-10-20 01:43:17.000000000","message":"ack.","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"8d39d107713c7f16bcae82e1b028d53f3c50d44c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, conf):"},{"line_number":37,"context_line":"        super(L2AgentExtensionsManager,"},{"line_number":38,"context_line":"              self).__init__(conf,"},{"line_number":39,"context_line":"                             L2_AGENT_EXT_MANAGER_NAMESPACE)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def handle_port(self, context, data):"},{"line_number":42,"context_line":"        \"\"\"Notify all agent extensions to handle port.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_8c0cbe3c","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":60},"in_reply_to":"fa6399be_b3ce4581","updated":"2016-10-20 00:06:02.000000000","message":"Ah, that\u0027s why: http://logs.openstack.org/45/385045/4/check/gate-neutron-lib-pep8-ubuntu-xenial/e26a4f7/console.html#_2016-10-19_22_05_41_093344","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"b8fb8bad8dc15745b467406ce7589387279a81a9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, conf):"},{"line_number":37,"context_line":"        super(L2AgentExtensionsManager,"},{"line_number":38,"context_line":"              self).__init__(conf,"},{"line_number":39,"context_line":"                             L2_AGENT_EXT_MANAGER_NAMESPACE)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def handle_port(self, context, data):"},{"line_number":42,"context_line":"        \"\"\"Notify all agent extensions to handle port.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_b3ce4581","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":60},"in_reply_to":"fa6399be_fc7b4879","updated":"2016-10-19 21:46:16.000000000","message":"Not sure why I did this; I don\u0027t recall specifically messing with it.  Changed it to be like Neutron.","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"}],"neutron_lib/agent/l2_extension.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5e0acb8130c45624b9d9d31d8bce9df7cea3d87f","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def handle_port(self, context, data):"},{"line_number":39,"context_line":"        \"\"\"Agent extension handle a port add/update event."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        This can be called on either create or update, depending on the"},{"line_number":42,"context_line":"        code flow. Thus, it\u0027s this function\u0027s responsibility to check what"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_2de150d1","line":39,"updated":"2016-12-07 19:48:40.000000000","message":"not sure the wording here is good, but at least it\u0027s consistent.","commit_id":"07c398d49323778710912b76aabcb26d31199b1d"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"134552195e1d1d18a48ca6096ae7913e6688df75","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def handle_port(self, context, data):"},{"line_number":39,"context_line":"        \"\"\"Agent extension handle a port add/update event."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        This can be called on either create or update, depending on the"},{"line_number":42,"context_line":"        code flow. Thus, it\u0027s this function\u0027s responsibility to check what"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_6c400435","line":39,"in_reply_to":"3a71b18c_2de150d1","updated":"2016-12-15 20:42:02.000000000","message":"Improved the wording by dropping the extraneous \u0027Agent extension\u0027.","commit_id":"07c398d49323778710912b76aabcb26d31199b1d"}],"neutron_lib/agent/l3/agent_extension.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f9c586d08a914dccfec0edb3b0b94740118fc88e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_dc6b6c1c","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":1},"updated":"2016-11-18 17:03:06.000000000","message":"Nit: remove","commit_id":"cc1e6e7a04134d2d55e515a8e106f66db75d4aad"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"247e17835e89990fa9aaa0bd98add9a6f46a884f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_175dbd14","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":1},"in_reply_to":"7a77a97e_dc6b6c1c","updated":"2016-11-18 17:12:07.000000000","message":"Done","commit_id":"cc1e6e7a04134d2d55e515a8e106f66db75d4aad"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f9c586d08a914dccfec0edb3b0b94740118fc88e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":23,"context_line":"class L3AgentCoreResourceExtension(agent_extension.AgentExtension):"},{"line_number":24,"context_line":"    \"\"\"Define stable abstract interface for l3 agent extensions."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    An agent extension extends the agent core functionality."}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_1c4404b5","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":34},"updated":"2016-11-18 17:03:06.000000000","message":"Clumsy name IMO. We could consider naming it just L3AgentExtension here in its new home.","commit_id":"cc1e6e7a04134d2d55e515a8e106f66db75d4aad"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"247e17835e89990fa9aaa0bd98add9a6f46a884f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":23,"context_line":"class L3AgentCoreResourceExtension(agent_extension.AgentExtension):"},{"line_number":24,"context_line":"    \"\"\"Define stable abstract interface for l3 agent extensions."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    An agent extension extends the agent core functionality."}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_379e39b9","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":34},"in_reply_to":"7a77a97e_1c4404b5","updated":"2016-11-18 17:12:07.000000000","message":"Done","commit_id":"cc1e6e7a04134d2d55e515a8e106f66db75d4aad"}],"neutron_lib/agent/l3/l3_agent_extension.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"214f38e8017f5ee4c563da3e82e4fd302b4ace55","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @abc.abstractmethod"},{"line_number":50,"context_line":"    def delete_router(self, context, data):"},{"line_number":51,"context_line":"        \"\"\"Delete router from agent extension."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param context: rpc context"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_fd4bf184","line":50,"updated":"2016-10-14 07:44:34.000000000","message":"How about exposing the interface for get_router as well?","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"7365cba979f56440f2a4e529f63ac523759d404a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @abc.abstractmethod"},{"line_number":50,"context_line":"    def delete_router(self, context, data):"},{"line_number":51,"context_line":"        \"\"\"Delete router from agent extension."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param context: rpc context"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_fba12b95","line":50,"in_reply_to":"fa6399be_fd4bf184","updated":"2016-10-14 13:59:27.000000000","message":"These are methods that get called when the indicated type of RPC message gets called.  For example:\n\n    neutron server -\u003e RabbitMQ -\u003e neutron agent -\u003e L3AgentExtensionManager.delete_router method -\u003e L3AgentExtension.delete_router\n\nThere should never be a \u0027get router\u0027 call that the neutron server needs to communicate to L3 agent extensions.","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"}],"neutron_lib/agent/l3/l3_agent_extensions_manager.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7961bb7603c96861b10a4049454edf098069778e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"Manage l3 agent extensions.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, conf):"},{"line_number":35,"context_line":"        super(L3AgentExtensionsManager,"},{"line_number":36,"context_line":"              self).__init__(conf,"},{"line_number":37,"context_line":"                             L3_AGENT_EXT_MANAGER_NAMESPACE)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def add_router(self, context, data):"},{"line_number":40,"context_line":"        \"\"\"Notify all agent extensions to add router.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_3cc4e090","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":60},"updated":"2016-10-19 12:26:41.000000000","message":"Why the format change?","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"b8fb8bad8dc15745b467406ce7589387279a81a9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"Manage l3 agent extensions.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, conf):"},{"line_number":35,"context_line":"        super(L3AgentExtensionsManager,"},{"line_number":36,"context_line":"              self).__init__(conf,"},{"line_number":37,"context_line":"                             L3_AGENT_EXT_MANAGER_NAMESPACE)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def add_router(self, context, data):"},{"line_number":40,"context_line":"        \"\"\"Notify all agent extensions to add router.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_f39fdd5c","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":60},"in_reply_to":"fa6399be_3cc4e090","updated":"2016-10-19 21:46:16.000000000","message":"Not sure why I did this; I don\u0027t recall specifically messing with it.  Changed it to be like Neutron.","commit_id":"d2b5aa519d4fa4d4d4b5ff898befb65ca17bc331"}],"neutron_lib/agent/l3_extension.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"31d5ab12383fe5650b6e028c943da2a7b5e2e2cb","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def update_router(self, context, data):"},{"line_number":39,"context_line":"        \"\"\"Handle agent extension for update."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        Called on router update."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a74a57a_e1a9dae0","line":39,"updated":"2016-11-24 16:31:53.000000000","message":"nit: docstrings seem inconsistent between all three hooks. Maybe it\u0027s worth using the same wording for all of them.","commit_id":"3cc27afaa1f8086ecaf28c8b4fd74bd3e82e6790"}],"neutron_lib/constants.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5e0acb8130c45624b9d9d31d8bce9df7cea3d87f","unresolved":false,"context_lines":[{"line_number":304,"context_line":"# Extension driver type for Linux Bridge mech driver"},{"line_number":305,"context_line":"LB_EXTENSION_DRIVER \u003d \u0027linuxbridge\u0027"},{"line_number":306,"context_line":"# Extension driver type for macvtap mech driver"},{"line_number":307,"context_line":"MACVTAP_EXTENSION_DRIVER \u003d \u0027macvtap\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_cdf1bc97","line":307,"updated":"2016-12-07 19:48:40.000000000","message":"there is also something for sr-iov I believe? (sriov?) I haven\u0027t actually seen \u0027macvtap\u0027 used anywhere. Is it?","commit_id":"07c398d49323778710912b76aabcb26d31199b1d"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"134552195e1d1d18a48ca6096ae7913e6688df75","unresolved":false,"context_lines":[{"line_number":304,"context_line":"# Extension driver type for Linux Bridge mech driver"},{"line_number":305,"context_line":"LB_EXTENSION_DRIVER \u003d \u0027linuxbridge\u0027"},{"line_number":306,"context_line":"# Extension driver type for macvtap mech driver"},{"line_number":307,"context_line":"MACVTAP_EXTENSION_DRIVER \u003d \u0027macvtap\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_6c12c458","line":307,"in_reply_to":"3a71b18c_cdf1bc97","updated":"2016-12-15 20:42:02.000000000","message":"It looked to me like most cases the EXTENSION_DRIVER_TYPE is what is passed to L2 agent extension initialization - the L2 OVS agent does this explicitly [1] and it is defined for anything using init_extension_manager from [2].  So I thought it would be good to put all the values of EXTENSION_DRIVER_TYPE into neutron-lib.  \n\nYou\u0027re right, SR-IOV does also do this [3], but it uses the text instead of an EXTENSION_DRIVER_TYPE.  So I added sriov.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L388-L390\n[2] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/agent/_common_agent.py#L175-L180\n[3] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py#L189","commit_id":"07c398d49323778710912b76aabcb26d31199b1d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"19000b924c99ef0c9422a1890a363e580b88c966","unresolved":false,"context_lines":[{"line_number":306,"context_line":"# Extension driver type for macvtap mech driver"},{"line_number":307,"context_line":"MACVTAP_EXTENSION_DRIVER \u003d \u0027macvtap\u0027"},{"line_number":308,"context_line":"# Extension driver type for SR-IOV mech driver"},{"line_number":309,"context_line":"MACVTAP_EXTENSION_DRIVER \u003d \u0027sriov\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a6eadb0_b0d16f25","line":309,"updated":"2016-12-16 13:02:00.000000000","message":"shouldn\u0027t this be SRIOV_EXTENSION_DRIVER ?","commit_id":"67be100b9e539615aecea3827d46ed2e8ac03477"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a02b7ab3b793855dbf59db14dda80e062e467440","unresolved":false,"context_lines":[{"line_number":306,"context_line":"# Extension driver type for macvtap mech driver"},{"line_number":307,"context_line":"MACVTAP_EXTENSION_DRIVER \u003d \u0027macvtap\u0027"},{"line_number":308,"context_line":"# Extension driver type for SR-IOV mech driver"},{"line_number":309,"context_line":"MACVTAP_EXTENSION_DRIVER \u003d \u0027sriov\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a6eadb0_90e9d3b9","line":309,"in_reply_to":"1a6eadb0_b0d16f25","updated":"2016-12-16 13:03:49.000000000","message":"OUCH","commit_id":"67be100b9e539615aecea3827d46ed2e8ac03477"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"def4f91a0813f3a556b45abfbf98f293d2eb3704","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"###################################"},{"line_number":300,"context_line":"# Agent extension related constants"},{"line_number":301,"context_line":"###################################"},{"line_number":302,"context_line":"# Extension driver type for Open vSwitch mech driver"},{"line_number":303,"context_line":"OVS_EXTENSION_DRIVER \u003d \u0027ovs\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a6eadb0_cb38fed5","line":300,"updated":"2016-12-16 13:14:26.000000000","message":"IF these are agent specific constants we could also put them in neutron_lib.agent.constants.py similar to how we did db.constants.","commit_id":"c223a6e839a1cf44d93efa42c1da525e1f21b066"}],"neutron_lib/tests/unit/agent/test_l2_agent_extensions_manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2ecc596a54fa413114057618c700524b1d36778c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_initialize(self):"},{"line_number":35,"context_line":"        connection \u003d object()"},{"line_number":36,"context_line":"        self.manager.initialize(connection, \u0027fake_driver_type\u0027)"},{"line_number":37,"context_line":"        print(\"DEBUG - extensions \u003d \u0027%s\u0027\" % self.manager.extensions)"},{"line_number":38,"context_line":"        ext \u003d self._get_extension()"},{"line_number":39,"context_line":"        ext.initialize.assert_called_once_with(connection, \u0027fake_driver_type\u0027)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_db98551e","line":37,"updated":"2016-10-30 08:23:58.000000000","message":"please remove this","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ec2ccbb6bb71b8d41d8279e31595abf59b29f95a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_initialize(self):"},{"line_number":35,"context_line":"        connection \u003d object()"},{"line_number":36,"context_line":"        self.manager.initialize(connection, \u0027fake_driver_type\u0027)"},{"line_number":37,"context_line":"        print(\"DEBUG - extensions \u003d \u0027%s\u0027\" % self.manager.extensions)"},{"line_number":38,"context_line":"        ext \u003d self._get_extension()"},{"line_number":39,"context_line":"        ext.initialize.assert_called_once_with(connection, \u0027fake_driver_type\u0027)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_f41ecdb9","line":37,"in_reply_to":"ba5da102_db98551e","updated":"2016-11-01 17:56:45.000000000","message":"Done in the next PS","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"9df445a1bad4cad3d407a84f10eb2f99ad5d2a09","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_initialize(self):"},{"line_number":35,"context_line":"        connection \u003d object()"},{"line_number":36,"context_line":"        self.manager.initialize(connection, \u0027fake_driver_type\u0027)"},{"line_number":37,"context_line":"        print(\"DEBUG - extensions \u003d \u0027%s\u0027\" % self.manager.extensions)"},{"line_number":38,"context_line":"        ext \u003d self._get_extension()"},{"line_number":39,"context_line":"        ext.initialize.assert_called_once_with(connection, \u0027fake_driver_type\u0027)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_8634414a","line":37,"in_reply_to":"ba5da102_f41ecdb9","updated":"2016-11-18 16:32:16.000000000","message":"Actually since I\u0027m not moving over the extension managers, these tests all disappear.","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"}],"neutron_lib/tests/unit/agent/test_l3_agent_extensions_manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2ecc596a54fa413114057618c700524b1d36778c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_initialize(self):"},{"line_number":35,"context_line":"        connection \u003d object()"},{"line_number":36,"context_line":"        self.manager.initialize(connection, \u0027fake_driver_type\u0027)"},{"line_number":37,"context_line":"        print(\"DEBUG - extensions \u003d \u0027%s\u0027\" % self.manager.extensions)"},{"line_number":38,"context_line":"        ext \u003d self._get_extension()"},{"line_number":39,"context_line":"        ext.initialize.assert_called_once_with(connection, \u0027fake_driver_type\u0027)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_fb9fd900","line":37,"updated":"2016-10-30 08:23:58.000000000","message":"please remove this","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"9df445a1bad4cad3d407a84f10eb2f99ad5d2a09","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_initialize(self):"},{"line_number":35,"context_line":"        connection \u003d object()"},{"line_number":36,"context_line":"        self.manager.initialize(connection, \u0027fake_driver_type\u0027)"},{"line_number":37,"context_line":"        print(\"DEBUG - extensions \u003d \u0027%s\u0027\" % self.manager.extensions)"},{"line_number":38,"context_line":"        ext \u003d self._get_extension()"},{"line_number":39,"context_line":"        ext.initialize.assert_called_once_with(connection, \u0027fake_driver_type\u0027)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_c642b9ad","line":37,"in_reply_to":"ba5da102_347be5f6","updated":"2016-11-18 16:32:16.000000000","message":"Actually since I\u0027m not moving over the extension managers, these tests all disappear.","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ec2ccbb6bb71b8d41d8279e31595abf59b29f95a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_initialize(self):"},{"line_number":35,"context_line":"        connection \u003d object()"},{"line_number":36,"context_line":"        self.manager.initialize(connection, \u0027fake_driver_type\u0027)"},{"line_number":37,"context_line":"        print(\"DEBUG - extensions \u003d \u0027%s\u0027\" % self.manager.extensions)"},{"line_number":38,"context_line":"        ext \u003d self._get_extension()"},{"line_number":39,"context_line":"        ext.initialize.assert_called_once_with(connection, \u0027fake_driver_type\u0027)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_347be5f6","line":37,"in_reply_to":"ba5da102_fb9fd900","updated":"2016-11-01 17:56:45.000000000","message":"Done in the next PS","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"}],"releasenotes/notes/agent_extensions-2b497ff33c6dc3e8.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f8de36809582ebe705950f772a74e292126b27cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Neutron agent extensions classes are moved from neutron to neutron_lib."},{"line_number":4,"context_line":"    - AgentExtension is moved from neutron.agent to neutron_lib.agent."},{"line_number":5,"context_line":"    - AgentExtensionsManager is moved from neutron.agent to neutron_lib.agent."},{"line_number":6,"context_line":"    - L2AgentExtension is moved from neutron.agent.l2 to neutron_lib.agent.l2."},{"line_number":7,"context_line":"    - L2AgentExtensionsManager is moved from neutron.agent.l2 to neutron_lib.agent.l2."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5da102_674ae327","line":4,"updated":"2016-11-02 18:13:58.000000000","message":"These sub-bullets don\u0027t format out well. See: http://docs-draft.openstack.org/45/385045/7/check/gate-neutron-lib-releasenotes/a5e3514//releasenotes/build/html/unreleased.html","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"9df445a1bad4cad3d407a84f10eb2f99ad5d2a09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Neutron agent extensions classes are moved from neutron to neutron_lib."},{"line_number":4,"context_line":"    - AgentExtension is moved from neutron.agent to neutron_lib.agent."},{"line_number":5,"context_line":"    - AgentExtensionsManager is moved from neutron.agent to neutron_lib.agent."},{"line_number":6,"context_line":"    - L2AgentExtension is moved from neutron.agent.l2 to neutron_lib.agent.l2."},{"line_number":7,"context_line":"    - L2AgentExtensionsManager is moved from neutron.agent.l2 to neutron_lib.agent.l2."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a77a97e_c67ab9bc","line":4,"in_reply_to":"ba5da102_674ae327","updated":"2016-11-18 16:32:16.000000000","message":"Tried a different set of bullet points as suggested by http://docs.openstack.org/developer/reno/usage.html#formatting","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ab43e734083ba55845b74ff3637d36e3120953dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Neutron agent extensions classes are moved from neutron to neutron_lib."},{"line_number":4,"context_line":"    * AgentExtension is moved from neutron.agent.agent_extension to neutron_lib.agent.agent_extension"},{"line_number":5,"context_line":"    * L2AgentExtension is moved from neutron.agent.l2.l2_agent_extension to neutron_lib.agent.l2.agent_extension"},{"line_number":6,"context_line":"    * L3AgentCoreResourceExtension is moved from neutron.agent.l3.l3_agent_extension to neutron_lib.agent.l3.agent_extension"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a77a97e_3348d487","line":4,"updated":"2016-11-21 14:51:24.000000000","message":"This sublist doesn\u0027t appear to be formatting properly on the gen\u0027d HTML: http://docs-draft.openstack.org/45/385045/10/check/gate-neutron-lib-releasenotes/f20ed0a//releasenotes/build/html/unreleased.html","commit_id":"11ce4a5e64878de41c01db7aad4e228b6cccf69d"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"52aefd5c0a48923270a9604511fb44a0c9e68031","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Neutron agent extensions classes are moved from neutron to neutron_lib."},{"line_number":4,"context_line":"    * AgentExtension is moved from neutron.agent.agent_extension to neutron_lib.agent.agent_extension"},{"line_number":5,"context_line":"    * L2AgentExtension is moved from neutron.agent.l2.l2_agent_extension to neutron_lib.agent.l2.agent_extension"},{"line_number":6,"context_line":"    * L3AgentCoreResourceExtension is moved from neutron.agent.l3.l3_agent_extension to neutron_lib.agent.l3.agent_extension"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a77a97e_50245bae","line":4,"in_reply_to":"7a77a97e_3348d487","updated":"2016-11-21 17:59:36.000000000","message":"I removed the list, as I am unable to figure out how to get a good nested list to render.","commit_id":"11ce4a5e64878de41c01db7aad4e228b6cccf69d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ad33f4ff5db6fb53bbecc775407930d74357bf20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Neutron agent extension abstract classes are moved from neutron.agent to neutron_lib.agent"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7a77a97e_f32e1941","line":3,"range":{"start_line":3,"start_character":77,"end_line":3,"end_character":94},"updated":"2016-11-22 17:25:16.000000000","message":"Ditto","commit_id":"3cc27afaa1f8086ecaf28c8b4fd74bd3e82e6790"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ad33f4ff5db6fb53bbecc775407930d74357bf20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Neutron agent extension abstract classes are moved from neutron.agent to neutron_lib.agent"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7a77a97e_3312510a","line":3,"range":{"start_line":3,"start_character":60,"end_line":3,"end_character":73},"updated":"2016-11-22 17:25:16.000000000","message":"Nit: might be nice to use ``formatting`` when referring to source code.","commit_id":"3cc27afaa1f8086ecaf28c8b4fd74bd3e82e6790"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9d64bf06be6f75917d9d1eb03b00bde48eec7968","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Neutron agent extension abstract classes are moved from neutron.agent to neutron_lib.agent"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5a74a57a_a25df77a","line":3,"range":{"start_line":3,"start_character":60,"end_line":3,"end_character":73},"in_reply_to":"7a77a97e_3312510a","updated":"2016-11-25 17:17:54.000000000","message":"+1","commit_id":"3cc27afaa1f8086ecaf28c8b4fd74bd3e82e6790"}],"setup.cfg":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2ecc596a54fa413114057618c700524b1d36778c","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[entry_points]"},{"line_number":50,"context_line":"neutron.agent.l2.extensions \u003d"},{"line_number":51,"context_line":"    dummy_l2 \u003d neutron_lib.tests.unit.agent.dummy_l2_agent_extension:DummyExtension"},{"line_number":52,"context_line":"neutron.agent.l3.extensions \u003d"},{"line_number":53,"context_line":"    dummy_l3 \u003d neutron_lib.tests.unit.agent.dummy_l3_agent_extension:DummyExtension"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"ba5da102_5b8525ab","line":51,"updated":"2016-10-30 08:23:58.000000000","message":"why do we need the tests as dummy entry points?","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ec2ccbb6bb71b8d41d8279e31595abf59b29f95a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[entry_points]"},{"line_number":50,"context_line":"neutron.agent.l2.extensions \u003d"},{"line_number":51,"context_line":"    dummy_l2 \u003d neutron_lib.tests.unit.agent.dummy_l2_agent_extension:DummyExtension"},{"line_number":52,"context_line":"neutron.agent.l3.extensions \u003d"},{"line_number":53,"context_line":"    dummy_l3 \u003d neutron_lib.tests.unit.agent.dummy_l3_agent_extension:DummyExtension"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"ba5da102_9ab21b05","line":51,"in_reply_to":"ba5da102_5b8525ab","updated":"2016-11-01 17:56:45.000000000","message":"We need the dummy agent extensions as entry points because Stevedore requires them to be entry points.  Without having them in here, stevedore will not register them as extensions.  For example, when I commend out these 5 lines and run the tests, I get the following for one of the L3 agent extension tests:\n\n    Captured pythonlogging:\n    ~~~~~~~~~~~~~~~~~~~~~~~\n        2016-11-01 17:52:36,809  WARNING [stevedore.named] Could not load dummy_l3\n        2016-11-01 17:52:36,809     INFO [neutron_lib.agent.agent_extensions_manager] Loaded agent extensions: []\n\nSee also: http://docs.openstack.org/developer/stevedore/tutorial/creating_plugins.html#registering-the-plugins","commit_id":"ea5d38c675291a666d2a1d92d77d5b8cad1771dc"}]}
