)]}'
{"neutron_lib/utils/helpers.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bc037d3f012a5163ba30d6d09b82219aeef1dbc1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            if value not in mappings[key]:"},{"line_number":60,"context_line":"                mappings[key].append(value)"},{"line_number":61,"context_line":"    for key, value in mappings.items():"},{"line_number":62,"context_line":"        if isinstance(value, list) and len(value) \u003d\u003d 1:"},{"line_number":63,"context_line":"            mappings[key] \u003d \u0027\u0027.join(value)"},{"line_number":64,"context_line":"    return mappings"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_fd9b2670","line":62,"range":{"start_line":62,"start_character":29,"end_line":62,"end_character":33},"updated":"2016-10-13 08:40:30.000000000","message":"Here value is asserted to be a list.. BTW, I still didn\u0027t get the reason for this change.. Can you please check the dependent projects on it\u0027s usage","commit_id":"8c2db31e9d746efd9ee04679447d8be142174535"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b0231b955fb7d1dae1e81790fe951751136a1899","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            mappings.setdefault(key, [])"},{"line_number":59,"context_line":"            if value not in mappings[key]:"},{"line_number":60,"context_line":"                mappings[key].append(value)"},{"line_number":61,"context_line":"    for key, value in mappings.items():"},{"line_number":62,"context_line":"        if isinstance(value, list) and len(value) \u003d\u003d 1:"},{"line_number":63,"context_line":"            mappings[key] \u003d \u0027\u0027.join(value)"},{"line_number":64,"context_line":"    return mappings"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_bd776b9e","line":63,"range":{"start_line":61,"start_character":4,"end_line":63,"end_character":42},"updated":"2016-10-17 14:18:07.000000000","message":"Not sure I\u0027m comfortable changing the return structure of this function given we\u0027ve already shipped it with neutron-lib 0.4.0.\n\nWith this change the values are only returned in a list when there are more than 1 value. Without the change, the collected values are always in a list. If we commit this change, consumers expecting the existing behavior may be broken which I see as an API change and we can\u0027t do that without deprecation notice: https://github.com/openstack/neutron-lib/blob/master/doc/source/conventions.rst","commit_id":"787f24e0ba760cbc4df4198d96477dc632f7428a"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1deab1f77e2a940e6d52bc2c5d3412d805bf4b43","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            mappings.setdefault(key, [])"},{"line_number":59,"context_line":"            if value not in mappings[key]:"},{"line_number":60,"context_line":"                mappings[key].append(value)"},{"line_number":61,"context_line":"    for key, value in mappings.items():"},{"line_number":62,"context_line":"        if isinstance(value, list) and len(value) \u003d\u003d 1:"},{"line_number":63,"context_line":"            mappings[key] \u003d \u0027\u0027.join(value)"},{"line_number":64,"context_line":"    return mappings"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_1ca2bc4b","line":63,"range":{"start_line":61,"start_character":4,"end_line":63,"end_character":42},"in_reply_to":"fa6399be_bd776b9e","updated":"2016-10-19 12:36:40.000000000","message":"I agree. This is a backwards incompatible change.","commit_id":"787f24e0ba760cbc4df4198d96477dc632f7428a"}]}