)]}'
{"neutron_lib/api/definitions/core.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0e78dec6d623cd52044912062caada5fe9791f52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa6399be_cc50c461","updated":"2016-10-18 12:41:02.000000000","message":"Does this (file) really belong as part of this patch rather than a patch of its own?","commit_id":"136a6ba48f54edd3561744fb8b5acdbba9da5e6c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a71279c382b1a5080bce5a742821c29d7b54f1d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa6399be_fe6c4738","in_reply_to":"fa6399be_cc50c461","updated":"2016-10-18 15:44:27.000000000","message":"don\u0027t get bogged down to the details, I can make this on its own as part of the API definition effort. I needed this here to validate my effort on migrating context and policy.","commit_id":"136a6ba48f54edd3561744fb8b5acdbba9da5e6c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9983d0ffce591a130c1eeb9a7252e2a57dae470f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":30,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":31,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":32,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: 255},"},{"line_number":33,"context_line":"                 \u0027default\u0027: \u0027\u0027, \u0027is_visible\u0027: True},"},{"line_number":34,"context_line":"        \u0027subnets\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":35,"context_line":"                    \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_227ccbea","line":32,"range":{"start_line":32,"start_character":45,"end_line":32,"end_character":48},"updated":"2016-10-19 04:36:16.000000000","message":"Do we want to use constants.NAME_FIELD_SIZE here?","commit_id":"a5d1556026e1f008ec4a35f705b4c48f7f023c59"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9983d0ffce591a130c1eeb9a7252e2a57dae470f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027status\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":42,"context_line":"                   \u0027is_visible\u0027: True},"},{"line_number":43,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":44,"context_line":"                      \u0027validate\u0027: {\u0027type:string\u0027: 255},"},{"line_number":45,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":46,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":47,"context_line":"        \u0027shared\u0027: {\u0027allow_post\u0027: True,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_42837fcc","line":44,"range":{"start_line":44,"start_character":50,"end_line":44,"end_character":53},"updated":"2016-10-19 04:36:16.000000000","message":"etc.","commit_id":"a5d1556026e1f008ec4a35f705b4c48f7f023c59"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9983d0ffce591a130c1eeb9a7252e2a57dae470f","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    NETWORKS: \u0027network_id\u0027"},{"line_number":245,"context_line":"}"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"# Store plural/singular mappings"},{"line_number":248,"context_line":"PLURALS \u003d {"},{"line_number":249,"context_line":"    NETWORKS: NETWORK,"},{"line_number":250,"context_line":"    PORTS: PORT,"},{"line_number":251,"context_line":"    SUBNETS: SUBNET,"},{"line_number":252,"context_line":"    SUBNETPOOLS: SUBNETPOOL,"},{"line_number":253,"context_line":"    \u0027dns_nameservers\u0027: \u0027dns_nameserver\u0027,"},{"line_number":254,"context_line":"    \u0027host_routes\u0027: \u0027host_route\u0027,"},{"line_number":255,"context_line":"    \u0027allocation_pools\u0027: \u0027allocation_pool\u0027,"},{"line_number":256,"context_line":"    \u0027fixed_ips\u0027: \u0027fixed_ip\u0027,"},{"line_number":257,"context_line":"    \u0027extensions\u0027: \u0027extension\u0027"},{"line_number":258,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_828917cd","line":258,"range":{"start_line":247,"start_character":0,"end_line":258,"end_character":1},"updated":"2016-10-19 04:36:16.000000000","message":"Don\u0027t include these. We intend to adopt https://review.openstack.org/387612 instead.","commit_id":"a5d1556026e1f008ec4a35f705b4c48f7f023c59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fef45d4b685393eb644fab8aa80b030faf147975","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    NETWORKS: \u0027network_id\u0027"},{"line_number":245,"context_line":"}"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"# Store plural/singular mappings"},{"line_number":248,"context_line":"PLURALS \u003d {"},{"line_number":249,"context_line":"    NETWORKS: NETWORK,"},{"line_number":250,"context_line":"    PORTS: PORT,"},{"line_number":251,"context_line":"    SUBNETS: SUBNET,"},{"line_number":252,"context_line":"    SUBNETPOOLS: SUBNETPOOL,"},{"line_number":253,"context_line":"    \u0027dns_nameservers\u0027: \u0027dns_nameserver\u0027,"},{"line_number":254,"context_line":"    \u0027host_routes\u0027: \u0027host_route\u0027,"},{"line_number":255,"context_line":"    \u0027allocation_pools\u0027: \u0027allocation_pool\u0027,"},{"line_number":256,"context_line":"    \u0027fixed_ips\u0027: \u0027fixed_ip\u0027,"},{"line_number":257,"context_line":"    \u0027extensions\u0027: \u0027extension\u0027"},{"line_number":258,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_4f79c3fb","line":258,"range":{"start_line":247,"start_character":0,"end_line":258,"end_character":1},"in_reply_to":"fa6399be_828917cd","updated":"2016-10-19 18:05:55.000000000","message":"Yeah, I noticed, I would like to get a better understanding of where you think these should sit. Because to me these are intrinsically an API concern.","commit_id":"a5d1556026e1f008ec4a35f705b4c48f7f023c59"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a00e632e1cda98af87f5d961900b9bdcee59f3ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fa6399be_bb2541c3","updated":"2016-10-19 20:22:26.000000000","message":"why is this part of this patch. I didn\u0027t see anything in the commit about it. must be missing something obvious...","commit_id":"5923f3f3141badcf5f48993a0761e09fbeba66e6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6d540a36dc3e6b6d7dfaccdd821b16a75ebaa822","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fa6399be_41827253","in_reply_to":"fa6399be_bb2541c3","updated":"2016-10-19 21:01:33.000000000","message":"agreed, I am just doing some skunk work to prove a point, I\u0027ll clean this when I am ready to take the -2 off.","commit_id":"5923f3f3141badcf5f48993a0761e09fbeba66e6"}],"neutron_lib/context.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0e78dec6d623cd52044912062caada5fe9791f52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa6399be_0cc1dc2e","updated":"2016-10-18 12:41:02.000000000","message":"Context is already in lib, but is currently private: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/_context.py","commit_id":"136a6ba48f54edd3561744fb8b5acdbba9da5e6c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a71279c382b1a5080bce5a742821c29d7b54f1d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa6399be_de7143e2","in_reply_to":"fa6399be_0cc1dc2e","updated":"2016-10-18 15:44:27.000000000","message":"It looks like my senility struck again.","commit_id":"136a6ba48f54edd3561744fb8b5acdbba9da5e6c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1341a23a7ff5ea6a17625b3737a38dd1159ab7c0","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# TODO(akamyshnikova): when all places in the code, which use sessions/"},{"line_number":113,"context_line":"# connections will be updated, this won\u0027t be needed"},{"line_number":114,"context_line":"def _get_session(autocommit\u003dTrue, expire_on_commit\u003dFalse, use_slave\u003dFalse):"},{"line_number":115,"context_line":"    \"\"\"Helper method to grab session.\"\"\""},{"line_number":116,"context_line":"    return _context_manager.get_legacy_facade().get_session("},{"line_number":117,"context_line":"        autocommit\u003dautocommit, expire_on_commit\u003dexpire_on_commit,"},{"line_number":118,"context_line":"        use_slave\u003duse_slave)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"@enginefacade.transaction_context_provider"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_5b2de944","line":118,"range":{"start_line":114,"start_character":0,"end_line":118,"end_character":28},"updated":"2016-10-20 13:44:51.000000000","message":"I must have missed it; why are we using/needing this rather than neutron_lib.db._api.get_session()?","commit_id":"8a6ae8fd5a433fee40bb08c1b12213aff6d88bc0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b275a53b5ade6a8d5abd06f0eada593111747b61","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# TODO(akamyshnikova): when all places in the code, which use sessions/"},{"line_number":113,"context_line":"# connections will be updated, this won\u0027t be needed"},{"line_number":114,"context_line":"def _get_session(autocommit\u003dTrue, expire_on_commit\u003dFalse, use_slave\u003dFalse):"},{"line_number":115,"context_line":"    \"\"\"Helper method to grab session.\"\"\""},{"line_number":116,"context_line":"    return _context_manager.get_legacy_facade().get_session("},{"line_number":117,"context_line":"        autocommit\u003dautocommit, expire_on_commit\u003dexpire_on_commit,"},{"line_number":118,"context_line":"        use_slave\u003duse_slave)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"@enginefacade.transaction_context_provider"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6895a0_d9fd1370","line":118,"range":{"start_line":114,"start_character":0,"end_line":118,"end_character":28},"in_reply_to":"fa6399be_5b2de944","updated":"2016-10-20 18:24:48.000000000","message":"Because it needs to change, but I can make the change to db_api.get_session() itself if you prefer.","commit_id":"8a6ae8fd5a433fee40bb08c1b12213aff6d88bc0"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"e57925d7965f1e6fd614c27ac372e8775b9c2d8b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    return _context_manager.get_legacy_facade().get_session("},{"line_number":117,"context_line":"        autocommit\u003dautocommit, expire_on_commit\u003dexpire_on_commit,"},{"line_number":118,"context_line":"        use_slave\u003duse_slave)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"@enginefacade.transaction_context_provider"},{"line_number":122,"context_line":"class ContextBaseWithSession(ContextBase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6895a0_e80e7be4","line":119,"updated":"2016-10-20 20:54:22.000000000","message":"Feels cleaner to me to leave all the sa init goo under db, but that\u0027s just style","commit_id":"8a6ae8fd5a433fee40bb08c1b12213aff6d88bc0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"92c3861776d48342dc70780f07e2325f85fecc55","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    return _context_manager.get_legacy_facade().get_session("},{"line_number":117,"context_line":"        autocommit\u003dautocommit, expire_on_commit\u003dexpire_on_commit,"},{"line_number":118,"context_line":"        use_slave\u003duse_slave)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"@enginefacade.transaction_context_provider"},{"line_number":122,"context_line":"class ContextBaseWithSession(ContextBase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6895a0_c808d794","line":119,"in_reply_to":"da6895a0_e80e7be4","updated":"2016-10-20 21:02:03.000000000","message":"Let me give it a go and see how it goes.","commit_id":"8a6ae8fd5a433fee40bb08c1b12213aff6d88bc0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"43c7993d78a87915ea46852d95400790e38b293b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # NOTE(jamielennox): We maintain these arguments in order for tests"},{"line_number":42,"context_line":"        # that pass arguments positionally."},{"line_number":43,"context_line":"        kwargs.setdefault(\u0027user\u0027, user_id)"},{"line_number":44,"context_line":"        kwargs.setdefault(\u0027tenant\u0027, tenant_id)"},{"line_number":45,"context_line":"        super(ContextBase, self).__init__(is_admin\u003dis_admin, **kwargs)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.user_name \u003d user_name"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_9bce8c2b","line":44,"updated":"2017-01-11 17:44:38.000000000","message":"If project_id is in kwargs it gets passed through to oslo.context and blows up. I think we need to have project_id in our explicit keyword list here and extract tenant from tenant_id or project_id and make sure they are the same if both are specified.\n\nSee the unit test failure on https://review.openstack.org/#/c/394244/20","commit_id":"767e6019e0d4a6804f0ddc32106183cf78b36732"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7b4a62121880f833ca3d7ec61c37ec25e0d61e4e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # NOTE(jamielennox): We maintain these arguments in order for tests"},{"line_number":42,"context_line":"        # that pass arguments positionally."},{"line_number":43,"context_line":"        kwargs.setdefault(\u0027user\u0027, user_id)"},{"line_number":44,"context_line":"        kwargs.setdefault(\u0027tenant\u0027, tenant_id)"},{"line_number":45,"context_line":"        super(ContextBase, self).__init__(is_admin\u003dis_admin, **kwargs)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.user_name \u003d user_name"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_ed119005","line":44,"in_reply_to":"ba5201f7_9bce8c2b","updated":"2017-01-11 23:37:17.000000000","message":"Can do, though I don\u0027t see it here:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/context.py#L46\n\nI am not sure it should be handled in this patch.","commit_id":"767e6019e0d4a6804f0ddc32106183cf78b36732"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"322ca245a71982f58bffb50a308f5121f19736ca","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # NOTE(jamielennox): We maintain these arguments in order for tests"},{"line_number":42,"context_line":"        # that pass arguments positionally."},{"line_number":43,"context_line":"        kwargs.setdefault(\u0027user\u0027, user_id)"},{"line_number":44,"context_line":"        kwargs.setdefault(\u0027tenant\u0027, tenant_id)"},{"line_number":45,"context_line":"        super(ContextBase, self).__init__(is_admin\u003dis_admin, **kwargs)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.user_name \u003d user_name"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_9febc3db","line":44,"in_reply_to":"ba5201f7_9c8af162","updated":"2017-01-12 02:55:55.000000000","message":"I\u0027ll keep an eye on it, thanks!!","commit_id":"767e6019e0d4a6804f0ddc32106183cf78b36732"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"06e3966acc1dc7bd8b61728c4a92fda68521d964","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # NOTE(jamielennox): We maintain these arguments in order for tests"},{"line_number":42,"context_line":"        # that pass arguments positionally."},{"line_number":43,"context_line":"        kwargs.setdefault(\u0027user\u0027, user_id)"},{"line_number":44,"context_line":"        kwargs.setdefault(\u0027tenant\u0027, tenant_id)"},{"line_number":45,"context_line":"        super(ContextBase, self).__init__(is_admin\u003dis_admin, **kwargs)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.user_name \u003d user_name"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_9c8af162","line":44,"in_reply_to":"ba5201f7_ed119005","updated":"2017-01-12 01:58:09.000000000","message":"I submitted https://review.openstack.org/419235","commit_id":"767e6019e0d4a6804f0ddc32106183cf78b36732"}],"neutron_lib/db/_api.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"7623ad2d0056d0fdedaf0ab25d99171644d62b1c","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# TODO(akamyshnikova): when all places in the code, which use sessions/"},{"line_number":46,"context_line":"# connections will be updated, this won\u0027t be needed"},{"line_number":47,"context_line":"def get_session(autocommit\u003dTrue, expire_on_commit\u003dFalse, use_slave\u003dFalse):"},{"line_number":48,"context_line":"    \"\"\"Helper method to grab session.\"\"\""},{"line_number":49,"context_line":"    return _context_manager.get_legacy_facade().get_session("},{"line_number":50,"context_line":"        autocommit\u003dautocommit, expire_on_commit\u003dexpire_on_commit,"}],"source_content_type":"text/x-python","patch_set":15,"id":"da6895a0_5a2a5f7f","line":47,"updated":"2016-10-26 02:07:05.000000000","message":"Probably it would be good to force all interested parties, to update it, by emitting DeprecationWarning.","commit_id":"e3090e031802ea34e7c93174682f25d510f5c945"}],"neutron_lib/policy.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0e78dec6d623cd52044912062caada5fe9791f52","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def init(conf\u003dcfg.CONF, policy_file\u003dNone):"},{"line_number":49,"context_line":"    \"\"\"Init an instance of the Enforcer class.\"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    global _ENFORCER"},{"line_number":52,"context_line":"    if not _ENFORCER:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_2c030078","line":49,"updated":"2016-10-18 12:41:02.000000000","message":"Why are we removing doc strings?","commit_id":"136a6ba48f54edd3561744fb8b5acdbba9da5e6c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a71279c382b1a5080bce5a742821c29d7b54f1d6","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def init(conf\u003dcfg.CONF, policy_file\u003dNone):"},{"line_number":49,"context_line":"    \"\"\"Init an instance of the Enforcer class.\"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    global _ENFORCER"},{"line_number":52,"context_line":"    if not _ENFORCER:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_3e2f9fa2","line":49,"in_reply_to":"fa6399be_2c030078","updated":"2016-10-18 15:44:27.000000000","message":"this is an effect by my ignorance. Let me fix that","commit_id":"136a6ba48f54edd3561744fb8b5acdbba9da5e6c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0e78dec6d623cd52044912062caada5fe9791f52","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def refresh(policy_file\u003dNone):"},{"line_number":58,"context_line":"    \"\"\"Reset policy and init a new instance of Enforcer.\"\"\""},{"line_number":59,"context_line":"    reset()"},{"line_number":60,"context_line":"    init(policy_file\u003dpolicy_file)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_4c083492","line":58,"updated":"2016-10-18 12:41:02.000000000","message":"Why are we removing doc strings?","commit_id":"136a6ba48f54edd3561744fb8b5acdbba9da5e6c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0e78dec6d623cd52044912062caada5fe9791f52","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def get_resource_and_action(action, pluralized\u003dNone):"},{"line_number":64,"context_line":"    \"\"\"Return resource and enforce_attr_based_check(boolean)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    This is done per resource and action extracted from API operation."},{"line_number":67,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_6cfdf86d","line":64,"updated":"2016-10-18 12:41:02.000000000","message":"Why are we removing doc strings?","commit_id":"136a6ba48f54edd3561744fb8b5acdbba9da5e6c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9983d0ffce591a130c1eeb9a7252e2a57dae470f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    validate \u003d attribute.get(\u0027validate\u0027)"},{"line_number":128,"context_line":"    return (validate and isinstance(sub_attr, collections.Iterable) and"},{"line_number":129,"context_line":"            any([k.startswith(\u0027type:dict\u0027) and"},{"line_number":130,"context_line":"                 v for (k, v) in six.iteritems(validate)]))"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"def _build_subattr_match_rule(attr_name, attr, action, target):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_bd3c80c0","line":130,"range":{"start_line":130,"start_character":33,"end_line":130,"end_character":56},"updated":"2016-10-19 04:36:16.000000000","message":"validate.items()","commit_id":"a5d1556026e1f008ec4a35f705b4c48f7f023c59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"246196ee4911969d8c2fd77b20c807c35a318cd0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    validate \u003d attribute.get(\u0027validate\u0027)"},{"line_number":128,"context_line":"    return (validate and isinstance(sub_attr, collections.Iterable) and"},{"line_number":129,"context_line":"            any([k.startswith(\u0027type:dict\u0027) and"},{"line_number":130,"context_line":"                 v for (k, v) in six.iteritems(validate)]))"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"def _build_subattr_match_rule(attr_name, attr, action, target):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_f2351edb","line":130,"range":{"start_line":130,"start_character":33,"end_line":130,"end_character":56},"in_reply_to":"fa6399be_bd3c80c0","updated":"2016-10-19 18:14:14.000000000","message":"I am still on the fence whether or not we need to export the entirety of the plugin engine. Even though the context module relies on a couple of methods, those have already been ported over. The use across the ecosystem looks minimal...perhaps I can split this patch (as I must do anyway) and take baby steps.","commit_id":"a5d1556026e1f008ec4a35f705b4c48f7f023c59"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9983d0ffce591a130c1eeb9a7252e2a57dae470f","unresolved":false,"context_lines":[{"line_number":208,"context_line":"# GenericCheck which was used for validating parent resource ownership."},{"line_number":209,"context_line":"# This will prevent us from having to handling backward compatibility"},{"line_number":210,"context_line":"# for policy.json"},{"line_number":211,"context_line":"# TODO(salv-orlando): Reinstate GenericCheck for simple tenant_id checks"},{"line_number":212,"context_line":"@policy.register(\u0027tenant_id\u0027)"},{"line_number":213,"context_line":"class OwnerCheck(policy.Check):"},{"line_number":214,"context_line":"    \"\"\"Resource ownership check."}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_fd1518e5","line":211,"range":{"start_line":211,"start_character":0,"end_line":211,"end_character":72},"updated":"2016-10-19 04:36:16.000000000","message":"What does this mean? Is it still relevant?","commit_id":"a5d1556026e1f008ec4a35f705b4c48f7f023c59"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9983d0ffce591a130c1eeb9a7252e2a57dae470f","unresolved":false,"context_lines":[{"line_number":209,"context_line":"# This will prevent us from having to handling backward compatibility"},{"line_number":210,"context_line":"# for policy.json"},{"line_number":211,"context_line":"# TODO(salv-orlando): Reinstate GenericCheck for simple tenant_id checks"},{"line_number":212,"context_line":"@policy.register(\u0027tenant_id\u0027)"},{"line_number":213,"context_line":"class OwnerCheck(policy.Check):"},{"line_number":214,"context_line":"    \"\"\"Resource ownership check."},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_ddf134cf","line":212,"range":{"start_line":212,"start_character":18,"end_line":212,"end_character":27},"updated":"2016-10-19 04:36:16.000000000","message":"Change to project_id now, or later?","commit_id":"a5d1556026e1f008ec4a35f705b4c48f7f023c59"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9983d0ffce591a130c1eeb9a7252e2a57dae470f","unresolved":false,"context_lines":[{"line_number":278,"context_line":"            f \u003d getattr(directory.get_plugin(), \u0027get_%s\u0027 % parent_res)"},{"line_number":279,"context_line":"            # f *must* exist, if not found it is better to let neutron"},{"line_number":280,"context_line":"            # explode. Check will be performed with admin context"},{"line_number":281,"context_line":"            context \u003d importutils.import_module(\u0027neutron_lib.context\u0027)"},{"line_number":282,"context_line":"            try:"},{"line_number":283,"context_line":"                data \u003d f(context.get_admin_context(),"},{"line_number":284,"context_line":"                         target[parent_foreign_key],"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_42129f63","line":281,"range":{"start_line":281,"start_character":12,"end_line":281,"end_character":70},"updated":"2016-10-19 04:36:16.000000000","message":"Do things blow up if you import this at the top?","commit_id":"a5d1556026e1f008ec4a35f705b4c48f7f023c59"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9983d0ffce591a130c1eeb9a7252e2a57dae470f","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                                  f)"},{"line_number":298,"context_line":"        match \u003d self.match % target"},{"line_number":299,"context_line":"        if self.kind in creds:"},{"line_number":300,"context_line":"            return match \u003d\u003d six.text_type(creds[self.kind])"},{"line_number":301,"context_line":"        return False"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_bd9e4052","line":300,"range":{"start_line":300,"start_character":28,"end_line":300,"end_character":41},"updated":"2016-10-19 04:36:16.000000000","message":"Darn. What breaks if we just use str?","commit_id":"a5d1556026e1f008ec4a35f705b4c48f7f023c59"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a00e632e1cda98af87f5d961900b9bdcee59f3ac","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    init(policy_file\u003dpolicy_file)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def get_resource_and_action(action, pluralized\u003dNone):"},{"line_number":86,"context_line":"    \"\"\"Return resource and enforce_attr_based_check(boolean)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    This is done per resource and action extracted from API operation."}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_7b3ba9eb","line":85,"updated":"2016-10-19 20:22:26.000000000","message":"any reason we need to make this public? codesearch seems to imply it\u0027s only used by the policy module.\nhttp://codesearch.openstack.org/?q\u003dget_resource_and_action\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"5923f3f3141badcf5f48993a0761e09fbeba66e6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a00e632e1cda98af87f5d961900b9bdcee59f3ac","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    return match_rule, target, credentials"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"def log_rule_list(match_rule):"},{"line_number":349,"context_line":"    if LOG.isEnabledFor(logging.DEBUG):"},{"line_number":350,"context_line":"        rules \u003d _process_rules_list([], match_rule)"},{"line_number":351,"context_line":"        LOG.debug(\"Enforcing rules: %s\", rules)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_9b3ebdd8","line":348,"updated":"2016-10-19 20:22:26.000000000","message":"also might not need to be public:\nhttp://codesearch.openstack.org/?q\u003dlog_rule_list\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"5923f3f3141badcf5f48993a0761e09fbeba66e6"}],"neutron_lib/tests/unit/test_context.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9983d0ffce591a130c1eeb9a7252e2a57dae470f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        ctx.user_id \u003d \u0027Darth\u0027"},{"line_number":44,"context_line":"        ctx.tenant_id \u003d \u0027Vader\u0027"},{"line_number":45,"context_line":"        self.assertEqual(\u0027Darth\u0027, ctx.user_id)"},{"line_number":46,"context_line":"        self.assertEqual(\u0027Vader\u0027, ctx.tenant_id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_neutron_context_create_with_name(self):"},{"line_number":49,"context_line":"        ctx \u003d _context.Context(\u0027user_id\u0027, \u0027tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_3d2eb0fa","side":"PARENT","line":46,"updated":"2016-10-19 04:36:16.000000000","message":"Not sure why you are removing these tests?","commit_id":"0fae18b0fac23fb1525bcc76f576c448b487128d"}],"releasenotes/notes/context-public-6df198b77027c224.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b74ab5958e34bf9bff339528c8dad0a3f09bd622","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The context has been made public. For example:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    .. code-block:: python"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a71b18c_3c6edcc9","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":15},"updated":"2016-12-01 16:08:52.000000000","message":"Nit: might be clearer to use something like::\n\n   The ``context`` module has been...","commit_id":"1b52166934d253849902164f3ae42c418bb92baf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"239fe2affc778ec59c2be8f26dd4d9cd15d619b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The context has been made public. For example:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    .. code-block:: python"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a71b18c_dce4083d","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":15},"in_reply_to":"3a71b18c_3c6edcc9","updated":"2016-12-01 16:10:49.000000000","message":"ack.","commit_id":"1b52166934d253849902164f3ae42c418bb92baf"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b6196387b2531ae349e2b7a3a10581b027f89dbc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``context`` has been made public. For example:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    .. code-block:: python"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ba5201f7_41a3d59e","line":4,"updated":"2016-12-29 16:49:15.000000000","message":"The ``context`` module has ...","commit_id":"767e6019e0d4a6804f0ddc32106183cf78b36732"}]}
