)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"3d0b230612ea8de00913e90476d73e1158dc3fa9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Carver \u003cpcarver@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-20 18:58:31 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Service Function Chaining API Reference"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit copies the Service Function Chaining API documentation from"},{"line_number":10,"context_line":"the networking-sfc repository to the neutron-lib repository and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_67ce1085","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":39},"updated":"2016-10-21 05:17:15.000000000","message":"Is it finalised to move networking-sfc\u0027s stuff\u0027s to neutron-lib. Can you please provide reference to a bug/review link/mail which suggest such change?","commit_id":"1e2dac3eb6e8b2c15631e2a37044c61f910e09c8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"00012c92a9689ca4af0d66738a714ff352c10e38","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Carver \u003cpcarver@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-20 18:58:31 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Service Function Chaining API Reference"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit copies the Service Function Chaining API documentation from"},{"line_number":10,"context_line":"the networking-sfc repository to the neutron-lib repository and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_e7b5c0d0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":39},"in_reply_to":"da6895a0_67ce1085","updated":"2016-10-21 05:18:38.000000000","message":"AFAIU, only neutron specific stuff\u0027s can be ported to neutron-lib.. Sub-projects should host their stuff in their respective tree. Please correct me if wrong..","commit_id":"1e2dac3eb6e8b2c15631e2a37044c61f910e09c8"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5735c507eacd730500e4a332719f7b267968da9f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Carver \u003cpcarver@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-20 18:58:31 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Service Function Chaining API Reference"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit copies the Service Function Chaining API documentation from"},{"line_number":10,"context_line":"the networking-sfc repository to the neutron-lib repository and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_359b54cb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":39},"in_reply_to":"da6895a0_67ce1085","updated":"2016-10-21 12:59:43.000000000","message":"It\u0027s here if I\u0027m reading it correctly:\n\n  http://docs.openstack.org/developer/neutron/stadium/governance.html#checklist\n\nI haven\u0027t created the RFE bug. I guess I should do that soon.","commit_id":"1e2dac3eb6e8b2c15631e2a37044c61f910e09c8"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"20a5b51227ea92c6c08a5043e71efbb390530962","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7a3c09a3_c8518c64","updated":"2017-01-13 17:01:37.000000000","message":"As per [1] we should be using the stadium-implosion topic here, no?\n\n\n[1] https://review.openstack.org/#/c/389397/16/specs/stadium/ocata.rst@246","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"10a4e62a02f55be70189d1081cd473623b4c3451","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7a3c09a3_665364e2","in_reply_to":"7a3c09a3_c8518c64","updated":"2017-01-13 18:43:34.000000000","message":"Done","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"20a5b51227ea92c6c08a5043e71efbb390530962","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Change-Id: I938b50ff6ff6aa50cfa87ae90e9295fd58f60dae"},{"line_number":14,"context_line":"Co-Authored-By: Cathy Zhang \u003ccathy.zhang@huawei.com\u003e"},{"line_number":15,"context_line":"Co-Authored-By: Louis Fourie \u003clouis.fourie@huawei.com\u003e"},{"line_number":16,"context_line":"Depends-On: I1a61e614fa2d8280910cf5af5bd9d8e25ebbbc8a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a3c09a3_a8db60ec","line":16,"updated":"2017-01-13 17:01:37.000000000","message":"Only use depends-on for changes in other repos. For depends in same repo just rebase atop them.","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"10a4e62a02f55be70189d1081cd473623b4c3451","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Change-Id: I938b50ff6ff6aa50cfa87ae90e9295fd58f60dae"},{"line_number":14,"context_line":"Co-Authored-By: Cathy Zhang \u003ccathy.zhang@huawei.com\u003e"},{"line_number":15,"context_line":"Co-Authored-By: Louis Fourie \u003clouis.fourie@huawei.com\u003e"},{"line_number":16,"context_line":"Depends-On: I1a61e614fa2d8280910cf5af5bd9d8e25ebbbc8a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a3c09a3_e65d94ea","line":16,"in_reply_to":"7a3c09a3_a8db60ec","updated":"2017-01-13 18:43:34.000000000","message":"Done","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"12955b36ff32f543d993240a445b83267e784442","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5a3905b3_0c1a7d6e","updated":"2017-01-20 21:04:46.000000000","message":"Looks like we lost the stadium-implosion topic.","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b7b77499f86bb2a89395bbe2c3057b0c1a4b2903","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ba2be162_79c78512","updated":"2017-03-01 12:32:29.000000000","message":"Looks like we lost the \u0027stadium-implosion\u0027 topic again.","commit_id":"5ec2d3a402a2c61f303b135c69bf5097c80812af"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"45e18fcfc54c033825fe5820ba40c7905467d1f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ba2be162_b4f45787","in_reply_to":"ba2be162_1cf757d4","updated":"2017-03-02 15:58:16.000000000","message":"I\u0027ll try the -t. I can\u0027t rename the local branch because then I would lose separation of the API reference change from the API definition change. I\u0027m now down to two stadium-implosion changes, but before the BGPVPN ones merged I had four separate branches that were all related to stadium-implosion.","commit_id":"5ec2d3a402a2c61f303b135c69bf5097c80812af"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"f5169b56001f800d15b5847a82e17f7c66d142a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ba2be162_1cf757d4","in_reply_to":"ba2be162_79c78512","updated":"2017-03-01 12:42:42.000000000","message":"Paul, you can do the following on every submission or rename the name of your local branch:\n\n git review -t stadium-implosion","commit_id":"5ec2d3a402a2c61f303b135c69bf5097c80812af"}],"api-ref/source/v2/index.rst":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"33e0a5d28c1be97928cc2c033e84241948c5771a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Service Function Chaining"},{"line_number":62,"context_line":"#########################"},{"line_number":63,"context_line":".. include:: sfc-overview.inc"},{"line_number":64,"context_line":".. include:: sfc-chains.inc"},{"line_number":65,"context_line":".. include:: sfc-classifiers.inc"},{"line_number":66,"context_line":".. include:: sfc-port-pair-groups.inc"},{"line_number":67,"context_line":".. include:: sfc-port-pairs.inc"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a3905b3_c79acb6d","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":32},"updated":"2017-01-23 15:46:58.000000000","message":"Should be:\nsfc-port-chains\nsfc-flow-classifiers","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"0bbb3a1eff7700945173375991d065cd476afc14","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Service Function Chaining"},{"line_number":62,"context_line":"#########################"},{"line_number":63,"context_line":".. include:: sfc-overview.inc"},{"line_number":64,"context_line":".. include:: sfc-chains.inc"},{"line_number":65,"context_line":".. include:: sfc-classifiers.inc"},{"line_number":66,"context_line":".. include:: sfc-port-pair-groups.inc"},{"line_number":67,"context_line":".. include:: sfc-port-pairs.inc"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a3905b3_b6ebfc11","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":32},"in_reply_to":"5a3905b3_c79acb6d","updated":"2017-01-24 14:42:06.000000000","message":"Done","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":53,"context_line":"##########################"},{"line_number":54,"context_line":"Load Balancer as a Service"},{"line_number":55,"context_line":"##########################"},{"line_number":56,"context_line":".. include:: lbaas-v2.inc"},{"line_number":57,"context_line":".. include:: lbaas-v1.inc"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a461143_5309dadc","side":"PARENT","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":25},"updated":"2017-02-02 07:21:08.000000000","message":"nit: It\u0027s better not to change the line because it\u0027s not related to this patch.","commit_id":"cf72bd10e60b172f03be6db2001e36b2cc2d7304"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":53,"context_line":"##########################"},{"line_number":54,"context_line":"Load Balancer as a Service"},{"line_number":55,"context_line":"##########################"},{"line_number":56,"context_line":".. include:: lbaas-v2.inc"},{"line_number":57,"context_line":".. include:: lbaas-v1.inc"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_516c949c","side":"PARENT","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":25},"in_reply_to":"3a461143_5309dadc","updated":"2017-02-03 00:11:02.000000000","message":"That was pulled in via rebase. I moved v1 above v2 because that just obviously the right order. If it is really a problem I can undo it, but I think that would be stupid.","commit_id":"cf72bd10e60b172f03be6db2001e36b2cc2d7304"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"36836d9c37e48fd0c24bd00c7a8559f76bfe0da7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"##########################"},{"line_number":54,"context_line":"Load Balancer as a Service"},{"line_number":55,"context_line":"##########################"},{"line_number":56,"context_line":".. include:: lbaas-v2.inc"},{"line_number":57,"context_line":".. include:: lbaas-v1.inc"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1a430d35_46a5a502","side":"PARENT","line":56,"updated":"2017-02-03 13:32:35.000000000","message":"Unrelated change, but OK.","commit_id":"cf72bd10e60b172f03be6db2001e36b2cc2d7304"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"2b680f94474799e9908f9f153f9115df11d2e7f7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"##########################"},{"line_number":54,"context_line":"Load Balancer as a Service"},{"line_number":55,"context_line":"##########################"},{"line_number":56,"context_line":".. include:: lbaas-v2.inc"},{"line_number":57,"context_line":".. include:: lbaas-v1.inc"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1a430d35_1c0a0ad3","side":"PARENT","line":56,"in_reply_to":"1a430d35_46a5a502","updated":"2017-02-03 15:05:21.000000000","message":"That came in due to rebasing this change.","commit_id":"cf72bd10e60b172f03be6db2001e36b2cc2d7304"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7a77a1cd9cebd73edabe4e4c7ecc79b2fbca0cea","unresolved":false,"context_lines":[{"line_number":3602,"context_line":"  in: body"},{"line_number":3603,"context_line":"  required: false"},{"line_number":3604,"context_line":"  type: object"},{"line_number":3605,"context_line":"sfc_chain_id:"},{"line_number":3606,"context_line":"  description: |"},{"line_number":3607,"context_line":"      The UUID of the port-chain."},{"line_number":3608,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5da102_1b7589ca","line":3605,"range":{"start_line":3605,"start_character":0,"end_line":3605,"end_character":13},"updated":"2016-10-28 08:22:36.000000000","message":"I think this variable is exactly same to one defined @L172","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d19103eaf09fd8c9468dda2f207084726bdd4842","unresolved":false,"context_lines":[{"line_number":3602,"context_line":"  in: body"},{"line_number":3603,"context_line":"  required: false"},{"line_number":3604,"context_line":"  type: object"},{"line_number":3605,"context_line":"sfc_chain_id:"},{"line_number":3606,"context_line":"  description: |"},{"line_number":3607,"context_line":"      The UUID of the port-chain."},{"line_number":3608,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5da102_83cccf36","line":3605,"range":{"start_line":3605,"start_character":0,"end_line":3605,"end_character":13},"in_reply_to":"ba5da102_1b7589ca","updated":"2016-10-28 09:33:18.000000000","message":"it is, but here it appears in the body and on line 172 it appears in the path. Discussing this with the docs team, elsewhere a convention of prefixing the parameter name with \"path_\" or \"body_\" has been used (but the convention is not documented and was only used in cases of conflict.)\n\nIt seems like it would be a good idea for each stadium sub-project to have a separate parameters.yaml file and adopt the convention instead of the convention I used of prefixing with \"sfc\" or \"bgpvpn\" to group the sub-project related parameters.","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e3add0d2048d31b0ffa171b7f7251de475e59506","unresolved":false,"context_lines":[{"line_number":3969,"context_line":"  type: dict"},{"line_number":3970,"context_line":"sfc_port_chain_id_body:"},{"line_number":3971,"context_line":"  description: |"},{"line_number":3972,"context_line":"      The UUID of the port-chain."},{"line_number":3973,"context_line":"  in: body"},{"line_number":3974,"context_line":"  required: true"},{"line_number":3975,"context_line":"  type: uuid"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a71b18c_7f900696","line":3972,"range":{"start_line":3972,"start_character":4,"end_line":3972,"end_character":6},"updated":"2016-12-09 06:19:33.000000000","message":"super-nit: extra spaces","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"fd3516d4f618fc5c58907da9d06be99d4390ba31","unresolved":false,"context_lines":[{"line_number":3969,"context_line":"  type: dict"},{"line_number":3970,"context_line":"sfc_port_chain_id_body:"},{"line_number":3971,"context_line":"  description: |"},{"line_number":3972,"context_line":"      The UUID of the port-chain."},{"line_number":3973,"context_line":"  in: body"},{"line_number":3974,"context_line":"  required: true"},{"line_number":3975,"context_line":"  type: uuid"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a6eadb0_ff9681ee","line":3972,"range":{"start_line":3972,"start_character":4,"end_line":3972,"end_character":6},"in_reply_to":"3a71b18c_7f900696","updated":"2016-12-15 16:09:18.000000000","message":"Done","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"c5768f5fcb0608015fc798a9261ef036b16eb513","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  in: path"},{"line_number":206,"context_line":"  required: false"},{"line_number":207,"context_line":"  type: string"},{"line_number":208,"context_line":"sfc_flow_classifier_id_path:"},{"line_number":209,"context_line":"  description: |"},{"line_number":210,"context_line":"      The UUID of the flow-classifier."},{"line_number":211,"context_line":"  in: path"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5201f7_dc096adf","line":208,"range":{"start_line":208,"start_character":0,"end_line":208,"end_character":27},"updated":"2016-12-29 17:47:46.000000000","message":"Can you please rename the path variable as sfc_flow_classifier_id-path instead of sfc_flow_classifier_id_path? So that it\u0027s consistent with the rest of the path variables. Same for all the newly added path variables.","commit_id":"1b48064e4b80a9f1c87f6a48f4231f9caa954245"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"e556583d1b6ef2f7f7652451484a2220ea55cfa1","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  in: path"},{"line_number":206,"context_line":"  required: false"},{"line_number":207,"context_line":"  type: string"},{"line_number":208,"context_line":"sfc_flow_classifier_id_path:"},{"line_number":209,"context_line":"  description: |"},{"line_number":210,"context_line":"      The UUID of the flow-classifier."},{"line_number":211,"context_line":"  in: path"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5201f7_04de186d","line":208,"range":{"start_line":208,"start_character":0,"end_line":208,"end_character":27},"in_reply_to":"ba5201f7_dc096adf","updated":"2017-01-02 16:11:47.000000000","message":"Done","commit_id":"1b48064e4b80a9f1c87f6a48f4231f9caa954245"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"c5768f5fcb0608015fc798a9261ef036b16eb513","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  type: string"},{"line_number":208,"context_line":"sfc_flow_classifier_id_path:"},{"line_number":209,"context_line":"  description: |"},{"line_number":210,"context_line":"      The UUID of the flow-classifier."},{"line_number":211,"context_line":"  in: path"},{"line_number":212,"context_line":"  required: true"},{"line_number":213,"context_line":"  type: uuid"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5201f7_5c93baa3","line":210,"range":{"start_line":210,"start_character":10,"end_line":210,"end_character":14},"updated":"2016-12-29 17:47:46.000000000","message":"Can you please change all the UUID\u0027s to ID for these newly added parameters?","commit_id":"1b48064e4b80a9f1c87f6a48f4231f9caa954245"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"e556583d1b6ef2f7f7652451484a2220ea55cfa1","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  type: string"},{"line_number":208,"context_line":"sfc_flow_classifier_id_path:"},{"line_number":209,"context_line":"  description: |"},{"line_number":210,"context_line":"      The UUID of the flow-classifier."},{"line_number":211,"context_line":"  in: path"},{"line_number":212,"context_line":"  required: true"},{"line_number":213,"context_line":"  type: uuid"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5201f7_e4b914eb","line":210,"range":{"start_line":210,"start_character":10,"end_line":210,"end_character":14},"in_reply_to":"ba5201f7_5c93baa3","updated":"2017-01-02 16:11:47.000000000","message":"Done","commit_id":"1b48064e4b80a9f1c87f6a48f4231f9caa954245"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"c5768f5fcb0608015fc798a9261ef036b16eb513","unresolved":false,"context_lines":[{"line_number":3895,"context_line":"  in: body"},{"line_number":3896,"context_line":"  required: false"},{"line_number":3897,"context_line":"  type: object"},{"line_number":3898,"context_line":"sfc_chain_parameters:"},{"line_number":3899,"context_line":"  description: |"},{"line_number":3900,"context_line":"    A dictionary of chain parameters."},{"line_number":3901,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5201f7_9c00c2ac","line":3898,"range":{"start_line":3898,"start_character":0,"end_line":3898,"end_character":20},"updated":"2016-12-29 17:47:46.000000000","message":"The naming convention is \"\u003cresource-name\u003e-\u003cfield-name\u003e\", so it will be \u0027sfc-chain_parameters\". Same for all the newly added parameters for sfc.","commit_id":"1b48064e4b80a9f1c87f6a48f4231f9caa954245"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"e556583d1b6ef2f7f7652451484a2220ea55cfa1","unresolved":false,"context_lines":[{"line_number":3895,"context_line":"  in: body"},{"line_number":3896,"context_line":"  required: false"},{"line_number":3897,"context_line":"  type: object"},{"line_number":3898,"context_line":"sfc_chain_parameters:"},{"line_number":3899,"context_line":"  description: |"},{"line_number":3900,"context_line":"    A dictionary of chain parameters."},{"line_number":3901,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5201f7_c4d170cf","line":3898,"range":{"start_line":3898,"start_character":0,"end_line":3898,"end_character":20},"in_reply_to":"ba5201f7_9c00c2ac","updated":"2017-01-02 16:11:47.000000000","message":"Done","commit_id":"1b48064e4b80a9f1c87f6a48f4231f9caa954245"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4a1f2c340902ad37670fbf6ea71fac485e601332","unresolved":false,"context_lines":[{"line_number":210,"context_line":"      The ID of the flow-classifier."},{"line_number":211,"context_line":"  in: path"},{"line_number":212,"context_line":"  required: true"},{"line_number":213,"context_line":"  type: uuid"},{"line_number":214,"context_line":"sfc-port_chain_id-path:"},{"line_number":215,"context_line":"  description: |"},{"line_number":216,"context_line":"      The ID of the port-chain."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_fa718fa9","line":213,"range":{"start_line":213,"start_character":8,"end_line":213,"end_character":12},"updated":"2017-01-03 17:49:39.000000000","message":"Looks like all other api-refs use \u0027string\u0027 as the type for UUIDs. Is this different?","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"60c7071115837ce763aca91e68e947139ede4995","unresolved":false,"context_lines":[{"line_number":210,"context_line":"      The ID of the flow-classifier."},{"line_number":211,"context_line":"  in: path"},{"line_number":212,"context_line":"  required: true"},{"line_number":213,"context_line":"  type: uuid"},{"line_number":214,"context_line":"sfc-port_chain_id-path:"},{"line_number":215,"context_line":"  description: |"},{"line_number":216,"context_line":"      The ID of the port-chain."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_5f43e56b","line":213,"range":{"start_line":213,"start_character":8,"end_line":213,"end_character":12},"in_reply_to":"ba5201f7_fa718fa9","updated":"2017-01-13 05:11:15.000000000","message":"wishful thinking. I\u0027ll change it to string, but I wish that more specific types were supported. Any string that is not a UUID will be be invalid and cause a failure regardless of whether the API ref claims that the type is string.\n\nBetter quality API documentation would tell the developer more accurately what is and isn\u0027t allowed.","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ad4bfbf243c1b5b9dfcde5ec9e8c7341fd699d0d","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  type: string"},{"line_number":208,"context_line":"sfc-flow_classifier_id-path:"},{"line_number":209,"context_line":"  description: |"},{"line_number":210,"context_line":"      The ID of the flow-classifier."},{"line_number":211,"context_line":"  in: path"},{"line_number":212,"context_line":"  required: true"},{"line_number":213,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a3905b3_44d56bb7","line":210,"range":{"start_line":210,"start_character":10,"end_line":210,"end_character":12},"updated":"2017-01-20 05:50:11.000000000","message":"Is ID and UUID are the same?","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"79800ed9d42421ac55da1a37db834a96c0d5a7c0","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  type: string"},{"line_number":208,"context_line":"sfc-flow_classifier_id-path:"},{"line_number":209,"context_line":"  description: |"},{"line_number":210,"context_line":"      The ID of the flow-classifier."},{"line_number":211,"context_line":"  in: path"},{"line_number":212,"context_line":"  required: true"},{"line_number":213,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a3905b3_01ffb134","line":210,"range":{"start_line":210,"start_character":10,"end_line":210,"end_character":12},"in_reply_to":"5a3905b3_44d56bb7","updated":"2017-01-20 17:57:52.000000000","message":"I believe so. Anindita Das\u0027 comment on PS7 asked for UUID to be changed to ID. I assumed that was because of some broader effort to standardize the terminology since I\u0027ve seen that comment on other changes as well.","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ad4bfbf243c1b5b9dfcde5ec9e8c7341fd699d0d","unresolved":false,"context_lines":[{"line_number":3918,"context_line":"      This parameter needs a better description. For now \"mpls\" is the only"},{"line_number":3919,"context_line":"      valid value."},{"line_number":3920,"context_line":"  in: body"},{"line_number":3921,"context_line":"  required: true"},{"line_number":3922,"context_line":"  type: string"},{"line_number":3923,"context_line":"sfc-destination_ip_prefix:"},{"line_number":3924,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a3905b3_44164b56","line":3921,"range":{"start_line":3921,"start_character":2,"end_line":3921,"end_character":16},"updated":"2017-01-20 05:50:11.000000000","message":"Is this mandatory?","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"79800ed9d42421ac55da1a37db834a96c0d5a7c0","unresolved":false,"context_lines":[{"line_number":3918,"context_line":"      This parameter needs a better description. For now \"mpls\" is the only"},{"line_number":3919,"context_line":"      valid value."},{"line_number":3920,"context_line":"  in: body"},{"line_number":3921,"context_line":"  required: true"},{"line_number":3922,"context_line":"  type: string"},{"line_number":3923,"context_line":"sfc-destination_ip_prefix:"},{"line_number":3924,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a3905b3_fc640ce6","line":3921,"range":{"start_line":3921,"start_character":2,"end_line":3921,"end_character":16},"in_reply_to":"5a3905b3_44164b56","updated":"2017-01-20 17:57:52.000000000","message":"I don\u0027t think so. I believe it defaults to \"None\" if not present. I think I\u0027ll have to add a \"-request\" variant. The tooling to generate the API docs has some rough edges. It doesn\u0027t make sense for a field in the response to be marked as \"Optional\" in the documentation, so we need to variants of the parameter in order to show it as optional in the request but not optional in the response (since the server always provides it.","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ad4bfbf243c1b5b9dfcde5ec9e8c7341fd699d0d","unresolved":false,"context_lines":[{"line_number":3952,"context_line":"  type: string"},{"line_number":3953,"context_line":"sfc-flow_classifier:"},{"line_number":3954,"context_line":"  description: |"},{"line_number":3955,"context_line":"    A ``flow_classifier`` object."},{"line_number":3956,"context_line":"  in: body"},{"line_number":3957,"context_line":"  required: true"},{"line_number":3958,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a3905b3_c4731b14","line":3955,"range":{"start_line":3955,"start_character":4,"end_line":3955,"end_character":33},"updated":"2017-01-20 05:50:11.000000000","message":"What is a FC object?","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ad4bfbf243c1b5b9dfcde5ec9e8c7341fd699d0d","unresolved":false,"context_lines":[{"line_number":3956,"context_line":"  in: body"},{"line_number":3957,"context_line":"  required: true"},{"line_number":3958,"context_line":"  type: object"},{"line_number":3959,"context_line":"sfc-flow_classifier_id:"},{"line_number":3960,"context_line":"  description: |"},{"line_number":3961,"context_line":"      The ID of the flow-classifier."},{"line_number":3962,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a3905b3_a44fefbb","line":3959,"range":{"start_line":3959,"start_character":0,"end_line":3959,"end_character":22},"updated":"2017-01-20 05:50:11.000000000","message":"How this different from sfc-flow_classifier_id-path? Description for both looks the same.","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ad4bfbf243c1b5b9dfcde5ec9e8c7341fd699d0d","unresolved":false,"context_lines":[{"line_number":3995,"context_line":"  type: string"},{"line_number":3996,"context_line":"sfc-logical_destination_port:"},{"line_number":3997,"context_line":"  description: |"},{"line_number":3998,"context_line":"    The ID of the destination logical port."},{"line_number":3999,"context_line":"  in: body"},{"line_number":4000,"context_line":"  required: false"},{"line_number":4001,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a3905b3_e49577e4","line":3998,"range":{"start_line":3998,"start_character":8,"end_line":3998,"end_character":10},"updated":"2017-01-20 05:50:11.000000000","message":"@L3979 we have used UUID, here we have used ID... Is it intentional? To me both looks the same.. If so, then can we follow a uniform nomenclature?","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":4436,"context_line":"    The destination IP prefix."},{"line_number":4437,"context_line":"  in: body"},{"line_number":4438,"context_line":"  required: false"},{"line_number":4439,"context_line":"  type: cidr"},{"line_number":4440,"context_line":"sfc-destination_port_range_max:"},{"line_number":4441,"context_line":"  description: |"},{"line_number":4442,"context_line":"    Maximum destination protocol port."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a461143_96809048","line":4439,"range":{"start_line":4439,"start_character":8,"end_line":4439,"end_character":12},"updated":"2017-02-02 07:21:08.000000000","message":"string","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":4436,"context_line":"    The destination IP prefix."},{"line_number":4437,"context_line":"  in: body"},{"line_number":4438,"context_line":"  required: false"},{"line_number":4439,"context_line":"  type: cidr"},{"line_number":4440,"context_line":"sfc-destination_port_range_max:"},{"line_number":4441,"context_line":"  description: |"},{"line_number":4442,"context_line":"    Maximum destination protocol port."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a430d35_311d4810","line":4439,"range":{"start_line":4439,"start_character":8,"end_line":4439,"end_character":12},"in_reply_to":"3a461143_96809048","updated":"2017-02-03 00:11:02.000000000","message":"curse this feeble-minded documentation generation system that limits us to inferior specification of types.\n\nDone.","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":4478,"context_line":"      List of flow-classifier IDs."},{"line_number":4479,"context_line":"  in: body"},{"line_number":4480,"context_line":"  required: false"},{"line_number":4481,"context_line":"  type: list"},{"line_number":4482,"context_line":"sfc-flow_classifiers-object:"},{"line_number":4483,"context_line":"  description: |"},{"line_number":4484,"context_line":"      A list of objects representing flow classifiers."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a461143_d692189f","line":4481,"range":{"start_line":4481,"start_character":8,"end_line":4481,"end_character":12},"updated":"2017-02-02 07:21:08.000000000","message":"array","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":4478,"context_line":"      List of flow-classifier IDs."},{"line_number":4479,"context_line":"  in: body"},{"line_number":4480,"context_line":"  required: false"},{"line_number":4481,"context_line":"  type: list"},{"line_number":4482,"context_line":"sfc-flow_classifiers-object:"},{"line_number":4483,"context_line":"  description: |"},{"line_number":4484,"context_line":"      A list of objects representing flow classifiers."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a430d35_51ad7487","line":4481,"range":{"start_line":4481,"start_character":8,"end_line":4481,"end_character":12},"in_reply_to":"3a461143_d692189f","updated":"2017-02-03 00:11:02.000000000","message":"arrrghh. A list is an array and an array is a list. Why must we quibble over synonyms?\n\nDone","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":4484,"context_line":"      A list of objects representing flow classifiers."},{"line_number":4485,"context_line":"  in: body"},{"line_number":4486,"context_line":"  required: true"},{"line_number":4487,"context_line":"  type: list"},{"line_number":4488,"context_line":"sfc-group_id:"},{"line_number":4489,"context_line":"  description: |"},{"line_number":4490,"context_line":"      NEED A DESCRIPTION. I DON\u0027T KNOW WHAT THIS DOES."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a461143_168d807b","line":4487,"range":{"start_line":4487,"start_character":8,"end_line":4487,"end_character":12},"updated":"2017-02-02 07:21:08.000000000","message":"array","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":4484,"context_line":"      A list of objects representing flow classifiers."},{"line_number":4485,"context_line":"  in: body"},{"line_number":4486,"context_line":"  required: true"},{"line_number":4487,"context_line":"  type: list"},{"line_number":4488,"context_line":"sfc-group_id:"},{"line_number":4489,"context_line":"  description: |"},{"line_number":4490,"context_line":"      NEED A DESCRIPTION. I DON\u0027T KNOW WHAT THIS DOES."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a430d35_71aa7072","line":4487,"range":{"start_line":4487,"start_character":8,"end_line":4487,"end_character":12},"in_reply_to":"3a461143_168d807b","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":4545,"context_line":"    A list of objects representing port chains."},{"line_number":4546,"context_line":"  in: body"},{"line_number":4547,"context_line":"  required: true"},{"line_number":4548,"context_line":"  type: list"},{"line_number":4549,"context_line":"sfc-port_pair:"},{"line_number":4550,"context_line":"  description: |"},{"line_number":4551,"context_line":"      An object representing the service function (i.e. a VM)"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a461143_36e8bc16","line":4548,"range":{"start_line":4548,"start_character":8,"end_line":4548,"end_character":12},"updated":"2017-02-02 07:21:08.000000000","message":"array","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":4545,"context_line":"    A list of objects representing port chains."},{"line_number":4546,"context_line":"  in: body"},{"line_number":4547,"context_line":"  required: true"},{"line_number":4548,"context_line":"  type: list"},{"line_number":4549,"context_line":"sfc-port_pair:"},{"line_number":4550,"context_line":"  description: |"},{"line_number":4551,"context_line":"      An object representing the service function (i.e. a VM)"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a430d35_51c4943f","line":4548,"range":{"start_line":4548,"start_character":8,"end_line":4548,"end_character":12},"in_reply_to":"3a461143_36e8bc16","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":4584,"context_line":"      List of port-pair-group IDs."},{"line_number":4585,"context_line":"  in: body"},{"line_number":4586,"context_line":"  required: true"},{"line_number":4587,"context_line":"  type: list"},{"line_number":4588,"context_line":"sfc-port_pair_groups-object:"},{"line_number":4589,"context_line":"  description: |"},{"line_number":4590,"context_line":"      A list of objects representing port pair groups."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a461143_56ed4824","line":4587,"range":{"start_line":4587,"start_character":8,"end_line":4587,"end_character":12},"updated":"2017-02-02 07:21:08.000000000","message":"array","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":4584,"context_line":"      List of port-pair-group IDs."},{"line_number":4585,"context_line":"  in: body"},{"line_number":4586,"context_line":"  required: true"},{"line_number":4587,"context_line":"  type: list"},{"line_number":4588,"context_line":"sfc-port_pair_groups-object:"},{"line_number":4589,"context_line":"  description: |"},{"line_number":4590,"context_line":"      A list of objects representing port pair groups."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a430d35_d1e6c4e7","line":4587,"range":{"start_line":4587,"start_character":8,"end_line":4587,"end_character":12},"in_reply_to":"3a461143_56ed4824","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":4590,"context_line":"      A list of objects representing port pair groups."},{"line_number":4591,"context_line":"  in: body"},{"line_number":4592,"context_line":"  required: true"},{"line_number":4593,"context_line":"  type: list"},{"line_number":4594,"context_line":"sfc-port_pair_id:"},{"line_number":4595,"context_line":"  description: |"},{"line_number":4596,"context_line":"      The ID of the port-pair."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a461143_76f24408","line":4593,"range":{"start_line":4593,"start_character":8,"end_line":4593,"end_character":12},"updated":"2017-02-02 07:21:08.000000000","message":"array","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":4590,"context_line":"      A list of objects representing port pair groups."},{"line_number":4591,"context_line":"  in: body"},{"line_number":4592,"context_line":"  required: true"},{"line_number":4593,"context_line":"  type: list"},{"line_number":4594,"context_line":"sfc-port_pair_id:"},{"line_number":4595,"context_line":"  description: |"},{"line_number":4596,"context_line":"      The ID of the port-pair."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a430d35_11d12cfc","line":4593,"range":{"start_line":4593,"start_character":8,"end_line":4593,"end_character":12},"in_reply_to":"3a461143_76f24408","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":4608,"context_line":"      List of port-pair IDs."},{"line_number":4609,"context_line":"  in: body"},{"line_number":4610,"context_line":"  required: true"},{"line_number":4611,"context_line":"  type: list"},{"line_number":4612,"context_line":"sfc-port_pairs-object:"},{"line_number":4613,"context_line":"  description: |"},{"line_number":4614,"context_line":"      A list of objects representing port pairs (i.e. VMs)"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a461143_96f7b0f4","line":4611,"range":{"start_line":4611,"start_character":8,"end_line":4611,"end_character":12},"updated":"2017-02-02 07:21:08.000000000","message":"array","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":4608,"context_line":"      List of port-pair IDs."},{"line_number":4609,"context_line":"  in: body"},{"line_number":4610,"context_line":"  required: true"},{"line_number":4611,"context_line":"  type: list"},{"line_number":4612,"context_line":"sfc-port_pairs-object:"},{"line_number":4613,"context_line":"  description: |"},{"line_number":4614,"context_line":"      A list of objects representing port pairs (i.e. VMs)"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a430d35_91035c76","line":4611,"range":{"start_line":4611,"start_character":8,"end_line":4611,"end_character":12},"in_reply_to":"3a461143_96f7b0f4","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":4614,"context_line":"      A list of objects representing port pairs (i.e. VMs)"},{"line_number":4615,"context_line":"  in: body"},{"line_number":4616,"context_line":"  required: true"},{"line_number":4617,"context_line":"  type: list"},{"line_number":4618,"context_line":"sfc-protocol:"},{"line_number":4619,"context_line":"  description: |"},{"line_number":4620,"context_line":"    IP protocol."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a461143_d6d93885","line":4617,"range":{"start_line":4617,"start_character":8,"end_line":4617,"end_character":12},"updated":"2017-02-02 07:21:08.000000000","message":"array","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":4614,"context_line":"      A list of objects representing port pairs (i.e. VMs)"},{"line_number":4615,"context_line":"  in: body"},{"line_number":4616,"context_line":"  required: true"},{"line_number":4617,"context_line":"  type: list"},{"line_number":4618,"context_line":"sfc-protocol:"},{"line_number":4619,"context_line":"  description: |"},{"line_number":4620,"context_line":"    IP protocol."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a430d35_d1fde46f","line":4617,"range":{"start_line":4617,"start_character":8,"end_line":4617,"end_character":12},"in_reply_to":"3a461143_d6d93885","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":4632,"context_line":"    The source IP prefix."},{"line_number":4633,"context_line":"  in: body"},{"line_number":4634,"context_line":"  required: false"},{"line_number":4635,"context_line":"  type: cidr"},{"line_number":4636,"context_line":"sfc-source_port_range_max:"},{"line_number":4637,"context_line":"  description: |"},{"line_number":4638,"context_line":"    Maximum source protocol port."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a461143_f6e63443","line":4635,"range":{"start_line":4635,"start_character":8,"end_line":4635,"end_character":12},"updated":"2017-02-02 07:21:08.000000000","message":"string","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":4632,"context_line":"    The source IP prefix."},{"line_number":4633,"context_line":"  in: body"},{"line_number":4634,"context_line":"  required: false"},{"line_number":4635,"context_line":"  type: cidr"},{"line_number":4636,"context_line":"sfc-source_port_range_max:"},{"line_number":4637,"context_line":"  description: |"},{"line_number":4638,"context_line":"    Maximum source protocol port."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a430d35_f1390043","line":4635,"range":{"start_line":4635,"start_character":8,"end_line":4635,"end_character":12},"in_reply_to":"3a461143_f6e63443","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cceaa29a46cdf4a31b36e8748f0c3ca11041b984","unresolved":false,"context_lines":[{"line_number":4659,"context_line":"  type: string"},{"line_number":4660,"context_line":"sfc-correlation:"},{"line_number":4661,"context_line":"  description: |"},{"line_number":4662,"context_line":"      This parameter needs a better description. For now \"mpls\" is the only"},{"line_number":4663,"context_line":"      valid value."},{"line_number":4664,"context_line":"  in: body"},{"line_number":4665,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"da36d5c6_f49be163","line":4662,"range":{"start_line":4662,"start_character":58,"end_line":4662,"end_character":62},"updated":"2017-02-24 16:13:51.000000000","message":"IMO it formats better if we use ``mpls``.","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6bc98ce69ce10bd061b8d3ce33e8d5d070ff647b","unresolved":false,"context_lines":[{"line_number":4659,"context_line":"  type: string"},{"line_number":4660,"context_line":"sfc-correlation:"},{"line_number":4661,"context_line":"  description: |"},{"line_number":4662,"context_line":"      This parameter needs a better description. For now \"mpls\" is the only"},{"line_number":4663,"context_line":"      valid value."},{"line_number":4664,"context_line":"  in: body"},{"line_number":4665,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba2be162_cf36ffb3","line":4662,"range":{"start_line":4662,"start_character":58,"end_line":4662,"end_character":62},"in_reply_to":"da36d5c6_f49be163","updated":"2017-02-28 23:01:25.000000000","message":"Done","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cceaa29a46cdf4a31b36e8748f0c3ca11041b984","unresolved":false,"context_lines":[{"line_number":4697,"context_line":"  type: string"},{"line_number":4698,"context_line":"sfc-ethertype:"},{"line_number":4699,"context_line":"  description: |"},{"line_number":4700,"context_line":"    L2 ethertype. Can be IPv4 or IPv6 only."},{"line_number":4701,"context_line":"  in: body"},{"line_number":4702,"context_line":"  required: false"},{"line_number":4703,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"da36d5c6_14ceb562","line":4700,"range":{"start_line":4700,"start_character":25,"end_line":4700,"end_character":29},"updated":"2017-02-24 16:13:51.000000000","message":"Ideally these acceptable values are written with using double-ticks.. e.g. ``IPv4``","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6bc98ce69ce10bd061b8d3ce33e8d5d070ff647b","unresolved":false,"context_lines":[{"line_number":4697,"context_line":"  type: string"},{"line_number":4698,"context_line":"sfc-ethertype:"},{"line_number":4699,"context_line":"  description: |"},{"line_number":4700,"context_line":"    L2 ethertype. Can be IPv4 or IPv6 only."},{"line_number":4701,"context_line":"  in: body"},{"line_number":4702,"context_line":"  required: false"},{"line_number":4703,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba2be162_ef3bc39a","line":4700,"range":{"start_line":4700,"start_character":25,"end_line":4700,"end_character":29},"in_reply_to":"da36d5c6_14ceb562","updated":"2017-02-28 23:01:25.000000000","message":"Done","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cceaa29a46cdf4a31b36e8748f0c3ca11041b984","unresolved":false,"context_lines":[{"line_number":4733,"context_line":"  type: array"},{"line_number":4734,"context_line":"sfc-group_id:"},{"line_number":4735,"context_line":"  description: |"},{"line_number":4736,"context_line":"      NEED A DESCRIPTION. I DON\u0027T KNOW WHAT THIS DOES."},{"line_number":4737,"context_line":"  in: body"},{"line_number":4738,"context_line":"  required: false"},{"line_number":4739,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"da36d5c6_94caa519","line":4736,"updated":"2017-02-24 16:13:51.000000000","message":"I think we need to fix this description before landing the patch","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"28513712d4a1131246b0793b59bfab5d1864f907","unresolved":false,"context_lines":[{"line_number":4733,"context_line":"  type: array"},{"line_number":4734,"context_line":"sfc-group_id:"},{"line_number":4735,"context_line":"  description: |"},{"line_number":4736,"context_line":"      NEED A DESCRIPTION. I DON\u0027T KNOW WHAT THIS DOES."},{"line_number":4737,"context_line":"  in: body"},{"line_number":4738,"context_line":"  required: false"},{"line_number":4739,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba2be162_e41a056e","line":4736,"in_reply_to":"ba2be162_cfb99fee","updated":"2017-02-28 23:32:51.000000000","message":"This is the autogenerated group number that gets associated to each port-pair-group. That number is then used in OVS OF groups (for the OVS backend), as in:\n\n(part of ovs-ofctl dump-flows br-int -O OpenFlow13):\n\n cookie\u003d0x9ea75cc87dd96232, duration\u003d28.170s, table\u003d0, n_packets\u003d0, n_bytes\u003d0, priority\u003d30,icmp,in_port\u003d4 actions\u003dgroup:1\n\n(part of ovs-ofctl dump-groups br-int -O OpenFlow13):\n\n group_id\u003d1,type\u003dselect,bucket\u003dactions\u003dset_field:fa:16:3e:58:88:0a-\u003eeth_dst,resubmit(,5),bucket\u003dactions\u003dset_field:fa:16:3e:f3:e9:b3-\u003eeth_dst,resubmit(,5)","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6bc98ce69ce10bd061b8d3ce33e8d5d070ff647b","unresolved":false,"context_lines":[{"line_number":4733,"context_line":"  type: array"},{"line_number":4734,"context_line":"sfc-group_id:"},{"line_number":4735,"context_line":"  description: |"},{"line_number":4736,"context_line":"      NEED A DESCRIPTION. I DON\u0027T KNOW WHAT THIS DOES."},{"line_number":4737,"context_line":"  in: body"},{"line_number":4738,"context_line":"  required: false"},{"line_number":4739,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba2be162_cfb99fee","line":4736,"in_reply_to":"da36d5c6_94caa519","updated":"2017-02-28 23:01:25.000000000","message":"I agree. I\u0027ll ask at our Thursday meeting if anybody has any good description for what this is for. I think it may just be an internal counter that\u0027s exposed in the API response.","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cceaa29a46cdf4a31b36e8748f0c3ca11041b984","unresolved":false,"context_lines":[{"line_number":4863,"context_line":"  type: array"},{"line_number":4864,"context_line":"sfc-protocol:"},{"line_number":4865,"context_line":"  description: |"},{"line_number":4866,"context_line":"    IP protocol."},{"line_number":4867,"context_line":"  in: body"},{"line_number":4868,"context_line":"  required: false"},{"line_number":4869,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"da36d5c6_f4ea0173","line":4866,"updated":"2017-02-24 16:13:51.000000000","message":"Is there a list of acceptable values for this one? If so it\u0027d be nice to list them here for our users.","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6bc98ce69ce10bd061b8d3ce33e8d5d070ff647b","unresolved":false,"context_lines":[{"line_number":4863,"context_line":"  type: array"},{"line_number":4864,"context_line":"sfc-protocol:"},{"line_number":4865,"context_line":"  description: |"},{"line_number":4866,"context_line":"    IP protocol."},{"line_number":4867,"context_line":"  in: body"},{"line_number":4868,"context_line":"  required: false"},{"line_number":4869,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba2be162_8fdb271b","line":4866,"in_reply_to":"da36d5c6_f4ea0173","updated":"2017-02-28 23:01:25.000000000","message":"Done","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b7b77499f86bb2a89395bbe2c3057b0c1a4b2903","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"  type: array"},{"line_number":4963,"context_line":"sfc-group_id:"},{"line_number":4964,"context_line":"  description: |"},{"line_number":4965,"context_line":"      NEED A DESCRIPTION. I DON\u0027T KNOW WHAT THIS DOES."},{"line_number":4966,"context_line":"  in: body"},{"line_number":4967,"context_line":"  required: false"},{"line_number":4968,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ba2be162_797945fc","line":4965,"updated":"2017-03-01 12:32:29.000000000","message":"I thought we were going to address this description??","commit_id":"5ec2d3a402a2c61f303b135c69bf5097c80812af"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"f5169b56001f800d15b5847a82e17f7c66d142a5","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"  type: array"},{"line_number":4963,"context_line":"sfc-group_id:"},{"line_number":4964,"context_line":"  description: |"},{"line_number":4965,"context_line":"      NEED A DESCRIPTION. I DON\u0027T KNOW WHAT THIS DOES."},{"line_number":4966,"context_line":"  in: body"},{"line_number":4967,"context_line":"  required: false"},{"line_number":4968,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ba2be162_9cbfc7cf","line":4965,"in_reply_to":"ba2be162_797945fc","updated":"2017-03-01 12:42:42.000000000","message":"Paul, my answer on previous patchset.","commit_id":"5ec2d3a402a2c61f303b135c69bf5097c80812af"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"45e18fcfc54c033825fe5820ba40c7905467d1f0","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"  type: array"},{"line_number":4963,"context_line":"sfc-group_id:"},{"line_number":4964,"context_line":"  description: |"},{"line_number":4965,"context_line":"      NEED A DESCRIPTION. I DON\u0027T KNOW WHAT THIS DOES."},{"line_number":4966,"context_line":"  in: body"},{"line_number":4967,"context_line":"  required: false"},{"line_number":4968,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ba2be162_f4e16f9b","line":4965,"in_reply_to":"ba2be162_9cbfc7cf","updated":"2017-03-02 15:58:16.000000000","message":"Got it. Saw your explanation on PS15 after I pushed PS16.","commit_id":"5ec2d3a402a2c61f303b135c69bf5097c80812af"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c3538aa4853053268ab353b008bebeec11511944","unresolved":false,"context_lines":[{"line_number":4888,"context_line":"  type: string"},{"line_number":4889,"context_line":"sfc-correlation:"},{"line_number":4890,"context_line":"  description: |"},{"line_number":4891,"context_line":"      This parameter needs a better description. For now ``mpls`` is the only"},{"line_number":4892,"context_line":"      valid value."},{"line_number":4893,"context_line":"  in: body"},{"line_number":4894,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ba2be162_4f8ee1d0","line":4891,"range":{"start_line":4891,"start_character":6,"end_line":4891,"end_character":47},"updated":"2017-03-03 20:54:26.000000000","message":"Did you intend to publish the docs with this \"note\"? If mpls is the only value let\u0027s just remove this 1st sentence. If needed we can add a comment TODO and address it later.","commit_id":"566cba8774a1ab2e5064ec0d3c2ed4f3875719b0"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"393b46204aeafb6d7c4b3936df5fd49a3f975f5a","unresolved":false,"context_lines":[{"line_number":4888,"context_line":"  type: string"},{"line_number":4889,"context_line":"sfc-correlation:"},{"line_number":4890,"context_line":"  description: |"},{"line_number":4891,"context_line":"      This parameter needs a better description. For now ``mpls`` is the only"},{"line_number":4892,"context_line":"      valid value."},{"line_number":4893,"context_line":"  in: body"},{"line_number":4894,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a30ddce_418676ba","line":4891,"range":{"start_line":4891,"start_character":6,"end_line":4891,"end_character":47},"in_reply_to":"ba2be162_4f8ee1d0","updated":"2017-03-07 01:11:07.000000000","message":"This should be renamed \u0027sfc-sf-correlation\u0027 and description should read:\n\"SF correlation indicates the type of SFC encapsulation supported by the SF.\"\n\nIt differs from the \u0027sfc-correlation\u0027 which specifies the type of SFC encapsulation to be used for the entire port-chain.\n\nsfc-sf-correlation should be referenced from sfc-port-pairs.inc\n\nsfc-correlation should be referenced from sfc-port-chain.inc\nThe description for sfc-correlation should read:\n\"The type of SFC encapsulation that is to be used for the entire port-chain.\"","commit_id":"566cba8774a1ab2e5064ec0d3c2ed4f3875719b0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c3538aa4853053268ab353b008bebeec11511944","unresolved":false,"context_lines":[{"line_number":4895,"context_line":"  type: string"},{"line_number":4896,"context_line":"sfc-correlation-request:"},{"line_number":4897,"context_line":"  description: |"},{"line_number":4898,"context_line":"      This parameter needs a better description. For now ``mpls`` is the only"},{"line_number":4899,"context_line":"      valid value."},{"line_number":4900,"context_line":"  in: body"},{"line_number":4901,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ba2be162_afb59d7e","line":4898,"range":{"start_line":4898,"start_character":6,"end_line":4898,"end_character":47},"updated":"2017-03-03 20:54:26.000000000","message":"Ditto.","commit_id":"566cba8774a1ab2e5064ec0d3c2ed4f3875719b0"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"bc4934d518108bb4b9b5e0f4be94144cdc29dcf4","unresolved":false,"context_lines":[{"line_number":4895,"context_line":"  type: string"},{"line_number":4896,"context_line":"sfc-correlation-request:"},{"line_number":4897,"context_line":"  description: |"},{"line_number":4898,"context_line":"      This parameter needs a better description. For now ``mpls`` is the only"},{"line_number":4899,"context_line":"      valid value."},{"line_number":4900,"context_line":"  in: body"},{"line_number":4901,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ba2be162_bafdd96f","line":4898,"range":{"start_line":4898,"start_character":6,"end_line":4898,"end_character":47},"in_reply_to":"ba2be162_afb59d7e","updated":"2017-03-03 21:09:20.000000000","message":"Hmm, \"sfc-correlation\" seems to be the port-pair correlation as used in sfc-port-pairs.inc. This means that there are two possible values: None or \u0027mpls\u0027. The attribute defines whether the PP/SF support any kind of correlations.\n\nWhich leads me to the fact that the port-chain\u0027s correlation attribute is missing from this API ref. That one is the one whose only valid value is \u0027mpls\u0027 - and it means the correlation of the chain itself (what protocol will be use to correlate throughout the chain).","commit_id":"566cba8774a1ab2e5064ec0d3c2ed4f3875719b0"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"393b46204aeafb6d7c4b3936df5fd49a3f975f5a","unresolved":false,"context_lines":[{"line_number":4895,"context_line":"  type: string"},{"line_number":4896,"context_line":"sfc-correlation-request:"},{"line_number":4897,"context_line":"  description: |"},{"line_number":4898,"context_line":"      This parameter needs a better description. For now ``mpls`` is the only"},{"line_number":4899,"context_line":"      valid value."},{"line_number":4900,"context_line":"  in: body"},{"line_number":4901,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a30ddce_01bb9e73","line":4898,"range":{"start_line":4898,"start_character":6,"end_line":4898,"end_character":47},"in_reply_to":"ba2be162_bafdd96f","updated":"2017-03-07 01:11:07.000000000","message":"agree with Igor: see previous comment.","commit_id":"566cba8774a1ab2e5064ec0d3c2ed4f3875719b0"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"7be881d6a9c267247683d9d6b167cf587f1c2883","unresolved":false,"context_lines":[{"line_number":4891,"context_line":"sfc-correlation:"},{"line_number":4892,"context_line":"  description: |"},{"line_number":4893,"context_line":"      The type of SFC encapsulation that is used for the entire port-chain."},{"line_number":4894,"context_line":"      Currently only ``mpls`` or ``None`` is supported."},{"line_number":4895,"context_line":"  in: body"},{"line_number":4896,"context_line":"  required: true"},{"line_number":4897,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9a30ddce_8f39f0f4","line":4894,"range":{"start_line":4894,"start_character":21,"end_line":4894,"end_character":41},"updated":"2017-03-09 16:45:52.000000000","message":"Only ``mpls``","commit_id":"6b0817d8e2b2e9bc7c3e4970c24b237a51d6c87b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"980ea11391b5bb51d972f16aafb5a907b4ad153f","unresolved":false,"context_lines":[{"line_number":4891,"context_line":"sfc-correlation:"},{"line_number":4892,"context_line":"  description: |"},{"line_number":4893,"context_line":"      The type of SFC encapsulation that is used for the entire port-chain."},{"line_number":4894,"context_line":"      Currently only ``mpls`` or ``None`` is supported."},{"line_number":4895,"context_line":"  in: body"},{"line_number":4896,"context_line":"  required: true"},{"line_number":4897,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9a30ddce_088dbed5","line":4894,"range":{"start_line":4894,"start_character":21,"end_line":4894,"end_character":41},"in_reply_to":"9a30ddce_8f39f0f4","updated":"2017-03-10 18:55:21.000000000","message":"Done","commit_id":"6b0817d8e2b2e9bc7c3e4970c24b237a51d6c87b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"7be881d6a9c267247683d9d6b167cf587f1c2883","unresolved":false,"context_lines":[{"line_number":4898,"context_line":"sfc-correlation-request:"},{"line_number":4899,"context_line":"  description: |"},{"line_number":4900,"context_line":"      The type of SFC encapsulation that is used for the entire port-chain."},{"line_number":4901,"context_line":"      Currently only ``mpls`` or ``None`` is supported."},{"line_number":4902,"context_line":"  in: body"},{"line_number":4903,"context_line":"  required: false"},{"line_number":4904,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9a30ddce_af3eb4d7","line":4901,"range":{"start_line":4901,"start_character":21,"end_line":4901,"end_character":41},"updated":"2017-03-09 16:45:52.000000000","message":"Only ``mpls``","commit_id":"6b0817d8e2b2e9bc7c3e4970c24b237a51d6c87b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"980ea11391b5bb51d972f16aafb5a907b4ad153f","unresolved":false,"context_lines":[{"line_number":4898,"context_line":"sfc-correlation-request:"},{"line_number":4899,"context_line":"  description: |"},{"line_number":4900,"context_line":"      The type of SFC encapsulation that is used for the entire port-chain."},{"line_number":4901,"context_line":"      Currently only ``mpls`` or ``None`` is supported."},{"line_number":4902,"context_line":"  in: body"},{"line_number":4903,"context_line":"  required: false"},{"line_number":4904,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9a30ddce_2888c2c4","line":4901,"range":{"start_line":4901,"start_character":21,"end_line":4901,"end_character":41},"in_reply_to":"9a30ddce_af3eb4d7","updated":"2017-03-10 18:55:21.000000000","message":"Done","commit_id":"6b0817d8e2b2e9bc7c3e4970c24b237a51d6c87b"}],"api-ref/source/v2/samples/service-function-chaining/sfc-chains/port-chain-create-req.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4a1f2c340902ad37670fbf6ea71fac485e601332","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_chain\": {"},{"line_number":3,"context_line":"        \"name\": \"PC1\","},{"line_number":4,"context_line":"        \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":5,"context_line":"        \"description\": \"Port chain with Firewall and IPS SFs\","},{"line_number":6,"context_line":"        \"flow_classifiers\": ["}],"source_content_type":"application/json","patch_set":8,"id":"ba5201f7_daf3eb08","line":3,"updated":"2017-01-03 17:49:39.000000000","message":"Shouldn\u0027t this also have an \"id\"??","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c1ef9ea9b0377faa6de04a25a4cfb142b4434610","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_chain\": {"},{"line_number":3,"context_line":"        \"name\": \"PC1\","},{"line_number":4,"context_line":"        \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":5,"context_line":"        \"description\": \"Port chain with Firewall and IPS SFs\","},{"line_number":6,"context_line":"        \"flow_classifiers\": ["}],"source_content_type":"application/json","patch_set":8,"id":"1a430d35_6eb77986","line":3,"in_reply_to":"ba5201f7_daf3eb08","updated":"2017-02-06 22:54:52.000000000","message":"Not on the request, yes on the response","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"}],"api-ref/source/v2/samples/service-function-chaining/sfc-chains/port-chain-create-resp.json":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"port_chain\": {"},{"line_number":3,"context_line":"    \"tenant_id\": \"8a67bbdf9498428d818cf051f2ea4991\","},{"line_number":4,"context_line":"    \"name\": \"Port Chain Name\","},{"line_number":5,"context_line":"    \"chain_parameters\": {"},{"line_number":6,"context_line":"      \"symmetric\": false,"}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_da8ec326","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":52},"updated":"2017-02-19 11:50:39.000000000","message":"remove","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"port_chain\": {"},{"line_number":3,"context_line":"    \"tenant_id\": \"8a67bbdf9498428d818cf051f2ea4991\","},{"line_number":4,"context_line":"    \"name\": \"Port Chain Name\","},{"line_number":5,"context_line":"    \"chain_parameters\": {"},{"line_number":6,"context_line":"      \"symmetric\": false,"}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_ed09c22d","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":52},"in_reply_to":"da36d5c6_da8ec326","updated":"2017-02-21 21:54:54.000000000","message":"Why? I generated this example by running a curl command and passing the output through a formatter. I just reran it and the output of a port chain create definitely does include this field.","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ba9bea2ac8fc7e5dda6d91383b06b75c6d32552d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"port_chain\": {"},{"line_number":3,"context_line":"    \"tenant_id\": \"8a67bbdf9498428d818cf051f2ea4991\","},{"line_number":4,"context_line":"    \"name\": \"Port Chain Name\","},{"line_number":5,"context_line":"    \"chain_parameters\": {"},{"line_number":6,"context_line":"      \"symmetric\": false,"}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_afb16b91","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":52},"in_reply_to":"da36d5c6_ed09c22d","updated":"2017-02-22 14:32:03.000000000","message":"Oops, I read this as a \"request\". Please ignore. Same below.","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \"flow_classifiers\": ["},{"line_number":14,"context_line":"      \"9081b050-f862-4c98-a284-3a1fdb180a8c\""},{"line_number":15,"context_line":"    ],"},{"line_number":16,"context_line":"    \"project_id\": \"8a67bbdf9498428d818cf051f2ea4991\","},{"line_number":17,"context_line":"    \"chain_id\": 1,"},{"line_number":18,"context_line":"    \"id\": \"8ab1d88b-5b44-47eb-a143-5fc3feb539ec\","},{"line_number":19,"context_line":"    \"description\": \"Port Chain description\""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_ba73cf4c","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":53},"updated":"2017-02-19 11:50:39.000000000","message":"remove","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \"flow_classifiers\": ["},{"line_number":14,"context_line":"      \"9081b050-f862-4c98-a284-3a1fdb180a8c\""},{"line_number":15,"context_line":"    ],"},{"line_number":16,"context_line":"    \"project_id\": \"8a67bbdf9498428d818cf051f2ea4991\","},{"line_number":17,"context_line":"    \"chain_id\": 1,"},{"line_number":18,"context_line":"    \"id\": \"8ab1d88b-5b44-47eb-a143-5fc3feb539ec\","},{"line_number":19,"context_line":"    \"description\": \"Port Chain description\""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_0d0d3637","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":53},"in_reply_to":"da36d5c6_ba73cf4c","updated":"2017-02-21 21:54:54.000000000","message":"and this one","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    ],"},{"line_number":16,"context_line":"    \"project_id\": \"8a67bbdf9498428d818cf051f2ea4991\","},{"line_number":17,"context_line":"    \"chain_id\": 1,"},{"line_number":18,"context_line":"    \"id\": \"8ab1d88b-5b44-47eb-a143-5fc3feb539ec\","},{"line_number":19,"context_line":"    \"description\": \"Port Chain description\""},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":"}"}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_9a760b3d","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":49},"updated":"2017-02-19 11:50:39.000000000","message":"remove","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    ],"},{"line_number":16,"context_line":"    \"project_id\": \"8a67bbdf9498428d818cf051f2ea4991\","},{"line_number":17,"context_line":"    \"chain_id\": 1,"},{"line_number":18,"context_line":"    \"id\": \"8ab1d88b-5b44-47eb-a143-5fc3feb539ec\","},{"line_number":19,"context_line":"    \"description\": \"Port Chain description\""},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":"}"}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_6d1eb264","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":49},"in_reply_to":"da36d5c6_9a760b3d","updated":"2017-02-21 21:54:54.000000000","message":"and this one","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"}],"api-ref/source/v2/samples/service-function-chaining/sfc-chains/port-chain-list-resp.json":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7a77a1cd9cebd73edabe4e4c7ecc79b2fbca0cea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_chains\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"name\": \"PC1\","},{"line_number":5,"context_line":"            \"id\": \"1278dcd4-459f-62ed-754b-87fc5e4a6751\","},{"line_number":6,"context_line":"            \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":7,"context_line":"            \"description\": \"Port chain with Firewall and IPS SFs\","}],"source_content_type":"application/json","patch_set":4,"id":"ba5da102_ada54405","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":25},"updated":"2016-10-28 08:22:36.000000000","message":"I suggest to provide an example with multiple entries..","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"}],"api-ref/source/v2/samples/service-function-chaining/sfc-classifiers/flow-classifier-create-req.json":[{"author":{"_account_id":8253,"name":"Murali Birru","email":"mbirru@gmail.com","username":"muralibirru"},"change_message_id":"a656097f76d1a6530851727a9491cf796317111b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"         \"description\": \"Flow rule for classifying TCP traffic\","},{"line_number":6,"context_line":"         \"protocol\": \"TCP\","},{"line_number":7,"context_line":"         \"source_port_range_min\": 22, \"source_port_range_max\": 4000,"},{"line_number":8,"context_line":"         \"destination_port_range_min\": 80, \"destination_port_range_max\": 80,"},{"line_number":9,"context_line":"         \"source_ip_prefix\": null, \"destination_ip_prefix\": \"22.12.34.45\""},{"line_number":10,"context_line":"     }"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"9a629dbe_885c3a4c","line":8,"range":{"start_line":8,"start_character":75,"end_line":8,"end_character":76},"updated":"2016-11-11 19:11:22.000000000","message":"please add logical-source-port and logical-destination-port","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \"source_port_range_max\": 65535"},{"line_number":12,"context_line":"  }"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_9aad2b8b","line":14,"updated":"2017-02-19 11:50:39.000000000","message":"blank line","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5bd56d1d16548a773bad8a37ad7043fbce6d4723","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \"source_port_range_max\": 65535"},{"line_number":12,"context_line":"  }"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_c47da61d","line":14,"in_reply_to":"da36d5c6_9aad2b8b","updated":"2017-02-22 14:10:55.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"}],"api-ref/source/v2/samples/service-function-chaining/sfc-classifiers/flow-classifier-create-resp.json":[{"author":{"_account_id":8253,"name":"Murali Birru","email":"mbirru@gmail.com","username":"muralibirru"},"change_message_id":"a656097f76d1a6530851727a9491cf796317111b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"         \"source_port_range_min\": 22, \"source_port_range_max\": 4000,"},{"line_number":8,"context_line":"         \"destination_port_range_min\": 80, \"destination_port_range_max\": 80,"},{"line_number":9,"context_line":"         \"source_ip_prefix\": null, \"destination_ip_prefix\": \"22.12.34.45\","},{"line_number":10,"context_line":"         \"id\": \"4a334cd4-fe9c-4fae-af4b-321c5e2eb051\""},{"line_number":11,"context_line":"     }"},{"line_number":12,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"9a629dbe_081e6a6f","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":53},"updated":"2016-11-11 19:11:22.000000000","message":"please add logical-source-port and logical-destination-port","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"}],"api-ref/source/v2/samples/service-function-chaining/sfc-classifiers/flow-classifier-list-resp.json":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7a77a1cd9cebd73edabe4e4c7ecc79b2fbca0cea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"     \"flow_classifiers\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"             \"id\": \"4a334cd4-fe9c-4fae-af4b-321c5e2eb051\","},{"line_number":5,"context_line":"             \"name\": \"FC1\","}],"source_content_type":"application/json","patch_set":4,"id":"ba5da102_6dd08c54","line":2,"range":{"start_line":2,"start_character":6,"end_line":2,"end_character":22},"updated":"2016-10-28 08:22:36.000000000","message":"Let\u0027s show multiple entries","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"}],"api-ref/source/v2/samples/service-function-chaining/sfc-classifiers/flow-classifier-update-req.json":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7a77a1cd9cebd73edabe4e4c7ecc79b2fbca0cea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"     \"flow_classifier\": {"},{"line_number":3,"context_line":"         \"id\": \"4a334cd4-fe9c-4fae-af4b-321c5e2eb051\","},{"line_number":4,"context_line":"         \"name\": \"FC1\","},{"line_number":5,"context_line":"         \"tenant_id\": \"1814726e2d22407b8ca76db5e567dcf1\","}],"source_content_type":"application/json","patch_set":4,"id":"ba5da102_6d5eccea","line":2,"updated":"2016-10-28 08:22:36.000000000","message":"What field is being modified?","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"717df65a66c4632939ea369f11ddcb6fcb6aa346","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"     \"flow_classifier\": {"},{"line_number":3,"context_line":"         \"id\": \"4a334cd4-fe9c-4fae-af4b-321c5e2eb051\","},{"line_number":4,"context_line":"         \"name\": \"FC1\","},{"line_number":5,"context_line":"         \"tenant_id\": \"1814726e2d22407b8ca76db5e567dcf1\","}],"source_content_type":"application/json","patch_set":4,"id":"ba5da102_0611ad52","line":2,"in_reply_to":"ba5da102_6d5eccea","updated":"2016-10-28 09:41:39.000000000","message":"I copied the examples directly from what was in the networking-sfc repo. I don\u0027t think I changed anything. I can generate new examples by invoking the API, but I hadn\u0027t been planning to do that.","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7a77a1cd9cebd73edabe4e4c7ecc79b2fbca0cea","unresolved":false,"context_lines":[{"line_number":3,"context_line":"         \"id\": \"4a334cd4-fe9c-4fae-af4b-321c5e2eb051\","},{"line_number":4,"context_line":"         \"name\": \"FC1\","},{"line_number":5,"context_line":"         \"tenant_id\": \"1814726e2d22407b8ca76db5e567dcf1\","},{"line_number":6,"context_line":"         \"description\": \"Flow rule for classifying TCP traffic\""},{"line_number":7,"context_line":"     }"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"ba5da102_2dbf74fc","line":6,"range":{"start_line":6,"start_character":51,"end_line":6,"end_character":62},"updated":"2016-10-28 08:22:36.000000000","message":"Is the description correct? I can\u0027t find protocol\u003d\u0027TCP\u0027 over here..","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"717df65a66c4632939ea369f11ddcb6fcb6aa346","unresolved":false,"context_lines":[{"line_number":3,"context_line":"         \"id\": \"4a334cd4-fe9c-4fae-af4b-321c5e2eb051\","},{"line_number":4,"context_line":"         \"name\": \"FC1\","},{"line_number":5,"context_line":"         \"tenant_id\": \"1814726e2d22407b8ca76db5e567dcf1\","},{"line_number":6,"context_line":"         \"description\": \"Flow rule for classifying TCP traffic\""},{"line_number":7,"context_line":"     }"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"ba5da102_2635d1d9","line":6,"range":{"start_line":6,"start_character":51,"end_line":6,"end_character":62},"in_reply_to":"ba5da102_2dbf74fc","updated":"2016-10-28 09:41:39.000000000","message":"ditto above, I didn\u0027t validate the content of the examples, just copied what was already in the networking-sfc repo.","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"}],"api-ref/source/v2/samples/service-function-chaining/sfc-port-pair-groups/port-pair-group-create-req.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4a1f2c340902ad37670fbf6ea71fac485e601332","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_pair_group\": {"},{"line_number":3,"context_line":"         \"name\": \"Firewall_PortPairGroup\","},{"line_number":4,"context_line":"         \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":5,"context_line":"         \"description\": \"Group of Firewall SF instances\","},{"line_number":6,"context_line":"         \"port_pairs\": ["}],"source_content_type":"application/json","patch_set":8,"id":"ba5201f7_7ae3df33","line":3,"updated":"2017-01-03 17:49:39.000000000","message":"Doesn\u0027t this object also include an \"id\"?","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c1ef9ea9b0377faa6de04a25a4cfb142b4434610","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_pair_group\": {"},{"line_number":3,"context_line":"         \"name\": \"Firewall_PortPairGroup\","},{"line_number":4,"context_line":"         \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":5,"context_line":"         \"description\": \"Group of Firewall SF instances\","},{"line_number":6,"context_line":"         \"port_pairs\": ["}],"source_content_type":"application/json","patch_set":8,"id":"1a430d35_6e6e9902","line":3,"in_reply_to":"ba5201f7_7ae3df33","updated":"2017-02-06 22:54:52.000000000","message":"not on the request, yes on the response","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"}],"api-ref/source/v2/samples/service-function-chaining/sfc-port-pair-groups/port-pair-group-get-resp.json":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \"name\": \"Firewall_PortPairGroup\""},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"}"},{"line_number":17,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_fa93874d","line":17,"updated":"2017-02-19 11:50:39.000000000","message":"blank line","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5bd56d1d16548a773bad8a37ad7043fbce6d4723","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \"name\": \"Firewall_PortPairGroup\""},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"}"},{"line_number":17,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_a4b432d1","line":17,"in_reply_to":"da36d5c6_fa93874d","updated":"2017-02-22 14:10:55.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"}],"api-ref/source/v2/samples/service-function-chaining/sfc-port-pair-groups/port-pair-group-list-resp.json":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7a77a1cd9cebd73edabe4e4c7ecc79b2fbca0cea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_pair_groups\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"             \"name\": \"Firewall_PortPairGroup\","},{"line_number":5,"context_line":"             \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","}],"source_content_type":"application/json","patch_set":4,"id":"ba5da102_edf9fcc9","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":21},"updated":"2016-10-28 08:22:36.000000000","message":"Let\u0027s add examples showing multiple entries..","commit_id":"455409b0b5aa20809357e79104d360ed4c258c82"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"  ]"},{"line_number":18,"context_line":"}"},{"line_number":19,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_1a993b6f","line":19,"updated":"2017-02-19 11:50:39.000000000","message":"blank line","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5bd56d1d16548a773bad8a37ad7043fbce6d4723","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"  ]"},{"line_number":18,"context_line":"}"},{"line_number":19,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_e4c62a48","line":19,"in_reply_to":"da36d5c6_1a993b6f","updated":"2017-02-22 14:10:55.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"}],"api-ref/source/v2/samples/service-function-chaining/sfc-port-pair-groups/port-pair-group-update-req.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4a1f2c340902ad37670fbf6ea71fac485e601332","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_pair_group\": {"},{"line_number":3,"context_line":"         \"name\": \"Firewall_PortPairGroup\","},{"line_number":4,"context_line":"         \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":5,"context_line":"         \"description\": \"Group of Firewall SF instances\","},{"line_number":6,"context_line":"         \"port_pairs\": ["}],"source_content_type":"application/json","patch_set":8,"id":"ba5201f7_3ac0777c","line":3,"updated":"2017-01-03 17:49:39.000000000","message":"Don\u0027t we need an \"id\" as well?","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c1ef9ea9b0377faa6de04a25a4cfb142b4434610","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_pair_group\": {"},{"line_number":3,"context_line":"         \"name\": \"Firewall_PortPairGroup\","},{"line_number":4,"context_line":"         \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":5,"context_line":"         \"description\": \"Group of Firewall SF instances\","},{"line_number":6,"context_line":"         \"port_pairs\": ["}],"source_content_type":"application/json","patch_set":8,"id":"1a430d35_ce730de6","line":3,"in_reply_to":"ba5201f7_3ac0777c","updated":"2017-02-06 22:54:52.000000000","message":"no","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"}],"api-ref/source/v2/samples/service-function-chaining/sfc-port-pair-groups/port-pair-group-update-resp.json":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \"name\": \"IDS_PortPairGroup\""},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"}"},{"line_number":17,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_3a9eff56","line":17,"updated":"2017-02-19 11:50:39.000000000","message":"blank line","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5bd56d1d16548a773bad8a37ad7043fbce6d4723","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \"name\": \"IDS_PortPairGroup\""},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"}"},{"line_number":17,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_04c6de47","line":17,"in_reply_to":"da36d5c6_3a9eff56","updated":"2017-02-22 14:10:55.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"}],"api-ref/source/v2/samples/service-function-chaining/sfc-port-pairs/port-pair-create-req.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4a1f2c340902ad37670fbf6ea71fac485e601332","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_pair\": {"},{"line_number":3,"context_line":"         \"name\": \"SF1\","},{"line_number":4,"context_line":"         \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":5,"context_line":"         \"description\": \"Firewall SF instance\","},{"line_number":6,"context_line":"         \"ingress\": \"dace4513-24fc-4fae-af4b-321c5e2eb3d1\","}],"source_content_type":"application/json","patch_set":8,"id":"ba5201f7_9a37a3af","line":3,"updated":"2017-01-03 17:49:39.000000000","message":"Doesn\u0027t this need an \"id\" as well?","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c1ef9ea9b0377faa6de04a25a4cfb142b4434610","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_pair\": {"},{"line_number":3,"context_line":"         \"name\": \"SF1\","},{"line_number":4,"context_line":"         \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":5,"context_line":"         \"description\": \"Firewall SF instance\","},{"line_number":6,"context_line":"         \"ingress\": \"dace4513-24fc-4fae-af4b-321c5e2eb3d1\","}],"source_content_type":"application/json","patch_set":8,"id":"1a430d35_ee828993","line":3,"in_reply_to":"ba5201f7_9a37a3af","updated":"2017-02-06 22:54:52.000000000","message":"no","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"}],"api-ref/source/v2/samples/service-function-chaining/sfc-port-pairs/port-pair-update-req.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4a1f2c340902ad37670fbf6ea71fac485e601332","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_pair\": {"},{"line_number":3,"context_line":"         \"name\": \"SF1\","},{"line_number":4,"context_line":"         \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":5,"context_line":"         \"description\": \"Firewall SF instance\""},{"line_number":6,"context_line":"    }"}],"source_content_type":"application/json","patch_set":8,"id":"ba5201f7_3a47971e","line":3,"updated":"2017-01-03 17:49:39.000000000","message":"Missing \"id\" attribute?","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c1ef9ea9b0377faa6de04a25a4cfb142b4434610","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_pair\": {"},{"line_number":3,"context_line":"         \"name\": \"SF1\","},{"line_number":4,"context_line":"         \"tenant_id\": \"d382007aa9904763a801f68ecf065cf5\","},{"line_number":5,"context_line":"         \"description\": \"Firewall SF instance\""},{"line_number":6,"context_line":"    }"}],"source_content_type":"application/json","patch_set":8,"id":"1a430d35_2e4bb188","line":3,"in_reply_to":"ba5201f7_3a47971e","updated":"2017-02-06 22:54:52.000000000","message":"no, not on the request","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \"description\": \"A Firewall type Service Function\""},{"line_number":5,"context_line":"  }"},{"line_number":6,"context_line":"}"},{"line_number":7,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_5aa3b39e","line":7,"updated":"2017-02-19 11:50:39.000000000","message":"blank line","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5bd56d1d16548a773bad8a37ad7043fbce6d4723","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \"description\": \"A Firewall type Service Function\""},{"line_number":5,"context_line":"  }"},{"line_number":6,"context_line":"}"},{"line_number":7,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_64e15ad0","line":7,"in_reply_to":"da36d5c6_5aa3b39e","updated":"2017-02-22 14:10:55.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"}],"api-ref/source/v2/samples/service-function-chaining/sfc-port-pairs/port-pair-update-resp.json":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \"name\": \"FirewallSF\""},{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_7aa07791","line":16,"updated":"2017-02-19 11:50:39.000000000","message":"blank line","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5bd56d1d16548a773bad8a37ad7043fbce6d4723","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \"name\": \"FirewallSF\""},{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""}],"source_content_type":"application/json","patch_set":13,"id":"da36d5c6_a4eb52af","line":16,"in_reply_to":"da36d5c6_7aa07791","updated":"2017-02-22 14:10:55.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"}],"api-ref/source/v2/sfc-chains.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b4285bb27cce1bb712e79393841958aecb7ef064","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Normal response codes: 200"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Error response codes: unauthorized(401), forbidden(403)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Request"},{"line_number":25,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3a71b18c_75bf3460","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":34},"updated":"2016-12-09 14:30:00.000000000","message":"All the other api-refs just list the codes. i.e.::\n\n   Error response codes: 401, 403","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"fd3516d4f618fc5c58907da9d06be99d4390ba31","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Normal response codes: 200"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Error response codes: unauthorized(401), forbidden(403)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Request"},{"line_number":25,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1a6eadb0_df6705b5","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":34},"in_reply_to":"3a71b18c_75bf3460","updated":"2016-12-15 16:09:18.000000000","message":"I specifically added them because I think it makes for a better user experience (this is the generation of end user facing documentation after all), but I\u0027ll remove them for consistency. I think that we should consider enhancing the code that generates the API-ref web pages to add human readable expansions of the codes. I\u0027ll look into that in January.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"848bb9c2fb777f5be382b9b1bb867c02f9a5ba97","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Normal response codes: 200"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Error response codes: unauthorized(401), forbidden(403)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Request"},{"line_number":25,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3a71b18c_3ea749be","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":34},"in_reply_to":"3a71b18c_75bf3460","updated":"2016-12-09 22:14:21.000000000","message":"ok","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b4285bb27cce1bb712e79393841958aecb7ef064","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  - tenant_id: tenant_id"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Response"},{"line_number":32,"context_line":"--------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3a71b18c_15828094","line":31,"updated":"2016-12-09 14:30:00.000000000","message":"Shouldn\u0027t these responses also document the returned top-level object for the response? e.g. \u0027port_chains\u0027","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"fd3516d4f618fc5c58907da9d06be99d4390ba31","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  - tenant_id: tenant_id"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Response"},{"line_number":32,"context_line":"--------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1a6eadb0_df1b85c8","line":31,"in_reply_to":"3a71b18c_15828094","updated":"2016-12-15 16:09:18.000000000","message":"Do you mean the static text \"port_chains\" in the JSON response? I don\u0027t think there\u0027s a real port_chains object per se. At least not as a manipulable entity with an ID. There are all the individual port chains for a tenant where each port chain has the fields listed below and the chains can all be listed, but the list of chains isn\u0027t another \"thing\" as far as the API is concerned.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b4285bb27cce1bb712e79393841958aecb7ef064","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  - tenant_id: tenant_id"},{"line_number":121,"context_line":"  - port_chain_id: sfc_port_chain_id_path"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3a71b18c_953bf0ea","line":120,"updated":"2016-12-09 14:30:00.000000000","message":"The tenant_id is in the body of a GET request?? Seems odd.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"36ca84ba363b54cf56824aec3c79cac59423ff41","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  - tenant_id: tenant_id"},{"line_number":121,"context_line":"  - port_chain_id: sfc_port_chain_id_path"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1a6eadb0_62f65afa","line":120,"in_reply_to":"1a6eadb0_df72a510","updated":"2016-12-15 16:14:15.000000000","message":"I\u0027ve started deleting tenant_id from all the request sections, but as I was deleting I wondered about an admin user. I\u0027m not sure whether an admin user can create SFC objects on behalf of a tenant, but if so then maybe the tenant ID would need to be passed in the request body. I\u0027ll delete it for now, but will need to do more checking to see if it needs to come back. If it comes back, I assume that both tenant_id and project_id would be valid.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"fd3516d4f618fc5c58907da9d06be99d4390ba31","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  - tenant_id: tenant_id"},{"line_number":121,"context_line":"  - port_chain_id: sfc_port_chain_id_path"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1a6eadb0_df72a510","line":120,"in_reply_to":"3a71b18c_953bf0ea","updated":"2016-12-15 16:09:18.000000000","message":"Done","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b4285bb27cce1bb712e79393841958aecb7ef064","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  - tenant_id: tenant_id"},{"line_number":129,"context_line":"  - id: sfc_port_chain_id_body"},{"line_number":130,"context_line":"  - name: sfc_port_chain_name"},{"line_number":131,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3a71b18c_d52568c2","line":128,"range":{"start_line":128,"start_character":4,"end_line":128,"end_character":13},"updated":"2016-12-09 14:30:00.000000000","message":"SFC doesn\u0027t use project_id??","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"fd3516d4f618fc5c58907da9d06be99d4390ba31","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  - tenant_id: tenant_id"},{"line_number":129,"context_line":"  - id: sfc_port_chain_id_body"},{"line_number":130,"context_line":"  - name: sfc_port_chain_name"},{"line_number":131,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1a6eadb0_7fdd11df","line":128,"range":{"start_line":128,"start_character":4,"end_line":128,"end_character":13},"in_reply_to":"3a71b18c_5e32455f","updated":"2016-12-15 16:09:18.000000000","message":"Do we currently return both? I\u0027ll include both in the documentation and then we can update the documentation when tenant_id is eventually removed.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"848bb9c2fb777f5be382b9b1bb867c02f9a5ba97","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  - tenant_id: tenant_id"},{"line_number":129,"context_line":"  - id: sfc_port_chain_id_body"},{"line_number":130,"context_line":"  - name: sfc_port_chain_name"},{"line_number":131,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3a71b18c_5e32455f","line":128,"range":{"start_line":128,"start_character":4,"end_line":128,"end_character":13},"in_reply_to":"3a71b18c_d52568c2","updated":"2016-12-09 22:14:21.000000000","message":"will change to project_id","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b4285bb27cce1bb712e79393841958aecb7ef064","unresolved":false,"context_lines":[{"line_number":213,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"  - port_chain_id: sfc_port_chain_id_path"},{"line_number":216,"context_line":"  - tenant_id: tenant_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Response"},{"line_number":219,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3a71b18c_b5154c4a","line":216,"updated":"2016-12-09 14:30:00.000000000","message":"Tenant ID is in the request body for DELETE??","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"fd3516d4f618fc5c58907da9d06be99d4390ba31","unresolved":false,"context_lines":[{"line_number":213,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"  - port_chain_id: sfc_port_chain_id_path"},{"line_number":216,"context_line":"  - tenant_id: tenant_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Response"},{"line_number":219,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1a6eadb0_9f010d3b","line":216,"in_reply_to":"3a71b18c_b5154c4a","updated":"2016-12-15 16:09:18.000000000","message":"Done","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4a1f2c340902ad37670fbf6ea71fac485e601332","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"},{"line_number":29,"context_line":"  - description: description"},{"line_number":30,"context_line":"  - port_pair_groups: sfc-port_pair_groups"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ba5201f7_14c0e9df","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":26},"updated":"2017-01-03 17:49:39.000000000","message":"Nit: I\u0027d opt just to use the same parameter for both tenant_id and project_id since they are the same thing (IIUC). Right now they read slightly different, which may cause confusion.","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4a1f2c340902ad37670fbf6ea71fac485e601332","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"},{"line_number":29,"context_line":"  - description: description"},{"line_number":30,"context_line":"  - port_pair_groups: sfc-port_pair_groups"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ba5201f7_14670926","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":14},"updated":"2017-01-03 17:49:39.000000000","message":"Nit: project_id shows up as \u0027in path\u0027 for the request params. It should be \u0027in body\u0027 shouldn\u0027t it?","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c1ef9ea9b0377faa6de04a25a4cfb142b4434610","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"},{"line_number":29,"context_line":"  - description: description"},{"line_number":30,"context_line":"  - port_pair_groups: sfc-port_pair_groups"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"1a430d35_0e55151c","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":26},"in_reply_to":"ba5201f7_14c0e9df","updated":"2017-02-06 22:54:52.000000000","message":"Done","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4a1f2c340902ad37670fbf6ea71fac485e601332","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - description: description"},{"line_number":30,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":31,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":32,"context_line":"  - chain_parameters: sfc-chain_parameters"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Response Example"},{"line_number":35,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ba5201f7_343c0de2","line":32,"updated":"2017-01-03 17:49:39.000000000","message":"The convention I\u0027ve seen in the API ref is to also define a parameter for the \u0027object\u0027 (or array of objects) returned. For example::\n\n    port_chains - An array of ``port_chain`` objects.","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c1ef9ea9b0377faa6de04a25a4cfb142b4434610","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - description: description"},{"line_number":30,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":31,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":32,"context_line":"  - chain_parameters: sfc-chain_parameters"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Response Example"},{"line_number":35,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"1a430d35_8e3f45d5","line":32,"in_reply_to":"ba5201f7_343c0de2","updated":"2017-02-06 22:54:52.000000000","message":"Done","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4a1f2c340902ad37670fbf6ea71fac485e601332","unresolved":false,"context_lines":[{"line_number":56,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  - name: sfc-port_chain_name"},{"line_number":59,"context_line":"  - description: description"},{"line_number":60,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":61,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":62,"context_line":"  - chain_parameters: sfc-chain_parameters"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ba5201f7_34132d68","line":59,"updated":"2017-01-03 17:49:39.000000000","message":"The example request also shows tenant_id... Seems we should include it here and perhaps project_id??","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c1ef9ea9b0377faa6de04a25a4cfb142b4434610","unresolved":false,"context_lines":[{"line_number":56,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  - name: sfc-port_chain_name"},{"line_number":59,"context_line":"  - description: description"},{"line_number":60,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":61,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":62,"context_line":"  - chain_parameters: sfc-chain_parameters"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"1a430d35_8e166553","line":59,"in_reply_to":"ba5201f7_34132d68","updated":"2017-02-06 22:54:52.000000000","message":"Done","commit_id":"97717c78b83d58138bdccf02348c4ad1df27e622"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"20a5b51227ea92c6c08a5043e71efbb390530962","unresolved":false,"context_lines":[{"line_number":9,"context_line":"List Port Chains"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method:: GET /v2.0/sfc/port_chains"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists port chains."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"7a3c09a3_4352dd14","line":12,"updated":"2017-01-13 17:01:37.000000000","message":"Do any of these GETters support the fields querying? If so need to add it. See how other api-refs have done so.","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"10a4e62a02f55be70189d1081cd473623b4c3451","unresolved":false,"context_lines":[{"line_number":9,"context_line":"List Port Chains"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method:: GET /v2.0/sfc/port_chains"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists port chains."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"7a3c09a3_261ebc0c","line":12,"in_reply_to":"7a3c09a3_4352dd14","updated":"2017-01-13 18:43:34.000000000","message":"I don\u0027t know. I\u0027ll test it and see.","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d5caf7e160652fba9d8a34289a9fe823f2420200","unresolved":false,"context_lines":[{"line_number":9,"context_line":"List Port Chains"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method:: GET /v2.0/sfc/port_chains"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists port chains."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3a461143_d67cf1ed","line":12,"in_reply_to":"7a3c09a3_4352dd14","updated":"2017-02-01 19:29:29.000000000","message":"It looks like it supports filtering or querying but not both. Also, it looks like it only supports querying on a single parameter, not multiple. This might be a bug. I think I\u0027ll leave it out of the documentation until/unless it works fully.","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"20a5b51227ea92c6c08a5043e71efbb390530962","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Lists port chains."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Error response codes: 401, 403"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"7a3c09a3_2863f01b","line":17,"updated":"2017-01-13 17:01:37.000000000","message":"What about Request?","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d5caf7e160652fba9d8a34289a9fe823f2420200","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Lists port chains."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Error response codes: 401, 403"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3a461143_36aff52c","line":17,"in_reply_to":"7a3c09a3_2863f01b","updated":"2017-02-01 19:29:29.000000000","message":"The request doesn\u0027t have any parameters so there isn\u0027t anything to include an example of.","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"20a5b51227ea92c6c08a5043e71efbb390530962","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"7a3c09a3_087f14ab","line":25,"updated":"2017-01-13 17:01:37.000000000","message":"Should also have a parameter to describe the ``port_chains`` object. Please see other api-refs. This should be done for all APIs.","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"10a4e62a02f55be70189d1081cd473623b4c3451","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"7a3c09a3_4677483a","line":25,"in_reply_to":"7a3c09a3_087f14ab","updated":"2017-01-13 18:43:34.000000000","message":"I haven\u0027t updated this file yet. I\u0027m going to go through all of these with curl. I only finished port-pair last night before going to sleep. I\u0027m going to replace all the samples with freshly generated ones via curl and match up the parameter lists.","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"20a5b51227ea92c6c08a5043e71efbb390530962","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"},{"line_number":29,"context_line":"  - description: description"},{"line_number":30,"context_line":"  - port_pair_groups: sfc-port_pair_groups"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"7a3c09a3_08047415","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":26},"updated":"2017-01-13 17:01:37.000000000","message":"These read different. I think we need to unify them unless they do in fact imply different use.\n\nRight now it reads:\n\n  tenant_id (Optional)\tbody\tstring\tThe ID of the project   that owns the resource.\n  project_id\tbody\tstring\tThe ID of the project.\n\n\nAren\u0027t project_id and tenant_id the same thing really?","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d5caf7e160652fba9d8a34289a9fe823f2420200","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"},{"line_number":29,"context_line":"  - description: description"},{"line_number":30,"context_line":"  - port_pair_groups: sfc-port_pair_groups"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3a461143_c1d7c6eb","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":26},"in_reply_to":"7a3c09a3_08047415","updated":"2017-02-01 19:29:29.000000000","message":"I\u0027ll make them both project_id","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"10a4e62a02f55be70189d1081cd473623b4c3451","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"},{"line_number":29,"context_line":"  - description: description"},{"line_number":30,"context_line":"  - port_pair_groups: sfc-port_pair_groups"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"7a3c09a3_e687540d","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":26},"in_reply_to":"7a3c09a3_08047415","updated":"2017-01-13 18:43:34.000000000","message":"These are just what was already in parameters.yaml before I started I think. I made some changes in the bgpvpn api-ref. I\u0027ll make the same changes here.","commit_id":"22cdb335d725c64732502c0c4396469170d56d0b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"12955b36ff32f543d993240a445b83267e784442","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"5a3905b3_0c48bd5a","line":25,"updated":"2017-01-20 21:04:46.000000000","message":"Still missing some of my comments from PS9. There should also be a param of each of these describing the top-level json object in the request/response.","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ad4bfbf243c1b5b9dfcde5ec9e8c7341fd699d0d","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"},{"line_number":29,"context_line":"  - description: description"},{"line_number":30,"context_line":"  - port_pair_groups: sfc-port_pair_groups"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"5a3905b3_44af2b94","line":27,"range":{"start_line":26,"start_character":2,"end_line":27,"end_character":26},"updated":"2017-01-20 05:50:11.000000000","message":"Why to have both?","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"79800ed9d42421ac55da1a37db834a96c0d5a7c0","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"},{"line_number":29,"context_line":"  - description: description"},{"line_number":30,"context_line":"  - port_pair_groups: sfc-port_pair_groups"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"5a3905b3_7ce1fccf","line":27,"range":{"start_line":26,"start_character":2,"end_line":27,"end_character":26},"in_reply_to":"5a3905b3_44af2b94","updated":"2017-01-20 17:57:52.000000000","message":"I haven\u0027t validated the port_chains API call yet due to a server 500 error when I attempt to create a chain, but assuming the server returns both the API documentation should list both.\n\nAs for why the server should return both, it\u0027s for transition. The server needs to support both older and newer clients.","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"}],"api-ref/source/v2/sfc-flow-classifiers.inc":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":12,"context_line":".. rest_method:: GET /v2.0/sfc/flow_classifiers"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists flow classifiers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Error response codes: 401, 403"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_bda9f426","line":15,"updated":"2017-01-25 05:56:27.000000000","message":"Does this api support querying based on fields? If yes, please add the description for fields as mentioned in [1]?\n\n[1]https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L24-L28","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":12,"context_line":".. rest_method:: GET /v2.0/sfc/flow_classifiers"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists flow classifiers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Error response codes: 401, 403"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_68a34e50","line":15,"in_reply_to":"5a3905b3_bda9f426","updated":"2017-02-01 23:31:13.000000000","message":"It looks like it only partially works. I\u0027m able to query or filter but not both, and only one field can be specified, not multiple.","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Error response codes: 401, 403"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Response"},{"line_number":21,"context_line":"--------"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_5d71f0df","line":19,"updated":"2017-01-25 05:56:27.000000000","message":"If the above is true, please  add  a Request section and fields as the request parameter as in [1].\n\n[1] https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L34-L39","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  - id: sfc-flow_classifier_id"},{"line_number":33,"context_line":"  - name: sfc-classifier_name"},{"line_number":34,"context_line":"  - ethertype: sfc-ethertype"},{"line_number":35,"context_line":"  - tenant_id: tenant_id"},{"line_number":36,"context_line":"  - source_ip_prefix: sfc-source_ip_prefix"},{"line_number":37,"context_line":"  - logical_destination_port: sfc-logical_destination_port"},{"line_number":38,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_f8246ab3","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"/s/tenant_id/project_id","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  - id: sfc-flow_classifier_id"},{"line_number":33,"context_line":"  - name: sfc-classifier_name"},{"line_number":34,"context_line":"  - ethertype: sfc-ethertype"},{"line_number":35,"context_line":"  - tenant_id: tenant_id"},{"line_number":36,"context_line":"  - source_ip_prefix: sfc-source_ip_prefix"},{"line_number":37,"context_line":"  - logical_destination_port: sfc-logical_destination_port"},{"line_number":38,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_88887ac8","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":24},"in_reply_to":"5a3905b3_f8246ab3","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - logical_destination_port: sfc-logical_destination_port"},{"line_number":38,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"},{"line_number":39,"context_line":"  - destination_port_range_max: sfc-destination_port_range_max"},{"line_number":40,"context_line":"  - project_id: project_id-body-required"},{"line_number":41,"context_line":"  - logical_source_port: sfc-logical_source_port"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_f872aaaf","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":40},"updated":"2017-01-25 05:56:27.000000000","message":"Is there a need of new parameter project_id-body-required? Can we use project_id instead?","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - logical_destination_port: sfc-logical_destination_port"},{"line_number":38,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"},{"line_number":39,"context_line":"  - destination_port_range_max: sfc-destination_port_range_max"},{"line_number":40,"context_line":"  - project_id: project_id-body-required"},{"line_number":41,"context_line":"  - logical_source_port: sfc-logical_source_port"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_a8ac5636","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":40},"in_reply_to":"5a3905b3_f872aaaf","updated":"2017-02-01 23:31:13.000000000","message":"Other people have been changing parameters.yaml. When I started project_id was a path parameter but now it isn\u0027t any more.","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  - id: sfc-flow_classifier_id"},{"line_number":103,"context_line":"  - name: sfc-classifier_name"},{"line_number":104,"context_line":"  - ethertype: sfc-ethertype"},{"line_number":105,"context_line":"  - tenant_id: tenant_id"},{"line_number":106,"context_line":"  - source_ip_prefix: sfc-source_ip_prefix"},{"line_number":107,"context_line":"  - logical_destination_port: sfc-logical_destination_port"},{"line_number":108,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_78395ad8","line":105,"range":{"start_line":105,"start_character":15,"end_line":105,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"/s/tenant_id/project_id","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  - id: sfc-flow_classifier_id"},{"line_number":103,"context_line":"  - name: sfc-classifier_name"},{"line_number":104,"context_line":"  - ethertype: sfc-ethertype"},{"line_number":105,"context_line":"  - tenant_id: tenant_id"},{"line_number":106,"context_line":"  - source_ip_prefix: sfc-source_ip_prefix"},{"line_number":107,"context_line":"  - logical_destination_port: sfc-logical_destination_port"},{"line_number":108,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_e8a65e52","line":105,"range":{"start_line":105,"start_character":15,"end_line":105,"end_character":24},"in_reply_to":"5a3905b3_78395ad8","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  - flow_classifier: sfc-flow_classifier"},{"line_number":138,"context_line":"  - flow_classifier_id: sfc-flow_classifier_id-path"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Response"},{"line_number":141,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_7d5dcc47","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":51},"updated":"2017-01-25 05:56:27.000000000","message":"nit: It would be nice to have the path variable as the first parameter in the request parameters table.","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  - flow_classifier: sfc-flow_classifier"},{"line_number":138,"context_line":"  - flow_classifier_id: sfc-flow_classifier_id-path"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Response"},{"line_number":141,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_0849ea8e","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":51},"in_reply_to":"5a3905b3_7d5dcc47","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  - id: sfc-flow_classifier_id"},{"line_number":153,"context_line":"  - name: sfc-classifier_name"},{"line_number":154,"context_line":"  - ethertype: sfc-ethertype"},{"line_number":155,"context_line":"  - tenant_id: tenant_id"},{"line_number":156,"context_line":"  - source_ip_prefix: sfc-source_ip_prefix"},{"line_number":157,"context_line":"  - logical_destination_port: sfc-logical_destination_port"},{"line_number":158,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_b833c2f5","line":155,"range":{"start_line":155,"start_character":15,"end_line":155,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"/s/tenant_id/project_id","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  - id: sfc-flow_classifier_id"},{"line_number":153,"context_line":"  - name: sfc-classifier_name"},{"line_number":154,"context_line":"  - ethertype: sfc-ethertype"},{"line_number":155,"context_line":"  - tenant_id: tenant_id"},{"line_number":156,"context_line":"  - source_ip_prefix: sfc-source_ip_prefix"},{"line_number":157,"context_line":"  - logical_destination_port: sfc-logical_destination_port"},{"line_number":158,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_284ea696","line":155,"range":{"start_line":155,"start_character":15,"end_line":155,"end_character":24},"in_reply_to":"5a3905b3_b833c2f5","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":212,"context_line":"  - id: sfc-flow_classifier_id"},{"line_number":213,"context_line":"  - name: sfc-classifier_name"},{"line_number":214,"context_line":"  - ethertype: sfc-ethertype"},{"line_number":215,"context_line":"  - tenant_id: tenant_id"},{"line_number":216,"context_line":"  - source_ip_prefix: sfc-source_ip_prefix"},{"line_number":217,"context_line":"  - logical_destination_port: sfc-logical_destination_port"},{"line_number":218,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_d8308eeb","line":215,"range":{"start_line":215,"start_character":15,"end_line":215,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"/s/tenant_id/project_id","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":212,"context_line":"  - id: sfc-flow_classifier_id"},{"line_number":213,"context_line":"  - name: sfc-classifier_name"},{"line_number":214,"context_line":"  - ethertype: sfc-ethertype"},{"line_number":215,"context_line":"  - tenant_id: tenant_id"},{"line_number":216,"context_line":"  - source_ip_prefix: sfc-source_ip_prefix"},{"line_number":217,"context_line":"  - logical_destination_port: sfc-logical_destination_port"},{"line_number":218,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_885dda4a","line":215,"range":{"start_line":215,"start_character":15,"end_line":215,"end_character":24},"in_reply_to":"5a3905b3_d8308eeb","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"36836d9c37e48fd0c24bd00c7a8559f76bfe0da7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method:: GET /v2.0/sfc/flow_classifiers"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists flow classifiers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1a430d35_e6ee91eb","line":14,"updated":"2017-02-03 13:32:35.000000000","message":"Does this support querying with \"fields\"? If so we should probably add it.","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method:: GET /v2.0/sfc/flow_classifiers"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists flow classifiers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_bcdd4216","line":14,"in_reply_to":"1a430d35_5fb9e4e8","updated":"2017-02-21 21:54:54.000000000","message":"It looks like it does work. I still object to copy and pasting the same info into every API ref, but if copy and paste is the goal then I\u0027ll include it.","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"2b680f94474799e9908f9f153f9115df11d2e7f7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method:: GET /v2.0/sfc/flow_classifiers"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists flow classifiers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1a430d35_5fb9e4e8","line":14,"in_reply_to":"1a430d35_e6ee91eb","updated":"2017-02-03 15:05:21.000000000","message":"Only partially. It doesn\u0027t work the way the documentation for other systems states. That\u0027s probably a bug, but I don\u0027t know that anyone ever specifically planned for support. It\u0027s probably a side effect of code reuse. I\u0027ll open a bug and if we implement support in the future then I can update the documentation.","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Creates a flow classifier."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Normal response codes: 200"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Error response codes: 400, 401, 403"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_dab5e3d0","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":26},"updated":"2017-02-19 11:50:39.000000000","message":"201","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Creates a flow classifier."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Normal response codes: 200"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Error response codes: 400, 401, 403"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_dc07567f","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":26},"in_reply_to":"da36d5c6_dab5e3d0","updated":"2017-02-21 21:54:54.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"36836d9c37e48fd0c24bd00c7a8559f76bfe0da7","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  - flow_classifier_id: sfc-flow_classifier_id-path"},{"line_number":138,"context_line":"  - flow_classifier: sfc-flow_classifier"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Response"},{"line_number":141,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1a430d35_0688fd21","line":138,"updated":"2017-02-03 13:32:35.000000000","message":"This GET has a body object??","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"2b680f94474799e9908f9f153f9115df11d2e7f7","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  - flow_classifier_id: sfc-flow_classifier_id-path"},{"line_number":138,"context_line":"  - flow_classifier: sfc-flow_classifier"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Response"},{"line_number":141,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1a430d35_3f825801","line":138,"in_reply_to":"1a430d35_0688fd21","updated":"2017-02-03 15:05:21.000000000","message":"I probably added this in the wrong place.","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"36836d9c37e48fd0c24bd00c7a8559f76bfe0da7","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"  - flow_classifier_id: sfc-flow_classifier_id-path"},{"line_number":188,"context_line":"  - flow_classfier: sfc-flow_classifier"},{"line_number":189,"context_line":"  - name: sfc-classifier_name"},{"line_number":190,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1a430d35_e673f14b","line":187,"updated":"2017-02-03 13:32:35.000000000","message":"Just to confirm; these are the only attrs that are updatable via this PUT?","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"2b680f94474799e9908f9f153f9115df11d2e7f7","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"  - flow_classifier_id: sfc-flow_classifier_id-path"},{"line_number":188,"context_line":"  - flow_classfier: sfc-flow_classifier"},{"line_number":189,"context_line":"  - name: sfc-classifier_name"},{"line_number":190,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1a430d35_fa9a9ec4","line":187,"in_reply_to":"1a430d35_e673f14b","updated":"2017-02-03 15:05:21.000000000","message":"Yes, that is correct.","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Deletes a flow classifier."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Normal response codes: 202"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_1ab05bdd","line":238,"range":{"start_line":238,"start_character":23,"end_line":238,"end_character":26},"updated":"2017-02-19 11:50:39.000000000","message":"204","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Deletes a flow classifier."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Normal response codes: 202"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_dc63d63f","line":238,"range":{"start_line":238,"start_character":23,"end_line":238,"end_character":26},"in_reply_to":"da36d5c6_1ab05bdd","updated":"2017-02-21 21:54:54.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cceaa29a46cdf4a31b36e8748f0c3ca11041b984","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - flow_classifier: sfc-flow_classifier"},{"line_number":81,"context_line":"  - description: description"},{"line_number":82,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"},{"line_number":83,"context_line":"  - destination_port_range_max: sfc-destination_port_range_max"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"da36d5c6_9415459d","line":80,"range":{"start_line":80,"start_character":21,"end_line":80,"end_character":40},"updated":"2017-02-24 16:13:51.000000000","message":"Can\u0027t use sfc-flow_classifiers-object here?","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6bc98ce69ce10bd061b8d3ce33e8d5d070ff647b","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - flow_classifier: sfc-flow_classifier"},{"line_number":81,"context_line":"  - description: description"},{"line_number":82,"context_line":"  - destination_port_range_min: sfc-destination_port_range_min"},{"line_number":83,"context_line":"  - destination_port_range_max: sfc-destination_port_range_max"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"ba2be162_ef990321","line":80,"range":{"start_line":80,"start_character":21,"end_line":80,"end_character":40},"in_reply_to":"da36d5c6_9415459d","updated":"2017-02-28 23:01:25.000000000","message":"Done","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b7b77499f86bb2a89395bbe2c3057b0c1a4b2903","unresolved":false,"context_lines":[{"line_number":36,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  - flow_classifiers: sfc-flow_classifiers-object"},{"line_number":39,"context_line":"  - source_port_range_min: sfc-source_port_range_min"},{"line_number":40,"context_line":"  - destination_ip_prefix: sfc-destination_ip_prefix"},{"line_number":41,"context_line":"  - protocol:  sfc-protocol"},{"line_number":42,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"ba2be162_f95e1544","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":52},"updated":"2017-03-01 12:32:29.000000000","message":"A number of these response params show up as \"optional\".. To me that means they may or may not come back in a response. If they\u0027re always in the response, we should consider making them required for clarity.","commit_id":"5ec2d3a402a2c61f303b135c69bf5097c80812af"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"45e18fcfc54c033825fe5820ba40c7905467d1f0","unresolved":false,"context_lines":[{"line_number":36,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  - flow_classifiers: sfc-flow_classifiers-object"},{"line_number":39,"context_line":"  - source_port_range_min: sfc-source_port_range_min"},{"line_number":40,"context_line":"  - destination_ip_prefix: sfc-destination_ip_prefix"},{"line_number":41,"context_line":"  - protocol:  sfc-protocol"},{"line_number":42,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"ba2be162_0f90b042","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":52},"in_reply_to":"ba2be162_f95e1544","updated":"2017-03-02 15:58:16.000000000","message":"Ok. It\u0027s unfortunate that the tooling makes it necessary to duplicate entries in parameters.yaml for all the many fields that are optional in a request but always reported back, even if None/default in the response. But it is what it is, so I\u0027ll add the extra entries so that I can show optional for request and not optional for response.","commit_id":"5ec2d3a402a2c61f303b135c69bf5097c80812af"}],"api-ref/source/v2/sfc-overview.inc":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ad4bfbf243c1b5b9dfcde5ec9e8c7341fd699d0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The Service Function Chaining extension to Neutron provides four API"},{"line_number":2,"context_line":"objects. Port Chains are composed of an ordered sequence of Port Pair"},{"line_number":3,"context_line":"Groups. Each Port Pair Group is composed of one or more Port Pairs. A"},{"line_number":4,"context_line":"Port Pair represents a service instance (e.g. a Virtual Machine) by"},{"line_number":5,"context_line":"means of an ingress and egress Neutron Port. Finally, a Flow Classifier"},{"line_number":6,"context_line":"is used to indicate which packets should be selected for handling by"},{"line_number":7,"context_line":"the Port Chain."}],"source_content_type":"text/x-c++src","patch_set":10,"id":"5a3905b3_849f534f","line":7,"range":{"start_line":2,"start_character":9,"end_line":7,"end_character":15},"updated":"2017-01-20 05:50:11.000000000","message":"How about ordering and numbering these?\n1. Port Pair\n2. Port Pair Group\n3. Flow Classifier\n4. Port Chain","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"79800ed9d42421ac55da1a37db834a96c0d5a7c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The Service Function Chaining extension to Neutron provides four API"},{"line_number":2,"context_line":"objects. Port Chains are composed of an ordered sequence of Port Pair"},{"line_number":3,"context_line":"Groups. Each Port Pair Group is composed of one or more Port Pairs. A"},{"line_number":4,"context_line":"Port Pair represents a service instance (e.g. a Virtual Machine) by"},{"line_number":5,"context_line":"means of an ingress and egress Neutron Port. Finally, a Flow Classifier"},{"line_number":6,"context_line":"is used to indicate which packets should be selected for handling by"},{"line_number":7,"context_line":"the Port Chain."}],"source_content_type":"text/x-c++src","patch_set":10,"id":"5a3905b3_1cac7833","line":7,"range":{"start_line":2,"start_character":9,"end_line":7,"end_character":15},"in_reply_to":"5a3905b3_849f534f","updated":"2017-01-20 17:57:52.000000000","message":"Done","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4ac57ffc8dc363cb8afd2ffdae0399667b715164","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The Service Function Chaining extension to Neutron provides four API"},{"line_number":2,"context_line":"objects."},{"line_number":3,"context_line":"# Port Pair - A Port Pair represents a service instance (e.g. a Virtual"},{"line_number":4,"context_line":"Machine) by means of an ingress and egress Neutron Port."},{"line_number":5,"context_line":"# Port Pair Group - Each Port Pair Group is composed of one or more Port Pairs."},{"line_number":6,"context_line":"# Flow Classifier - A Flow Classifier is used to indicate which packets should"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_357a9924","line":3,"updated":"2017-01-24 17:12:07.000000000","message":"This list isn\u0027t formatting properly. See: http://docs-draft.openstack.org/85/389385/11/check/gate-neutron-lib-api-ref/aa5b829//api-ref/build/html/v2/index.html#service-function-chaining","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The Service Function Chaining extension to Neutron provides four API"},{"line_number":2,"context_line":"objects."},{"line_number":3,"context_line":"# Port Pair - A Port Pair represents a service instance (e.g. a Virtual"},{"line_number":4,"context_line":"Machine) by means of an ingress and egress Neutron Port."},{"line_number":5,"context_line":"# Port Pair Group - Each Port Pair Group is composed of one or more Port Pairs."},{"line_number":6,"context_line":"# Flow Classifier - A Flow Classifier is used to indicate which packets should"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_88015a3c","line":3,"in_reply_to":"5a3905b3_357a9924","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The Service Function Chaining extension to Neutron provides four API"},{"line_number":2,"context_line":"objects."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"1. Port Pair - A Port Pair represents a service instance (e.g. a Virtual"},{"line_number":5,"context_line":"   Machine) by means of an ingress and egress Neutron Port."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_7ac79745","line":2,"range":{"start_line":1,"start_character":65,"end_line":2,"end_character":7},"updated":"2017-02-19 11:50:39.000000000","message":"resources (API objects)","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5bd56d1d16548a773bad8a37ad7043fbce6d4723","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The Service Function Chaining extension to Neutron provides four API"},{"line_number":2,"context_line":"objects."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"1. Port Pair - A Port Pair represents a service instance (e.g. a Virtual"},{"line_number":5,"context_line":"   Machine) by means of an ingress and egress Neutron Port."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_a4399243","line":2,"range":{"start_line":1,"start_character":65,"end_line":2,"end_character":7},"in_reply_to":"da36d5c6_7ac79745","updated":"2017-02-22 14:10:55.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"e90a1ba12896a7bb5e5db4cfbd6a7869b950dd7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The Service Function Chaining extension to Neutron provides four"},{"line_number":2,"context_line":"resources (API objects.)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"1. Port Pair - A Port Pair represents a service instance (e.g. a Virtual"},{"line_number":5,"context_line":"   Machine) by means of an ingress and egress Neutron Port."}],"source_content_type":"text/x-c++src","patch_set":14,"id":"da36d5c6_ca64cde6","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":24},"updated":"2017-02-22 14:39:24.000000000","message":"Minor: dot after bracket.","commit_id":"d0ef8cef98f5caeb67a9e2d973c85bfc67da2163"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"0366a2f4a7ae4d28061a8aec1f3b3cd58dacbff6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The Service Function Chaining extension to Neutron provides four"},{"line_number":2,"context_line":"resources (API objects.)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"1. Port Pair - A Port Pair represents a service instance (e.g. a Virtual"},{"line_number":5,"context_line":"   Machine) by means of an ingress and egress Neutron Port."}],"source_content_type":"text/x-c++src","patch_set":14,"id":"da36d5c6_6db20d08","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":24},"in_reply_to":"da36d5c6_ca64cde6","updated":"2017-02-22 19:55:33.000000000","message":"Personally I like it better where it is, but I\u0027ll change it.","commit_id":"d0ef8cef98f5caeb67a9e2d973c85bfc67da2163"}],"api-ref/source/v2/sfc-port-chains.inc":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":12,"context_line":".. rest_method:: GET /v2.0/sfc/port_chains"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists port chains."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Error response codes: 401, 403"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_5d3f30d6","line":15,"updated":"2017-01-25 05:56:27.000000000","message":"Does this api support querying based on fields? If yes, please add the description for fields as mentioned in [1]?\n\n[1]https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L24-L28","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":12,"context_line":".. rest_method:: GET /v2.0/sfc/port_chains"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists port chains."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Error response codes: 401, 403"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_9b3d22be","line":15,"in_reply_to":"5a3905b3_5d3f30d6","updated":"2017-02-01 23:31:13.000000000","message":"Looks like only partially. It doesn\u0027t work as that documentation describes.","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Normal response codes: 200"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Error response codes: 401, 403"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Response"},{"line_number":21,"context_line":"--------"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_9d2198b7","line":19,"updated":"2017-01-25 05:56:27.000000000","message":"If the above is true, please add  a Request section and fields as the request parameter as in [1].\n\n[1] https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L34-L39","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"},{"line_number":29,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_580d7e36","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"/s/tenant_id/project_id","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":26,"context_line":"  - tenant_id: tenant_id"},{"line_number":27,"context_line":"  - project_id: project_id"},{"line_number":28,"context_line":"  - name: sfc-port_chain_name"},{"line_number":29,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_bbb81e2c","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":24},"in_reply_to":"5a3905b3_580d7e36","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":75,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":78,"context_line":"  - tenant_id: tenant_id"},{"line_number":79,"context_line":"  - project_id: project_id"},{"line_number":80,"context_line":"  - name: sfc-port_chain_name"},{"line_number":81,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_f8fd4a09","line":78,"range":{"start_line":78,"start_character":15,"end_line":78,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"ditto","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":75,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":78,"context_line":"  - tenant_id: tenant_id"},{"line_number":79,"context_line":"  - project_id: project_id"},{"line_number":80,"context_line":"  - name: sfc-port_chain_name"},{"line_number":81,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_1b869265","line":78,"range":{"start_line":78,"start_character":15,"end_line":78,"end_character":24},"in_reply_to":"5a3905b3_f8fd4a09","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  - tenant_id: tenant_id"},{"line_number":118,"context_line":"  - project_id: project_id"},{"line_number":119,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":120,"context_line":"  - name: sfc-port_chain_name"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_5d165056","line":117,"range":{"start_line":117,"start_character":15,"end_line":117,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"ditto","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  - tenant_id: tenant_id"},{"line_number":118,"context_line":"  - project_id: project_id"},{"line_number":119,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":120,"context_line":"  - name: sfc-port_chain_name"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_bb8f3e74","line":117,"range":{"start_line":117,"start_character":15,"end_line":117,"end_character":24},"in_reply_to":"5a3905b3_5d165056","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":171,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":174,"context_line":"  - tenant_id: tenant_id"},{"line_number":175,"context_line":"  - project_id: project_id"},{"line_number":176,"context_line":"  - name: sfc-port_chain_name"},{"line_number":177,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_7d0b0c2c","line":174,"range":{"start_line":174,"start_character":15,"end_line":174,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"ditto","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":171,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  - id: sfc-port_chain_id_body"},{"line_number":174,"context_line":"  - tenant_id: tenant_id"},{"line_number":175,"context_line":"  - project_id: project_id"},{"line_number":176,"context_line":"  - name: sfc-port_chain_name"},{"line_number":177,"context_line":"  - description: description"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_fbe70644","line":174,"range":{"start_line":174,"start_character":15,"end_line":174,"end_character":24},"in_reply_to":"5a3905b3_7d0b0c2c","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - name: sfc-port_chain_name"},{"line_number":30,"context_line":"  - description: description"},{"line_number":31,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":32,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":33,"context_line":"  - chain_parameters: sfc-chain_parameters"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Response Example"},{"line_number":36,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3a461143_962410b0","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":42},"updated":"2017-02-02 07:21:08.000000000","message":"These parameters are not Optional.","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - name: sfc-port_chain_name"},{"line_number":30,"context_line":"  - description: description"},{"line_number":31,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":32,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":33,"context_line":"  - chain_parameters: sfc-chain_parameters"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Response Example"},{"line_number":36,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a430d35_5181f48e","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":42},"in_reply_to":"3a461143_962410b0","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  - port_chain: sfc-port_chain"},{"line_number":60,"context_line":"  - name: sfc-port_chain_name"},{"line_number":61,"context_line":"  - description: description"},{"line_number":62,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":63,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":64,"context_line":"  - chain_parameters: sfc-chain_parameters"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3a461143_364c3c76","line":61,"range":{"start_line":61,"start_character":17,"end_line":61,"end_character":28},"updated":"2017-02-02 07:21:08.000000000","message":"description-request","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  - port_chain: sfc-port_chain"},{"line_number":60,"context_line":"  - name: sfc-port_chain_name"},{"line_number":61,"context_line":"  - description: description"},{"line_number":62,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":63,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":64,"context_line":"  - chain_parameters: sfc-chain_parameters"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a430d35_d143246b","line":61,"range":{"start_line":61,"start_character":17,"end_line":61,"end_character":28},"in_reply_to":"3a461143_364c3c76","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  - name: sfc-port_chain_name"},{"line_number":84,"context_line":"  - description: description"},{"line_number":85,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":86,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":87,"context_line":"  - chain_parameters: sfc-chain_parameters"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Response Example"},{"line_number":90,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3a461143_5651c80d","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":42},"updated":"2017-02-02 07:21:08.000000000","message":"ditto","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  - name: sfc-port_chain_name"},{"line_number":84,"context_line":"  - description: description"},{"line_number":85,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":86,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":87,"context_line":"  - chain_parameters: sfc-chain_parameters"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Response Example"},{"line_number":90,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a430d35_f148208a","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":42},"in_reply_to":"3a461143_5651c80d","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  - name: sfc-port_chain_name"},{"line_number":125,"context_line":"  - description: description"},{"line_number":126,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":127,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":128,"context_line":"  - chain_parameters: sfc-chain_parameters"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Response Example"},{"line_number":131,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3a461143_965b302e","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":42},"updated":"2017-02-02 07:21:08.000000000","message":"ditto","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  - name: sfc-port_chain_name"},{"line_number":125,"context_line":"  - description: description"},{"line_number":126,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":127,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":128,"context_line":"  - chain_parameters: sfc-chain_parameters"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Response Example"},{"line_number":131,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a430d35_51581457","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":42},"in_reply_to":"3a461143_965b302e","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":156,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  - port_chain: sfc-port_chain"},{"line_number":159,"context_line":"  - port_chain_id: sfc-port_chain_id-path"},{"line_number":160,"context_line":"  - name: sfc-port_chain_name"},{"line_number":161,"context_line":"  - description: description"},{"line_number":162,"context_line":"  - port_pair_groups: sfc-port_pair_groups"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3a461143_5678e88f","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":41},"updated":"2017-02-02 07:21:08.000000000","message":"Generally a parameter for path is better to be put on top.","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":156,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  - port_chain: sfc-port_chain"},{"line_number":159,"context_line":"  - port_chain_id: sfc-port_chain_id-path"},{"line_number":160,"context_line":"  - name: sfc-port_chain_name"},{"line_number":161,"context_line":"  - description: description"},{"line_number":162,"context_line":"  - port_pair_groups: sfc-port_pair_groups"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a430d35_f13f40d4","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":41},"in_reply_to":"3a461143_5678e88f","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  - port_chain: sfc-port_chain"},{"line_number":159,"context_line":"  - port_chain_id: sfc-port_chain_id-path"},{"line_number":160,"context_line":"  - name: sfc-port_chain_name"},{"line_number":161,"context_line":"  - description: description"},{"line_number":162,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":163,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3a461143_b6402c37","line":161,"range":{"start_line":161,"start_character":17,"end_line":161,"end_character":28},"updated":"2017-02-02 07:21:08.000000000","message":"ditto","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  - port_chain: sfc-port_chain"},{"line_number":159,"context_line":"  - port_chain_id: sfc-port_chain_id-path"},{"line_number":160,"context_line":"  - name: sfc-port_chain_name"},{"line_number":161,"context_line":"  - description: description"},{"line_number":162,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":163,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a430d35_512f34a1","line":161,"range":{"start_line":161,"start_character":17,"end_line":161,"end_character":28},"in_reply_to":"3a461143_b6402c37","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc5f95c6c172503768290d0f1b794b25ede91ce","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  - name: sfc-port_chain_name"},{"line_number":183,"context_line":"  - description: description"},{"line_number":184,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":185,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Response Example"},{"line_number":188,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3a461143_766de4cb","line":185,"range":{"start_line":185,"start_character":1,"end_line":185,"end_character":42},"updated":"2017-02-02 07:21:08.000000000","message":"ditto","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"576ae146cb60f1463ea6ba0f4b91a0a5247962ca","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  - name: sfc-port_chain_name"},{"line_number":183,"context_line":"  - description: description"},{"line_number":184,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":185,"context_line":"  - flow_classifiers: sfc-flow_classifiers"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Response Example"},{"line_number":188,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a430d35_712c30ac","line":185,"range":{"start_line":185,"start_character":1,"end_line":185,"end_character":42},"in_reply_to":"3a461143_766de4cb","updated":"2017-02-03 00:11:02.000000000","message":"Done","commit_id":"e9a3f89536cd3d8d871b250b1233704baa43211d"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Creates a port chain."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Normal response codes: 200"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Error response codes: 400, 401, 403"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_bac10f31","line":50,"range":{"start_line":50,"start_character":23,"end_line":50,"end_character":26},"updated":"2017-02-19 11:50:39.000000000","message":"201","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5bd56d1d16548a773bad8a37ad7043fbce6d4723","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Creates a port chain."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Normal response codes: 200"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Error response codes: 400, 401, 403"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_2474c2fb","line":50,"range":{"start_line":50,"start_character":23,"end_line":50,"end_character":26},"in_reply_to":"da36d5c6_bac10f31","updated":"2017-02-22 14:10:55.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Deletes a port chain."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Normal response codes: 202"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_dadc031b","line":202,"range":{"start_line":202,"start_character":23,"end_line":202,"end_character":26},"updated":"2017-02-19 11:50:39.000000000","message":"204","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5bd56d1d16548a773bad8a37ad7043fbce6d4723","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Deletes a port chain."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Normal response codes: 202"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_e450ea60","line":202,"range":{"start_line":202,"start_character":23,"end_line":202,"end_character":26},"in_reply_to":"da36d5c6_dadc031b","updated":"2017-02-22 14:10:55.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"e90a1ba12896a7bb5e5db4cfbd6a7869b950dd7d","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  - port_chain: sfc-port_chain"},{"line_number":60,"context_line":"  - name: sfc-port_chain_name"},{"line_number":61,"context_line":"  - tenant_id: project_id"},{"line_number":62,"context_line":"  - project_id: project_id"},{"line_number":63,"context_line":"  - description: description-request"},{"line_number":64,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":65,"context_line":"  - flow_classifiers: sfc-flow_classifiers"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"da36d5c6_cac04d7f","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":26},"updated":"2017-02-22 14:39:24.000000000","message":"Is this for a create port chain request?","commit_id":"d0ef8cef98f5caeb67a9e2d973c85bfc67da2163"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"0366a2f4a7ae4d28061a8aec1f3b3cd58dacbff6","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  - port_chain: sfc-port_chain"},{"line_number":60,"context_line":"  - name: sfc-port_chain_name"},{"line_number":61,"context_line":"  - tenant_id: project_id"},{"line_number":62,"context_line":"  - project_id: project_id"},{"line_number":63,"context_line":"  - description: description-request"},{"line_number":64,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":65,"context_line":"  - flow_classifiers: sfc-flow_classifiers"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"da36d5c6_c8f847c6","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":26},"in_reply_to":"da36d5c6_cac04d7f","updated":"2017-02-22 19:55:33.000000000","message":"I just tested that an admin user can include tenant_id or project_id in a POST and the port chain will be created with the ID provided.\n\nAnd if just to be difficult you specify both of them at the same time with different values you get an appropriately helpful error message:\n\n {\"NeutronError\": {\"message\": \"\u0027project_id\u0027 and \u0027tenant_id\u0027 do not match\", \"type\": \"HTTPBadRequest\", \"detail\": \"\"}}","commit_id":"d0ef8cef98f5caeb67a9e2d973c85bfc67da2163"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cceaa29a46cdf4a31b36e8748f0c3ca11041b984","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"**Example List port chains: JSON response**"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. literalinclude:: samples/service-function-chaining/sfc-chains/port-chain-list-resp.json"},{"line_number":41,"context_line":"   :language: javascript"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Create Port Chain"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"da36d5c6_54558dc3","line":40,"updated":"2017-02-24 16:13:51.000000000","message":"The sample response includes::\n\n  \"chain_id\": 1,\n\nBut I don\u0027t see chain_id documented.\n\nNOTE: This appears to be the case with other responses below as well.","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6bc98ce69ce10bd061b8d3ce33e8d5d070ff647b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"**Example List port chains: JSON response**"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. literalinclude:: samples/service-function-chaining/sfc-chains/port-chain-list-resp.json"},{"line_number":41,"context_line":"   :language: javascript"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Create Port Chain"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"ba2be162_01746b9a","line":40,"in_reply_to":"da36d5c6_54558dc3","updated":"2017-02-28 23:01:25.000000000","message":"I\u0027m actually wondering if this is something that shouldn\u0027t even be shown to the user. It\u0027s a bit confusing to have an id field and a chain_id field on the port chain object. I\u0027ll ask about this at our Thursday meeting.","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cceaa29a46cdf4a31b36e8748f0c3ca11041b984","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  - port_chain: sfc-port_chain"},{"line_number":60,"context_line":"  - name: sfc-port_chain_name"},{"line_number":61,"context_line":"  - tenant_id: project_id"},{"line_number":62,"context_line":"  - project_id: project_id"},{"line_number":63,"context_line":"  - description: description-request"},{"line_number":64,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":65,"context_line":"  - flow_classifiers: sfc-flow_classifiers"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"da36d5c6_b43249a5","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":26},"updated":"2017-02-24 16:13:51.000000000","message":"These show up as required for the request, but are not in the sample JSON request.","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6bc98ce69ce10bd061b8d3ce33e8d5d070ff647b","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  - port_chain: sfc-port_chain"},{"line_number":60,"context_line":"  - name: sfc-port_chain_name"},{"line_number":61,"context_line":"  - tenant_id: project_id"},{"line_number":62,"context_line":"  - project_id: project_id"},{"line_number":63,"context_line":"  - description: description-request"},{"line_number":64,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":65,"context_line":"  - flow_classifiers: sfc-flow_classifiers"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"ba2be162_8f2fa7a0","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":26},"in_reply_to":"da36d5c6_b43249a5","updated":"2017-02-28 23:01:25.000000000","message":"Done","commit_id":"98750024fc5a8cb79229e9812c439c9ab8f3bede"}],"api-ref/source/v2/sfc-port-pair-groups.inc":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ad4bfbf243c1b5b9dfcde5ec9e8c7341fd699d0d","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":".. rest_method:: PUT /v2.0/sfc/port_pair_groups/{port_pair_group_id}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Updates a port pair group. The current list of port pairs is replaced"},{"line_number":146,"context_line":"by the port pair list in the Update request."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Normal response codes: 200"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"5a3905b3_042fe3f6","line":146,"range":{"start_line":145,"start_character":27,"end_line":146,"end_character":44},"updated":"2017-01-20 05:50:11.000000000","message":"description and name can also be updated.","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"79800ed9d42421ac55da1a37db834a96c0d5a7c0","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":".. rest_method:: PUT /v2.0/sfc/port_pair_groups/{port_pair_group_id}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Updates a port pair group. The current list of port pairs is replaced"},{"line_number":146,"context_line":"by the port pair list in the Update request."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Normal response codes: 200"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"5a3905b3_bc48c488","line":146,"range":{"start_line":145,"start_character":27,"end_line":146,"end_character":44},"in_reply_to":"5a3905b3_042fe3f6","updated":"2017-01-20 17:57:52.000000000","message":"Done","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":15,"context_line":".. rest_method:: GET /v2.0/sfc/port_pair_groups"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Lists port pair groups."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Normal response codes: 200"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Error response codes: 401, 403"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_b88f4274","line":18,"updated":"2017-01-25 05:56:27.000000000","message":"ditto as in other files","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Normal response codes: 200"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Error response codes: 401, 403"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Response"},{"line_number":24,"context_line":"--------"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_18d4d645","line":22,"updated":"2017-01-25 05:56:27.000000000","message":"ditto as in other files","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":29,"context_line":"  - project_id: project_id-body-required"},{"line_number":30,"context_line":"  - description: description"},{"line_number":31,"context_line":"  - tenant_id: tenant_id"},{"line_number":32,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"},{"line_number":33,"context_line":"  - lb_fields: sfc-lb_fields"},{"line_number":34,"context_line":"  - port_pairs: sfc-port_pairs"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_9847e61c","line":31,"range":{"start_line":31,"start_character":15,"end_line":31,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"/s/tenant_id/project_id\nAlso project_id: project_id needs to be added","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - port_pair_groups: sfc-port_pair_groups"},{"line_number":29,"context_line":"  - project_id: project_id-body-required"},{"line_number":30,"context_line":"  - description: description"},{"line_number":31,"context_line":"  - tenant_id: tenant_id"},{"line_number":32,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"},{"line_number":33,"context_line":"  - lb_fields: sfc-lb_fields"},{"line_number":34,"context_line":"  - port_pairs: sfc-port_pairs"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_fb3546a8","line":31,"range":{"start_line":31,"start_character":15,"end_line":31,"end_character":24},"in_reply_to":"5a3905b3_9847e61c","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":64,"context_line":"  - name: sfc-port_pair_group_name"},{"line_number":65,"context_line":"  - tenant_id: tenant_id"},{"line_number":66,"context_line":"  - description: description"},{"line_number":67,"context_line":"  - port_pairs: sfc-port_pairs"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_b86bc284","line":65,"range":{"start_line":65,"start_character":15,"end_line":65,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"/s/tenant_id/project_id","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":64,"context_line":"  - name: sfc-port_pair_group_name"},{"line_number":65,"context_line":"  - tenant_id: tenant_id"},{"line_number":66,"context_line":"  - description: description"},{"line_number":67,"context_line":"  - port_pairs: sfc-port_pairs"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_1b3bf29d","line":65,"range":{"start_line":65,"start_character":15,"end_line":65,"end_character":24},"in_reply_to":"5a3905b3_b86bc284","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":80,"context_line":"  - project_id: project_id-body-required"},{"line_number":81,"context_line":"  - description: description"},{"line_number":82,"context_line":"  - tenant_id: tenant_id"},{"line_number":83,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"},{"line_number":84,"context_line":"  - lb_fields: sfc-lb_fields"},{"line_number":85,"context_line":"  - port_pairs: sfc-port_pairs"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_585c9eed","line":82,"range":{"start_line":82,"start_character":15,"end_line":82,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"/s/tenant_id/project_id\nAlso project_id: project_id needs to be added","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":80,"context_line":"  - project_id: project_id-body-required"},{"line_number":81,"context_line":"  - description: description"},{"line_number":82,"context_line":"  - tenant_id: tenant_id"},{"line_number":83,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"},{"line_number":84,"context_line":"  - lb_fields: sfc-lb_fields"},{"line_number":85,"context_line":"  - port_pairs: sfc-port_pairs"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_3b40ae07","line":82,"range":{"start_line":82,"start_character":15,"end_line":82,"end_character":24},"in_reply_to":"5a3905b3_585c9eed","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":119,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":122,"context_line":"  - project_id: project_id-body-required"},{"line_number":123,"context_line":"  - description: description"},{"line_number":124,"context_line":"  - tenant_id: tenant_id"},{"line_number":125,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_5813be0d","line":122,"range":{"start_line":122,"start_character":16,"end_line":122,"end_character":40},"updated":"2017-01-25 05:56:27.000000000","message":"can we use project_id here?","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":119,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":122,"context_line":"  - project_id: project_id-body-required"},{"line_number":123,"context_line":"  - description: description"},{"line_number":124,"context_line":"  - tenant_id: tenant_id"},{"line_number":125,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_5b457a15","line":122,"range":{"start_line":122,"start_character":16,"end_line":122,"end_character":40},"in_reply_to":"5a3905b3_5813be0d","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":122,"context_line":"  - project_id: project_id-body-required"},{"line_number":123,"context_line":"  - description: description"},{"line_number":124,"context_line":"  - tenant_id: tenant_id"},{"line_number":125,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"},{"line_number":126,"context_line":"  - lb_fields: sfc-lb_fields"},{"line_number":127,"context_line":"  - port_pairs: sfc-port_pairs"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_380ef2e5","line":124,"range":{"start_line":124,"start_character":15,"end_line":124,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"/s/tenant_id/project_id","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":122,"context_line":"  - project_id: project_id-body-required"},{"line_number":123,"context_line":"  - description: description"},{"line_number":124,"context_line":"  - tenant_id: tenant_id"},{"line_number":125,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"},{"line_number":126,"context_line":"  - lb_fields: sfc-lb_fields"},{"line_number":127,"context_line":"  - port_pairs: sfc-port_pairs"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_7b4a3629","line":124,"range":{"start_line":124,"start_character":15,"end_line":124,"end_character":24},"in_reply_to":"5a3905b3_380ef2e5","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  - port_pair_group_id: sfc-port_pair_group_id-path"},{"line_number":159,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":160,"context_line":"  - name: sfc-port_pair_group_name"},{"line_number":161,"context_line":"  - tenant_id: tenant_id"},{"line_number":162,"context_line":"  - description: description"},{"line_number":163,"context_line":"  - port_pairs: sfc-port_pairs"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_b802e2b2","line":161,"range":{"start_line":161,"start_character":15,"end_line":161,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"/s/tenant_id/project_id","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  - port_pair_group_id: sfc-port_pair_group_id-path"},{"line_number":159,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":160,"context_line":"  - name: sfc-port_pair_group_name"},{"line_number":161,"context_line":"  - tenant_id: tenant_id"},{"line_number":162,"context_line":"  - description: description"},{"line_number":163,"context_line":"  - port_pairs: sfc-port_pairs"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_bb549eca","line":161,"range":{"start_line":161,"start_character":15,"end_line":161,"end_character":24},"in_reply_to":"5a3905b3_b802e2b2","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":176,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":179,"context_line":"  - project_id: project_id-body-required"},{"line_number":180,"context_line":"  - description: description"},{"line_number":181,"context_line":"  - tenant_id: tenant_id"},{"line_number":182,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_3825125c","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":40},"updated":"2017-01-25 05:56:27.000000000","message":"same as above","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":176,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":179,"context_line":"  - project_id: project_id-body-required"},{"line_number":180,"context_line":"  - description: description"},{"line_number":181,"context_line":"  - tenant_id: tenant_id"},{"line_number":182,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_db516ada","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":40},"in_reply_to":"5a3905b3_3825125c","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":179,"context_line":"  - project_id: project_id-body-required"},{"line_number":180,"context_line":"  - description: description"},{"line_number":181,"context_line":"  - tenant_id: tenant_id"},{"line_number":182,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"},{"line_number":183,"context_line":"  - lb_fields: sfc-lb_fields"},{"line_number":184,"context_line":"  - port_pairs: sfc-port_pairs"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_d8ffaea8","line":181,"range":{"start_line":181,"start_character":15,"end_line":181,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"ditto","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  - port_pair_group: sfc-port_pair_group"},{"line_number":179,"context_line":"  - project_id: project_id-body-required"},{"line_number":180,"context_line":"  - description: description"},{"line_number":181,"context_line":"  - tenant_id: tenant_id"},{"line_number":182,"context_line":"  - port_pair_group_parameters: sfc-port_pair_group_parameters"},{"line_number":183,"context_line":"  - lb_fields: sfc-lb_fields"},{"line_number":184,"context_line":"  - port_pairs: sfc-port_pairs"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_fb5c66f2","line":181,"range":{"start_line":181,"start_character":15,"end_line":181,"end_character":24},"in_reply_to":"5a3905b3_d8ffaea8","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"36836d9c37e48fd0c24bd00c7a8559f76bfe0da7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":".. rest_method:: GET /v2.0/sfc/port_pair_groups"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Lists port pair groups."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Normal response codes: 200"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1a430d35_66b541cc","line":16,"updated":"2017-02-03 13:32:35.000000000","message":"Is querying with fields applicable here?","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":".. rest_method:: GET /v2.0/sfc/port_pair_groups"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Lists port pair groups."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Normal response codes: 200"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_1c71eee0","line":16,"in_reply_to":"1a430d35_66b541cc","updated":"2017-02-21 21:54:54.000000000","message":"copied and pasted","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Creates a port pair group."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Normal response codes: 200"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Error response codes: 400, 401, 403"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_fae1c7d1","line":54,"range":{"start_line":54,"start_character":23,"end_line":54,"end_character":26},"updated":"2017-02-19 11:50:39.000000000","message":"201","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5bd56d1d16548a773bad8a37ad7043fbce6d4723","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Creates a port pair group."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Normal response codes: 200"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Error response codes: 400, 401, 403"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_44bd3667","line":54,"range":{"start_line":54,"start_character":23,"end_line":54,"end_character":26},"in_reply_to":"da36d5c6_fae1c7d1","updated":"2017-02-22 14:10:55.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Deletes a port pair group."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Normal response codes: 202"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_1ae77be5","line":204,"range":{"start_line":204,"start_character":23,"end_line":204,"end_character":26},"updated":"2017-02-19 11:50:39.000000000","message":"204","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Deletes a port pair group."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Normal response codes: 202"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_dc1bd67e","line":204,"range":{"start_line":204,"start_character":23,"end_line":204,"end_character":26},"in_reply_to":"da36d5c6_1ae77be5","updated":"2017-02-21 21:54:54.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"}],"api-ref/source/v2/sfc-port-pairs.inc":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":16,"context_line":".. rest_method:: GET /v2.0/sfc/port_pairs"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Lists port pairs."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Normal response codes: 200"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Error response codes: 401, 403"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_f8d1ca30","line":19,"updated":"2017-01-25 05:56:27.000000000","message":"ditto as in other files","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - port_pairs: sfc-port_pairs"},{"line_number":30,"context_line":"  - ingress: sfc-ingress_port_id"},{"line_number":31,"context_line":"  - description: description"},{"line_number":32,"context_line":"  - tenant_id: tenant_id"},{"line_number":33,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":34,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":35,"context_line":"  - weight: sfc-weight"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_78e6ba17","line":32,"range":{"start_line":32,"start_character":15,"end_line":32,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"ditto","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - port_pairs: sfc-port_pairs"},{"line_number":30,"context_line":"  - ingress: sfc-ingress_port_id"},{"line_number":31,"context_line":"  - description: description"},{"line_number":32,"context_line":"  - tenant_id: tenant_id"},{"line_number":33,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":34,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":35,"context_line":"  - weight: sfc-weight"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_fb0386bc","line":32,"range":{"start_line":32,"start_character":15,"end_line":32,"end_character":24},"in_reply_to":"5a3905b3_78e6ba17","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  - port_pair: sfc-port_pair"},{"line_number":86,"context_line":"  - ingress: sfc-ingress_port_id"},{"line_number":87,"context_line":"  - description: description"},{"line_number":88,"context_line":"  - tenant_id: tenant_id"},{"line_number":89,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":90,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":91,"context_line":"  - weight: sfc-weight"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_b8f022cb","line":88,"range":{"start_line":88,"start_character":15,"end_line":88,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"ditto","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  - port_pair: sfc-port_pair"},{"line_number":86,"context_line":"  - ingress: sfc-ingress_port_id"},{"line_number":87,"context_line":"  - description: description"},{"line_number":88,"context_line":"  - tenant_id: tenant_id"},{"line_number":89,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":90,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":91,"context_line":"  - weight: sfc-weight"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_1b0932de","line":88,"range":{"start_line":88,"start_character":15,"end_line":88,"end_character":24},"in_reply_to":"5a3905b3_b8f022cb","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  - port_pair: sfc-port_pair"},{"line_number":129,"context_line":"  - ingress: sfc-ingress_port_id"},{"line_number":130,"context_line":"  - description: description"},{"line_number":131,"context_line":"  - tenant_id: tenant_id"},{"line_number":132,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":133,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":134,"context_line":"  - weight: sfc-weight"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_f8b8eaea","line":131,"range":{"start_line":131,"start_character":15,"end_line":131,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"ditto","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  - port_pair: sfc-port_pair"},{"line_number":129,"context_line":"  - ingress: sfc-ingress_port_id"},{"line_number":130,"context_line":"  - description: description"},{"line_number":131,"context_line":"  - tenant_id: tenant_id"},{"line_number":132,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":133,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":134,"context_line":"  - weight: sfc-weight"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_3b0eeee5","line":131,"range":{"start_line":131,"start_character":15,"end_line":131,"end_character":24},"in_reply_to":"5a3905b3_f8b8eaea","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"345871bf16999241cf1687cad4bff7d8cd1e847e","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  - port_pair: sfc-port_pair"},{"line_number":183,"context_line":"  - ingress: sfc-ingress_port_id"},{"line_number":184,"context_line":"  - description: description"},{"line_number":185,"context_line":"  - tenant_id: tenant_id"},{"line_number":186,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":187,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":188,"context_line":"  - weight: sfc-weight"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5a3905b3_18be96d4","line":185,"range":{"start_line":185,"start_character":15,"end_line":185,"end_character":24},"updated":"2017-01-25 05:56:27.000000000","message":"ditto","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  - port_pair: sfc-port_pair"},{"line_number":183,"context_line":"  - ingress: sfc-ingress_port_id"},{"line_number":184,"context_line":"  - description: description"},{"line_number":185,"context_line":"  - tenant_id: tenant_id"},{"line_number":186,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":187,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":188,"context_line":"  - weight: sfc-weight"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3a461143_5b13ba0d","line":185,"range":{"start_line":185,"start_character":15,"end_line":185,"end_character":24},"in_reply_to":"5a3905b3_18be96d4","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"36836d9c37e48fd0c24bd00c7a8559f76bfe0da7","unresolved":false,"context_lines":[{"line_number":16,"context_line":".. rest_method:: GET /v2.0/sfc/port_pairs"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Lists port pairs."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Normal response codes: 200"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Error response codes: 401, 403"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1a430d35_c6c43542","line":19,"updated":"2017-02-03 13:32:35.000000000","message":"Is querying with fields applicable here?","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":16,"context_line":".. rest_method:: GET /v2.0/sfc/port_pairs"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Lists port pairs."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Normal response codes: 200"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Error response codes: 401, 403"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_5736e1e7","line":19,"in_reply_to":"1a430d35_c6c43542","updated":"2017-02-21 21:54:54.000000000","message":"copied and pasted","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Creates a port pair."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Normal response codes: 200"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Error response codes: 400, 401, 403"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_3aec3fc7","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":26},"updated":"2017-02-19 11:50:39.000000000","message":"201","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Creates a port pair."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Normal response codes: 200"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Error response codes: 400, 401, 403"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_37424d3f","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":26},"in_reply_to":"da36d5c6_3aec3fc7","updated":"2017-02-21 21:54:54.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0752dd13e34012dc95aaa0353781172538043187","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Deletes a port pair."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Normal response codes: 202"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_5ad1f3fa","line":209,"range":{"start_line":209,"start_character":23,"end_line":209,"end_character":26},"updated":"2017-02-19 11:50:39.000000000","message":"204","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d67d74048bf3b49297e9fdefb995aa526d3bbd7d","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Deletes a port pair."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Normal response codes: 202"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da36d5c6_f7a51504","line":209,"range":{"start_line":209,"start_character":23,"end_line":209,"end_character":26},"in_reply_to":"da36d5c6_5ad1f3fa","updated":"2017-02-21 21:54:54.000000000","message":"Done","commit_id":"956ff2d01bb2eb55ad3a95712f1f90019b57527b"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"393b46204aeafb6d7c4b3936df5fd49a3f975f5a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":47,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":48,"context_line":"  - weight: sfc-weight"},{"line_number":49,"context_line":"  - correlation: sfc-correlation"},{"line_number":50,"context_line":"  - project_id: project_id"},{"line_number":51,"context_line":"  - id: sfc-port_pair_id"},{"line_number":52,"context_line":"  - name: sfc-port_pair_name"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"9a30ddce_6181ba8f","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":32},"updated":"2017-03-07 01:11:07.000000000","message":"change to sfc-sf-correlation (see comment in parameters.yaml)","commit_id":"566cba8774a1ab2e5064ec0d3c2ed4f3875719b0"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"393b46204aeafb6d7c4b3936df5fd49a3f975f5a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":103,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":104,"context_line":"  - weight: sfc-weight"},{"line_number":105,"context_line":"  - correlation: sfc-correlation"},{"line_number":106,"context_line":"  - project_id: project_id"},{"line_number":107,"context_line":"  - id: sfc-port_pair_id"},{"line_number":108,"context_line":"  - name: sfc-port_pair_name"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"9a30ddce_215ee245","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":32},"updated":"2017-03-07 01:11:07.000000000","message":"ditto","commit_id":"566cba8774a1ab2e5064ec0d3c2ed4f3875719b0"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"393b46204aeafb6d7c4b3936df5fd49a3f975f5a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":146,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":147,"context_line":"  - weight: sfc-weight"},{"line_number":148,"context_line":"  - correlation: sfc-correlation"},{"line_number":149,"context_line":"  - project_id: project_id"},{"line_number":150,"context_line":"  - id: sfc-port_pair_id"},{"line_number":151,"context_line":"  - name: sfc-port_pair_name"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"9a30ddce_415bd654","line":148,"range":{"start_line":148,"start_character":4,"end_line":148,"end_character":32},"updated":"2017-03-07 01:11:07.000000000","message":"ditto","commit_id":"566cba8774a1ab2e5064ec0d3c2ed4f3875719b0"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"393b46204aeafb6d7c4b3936df5fd49a3f975f5a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"  - egress: sfc-egress_port_id"},{"line_number":200,"context_line":"  - service_function_parameters: sfc-service_function_parameters"},{"line_number":201,"context_line":"  - weight: sfc-weight"},{"line_number":202,"context_line":"  - correlation: sfc-correlation"},{"line_number":203,"context_line":"  - project_id: project_id"},{"line_number":204,"context_line":"  - id: sfc-port_pair_id"},{"line_number":205,"context_line":"  - name: sfc-port_pair_name"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"9a30ddce_8155ce1e","line":202,"range":{"start_line":202,"start_character":4,"end_line":202,"end_character":32},"updated":"2017-03-07 01:11:07.000000000","message":"ditto","commit_id":"566cba8774a1ab2e5064ec0d3c2ed4f3875719b0"}],"neutron_lib/api/definitions/sfc.py":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"7e43beb49609cad64e5a3058c622bcdf8ae0d8e1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \u0027name\u0027: {"},{"line_number":59,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":60,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: \u0027\u0027,"},{"line_number":61,"context_line":"            \u0027validate\u0027: {\u0027type:string\u0027: attr.NAME_MAX_LEN},"},{"line_number":62,"context_line":"        },"},{"line_number":63,"context_line":"        \u0027description\u0027: {"},{"line_number":64,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_590bead5","line":61,"range":{"start_line":61,"start_character":40,"end_line":61,"end_character":44},"updated":"2016-12-06 18:00:57.000000000","message":"need: from neutron_lib.db import constants as attr","commit_id":"e32d46cef8c06fb391d8e4c785a3b169a0a97d36"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"7e43beb49609cad64e5a3058c622bcdf8ae0d8e1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \u0027description\u0027: {"},{"line_number":64,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":65,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: \u0027\u0027,"},{"line_number":66,"context_line":"            \u0027validate\u0027: {\u0027type:string\u0027: attr.DESCRIPTION_MAX_LEN},"},{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \u0027tenant_id\u0027: {"},{"line_number":69,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_392f0e40","line":66,"range":{"start_line":66,"start_character":40,"end_line":66,"end_character":44},"updated":"2016-12-06 18:00:57.000000000","message":"ditto and elsewhere","commit_id":"e32d46cef8c06fb391d8e4c785a3b169a0a97d36"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b4285bb27cce1bb712e79393841958aecb7ef064","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a71b18c_98b087df","updated":"2016-12-09 14:30:00.000000000","message":"This needs a UT; see the existing api-def UTs and those that are out for review right now.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"fd3516d4f618fc5c58907da9d06be99d4390ba31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a6eadb0_ff32010f","in_reply_to":"3a71b18c_98b087df","updated":"2016-12-15 16:09:18.000000000","message":"I\u0027m going to remove this file from this change. I had originally intended this change as DOCUMENTATION and added in the API definition because it seemed like a related thing that just needed to be copy and pasted into neutron-lib. Since it\u0027s become more complicated than that and requires development I\u0027m going to split it into a separate commit.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"983649468d62c7825737c41f28c6d3006043250e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def validate_list_of_allowed_values(data, allowed_values\u003dNone):"},{"line_number":61,"context_line":"    if not isinstance(data, list):"},{"line_number":62,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a list\") % data"},{"line_number":63,"context_line":"        return msg"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_8baa5818","line":60,"updated":"2016-12-12 19:59:47.000000000","message":"Validators should be posted on their own base review, as suggested in other patches, like the FWaaS one from Nate [1]. However, before adding new validators we need to assess whether you really need one. Check for [2] to see if there are existing validators that meet your needs. If not, this validator must be contributed in the same module as [2], so that it can be more easily found and reused.\n\n[1] https://review.openstack.org/#/c/389388/\n[2] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/validators.py","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b4285bb27cce1bb712e79393841958aecb7ef064","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return msg"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"lib_validators.validators[\u0027type:list_of_allowed_values\u0027] \u003d \\"},{"line_number":72,"context_line":"    validate_list_of_allowed_values"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_3872134a","line":71,"updated":"2016-12-09 14:30:00.000000000","message":"We should be using add_validator() here: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/validators.py#L936","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"983649468d62c7825737c41f28c6d3006043250e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return msg"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"lib_validators.validators[\u0027type:list_of_allowed_values\u0027] \u003d \\"},{"line_number":72,"context_line":"    validate_list_of_allowed_values"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_8b589858","line":71,"in_reply_to":"3a71b18c_3872134a","updated":"2016-12-12 19:59:47.000000000","message":"Or, better still add this \u0027statically\u0027 in [1]\n\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/validators.py#L883","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b4285bb27cce1bb712e79393841958aecb7ef064","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Port Chain Exceptions"},{"line_number":76,"context_line":"class PortChainNotFound(neutron_exc.NotFound):"},{"line_number":77,"context_line":"    message \u003d _(\"Port Chain %(id)s not found.\")"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_d8dd9f71","line":76,"updated":"2016-12-09 14:30:00.000000000","message":"I question if we should really be including all these exceptions in the api defn. We were discussing something similar over in [1], but its not clear to me how to proceed. I\u0027ll try to sync with Armando today on this topic.\n\n\n[1] https://review.openstack.org/#/c/389388/","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"983649468d62c7825737c41f28c6d3006043250e","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Port Chain Exceptions"},{"line_number":76,"context_line":"class PortChainNotFound(neutron_exc.NotFound):"},{"line_number":77,"context_line":"    message \u003d _(\"Port Chain %(id)s not found.\")"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_ab03940e","line":76,"in_reply_to":"3a71b18c_d8dd9f71","updated":"2016-12-12 19:59:47.000000000","message":"I think I mentioned elsewhere but extension specific InvalidInput exceptions do not quite make sense, especially if these are thrown by API validators or converters.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"983649468d62c7825737c41f28c6d3006043250e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                \"Port Chain %(port_chain)s.\")"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class PortPairGroupNotFound(neutron_exc.NotFound):"},{"line_number":105,"context_line":"    message \u003d _(\"Port Pair Group %(id)s not found.\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_260edb34","line":104,"updated":"2016-12-12 19:59:47.000000000","message":"If exceptions are not used anywhere in this patch, it should not be in here.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b4285bb27cce1bb712e79393841958aecb7ef064","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    message \u003d _(\"Port Pair %(id)s in use.\")"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def normalize_port_pair_groups(port_pair_groups):"},{"line_number":147,"context_line":"    port_pair_groups \u003d lib_converters.convert_to_list(port_pair_groups)"},{"line_number":148,"context_line":"    if not port_pair_groups:"},{"line_number":149,"context_line":"        raise PortPairGroupNotSpecified()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_b8ae2396","line":146,"updated":"2016-12-09 14:30:00.000000000","message":"Same comment as on the exceptions, but I can see why these are needed. I\u0027d suggest we consider making them private unless they really need to be public.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"983649468d62c7825737c41f28c6d3006043250e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    port_pair_groups \u003d lib_converters.convert_to_list(port_pair_groups)"},{"line_number":148,"context_line":"    if not port_pair_groups:"},{"line_number":149,"context_line":"        raise PortPairGroupNotSpecified()"},{"line_number":150,"context_line":"    return port_pair_groups"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"def normalize_chain_parameters(parameters):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_c67367b3","line":150,"updated":"2016-12-12 19:59:47.000000000","message":"We need to be more strict about introducing converters. These need to be contributed alongside other converters, have docstrings, tests, etc.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"983649468d62c7825737c41f28c6d3006043250e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    return port_pair_groups"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"def normalize_chain_parameters(parameters):"},{"line_number":154,"context_line":"    return parameters if parameters else DEFAULT_CHAIN_PARAMETERS"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_e69f83b2","line":153,"updated":"2016-12-12 19:59:47.000000000","message":"same for these ones.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e3add0d2048d31b0ffa171b7f7251de475e59506","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    return parameters if parameters else DEFAULT_PPG_PARAMETERS"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# The resource attribute map for the extension."},{"line_number":165,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":166,"context_line":"    \u0027port_pairs\u0027: {"},{"line_number":167,"context_line":"        \u0027id\u0027: {"},{"line_number":168,"context_line":"            \u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_df8afa19","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":22},"updated":"2016-12-09 06:19:33.000000000","message":"No classifier definition?","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e3add0d2048d31b0ffa171b7f7251de475e59506","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# The action map."},{"line_number":326,"context_line":"ACTION_MAP \u003d {"},{"line_number":327,"context_line":"    SFC: {                         # FIXME: Copied from trunk.py need"},{"line_number":328,"context_line":"        \u0027add_subports\u0027: \u0027PUT\u0027,     # to determine if sfc.py should use"},{"line_number":329,"context_line":"        \u0027remove_subports\u0027: \u0027PUT\u0027,  # ACTION_MAP and if so, how."},{"line_number":330,"context_line":"        \u0027get_subports\u0027: \u0027GET\u0027"},{"line_number":331,"context_line":"    }"},{"line_number":332,"context_line":"}"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"# The list of required extensions."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_7f6c869c","line":331,"range":{"start_line":327,"start_character":4,"end_line":331,"end_character":5},"updated":"2016-12-09 06:19:33.000000000","message":"Do we really need this?","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"983649468d62c7825737c41f28c6d3006043250e","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# The action map."},{"line_number":326,"context_line":"ACTION_MAP \u003d {"},{"line_number":327,"context_line":"    SFC: {                         # FIXME: Copied from trunk.py need"},{"line_number":328,"context_line":"        \u0027add_subports\u0027: \u0027PUT\u0027,     # to determine if sfc.py should use"},{"line_number":329,"context_line":"        \u0027remove_subports\u0027: \u0027PUT\u0027,  # ACTION_MAP and if so, how."},{"line_number":330,"context_line":"        \u0027get_subports\u0027: \u0027GET\u0027"},{"line_number":331,"context_line":"    }"},{"line_number":332,"context_line":"}"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"# The list of required extensions."}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_66da937a","line":331,"range":{"start_line":327,"start_character":4,"end_line":331,"end_character":5},"in_reply_to":"1a6eadb0_f0ed7926","updated":"2016-12-12 19:59:47.000000000","message":"Where is this used exactly in the existing code [1]?\n\nthou shalt not make API extension changes during this process. The first step is to consolidate APIs. Next steps, if needed, will be used to iterate on the API definition.\n\n[1] https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":11907,"name":"cathy","email":"cathy.h.zhang@huawei.com","username":"cathy"},"change_message_id":"1ff671c5bcfbf27a86e4bda1311af1a8e7d5e60f","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# The action map."},{"line_number":326,"context_line":"ACTION_MAP \u003d {"},{"line_number":327,"context_line":"    SFC: {                         # FIXME: Copied from trunk.py need"},{"line_number":328,"context_line":"        \u0027add_subports\u0027: \u0027PUT\u0027,     # to determine if sfc.py should use"},{"line_number":329,"context_line":"        \u0027remove_subports\u0027: \u0027PUT\u0027,  # ACTION_MAP and if so, how."},{"line_number":330,"context_line":"        \u0027get_subports\u0027: \u0027GET\u0027"},{"line_number":331,"context_line":"    }"},{"line_number":332,"context_line":"}"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"# The list of required extensions."}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_f0ed7926","line":331,"range":{"start_line":327,"start_character":4,"end_line":331,"end_character":5},"in_reply_to":"3a71b18c_7f6c869c","updated":"2016-12-12 18:57:10.000000000","message":"We need subports for nested container chain support","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b4285bb27cce1bb712e79393841958aecb7ef064","unresolved":false,"context_lines":[{"line_number":339,"context_line":"# The list of optional extensions."},{"line_number":340,"context_line":"OPTIONAL_EXTENSIONS \u003d None"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"# TODO(armax): add support for modeling custom queries"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_383053e8","line":342,"updated":"2016-12-09 14:30:00.000000000","message":"This TODO can be removed.","commit_id":"7a878c0a9a9f172aff132378cf26b1555568ea14"}],"releasenotes/notes/sfc-api-ref-1f6e15545d7abd96.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"12955b36ff32f543d993240a445b83267e784442","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the networking-sfc API reference documentation to neutron-lib"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a3905b3_8c24adaf","line":3,"updated":"2017-01-20 21:04:46.000000000","message":"Nit: missing period.","commit_id":"7d1f1cee7c68d0d2d1ac2d6d04aa15520e939845"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4ac57ffc8dc363cb8afd2ffdae0399667b715164","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the networking-sfc API reference documentation to neutron-lib"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5a3905b3_f5b571ec","line":3,"range":{"start_line":3,"start_character":67,"end_line":3,"end_character":70},"updated":"2017-01-24 17:12:07.000000000","message":"Nit: missing period.","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4ac57ffc8dc363cb8afd2ffdae0399667b715164","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the networking-sfc API reference documentation to neutron-lib"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5a3905b3_95bc2ddd","line":3,"range":{"start_line":3,"start_character":13,"end_line":3,"end_character":27},"updated":"2017-01-24 17:12:07.000000000","message":"Nit: use ``networking-sfc`` to format as code.","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the networking-sfc API reference documentation to neutron-lib"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3a461143_921c2a6c","line":3,"range":{"start_line":3,"start_character":13,"end_line":3,"end_character":27},"in_reply_to":"5a3905b3_95bc2ddd","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c0cdeadc1d19f09caae16ccaff1ebb2f17fb0561","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the networking-sfc API reference documentation to neutron-lib"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3a461143_b219267c","line":3,"range":{"start_line":3,"start_character":67,"end_line":3,"end_character":70},"in_reply_to":"5a3905b3_f5b571ec","updated":"2017-02-01 23:31:13.000000000","message":"Done","commit_id":"c335c6380341fa1ea4e2195ba53346411ebe64c2"}]}
