)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"fa97f640b0c80fb254f7c36e910c178e2477f09b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Carver \u003cpcarver@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-27 06:01:05 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BGP VPN API Reference"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit converts the BGP VPN API documentation and moves it into"},{"line_number":10,"context_line":"the neutron-lib api-ref."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_06f60d8f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":21},"updated":"2016-10-28 10:12:37.000000000","message":"Retitle into \"move BGPVPN API definition to neutron-lib, add API ref documentation\", or something along these line ?","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"2c31ac3cb2096549d5a18cf8dfc27f1c44e71f4e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Carver \u003cpcarver@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-27 06:01:05 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BGP VPN API Reference"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit converts the BGP VPN API documentation and moves it into"},{"line_number":10,"context_line":"the neutron-lib api-ref."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_527b118c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":21},"in_reply_to":"ba5da102_06f60d8f","updated":"2016-11-01 14:56:11.000000000","message":"Done","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"fa97f640b0c80fb254f7c36e910c178e2477f09b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BGP VPN API Reference"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit converts the BGP VPN API documentation and moves it into"},{"line_number":10,"context_line":"the neutron-lib api-ref."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib0fef2e368c47b1400ab60de19198aa1d1994b69"},{"line_number":13,"context_line":"Partial-Bug: #1636415"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_c1731fb0","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":24},"updated":"2016-10-28 10:12:37.000000000","message":"\"This commit moves the BGP VPN API definition to neutron-lib, and converts ...\"","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"2c31ac3cb2096549d5a18cf8dfc27f1c44e71f4e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BGP VPN API Reference"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit converts the BGP VPN API documentation and moves it into"},{"line_number":10,"context_line":"the neutron-lib api-ref."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib0fef2e368c47b1400ab60de19198aa1d1994b69"},{"line_number":13,"context_line":"Partial-Bug: #1636415"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_726c95d0","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":24},"in_reply_to":"ba5da102_c1731fb0","updated":"2016-11-01 14:56:11.000000000","message":"Done","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"it into the neutron-lib api-ref."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib0fef2e368c47b1400ab60de19198aa1d1994b69"},{"line_number":14,"context_line":"Partial-Bug: #1636415"},{"line_number":15,"context_line":"Depends-On: I3ba35ec6d20d1f60b60183eaea1271727e17f2aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a77a97e_263829a0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":11},"updated":"2016-11-16 23:55:29.000000000","message":"If I understand bug correctly, you should use `Closes-Bug`","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"55ce365f85fd9265b88d87bf8f4203d89a6ee697","unresolved":false,"context_lines":[{"line_number":11,"context_line":"it into the neutron-lib api-ref."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib0fef2e368c47b1400ab60de19198aa1d1994b69"},{"line_number":14,"context_line":"Partial-Bug: #1636415"},{"line_number":15,"context_line":"Depends-On: I3ba35ec6d20d1f60b60183eaea1271727e17f2aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a77a97e_8c7cedb6","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":11},"in_reply_to":"7a77a97e_263829a0","updated":"2016-11-22 15:15:08.000000000","message":"I was thinking in terms of the full stadium criteria, but I\u0027ll change it to Closes-Bug","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1df676714b6930c6b8311774bf9b3445852fb35f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7a3c09a3_a9bb5fc3","updated":"2017-01-13 19:12:28.000000000","message":"As per [1] I think we want this on the topic \u0027stadium-implosion\u0027\n\n\n[1] https://review.openstack.org/#/c/389397/16/specs/stadium/ocata.rst@246","commit_id":"48ff4aa078d3b6ec323d44220645b875b4a11521"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c918946725df36e31cc677bb761fb3fbac239caa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7a3c09a3_3b73fc4e","in_reply_to":"7a3c09a3_a9bb5fc3","updated":"2017-01-16 14:08:08.000000000","message":"Done","commit_id":"48ff4aa078d3b6ec323d44220645b875b4a11521"}],"api-ref/source/v2/bgpvpn-bgpvpns.inc":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9c51e0abc3d607b86c00a82892bc20d08e4b93d1","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   - export_targets: bgpvpn_export_targets"},{"line_number":67,"context_line":"   - id: bgpvpn_id"},{"line_number":68,"context_line":"   - import_targets: bgpvpn_import_targets"},{"line_number":69,"context_line":"   - name: bgpvpn_name"},{"line_number":70,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"},{"line_number":71,"context_line":"   - route_targets: bgpvpn_route_targets"},{"line_number":72,"context_line":"   - tenant_id: tenant_id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Request Example"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"da6895a0_dd1be07e","line":72,"range":{"start_line":66,"start_character":0,"end_line":72,"end_character":25},"updated":"2016-10-25 07:33:33.000000000","message":"Can we keep the same order as for \"List BGPVPNs\" ?\n(and same for the requests below)","commit_id":"6219df398ceec5148ae1900f1cb45c20994d6278"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Lists BGP VPNs to which the tenant has access."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Normal response codes: OK(200)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Error response codes: BadRequest(400), Unauthorized(401), Forbidden(403)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"7a77a97e_413b4f9c","line":26,"range":{"start_line":26,"start_character":23,"end_line":26,"end_character":30},"updated":"2016-11-16 23:55:29.000000000","message":"you should include just code response, without description. It applies to all descriptions.","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"55ce365f85fd9265b88d87bf8f4203d89a6ee697","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Lists BGP VPNs to which the tenant has access."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Normal response codes: OK(200)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Error response codes: BadRequest(400), Unauthorized(401), Forbidden(403)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"7a77a97e_2a073c82","line":26,"range":{"start_line":26,"start_character":23,"end_line":26,"end_character":30},"in_reply_to":"7a77a97e_413b4f9c","updated":"2016-11-22 15:15:08.000000000","message":"We should probably see about modifying the code that renders the api-ref docs to add the descriptions because this is generating user facing documentation and the numeric codes without descriptions are a poor user experience, but I\u0027ll remove them from here.","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":".. needs:method_verification"},{"line_number":3,"context_line":".. needs:parameter_verification"},{"line_number":4,"context_line":".. needs:example_verification"},{"line_number":5,"context_line":".. needs:body_verification"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"BGP VPNs"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_7ae6dae8","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":26},"updated":"2016-11-29 00:15:57.000000000","message":"I hope this patch doesn\u0027t need these checks.","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":31,"context_line":"-------------------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   - id: bgpvpn_id"},{"line_number":36,"context_line":"   - name: bgpvpn_name"},{"line_number":37,"context_line":"   - type: bgpvpn_type"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_27e0cb95","line":34,"updated":"2016-11-29 00:15:57.000000000","message":"nit: Could you consider to add \"bgpvpns\" which has description like \"A list of bgpvpn objects.\"?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   - export_targets: bgpvpn_export_targets"},{"line_number":42,"context_line":"   - networks: bgpvpn_networks"},{"line_number":43,"context_line":"   - routers: bgpvpn_routers"},{"line_number":44,"context_line":"   - tenant_id: tenant_id"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Response Example"},{"line_number":47,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_879eff04","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":25},"updated":"2016-11-29 00:15:57.000000000","message":"bgpvpn doesn\u0027t support project id?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ba40cdfbdd2c01cd851e88d10e48f9f5fadee148","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   - export_targets: bgpvpn_export_targets"},{"line_number":42,"context_line":"   - networks: bgpvpn_networks"},{"line_number":43,"context_line":"   - routers: bgpvpn_routers"},{"line_number":44,"context_line":"   - tenant_id: tenant_id"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Response Example"},{"line_number":47,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_61fb6f47","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":25},"in_reply_to":"5a74a57a_879eff04","updated":"2016-11-29 14:52:32.000000000","message":"Good catch.\n\nYes, bgpvpn supports project_id as well.\n\nPaul, we need to have the line above with tenant_id, *and* a line with project_id: project_id .","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Create BGP VPNS"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":".. rest_method::  POST /bgpvpn/bgpvpns"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Creates a BGP VPN."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_3a61c2a9","line":55,"updated":"2016-11-29 00:15:57.000000000","message":"Missing /v2.0","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":64,"context_line":"-------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   - id: bgpvpn_id"},{"line_number":69,"context_line":"   - name: bgpvpn_name"},{"line_number":70,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_dac8ce57","line":67,"updated":"2016-11-29 00:15:57.000000000","message":"nit: Could you consider to add \"bgpvpn\" which has description like \"A bgpvpn object.\"?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   - id: bgpvpn_id"},{"line_number":69,"context_line":"   - name: bgpvpn_name"},{"line_number":70,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"},{"line_number":71,"context_line":"   - route_targets: bgpvpn_route_targets"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_7ab33a0a","line":68,"range":{"start_line":68,"start_character":5,"end_line":68,"end_character":18},"updated":"2016-11-29 00:15:57.000000000","message":"This is unnecessary.","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Normal response codes: 200"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Error response codes: 401, 403"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Request"},{"line_number":113,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_ba16b249","line":110,"range":{"start_line":110,"start_character":22,"end_line":110,"end_character":30},"updated":"2016-11-29 00:15:57.000000000","message":"What happens when the bpgvpn_id doesn\u0027t exist? That\u0027s 404?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   - id: bgpvpn_id"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Response Parameters"},{"line_number":120,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_072f4fa1","line":117,"range":{"start_line":117,"start_character":5,"end_line":117,"end_character":7},"updated":"2016-11-29 00:15:57.000000000","message":"bgpvpn_id","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ba40cdfbdd2c01cd851e88d10e48f9f5fadee148","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   - id: bgpvpn_id"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Response Parameters"},{"line_number":120,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_81a40b4b","line":117,"range":{"start_line":117,"start_character":5,"end_line":117,"end_character":7},"in_reply_to":"5a74a57a_072f4fa1","updated":"2016-11-29 14:52:32.000000000","message":"Good catch.","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Updates a BGP VPN."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Normal response codes: 200, 201"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Error response codes: 400, 401, 403"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_fabd8a02","line":148,"range":{"start_line":148,"start_character":23,"end_line":148,"end_character":31},"updated":"2016-11-29 00:15:57.000000000","message":"Is it possible for the API to return two response codes?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Normal response codes: 200, 201"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Error response codes: 400, 401, 403"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Request"},{"line_number":153,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_fa54aaca","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":35},"updated":"2016-11-29 00:15:57.000000000","message":"What happens when the bpgvpn_id doesn\u0027t exist? That\u0027s 404?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"   - id: bgpvpn_id"},{"line_number":160,"context_line":"   - name: bgpvpn_name"},{"line_number":161,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"},{"line_number":162,"context_line":"   - route_targets: bgpvpn_route_targets"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_7a0edae5","line":159,"range":{"start_line":159,"start_character":5,"end_line":159,"end_character":7},"updated":"2016-11-29 00:15:57.000000000","message":"ditto","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ba40cdfbdd2c01cd851e88d10e48f9f5fadee148","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"   - id: bgpvpn_id"},{"line_number":160,"context_line":"   - name: bgpvpn_name"},{"line_number":161,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"},{"line_number":162,"context_line":"   - route_targets: bgpvpn_route_targets"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_e1421f67","line":159,"range":{"start_line":159,"start_character":5,"end_line":159,"end_character":7},"in_reply_to":"5a74a57a_7a0edae5","updated":"2016-11-29 14:52:32.000000000","message":"good catch","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - id: bgpvpn_id"},{"line_number":32,"context_line":"   - name: bgpvpn_name"},{"line_number":33,"context_line":"   - type: bgpvpn_type"},{"line_number":34,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_81ca066d","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":18},"updated":"2016-12-13 18:19:56.000000000","message":"This shows up as a \u0027path\u0027 parameter; shouldn\u0027t it be in the \u0027body\u0027? This comment applies to all api-refs herein.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8e8a56de17bdb3093e2cbc4a858e7b7a4c24f999","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - id: bgpvpn_id"},{"line_number":32,"context_line":"   - name: bgpvpn_name"},{"line_number":33,"context_line":"   - type: bgpvpn_type"},{"line_number":34,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_055fc241","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":18},"in_reply_to":"1a6eadb0_57193578","updated":"2016-12-20 15:59:46.000000000","message":"I\u0027ve created two parameters, one for path and one for body. The path one is used in requests. In responses it\u0027s always in the body.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - id: bgpvpn_id"},{"line_number":32,"context_line":"   - name: bgpvpn_name"},{"line_number":33,"context_line":"   - type: bgpvpn_type"},{"line_number":34,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_57193578","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":18},"in_reply_to":"1a6eadb0_81ca066d","updated":"2016-12-15 09:58:58.000000000","message":"Good catch\n\nHowever, it is not an issue in all places in the document: in some, it is actually a path parameter (Get/Update/Delete for a BGPVPN, and in all cases for Network and Router associations).","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - id: bgpvpn_id"},{"line_number":32,"context_line":"   - name: bgpvpn_name"},{"line_number":33,"context_line":"   - type: bgpvpn_type"},{"line_number":34,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"},{"line_number":35,"context_line":"   - route_targets: bgpvpn_route_targets"},{"line_number":36,"context_line":"   - import_targets: bgpvpn_import_targets"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_419d4e58","line":33,"updated":"2016-12-13 18:19:56.000000000","message":"The api-refs I\u0027ve seen also document their top-level json object in the response. For example here: \u0027bgpvpns\u0027. This comment applies to all APIs herein.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - id: bgpvpn_id"},{"line_number":32,"context_line":"   - name: bgpvpn_name"},{"line_number":33,"context_line":"   - type: bgpvpn_type"},{"line_number":34,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"},{"line_number":35,"context_line":"   - route_targets: bgpvpn_route_targets"},{"line_number":36,"context_line":"   - import_targets: bgpvpn_import_targets"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_b780c9f8","line":33,"in_reply_to":"1a6eadb0_419d4e58","updated":"2016-12-15 09:58:58.000000000","message":"I don\u0027t understand your comment. I couldn\u0027t for instance find an obvious different in how \"List Networks\" differs from \"List BGPVPNs\" nor for the documented JSON or for the response example.\n\nWould you have a pointer on a specific API that is documented differently from this?","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8e8a56de17bdb3093e2cbc4a858e7b7a4c24f999","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - id: bgpvpn_id"},{"line_number":32,"context_line":"   - name: bgpvpn_name"},{"line_number":33,"context_line":"   - type: bgpvpn_type"},{"line_number":34,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"},{"line_number":35,"context_line":"   - route_targets: bgpvpn_route_targets"},{"line_number":36,"context_line":"   - import_targets: bgpvpn_import_targets"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_73191c79","line":33,"in_reply_to":"1a6eadb0_62157a47","updated":"2016-12-20 15:59:46.000000000","message":"Done","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17041b34021af4024092ce7d1984626d935db4d8","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - id: bgpvpn_id"},{"line_number":32,"context_line":"   - name: bgpvpn_name"},{"line_number":33,"context_line":"   - type: bgpvpn_type"},{"line_number":34,"context_line":"   - route_distinguishers: bgpvpn_route_distinguishers"},{"line_number":35,"context_line":"   - route_targets: bgpvpn_route_targets"},{"line_number":36,"context_line":"   - import_targets: bgpvpn_import_targets"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_62157a47","line":33,"in_reply_to":"1a6eadb0_b780c9f8","updated":"2016-12-15 16:37:58.000000000","message":"Take for example list networks [1]. The response params show::\n\n   networks\tbody\tarray\tA list of network objects.\n\nWhich correspond to the JSON response::\n\n  {\n    \"networks\": [\n        {net object},\n        {net object},\n    ]\n  }\n\n\nSo I was saying for consistency it seems we should doc something like::\n\n   bgpvpns\tbody\tarray\tA list of bgpvpns objects.\n\n\n[1] http://docs-draft.openstack.org/96/390196/12/check/gate-neutron-lib-api-ref/1a0a45d//api-ref/build/html/v2/index.html?expanded\u003dlist-networks-detail#networks","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"   - networks: bgpvpn_networks"},{"line_number":39,"context_line":"   - routers: bgpvpn_routers"},{"line_number":40,"context_line":"   - tenant_id: tenant_id"},{"line_number":41,"context_line":"   - project_id: project_id"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Response Example"},{"line_number":44,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_6196ca4d","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":27},"updated":"2016-12-13 18:19:56.000000000","message":"This shows up as a \u0027path\u0027 parameter; shouldn\u0027t it be \u0027body\u0027? This comment applies to all api-refs herein.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17041b34021af4024092ce7d1984626d935db4d8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"   - networks: bgpvpn_networks"},{"line_number":39,"context_line":"   - routers: bgpvpn_routers"},{"line_number":40,"context_line":"   - tenant_id: tenant_id"},{"line_number":41,"context_line":"   - project_id: project_id"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Response Example"},{"line_number":44,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_4d0c2f3b","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":27},"in_reply_to":"1a6eadb0_37575927","updated":"2016-12-15 16:37:58.000000000","message":"Thanks","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"   - networks: bgpvpn_networks"},{"line_number":39,"context_line":"   - routers: bgpvpn_routers"},{"line_number":40,"context_line":"   - tenant_id: tenant_id"},{"line_number":41,"context_line":"   - project_id: project_id"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Response Example"},{"line_number":44,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_37575927","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":27},"in_reply_to":"1a6eadb0_6196ca4d","updated":"2016-12-15 09:58:58.000000000","message":"The issue is present for many other resources, and addressed in https://review.openstack.org/#/c/411170/","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"   - route_targets: bgpvpn_route_targets"},{"line_number":68,"context_line":"   - import_targets: bgpvpn_import_targets"},{"line_number":69,"context_line":"   - export_targets: bgpvpn_export_targets"},{"line_number":70,"context_line":"   - tenant_id: tenant_id"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Request Example"},{"line_number":73,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_a1c5423d","line":70,"updated":"2016-12-13 18:19:56.000000000","message":"No project_id here?? This comment applies for the other api-refs herein as well.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"   - route_targets: bgpvpn_route_targets"},{"line_number":68,"context_line":"   - import_targets: bgpvpn_import_targets"},{"line_number":69,"context_line":"   - export_targets: bgpvpn_export_targets"},{"line_number":70,"context_line":"   - tenant_id: tenant_id"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Request Example"},{"line_number":73,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1a6eadb0_f7a5e1a1","line":70,"in_reply_to":"1a6eadb0_a1c5423d","updated":"2016-12-15 09:58:58.000000000","message":"Good catch.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1c99fd7a64f9b7b3ef6068933ef8659e11462702","unresolved":false,"context_lines":[{"line_number":18,"context_line":".. rest_method::  GET /v2.0/bgpvpn/bgpvpns"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Lists BGP VPNs to which the tenant has access."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Normal response codes: 200"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Error response codes: 400, 401, 403"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da4df55a_2756b7d2","line":21,"updated":"2016-12-22 21:10:14.000000000","message":"Please add the description for fields as mentioned in [1]\n\n\n[1]https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L24-L28","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"680668fa4742a1e74683c2baf8af92d6f1109a27","unresolved":false,"context_lines":[{"line_number":18,"context_line":".. rest_method::  GET /v2.0/bgpvpn/bgpvpns"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Lists BGP VPNs to which the tenant has access."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Normal response codes: 200"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Error response codes: 400, 401, 403"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"ba5201f7_dc74d59d","line":21,"in_reply_to":"ba5201f7_c77c1275","updated":"2017-01-03 12:35:43.000000000","message":"I think that it would be much more efficient to provide this as global information for the whole Neutron API, or a as a paragraph in a .inc that would be included in the right places.","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":18,"context_line":".. rest_method::  GET /v2.0/bgpvpn/bgpvpns"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Lists BGP VPNs to which the tenant has access."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Normal response codes: 200"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Error response codes: 400, 401, 403"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"ba5201f7_c77c1275","line":21,"in_reply_to":"da4df55a_2756b7d2","updated":"2017-01-02 17:46:30.000000000","message":"Is this global functionality? It doesn\u0027t seem like it\u0027s specific to this method, but I\u0027ll add it for now. I think it\u0027s probably not a good idea though.","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1c99fd7a64f9b7b3ef6068933ef8659e11462702","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Normal response codes: 200"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Error response codes: 400, 401, 403"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Response Parameters"},{"line_number":27,"context_line":"-------------------"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da4df55a_4701fbad","line":25,"updated":"2016-12-22 21:10:14.000000000","message":"Please add Request section and fields as the request parameter as in [1].\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L34-L39","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Normal response codes: 200"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Error response codes: 400, 401, 403"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Response Parameters"},{"line_number":27,"context_line":"-------------------"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"ba5201f7_27db1e7e","line":25,"in_reply_to":"da4df55a_4701fbad","updated":"2017-01-02 17:46:30.000000000","message":"Done","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3e9975433de09c86431a1ce69aa92304f1c9de33","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - bgpvpns: bgpvpns"},{"line_number":32,"context_line":"   - id: bgpvpn_id_body"},{"line_number":33,"context_line":"   - name: bgpvpn_name"},{"line_number":34,"context_line":"   - type: bgpvpn_type"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1a6eadb0_079b0a67","line":31,"updated":"2016-12-21 16:03:36.000000000","message":"Got it here, but the other API request/response params didn\u0027t get updated. For example \u0027Create BGP VPNS\u0027 should include \u0027bgpvpn\u0027 object (this also applies to the other APIs).","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - bgpvpns: bgpvpns"},{"line_number":32,"context_line":"   - id: bgpvpn_id_body"},{"line_number":33,"context_line":"   - name: bgpvpn_name"},{"line_number":34,"context_line":"   - type: bgpvpn_type"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"ba5201f7_077d3a1c","line":31,"in_reply_to":"1a6eadb0_079b0a67","updated":"2017-01-02 17:46:30.000000000","message":"Done","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1c99fd7a64f9b7b3ef6068933ef8659e11462702","unresolved":false,"context_lines":[{"line_number":209,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"   - bgpvpn_id: bgpvpn_id_path"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da4df55a_87d84355","line":212,"updated":"2016-12-22 21:10:14.000000000","message":"Can you please add a Response section as in [1]?\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L292-L295","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":209,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"   - bgpvpn_id: bgpvpn_id_path"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"ba5201f7_67744635","line":212,"in_reply_to":"da4df55a_87d84355","updated":"2017-01-02 17:46:30.000000000","message":"Done","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1df676714b6930c6b8311774bf9b3445852fb35f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id-request"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Response Example"},{"line_number":58,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"7a3c09a3_0955534f","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":41},"updated":"2017-01-13 19:12:28.000000000","message":"Aren\u0027t these really the same thing? In the description for these the read differently and is a little confusing.","commit_id":"48ff4aa078d3b6ec323d44220645b875b4a11521"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"52ee3226ef9836eda19db65f71fba8190c79c123","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id-request"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Response Example"},{"line_number":58,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"7a3c09a3_4f9d9b64","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":41},"in_reply_to":"7a3c09a3_0955534f","updated":"2017-01-13 19:57:28.000000000","message":"The text for tenant_id-request is indeed not the one we want here.\nUsing \u0027tenant_id: tenant_id\u0027 would avoid this.","commit_id":"48ff4aa078d3b6ec323d44220645b875b4a11521"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c918946725df36e31cc677bb761fb3fbac239caa","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id-request"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Response Example"},{"line_number":58,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"7a3c09a3_4003730f","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":41},"in_reply_to":"7a3c09a3_4f9d9b64","updated":"2017-01-16 14:08:08.000000000","message":"Done","commit_id":"48ff4aa078d3b6ec323d44220645b875b4a11521"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1df676714b6930c6b8311774bf9b3445852fb35f","unresolved":false,"context_lines":[{"line_number":176,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"   - bgpvpn: bgpvpn"},{"line_number":179,"context_line":"   - bgpvpn_id: bgpvpn-id-path"},{"line_number":180,"context_line":"   - name: bgpvpn-name"},{"line_number":181,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":182,"context_line":"   - route_targets: bgpvpn-route_targets"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"7a3c09a3_49e67bb5","line":179,"updated":"2017-01-13 19:12:28.000000000","message":"Nit: ususally the path params come first I think (before body params).","commit_id":"48ff4aa078d3b6ec323d44220645b875b4a11521"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c918946725df36e31cc677bb761fb3fbac239caa","unresolved":false,"context_lines":[{"line_number":176,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"   - bgpvpn: bgpvpn"},{"line_number":179,"context_line":"   - bgpvpn_id: bgpvpn-id-path"},{"line_number":180,"context_line":"   - name: bgpvpn-name"},{"line_number":181,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":182,"context_line":"   - route_targets: bgpvpn-route_targets"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"7a3c09a3_3bbbfc0f","line":179,"in_reply_to":"7a3c09a3_49e67bb5","updated":"2017-01-16 14:08:08.000000000","message":"Done","commit_id":"48ff4aa078d3b6ec323d44220645b875b4a11521"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":10,"context_line":"A BGPVPN is created by the admin and given to a tenant who can then associate"},{"line_number":11,"context_line":"it to Networks or Routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The bgpvpns API lists, shows details for, creates, updates, and deletes BGP VPNs."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"List BGP VPNs"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_3f38b8d2","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":11},"updated":"2017-01-24 18:21:44.000000000","message":"-\u003e BGP VPNs?","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":10,"context_line":"A BGPVPN is created by the admin and given to a tenant who can then associate"},{"line_number":11,"context_line":"it to Networks or Routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The bgpvpns API lists, shows details for, creates, updates, and deletes BGP VPNs."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"List BGP VPNs"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_fb8bed65","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":11},"in_reply_to":"5a3905b3_3f38b8d2","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. rest_method::  GET /v2.0/bgpvpn/bgpvpns"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Lists BGP VPNs to which the tenant has access."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use the ``fields`` query parameter to control which fields are"},{"line_number":23,"context_line":"returned in the response body. Additionally, you can filter results"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_3f5c384a","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":34},"updated":"2017-01-24 18:21:44.000000000","message":"tenant -\u003e project","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. rest_method::  GET /v2.0/bgpvpn/bgpvpns"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Lists BGP VPNs to which the tenant has access."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use the ``fields`` query parameter to control which fields are"},{"line_number":23,"context_line":"returned in the response body. Additionally, you can filter results"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_bbdc0574","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":34},"in_reply_to":"5a3905b3_3f5c384a","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Normal response codes: 200"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Error response codes: 400, 401, 403"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Request"},{"line_number":33,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_76c0a62b","line":30,"range":{"start_line":30,"start_character":22,"end_line":30,"end_character":35},"updated":"2017-01-24 18:21:44.000000000","message":"Is there a case where 400 or 403 is returned?","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Normal response codes: 200"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Error response codes: 400, 401, 403"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Request"},{"line_number":33,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_9bc66998","line":30,"range":{"start_line":30,"start_character":22,"end_line":30,"end_character":35},"in_reply_to":"5a3905b3_76c0a62b","updated":"2017-01-31 14:16:29.000000000","message":"I don\u0027t know.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"   - bgpvpns: bgpvpns"},{"line_number":45,"context_line":"   - id: bgpvpn-id-body"},{"line_number":46,"context_line":"   - name: bgpvpn-name"},{"line_number":47,"context_line":"   - type: bgpvpn-type"},{"line_number":48,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":49,"context_line":"   - route_targets: bgpvpn-route_targets"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_962a722e","line":46,"range":{"start_line":46,"start_character":5,"end_line":46,"end_character":22},"updated":"2017-01-24 18:21:44.000000000","message":"name field always exists in a response, so \"name (Optional)\" looks incorrect.\n\nI see several fields in the response parameters are marked as optional, but I think they always exist in a response. If so, they should not be marked as optional.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"   - bgpvpns: bgpvpns"},{"line_number":45,"context_line":"   - id: bgpvpn-id-body"},{"line_number":46,"context_line":"   - name: bgpvpn-name"},{"line_number":47,"context_line":"   - type: bgpvpn-type"},{"line_number":48,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":49,"context_line":"   - route_targets: bgpvpn-route_targets"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_3bdad54c","line":46,"range":{"start_line":46,"start_character":5,"end_line":46,"end_character":22},"in_reply_to":"5a3905b3_962a722e","updated":"2017-01-31 14:16:29.000000000","message":"Yeah, I\u0027ve lost all enthusiasm for this generating documentation from YAML business. Filling up paramaters.yaml with blah-path, blah-body, blah-optional, blah-required is really a mess. It\u0027s a recipe for unintended consequences.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Response Example"},{"line_number":58,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_76c4265f","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":41},"updated":"2017-01-24 18:21:44.000000000","message":"I think project_id is enough. in parameters.yaml, project_id and project_id-body-required are same. I think project_id is used in more places.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Response Example"},{"line_number":58,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_7be0ddfa","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":41},"in_reply_to":"5a3905b3_76c4265f","updated":"2017-01-31 14:16:29.000000000","message":"They used to be different. Too many cooks in the kitchen.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Normal response codes: 201"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Error response codes: 401"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Request"},{"line_number":75,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_f6381640","line":72,"updated":"2017-01-24 18:21:44.000000000","message":"I think at least 400 can be returned. For example, if an invalid type is specified, 400 should be returned.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Normal response codes: 201"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Error response codes: 401"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Request"},{"line_number":75,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_755a88f3","line":72,"in_reply_to":"5a3905b3_f6381640","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":77,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"   - bgpvpn: bgpvpn"},{"line_number":80,"context_line":"   - name: bgpvpn-name"},{"line_number":81,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":82,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":83,"context_line":"   - import_targets: bgpvpn-import_targets"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_56ac8a8c","line":80,"range":{"start_line":80,"start_character":11,"end_line":80,"end_character":22},"updated":"2017-01-24 18:21:44.000000000","message":"Per my comment at L.46, you need a new parameter for \"optional\" like bgpvpn-name-request.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":77,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"   - bgpvpn: bgpvpn"},{"line_number":80,"context_line":"   - name: bgpvpn-name"},{"line_number":81,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":82,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":83,"context_line":"   - import_targets: bgpvpn-import_targets"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_7528c833","line":80,"range":{"start_line":80,"start_character":11,"end_line":80,"end_character":22},"in_reply_to":"5a3905b3_56ac8a8c","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9e78d594510a034b07a24e9f6ad901a02c2e5a23","unresolved":false,"context_lines":[{"line_number":84,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":85,"context_line":"   - tenant_id: tenant_id-request"},{"line_number":86,"context_line":"   - project_id: project_id-request"},{"line_number":87,"context_line":"   - type: bgpvpn-type"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Request Example"},{"line_number":90,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_6850030c","line":87,"range":{"start_line":87,"start_character":5,"end_line":87,"end_character":22},"updated":"2017-01-31 04:20:45.000000000","message":"Is this parameter required in POST?","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d030a77c9bdc48975bb0759b5b3ddd94bd2001bb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":85,"context_line":"   - tenant_id: tenant_id-request"},{"line_number":86,"context_line":"   - project_id: project_id-request"},{"line_number":87,"context_line":"   - type: bgpvpn-type"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Request Example"},{"line_number":90,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_d21c206c","line":87,"range":{"start_line":87,"start_character":5,"end_line":87,"end_character":22},"in_reply_to":"3a461143_15bdc4d7","updated":"2017-01-31 20:23:39.000000000","message":"It is not required (defaults to L3)","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":84,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":85,"context_line":"   - tenant_id: tenant_id-request"},{"line_number":86,"context_line":"   - project_id: project_id-request"},{"line_number":87,"context_line":"   - type: bgpvpn-type"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Request Example"},{"line_number":90,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_15bdc4d7","line":87,"range":{"start_line":87,"start_character":5,"end_line":87,"end_character":22},"in_reply_to":"3a461143_6850030c","updated":"2017-01-31 14:16:29.000000000","message":"I don\u0027t think so. I don\u0027t think it can be changed after creation.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Deletes a BGP VPN and its network and/or router associations."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Normal response codes: 202"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_1fd4dce9","line":223,"range":{"start_line":223,"start_character":23,"end_line":223,"end_character":26},"updated":"2017-01-24 18:21:44.000000000","message":"Does BGP VPN really return 202? 204 is usually returned in Neutron API.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Deletes a BGP VPN and its network and/or router associations."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Normal response codes: 202"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_35a720be","line":223,"range":{"start_line":223,"start_character":23,"end_line":223,"end_character":26},"in_reply_to":"5a3905b3_1fd4dce9","updated":"2017-01-31 14:16:29.000000000","message":"I don\u0027t know. I\u0027ll double check when Devstack is working again.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Normal response codes: 202"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"Request"},{"line_number":228,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_df0a5478","line":225,"range":{"start_line":225,"start_character":22,"end_line":225,"end_character":26},"updated":"2017-01-24 18:21:44.000000000","message":"When is 400 returned?","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Normal response codes: 202"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"Request"},{"line_number":228,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_9598d479","line":225,"range":{"start_line":225,"start_character":22,"end_line":225,"end_character":26},"in_reply_to":"5a3905b3_df0a5478","updated":"2017-01-31 14:16:29.000000000","message":"I don\u0027t know.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ed89079103d0b1d2d621c39a82f21f32684e2b84","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   - id: bgpvpn-id-body"},{"line_number":46,"context_line":"   - name: bgpvpn-name-required"},{"line_number":47,"context_line":"   - type: bgpvpn-type"},{"line_number":48,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":49,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":50,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":51,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_e2bcebdd","line":53,"range":{"start_line":48,"start_character":0,"end_line":53,"end_character":28},"updated":"2017-01-31 21:45:42.000000000","message":"These parameters show as optional. As they are response parameters they should be required.","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c86fc2cc93fc0cb531339bd891b454ee4f7e93d6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   - id: bgpvpn-id-body"},{"line_number":46,"context_line":"   - name: bgpvpn-name-required"},{"line_number":47,"context_line":"   - type: bgpvpn-type"},{"line_number":48,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":49,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":50,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":51,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_53702fa4","line":53,"range":{"start_line":48,"start_character":0,"end_line":53,"end_character":28},"in_reply_to":"3a461143_e2bcebdd","updated":"2017-01-31 23:03:55.000000000","message":"Done","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ed89079103d0b1d2d621c39a82f21f32684e2b84","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_a2c74362","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":25},"updated":"2017-01-31 21:45:42.000000000","message":"Replace tenant_id with project_id","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c86fc2cc93fc0cb531339bd891b454ee4f7e93d6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_736b6bb7","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":25},"in_reply_to":"3a461143_a2c74362","updated":"2017-01-31 23:03:55.000000000","message":"Done","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ed89079103d0b1d2d621c39a82f21f32684e2b84","unresolved":false,"context_lines":[{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Response Example"},{"line_number":58,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_6298fb78","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":41},"updated":"2017-01-31 21:45:42.000000000","message":"No need of a new parameter project_id-body-required. \"project-id\" will work in this case.","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c86fc2cc93fc0cb531339bd891b454ee4f7e93d6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"   - networks: bgpvpn-networks"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers"},{"line_number":54,"context_line":"   - tenant_id: tenant_id"},{"line_number":55,"context_line":"   - project_id: project_id-body-required"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Response Example"},{"line_number":58,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_936617eb","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":41},"in_reply_to":"3a461143_6298fb78","updated":"2017-01-31 23:03:55.000000000","message":"Done","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ed89079103d0b1d2d621c39a82f21f32684e2b84","unresolved":false,"context_lines":[{"line_number":101,"context_line":"   - id: bgpvpn-id-body"},{"line_number":102,"context_line":"   - name: bgpvpn-name-required"},{"line_number":103,"context_line":"   - type: bgpvpn-type"},{"line_number":104,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":105,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":106,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":107,"context_line":"   - networks: bgpvpn-networks"},{"line_number":108,"context_line":"   - routers: bgpvpn-routers"},{"line_number":109,"context_line":"   - tenant_id: tenant_id"},{"line_number":110,"context_line":"   - project_id: project_id-body-required"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Response Example"},{"line_number":113,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_02957731","line":110,"range":{"start_line":104,"start_character":0,"end_line":110,"end_character":41},"updated":"2017-01-31 21:45:42.000000000","message":"ditto","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c86fc2cc93fc0cb531339bd891b454ee4f7e93d6","unresolved":false,"context_lines":[{"line_number":101,"context_line":"   - id: bgpvpn-id-body"},{"line_number":102,"context_line":"   - name: bgpvpn-name-required"},{"line_number":103,"context_line":"   - type: bgpvpn-type"},{"line_number":104,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":105,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":106,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":107,"context_line":"   - networks: bgpvpn-networks"},{"line_number":108,"context_line":"   - routers: bgpvpn-routers"},{"line_number":109,"context_line":"   - tenant_id: tenant_id"},{"line_number":110,"context_line":"   - project_id: project_id-body-required"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Response Example"},{"line_number":113,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_b36153d5","line":110,"range":{"start_line":104,"start_character":0,"end_line":110,"end_character":41},"in_reply_to":"3a461143_02957731","updated":"2017-01-31 23:03:55.000000000","message":"Done","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ed89079103d0b1d2d621c39a82f21f32684e2b84","unresolved":false,"context_lines":[{"line_number":142,"context_line":"   - id: bgpvpn-id-body"},{"line_number":143,"context_line":"   - name: bgpvpn-name-required"},{"line_number":144,"context_line":"   - type: bgpvpn-type"},{"line_number":145,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":146,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":147,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":148,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":149,"context_line":"   - networks: bgpvpn-networks"},{"line_number":150,"context_line":"   - routers: bgpvpn-routers"},{"line_number":151,"context_line":"   - tenant_id: tenant_id"},{"line_number":152,"context_line":"   - project_id: project_id-body-required"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Response Example"},{"line_number":155,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_827a4722","line":152,"range":{"start_line":145,"start_character":0,"end_line":152,"end_character":41},"updated":"2017-01-31 21:45:42.000000000","message":"ditto","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c86fc2cc93fc0cb531339bd891b454ee4f7e93d6","unresolved":false,"context_lines":[{"line_number":142,"context_line":"   - id: bgpvpn-id-body"},{"line_number":143,"context_line":"   - name: bgpvpn-name-required"},{"line_number":144,"context_line":"   - type: bgpvpn-type"},{"line_number":145,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":146,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":147,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":148,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":149,"context_line":"   - networks: bgpvpn-networks"},{"line_number":150,"context_line":"   - routers: bgpvpn-routers"},{"line_number":151,"context_line":"   - tenant_id: tenant_id"},{"line_number":152,"context_line":"   - project_id: project_id-body-required"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Response Example"},{"line_number":155,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_d35c1f1b","line":152,"range":{"start_line":145,"start_character":0,"end_line":152,"end_character":41},"in_reply_to":"3a461143_827a4722","updated":"2017-01-31 23:03:55.000000000","message":"Done","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ed89079103d0b1d2d621c39a82f21f32684e2b84","unresolved":false,"context_lines":[{"line_number":198,"context_line":"   - id: bgpvpn-id-body"},{"line_number":199,"context_line":"   - name: bgpvpn-name-required"},{"line_number":200,"context_line":"   - type: bgpvpn-type"},{"line_number":201,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":202,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":203,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":204,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":205,"context_line":"   - networks: bgpvpn-networks"},{"line_number":206,"context_line":"   - routers: bgpvpn-routers"},{"line_number":207,"context_line":"   - tenant_id: tenant_id"},{"line_number":208,"context_line":"   - project_id: project_id-body-required"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Response Example"},{"line_number":211,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_82a16796","line":208,"range":{"start_line":201,"start_character":0,"end_line":208,"end_character":41},"updated":"2017-01-31 21:45:42.000000000","message":"ditto","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c86fc2cc93fc0cb531339bd891b454ee4f7e93d6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"   - id: bgpvpn-id-body"},{"line_number":199,"context_line":"   - name: bgpvpn-name-required"},{"line_number":200,"context_line":"   - type: bgpvpn-type"},{"line_number":201,"context_line":"   - route_distinguishers: bgpvpn-route_distinguishers"},{"line_number":202,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":203,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":204,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":205,"context_line":"   - networks: bgpvpn-networks"},{"line_number":206,"context_line":"   - routers: bgpvpn-routers"},{"line_number":207,"context_line":"   - tenant_id: tenant_id"},{"line_number":208,"context_line":"   - project_id: project_id-body-required"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Response Example"},{"line_number":211,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":22,"id":"3a461143_13a147f8","line":208,"range":{"start_line":201,"start_character":0,"end_line":208,"end_character":41},"in_reply_to":"3a461143_82a16796","updated":"2017-01-31 23:03:55.000000000","message":"Done","commit_id":"1711851f3c3632a597a976dd4ec559fa7d7e7b7c"}],"api-ref/source/v2/bgpvpn-caveats.inc":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45b46781b633a71dd77100a547c2a1c0a124672d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Association constraints"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"A said BGPVPN can be associated to multiple Networks and/or multiple"},{"line_number":11,"context_line":"Routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To avoid any ambiguity on semantics in particular the context of"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"5a74a57a_d8e83fe5","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":6},"updated":"2016-11-25 10:49:26.000000000","message":"\"given\" ?","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45b46781b633a71dd77100a547c2a1c0a124672d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To avoid any ambiguity on semantics in particular the context of"},{"line_number":14,"context_line":"processing associated to a Router (e.g. NAT or FWaaS), if a said Subnet"},{"line_number":15,"context_line":"in a Network is bound to a Router, this API does not allow to both"},{"line_number":16,"context_line":"associate the Network to an L3 BGPVPN and the Router to the same or to"},{"line_number":17,"context_line":"a distinct L3 BGPVPN."}],"source_content_type":"text/x-c++src","patch_set":8,"id":"5a74a57a_38ee93ec","line":14,"range":{"start_line":14,"start_character":60,"end_line":14,"end_character":64},"updated":"2016-11-25 10:49:26.000000000","message":"\"given\" ?","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"}],"api-ref/source/v2/bgpvpn-network_associations.inc":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9c51e0abc3d607b86c00a82892bc20d08e4b93d1","unresolved":false,"context_lines":[{"line_number":104,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"   - bgpvpn_id: bgpvpn_id"},{"line_number":107,"context_line":"   - network_id: bgpvpn_network_id"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Response Parameters"},{"line_number":110,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"da6895a0_7d4e5370","line":107,"range":{"start_line":107,"start_character":16,"end_line":107,"end_character":17},"updated":"2016-10-25 07:33:33.000000000","message":"Should be:\n\n   - network_association_id: bgpvpn_network_association_id","commit_id":"6219df398ceec5148ae1900f1cb45c20994d6278"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"8849aaa7554d9aeb669317cbeb457ae6d30cff59","unresolved":false,"context_lines":[{"line_number":104,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"   - bgpvpn_id: bgpvpn_id"},{"line_number":107,"context_line":"   - network_id: bgpvpn_network_id"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Response Parameters"},{"line_number":110,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ba5da102_c446f4be","line":107,"range":{"start_line":107,"start_character":4,"end_line":107,"end_character":34},"updated":"2016-10-26 21:56:46.000000000","message":"This line wasn\u0027t fixed, instead line 115 was modified (and is wrong now).","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8b91a3abeb1bf749c112e90243d728dd199e0e2b","unresolved":false,"context_lines":[{"line_number":104,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"   - bgpvpn_id: bgpvpn_id"},{"line_number":107,"context_line":"   - network_id: bgpvpn_network_id"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Response Parameters"},{"line_number":110,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ba5da102_e58daf7c","line":107,"range":{"start_line":107,"start_character":4,"end_line":107,"end_character":34},"in_reply_to":"ba5da102_c446f4be","updated":"2016-10-27 07:38:17.000000000","message":"Done","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"8849aaa7554d9aeb669317cbeb457ae6d30cff59","unresolved":false,"context_lines":[{"line_number":112,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"   - id: bgpvpn_network_association_id"},{"line_number":115,"context_line":"   - network_association_id: bgpvpn_network_association_id"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Response Example"},{"line_number":118,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ba5da102_643fe825","line":115,"range":{"start_line":115,"start_character":5,"end_line":115,"end_character":58},"updated":"2016-10-26 21:56:46.000000000","message":"Said above, you applied my suggestion to the wrong line.\nPrevious line 115 was good.","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8b91a3abeb1bf749c112e90243d728dd199e0e2b","unresolved":false,"context_lines":[{"line_number":112,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"   - id: bgpvpn_network_association_id"},{"line_number":115,"context_line":"   - network_association_id: bgpvpn_network_association_id"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Response Example"},{"line_number":118,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ba5da102_05e9c31a","line":115,"range":{"start_line":115,"start_character":5,"end_line":115,"end_character":58},"in_reply_to":"ba5da102_643fe825","updated":"2016-10-27 07:38:17.000000000","message":"Done","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":".. needs:method_verification"},{"line_number":3,"context_line":".. needs:parameter_verification"},{"line_number":4,"context_line":".. needs:example_verification"},{"line_number":5,"context_line":".. needs:body_verification"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Network Associations"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_3a070283","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":26},"updated":"2016-11-29 00:15:57.000000000","message":"I hope this patch doesn\u0027t need these checks.","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":39,"context_line":"-------------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"   - id: bgpvpn_network_association_id"},{"line_number":44,"context_line":"   - network_id: bgpvpn_network_id"},{"line_number":45,"context_line":"   - tenant_id: tenant_id"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_da3d2e2c","line":42,"updated":"2016-11-29 00:15:57.000000000","message":"nit: Could you consider to add \"network_associations\" which has description like \"A list of network_association objects.\"?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Normal response codes: 201"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Error response codes: 401, 400"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Request"},{"line_number":65,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_1ae08695","line":62,"range":{"start_line":62,"start_character":22,"end_line":62,"end_character":30},"updated":"2016-11-29 00:15:57.000000000","message":"What happens when bgpvpn_id and network_id don\u0027t exist?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   - id: bgpvpn_network_association_id"},{"line_number":84,"context_line":"   - network_id: bgpvpn_network_id"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Response Example"},{"line_number":87,"context_line":"----------------"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_dad9aef4","line":85,"updated":"2016-11-29 00:15:57.000000000","message":"tenant_id as well?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Normal response codes: 200"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Error response codes: 401, 403"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Request"},{"line_number":104,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_da00ce36","line":101,"range":{"start_line":101,"start_character":22,"end_line":101,"end_character":30},"updated":"2016-11-29 00:15:57.000000000","message":"What happens when bgpvpn_id and network_association_id don\u0027t exist?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ba40cdfbdd2c01cd851e88d10e48f9f5fadee148","unresolved":false,"context_lines":[{"line_number":106,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"   - bgpvpn_id: bgpvpn_id"},{"line_number":109,"context_line":"   - network_association_id: bgpvpn_network_association_id"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Response Parameters"},{"line_number":112,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_dc6c2ad2","line":109,"range":{"start_line":109,"start_character":5,"end_line":109,"end_character":27},"updated":"2016-11-29 14:52:32.000000000","message":"This renders into \"network_association_id  | body  | ...\" in the table, while it should be \"path\".\n\nI don\u0027t know how that can be fixed, but this is incorrect.\n\n(same issue in Delete)","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1c99fd7a64f9b7b3ef6068933ef8659e11462702","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   - bgpvpn_id: bgpvpn_id_path"},{"line_number":138,"context_line":"   - network_association_id: bgpvpn_network_association_id_path"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"da4df55a_07cc5388","line":139,"updated":"2016-12-22 21:10:14.000000000","message":"ditto","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   - bgpvpn_id: bgpvpn_id_path"},{"line_number":138,"context_line":"   - network_association_id: bgpvpn_network_association_id_path"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"ba5201f7_a7cc6e36","line":139,"in_reply_to":"da4df55a_07cc5388","updated":"2017-01-02 17:46:30.000000000","message":"Done","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"90c49905615553d05c4d0f91231bb19e91de89a0","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   - network_association: bgpvpn-network_association"},{"line_number":82,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":83,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Response Example"},{"line_number":86,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"ba5201f7_42d55eb7","line":83,"updated":"2017-01-03 14:15:18.000000000","message":"The sample response shows \u0027tenant_id\u0027 as a param, but it\u0027s not documented here.","commit_id":"83f19d031f5d120bd861c53c4c3c74a345905fb8"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"010ab03cc3ce4cc72cea6e244c93bd78c1d1ceab","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   - network_association: bgpvpn-network_association"},{"line_number":82,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":83,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Response Example"},{"line_number":86,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"7a3c09a3_c92a92e7","line":83,"in_reply_to":"ba5201f7_42d55eb7","updated":"2017-01-13 03:06:45.000000000","message":"Done","commit_id":"83f19d031f5d120bd861c53c4c3c74a345905fb8"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"8523f200a7f9bb715d7e37d188bcbd1e656bd0f2","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   - network_association: bgpvpn-network_association"},{"line_number":82,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":83,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Response Example"},{"line_number":86,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"ba5201f7_6ac3d8ed","line":83,"in_reply_to":"ba5201f7_42d55eb7","updated":"2017-01-04 22:34:53.000000000","message":"We can indeed add it, along with project_id, to both network and router association resources, in the create requests and in all responses to GET, PUT and POST requests.","commit_id":"83f19d031f5d120bd861c53c4c3c74a345905fb8"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"43e298b3d2b6865acc38b3283f339dec41d82b21","unresolved":false,"context_lines":[{"line_number":65,"context_line":"   - network_association: bgpvpn-network_association"},{"line_number":66,"context_line":"   - bgpvpn_id: bgpvpn-id-path"},{"line_number":67,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":68,"context_line":"   - tenant_id: tenant_id-request"},{"line_number":69,"context_line":"   - project_id: project_id-request"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Request Example"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"7a3c09a3_50963e95","line":69,"range":{"start_line":68,"start_character":0,"end_line":69,"end_character":35},"updated":"2017-01-13 08:56:48.000000000","message":"These should not appear here (as correctly documented for router association). The API does not allow to choose for an association a different ownership than the one of the associated BGPVPN.","commit_id":"517cc816a06375b2d5d1d7bf771ad73b50215162"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"e2917c1a3a4f66b6d918a6aca2a42b4c8576750a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"   - network_association: bgpvpn-network_association"},{"line_number":66,"context_line":"   - bgpvpn_id: bgpvpn-id-path"},{"line_number":67,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":68,"context_line":"   - tenant_id: tenant_id-request"},{"line_number":69,"context_line":"   - project_id: project_id-request"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Request Example"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"7a3c09a3_03cff27f","line":69,"range":{"start_line":68,"start_character":0,"end_line":69,"end_character":35},"in_reply_to":"7a3c09a3_50963e95","updated":"2017-01-13 18:26:37.000000000","message":"Done","commit_id":"517cc816a06375b2d5d1d7bf771ad73b50215162"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"058f153692ee2fb6e2c5ba2776ac12e553316b81","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Associating or disassociating a BGPVPN to a Network is done by manipulating a"},{"line_number":12,"context_line":"Network association API resource as a sub-resource of the BGPVPN resource:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"List Network Associations"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".. rest_method::  GET /v2.0/bgpvpn/bgpvpns/{bgpvpn_id}/network_associations"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_15b3dd98","line":14,"updated":"2017-01-24 17:17:38.000000000","message":"Do the \u0027fields\u0027 (query params) apply to these top-level sub-resources as well (and the others in this patch)?","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Associating or disassociating a BGPVPN to a Network is done by manipulating a"},{"line_number":12,"context_line":"Network association API resource as a sub-resource of the BGPVPN resource:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"List Network Associations"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".. rest_method::  GET /v2.0/bgpvpn/bgpvpns/{bgpvpn_id}/network_associations"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_189d1fbc","line":14,"in_reply_to":"5a3905b3_15b3dd98","updated":"2017-01-31 14:16:29.000000000","message":"I don\u0027t know. Devstack is broken yet again, but if I can get the stupid thing working again I\u0027ll try using fields. I still think it\u0027s dumb to copy and paste the same text into lots of different API reference documents. But if copy and paste is what people want, that\u0027s what I\u0027ll do.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Normal response codes: 200"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Request"},{"line_number":26,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_36645ee4","line":23,"updated":"2017-01-24 18:21:44.000000000","message":"I wonder 404 and 403 can be returned for LIST operation.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9e78d594510a034b07a24e9f6ad901a02c2e5a23","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Normal response codes: 200"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Request"},{"line_number":26,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_1d933ffb","line":23,"in_reply_to":"5a3905b3_36645ee4","updated":"2017-01-31 04:20:45.000000000","message":"I guess that it may return 404 when passing invalid bgpvpn_id. Anyway, I think that this API doesn\u0027t return 400.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Normal response codes: 200"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Request"},{"line_number":26,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_9874af68","line":23,"in_reply_to":"5a3905b3_36645ee4","updated":"2017-01-31 14:16:29.000000000","message":"I suppose a 404 might happen if an incorrect bgpvpn_id were specified. I would imagine that some RBAC configuration could possibly generate a 403 but I don\u0027t know how to test that.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   - network_associations: bgpvpn-network_associations"},{"line_number":38,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":39,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":40,"context_line":"   - tenant_id: tenant_id"},{"line_number":41,"context_line":"   - project_id: project_id-body-required"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_f6a816de","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":25},"updated":"2017-01-24 18:21:44.000000000","message":"-\u003e project_id\n\nNote that tenant_id in parameters.yaml will be removed soon.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   - network_associations: bgpvpn-network_associations"},{"line_number":38,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":39,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":40,"context_line":"   - tenant_id: tenant_id"},{"line_number":41,"context_line":"   - project_id: project_id-body-required"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_188a7f1b","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":25},"in_reply_to":"5a3905b3_f6a816de","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":38,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":39,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":40,"context_line":"   - tenant_id: tenant_id"},{"line_number":41,"context_line":"   - project_id: project_id-body-required"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Response Example"},{"line_number":44,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_36929ea0","line":41,"range":{"start_line":41,"start_character":17,"end_line":41,"end_character":41},"updated":"2017-01-24 18:21:44.000000000","message":"I think project_id is enough.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":38,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":39,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":40,"context_line":"   - tenant_id: tenant_id"},{"line_number":41,"context_line":"   - project_id: project_id-body-required"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Response Example"},{"line_number":44,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_d8c63767","line":41,"range":{"start_line":41,"start_character":17,"end_line":41,"end_character":41},"in_reply_to":"5a3905b3_36929ea0","updated":"2017-01-31 14:16:29.000000000","message":"project_id used to be a path parameter, but I guess somebody changed that.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":80,"context_line":"   - network_association: bgpvpn-network_association"},{"line_number":81,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":82,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":83,"context_line":"   - tenant_id: tenant_id"},{"line_number":84,"context_line":"   - project_id: project_id-body-required"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_967272af","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":25},"updated":"2017-01-24 18:21:44.000000000","message":"-\u003e project_id","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":80,"context_line":"   - network_association: bgpvpn-network_association"},{"line_number":81,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":82,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":83,"context_line":"   - tenant_id: tenant_id"},{"line_number":84,"context_line":"   - project_id: project_id-body-required"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_58aec781","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":25},"in_reply_to":"5a3905b3_967272af","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Normal response codes: 200"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Error response codes: 401, 403, 404"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Request"},{"line_number":104,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_363d3ebc","line":101,"range":{"start_line":101,"start_character":27,"end_line":101,"end_character":30},"updated":"2017-01-24 18:21:44.000000000","message":"Is there a case where 403 is returned?\nIf it is allowed by policy, 404 will be returned for such case.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Normal response codes: 200"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Error response codes: 401, 403, 404"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Request"},{"line_number":104,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_780f0388","line":101,"range":{"start_line":101,"start_character":27,"end_line":101,"end_character":30},"in_reply_to":"5a3905b3_363d3ebc","updated":"2017-01-31 14:16:29.000000000","message":"I think 403 would be the correct response if an attempt is made to show a network association with incorrect credentials.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":116,"context_line":"   - network_association: bgpvpn-network_association"},{"line_number":117,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":118,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":119,"context_line":"   - tenant_id: tenant_id"},{"line_number":120,"context_line":"   - project_id: project_id-body-required"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_16120259","line":119,"range":{"start_line":119,"start_character":16,"end_line":119,"end_character":25},"updated":"2017-01-24 18:21:44.000000000","message":"-\u003e project_id\n\nIf you change it to project_id, \"(Optional)\" will go away.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":116,"context_line":"   - network_association: bgpvpn-network_association"},{"line_number":117,"context_line":"   - id: bgpvpn-network_association_id"},{"line_number":118,"context_line":"   - network_id: bgpvpn-network_id"},{"line_number":119,"context_line":"   - tenant_id: tenant_id"},{"line_number":120,"context_line":"   - project_id: project_id-body-required"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_d575fc31","line":119,"range":{"start_line":119,"start_character":16,"end_line":119,"end_character":25},"in_reply_to":"5a3905b3_16120259","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9e78d594510a034b07a24e9f6ad901a02c2e5a23","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Deletes a network association."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Normal response codes: 202, 204"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_bd46ab78","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":31},"updated":"2017-01-31 04:20:45.000000000","message":"Just question: I feel strange that there are two normal response codes although I\u0027m not good about BGP VPN. When are they returned?","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Deletes a network association."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Normal response codes: 202, 204"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_b5f6b08c","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":31},"in_reply_to":"3a461143_bd46ab78","updated":"2017-01-31 14:16:29.000000000","message":"I don\u0027t know how to figure out what all possible response codes are. I can test what code is most common but I don\u0027t know how to find out if there\u0027s a less common code other than guessing what\u0027s reasonable.\n204 would be the expected code if the delete request has been completed, but 202 would be expected if the delete request has been accepted but not completed immediately.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Normal response codes: 202, 204"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Request"},{"line_number":140,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_b31b0080","line":137,"updated":"2017-01-24 18:21:44.000000000","message":"Can 400 be returned for DELETE request?\n\nIn addition, is there a case where 403 is returned?\nIf it is allowed by policy, 404 will be returned for such case.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Normal response codes: 202, 204"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Request"},{"line_number":140,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_9b6ae9b1","line":137,"in_reply_to":"5a3905b3_b31b0080","updated":"2017-01-31 14:16:29.000000000","message":"Probably not, but I don\u0027t know how to test it.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"}],"api-ref/source/v2/bgpvpn-overview.inc":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":2,"context_line":"BGP - MPLS VPN Overview"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The BGP VPN API provides the ability to associate Neutron networks"},{"line_number":6,"context_line":"and/or routers with Multiprotocol Label Switching (MPLS) Virtual"},{"line_number":7,"context_line":"Private Networks (VPNs) via Border Gateway Patrol (BGP) peering."},{"line_number":8,"context_line":"BGP-MPLS VPNs are commonly provided by telecommuncations service"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_4966b2ed","line":5,"range":{"start_line":5,"start_character":50,"end_line":5,"end_character":57},"updated":"2017-01-24 18:21:44.000000000","message":"I think we don\u0027t use a keyword \"Neutron\" and use OpenStack or Networking instead. How about \"OpenStack networks\"?","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":2,"context_line":"BGP - MPLS VPN Overview"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The BGP VPN API provides the ability to associate Neutron networks"},{"line_number":6,"context_line":"and/or routers with Multiprotocol Label Switching (MPLS) Virtual"},{"line_number":7,"context_line":"Private Networks (VPNs) via Border Gateway Patrol (BGP) peering."},{"line_number":8,"context_line":"BGP-MPLS VPNs are commonly provided by telecommuncations service"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_b53dd02c","line":5,"range":{"start_line":5,"start_character":50,"end_line":5,"end_character":57},"in_reply_to":"5a3905b3_4966b2ed","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":17,"context_line":"``route_targets``, ``import_targets``, ``export_targets`` attributes"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  - The set of RTs used for import is the union of ``route_targets`` and ``import_targets``."},{"line_number":20,"context_line":"  - The set of RTs used for export is the union of ``route_targets`` and ``export_targets``."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"At least one of ``route_targets``, ``import_targets`` or ``export_targets`` options will"},{"line_number":23,"context_line":"typically be defined, but the API will not enforce that and all lists can be"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_097e6a69","line":20,"updated":"2017-01-24 18:21:44.000000000","message":"In L.19-20, the spaces at the beginning of lines are unnecessary.\nOtherwise we will see unnecessary vertical lines in HTML [0].\n\n[0] http://docs-draft.openstack.org/96/390196/20/check/gate-neutron-lib-api-ref/39f9907//api-ref/build/html/v2/index.html#bgp-mpls-vpn-interconnection","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":17,"context_line":"``route_targets``, ``import_targets``, ``export_targets`` attributes"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  - The set of RTs used for import is the union of ``route_targets`` and ``import_targets``."},{"line_number":20,"context_line":"  - The set of RTs used for export is the union of ``route_targets`` and ``export_targets``."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"At least one of ``route_targets``, ``import_targets`` or ``export_targets`` options will"},{"line_number":23,"context_line":"typically be defined, but the API will not enforce that and all lists can be"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_b524f00c","line":20,"in_reply_to":"5a3905b3_097e6a69","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":23,"context_line":"typically be defined, but the API will not enforce that and all lists can be"},{"line_number":24,"context_line":"empty."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"For instance, in the very typical use case where the BGPVPN uses a single"},{"line_number":27,"context_line":"Route Target for both import and export, the route_targets parameter alone is"},{"line_number":28,"context_line":"enough and will contain one Route target."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_2428ad99","line":26,"range":{"start_line":26,"start_character":53,"end_line":26,"end_character":59},"updated":"2017-01-24 18:21:44.000000000","message":"You use BGPVPN and BGP VPN. What is the difference? It not, either of them should be used.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":23,"context_line":"typically be defined, but the API will not enforce that and all lists can be"},{"line_number":24,"context_line":"empty."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"For instance, in the very typical use case where the BGPVPN uses a single"},{"line_number":27,"context_line":"Route Target for both import and export, the route_targets parameter alone is"},{"line_number":28,"context_line":"enough and will contain one Route target."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_f552f833","line":26,"range":{"start_line":26,"start_character":53,"end_line":26,"end_character":59},"in_reply_to":"5a3905b3_2428ad99","updated":"2017-01-31 14:16:29.000000000","message":"No difference that I know of.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"For instance, in the very typical use case where the BGPVPN uses a single"},{"line_number":27,"context_line":"Route Target for both import and export, the route_targets parameter alone is"},{"line_number":28,"context_line":"enough and will contain one Route target."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"On Route Distinguishers"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_e9567ecc","line":28,"updated":"2017-01-24 18:21:44.000000000","message":"Just from my curiosity, what is the use case where all lists are empty?","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"For instance, in the very typical use case where the BGPVPN uses a single"},{"line_number":27,"context_line":"Route Target for both import and export, the route_targets parameter alone is"},{"line_number":28,"context_line":"enough and will contain one Route target."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"On Route Distinguishers"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_807ed467","line":28,"in_reply_to":"5a3905b3_e9567ecc","updated":"2017-01-31 14:16:29.000000000","message":"None. At least one list needs to have at least one route target in it to be useful. But any list can be empty and the code does not cross validate.\n\nThere\u0027s no harm in all the lists being empty, it just won\u0027t do anything. For comparison, consider the fact that Neutron lets you create a port and not attach it to anything. It\u0027s not useful, but presumably you plan to eventually do something with it. Even if you don\u0027t, it doesn\u0027t break anything.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The ``route_distinguishers`` parameter is optional and provides an"},{"line_number":34,"context_line":"indication of the RDs that shall be used for routes announced for"},{"line_number":35,"context_line":"Neutron networks. The contract is that when a list of RDs is specified,"},{"line_number":36,"context_line":"the backend will use, for a said advertisement of a route, one of these"},{"line_number":37,"context_line":"RDs. The motivation for having a list rather than only one RD is to"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_a9a396b0","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":21},"updated":"2017-01-24 18:21:44.000000000","message":"I think RD is an abbrev of router distinguishers. It is the first use of RD. It is better to use full spelling: router distinguishers (RDs).","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The ``route_distinguishers`` parameter is optional and provides an"},{"line_number":34,"context_line":"indication of the RDs that shall be used for routes announced for"},{"line_number":35,"context_line":"Neutron networks. The contract is that when a list of RDs is specified,"},{"line_number":36,"context_line":"the backend will use, for a said advertisement of a route, one of these"},{"line_number":37,"context_line":"RDs. The motivation for having a list rather than only one RD is to"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_403dcc8d","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":21},"in_reply_to":"5a3905b3_a9a396b0","updated":"2017-01-31 14:16:29.000000000","message":"It\u0027s an abbreviation of \"Route Distinguishers\" which appears in both the section heading on line 30 and in double backticks on the preceding line. I can add (RD) to the heading in line 30 if you like.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":39,"context_line":"resiliency, load balancing or anycast). A backend may or may not"},{"line_number":40,"context_line":"support this behavior, and should report an API error in the latter"},{"line_number":41,"context_line":"case. When not specified, the backend will use automatically-assigned"},{"line_number":42,"context_line":"RDs (for instance \u003cip\u003e:\u003cnumber\u003e RDs derived from the PE IP)."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Valid strings for Route Distinguishers and Route Targets"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_89ec1abc","line":42,"range":{"start_line":42,"start_character":53,"end_line":42,"end_character":55},"updated":"2017-01-24 18:21:44.000000000","message":"If exists, full name of PE is used here as it is the first appearance of PE.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":39,"context_line":"resiliency, load balancing or anycast). A backend may or may not"},{"line_number":40,"context_line":"support this behavior, and should report an API error in the latter"},{"line_number":41,"context_line":"case. When not specified, the backend will use automatically-assigned"},{"line_number":42,"context_line":"RDs (for instance \u003cip\u003e:\u003cnumber\u003e RDs derived from the PE IP)."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Valid strings for Route Distinguishers and Route Targets"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_4064ecb7","line":42,"range":{"start_line":42,"start_character":53,"end_line":42,"end_character":55},"in_reply_to":"5a3905b3_89ec1abc","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  - \u003c2-byte AS#\u003e:\u003c32bit-number\u003e"},{"line_number":50,"context_line":"  - \u003c4-byte AS#\u003e:\u003c16bit-number\u003e"},{"line_number":51,"context_line":"  - \u003c4-byte IPv4\u003e:\u003c16bit-number\u003e"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":"BGP - MPLS VPN Caveats"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_292966e6","line":51,"updated":"2017-01-24 18:21:44.000000000","message":"No preceding spaces are unnecessary (as for L.20).","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  - \u003c2-byte AS#\u003e:\u003c32bit-number\u003e"},{"line_number":50,"context_line":"  - \u003c4-byte AS#\u003e:\u003c16bit-number\u003e"},{"line_number":51,"context_line":"  - \u003c4-byte IPv4\u003e:\u003c16bit-number\u003e"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":"BGP - MPLS VPN Caveats"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_a0fcb0b8","line":51,"in_reply_to":"5a3905b3_292966e6","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Association constraints"},{"line_number":58,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"A given BGPVPN can be associated to multiple Networks and/or multiple"},{"line_number":61,"context_line":"Routers."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"To avoid any ambiguity on semantics in particular the context of"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"5a3905b3_84f6c15a","line":60,"range":{"start_line":60,"start_character":45,"end_line":60,"end_character":53},"updated":"2017-01-24 18:21:44.000000000","message":"No need to capitalize it. This applies to all others like Router and Subnet.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Association constraints"},{"line_number":58,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"A given BGPVPN can be associated to multiple Networks and/or multiple"},{"line_number":61,"context_line":"Routers."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"To avoid any ambiguity on semantics in particular the context of"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_80b254e3","line":60,"range":{"start_line":60,"start_character":45,"end_line":60,"end_character":53},"in_reply_to":"5a3905b3_84f6c15a","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3a8c312744bef39331abda2255629e658520179b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"BGP - MPLS VPN Overview"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The BGP VPN API provides the ability to associate OpenStack networks"},{"line_number":6,"context_line":"and/or routers with Multiprotocol Label Switching (MPLS) Virtual"},{"line_number":7,"context_line":"Private Networks (VPNs) via Border Gateway Patrol (BGP) peering."},{"line_number":8,"context_line":"BGP-MPLS VPNs are commonly provided by telecommuncations service"}],"source_content_type":"text/x-c++src","patch_set":29,"id":"fa31d9ce_c4168b54","line":5,"updated":"2017-02-13 14:03:16.000000000","message":"It would be nice to note which extension (alias) provides this functionality so that consumers could query for the extension. Perhaps we can add that later.","commit_id":"1e4b54fbb51fbecea53d90fce8e8975f07e9ed4c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"e3106cc9fa69fac780be4310009210938fcd3df5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"BGP - MPLS VPN Overview"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The BGP VPN API provides the ability to associate OpenStack networks"},{"line_number":6,"context_line":"and/or routers with Multiprotocol Label Switching (MPLS) Virtual"},{"line_number":7,"context_line":"Private Networks (VPNs) via Border Gateway Patrol (BGP) peering."},{"line_number":8,"context_line":"BGP-MPLS VPNs are commonly provided by telecommuncations service"}],"source_content_type":"text/x-c++src","patch_set":29,"id":"fa31d9ce_dade666c","line":5,"in_reply_to":"fa31d9ce_3f7e94ae","updated":"2017-02-13 14:22:21.000000000","message":"Keeping \"BGP VPN API\" is I believe better here (or even better: \"BGP VPN Interconnection API\").\n\nWe can indicate via which extension this API is accessed with a sentence like this (to be put for instance before \"On Route Targets\"):  \"This capability is accessed via the \u0027bgpvpn\u0027 API extension.\"","commit_id":"1e4b54fbb51fbecea53d90fce8e8975f07e9ed4c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4aa324be00332f7344830c4bb8d83f13cb466de9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"BGP - MPLS VPN Overview"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The BGP VPN API provides the ability to associate OpenStack networks"},{"line_number":6,"context_line":"and/or routers with Multiprotocol Label Switching (MPLS) Virtual"},{"line_number":7,"context_line":"Private Networks (VPNs) via Border Gateway Patrol (BGP) peering."},{"line_number":8,"context_line":"BGP-MPLS VPNs are commonly provided by telecommuncations service"}],"source_content_type":"text/x-c++src","patch_set":29,"id":"fa31d9ce_ff4cf971","line":5,"in_reply_to":"fa31d9ce_9c394b44","updated":"2017-02-13 14:44:03.000000000","message":"This would work for me as well.\nWe are at this point at a very fine word tuning level :)","commit_id":"1e4b54fbb51fbecea53d90fce8e8975f07e9ed4c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"66a2b550f789116aa374a77f4ab3ff7c9d4fc9dc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"BGP - MPLS VPN Overview"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The BGP VPN API provides the ability to associate OpenStack networks"},{"line_number":6,"context_line":"and/or routers with Multiprotocol Label Switching (MPLS) Virtual"},{"line_number":7,"context_line":"Private Networks (VPNs) via Border Gateway Patrol (BGP) peering."},{"line_number":8,"context_line":"BGP-MPLS VPNs are commonly provided by telecommuncations service"}],"source_content_type":"text/x-c++src","patch_set":29,"id":"fa31d9ce_3f7e94ae","line":5,"in_reply_to":"fa31d9ce_c4168b54","updated":"2017-02-13 14:18:09.000000000","message":"Do you just mean changing \"BGP VPN API\" to ``bgpvpn``? Sure, no problem.","commit_id":"1e4b54fbb51fbecea53d90fce8e8975f07e9ed4c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"70291c4796bbb1628a22348add5c6ee586202cd1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"BGP - MPLS VPN Overview"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The BGP VPN API provides the ability to associate OpenStack networks"},{"line_number":6,"context_line":"and/or routers with Multiprotocol Label Switching (MPLS) Virtual"},{"line_number":7,"context_line":"Private Networks (VPNs) via Border Gateway Patrol (BGP) peering."},{"line_number":8,"context_line":"BGP-MPLS VPNs are commonly provided by telecommuncations service"}],"source_content_type":"text/x-c++src","patch_set":29,"id":"fa31d9ce_9c394b44","line":5,"in_reply_to":"fa31d9ce_dade666c","updated":"2017-02-13 14:40:00.000000000","message":"I looked at other sections of the API ref and \"The \u003cblank\u003e extension\" seems common although not 100% consistent. How about:\n\n\"The ``bgpvpn`` extension implements the BGP VPN Interconnection API whcih provides the ability ...\"","commit_id":"1e4b54fbb51fbecea53d90fce8e8975f07e9ed4c"}],"api-ref/source/v2/bgpvpn-router_associations.inc":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":".. needs:method_verification"},{"line_number":3,"context_line":".. needs:parameter_verification"},{"line_number":4,"context_line":".. needs:example_verification"},{"line_number":5,"context_line":".. needs:body_verification"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Router Associations"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_bafb1278","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":26},"updated":"2016-11-29 00:15:57.000000000","message":"I hope this patch doesn\u0027t need these checks.","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Normal response codes: 200"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Response Parameters"},{"line_number":32,"context_line":"-------------------"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_fa92eaf4","line":30,"updated":"2016-11-29 00:15:57.000000000","message":"This API needs request parameter includes \"bgpvpn_id\".","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ba40cdfbdd2c01cd851e88d10e48f9f5fadee148","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Normal response codes: 200"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Response Parameters"},{"line_number":32,"context_line":"-------------------"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_9c39d2a6","line":30,"in_reply_to":"5a74a57a_fa92eaf4","updated":"2016-11-29 14:52:32.000000000","message":"I think the definition is correct, because {bgpvpn_id} is in the GET URL path.","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"   - bgpvpn_id: bgpvpn_id"},{"line_number":37,"context_line":"   - id: bgpvpn_router_association_id"},{"line_number":38,"context_line":"   - router_id: bgpvpn_router_id"},{"line_number":39,"context_line":"   - tenant_id: tenant_id"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_1a8ec6cf","line":36,"range":{"start_line":36,"start_character":5,"end_line":36,"end_character":25},"updated":"2016-11-29 00:15:57.000000000","message":"So this is request parameter.","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Normal response codes: 201"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Error response codes: 401, 400"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Request"},{"line_number":59,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_9ab81677","line":56,"range":{"start_line":56,"start_character":22,"end_line":56,"end_character":30},"updated":"2016-11-29 00:15:57.000000000","message":"What happens when bgpvpn_id and router_id don\u0027t exist?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"   - bgpvpn_id: bgpvpn_id"},{"line_number":78,"context_line":"   - id: bgpvpn_router_association_id"},{"line_number":79,"context_line":"   - router_id: bgpvpn_router_id"},{"line_number":80,"context_line":"   - tenant_id: tenant_id"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_da752ecb","line":77,"range":{"start_line":77,"start_character":5,"end_line":77,"end_character":25},"updated":"2016-11-29 00:15:57.000000000","message":"This is request parameter.","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20a8b62cb030d8968add78ff5434968b67640805","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Normal response codes: 200"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Error response codes: 401, 403"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Request"},{"line_number":100,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_3a4d429a","line":97,"range":{"start_line":97,"start_character":22,"end_line":97,"end_character":30},"updated":"2016-11-29 00:15:57.000000000","message":"What happens when bgpvpn_id and router_association_id don\u0027t exist?","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ba40cdfbdd2c01cd851e88d10e48f9f5fadee148","unresolved":false,"context_lines":[{"line_number":102,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"   - bgpvpn_id: bgpvpn_id"},{"line_number":105,"context_line":"   - router_association_id: bgpvpn_router_association_id"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Response Parameters"},{"line_number":108,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_9c0712c9","line":105,"range":{"start_line":105,"start_character":5,"end_line":105,"end_character":26},"updated":"2016-11-29 14:52:32.000000000","message":"Same as for network association: this renders as \"body\" instead of \"path\".","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ba40cdfbdd2c01cd851e88d10e48f9f5fadee148","unresolved":false,"context_lines":[{"line_number":136,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"   - bgpvpn_id: bgpvpn_id"},{"line_number":139,"context_line":"   - router_association_id: bgpvpn_router_association_id"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5a74a57a_bc0a0ed0","line":139,"range":{"start_line":139,"start_character":5,"end_line":139,"end_character":26},"updated":"2016-11-29 14:52:32.000000000","message":"Same as for network association: this renders as \"body\" instead of \"path\".","commit_id":"3a8e0dbfbc789340272ffc5552956bb763c72399"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1c99fd7a64f9b7b3ef6068933ef8659e11462702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"da4df55a_6788bf23","line":142,"updated":"2016-12-22 21:10:14.000000000","message":"ditto","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ba5201f7_c7d172cf","line":142,"in_reply_to":"da4df55a_6788bf23","updated":"2017-01-02 17:46:30.000000000","message":"Done","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9e78d594510a034b07a24e9f6ad901a02c2e5a23","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Normal response codes: 200"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Request"},{"line_number":28,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_9d11ef5f","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":40},"updated":"2017-01-31 04:20:45.000000000","message":"Can this API return 400 and 403?","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Normal response codes: 200"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Request"},{"line_number":28,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_c0cffc53","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":40},"in_reply_to":"3a461143_9d11ef5f","updated":"2017-01-31 14:16:29.000000000","message":"I don\u0027t know.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9e78d594510a034b07a24e9f6ad901a02c2e5a23","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Normal response codes: 202"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Request"},{"line_number":142,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"3a461143_1d06df1f","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":40},"updated":"2017-01-31 04:20:45.000000000","message":"Mostly DELETE API returns 401 and 404.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"}],"api-ref/source/v2/index.rst":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9c51e0abc3d607b86c00a82892bc20d08e4b93d1","unresolved":false,"context_lines":[{"line_number":60,"context_line":".. include:: lbaas-v2.inc"},{"line_number":61,"context_line":".. include:: lbaas-v1.inc"},{"line_number":62,"context_line":"#######################"},{"line_number":63,"context_line":"BGP/MPLS VPN Attachment"},{"line_number":64,"context_line":"#######################"},{"line_number":65,"context_line":".. include:: bgpvpn-overview.inc"},{"line_number":66,"context_line":".. include:: bgpvpn-bgpvpns.inc"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_fd442475","line":63,"range":{"start_line":63,"start_character":13,"end_line":63,"end_character":23},"updated":"2016-10-25 07:33:33.000000000","message":"\"Interconnection\" is the term we have used until now for networking-bgpvpn","commit_id":"6219df398ceec5148ae1900f1cb45c20994d6278"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"23ed0e61ab6c13f9512ab3e04d85f8ff86eb0bcc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":".. rest_expand_all::"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":10,"context_line":"by the Neutron project and its sub-projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5da102_dbbf755e","line":9,"updated":"2016-10-30 08:26:14.000000000","message":"these changes should be done in a different patch","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"51f95ca4c210ec3078af7d3d7687f481f4774b4a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":".. rest_expand_all::"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":10,"context_line":"by the Neutron project and its sub-projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5da102_d96e882e","line":9,"in_reply_to":"ba5da102_19af2082","updated":"2016-10-31 16:50:05.000000000","message":"Ok, makes sense...","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"91ed2e512a445f79e69778a0123d692b9996d5fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":".. rest_expand_all::"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":10,"context_line":"by the Neutron project and its sub-projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5da102_7ced6a24","line":9,"in_reply_to":"ba5da102_d96e882e","updated":"2016-10-31 17:08:20.000000000","message":"This bit moved to https://review.openstack.org/391919","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ff6a8964d5fd7f9f7110ac99aef7bb1f0e9e6303","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":".. rest_expand_all::"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":10,"context_line":"by the Neutron project and its sub-projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5da102_c8dde215","line":9,"in_reply_to":"ba5da102_dbbf755e","updated":"2016-10-31 10:11:15.000000000","message":"Can you explain ?","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"1eb1dd3f02d0aed57892c017f7b9a27323ad1435","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":".. rest_expand_all::"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":10,"context_line":"by the Neutron project and its sub-projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5da102_19af2082","line":9,"in_reply_to":"ba5da102_dbbf755e","updated":"2016-10-31 16:45:16.000000000","message":"I assume you mean the fact that I added a bunch of section headings in order to group related API calls together. I agree it makes sense to do a separate commit just to add the section headings. I\u0027ll do that.","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ce78e13d2b655d03500777bf841c437712b1e056","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a629dbe_f379d0fd","updated":"2016-11-08 14:03:15.000000000","message":"I\u0027d guess that the modifications here are unintended ?","commit_id":"a97a017205fa0b2fd13ca417e24f8b1587b779bf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"292a5378b3e760d0e218c0ed3189a18c7306d170","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a629dbe_4e457315","in_reply_to":"9a629dbe_ee4d6773","updated":"2016-11-08 14:12:47.000000000","message":"Then what you should do is, instead of a Depends-On, push gerrit changes for commits stacked onto one another.\n\nLike this:\n$ git review -d 391919\n$ git review -x 390196\n$ git review\n(confirm that you want to push two changes for two commits: y)\n\nsee http://docs.openstack.org/infra/manual/developers.html#adding-a-dependency","commit_id":"a97a017205fa0b2fd13ca417e24f8b1587b779bf"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"cc9a319d3871e3c4f197b0a8007ae2262838d4c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a629dbe_ee4d6773","in_reply_to":"9a629dbe_f379d0fd","updated":"2016-11-08 14:09:44.000000000","message":"No, they\u0027re intentional, but what I forgot to do was add a Depends-On to the commit message. Once https://review.openstack.org/#/c/391919/ merges, this change should rebase to simply adding lines 10-12 and 63-70. All the other changes shown here should match up exactly with 391919.","commit_id":"a97a017205fa0b2fd13ca417e24f8b1587b779bf"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. rest_expand_all::"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":11,"context_line":"by the Neutron project and its sub-projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_24586032","line":10,"updated":"2016-12-13 18:19:56.000000000","message":"Why are we adding this blanket top-level statement??","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8e8a56de17bdb3093e2cbc4a858e7b7a4c24f999","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. rest_expand_all::"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":11,"context_line":"by the Neutron project and its sub-projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_333b243a","line":10,"in_reply_to":"1a6eadb0_24586032","updated":"2016-12-20 15:59:46.000000000","message":"I meant to add it in https://review.openstack.org/#/c/391919/ but got mixed up because I\u0027m not great at managing git branches. I can remove it if you think it\u0027s undesirable. My thought was that with all the stadium activity it would be good to make it clear that this document is a combination of Neutron and the sub-projects that are not Neutron itself.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"############################"},{"line_number":64,"context_line":"BGP/MPLS VPN Interconnection"},{"line_number":65,"context_line":"############################"},{"line_number":66,"context_line":".. include:: bgpvpn-overview.inc"},{"line_number":67,"context_line":".. include:: bgpvpn-bgpvpns.inc"},{"line_number":68,"context_line":".. include:: bgpvpn-network_associations.inc"},{"line_number":69,"context_line":".. include:: bgpvpn-router_associations.inc"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_44247cae","line":66,"range":{"start_line":66,"start_character":13,"end_line":66,"end_character":32},"updated":"2016-12-13 18:19:56.000000000","message":"I haven\u0027t see other APIs have their own inc for an overview, but I guess it\u0027s ok since this API has a decent bit of general overview info.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8e8a56de17bdb3093e2cbc4a858e7b7a4c24f999","unresolved":false,"context_lines":[{"line_number":63,"context_line":"############################"},{"line_number":64,"context_line":"BGP/MPLS VPN Interconnection"},{"line_number":65,"context_line":"############################"},{"line_number":66,"context_line":".. include:: bgpvpn-overview.inc"},{"line_number":67,"context_line":".. include:: bgpvpn-bgpvpns.inc"},{"line_number":68,"context_line":".. include:: bgpvpn-network_associations.inc"},{"line_number":69,"context_line":".. include:: bgpvpn-router_associations.inc"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_332164b5","line":66,"range":{"start_line":66,"start_character":13,"end_line":66,"end_character":32},"in_reply_to":"1a6eadb0_44247cae","updated":"2016-12-20 15:59:46.000000000","message":"It wasn\u0027t done before, but I think it\u0027s necessary for sub-projects that provide a collection of related APIs that are intended to be used together. I\u0027ve done the same for the SFC API reference. The end user needs some context of how the API calls are intended to be used in addition to listing out the details of each call.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":67,"context_line":".. include:: bgpvpn-bgpvpns.inc"},{"line_number":68,"context_line":".. include:: bgpvpn-network_associations.inc"},{"line_number":69,"context_line":".. include:: bgpvpn-router_associations.inc"},{"line_number":70,"context_line":".. include:: bgpvpn-caveats.inc"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_a130e202","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":31},"updated":"2016-12-13 18:19:56.000000000","message":"I\u0027d opt to move this info within bgpvpn-overview.inc, perhaps as subsection(s).","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8e8a56de17bdb3093e2cbc4a858e7b7a4c24f999","unresolved":false,"context_lines":[{"line_number":67,"context_line":".. include:: bgpvpn-bgpvpns.inc"},{"line_number":68,"context_line":".. include:: bgpvpn-network_associations.inc"},{"line_number":69,"context_line":".. include:: bgpvpn-router_associations.inc"},{"line_number":70,"context_line":".. include:: bgpvpn-caveats.inc"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_5330a001","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":31},"in_reply_to":"1a6eadb0_a130e202","updated":"2016-12-20 15:59:46.000000000","message":"Done","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":67,"context_line":".. include:: bgpvpn-bgpvpns.inc"},{"line_number":68,"context_line":".. include:: bgpvpn-network_associations.inc"},{"line_number":69,"context_line":".. include:: bgpvpn-router_associations.inc"},{"line_number":70,"context_line":".. include:: bgpvpn-caveats.inc"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_92067b1b","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":31},"in_reply_to":"1a6eadb0_a130e202","updated":"2016-12-15 09:58:58.000000000","message":"Yes, not a bad idea at all.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"90c49905615553d05c4d0f91231bb19e91de89a0","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. rest_expand_all::"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":11,"context_line":"by the Neutron project and its sub-projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_0299961f","line":10,"updated":"2017-01-03 14:15:18.000000000","message":"Seems odd we are adding this blanket statement with this patch, but I guess it\u0027s no biggie.","commit_id":"83f19d031f5d120bd861c53c4c3c74a345905fb8"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"010ab03cc3ce4cc72cea6e244c93bd78c1d1ceab","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. rest_expand_all::"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":11,"context_line":"by the Neutron project and its sub-projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7a3c09a3_49ca2251","line":10,"in_reply_to":"ba5201f7_0299961f","updated":"2017-01-13 03:06:45.000000000","message":"I meant to do it in https://review.openstack.org/#/c/391919/ but I\u0027m still not great with managing multiple changes in git. Unless it causes heartburn I\u0027d like to just slip it in here rather than as a separate commit. I think a little something ought to be there.","commit_id":"83f19d031f5d120bd861c53c4c3c74a345905fb8"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1df676714b6930c6b8311774bf9b3445852fb35f","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. rest_expand_all::"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":11,"context_line":"by the Neutron project and its sub-projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a3c09a3_c9e7cbe2","line":10,"updated":"2017-01-13 19:12:28.000000000","message":"Nit: I wouldn\u0027t add this as part of this patch.","commit_id":"48ff4aa078d3b6ec323d44220645b875b4a11521"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c918946725df36e31cc677bb761fb3fbac239caa","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. rest_expand_all::"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This is a reference for the OpenStack Networking API which is provided"},{"line_number":11,"context_line":"by the Neutron project and its sub-projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"####################"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a3c09a3_dbcf587d","line":10,"in_reply_to":"7a3c09a3_c9e7cbe2","updated":"2017-01-16 14:08:08.000000000","message":"Fine, whatever.","commit_id":"48ff4aa078d3b6ec323d44220645b875b4a11521"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      The UUID of the BGP VPN."},{"line_number":13,"context_line":"  in: path"},{"line_number":14,"context_line":"  required: true"},{"line_number":15,"context_line":"  type: uuid"},{"line_number":16,"context_line":"connection_id:"},{"line_number":17,"context_line":"  description: |"},{"line_number":18,"context_line":"    The UUID of the IPSec site-to-site connection."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_61584b33","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":12},"updated":"2016-11-16 23:55:29.000000000","message":"Should be string","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"55ce365f85fd9265b88d87bf8f4203d89a6ee697","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      The UUID of the BGP VPN."},{"line_number":13,"context_line":"  in: path"},{"line_number":14,"context_line":"  required: true"},{"line_number":15,"context_line":"  type: uuid"},{"line_number":16,"context_line":"connection_id:"},{"line_number":17,"context_line":"  description: |"},{"line_number":18,"context_line":"    The UUID of the IPSec site-to-site connection."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_ecb5617e","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":12},"in_reply_to":"7a77a97e_61584b33","updated":"2016-11-22 15:15:08.000000000","message":"A UUID is a string, but not all strings are UUIDs. Is there a consumer of this information other than a human being trying to read the API reference documentation? It doesn\u0027t make sense to me to be less specific when we can be more specific. Anyone who codes to this API and provides a string that is not a UUID for this parameter is only going to receive a failure in response.","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45b46781b633a71dd77100a547c2a1c0a124672d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      The UUID of the BGP VPN."},{"line_number":13,"context_line":"  in: path"},{"line_number":14,"context_line":"  required: true"},{"line_number":15,"context_line":"  type: uuid"},{"line_number":16,"context_line":"connection_id:"},{"line_number":17,"context_line":"  description: |"},{"line_number":18,"context_line":"    The UUID of the IPSec site-to-site connection."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a74a57a_58d42a46","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":12},"in_reply_to":"7a77a97e_ecb5617e","updated":"2016-11-25 10:49:26.000000000","message":"We need to follow what os-api-ref allows and currently, the type field is defined as \"the javascript/json type of the field. one of boolean, int, float, string, array, object\" [1].\n\nTo give more information about what a string field contains, the only place we have is the description field.\n\n[1] http://git.openstack.org/cgit/openstack/os-api-ref/tree/doc/source/usage.rst#n171","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":614,"context_line":"      Additional Route Targets that will be used for export."},{"line_number":615,"context_line":"  in: body"},{"line_number":616,"context_line":"  required: false"},{"line_number":617,"context_line":"  type: list(str)"},{"line_number":618,"context_line":"bgpvpn_import_targets:"},{"line_number":619,"context_line":"  description: |"},{"line_number":620,"context_line":"      Additional Route Targets that will be imported."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_c13d9fbc","line":617,"range":{"start_line":617,"start_character":8,"end_line":617,"end_character":17},"updated":"2016-11-16 23:55:29.000000000","message":"array","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45b46781b633a71dd77100a547c2a1c0a124672d","unresolved":false,"context_lines":[{"line_number":614,"context_line":"      Additional Route Targets that will be used for export."},{"line_number":615,"context_line":"  in: body"},{"line_number":616,"context_line":"  required: false"},{"line_number":617,"context_line":"  type: list(str)"},{"line_number":618,"context_line":"bgpvpn_import_targets:"},{"line_number":619,"context_line":"  description: |"},{"line_number":620,"context_line":"      Additional Route Targets that will be imported."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a74a57a_985c02ef","line":617,"range":{"start_line":617,"start_character":8,"end_line":617,"end_character":17},"in_reply_to":"7a77a97e_4cc9f578","updated":"2016-11-25 10:49:26.000000000","message":"see above","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"55ce365f85fd9265b88d87bf8f4203d89a6ee697","unresolved":false,"context_lines":[{"line_number":614,"context_line":"      Additional Route Targets that will be used for export."},{"line_number":615,"context_line":"  in: body"},{"line_number":616,"context_line":"  required: false"},{"line_number":617,"context_line":"  type: list(str)"},{"line_number":618,"context_line":"bgpvpn_import_targets:"},{"line_number":619,"context_line":"  description: |"},{"line_number":620,"context_line":"      Additional Route Targets that will be imported."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_4cc9f578","line":617,"range":{"start_line":617,"start_character":8,"end_line":617,"end_character":17},"in_reply_to":"7a77a97e_c13d9fbc","updated":"2016-11-22 15:15:08.000000000","message":"I think most programmers would equate array and list as synonyms, but I\u0027ll grant you that the JSON spec uses the term array where Python uses list and since this is JSON I\u0027ll change it.","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":620,"context_line":"      Additional Route Targets that will be imported."},{"line_number":621,"context_line":"  in: body"},{"line_number":622,"context_line":"  required: false"},{"line_number":623,"context_line":"  type: list(str)"},{"line_number":624,"context_line":"bgpvpn_name:"},{"line_number":625,"context_line":"  description: |"},{"line_number":626,"context_line":"      The user meaningful name of the BGP VPN."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_e14c5b72","line":623,"range":{"start_line":623,"start_character":8,"end_line":623,"end_character":17},"updated":"2016-11-16 23:55:29.000000000","message":"ditto","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        The UUID of a Neutron network with which to associate the BGP VPN."},{"line_number":639,"context_line":"  in: body"},{"line_number":640,"context_line":"  required: true"},{"line_number":641,"context_line":"  type: uuid"},{"line_number":642,"context_line":"bgpvpn_networks:"},{"line_number":643,"context_line":"  description: |"},{"line_number":644,"context_line":"       This read-only attribute reflects the associations defined by Network association API resources."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_a16983c0","line":641,"range":{"start_line":641,"start_character":8,"end_line":641,"end_character":12},"updated":"2016-11-16 23:55:29.000000000","message":"string","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45b46781b633a71dd77100a547c2a1c0a124672d","unresolved":false,"context_lines":[{"line_number":641,"context_line":"  type: uuid"},{"line_number":642,"context_line":"bgpvpn_networks:"},{"line_number":643,"context_line":"  description: |"},{"line_number":644,"context_line":"       This read-only attribute reflects the associations defined by Network association API resources."},{"line_number":645,"context_line":"  in: body"},{"line_number":646,"context_line":"  required: false"},{"line_number":647,"context_line":"  type: list(uuid-str)"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a74a57a_1800f2a9","line":644,"range":{"start_line":644,"start_character":22,"end_line":644,"end_character":31},"updated":"2016-11-25 10:49:26.000000000","message":"you could say \"this read-only list of network uuid\u0027s ...\"","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":644,"context_line":"       This read-only attribute reflects the associations defined by Network association API resources."},{"line_number":645,"context_line":"  in: body"},{"line_number":646,"context_line":"  required: false"},{"line_number":647,"context_line":"  type: list(uuid-str)"},{"line_number":648,"context_line":"bgpvpn_route_distinguishers:"},{"line_number":649,"context_line":"  description: |"},{"line_number":650,"context_line":"      If this parameter is specified, one of these RDs will be used to advertise VPN routes."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_e1637bda","line":647,"range":{"start_line":647,"start_character":8,"end_line":647,"end_character":22},"updated":"2016-11-16 23:55:29.000000000","message":"array","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":650,"context_line":"      If this parameter is specified, one of these RDs will be used to advertise VPN routes."},{"line_number":651,"context_line":"  in: body"},{"line_number":652,"context_line":"  required: false"},{"line_number":653,"context_line":"  type: list(str)"},{"line_number":654,"context_line":"bgpvpn_route_targets:"},{"line_number":655,"context_line":"  description: |"},{"line_number":656,"context_line":"      Route Targets that will be both imported and used for export."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_219c93bf","line":653,"range":{"start_line":653,"start_character":8,"end_line":653,"end_character":17},"updated":"2016-11-16 23:55:29.000000000","message":"array","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":656,"context_line":"      Route Targets that will be both imported and used for export."},{"line_number":657,"context_line":"  in: body"},{"line_number":658,"context_line":"  required: false"},{"line_number":659,"context_line":"  type: list(str)"},{"line_number":660,"context_line":"bgpvpn_router_association_id:"},{"line_number":661,"context_line":"  description: |"},{"line_number":662,"context_line":"      The ID of an association between a router and a BGP VPN."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_419fcfb3","line":659,"range":{"start_line":659,"start_character":8,"end_line":659,"end_character":17},"updated":"2016-11-16 23:55:29.000000000","message":"ditto","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":668,"context_line":"      The UUID of a Neutron router with which to associate the BGP VPN."},{"line_number":669,"context_line":"  in: body"},{"line_number":670,"context_line":"  required: true"},{"line_number":671,"context_line":"  type: uuid"},{"line_number":672,"context_line":"bgpvpn_routers:"},{"line_number":673,"context_line":"  description: |"},{"line_number":674,"context_line":"      This read-only attribute reflects the associations defined by Router association API resources."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_a1b0a344","line":671,"range":{"start_line":671,"start_character":8,"end_line":671,"end_character":12},"updated":"2016-11-16 23:55:29.000000000","message":"string","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45b46781b633a71dd77100a547c2a1c0a124672d","unresolved":false,"context_lines":[{"line_number":671,"context_line":"  type: uuid"},{"line_number":672,"context_line":"bgpvpn_routers:"},{"line_number":673,"context_line":"  description: |"},{"line_number":674,"context_line":"      This read-only attribute reflects the associations defined by Router association API resources."},{"line_number":675,"context_line":"  in: body"},{"line_number":676,"context_line":"  required: false"},{"line_number":677,"context_line":"  type: list(uuid-str)"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a74a57a_9813220d","line":674,"range":{"start_line":674,"start_character":21,"end_line":674,"end_character":30},"updated":"2016-11-25 10:49:26.000000000","message":"you could say \"this read-only list of router uuid\u0027s ...\"","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":674,"context_line":"      This read-only attribute reflects the associations defined by Router association API resources."},{"line_number":675,"context_line":"  in: body"},{"line_number":676,"context_line":"  required: false"},{"line_number":677,"context_line":"  type: list(uuid-str)"},{"line_number":678,"context_line":"bgpvpn_type:"},{"line_number":679,"context_line":"  description: |"},{"line_number":680,"context_line":"      Selection of the type of VPN and the technology behind it. The default is Layer 3."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_01b6b73c","line":677,"range":{"start_line":677,"start_character":8,"end_line":677,"end_character":22},"updated":"2016-11-16 23:55:29.000000000","message":"array","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":680,"context_line":"      Selection of the type of VPN and the technology behind it. The default is Layer 3."},{"line_number":681,"context_line":"  in: body"},{"line_number":682,"context_line":"  required: false"},{"line_number":683,"context_line":"  type: string (\"l2\" or \"l3\")"},{"line_number":684,"context_line":"changed_at:"},{"line_number":685,"context_line":"  description: |"},{"line_number":686,"context_line":"    Time at which the network has been created."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_2183b357","line":683,"range":{"start_line":683,"start_character":15,"end_line":683,"end_character":29},"updated":"2016-11-16 23:55:29.000000000","message":"This part should be moved to description","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"55ce365f85fd9265b88d87bf8f4203d89a6ee697","unresolved":false,"context_lines":[{"line_number":680,"context_line":"      Selection of the type of VPN and the technology behind it. The default is Layer 3."},{"line_number":681,"context_line":"  in: body"},{"line_number":682,"context_line":"  required: false"},{"line_number":683,"context_line":"  type: string (\"l2\" or \"l3\")"},{"line_number":684,"context_line":"changed_at:"},{"line_number":685,"context_line":"  description: |"},{"line_number":686,"context_line":"    Time at which the network has been created."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_ece721aa","line":683,"range":{"start_line":683,"start_character":15,"end_line":683,"end_character":29},"in_reply_to":"7a77a97e_2183b357","updated":"2016-11-22 15:15:08.000000000","message":"I would argue that the current code for generating OpenStack api-ref pages needs to be extended. This parameter does not accept arbitrary strings, it accepts two specific strings. If Python and JSON had enums it would be more accurate to declare this as\n\n  typedef enum bgpvpn_type\n  {\n    \"l2\",\n    \"l3\"\n  } bgpvpn_type;\n\nI\u0027ll move it to the description, but that\u0027s not really where it belongs. The list of permitted values really is part of the type specification as far as documenting the API is concerned.","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45b46781b633a71dd77100a547c2a1c0a124672d","unresolved":false,"context_lines":[{"line_number":680,"context_line":"      Selection of the type of VPN and the technology behind it. The default is Layer 3."},{"line_number":681,"context_line":"  in: body"},{"line_number":682,"context_line":"  required: false"},{"line_number":683,"context_line":"  type: string (\"l2\" or \"l3\")"},{"line_number":684,"context_line":"changed_at:"},{"line_number":685,"context_line":"  description: |"},{"line_number":686,"context_line":"    Time at which the network has been created."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a74a57a_f80416c1","line":683,"range":{"start_line":683,"start_character":15,"end_line":683,"end_character":29},"in_reply_to":"7a77a97e_ece721aa","updated":"2016-11-25 10:49:26.000000000","message":"See my comment on what is allowed in the type field.","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"eeb2f1e1e78e18b2dfef259ea8df7e6d3aa094d7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      The UUID of the BGP VPN."},{"line_number":7,"context_line":"  in: path"},{"line_number":8,"context_line":"  required: true"},{"line_number":9,"context_line":"  type: uuid"},{"line_number":10,"context_line":"bgpvpn_network_association_id_path:"},{"line_number":11,"context_line":"  description: |"},{"line_number":12,"context_line":"      The ID of an association between a network and a BGP VPN."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a71b18c_b25c1e4c","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":12},"updated":"2016-12-06 15:33:11.000000000","message":"string","commit_id":"f0334fc75efbc27cb541ed1456a806d6877caa75"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"eeb2f1e1e78e18b2dfef259ea8df7e6d3aa094d7","unresolved":false,"context_lines":[{"line_number":716,"context_line":"      The UUID of a Neutron router with which to associate the BGP VPN."},{"line_number":717,"context_line":"  in: body"},{"line_number":718,"context_line":"  required: true"},{"line_number":719,"context_line":"  type: uuid"},{"line_number":720,"context_line":"bgpvpn_routers:"},{"line_number":721,"context_line":"  description: |"},{"line_number":722,"context_line":"      This read-only list of router UUIDs reflects the associations defined by Router association API resources."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a71b18c_f2521634","line":719,"range":{"start_line":719,"start_character":8,"end_line":719,"end_character":12},"updated":"2016-12-06 15:33:11.000000000","message":"string","commit_id":"f0334fc75efbc27cb541ed1456a806d6877caa75"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":698,"context_line":"      If this parameter is specified, one of these RDs will be used to advertise VPN routes."},{"line_number":699,"context_line":"  in: body"},{"line_number":700,"context_line":"  required: false"},{"line_number":701,"context_line":"  type: array(str)"},{"line_number":702,"context_line":"bgpvpn_route_targets:"},{"line_number":703,"context_line":"  description: |"},{"line_number":704,"context_line":"      Route Targets that will be both imported and used for export."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a6eadb0_81220600","line":701,"range":{"start_line":701,"start_character":13,"end_line":701,"end_character":18},"updated":"2016-12-13 18:19:56.000000000","message":"The trailing \u0027(str)\u0027 seems inconsistent with other array parameters. I\u0027d opt to just use \u0027array\u0027.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8e8a56de17bdb3093e2cbc4a858e7b7a4c24f999","unresolved":false,"context_lines":[{"line_number":698,"context_line":"      If this parameter is specified, one of these RDs will be used to advertise VPN routes."},{"line_number":699,"context_line":"  in: body"},{"line_number":700,"context_line":"  required: false"},{"line_number":701,"context_line":"  type: array(str)"},{"line_number":702,"context_line":"bgpvpn_route_targets:"},{"line_number":703,"context_line":"  description: |"},{"line_number":704,"context_line":"      Route Targets that will be both imported and used for export."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a6eadb0_c85b1af5","line":701,"range":{"start_line":701,"start_character":13,"end_line":701,"end_character":18},"in_reply_to":"1a6eadb0_523063e8","updated":"2016-12-20 15:59:46.000000000","message":"Done","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":698,"context_line":"      If this parameter is specified, one of these RDs will be used to advertise VPN routes."},{"line_number":699,"context_line":"  in: body"},{"line_number":700,"context_line":"  required: false"},{"line_number":701,"context_line":"  type: array(str)"},{"line_number":702,"context_line":"bgpvpn_route_targets:"},{"line_number":703,"context_line":"  description: |"},{"line_number":704,"context_line":"      Route Targets that will be both imported and used for export."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a6eadb0_523063e8","line":701,"range":{"start_line":701,"start_character":13,"end_line":701,"end_character":18},"in_reply_to":"1a6eadb0_81220600","updated":"2016-12-15 09:58:58.000000000","message":"Yes.\nTo keep the information, we should then update the description to something like: \"List of Route Distinguisher strings. If this parameter...\"","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":726,"context_line":"bgpvpn_type:"},{"line_number":727,"context_line":"  description: |"},{"line_number":728,"context_line":"      Selection of the type of VPN and the technology behind it. Allowed"},{"line_number":729,"context_line":"      values are \"l2\" or \"l3\". The default is l3. \"l2\" indicates a Layer"},{"line_number":730,"context_line":"      2 (i.e. bridged) attachment and \"l3\" indicates a Layer 3 (i.e."},{"line_number":731,"context_line":"      routed) attachment."},{"line_number":732,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a6eadb0_81504660","line":729,"range":{"start_line":729,"start_character":18,"end_line":729,"end_character":20},"updated":"2016-12-13 18:19:56.000000000","message":"For \"code references\" I think we should use ``myword`` for consistency. This applies elsewhere in this document as well.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1c99fd7a64f9b7b3ef6068933ef8659e11462702","unresolved":false,"context_lines":[{"line_number":665,"context_line":"  type: array"},{"line_number":666,"context_line":"bgpvpn_id_body:"},{"line_number":667,"context_line":"  description: |"},{"line_number":668,"context_line":"      The UUID of the BGP VPN."},{"line_number":669,"context_line":"  in: body"},{"line_number":670,"context_line":"  required: true"},{"line_number":671,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"da4df55a_8794c337","line":668,"range":{"start_line":668,"start_character":10,"end_line":668,"end_character":14},"updated":"2016-12-22 21:10:14.000000000","message":"Can you please change this to ID instead of UUID for consistency?","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":665,"context_line":"  type: array"},{"line_number":666,"context_line":"bgpvpn_id_body:"},{"line_number":667,"context_line":"  description: |"},{"line_number":668,"context_line":"      The UUID of the BGP VPN."},{"line_number":669,"context_line":"  in: body"},{"line_number":670,"context_line":"  required: true"},{"line_number":671,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba5201f7_27d95ef4","line":668,"range":{"start_line":668,"start_character":10,"end_line":668,"end_character":14},"in_reply_to":"da4df55a_8794c337","updated":"2017-01-02 17:46:30.000000000","message":"Done","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1c99fd7a64f9b7b3ef6068933ef8659e11462702","unresolved":false,"context_lines":[{"line_number":689,"context_line":"  type: string"},{"line_number":690,"context_line":"bgpvpn_network_id:"},{"line_number":691,"context_line":"  description: |"},{"line_number":692,"context_line":"        The UUID of a Neutron network with which to associate the BGP VPN."},{"line_number":693,"context_line":"  in: body"},{"line_number":694,"context_line":"  required: true"},{"line_number":695,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"da4df55a_c79ecb55","line":692,"range":{"start_line":692,"start_character":12,"end_line":692,"end_character":16},"updated":"2016-12-22 21:10:14.000000000","message":"ditto","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":689,"context_line":"  type: string"},{"line_number":690,"context_line":"bgpvpn_network_id:"},{"line_number":691,"context_line":"  description: |"},{"line_number":692,"context_line":"        The UUID of a Neutron network with which to associate the BGP VPN."},{"line_number":693,"context_line":"  in: body"},{"line_number":694,"context_line":"  required: true"},{"line_number":695,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba5201f7_87ee8a89","line":692,"range":{"start_line":692,"start_character":12,"end_line":692,"end_character":16},"in_reply_to":"da4df55a_c79ecb55","updated":"2017-01-02 17:46:30.000000000","message":"Done","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1c99fd7a64f9b7b3ef6068933ef8659e11462702","unresolved":false,"context_lines":[{"line_number":719,"context_line":"  type: string"},{"line_number":720,"context_line":"bgpvpn_router_id:"},{"line_number":721,"context_line":"  description: |"},{"line_number":722,"context_line":"      The UUID of a Neutron router with which to associate the BGP VPN."},{"line_number":723,"context_line":"  in: body"},{"line_number":724,"context_line":"  required: true"},{"line_number":725,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"da4df55a_27aeb785","line":722,"range":{"start_line":722,"start_character":10,"end_line":722,"end_character":14},"updated":"2016-12-22 21:10:14.000000000","message":"ditto","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":719,"context_line":"  type: string"},{"line_number":720,"context_line":"bgpvpn_router_id:"},{"line_number":721,"context_line":"  description: |"},{"line_number":722,"context_line":"      The UUID of a Neutron router with which to associate the BGP VPN."},{"line_number":723,"context_line":"  in: body"},{"line_number":724,"context_line":"  required: true"},{"line_number":725,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba5201f7_a7f38e72","line":722,"range":{"start_line":722,"start_character":10,"end_line":722,"end_character":14},"in_reply_to":"da4df55a_27aeb785","updated":"2017-01-02 17:46:30.000000000","message":"Done","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3590c1197d2fde87b02cf564fb377535ccc2ddab","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# variables in path"},{"line_number":4,"context_line":"bgpvpn-id-path:"},{"line_number":5,"context_line":"  description: |"},{"line_number":6,"context_line":"      The UUID of the BGP VPN."},{"line_number":7,"context_line":"  in: path"},{"line_number":8,"context_line":"  required: true"},{"line_number":9,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5a3905b3_ffb71082","line":6,"range":{"start_line":6,"start_character":10,"end_line":6,"end_character":14},"updated":"2017-01-24 18:21:44.000000000","message":"We prefer to ID over UUID.","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f2c20de4f52d600bbb867ce3e76fa0b596040538","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# variables in path"},{"line_number":4,"context_line":"bgpvpn-id-path:"},{"line_number":5,"context_line":"  description: |"},{"line_number":6,"context_line":"      The UUID of the BGP VPN."},{"line_number":7,"context_line":"  in: path"},{"line_number":8,"context_line":"  required: true"},{"line_number":9,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3a461143_a0fbd077","line":6,"range":{"start_line":6,"start_character":10,"end_line":6,"end_character":14},"in_reply_to":"5a3905b3_ffb71082","updated":"2017-01-31 14:16:29.000000000","message":"Done","commit_id":"265d616114bf77ba70167e2b220122263d3566fa"}],"api-ref/source/v2/samples/bgpvpn/bgpvpns/bgpvpn-create-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3e9975433de09c86431a1ce69aa92304f1c9de33","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      \"64512:1888\","},{"line_number":11,"context_line":"      \"64512:1999\""},{"line_number":12,"context_line":"    ],"},{"line_number":13,"context_line":"    \"tenant_id\": \"b7549121395844bea941bb92feb3fad9\","},{"line_number":14,"context_line":"    \"import_targets\": ["},{"line_number":15,"context_line":"      \"64512:1555\""},{"line_number":16,"context_line":"    ],"}],"source_content_type":"application/json","patch_set":13,"id":"1a6eadb0_8ac2bf51","line":13,"updated":"2016-12-21 16:03:36.000000000","message":"No project_id in the responses?","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      \"64512:1888\","},{"line_number":11,"context_line":"      \"64512:1999\""},{"line_number":12,"context_line":"    ],"},{"line_number":13,"context_line":"    \"tenant_id\": \"b7549121395844bea941bb92feb3fad9\","},{"line_number":14,"context_line":"    \"import_targets\": ["},{"line_number":15,"context_line":"      \"64512:1555\""},{"line_number":16,"context_line":"    ],"}],"source_content_type":"application/json","patch_set":13,"id":"ba5201f7_270a3e27","line":13,"in_reply_to":"1a6eadb0_8ac2bf51","updated":"2017-01-02 17:46:30.000000000","message":"It was a while ago because of how long this has been in review, but I\u0027m pretty sure I created all of these samples by calling the API with curl and piping the output to jq. I\u0027ll double check it, but devstack isn\u0027t working right so I\u0027m going to push a new patchset to address all the other comments before I start troubleshooting devstack again.","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"680668fa4742a1e74683c2baf8af92d6f1109a27","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      \"64512:1888\","},{"line_number":11,"context_line":"      \"64512:1999\""},{"line_number":12,"context_line":"    ],"},{"line_number":13,"context_line":"    \"tenant_id\": \"b7549121395844bea941bb92feb3fad9\","},{"line_number":14,"context_line":"    \"import_targets\": ["},{"line_number":15,"context_line":"      \"64512:1555\""},{"line_number":16,"context_line":"    ],"}],"source_content_type":"application/json","patch_set":13,"id":"ba5201f7_1c21fd9f","line":13,"in_reply_to":"ba5201f7_270a3e27","updated":"2017-01-03 12:35:43.000000000","message":"We have moved to using the project_id in the DB since I017b3f8ec432f1d334879f30026d8b16f6295eff has merged, but to my knowledge, unless its done behind the scene, we don\u0027t have project_id on the API side.","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"}],"api-ref/source/v2/samples/bgpvpn/bgpvpns/bgpvpn-show-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{\"bgpvpn\": {"},{"line_number":2,"context_line":"   \"id\": \"460ac411-3dfb-45bb-8116-ed1a7233d143\","},{"line_number":3,"context_line":"   \"name\": \"foo\","},{"line_number":4,"context_line":"   \"route_targets\": [\"64512:1444\"],"}],"source_content_type":"application/json","patch_set":12,"id":"1a6eadb0_41ec6e8f","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":12},"updated":"2016-12-13 18:19:56.000000000","message":"This is inconsistent json formatting.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{\"bgpvpn\": {"},{"line_number":2,"context_line":"   \"id\": \"460ac411-3dfb-45bb-8116-ed1a7233d143\","},{"line_number":3,"context_line":"   \"name\": \"foo\","},{"line_number":4,"context_line":"   \"route_targets\": [\"64512:1444\"],"}],"source_content_type":"application/json","patch_set":12,"id":"1a6eadb0_52ba230b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":12},"in_reply_to":"1a6eadb0_41ec6e8f","updated":"2016-12-15 09:58:58.000000000","message":"Indeed. Missing newline+indent after the first \u0027{\u0027.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8e8a56de17bdb3093e2cbc4a858e7b7a4c24f999","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{\"bgpvpn\": {"},{"line_number":2,"context_line":"   \"id\": \"460ac411-3dfb-45bb-8116-ed1a7233d143\","},{"line_number":3,"context_line":"   \"name\": \"foo\","},{"line_number":4,"context_line":"   \"route_targets\": [\"64512:1444\"],"}],"source_content_type":"application/json","patch_set":12,"id":"1a6eadb0_e8545655","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":12},"in_reply_to":"1a6eadb0_52ba230b","updated":"2016-12-20 15:59:46.000000000","message":"Done","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \"networks\": ["},{"line_number":12,"context_line":"      \"a4f2b8df-cb42-4893-a333-d0b5c36ade17\""},{"line_number":13,"context_line":"    ]"},{"line_number":14,"context_line":"}}"}],"source_content_type":"application/json","patch_set":12,"id":"1a6eadb0_b25617cc","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"updated":"2016-12-15 09:58:58.000000000","message":"Missing indent+newline here as well.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8e8a56de17bdb3093e2cbc4a858e7b7a4c24f999","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \"networks\": ["},{"line_number":12,"context_line":"      \"a4f2b8df-cb42-4893-a333-d0b5c36ade17\""},{"line_number":13,"context_line":"    ]"},{"line_number":14,"context_line":"}}"}],"source_content_type":"application/json","patch_set":12,"id":"1a6eadb0_284f2ebe","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"in_reply_to":"1a6eadb0_b25617cc","updated":"2016-12-20 15:59:46.000000000","message":"Done","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"90c49905615553d05c4d0f91231bb19e91de89a0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"       \"import_targets\": [],"},{"line_number":8,"context_line":"       \"type\": \"l3\","},{"line_number":9,"context_line":"       \"tenant_id\": \"f94ea398564d49dfb0d542f086c68ce7\","},{"line_number":10,"context_line":"        \"routers\": [],"},{"line_number":11,"context_line":"        \"route_distinguishers\": [],"},{"line_number":12,"context_line":"        \"networks\": ["},{"line_number":13,"context_line":"          \"a4f2b8df-cb42-4893-a333-d0b5c36ade17\""}],"source_content_type":"application/json","patch_set":14,"id":"ba5201f7_6240a2a6","line":10,"updated":"2017-01-03 14:15:18.000000000","message":"Nit: Formatting; a space was added starting here at line 10.","commit_id":"83f19d031f5d120bd861c53c4c3c74a345905fb8"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"010ab03cc3ce4cc72cea6e244c93bd78c1d1ceab","unresolved":false,"context_lines":[{"line_number":7,"context_line":"       \"import_targets\": [],"},{"line_number":8,"context_line":"       \"type\": \"l3\","},{"line_number":9,"context_line":"       \"tenant_id\": \"f94ea398564d49dfb0d542f086c68ce7\","},{"line_number":10,"context_line":"        \"routers\": [],"},{"line_number":11,"context_line":"        \"route_distinguishers\": [],"},{"line_number":12,"context_line":"        \"networks\": ["},{"line_number":13,"context_line":"          \"a4f2b8df-cb42-4893-a333-d0b5c36ade17\""}],"source_content_type":"application/json","patch_set":14,"id":"7a3c09a3_29031675","line":10,"in_reply_to":"ba5201f7_6240a2a6","updated":"2017-01-13 03:06:45.000000000","message":"Done","commit_id":"83f19d031f5d120bd861c53c4c3c74a345905fb8"}],"api-ref/source/v2/samples/bgpvpn/bgpvpns/bgpvpn-update-request.json":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{\"bgpvpn\": {"},{"line_number":2,"context_line":"   \"name\": \"foo\","},{"line_number":3,"context_line":"   \"route_targets\": [\"64512:1444\"],"},{"line_number":4,"context_line":"   \"export_targets\": [],"},{"line_number":5,"context_line":"   \"import_targets\": [],"},{"line_number":6,"context_line":"}}"}],"source_content_type":"application/json","patch_set":12,"id":"1a6eadb0_529b0372","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":2},"updated":"2016-12-15 09:58:58.000000000","message":"We can apply boden\u0027s comment on indentation here as well.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8e8a56de17bdb3093e2cbc4a858e7b7a4c24f999","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{\"bgpvpn\": {"},{"line_number":2,"context_line":"   \"name\": \"foo\","},{"line_number":3,"context_line":"   \"route_targets\": [\"64512:1444\"],"},{"line_number":4,"context_line":"   \"export_targets\": [],"},{"line_number":5,"context_line":"   \"import_targets\": [],"},{"line_number":6,"context_line":"}}"}],"source_content_type":"application/json","patch_set":12,"id":"1a6eadb0_6863e61a","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":2},"in_reply_to":"1a6eadb0_529b0372","updated":"2016-12-20 15:59:46.000000000","message":"Done","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"}],"api-ref/source/v2/samples/bgpvpn/network_associations/network_association-show-response.json":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ \"network_association\":"},{"line_number":2,"context_line":"   {"},{"line_number":3,"context_line":"      \"id\": NET_ASSOCIATION_UUID,"},{"line_number":4,"context_line":"      \"network_id\": NETWORK_UUID,"},{"line_number":5,"context_line":"   }"},{"line_number":6,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"7a77a97e_e14a9bc4","line":3,"range":{"start_line":3,"start_character":12,"end_line":3,"end_character":32},"updated":"2016-11-16 23:55:29.000000000","message":"I\u0027m not quite sure about this response. I believe this should include \"real\" id (so probably uuid)","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ \"network_association\":"},{"line_number":2,"context_line":"   {"},{"line_number":3,"context_line":"      \"id\": NET_ASSOCIATION_UUID,"},{"line_number":4,"context_line":"      \"network_id\": NETWORK_UUID,"},{"line_number":5,"context_line":"   }"},{"line_number":6,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"7a77a97e_2113b3b9","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":32},"updated":"2016-11-16 23:55:29.000000000","message":"ditto","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ \"network_association\":"},{"line_number":2,"context_line":"   {"},{"line_number":3,"context_line":"      \"id\": \"1b09fd12-c769-4be7-9c26-dececa474acf\","},{"line_number":4,"context_line":"      \"network_id\": \"a4f2b8df-cb42-4893-a333-d0b5c36ade17\","}],"source_content_type":"application/json","patch_set":12,"id":"1a6eadb0_32acc78b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":24},"updated":"2016-12-15 09:58:58.000000000","message":"We can apply boden\u0027s comment on indentation here as well.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8e8a56de17bdb3093e2cbc4a858e7b7a4c24f999","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ \"network_association\":"},{"line_number":2,"context_line":"   {"},{"line_number":3,"context_line":"      \"id\": \"1b09fd12-c769-4be7-9c26-dececa474acf\","},{"line_number":4,"context_line":"      \"network_id\": \"a4f2b8df-cb42-4893-a333-d0b5c36ade17\","}],"source_content_type":"application/json","patch_set":12,"id":"1a6eadb0_2859ee5a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":24},"in_reply_to":"1a6eadb0_32acc78b","updated":"2016-12-20 15:59:46.000000000","message":"Done","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"}],"api-ref/source/v2/samples/bgpvpn/router_associations/router_association-show-response.json":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e16b4cea945d343748584f8e29d7161263d452ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ \"router_association\":"},{"line_number":2,"context_line":"   {"},{"line_number":3,"context_line":"      \"id\": NET_ASSOCIATION_UUID,"},{"line_number":4,"context_line":"      \"router_id\": ROUTER_UUID,"},{"line_number":5,"context_line":"      \"tenant_id\": \"b7549121395844bea941bb92feb3fad9\","},{"line_number":6,"context_line":"   }"}],"source_content_type":"application/json","patch_set":8,"id":"7a77a97e_a127c310","line":3,"range":{"start_line":3,"start_character":12,"end_line":3,"end_character":32},"updated":"2016-11-16 23:55:29.000000000","message":"The same as comment on network_association","commit_id":"f9cf111c404058773bb86cd7efc5cddbaf9939d9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ \"router_association\":"},{"line_number":2,"context_line":"   {"},{"line_number":3,"context_line":"      \"id\": \"c63149a0-a0b3-4ca7-aba4-9aaa1b39d7f3\","},{"line_number":4,"context_line":"      \"router_id\": \"46a1a80b-7c42-4c45-88fd-b531e636969f\","}],"source_content_type":"application/json","patch_set":12,"id":"1a6eadb0_d2b393e7","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":23},"updated":"2016-12-15 09:58:58.000000000","message":"We can apply boden\u0027s comment on indentation here as well.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3e9975433de09c86431a1ce69aa92304f1c9de33","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"router_association\":"},{"line_number":3,"context_line":"       {"},{"line_number":4,"context_line":"          \"id\": \"c63149a0-a0b3-4ca7-aba4-9aaa1b39d7f3\","},{"line_number":5,"context_line":"          \"router_id\": \"46a1a80b-7c42-4c45-88fd-b531e636969f\","},{"line_number":6,"context_line":"          \"tenant_id\": \"b7549121395844bea941bb92feb3fad9\","}],"source_content_type":"application/json","patch_set":13,"id":"1a6eadb0_03da1fe8","line":3,"updated":"2016-12-21 16:03:36.000000000","message":"Nit: inconsistent JSON formatting when compared to the other JSON response.","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"router_association\":"},{"line_number":3,"context_line":"       {"},{"line_number":4,"context_line":"          \"id\": \"c63149a0-a0b3-4ca7-aba4-9aaa1b39d7f3\","},{"line_number":5,"context_line":"          \"router_id\": \"46a1a80b-7c42-4c45-88fd-b531e636969f\","},{"line_number":6,"context_line":"          \"tenant_id\": \"b7549121395844bea941bb92feb3fad9\","}],"source_content_type":"application/json","patch_set":13,"id":"ba5201f7_a7654e46","line":3,"in_reply_to":"1a6eadb0_03da1fe8","updated":"2017-01-02 17:46:30.000000000","message":"what exactly is inconsistent? It was a while ago, but I\u0027m pretty sure I created all these samples by using curl to invoke the API and piping the output to jq to pretty print it.","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"680668fa4742a1e74683c2baf8af92d6f1109a27","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"router_association\":"},{"line_number":3,"context_line":"       {"},{"line_number":4,"context_line":"          \"id\": \"c63149a0-a0b3-4ca7-aba4-9aaa1b39d7f3\","},{"line_number":5,"context_line":"          \"router_id\": \"46a1a80b-7c42-4c45-88fd-b531e636969f\","},{"line_number":6,"context_line":"          \"tenant_id\": \"b7549121395844bea941bb92feb3fad9\","}],"source_content_type":"application/json","patch_set":13,"id":"ba5201f7_dcff75ff","line":3,"in_reply_to":"ba5201f7_a7654e46","updated":"2017-01-03 12:35:43.000000000","message":"Other examples have no newline between \":\" and \"{\" .","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"}],"api-ref/source/v2/samples/bgpvpn/router_associations/router_associations-create-request.json":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"43e298b3d2b6865acc38b3283f339dec41d82b21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7a3c09a3_d036aeb3","updated":"2017-01-13 08:56:48.000000000","message":"Didn\u0027t notice this before: why the plural in the file name ?\nI think we should have \u0027router_association-create-request.json\u0027","commit_id":"517cc816a06375b2d5d1d7bf771ad73b50215162"}],"api-ref/source/v2/samples/bgpvpn/router_associations/router_associations-create-response.json":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"2973b619c278adc03d4fa650e7047c2ff6ee8112","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7a3c09a3_3fed058c","updated":"2017-01-13 07:21:49.000000000","message":"Why the rename from router_association-create-response.json to router_associations-create-response.json ?","commit_id":"517cc816a06375b2d5d1d7bf771ad73b50215162"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"e2917c1a3a4f66b6d918a6aca2a42b4c8576750a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7a3c09a3_43dc9a12","in_reply_to":"7a3c09a3_3fed058c","updated":"2017-01-13 18:26:37.000000000","message":"I noticed an inconsistency in the file names. The request sample had \"associations\" and the response sample had \"association\". Since the URL to POST to is plural I changed the singular to plural. I can change both back the other way. I didn\u0027t give it too much thought, but just wanted to make them consistent.","commit_id":"517cc816a06375b2d5d1d7bf771ad73b50215162"}],"neutron_lib/api/definitions/bgpvpn.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d1b2c7e0772d7a13f730e34bbb29e4edd2cd7992","unresolved":false,"context_lines":[{"line_number":34,"context_line":"NAME \u003d \u0027BGPVPN Extension\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# The description of the extension."},{"line_number":37,"context_line":"DESCRIPTION \u003d \"Provides support for BGP VPN Network and Router attachment\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":40,"context_line":"UPDATED_TIMESTAMP \u003d \"2014-06-10T17:00:00-00:00\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_04bb8cc5","line":37,"range":{"start_line":37,"start_character":44,"end_line":37,"end_character":74},"updated":"2016-10-26 21:49:57.000000000","message":"Let\u0027s say \"for BGP VPN interconnections\": shorter, and won\u0027t need to be updated when we add other kinds of extensions.","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8b91a3abeb1bf749c112e90243d728dd199e0e2b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"NAME \u003d \u0027BGPVPN Extension\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# The description of the extension."},{"line_number":37,"context_line":"DESCRIPTION \u003d \"Provides support for BGP VPN Network and Router attachment\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":40,"context_line":"UPDATED_TIMESTAMP \u003d \"2014-06-10T17:00:00-00:00\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_6a496e8b","line":37,"range":{"start_line":37,"start_character":44,"end_line":37,"end_character":74},"in_reply_to":"ba5da102_04bb8cc5","updated":"2016-10-27 07:38:17.000000000","message":"Done","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d1b2c7e0772d7a13f730e34bbb29e4edd2cd7992","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# The specific resources and/or attributes for the extension (optional)."},{"line_number":43,"context_line":"BGPVPN \u003d \u0027bpgvpn\u0027"},{"line_number":44,"context_line":"BGPVPNS \u003d \u0027bgpvpns\u0027"},{"line_number":45,"context_line":"NETWORK_ASSOCIATION \u003d \u0027network_association\u0027"},{"line_number":46,"context_line":"ROUTER_ASSOCIATION \u003d \u0027router_association\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# The resource attribute map for the extension."},{"line_number":49,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_84f5dc84","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":41},"updated":"2016-10-26 21:49:57.000000000","message":"define plurals and reuse below ?","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8b91a3abeb1bf749c112e90243d728dd199e0e2b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# The specific resources and/or attributes for the extension (optional)."},{"line_number":43,"context_line":"BGPVPN \u003d \u0027bpgvpn\u0027"},{"line_number":44,"context_line":"BGPVPNS \u003d \u0027bgpvpns\u0027"},{"line_number":45,"context_line":"NETWORK_ASSOCIATION \u003d \u0027network_association\u0027"},{"line_number":46,"context_line":"ROUTER_ASSOCIATION \u003d \u0027router_association\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# The resource attribute map for the extension."},{"line_number":49,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_ca58ba59","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":41},"in_reply_to":"ba5da102_84f5dc84","updated":"2016-10-27 07:38:17.000000000","message":"Done","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d1b2c7e0772d7a13f730e34bbb29e4edd2cd7992","unresolved":false,"context_lines":[{"line_number":102,"context_line":"}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":105,"context_line":"    \u0027network_associations\u0027: {"},{"line_number":106,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: \u0027bgpvpns\u0027,"},{"line_number":107,"context_line":"                   \u0027member_name\u0027: \u0027bgpvpn\u0027},"},{"line_number":108,"context_line":"        \u0027parameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_64d1a8fb","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":26},"updated":"2016-10-26 21:49:57.000000000","message":"Would probably be nicer defined as a const in this file, like BGPVPN\u003d\"bgpvpn\".","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d1b2c7e0772d7a13f730e34bbb29e4edd2cd7992","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":105,"context_line":"    \u0027network_associations\u0027: {"},{"line_number":106,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: \u0027bgpvpns\u0027,"},{"line_number":107,"context_line":"                   \u0027member_name\u0027: \u0027bgpvpn\u0027},"},{"line_number":108,"context_line":"        \u0027parameters\u0027: {"},{"line_number":109,"context_line":"            \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_24fed06b","line":106,"range":{"start_line":106,"start_character":38,"end_line":106,"end_character":47},"updated":"2016-10-26 21:49:57.000000000","message":"use BGPVPNS ?","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8b91a3abeb1bf749c112e90243d728dd199e0e2b","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":105,"context_line":"    \u0027network_associations\u0027: {"},{"line_number":106,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: \u0027bgpvpns\u0027,"},{"line_number":107,"context_line":"                   \u0027member_name\u0027: \u0027bgpvpn\u0027},"},{"line_number":108,"context_line":"        \u0027parameters\u0027: {"},{"line_number":109,"context_line":"            \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_8513135c","line":106,"range":{"start_line":106,"start_character":38,"end_line":106,"end_character":47},"in_reply_to":"ba5da102_24fed06b","updated":"2016-10-27 07:38:17.000000000","message":"Done","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d1b2c7e0772d7a13f730e34bbb29e4edd2cd7992","unresolved":false,"context_lines":[{"line_number":104,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":105,"context_line":"    \u0027network_associations\u0027: {"},{"line_number":106,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: \u0027bgpvpns\u0027,"},{"line_number":107,"context_line":"                   \u0027member_name\u0027: \u0027bgpvpn\u0027},"},{"line_number":108,"context_line":"        \u0027parameters\u0027: {"},{"line_number":109,"context_line":"            \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":110,"context_line":"                   \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_4403c473","line":107,"range":{"start_line":107,"start_character":34,"end_line":107,"end_character":42},"updated":"2016-10-26 21:49:57.000000000","message":"use BGPVPN ?","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8b91a3abeb1bf749c112e90243d728dd199e0e2b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":105,"context_line":"    \u0027network_associations\u0027: {"},{"line_number":106,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: \u0027bgpvpns\u0027,"},{"line_number":107,"context_line":"                   \u0027member_name\u0027: \u0027bgpvpn\u0027},"},{"line_number":108,"context_line":"        \u0027parameters\u0027: {"},{"line_number":109,"context_line":"            \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":110,"context_line":"                   \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_a5101750","line":107,"range":{"start_line":107,"start_character":34,"end_line":107,"end_character":42},"in_reply_to":"ba5da102_4403c473","updated":"2016-10-27 07:38:17.000000000","message":"Done","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d1b2c7e0772d7a13f730e34bbb29e4edd2cd7992","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                           \u0027enforce_policy\u0027: True}"},{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":"    },"},{"line_number":124,"context_line":"    \u0027router_associations\u0027: {"},{"line_number":125,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: \u0027bgpvpns\u0027,"},{"line_number":126,"context_line":"                   \u0027member_name\u0027: \u0027bgpvpn\u0027},"},{"line_number":127,"context_line":"        \u0027parameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_84cebc58","line":124,"range":{"start_line":124,"start_character":4,"end_line":124,"end_character":25},"updated":"2016-10-26 21:49:57.000000000","message":"Ditto.","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8b91a3abeb1bf749c112e90243d728dd199e0e2b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                           \u0027enforce_policy\u0027: True}"},{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":"    },"},{"line_number":124,"context_line":"    \u0027router_associations\u0027: {"},{"line_number":125,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: \u0027bgpvpns\u0027,"},{"line_number":126,"context_line":"                   \u0027member_name\u0027: \u0027bgpvpn\u0027},"},{"line_number":127,"context_line":"        \u0027parameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_c51d0b68","line":124,"range":{"start_line":124,"start_character":4,"end_line":124,"end_character":25},"in_reply_to":"ba5da102_84cebc58","updated":"2016-10-27 07:38:17.000000000","message":"Done","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d1b2c7e0772d7a13f730e34bbb29e4edd2cd7992","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":"    },"},{"line_number":124,"context_line":"    \u0027router_associations\u0027: {"},{"line_number":125,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: \u0027bgpvpns\u0027,"},{"line_number":126,"context_line":"                   \u0027member_name\u0027: \u0027bgpvpn\u0027},"},{"line_number":127,"context_line":"        \u0027parameters\u0027: {"},{"line_number":128,"context_line":"            \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":129,"context_line":"                   \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_64f8c87d","line":126,"range":{"start_line":125,"start_character":19,"end_line":126,"end_character":44},"updated":"2016-10-26 21:49:57.000000000","message":"again, same as above","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8b91a3abeb1bf749c112e90243d728dd199e0e2b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":"    },"},{"line_number":124,"context_line":"    \u0027router_associations\u0027: {"},{"line_number":125,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: \u0027bgpvpns\u0027,"},{"line_number":126,"context_line":"                   \u0027member_name\u0027: \u0027bgpvpn\u0027},"},{"line_number":127,"context_line":"        \u0027parameters\u0027: {"},{"line_number":128,"context_line":"            \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":129,"context_line":"                   \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_e51a0f6e","line":126,"range":{"start_line":125,"start_character":19,"end_line":126,"end_character":44},"in_reply_to":"ba5da102_64f8c87d","updated":"2016-10-27 07:38:17.000000000","message":"Done","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d1b2c7e0772d7a13f730e34bbb29e4edd2cd7992","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# The action map."},{"line_number":147,"context_line":"ACTION_MAP \u003d {"},{"line_number":148,"context_line":"    TRUNK: {"},{"line_number":149,"context_line":"        \u0027add_subports\u0027: \u0027PUT\u0027,"},{"line_number":150,"context_line":"        \u0027remove_subports\u0027: \u0027PUT\u0027,"},{"line_number":151,"context_line":"        \u0027get_subports\u0027: \u0027GET\u0027"},{"line_number":152,"context_line":"    }"},{"line_number":153,"context_line":"}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# The list of required extensions."},{"line_number":156,"context_line":"REQUIRED_EXTENSIONS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_e4dcd81a","line":153,"range":{"start_line":147,"start_character":0,"end_line":153,"end_character":1},"updated":"2016-10-26 21:49:57.000000000","message":"To remove, we don\u0027t use an action map.","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5085dcde82e69fd6a370338cd66a3d8d137e9945","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# The action map."},{"line_number":147,"context_line":"ACTION_MAP \u003d {"},{"line_number":148,"context_line":"    TRUNK: {"},{"line_number":149,"context_line":"        \u0027add_subports\u0027: \u0027PUT\u0027,"},{"line_number":150,"context_line":"        \u0027remove_subports\u0027: \u0027PUT\u0027,"},{"line_number":151,"context_line":"        \u0027get_subports\u0027: \u0027GET\u0027"},{"line_number":152,"context_line":"    }"},{"line_number":153,"context_line":"}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# The list of required extensions."},{"line_number":156,"context_line":"REQUIRED_EXTENSIONS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_7bbcc56c","line":153,"range":{"start_line":147,"start_character":0,"end_line":153,"end_character":1},"in_reply_to":"ba5da102_65251faa","updated":"2016-10-28 08:08:23.000000000","message":"In fact in the early days the API proposal we had an action_map to implement associations as actions on a BGPVPN, but we purposedly replaced that with full resources for associations (sub-resources of a BGPVPN objects) to allow having per-association attributes later.","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8b91a3abeb1bf749c112e90243d728dd199e0e2b","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# The action map."},{"line_number":147,"context_line":"ACTION_MAP \u003d {"},{"line_number":148,"context_line":"    TRUNK: {"},{"line_number":149,"context_line":"        \u0027add_subports\u0027: \u0027PUT\u0027,"},{"line_number":150,"context_line":"        \u0027remove_subports\u0027: \u0027PUT\u0027,"},{"line_number":151,"context_line":"        \u0027get_subports\u0027: \u0027GET\u0027"},{"line_number":152,"context_line":"    }"},{"line_number":153,"context_line":"}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# The list of required extensions."},{"line_number":156,"context_line":"REQUIRED_EXTENSIONS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_65251faa","line":153,"range":{"start_line":147,"start_character":0,"end_line":153,"end_character":1},"in_reply_to":"ba5da102_e4dcd81a","updated":"2016-10-27 07:38:17.000000000","message":"I asked Armando about ACTION_MAP and he suggested pushing the patch set as-is so we can discuss it in review. We don\u0027t use it now, but he wanted to discuss whether we should.","commit_id":"eaa645ef49809061d65a75846cdb6e7340dfceb3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"f9417ca7c26e5a9c894a36a2d13f8145e34bf76e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from networking_bgpvpn.neutron.services.common import constants"},{"line_number":16,"context_line":"from neutron_lib.api import converters"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_e923c103","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":23},"updated":"2016-10-28 08:06:07.000000000","message":"I don\u0027t think we can make neutron-lib depend on networking-bgpvpn, so we should do this the other way round: define the constants here, and import them from networking-bgpvpn.","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"206e8d593062173ac8d094e17ba4cd3657019b93","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from networking_bgpvpn.neutron.services.common import constants"},{"line_number":16,"context_line":"from neutron_lib.api import converters"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_c64d4ac5","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":23},"in_reply_to":"ba5da102_6f6bd2f1","updated":"2016-11-03 14:57:22.000000000","message":"\u0027BGPVPN\u0027 is used in n8g-bgpvpn for the service plugin declaration and should not be related to this API definition move.\n\nThere is no conflict since they are declared in different scopes; in n8g-bgpvpn code,  we will access them as constants.BGPVPN and e.g. api.BGPVPN .","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"49594925828c21ed7d83b480b0fdba45a17602f8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from networking_bgpvpn.neutron.services.common import constants"},{"line_number":16,"context_line":"from neutron_lib.api import converters"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_6f6bd2f1","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":23},"in_reply_to":"ba5da102_cfda1ee8","updated":"2016-11-01 14:50:46.000000000","message":"And I just realized we\u0027ve got a conflict. In constants.py we have BGPVPN \u003d \"BGPVPN\" but here we have BGPVPN \u003d \u0027bgpvpn\u0027 so do we need both the uppercase and lowercase variants? And if so, how do we make it less confusing?","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"656477247c965a261ef0a60e18bd2059a25dbb63","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from networking_bgpvpn.neutron.services.common import constants"},{"line_number":16,"context_line":"from neutron_lib.api import converters"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_cfda1ee8","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":23},"in_reply_to":"ba5da102_e923c103","updated":"2016-11-01 14:47:54.000000000","message":"Ok, so it looks like there are two used:\n  constants.BGPVPN_L3\n  constants.BGPVPN_TYPES\n\nbut the second one depends on a third. From\n  networking_bgpvpn/neutron/services/common/constants.py\n\nwe have\n  BGPVPN_L3 \u003d \u0027l3\u0027\n  BGPVPN_L2 \u003d \u0027l2\u0027\n  BGPVPN_TYPES \u003d [BGPVPN_L3, BGPVPN_L2]\n\nplus also\n  BGPVPN \u003d \"BGPVPN\"\n  BGPVPN_RES \u003d \"bgpvpns\"\n\nand some regexes. So I\u0027ll add all the BGPVPN_ ones here, but then do we keep networking_bgpvpn/neutron/services/common/constants.py around just for the regexes or do those belong somewhere better?","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"23ed0e61ab6c13f9512ab3e04d85f8ff86eb0bcc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from networking_bgpvpn.neutron.services.common import constants"},{"line_number":16,"context_line":"from neutron_lib.api import converters"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_fbb6f988","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":23},"in_reply_to":"ba5da102_e923c103","updated":"2016-10-30 08:26:14.000000000","message":"agree. there should be no dependencies here","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"f9417ca7c26e5a9c894a36a2d13f8145e34bf76e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                 \u0027is_visible\u0027: True,"},{"line_number":68,"context_line":"                 \u0027enforce_policy\u0027: True},"},{"line_number":69,"context_line":"        \u0027type\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":70,"context_line":"                 \u0027default\u0027: constants.BGPVPN_L3,"},{"line_number":71,"context_line":"                 \u0027validate\u0027: {\u0027type:values\u0027: constants.BGPVPN_TYPES},"},{"line_number":72,"context_line":"                 \u0027is_visible\u0027: True,"},{"line_number":73,"context_line":"                 \u0027enforce_policy\u0027: True},"},{"line_number":74,"context_line":"        \u0027route_targets\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":75,"context_line":"                          \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_291e99ba","line":72,"range":{"start_line":70,"start_character":3,"end_line":72,"end_character":8},"updated":"2016-10-28 08:06:07.000000000","message":"See above.","commit_id":"23b01c93592cc75c44067abd7f13538e9e614989"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"047db7510e687761fd5572ef236bafe1e5dd223d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"}"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"# The action map."},{"line_number":155,"context_line":"ACTION_MAP \u003d {                     # FIXME: Copied from trunk.py"},{"line_number":156,"context_line":"    RESOURCE_NAME: {                      # Need to figure out if bgpvpn.py"},{"line_number":157,"context_line":"        \u0027add_subports\u0027: \u0027PUT\u0027,     # should include an ACTION_MAP and"},{"line_number":158,"context_line":"        \u0027remove_subports\u0027: \u0027PUT\u0027,  # if so, what should be in it."},{"line_number":159,"context_line":"        \u0027get_subports\u0027: \u0027GET\u0027"},{"line_number":160,"context_line":"    }"},{"line_number":161,"context_line":"}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# The list of required extensions."},{"line_number":164,"context_line":"REQUIRED_EXTENSIONS \u003d ["}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_ac8210c6","line":161,"range":{"start_line":154,"start_character":0,"end_line":161,"end_character":1},"updated":"2016-12-06 12:17:30.000000000","message":"This really needs to be removed: we don\u0027t have any plan at this point to use actions in BGPVPN API.","commit_id":"f0334fc75efbc27cb541ed1456a806d6877caa75"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"047db7510e687761fd5572ef236bafe1e5dd223d","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# The list of optional extensions."},{"line_number":169,"context_line":"OPTIONAL_EXTENSIONS \u003d None"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def get_attribute_map():"},{"line_number":172,"context_line":"    return RESOURCE_ATTRIBUTE_MAP"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_8c18f4d4","line":170,"updated":"2016-12-06 12:17:30.000000000","message":"You need an additional newline here.","commit_id":"f0334fc75efbc27cb541ed1456a806d6877caa75"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0ac04b16e49682c8075a81e17ab3df961f27922c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3a71b18c_ea7ca8ed","updated":"2016-12-07 16:05:27.000000000","message":"I think we need a UT for this. See what\u0027s already been done under the api definitions UTs and also in other patches out for review.","commit_id":"1ac2bbde7e846c15298f1bb019b470f271d2e002"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"3cc3f9b5469bcb82d3632b1e93577169fe22c773","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3a71b18c_9aa169ac","in_reply_to":"3a71b18c_ea7ca8ed","updated":"2016-12-09 09:52:48.000000000","message":"Why not.\n\nExample here:\n\nhttps://review.openstack.org/#/c/407308/3/neutron_lib/tests/unit/api/definitions/test__dummy.py","commit_id":"1ac2bbde7e846c15298f1bb019b470f271d2e002"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0ac04b16e49682c8075a81e17ab3df961f27922c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    NETWORK_ASSOCIATIONS: {"},{"line_number":112,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: COLLECTION_NAME,"},{"line_number":113,"context_line":"                   \u0027member_name\u0027: RESOURCE_NAME},"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_cab44cd6","line":110,"updated":"2016-12-07 16:05:27.000000000","message":"It\u0027s still not clear to me how we\u0027re going to handle sub attr maps. See discussion started here: https://review.openstack.org/#/c/407308/","commit_id":"1ac2bbde7e846c15298f1bb019b470f271d2e002"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ea7456b668f2e71bebb51a80022127949d31833d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    NETWORK_ASSOCIATIONS: {"},{"line_number":112,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: COLLECTION_NAME,"},{"line_number":113,"context_line":"                   \u0027member_name\u0027: RESOURCE_NAME},"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_8bf3210a","line":110,"in_reply_to":"1a6eadb0_26725be6","updated":"2016-12-13 08:34:25.000000000","message":"There are two other uses of subresources that I could find with codesearch [1]:\n- midonet\n- lbaas\n\n[1] http://codesearch.openstack.org/?q\u003dSUB_RESOURCE_ATTRIBUTE_MAP\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dnetworking-6wind,networking-ale-omniswitch,networking-arista,networking-bagpipe,networking-bgpvpn,networking-bigswitch,networking-brocade,networking-calico,networking-cisco,networking-edge-vpn,networking-extreme,networking-fortinet,networking-fujitsu,networking-generic-switch,networking-hpe,networking-huawei,networking-hyperv,networking-ibm,networking-icc,networking-infoblox,networking-l2gw,networking-lenovo,networking-midonet,networking-mlnx,networking-nec,networking-odl,networking-ofagent,networking-onos,networking-ovn,networking-ovs-dpdk,networking-plumgrid,networking-portforwarding,networking-powervm,networking-sfc,networking-vpp,networking-vsphere,networking-zvm,neutron,neutron-classifier,neutron-dynamic-routing,neutron-fwaas,neutron-lbaas,neutron-lbaas-dashboard,neutron-lib,neutron-salt-formula,neutron-specs,neutron-vpnaas","commit_id":"1ac2bbde7e846c15298f1bb019b470f271d2e002"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"05a852795d3717e72b4fec09ef530f3bab9dcc19","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    NETWORK_ASSOCIATIONS: {"},{"line_number":112,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: COLLECTION_NAME,"},{"line_number":113,"context_line":"                   \u0027member_name\u0027: RESOURCE_NAME},"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_26725be6","line":110,"in_reply_to":"3a71b18c_ba2e25f8","updated":"2016-12-12 20:19:19.000000000","message":"IMO the way this was handled in [1] is not what we conventionally did with Neutron extensions. This SUB_RESOURCE_ATTRIBUTE_MAP is basically a RESOURCE_ATTRIBUTE_MAP that is introduced to extend another extension and its resources. As such it should have been modeled as a separate extension, which depends on the initially one.\n\nI can see there are other examples in [2] where this was modeled this way (e.g. flavors and qos). Are you aware of any other?\n\nTo me the advantage of keeping a flat resource map model is that it\u0027s easier to understand, and we have more declarative boilerplate over imperative one, which is an added bonus. I am still on the fence on which way to go about this, i.e. break this API definition in two, or consider subresources a canonical way of modeling things. As for the latter, we definitely need to revise UTs to address gaps.\n\n[1] https://github.com/openstack/networking-bgpvpn/blob/master/networking_bgpvpn/neutron/extensions/bgpvpn.py#L180\n[2] https://github.com/openstack/neutron/tree/master/neutron/extensions","commit_id":"1ac2bbde7e846c15298f1bb019b470f271d2e002"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"3cc3f9b5469bcb82d3632b1e93577169fe22c773","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    NETWORK_ASSOCIATIONS: {"},{"line_number":112,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: COLLECTION_NAME,"},{"line_number":113,"context_line":"                   \u0027member_name\u0027: RESOURCE_NAME},"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_ba2e25f8","line":110,"in_reply_to":"3a71b18c_cab44cd6","updated":"2016-12-09 09:52:48.000000000","message":"The discussion in  https://review.openstack.org/#/c/407308/ concluded by \"Re SUB resource map, we can always update the template later if we see the need.\".\n\nI don\u0027t see an obvious alternative to defining the sub resource map this way.\n\nUnless there is an identified drawback of doing it this way, I propose to keep this.","commit_id":"1ac2bbde7e846c15298f1bb019b470f271d2e002"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0ac04b16e49682c8075a81e17ab3df961f27922c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"OPTIONAL_EXTENSIONS \u003d None"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def get_attribute_map():"},{"line_number":161,"context_line":"    return RESOURCE_ATTRIBUTE_MAP"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def get_sub_attribute_map():"},{"line_number":165,"context_line":"    return SUB_RESOURCE_ATTRIBUTE_MAP"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# TODO(armax): add support for modeling custom queries"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_4a94bc43","line":165,"range":{"start_line":160,"start_character":0,"end_line":165,"end_character":37},"updated":"2016-12-07 16:05:27.000000000","message":"Based on [1] I don\u0027t think we\u0027re using these getter functions anymore.\n\n\n[1] https://review.openstack.org/#/c/394244","commit_id":"1ac2bbde7e846c15298f1bb019b470f271d2e002"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"3cc3f9b5469bcb82d3632b1e93577169fe22c773","unresolved":false,"context_lines":[{"line_number":157,"context_line":"OPTIONAL_EXTENSIONS \u003d None"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def get_attribute_map():"},{"line_number":161,"context_line":"    return RESOURCE_ATTRIBUTE_MAP"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def get_sub_attribute_map():"},{"line_number":165,"context_line":"    return SUB_RESOURCE_ATTRIBUTE_MAP"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# TODO(armax): add support for modeling custom queries"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_fa017d6b","line":165,"range":{"start_line":160,"start_character":0,"end_line":165,"end_character":37},"in_reply_to":"3a71b18c_4a94bc43","updated":"2016-12-09 09:52:48.000000000","message":"Seems true indeed; both accessors can be removeD.","commit_id":"1ac2bbde7e846c15298f1bb019b470f271d2e002"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0ac04b16e49682c8075a81e17ab3df961f27922c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"def get_sub_attribute_map():"},{"line_number":165,"context_line":"    return SUB_RESOURCE_ATTRIBUTE_MAP"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# TODO(armax): add support for modeling custom queries"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_ca860c16","line":167,"updated":"2016-12-07 16:05:27.000000000","message":"Probably don\u0027t need this TODO line.","commit_id":"1ac2bbde7e846c15298f1bb019b470f271d2e002"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"3cc3f9b5469bcb82d3632b1e93577169fe22c773","unresolved":false,"context_lines":[{"line_number":164,"context_line":"def get_sub_attribute_map():"},{"line_number":165,"context_line":"    return SUB_RESOURCE_ATTRIBUTE_MAP"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# TODO(armax): add support for modeling custom queries"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_5af3519e","line":167,"in_reply_to":"3a71b18c_ca860c16","updated":"2016-12-09 09:52:48.000000000","message":"Agree.","commit_id":"1ac2bbde7e846c15298f1bb019b470f271d2e002"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The alias of the extension."},{"line_number":19,"context_line":"ALIAS \u003d \u0027bgpvpn\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Whether or not this extension is simply signaling behavior to the user"},{"line_number":22,"context_line":"# or it actively modifies the attribute map."},{"line_number":23,"context_line":"IS_SHIM_EXTENSION \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_0186f664","line":20,"updated":"2016-12-13 18:19:56.000000000","message":"Based on [1], we should also define the LABEL.\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/_dummy.py#L20","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The alias of the extension."},{"line_number":19,"context_line":"ALIAS \u003d \u0027bgpvpn\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Whether or not this extension is simply signaling behavior to the user"},{"line_number":22,"context_line":"# or it actively modifies the attribute map."},{"line_number":23,"context_line":"IS_SHIM_EXTENSION \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_f2fa4f74","line":20,"in_reply_to":"1a6eadb0_0186f664","updated":"2016-12-15 09:58:58.000000000","message":"Ack,","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"614da8d17ef0082225800702deb560e44d8643e6","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The alias of the extension."},{"line_number":19,"context_line":"ALIAS \u003d \u0027bgpvpn\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Whether or not this extension is simply signaling behavior to the user"},{"line_number":22,"context_line":"# or it actively modifies the attribute map."},{"line_number":23,"context_line":"IS_SHIM_EXTENSION \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_a1351947","line":20,"in_reply_to":"1a6eadb0_0186f664","updated":"2016-12-20 17:13:25.000000000","message":"Done","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    NETWORK_ASSOCIATIONS: {"},{"line_number":112,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: COLLECTION_NAME,"},{"line_number":113,"context_line":"                   \u0027member_name\u0027: RESOURCE_NAME},"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_010996dd","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":26},"updated":"2016-12-13 18:19:56.000000000","message":"IIUC, we still don\u0027t have the means to handle SUB_RESOURCE_ATTRIBUTE_MAP this yet. As Armando suggested, maybe this should be separated into it\u0027s own def? Otherwise we likely need to take SUB_RESOURCE_ATTRIBUTE_MAP into account in  [1] or other work.\n\n\n[1] https://review.openstack.org/#/c/394244/","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c19aabff4ffbf3734f18a369055ab58368c1aabd","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    NETWORK_ASSOCIATIONS: {"},{"line_number":112,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: COLLECTION_NAME,"},{"line_number":113,"context_line":"                   \u0027member_name\u0027: RESOURCE_NAME},"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_8b14464d","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":26},"in_reply_to":"1a6eadb0_00674ce9","updated":"2016-12-16 13:34:18.000000000","message":"Armando: would you also agree that [1] needs to take into account the sub resource map?\n\n\n[1] https://review.openstack.org/#/c/394244","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    NETWORK_ASSOCIATIONS: {"},{"line_number":112,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: COLLECTION_NAME,"},{"line_number":113,"context_line":"                   \u0027member_name\u0027: RESOURCE_NAME},"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_5254e31f","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":26},"in_reply_to":"1a6eadb0_010996dd","updated":"2016-12-15 09:58:58.000000000","message":"Can you explain more on what is missing to handle SUB_RESOURCE_ATTRIBUTE_MAP ? Is it the unit testing part, is it more ?\n\n(from the viewpoint of the project using this API, nothing is missing, we\u0027ve been using this sub-resource from day one)","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"29fdc3974cf451c129452ca78d83763f0c27bb16","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    NETWORK_ASSOCIATIONS: {"},{"line_number":112,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: COLLECTION_NAME,"},{"line_number":113,"context_line":"                   \u0027member_name\u0027: RESOURCE_NAME},"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_00674ce9","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":26},"in_reply_to":"1a6eadb0_010996dd","updated":"2016-12-16 02:07:55.000000000","message":"What I meant in [1], is that with the introduction of SUB_RESOURCE_ATTRIBUTE_MAP where\u0027 exposing a single extension alias but introducing resources and their children (one level down from  a parent resource). My mental way of modelling this situation has always been to introduce one level of resources per extension. But I can see two-level resource modeling has been done in many places.\n\nSo I am thinking that maybe yeah, we want to stick with this to avoid too much churn, but if we do, I\u0027d like to make sure any mismatch is caught by UTs. And I can volunteer to model this in the _dummy extension. So bear with me.\n\nMakes sense?\n\n[1] https://review.openstack.org/#/c/390196/11/neutron_lib/api/definitions/bgpvpn.py@110","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17041b34021af4024092ce7d1984626d935db4d8","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    NETWORK_ASSOCIATIONS: {"},{"line_number":112,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: COLLECTION_NAME,"},{"line_number":113,"context_line":"                   \u0027member_name\u0027: RESOURCE_NAME},"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_edbb3be3","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":26},"in_reply_to":"1a6eadb0_5254e31f","updated":"2016-12-15 16:37:58.000000000","message":"IIUC we\u0027re moving towards an attributes based API in [1] (I need to follow up on this patch, its getting stale). In [2] you can see the introduction of an API that keeps track of all api extension attr maps. Best I can tell [2] doesn\u0027t account for SUB_RESOURCE_ATTRIBUTE_MAP and therefore won\u0027t know about any of sub resource definitions.\n\n\nWith that in mind; is there any reason the SUB_RESOURCE_ATTRIBUTE_MAP definitions can\u0027t be moved into RESOURCE_ATTRIBUTE_MAP or put into their own definition if appropriate?\n\n\n[1] https://review.openstack.org/#/c/394244/\n[2] https://review.openstack.org/#/c/394244/neutron_lib/api/attributes.py","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"614da8d17ef0082225800702deb560e44d8643e6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    NETWORK_ASSOCIATIONS: {"},{"line_number":112,"context_line":"        \u0027parent\u0027: {\u0027collection_name\u0027: COLLECTION_NAME,"},{"line_number":113,"context_line":"                   \u0027member_name\u0027: RESOURCE_NAME},"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_1cc63049","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":26},"in_reply_to":"1a6eadb0_8b14464d","updated":"2016-12-20 17:13:25.000000000","message":"I\u0027ve split the API definition out into a separate commit so that we can muddle through this independent of completing the API reference documentation.\n\nIt wasn\u0027t my intention to introduce code changes with this commit. The SUB_RESOURCE_ATTRIBUTE_MAP was copied and pasted from the file in networking-bgpvpn where it is already in use and working as Thomas has mentioned.\n\nI\u0027d prefer to leave it as is, and figure out what additional is needed in terms of unit tests and anything else, but if it does need to change then it\u0027s not just a change to the API definition in neutron-lib but also to the implementation in networking-bgpvpn that depends on it (or technically, that will depend on it once I make the change in networking-bgpvpn to remove the code and import it from neutron-lib.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"# The list of required extensions."},{"line_number":152,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":153,"context_line":"    \"binding\","},{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# The list of optional extensions."}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_ed435240","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":14},"updated":"2016-12-15 09:58:58.000000000","message":"pcarver, why is this here ?\n(don\u0027t know why I didn\u0027t spot this earlier)","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"614da8d17ef0082225800702deb560e44d8643e6","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"# The list of required extensions."},{"line_number":152,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":153,"context_line":"    \"binding\","},{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# The list of optional extensions."}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_c15db57a","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":14},"in_reply_to":"1a6eadb0_ed435240","updated":"2016-12-20 17:13:25.000000000","message":"Probably copied directly from trunk.py which I was using as an example. If we don\u0027t require anything I\u0027ll delete it.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0d2e9f84099ab0f25c48f468f58f9e033a5b2a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# The list of optional extensions."},{"line_number":157,"context_line":"OPTIONAL_EXTENSIONS \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_21cbf2a6","line":157,"updated":"2016-12-13 18:19:56.000000000","message":"Based on [1], maybe this should be an empty list?\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/_dummy.py#L81","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"614da8d17ef0082225800702deb560e44d8643e6","unresolved":false,"context_lines":[{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# The list of optional extensions."},{"line_number":157,"context_line":"OPTIONAL_EXTENSIONS \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_41e1a599","line":157,"in_reply_to":"1a6eadb0_21cbf2a6","updated":"2016-12-20 17:13:25.000000000","message":"Also copied from trunk.py. I\u0027ll change this to an empty list.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b4a749078511cb04a3d59e8323b409033104e6f9","unresolved":false,"context_lines":[{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# The list of optional extensions."},{"line_number":157,"context_line":"OPTIONAL_EXTENSIONS \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_0d416e38","line":157,"in_reply_to":"1a6eadb0_21cbf2a6","updated":"2016-12-15 09:58:58.000000000","message":"Yes.","commit_id":"9f8e3058ae83efa4e6be4ba1ffb3f936e46282be"}],"neutron_lib/tests/unit/api/definitions/bgpvpn.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3e9975433de09c86431a1ce69aa92304f1c9de33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1a6eadb0_c7a032f7","updated":"2016-12-21 16:03:36.000000000","message":"This should go with the api definition itself in: https://review.openstack.org/#/c/413182/","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"}],"neutron_lib/tests/unit/api/definitions/test_bgpvpn.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d19f733646607b16f44f9c07d88ddb49b958a46b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"1a430d35_a0a8698e","updated":"2017-02-07 16:56:27.000000000","message":"There are changes in the BGPVPN change, and the TrunkDefinitionTestCase is removed, but this change should not even touch this file, right ?","commit_id":"1e6b580b95c86146c982ed8308a9b3b79eb367e2"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"840f9b6175b43302666f6531c0811254a6e23838","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"1a430d35_fbb14048","in_reply_to":"1a430d35_a0a8698e","updated":"2017-02-07 17:08:34.000000000","message":"This rebasing is driving me crazy. That TrunkDefinitionTestCas should never have been added in the first place. It was a temporary addition, as a comment, to the API definition change while I was making sure that the API definition exactly matched the Trunk example.\n\nSomehow, maybe when I rebased the API ref on top of the API def it pulled in a copy of WIP that wasn\u0027t even supposed to be here. I\u0027ll push a new change to get it out.","commit_id":"1e6b580b95c86146c982ed8308a9b3b79eb367e2"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ae402748cdc338d619cead5c9dbc1e69b56fa8c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"1a430d35_9b659cb6","in_reply_to":"1a430d35_fbb14048","updated":"2017-02-07 17:10:54.000000000","message":"Yep, rebasing can indeed be cumbersome.\nBon courage!","commit_id":"1e6b580b95c86146c982ed8308a9b3b79eb367e2"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"045ccb8d09286e60ed8fcb858e65dea388eeed73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"1a430d35_db9c845f","updated":"2017-02-07 17:15:31.000000000","message":"This change is now deleting the file  :-(","commit_id":"8d8beadc355ca0d50eb7afba2adb112e14dd2eac"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9f4fab40cb1d351b824fb251463121b5428e4ad0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"1a430d35_02b22006","in_reply_to":"1a430d35_1b0c4c40","updated":"2017-02-07 17:50:54.000000000","message":"Your bgpvpn-api-ref branch is rebased on top of the bgpvpn-api-def branch, so it should have the file (\"inherited\" from the bgpvpn-api-def) and all other files and changes from the BGPVPN API definition change.  It should \"ignore\" this file like other files for the BGPVPN API definition, rather than delete it.","commit_id":"8d8beadc355ca0d50eb7afba2adb112e14dd2eac"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"cb4859e3044655279942bb2df61141575f924cda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"1a430d35_1b0c4c40","in_reply_to":"1a430d35_db9c845f","updated":"2017-02-07 17:29:00.000000000","message":"Isn\u0027t that correct?\n\nWhat I have now in my local repo is that the branch bgpvpn-api-ref does not contain the API definition unit test. The branch bgpvpn-api-def DOES contain the API definition test case, and it\u0027s the correct test case which this file is not.\n\nI don\u0027t think the API definition or it\u0027s test case should be in the API reference change. However, when I look at my local repo the API definition DOES appear in the bgpvpn-api-ref branch although it doesn\u0027t appear in Gerrit. I don\u0027t know why. I expected that it shouldn\u0027t appear in my local repo.","commit_id":"8d8beadc355ca0d50eb7afba2adb112e14dd2eac"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ed68cfd043a17739486f66b8179d766ea40c3e57","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from neutron_lib.api.definitions import bgpvpn"},{"line_number":14,"context_line":"from neutron_lib.api.validators import validate_list_of_regex_or_none"},{"line_number":15,"context_line":"from neutron_lib.tests.unit.api.definitions import base"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa31d9ce_b64c6643","line":14,"updated":"2017-02-13 16:12:18.000000000","message":"Py tests are complaining about missing function [1] and I\u0027m not able to find it in neutron_lib repo [2]\n\n[1] http://logs.openstack.org/96/390196/31/check/gate-neutron-lib-python35/db8ffad/console.html#_2017-02-13_14_57_57_330707\n[2] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/validators.py","commit_id":"99202a5b9bb4569d78e2626909c41e72a78429ba"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6a4687d23f6c0df92d2e2205aaecc419a81df724","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from neutron_lib.api.definitions import bgpvpn"},{"line_number":14,"context_line":"from neutron_lib.api.validators import validate_list_of_regex_or_none"},{"line_number":15,"context_line":"from neutron_lib.tests.unit.api.definitions import base"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa31d9ce_bc3b6437","line":14,"in_reply_to":"fa31d9ce_b64c6643","updated":"2017-02-13 17:56:52.000000000","message":"I hate rebasing and it hates me. This is from the API definition change 413182, not the API reference change. But the API definition change is failing too, because that function went AWOL between patch sets. I think git review killed it and hid the body.","commit_id":"99202a5b9bb4569d78e2626909c41e72a78429ba"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"56efe0f740a0549709c8cfa9235d74b5b3ab4d76","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from neutron_lib.api.definitions import bgpvpn"},{"line_number":14,"context_line":"from neutron_lib.api.validators import validate_list_of_regex_or_none"},{"line_number":15,"context_line":"from neutron_lib.tests.unit.api.definitions import base"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa31d9ce_e0044619","line":14,"in_reply_to":"fa31d9ce_bc3b6437","updated":"2017-02-13 20:56:45.000000000","message":"Ack","commit_id":"99202a5b9bb4569d78e2626909c41e72a78429ba"}],"releasenotes/notes/bgpvpn-api-ref-f0294d9ddec726a0.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3e9975433de09c86431a1ce69aa92304f1c9de33","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - API reference for networking-bgpvpn extension"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1a6eadb0_0a84ef08","line":3,"range":{"start_line":3,"start_character":18,"end_line":3,"end_character":22},"updated":"2016-12-21 16:03:36.000000000","message":"Nit \"for the..\"","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3e9975433de09c86431a1ce69aa92304f1c9de33","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - API reference for networking-bgpvpn extension"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1a6eadb0_6a73a34e","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":49},"updated":"2016-12-21 16:03:36.000000000","message":"Nit: period at the end of sentence.","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - API reference for networking-bgpvpn extension"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba5201f7_e75f5670","line":3,"range":{"start_line":3,"start_character":18,"end_line":3,"end_character":22},"in_reply_to":"1a6eadb0_0a84ef08","updated":"2017-01-02 17:46:30.000000000","message":"Done","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"128bc1c623f170fef72750e5f89c3c93180c4019","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - API reference for networking-bgpvpn extension"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba5201f7_07553a4f","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":49},"in_reply_to":"1a6eadb0_6a73a34e","updated":"2017-01-02 17:46:30.000000000","message":"Done","commit_id":"592d138b7ac17b2b27e6643173a4ffcec3a763ca"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"862947c03721a1de68dda0274dc95b9eb33c0655","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - API reference for the networking-bgpvpn extension."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3a461143_01eb98b1","line":3,"range":{"start_line":3,"start_character":26,"end_line":3,"end_character":43},"updated":"2017-02-01 15:32:20.000000000","message":"Nit: use ``networking-bgpvpn`` to be consistent with bgpvpn api-def release note.","commit_id":"d940555ce3b58ed95b8648bf79a401f10351ec83"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"3834767e4e60baf2ea2c09d344605d15a83307c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - API reference for the networking-bgpvpn extension."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"1a430d35_15928b9e","line":3,"range":{"start_line":3,"start_character":26,"end_line":3,"end_character":43},"in_reply_to":"3a461143_01eb98b1","updated":"2017-02-07 16:02:42.000000000","message":"Done","commit_id":"d940555ce3b58ed95b8648bf79a401f10351ec83"}]}
