)]}'
{"neutron_lib/api/validators.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1be89e74a6e27391405b61116c4443bcb4211ecd","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            return msg"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class _check_valid_values(object):"},{"line_number":105,"context_line":"    \"\"\"Decorates validators to automatically validate valid_values."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    This decorator can be used on validator functions that wish to"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_bf21bfa1","line":104,"updated":"2016-10-31 12:23:05.000000000","message":"Is it possible to remove duplication by creating a common decorator for all the validators to use?","commit_id":"3687bc2686ae6ac53d89cf74129d11fbd8ae10c5"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"db8ea65202e2ca092887c14c977fa5325b2c0a62","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            return msg"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class _check_valid_values(object):"},{"line_number":105,"context_line":"    \"\"\"Decorates validators to automatically validate valid_values."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    This decorator can be used on validator functions that wish to"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_3f6e8f95","line":104,"in_reply_to":"ba5da102_bf21bfa1","updated":"2016-10-31 12:28:35.000000000","message":"Never mind... just noticed that these are all in the same file and not in separate validator files...","commit_id":"3687bc2686ae6ac53d89cf74129d11fbd8ae10c5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"795b5e434821a96a77f185db95fc6230fa08874d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        will not validate data is iterable, and after successful return from"},{"line_number":122,"context_line":"        the validation function will validate data is in valid_values."},{"line_number":123,"context_line":"        :param data_debug_name: If iterate_on_data is True, data_debug_name"},{"line_number":124,"context_line":"        is used in the debug logging message to indicate the dataum is"},{"line_number":125,"context_line":"        not iterable (when applicable)."},{"line_number":126,"context_line":"        \"\"\""},{"line_number":127,"context_line":"        self.iterate_on_data \u003d iterate_on_data"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_0f9247f6","line":124,"range":{"start_line":124,"start_character":61,"end_line":124,"end_character":67},"updated":"2016-11-01 22:08:24.000000000","message":"data","commit_id":"cf9caa67375260851f42e495ccac7e15c06a857c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f80501d5955cce9e3400b6ad006d4fffa7555f98","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        will not validate data is iterable, and after successful return from"},{"line_number":122,"context_line":"        the validation function will validate data is in valid_values."},{"line_number":123,"context_line":"        :param data_debug_name: If iterate_on_data is True, data_debug_name"},{"line_number":124,"context_line":"        is used in the debug logging message to indicate the dataum is"},{"line_number":125,"context_line":"        not iterable (when applicable)."},{"line_number":126,"context_line":"        \"\"\""},{"line_number":127,"context_line":"        self.iterate_on_data \u003d iterate_on_data"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_33f7b1f6","line":124,"range":{"start_line":124,"start_character":61,"end_line":124,"end_character":67},"in_reply_to":"9a629dbe_d012ebb3","updated":"2016-11-08 21:31:39.000000000","message":"Datum would be perfectly fine. Yeah, I agree. Not worth another patchset, unless something else comes up","commit_id":"cf9caa67375260851f42e495ccac7e15c06a857c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e4eeaaa186ca4c8a450aceaea00b42422b35e51d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        will not validate data is iterable, and after successful return from"},{"line_number":122,"context_line":"        the validation function will validate data is in valid_values."},{"line_number":123,"context_line":"        :param data_debug_name: If iterate_on_data is True, data_debug_name"},{"line_number":124,"context_line":"        is used in the debug logging message to indicate the dataum is"},{"line_number":125,"context_line":"        not iterable (when applicable)."},{"line_number":126,"context_line":"        \"\"\""},{"line_number":127,"context_line":"        self.iterate_on_data \u003d iterate_on_data"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_d012ebb3","line":124,"range":{"start_line":124,"start_character":61,"end_line":124,"end_character":67},"in_reply_to":"ba5da102_0f9247f6","updated":"2016-11-08 21:18:37.000000000","message":"I actually intended to use datum [1] here since in this case its not iterable. However if its confusing I can change it (IMO its not worth another patch in itself tho).\n\n\n[1] https://en.wikipedia.org/wiki/Datum","commit_id":"cf9caa67375260851f42e495ccac7e15c06a857c"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"062b2a3cc0319c90f7b2cc803358bde91387ddcd","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    \"\"\"Validate data is a python bool compatible object."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    :param data: The data to validate."},{"line_number":282,"context_line":"    :param valid_values: If specified, validate_values() will be called"},{"line_number":283,"context_line":"    after validating data to ensure data is in valid_values. This allows"},{"line_number":284,"context_line":"    consumers to constrain the valid values data may take on."},{"line_number":285,"context_line":"    :return: None if the value can be converted to a bool, otherwise a"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_89641be6","line":282,"range":{"start_line":282,"start_character":11,"end_line":282,"end_character":23},"updated":"2016-11-29 22:40:21.000000000","message":"ditto.","commit_id":"cf9caa67375260851f42e495ccac7e15c06a857c"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"062b2a3cc0319c90f7b2cc803358bde91387ddcd","unresolved":false,"context_lines":[{"line_number":529,"context_line":"def validate_nameservers(data, valid_values\u003dNone):"},{"line_number":530,"context_line":"    \"\"\"Validate a list of unique IP addresses."},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    :param data: The data to validate."},{"line_number":533,"context_line":"    :param valid_values: If specified, validate_values() will be called"},{"line_number":534,"context_line":"    after validating data to ensure data is in valid_values. This allows"},{"line_number":535,"context_line":"    consumers to constrain the valid values data may take on."}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_893dfbbd","line":532,"range":{"start_line":532,"start_character":11,"end_line":532,"end_character":15},"updated":"2016-11-29 22:40:21.000000000","message":":param iterate_on_data","commit_id":"cf9caa67375260851f42e495ccac7e15c06a857c"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"062b2a3cc0319c90f7b2cc803358bde91387ddcd","unresolved":false,"context_lines":[{"line_number":530,"context_line":"    \"\"\"Validate a list of unique IP addresses."},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    :param data: The data to validate."},{"line_number":533,"context_line":"    :param valid_values: If specified, validate_values() will be called"},{"line_number":534,"context_line":"    after validating data to ensure data is in valid_values. This allows"},{"line_number":535,"context_line":"    consumers to constrain the valid values data may take on."},{"line_number":536,"context_line":"    :returns: None if data is a list of valid IP addresses, otherwise"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_09780b8f","line":533,"range":{"start_line":533,"start_character":11,"end_line":533,"end_character":23},"updated":"2016-11-29 22:40:21.000000000","message":":param data_debug_name","commit_id":"cf9caa67375260851f42e495ccac7e15c06a857c"}],"neutron_lib/tests/unit/api/test_validators.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1be89e74a6e27391405b61116c4443bcb4211ecd","unresolved":false,"context_lines":[{"line_number":812,"context_line":"                 {\u0027uuid\u0027: \u0027e5069610-744b-42a7-8bd8-ceac1a229cd4\u0027}]"},{"line_number":813,"context_line":"        for item in items:"},{"line_number":814,"context_line":"            msg \u003d validators._validate_list_of_items(mock.Mock(), item)"},{"line_number":815,"context_line":"            error \u003d \"Invalid format for \u0027data\u0027. Valid data must be a \" \\"},{"line_number":816,"context_line":"                    \"list or set.\""},{"line_number":817,"context_line":"            self.assertEqual(error, msg)"},{"line_number":818,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_7f4e4770","line":815,"updated":"2016-10-31 12:23:05.000000000","message":"parens vs backslash for continuation.","commit_id":"3687bc2686ae6ac53d89cf74129d11fbd8ae10c5"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"6f788f2c75b98433914a51a7b6e5a3bd9b46dcfc","unresolved":false,"context_lines":[{"line_number":812,"context_line":"                 {\u0027uuid\u0027: \u0027e5069610-744b-42a7-8bd8-ceac1a229cd4\u0027}]"},{"line_number":813,"context_line":"        for item in items:"},{"line_number":814,"context_line":"            msg \u003d validators._validate_list_of_items(mock.Mock(), item)"},{"line_number":815,"context_line":"            error \u003d \"Invalid format for \u0027data\u0027. Valid data must be a \" \\"},{"line_number":816,"context_line":"                    \"list or set.\""},{"line_number":817,"context_line":"            self.assertEqual(error, msg)"},{"line_number":818,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_c6b867e8","line":815,"in_reply_to":"ba5da102_7f4e4770","updated":"2016-10-31 16:19:08.000000000","message":"Done","commit_id":"3687bc2686ae6ac53d89cf74129d11fbd8ae10c5"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1be89e74a6e27391405b61116c4443bcb4211ecd","unresolved":false,"context_lines":[{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    @mock.patch.object(validators, \u0027LOG\u0027)"},{"line_number":1048,"context_line":"    def test_check_valid_values_invalid_iter_data(self, mock_log):"},{"line_number":1049,"context_line":"        expected_msg \u003d \"Invalid format for \u0027nameserver\u0027. \" \\"},{"line_number":1050,"context_line":"                       \"Valid data must be a list or set.\""},{"line_number":1051,"context_line":"        valid \u003d [\u00271.1.1.1\u0027, \u00272.2.2.2\u0027, \u00273.3.3.3\u0027]"},{"line_number":1052,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_ff6977bf","line":1049,"updated":"2016-10-31 12:23:05.000000000","message":"ditto","commit_id":"3687bc2686ae6ac53d89cf74129d11fbd8ae10c5"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"6f788f2c75b98433914a51a7b6e5a3bd9b46dcfc","unresolved":false,"context_lines":[{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    @mock.patch.object(validators, \u0027LOG\u0027)"},{"line_number":1048,"context_line":"    def test_check_valid_values_invalid_iter_data(self, mock_log):"},{"line_number":1049,"context_line":"        expected_msg \u003d \"Invalid format for \u0027nameserver\u0027. \" \\"},{"line_number":1050,"context_line":"                       \"Valid data must be a list or set.\""},{"line_number":1051,"context_line":"        valid \u003d [\u00271.1.1.1\u0027, \u00272.2.2.2\u0027, \u00273.3.3.3\u0027]"},{"line_number":1052,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_06797f2f","line":1049,"in_reply_to":"ba5da102_ff6977bf","updated":"2016-10-31 16:19:08.000000000","message":"Done","commit_id":"3687bc2686ae6ac53d89cf74129d11fbd8ae10c5"}]}
