)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"44f116c2e6a72b9d3c5d11f4eeb22344010b722d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add API references for FWaaS v2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: I7b4108772e8370e8f51971caf40ecd23e9f977e9"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icc6f8b5f04268a7efc3522b28f30df1283fcdfda"},{"line_number":14,"context_line":"Partial-Implements: blueprint fwaas-api-2.0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"1a6eadb0_ede42da9","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"updated":"2016-12-21 16:35:55.000000000","message":"Depends-On is only for changes in a different project/repo. You can just rebase this one on its dependency if in the same repo.","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add API references for FWaaS v2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: I7b4108772e8370e8f51971caf40ecd23e9f977e9"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icc6f8b5f04268a7efc3522b28f30df1283fcdfda"},{"line_number":14,"context_line":"Partial-Implements: blueprint fwaas-api-2.0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"da4df55a_42c7c563","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"1a6eadb0_ede42da9","updated":"2016-12-27 13:58:43.000000000","message":"I\u0027ve rebased it.","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"}],"api-ref/source/v2/fwaas-v2.inc":[{"author":{"_account_id":6995,"name":"Sridar Kandaswamy","email":"skandasw@yahoo.com","username":"skandasw"},"change_message_id":"adfd4a421f1a102e6fbead2fa927924b0689ce40","unresolved":false,"context_lines":[{"line_number":85,"context_line":"   - project_id: project_id"},{"line_number":86,"context_line":"   - firewall_list: firewall_list"},{"line_number":87,"context_line":"   - audited: audited"},{"line_number":88,"context_line":"   - shared: shared"},{"line_number":89,"context_line":"   - id: id"},{"line_number":90,"context_line":"   - description: description"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ba5da102_fb68d5bc","line":88,"updated":"2016-10-28 07:49:03.000000000","message":"the above should be public correct ? Same for all occurrences in the file.","commit_id":"32724d284d3e32b5a9ca4dc6a4b967c018fa1b55"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"8ed716307963cfe2f545630bd29658033e767629","unresolved":false,"context_lines":[{"line_number":85,"context_line":"   - project_id: project_id"},{"line_number":86,"context_line":"   - firewall_list: firewall_list"},{"line_number":87,"context_line":"   - audited: audited"},{"line_number":88,"context_line":"   - shared: shared"},{"line_number":89,"context_line":"   - id: id"},{"line_number":90,"context_line":"   - description: description"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ba5da102_90a093f6","line":88,"in_reply_to":"ba5da102_fb68d5bc","updated":"2016-10-28 08:41:37.000000000","message":"Done.","commit_id":"32724d284d3e32b5a9ca4dc6a4b967c018fa1b55"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":5,"context_line":".. needs:body_verification"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"FWaaS v2.0 (CURRENT) (fw, firewall_groups, firewall_policies, firewall_rules)"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Use the Firewall-as-a-Service (FWaaS) v2.0 extension to deploy"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_c6b895e8","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":25},"updated":"2016-11-07 09:54:53.000000000","message":"Is it a prefix for URI?  If so, we should specify \u0027fwaas\u0027, shouldn\u0027t we?","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":5,"context_line":".. needs:body_verification"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"FWaaS v2.0 (CURRENT) (fw, firewall_groups, firewall_policies, firewall_rules)"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Use the Firewall-as-a-Service (FWaaS) v2.0 extension to deploy"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_8db6d188","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":25},"in_reply_to":"ba5da102_c6b895e8","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":64,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   - insert_after: insert_after"},{"line_number":67,"context_line":"   - firewall_rule_id: firewall_rule_id"},{"line_number":68,"context_line":"   - insert_before: insert_before"},{"line_number":69,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_431717ed","line":67,"updated":"2016-11-07 09:54:53.000000000","message":"I saw a build result[1] and found that firewall_rule_id is not \u0027path\u0027 but \u0027body\u0027.  In addition, this value is required.\n\n\n[1]http://docs-draft.openstack.org/38/391338/7/check/gate-neutron-lib-api-ref/81b7957//api-ref/build/html/v2/index.html?expanded\u003did533-detail#fwaas-v2-0-current-fw-firewall-groups-firewall-policies-firewall-rules","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":64,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   - insert_after: insert_after"},{"line_number":67,"context_line":"   - firewall_rule_id: firewall_rule_id"},{"line_number":68,"context_line":"   - insert_before: insert_before"},{"line_number":69,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_0d4f21be","line":67,"in_reply_to":"ba5da102_431717ed","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   - insert_after: insert_after"},{"line_number":67,"context_line":"   - firewall_rule_id: firewall_rule_id"},{"line_number":68,"context_line":"   - insert_before: insert_before"},{"line_number":69,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Request Example"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_83d76f22","line":69,"updated":"2016-11-07 09:54:53.000000000","message":"firewall_policy_id is not \u0027body\u0027 but \u0027path\u0027.  It should be specified firewall_policy_id_2 with required\u003dTrue.","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   - insert_after: insert_after"},{"line_number":67,"context_line":"   - firewall_rule_id: firewall_rule_id"},{"line_number":68,"context_line":"   - insert_before: insert_before"},{"line_number":69,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Request Example"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_cd544956","line":69,"in_reply_to":"ba5da102_83d76f22","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":74,"context_line":".. literalinclude:: samples/firewall-v2/firewall-policy-insert-rule-request.json"},{"line_number":75,"context_line":"   :language: javascript"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Response Parameters"},{"line_number":78,"context_line":"-------------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_e3f74b8a","line":77,"updated":"2016-11-07 09:54:53.000000000","message":"Response parameters are all \u0027required\u0027 value.  Please reflect all response parameters.","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":74,"context_line":".. literalinclude:: samples/firewall-v2/firewall-policy-insert-rule-request.json"},{"line_number":75,"context_line":"   :language: javascript"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Response Parameters"},{"line_number":78,"context_line":"-------------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_8d35f147","line":77,"in_reply_to":"ba5da102_e3f74b8a","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"   - firewall_list: firewall_list"},{"line_number":87,"context_line":"   - audited: audited"},{"line_number":88,"context_line":"   - public: shared"},{"line_number":89,"context_line":"   - id: id"},{"line_number":90,"context_line":"   - description: description"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_e3c90b5c","line":89,"updated":"2016-11-07 09:54:53.000000000","message":"This explanation is \"The UUID of the network\".  It\u0027s better to specify firewall_policy_id_2 with required \"True\".","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":86,"context_line":"   - firewall_list: firewall_list"},{"line_number":87,"context_line":"   - audited: audited"},{"line_number":88,"context_line":"   - public: shared"},{"line_number":89,"context_line":"   - id: id"},{"line_number":90,"context_line":"   - description: description"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_8d5a5182","line":89,"in_reply_to":"ba5da102_e3c90b5c","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"   - project_id: project_id"},{"line_number":130,"context_line":"   - audited: audited"},{"line_number":131,"context_line":"   - public: shared"},{"line_number":132,"context_line":"   - id: id"},{"line_number":133,"context_line":"   - description: description"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_23db031d","line":132,"updated":"2016-11-07 09:54:53.000000000","message":"ditto","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":129,"context_line":"   - project_id: project_id"},{"line_number":130,"context_line":"   - audited: audited"},{"line_number":131,"context_line":"   - public: shared"},{"line_number":132,"context_line":"   - id: id"},{"line_number":133,"context_line":"   - description: description"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_6dcc1d36","line":132,"in_reply_to":"ba5da102_23db031d","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Response Parameters"},{"line_number":269,"context_line":"-------------------"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"   - firewall_policy: firewall_policy"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_c31087ab","line":270,"updated":"2016-11-07 09:54:53.000000000","message":"Following definition are missing:\n\n.. literalinclude:: samples/firewall-v2/firewall-policy-create-response.json\n   :language: javascript","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Response Parameters"},{"line_number":269,"context_line":"-------------------"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"   - firewall_policy: firewall_policy"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_c896f793","line":270,"in_reply_to":"ba5da102_c31087ab","updated":"2016-11-08 00:28:40.000000000","message":"Done.  And I\u0027ve added some other missing ones.  Thanks for catching this.","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Shows details for a firewall group."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"If the user is not an administrative user and the firewall group"},{"line_number":424,"context_line":"object does not belong to the project, this call returns the"},{"line_number":425,"context_line":"``Forbidden (403)`` response code."},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Normal response codes: 200"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_e6c3d988","line":425,"range":{"start_line":423,"start_character":1,"end_line":425,"end_character":34},"updated":"2016-11-07 09:54:53.000000000","message":"If a firewall group belongs to different project and an operator is not administrative user, the response result in 404(Not Found).  I tried to reproduce with current design and got returns 404[1].   (BTW, I think we shouldn\u0027t return 403.  Because, another project user can realize that specified ID exists in another project.)\n\n[1]http://paste.openstack.org/show/588219/","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Shows details for a firewall group."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"If the user is not an administrative user and the firewall group"},{"line_number":424,"context_line":"object does not belong to the project, this call returns the"},{"line_number":425,"context_line":"``Forbidden (403)`` response code."},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Normal response codes: 200"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_48d02754","line":425,"range":{"start_line":423,"start_character":1,"end_line":425,"end_character":34},"in_reply_to":"ba5da102_e6c3d988","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"   - ports: ports"},{"line_number":698,"context_line":"   - description: description"},{"line_number":699,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":700,"context_line":"   - firewall_group: firewall_group"},{"line_number":701,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":702,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":703,"context_line":"   - name: name"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"Request Example"},{"line_number":706,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_63497b8e","line":703,"range":{"start_line":697,"start_character":1,"end_line":703,"end_character":15},"updated":"2016-11-07 09:54:53.000000000","message":"All values except \u0027firewall_group\u0027 is \"Optional\".","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"   - ports: ports"},{"line_number":698,"context_line":"   - description: description"},{"line_number":699,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":700,"context_line":"   - firewall_group: firewall_group"},{"line_number":701,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":702,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":703,"context_line":"   - name: name"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"Request Example"},{"line_number":706,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_08a0ef9e","line":703,"range":{"start_line":697,"start_character":1,"end_line":703,"end_character":15},"in_reply_to":"ba5da102_63497b8e","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":701,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":702,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":703,"context_line":"   - name: name"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"Request Example"},{"line_number":706,"context_line":"---------------"},{"line_number":707,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_035b5f55","line":704,"updated":"2016-11-07 09:54:53.000000000","message":"Following values are missing:\n\n* tenant_id\n* project_id","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":701,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":702,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":703,"context_line":"   - name: name"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"Request Example"},{"line_number":706,"context_line":"---------------"},{"line_number":707,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_a887030e","line":704,"in_reply_to":"ba5da102_035b5f55","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"   - status: status"},{"line_number":717,"context_line":"   - ports: ports"},{"line_number":718,"context_line":"   - description: description"},{"line_number":719,"context_line":"   - admin_state_up: admin_state_up"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"ba5da102_c60df538","line":716,"updated":"2016-11-07 09:54:53.000000000","message":"\u0027status\u0027 describes \"The network status.\"  How about specifying a new value as follows?\n\ndescription\n\n* The status of the firewall group.  Value is  ``ACTIVE``, ``INACTIVE``, ``ERROR``, ``PENDING_UPDATE``, or ``PENDING_DELETE``.\n\nrequired\n\n* true\n\nin\n\n* body\n\ntype\n\n* string","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"   - status: status"},{"line_number":717,"context_line":"   - ports: ports"},{"line_number":718,"context_line":"   - description: description"},{"line_number":719,"context_line":"   - admin_state_up: admin_state_up"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a629dbe_a89e2354","line":716,"in_reply_to":"ba5da102_c60df538","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Shows details of a firewall policy."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"If the user is not an administrative user and the firewall policy"},{"line_number":106,"context_line":"object does not belong to the project, this call returns the"},{"line_number":107,"context_line":"``Forbidden (403)`` response code."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Normal response codes: 200"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_10f01190","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":34},"updated":"2016-11-08 12:23:09.000000000","message":"All of GET/PUT method returns 404[1] when it cannot access from own project.  I think this explanation is not necessary in this file.\n\n[1]http://paste.openstack.org/show/588336/","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Shows details of a firewall policy."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"If the user is not an administrative user and the firewall policy"},{"line_number":106,"context_line":"object does not belong to the project, this call returns the"},{"line_number":107,"context_line":"``Forbidden (403)`` response code."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Normal response codes: 200"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_f4d0d655","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":34},"in_reply_to":"9a629dbe_10f01190","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Normal response codes: 200"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Error response codes: 404,403,401"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Request"},{"line_number":114,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_b0d125fe","line":111,"updated":"2016-11-08 12:23:09.000000000","message":"Could you add 400(BadRequest) for all PUT method?  Here is a result for PUT firewall_policy with specifying wrong attribute:\n\n$ curl -i -X PUT -d \u0027{\"firewall_policy\":{\"namea\":\"changed\"}}\u0027 -H \"x-auth-token:$TOKEN\" 192.168.122.181:9696/v2.0/fwaas/firewall_po\nlicies/2e6bfa42-cea2-4885-8e15-2cd08c38a578\nHTTP/1.1 400 Bad Request\nContent-Length: 106\nContent-Type: application/json; charset\u003dUTF-8\nX-Openstack-Request-Id: req-84af5a3b-e96a-42c6-9afd-2249730772e7\nDate: Tue, 08 Nov 2016 04:40:31 GMT\n\n{\"NeutronError\": {\"message\": \"Unrecognized attribute(s) \u0027namea\u0027\", \"type\": \"HTTPBadRequest\", \"detail\": \"\"}}","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Normal response codes: 200"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Error response codes: 404,403,401"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Request"},{"line_number":114,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_14938a50","line":111,"in_reply_to":"9a629dbe_b0d125fe","updated":"2016-11-08 23:18:37.000000000","message":"I see that 400 is already listed as a possible response code for all PUT methods.  (The method that this comment is attached to is a GET.)","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Response Parameters"},{"line_number":121,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_512d21a6","line":118,"updated":"2016-11-08 12:23:09.000000000","message":"firewall_policy_id should be in \u0027path\u0027.  This value is \u0027body\u0027.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Response Parameters"},{"line_number":121,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_f460d637","line":118,"in_reply_to":"9a629dbe_512d21a6","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":125,"context_line":"   - firewall_policy: firewall_policy"},{"line_number":126,"context_line":"   - name: name"},{"line_number":127,"context_line":"   - firewall_rules: firewall_rules"},{"line_number":128,"context_line":"   - tenant_id: project_id"},{"line_number":129,"context_line":"   - project_id: project_id"},{"line_number":130,"context_line":"   - audited: audited"},{"line_number":131,"context_line":"   - public: shared"},{"line_number":132,"context_line":"   - id: firewall_policy_id_2"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_e43af5cc","line":129,"range":{"start_line":128,"start_character":0,"end_line":129,"end_character":27},"updated":"2016-11-08 12:23:09.000000000","message":"tenant_id and project_id are not \u0027path\u0027 but \u0027body in response parameters\n  Could you check all of request/response parameters for \u0027tenant_id\u0027 and \u0027project_id\u0027?\n\nrequest parameters\n\n* tenant_id(Optional) in body\n* project_id(Optional) in body\n\nresponse parameters\n\n* tenant_id in body\n* project_id in body","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":125,"context_line":"   - firewall_policy: firewall_policy"},{"line_number":126,"context_line":"   - name: name"},{"line_number":127,"context_line":"   - firewall_rules: firewall_rules"},{"line_number":128,"context_line":"   - tenant_id: project_id"},{"line_number":129,"context_line":"   - project_id: project_id"},{"line_number":130,"context_line":"   - audited: audited"},{"line_number":131,"context_line":"   - public: shared"},{"line_number":132,"context_line":"   - id: firewall_policy_id_2"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_e8b55a31","line":129,"range":{"start_line":128,"start_character":0,"end_line":129,"end_character":27},"in_reply_to":"9a629dbe_e43af5cc","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Request Example"},{"line_number":160,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_e40cb544","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":43},"updated":"2016-11-08 12:23:09.000000000","message":"firewall_policy_id is not in \u0027body\u0027 but \u0027path\u0027.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Request Example"},{"line_number":160,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_6b5b042f","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":43},"in_reply_to":"9a629dbe_e40cb544","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":174,"context_line":"   - project_id: project_id"},{"line_number":175,"context_line":"   - audited: audited"},{"line_number":176,"context_line":"   - public: shared"},{"line_number":177,"context_line":"   - id: id"},{"line_number":178,"context_line":"   - description: description"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_e713d75a","line":177,"updated":"2016-11-08 12:23:09.000000000","message":"\u0027id\u0027 is still \u0027The UUID of the network.  It should be like \u0027The ID of the policy\u0027.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":174,"context_line":"   - project_id: project_id"},{"line_number":175,"context_line":"   - audited: audited"},{"line_number":176,"context_line":"   - public: shared"},{"line_number":177,"context_line":"   - id: id"},{"line_number":178,"context_line":"   - description: description"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_2b3bcc9d","line":177,"in_reply_to":"9a629dbe_e713d75a","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List firewall policies"},{"line_number":203,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_a7571f01","line":200,"range":{"start_line":200,"start_character":25,"end_line":200,"end_character":43},"updated":"2016-11-08 12:23:09.000000000","message":"firewall_policy_id is not \u0027body\u0027 but \u0027path.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List firewall policies"},{"line_number":203,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_4ba00044","line":200,"range":{"start_line":200,"start_character":25,"end_line":200,"end_character":43},"in_reply_to":"9a629dbe_a7571f01","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":224,"context_line":"   - firewall_rules: firewall_rules"},{"line_number":225,"context_line":"   - tenant_id: project_id"},{"line_number":226,"context_line":"   - project_id: project_id"},{"line_number":227,"context_line":"   - audited: audited"},{"line_number":228,"context_line":"   - firewall_policies: firewall_policies"},{"line_number":229,"context_line":"   - public: shared"},{"line_number":230,"context_line":"   - id: id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_27914f9a","line":227,"range":{"start_line":227,"start_character":14,"end_line":227,"end_character":21},"updated":"2016-11-08 12:23:09.000000000","message":"audited is not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":224,"context_line":"   - firewall_rules: firewall_rules"},{"line_number":225,"context_line":"   - tenant_id: project_id"},{"line_number":226,"context_line":"   - project_id: project_id"},{"line_number":227,"context_line":"   - audited: audited"},{"line_number":228,"context_line":"   - firewall_policies: firewall_policies"},{"line_number":229,"context_line":"   - public: shared"},{"line_number":230,"context_line":"   - id: id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_eb02b40a","line":227,"range":{"start_line":227,"start_character":14,"end_line":227,"end_character":21},"in_reply_to":"9a629dbe_27914f9a","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":226,"context_line":"   - project_id: project_id"},{"line_number":227,"context_line":"   - audited: audited"},{"line_number":228,"context_line":"   - firewall_policies: firewall_policies"},{"line_number":229,"context_line":"   - public: shared"},{"line_number":230,"context_line":"   - id: id"},{"line_number":231,"context_line":"   - description: description"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_a7f39f09","line":229,"range":{"start_line":229,"start_character":5,"end_line":229,"end_character":19},"updated":"2016-11-08 12:23:09.000000000","message":"\u0027public\u0027 is not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":226,"context_line":"   - project_id: project_id"},{"line_number":227,"context_line":"   - audited: audited"},{"line_number":228,"context_line":"   - firewall_policies: firewall_policies"},{"line_number":229,"context_line":"   - public: shared"},{"line_number":230,"context_line":"   - id: id"},{"line_number":231,"context_line":"   - description: description"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_5e243cae","line":229,"range":{"start_line":229,"start_character":5,"end_line":229,"end_character":19},"in_reply_to":"9a629dbe_a7f39f09","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":227,"context_line":"   - audited: audited"},{"line_number":228,"context_line":"   - firewall_policies: firewall_policies"},{"line_number":229,"context_line":"   - public: shared"},{"line_number":230,"context_line":"   - id: id"},{"line_number":231,"context_line":"   - description: description"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_47b72339","line":230,"updated":"2016-11-08 12:23:09.000000000","message":"ditto #177","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":227,"context_line":"   - audited: audited"},{"line_number":228,"context_line":"   - firewall_policies: firewall_policies"},{"line_number":229,"context_line":"   - public: shared"},{"line_number":230,"context_line":"   - id: id"},{"line_number":231,"context_line":"   - description: description"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_0b5fe8e5","line":230,"in_reply_to":"9a629dbe_47b72339","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"   - firewall_rules_id: firewall_rules_id"},{"line_number":254,"context_line":"   - firewall_policy: firewall_policy"},{"line_number":255,"context_line":"   - name: name"},{"line_number":256,"context_line":"   - tenant_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_c7cfb3ae","line":253,"range":{"start_line":253,"start_character":5,"end_line":253,"end_character":22},"updated":"2016-11-08 12:23:09.000000000","message":"firewall_rules","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"   - firewall_rules_id: firewall_rules_id"},{"line_number":254,"context_line":"   - firewall_policy: firewall_policy"},{"line_number":255,"context_line":"   - name: name"},{"line_number":256,"context_line":"   - tenant_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_fe4d1073","line":253,"range":{"start_line":253,"start_character":5,"end_line":253,"end_character":22},"in_reply_to":"9a629dbe_c7cfb3ae","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"   - firewall_rules_id: firewall_rules_id"},{"line_number":254,"context_line":"   - firewall_policy: firewall_policy"},{"line_number":255,"context_line":"   - name: name"},{"line_number":256,"context_line":"   - tenant_id: project_id"},{"line_number":257,"context_line":"   - project_id: project_id"},{"line_number":258,"context_line":"   - public: shared"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_c225e1ab","line":255,"range":{"start_line":255,"start_character":11,"end_line":255,"end_character":15},"updated":"2016-11-08 12:23:09.000000000","message":"\u0027name\u0027 is \u0027Optional\u0027.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"   - firewall_rules_id: firewall_rules_id"},{"line_number":254,"context_line":"   - firewall_policy: firewall_policy"},{"line_number":255,"context_line":"   - name: name"},{"line_number":256,"context_line":"   - tenant_id: project_id"},{"line_number":257,"context_line":"   - project_id: project_id"},{"line_number":258,"context_line":"   - public: shared"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_de5e8c11","line":255,"range":{"start_line":255,"start_character":11,"end_line":255,"end_character":15},"in_reply_to":"9a629dbe_c225e1ab","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":257,"context_line":"   - project_id: project_id"},{"line_number":258,"context_line":"   - public: shared"},{"line_number":259,"context_line":"   - audited: audited"},{"line_number":260,"context_line":"   - description: description"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"Request Example"},{"line_number":263,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_a26e2dc7","line":260,"range":{"start_line":260,"start_character":18,"end_line":260,"end_character":29},"updated":"2016-11-08 12:23:09.000000000","message":"\u0027description\u0027 is \u0027Optional\u0027.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":257,"context_line":"   - project_id: project_id"},{"line_number":258,"context_line":"   - public: shared"},{"line_number":259,"context_line":"   - audited: audited"},{"line_number":260,"context_line":"   - description: description"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"Request Example"},{"line_number":263,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_deff6ca8","line":260,"range":{"start_line":260,"start_character":18,"end_line":260,"end_character":29},"in_reply_to":"9a629dbe_a26e2dc7","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":275,"context_line":"   - firewall_rules: firewall_rules"},{"line_number":276,"context_line":"   - tenant_id: project_id"},{"line_number":277,"context_line":"   - project_id: project_id"},{"line_number":278,"context_line":"   - audited: audited"},{"line_number":279,"context_line":"   - public: shared"},{"line_number":280,"context_line":"   - id: id"},{"line_number":281,"context_line":"   - description: description"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_82876960","line":279,"range":{"start_line":278,"start_character":0,"end_line":279,"end_character":19},"updated":"2016-11-08 12:23:09.000000000","message":"These values are not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":275,"context_line":"   - firewall_rules: firewall_rules"},{"line_number":276,"context_line":"   - tenant_id: project_id"},{"line_number":277,"context_line":"   - project_id: project_id"},{"line_number":278,"context_line":"   - audited: audited"},{"line_number":279,"context_line":"   - public: shared"},{"line_number":280,"context_line":"   - id: id"},{"line_number":281,"context_line":"   - description: description"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_1ebe44d4","line":279,"range":{"start_line":278,"start_character":0,"end_line":279,"end_character":19},"in_reply_to":"9a629dbe_82876960","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":277,"context_line":"   - project_id: project_id"},{"line_number":278,"context_line":"   - audited: audited"},{"line_number":279,"context_line":"   - public: shared"},{"line_number":280,"context_line":"   - id: id"},{"line_number":281,"context_line":"   - description: description"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_e2af45e1","line":280,"updated":"2016-11-08 12:23:09.000000000","message":"ditto #177","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":277,"context_line":"   - project_id: project_id"},{"line_number":278,"context_line":"   - audited: audited"},{"line_number":279,"context_line":"   - public: shared"},{"line_number":280,"context_line":"   - id: id"},{"line_number":281,"context_line":"   - description: description"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_6b5ce4ed","line":280,"in_reply_to":"9a629dbe_e2af45e1","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"   - firewall_rule_id: firewall_rule_id"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"Response Parameters"},{"line_number":312,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_c2f881e8","line":309,"range":{"start_line":309,"start_character":22,"end_line":309,"end_character":39},"updated":"2016-11-08 12:23:09.000000000","message":"\u0027firewall_rule_id\u0027 is not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"   - firewall_rule_id: firewall_rule_id"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"Response Parameters"},{"line_number":312,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_7e55804e","line":309,"range":{"start_line":309,"start_character":22,"end_line":309,"end_character":39},"in_reply_to":"9a629dbe_c2f881e8","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":312,"context_line":"-------------------"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"   - firewall_rule: firewall_rule"},{"line_number":317,"context_line":"   - description: description"},{"line_number":318,"context_line":"   - source_ip_address: source_ip_address"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_0270b971","line":315,"updated":"2016-11-08 12:23:09.000000000","message":"Following values are not \u0027Optional\u0027 but also required:\n\n* enabled\n* protocol\n* source_port\n* ip_version\n* destination_ip_address\n* public\n* action\n* destination_port","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":312,"context_line":"-------------------"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"   - firewall_rule: firewall_rule"},{"line_number":317,"context_line":"   - description: description"},{"line_number":318,"context_line":"   - source_ip_address: source_ip_address"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_bd19d07b","line":315,"in_reply_to":"9a629dbe_0270b971","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":366,"context_line":"   - protocol: protocol"},{"line_number":367,"context_line":"   - destination_port: destination_port"},{"line_number":368,"context_line":"   - name: name"},{"line_number":369,"context_line":"   - firewall_rule_id: firewall_rule_id"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"Request Example"},{"line_number":372,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_02e51908","line":369,"range":{"start_line":369,"start_character":23,"end_line":369,"end_character":39},"updated":"2016-11-08 12:23:09.000000000","message":"\u0027firewall_rule_id\u0027 is not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":366,"context_line":"   - protocol: protocol"},{"line_number":367,"context_line":"   - destination_port: destination_port"},{"line_number":368,"context_line":"   - name: name"},{"line_number":369,"context_line":"   - firewall_rule_id: firewall_rule_id"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"Request Example"},{"line_number":372,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_0eb1a4e1","line":369,"range":{"start_line":369,"start_character":23,"end_line":369,"end_character":39},"in_reply_to":"9a629dbe_02e51908","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":380,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"   - firewall_rule: firewall_rule"},{"line_number":383,"context_line":"   - description: description"},{"line_number":384,"context_line":"   - source_ip_address: source_ip_address"},{"line_number":385,"context_line":"   - tenant_id: project_id"},{"line_number":386,"context_line":"   - project_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_42ab9174","line":383,"range":{"start_line":383,"start_character":5,"end_line":383,"end_character":29},"updated":"2016-11-08 12:23:09.000000000","message":"Optional","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":380,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"   - firewall_rule: firewall_rule"},{"line_number":383,"context_line":"   - description: description"},{"line_number":384,"context_line":"   - source_ip_address: source_ip_address"},{"line_number":385,"context_line":"   - tenant_id: project_id"},{"line_number":386,"context_line":"   - project_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_ee15509b","line":383,"range":{"start_line":383,"start_character":5,"end_line":383,"end_character":29},"in_reply_to":"9a629dbe_42ab9174","updated":"2016-11-08 23:18:37.000000000","message":"I think this is optional in the request but required in the response.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":394,"context_line":"   - action: action"},{"line_number":395,"context_line":"   - position: position"},{"line_number":396,"context_line":"   - destination_port: destination_port"},{"line_number":397,"context_line":"   - id: id"},{"line_number":398,"context_line":"   - name: name"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_c2a40159","line":397,"range":{"start_line":397,"start_character":3,"end_line":397,"end_character":11},"updated":"2016-11-08 12:23:09.000000000","message":"ditto #177","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":394,"context_line":"   - action: action"},{"line_number":395,"context_line":"   - position: position"},{"line_number":396,"context_line":"   - destination_port: destination_port"},{"line_number":397,"context_line":"   - id: id"},{"line_number":398,"context_line":"   - name: name"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_2bd74c24","line":397,"range":{"start_line":397,"start_character":3,"end_line":397,"end_character":11},"in_reply_to":"9a629dbe_c2a40159","updated":"2016-11-08 23:18:37.000000000","message":"I believe this should be the ID of the firewall rule; the firewall_policy_id is a separate parameter in this response.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":395,"context_line":"   - position: position"},{"line_number":396,"context_line":"   - destination_port: destination_port"},{"line_number":397,"context_line":"   - id: id"},{"line_number":398,"context_line":"   - name: name"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"Response Example"},{"line_number":401,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_62ddf513","line":398,"range":{"start_line":398,"start_character":5,"end_line":398,"end_character":15},"updated":"2016-11-08 12:23:09.000000000","message":"Optional","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":395,"context_line":"   - position: position"},{"line_number":396,"context_line":"   - destination_port: destination_port"},{"line_number":397,"context_line":"   - id: id"},{"line_number":398,"context_line":"   - name: name"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"Response Example"},{"line_number":401,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_6e222003","line":398,"range":{"start_line":398,"start_character":5,"end_line":398,"end_character":15},"in_reply_to":"9a629dbe_62ddf513","updated":"2016-11-08 23:18:37.000000000","message":"I believe this is optional in request but required in the response.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"   - firewall_rule_id: firewall_rule_id"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"Show firewall group details"},{"line_number":423,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_82092998","line":420,"range":{"start_line":420,"start_character":23,"end_line":420,"end_character":39},"updated":"2016-11-08 12:23:09.000000000","message":"\u0027firewall_rule_id\u0027 is not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"   - firewall_rule_id: firewall_rule_id"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"Show firewall group details"},{"line_number":423,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_8459155d","line":420,"range":{"start_line":420,"start_character":23,"end_line":420,"end_character":39},"in_reply_to":"9a629dbe_82092998","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"   - firewall_group_id: firewall_group_id"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"Response Parameters"},{"line_number":445,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_821769a2","line":442,"range":{"start_line":442,"start_character":24,"end_line":442,"end_character":41},"updated":"2016-11-08 12:23:09.000000000","message":"\u0027firewall_group_id\u0027 is not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"   - firewall_group_id: firewall_group_id"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"Response Parameters"},{"line_number":445,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_6e694025","line":442,"range":{"start_line":442,"start_character":24,"end_line":442,"end_character":41},"in_reply_to":"9a629dbe_821769a2","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":455,"context_line":"   - project_id: project_id"},{"line_number":456,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":457,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":458,"context_line":"   - id: id"},{"line_number":459,"context_line":"   - name: name"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_6295f5e2","line":458,"range":{"start_line":458,"start_character":0,"end_line":458,"end_character":11},"updated":"2016-11-08 12:23:09.000000000","message":"ditto #177","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":455,"context_line":"   - project_id: project_id"},{"line_number":456,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":457,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":458,"context_line":"   - id: id"},{"line_number":459,"context_line":"   - name: name"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_abca7c6c","line":458,"range":{"start_line":458,"start_character":0,"end_line":458,"end_character":11},"in_reply_to":"9a629dbe_6295f5e2","updated":"2016-11-08 23:18:37.000000000","message":"I believe this is supposed to be the id of the firewall group.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":457,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":458,"context_line":"   - id: id"},{"line_number":459,"context_line":"   - name: name"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Response Example"},{"line_number":462,"context_line":"----------------"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_e202e53d","line":460,"updated":"2016-11-08 12:23:09.000000000","message":"\u0027public\u0027 is missing.  a response body(JSON) is as follows:\n\n{\n    \"firewall_group\": {\n        \"admin_state_up\": true,\n        \"description\": \"\",\n        \"egress_firewall_policy_id\": null,\n        \"id\": \"07411bda-0147-418b-af05-c8665630d937\",\n        \"ingress_firewall_policy_id\": null,\n        \"name\": \"\",\n        \"project_id\": \"96108b04417b416e9b9bc788c11c42c9\",\n        \"public\": false,\n        \"status\": \"INACTIVE\",\n        \"tenant_id\": \"96108b04417b416e9b9bc788c11c42c9\"\n    }\n}","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":457,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":458,"context_line":"   - id: id"},{"line_number":459,"context_line":"   - name: name"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Response Example"},{"line_number":462,"context_line":"----------------"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_4e8abcc0","line":460,"in_reply_to":"9a629dbe_e202e53d","updated":"2016-11-08 23:18:37.000000000","message":"I have added public.  Why don\u0027t ports show up in this response?","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":483,"context_line":""},{"line_number":484,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"   - ports: ports"},{"line_number":487,"context_line":"   - description: description"},{"line_number":488,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":489,"context_line":"   - firewall_group: firewall_group"},{"line_number":490,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":491,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_a2446d74","line":488,"range":{"start_line":486,"start_character":0,"end_line":488,"end_character":35},"updated":"2016-11-08 12:23:09.000000000","message":"These values are \u0027Optional\u0027.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":483,"context_line":""},{"line_number":484,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"   - ports: ports"},{"line_number":487,"context_line":"   - description: description"},{"line_number":488,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":489,"context_line":"   - firewall_group: firewall_group"},{"line_number":490,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":491,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_c9ffa6ff","line":488,"range":{"start_line":486,"start_character":0,"end_line":488,"end_character":35},"in_reply_to":"9a629dbe_a2446d74","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":489,"context_line":"   - firewall_group: firewall_group"},{"line_number":490,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":491,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":492,"context_line":"   - name: name"},{"line_number":493,"context_line":"   - firewall_group_id: firewall_group_id"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"Request Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_025c394a","line":492,"range":{"start_line":492,"start_character":5,"end_line":492,"end_character":15},"updated":"2016-11-08 12:23:09.000000000","message":"Optional","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":489,"context_line":"   - firewall_group: firewall_group"},{"line_number":490,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":491,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":492,"context_line":"   - name: name"},{"line_number":493,"context_line":"   - firewall_group_id: firewall_group_id"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"Request Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_8e821493","line":492,"range":{"start_line":492,"start_character":5,"end_line":492,"end_character":15},"in_reply_to":"9a629dbe_025c394a","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":490,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":491,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":492,"context_line":"   - name: name"},{"line_number":493,"context_line":"   - firewall_group_id: firewall_group_id"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"Request Example"},{"line_number":496,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_e27745d2","line":493,"range":{"start_line":493,"start_character":24,"end_line":493,"end_character":41},"updated":"2016-11-08 12:23:09.000000000","message":"\u0027firewall_group_id\u0027 is not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":490,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":491,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":492,"context_line":"   - name: name"},{"line_number":493,"context_line":"   - firewall_group_id: firewall_group_id"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"Request Example"},{"line_number":496,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_6e7300e8","line":493,"range":{"start_line":493,"start_character":24,"end_line":493,"end_character":41},"in_reply_to":"9a629dbe_e27745d2","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":508,"context_line":"   - description: description"},{"line_number":509,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":510,"context_line":"   - firewall_group: firewall_group"},{"line_number":511,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":512,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":513,"context_line":"   - tenant_id: project_id"},{"line_number":514,"context_line":"   - project_id: project_id"},{"line_number":515,"context_line":"   - firewall_policy_id: firewall_policy_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_a212ad60","line":512,"range":{"start_line":511,"start_character":0,"end_line":512,"end_character":57},"updated":"2016-11-08 12:23:09.000000000","message":"Not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":508,"context_line":"   - description: description"},{"line_number":509,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":510,"context_line":"   - firewall_group: firewall_group"},{"line_number":511,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":512,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":513,"context_line":"   - tenant_id: project_id"},{"line_number":514,"context_line":"   - project_id: project_id"},{"line_number":515,"context_line":"   - firewall_policy_id: firewall_policy_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_e9d38a5d","line":512,"range":{"start_line":511,"start_character":0,"end_line":512,"end_character":57},"in_reply_to":"9a629dbe_a212ad60","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":513,"context_line":"   - tenant_id: project_id"},{"line_number":514,"context_line":"   - project_id: project_id"},{"line_number":515,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":516,"context_line":"   - id: id"},{"line_number":517,"context_line":"   - name: name"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_4256312a","line":516,"range":{"start_line":516,"start_character":2,"end_line":516,"end_character":11},"updated":"2016-11-08 12:23:09.000000000","message":"ditto #177","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":513,"context_line":"   - tenant_id: project_id"},{"line_number":514,"context_line":"   - project_id: project_id"},{"line_number":515,"context_line":"   - firewall_policy_id: firewall_policy_id"},{"line_number":516,"context_line":"   - id: id"},{"line_number":517,"context_line":"   - name: name"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_0b89a826","line":516,"range":{"start_line":516,"start_character":2,"end_line":516,"end_character":11},"in_reply_to":"9a629dbe_4256312a","updated":"2016-11-08 23:18:37.000000000","message":"I believe this is supposed to be the ID of the firewall group.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":536,"context_line":""},{"line_number":537,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"   - firewall_group_id: firewall_group_id"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"List firewall rules"},{"line_number":542,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_9d09882f","line":539,"range":{"start_line":539,"start_character":4,"end_line":539,"end_character":41},"updated":"2016-11-08 12:23:09.000000000","message":"\u0027firewall_group_id\u0027 is not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":536,"context_line":""},{"line_number":537,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"   - firewall_group_id: firewall_group_id"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"List firewall rules"},{"line_number":542,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_a95192da","line":539,"range":{"start_line":539,"start_character":4,"end_line":539,"end_character":41},"in_reply_to":"9a629dbe_9d09882f","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":558,"context_line":"-------------------"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"   - protocol: protocol"},{"line_number":563,"context_line":"   - description: description"},{"line_number":564,"context_line":"   - source_ip_address: source_ip_address"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_3d8ebc78","line":561,"updated":"2016-11-08 12:23:09.000000000","message":"All of response parameter is required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":558,"context_line":"-------------------"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"   - protocol: protocol"},{"line_number":563,"context_line":"   - description: description"},{"line_number":564,"context_line":"   - source_ip_address: source_ip_address"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_696e9a97","line":561,"in_reply_to":"9a629dbe_3d8ebc78","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":565,"context_line":"   - tenant_id: project_id"},{"line_number":566,"context_line":"   - project_id: project_id"},{"line_number":567,"context_line":"   - enabled: enabled"},{"line_number":568,"context_line":"   - id: id"},{"line_number":569,"context_line":"   - ip_version: ip_version"},{"line_number":570,"context_line":"   - destination_ip_address: destination_ip_address"},{"line_number":571,"context_line":"   - firewall_policy_id: firewall_policy_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_5d74509b","line":568,"range":{"start_line":568,"start_character":2,"end_line":568,"end_character":11},"updated":"2016-11-08 12:23:09.000000000","message":"ditto #177","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":565,"context_line":"   - tenant_id: project_id"},{"line_number":566,"context_line":"   - project_id: project_id"},{"line_number":567,"context_line":"   - enabled: enabled"},{"line_number":568,"context_line":"   - id: id"},{"line_number":569,"context_line":"   - ip_version: ip_version"},{"line_number":570,"context_line":"   - destination_ip_address: destination_ip_address"},{"line_number":571,"context_line":"   - firewall_policy_id: firewall_policy_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_eb72b448","line":568,"range":{"start_line":568,"start_character":2,"end_line":568,"end_character":11},"in_reply_to":"9a629dbe_5d74509b","updated":"2016-11-08 23:18:37.000000000","message":"I think this is the ID of the firewall rule.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":596,"context_line":"-------"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"   - firewall_rule: firewall_rule"},{"line_number":601,"context_line":"   - description: description"},{"line_number":602,"context_line":"   - tenant_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_dd20604c","line":599,"updated":"2016-11-08 12:23:09.000000000","message":"Current implementation, all of value except \u0027firewall_rule\u0027 is \u0027Optional\u0027.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":596,"context_line":"-------"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"   - firewall_rule: firewall_rule"},{"line_number":601,"context_line":"   - description: description"},{"line_number":602,"context_line":"   - tenant_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_a9a9927d","line":599,"in_reply_to":"9a629dbe_dd20604c","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":638,"context_line":"   - action: action"},{"line_number":639,"context_line":"   - position: position"},{"line_number":640,"context_line":"   - destination_port: destination_port"},{"line_number":641,"context_line":"   - id: id"},{"line_number":642,"context_line":"   - name: name"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_3d187c1d","line":641,"range":{"start_line":641,"start_character":0,"end_line":641,"end_character":11},"updated":"2016-11-08 12:23:09.000000000","message":"ditto #177","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":638,"context_line":"   - action: action"},{"line_number":639,"context_line":"   - position: position"},{"line_number":640,"context_line":"   - destination_port: destination_port"},{"line_number":641,"context_line":"   - id: id"},{"line_number":642,"context_line":"   - name: name"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_6b9dc458","line":641,"range":{"start_line":641,"start_character":0,"end_line":641,"end_character":11},"in_reply_to":"9a629dbe_3d187c1d","updated":"2016-11-08 23:18:37.000000000","message":"I think this is the ID of the firewall rule.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":667,"context_line":"-------------------"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"   - status: status"},{"line_number":672,"context_line":"   - ports: ports"},{"line_number":673,"context_line":"   - description: description"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_1df3b89f","line":670,"updated":"2016-11-08 12:23:09.000000000","message":"\u0027public\u0027 is missing in response parameters.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":667,"context_line":"-------------------"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"   - status: status"},{"line_number":672,"context_line":"   - ports: ports"},{"line_number":673,"context_line":"   - description: description"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_e9f1ca6b","line":670,"in_reply_to":"9a629dbe_1df3b89f","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":674,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":675,"context_line":"   - tenant_id: project_id"},{"line_number":676,"context_line":"   - project_id: project_id"},{"line_number":677,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":678,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":679,"context_line":"   - firewall_groups: firewall_groups"},{"line_number":680,"context_line":"   - id: id"},{"line_number":681,"context_line":"   - name: name"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_3dc23c34","line":678,"range":{"start_line":677,"start_character":3,"end_line":678,"end_character":57},"updated":"2016-11-08 12:23:09.000000000","message":"Not \u0027Optional\u0027 in \u0027path\u0027 but required in \u0027body\u0027.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":674,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":675,"context_line":"   - tenant_id: project_id"},{"line_number":676,"context_line":"   - project_id: project_id"},{"line_number":677,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":678,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":679,"context_line":"   - firewall_groups: firewall_groups"},{"line_number":680,"context_line":"   - id: id"},{"line_number":681,"context_line":"   - name: name"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_c9eec68a","line":678,"range":{"start_line":677,"start_character":3,"end_line":678,"end_character":57},"in_reply_to":"9a629dbe_3dc23c34","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":677,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":678,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":679,"context_line":"   - firewall_groups: firewall_groups"},{"line_number":680,"context_line":"   - id: id"},{"line_number":681,"context_line":"   - name: name"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_dde78010","line":680,"range":{"start_line":680,"start_character":3,"end_line":680,"end_character":11},"updated":"2016-11-08 12:23:09.000000000","message":"ditto #177","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":677,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":678,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":679,"context_line":"   - firewall_groups: firewall_groups"},{"line_number":680,"context_line":"   - id: id"},{"line_number":681,"context_line":"   - name: name"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_eba9d47c","line":680,"range":{"start_line":680,"start_character":3,"end_line":680,"end_character":11},"in_reply_to":"9a629dbe_dde78010","updated":"2016-11-08 23:18:37.000000000","message":"I believe this should be the ID for the firewall group.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":705,"context_line":"-------"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"   - firewall_group: firewall_group"},{"line_number":710,"context_line":"   - ports: ports_2"},{"line_number":711,"context_line":"   - description: description_20"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_d84b0e2a","line":708,"updated":"2016-11-08 12:23:09.000000000","message":"\u0027public\u0027 is missing at request/response parameter.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":705,"context_line":"-------"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"   - firewall_group: firewall_group"},{"line_number":710,"context_line":"   - ports: ports_2"},{"line_number":711,"context_line":"   - description: description_20"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_44145d43","line":708,"in_reply_to":"9a629dbe_d84b0e2a","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":710,"context_line":"   - ports: ports_2"},{"line_number":711,"context_line":"   - description: description_20"},{"line_number":712,"context_line":"   - admin_state_up: admin_state_up_27"},{"line_number":713,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":714,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":715,"context_line":"   - name: name_44"},{"line_number":716,"context_line":"   - tenant_id: project_id"},{"line_number":717,"context_line":"   - project_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_186d8698","line":714,"range":{"start_line":713,"start_character":0,"end_line":714,"end_character":57},"updated":"2016-11-08 12:23:09.000000000","message":"These values are not in \u0027path\u0027 but \u0027body\u0027.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":710,"context_line":"   - ports: ports_2"},{"line_number":711,"context_line":"   - description: description_20"},{"line_number":712,"context_line":"   - admin_state_up: admin_state_up_27"},{"line_number":713,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":714,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":715,"context_line":"   - name: name_44"},{"line_number":716,"context_line":"   - tenant_id: project_id"},{"line_number":717,"context_line":"   - project_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_843595db","line":714,"range":{"start_line":713,"start_character":0,"end_line":714,"end_character":57},"in_reply_to":"9a629dbe_186d8698","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":712,"context_line":"   - admin_state_up: admin_state_up_27"},{"line_number":713,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":714,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":715,"context_line":"   - name: name_44"},{"line_number":716,"context_line":"   - tenant_id: project_id"},{"line_number":717,"context_line":"   - project_id: project_id"},{"line_number":718,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_f81d3210","line":715,"range":{"start_line":715,"start_character":4,"end_line":715,"end_character":18},"updated":"2016-11-08 12:23:09.000000000","message":"\u0027name\u0027 is not required but \u0027Optional\u0027.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":712,"context_line":"   - admin_state_up: admin_state_up_27"},{"line_number":713,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":714,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":715,"context_line":"   - name: name_44"},{"line_number":716,"context_line":"   - tenant_id: project_id"},{"line_number":717,"context_line":"   - project_id: project_id"},{"line_number":718,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_6436c1e8","line":715,"range":{"start_line":715,"start_character":4,"end_line":715,"end_character":18},"in_reply_to":"9a629dbe_f81d3210","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":731,"context_line":"   - ports: ports"},{"line_number":732,"context_line":"   - description: description"},{"line_number":733,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":734,"context_line":"   - firewall: firewall"},{"line_number":735,"context_line":"   - tenant_id: project_id"},{"line_number":736,"context_line":"   - project_id: project_id"},{"line_number":737,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_788da230","line":734,"range":{"start_line":734,"start_character":5,"end_line":734,"end_character":23},"updated":"2016-11-08 12:23:09.000000000","message":"firewall_group: firewall_group","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":731,"context_line":"   - ports: ports"},{"line_number":732,"context_line":"   - description: description"},{"line_number":733,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":734,"context_line":"   - firewall: firewall"},{"line_number":735,"context_line":"   - tenant_id: project_id"},{"line_number":736,"context_line":"   - project_id: project_id"},{"line_number":737,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_04f425f0","line":734,"range":{"start_line":734,"start_character":5,"end_line":734,"end_character":23},"in_reply_to":"9a629dbe_788da230","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"af054f4b7e98f1af4d8fd79625ef3897a84dcb01","unresolved":false,"context_lines":[{"line_number":734,"context_line":"   - firewall: firewall"},{"line_number":735,"context_line":"   - tenant_id: project_id"},{"line_number":736,"context_line":"   - project_id: project_id"},{"line_number":737,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":738,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":739,"context_line":"   - id: id"},{"line_number":740,"context_line":"   - name: name"},{"line_number":741,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_18f2e6d2","line":738,"range":{"start_line":737,"start_character":0,"end_line":738,"end_character":57},"updated":"2016-11-08 12:23:09.000000000","message":"These values are not \u0027Optional\u0027 but required.","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"052f2a334d669c1290c1175679e5f634f9dec727","unresolved":false,"context_lines":[{"line_number":734,"context_line":"   - firewall: firewall"},{"line_number":735,"context_line":"   - tenant_id: project_id"},{"line_number":736,"context_line":"   - project_id: project_id"},{"line_number":737,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id"},{"line_number":738,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id"},{"line_number":739,"context_line":"   - id: id"},{"line_number":740,"context_line":"   - name: name"},{"line_number":741,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9a629dbe_44de1d6e","line":738,"range":{"start_line":737,"start_character":0,"end_line":738,"end_character":57},"in_reply_to":"9a629dbe_18f2e6d2","updated":"2016-11-08 23:18:37.000000000","message":"Done","commit_id":"822e2987986600c88f6440066d77b5b96a371745"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e7d3134f10469d58433a542df7488633f7718861","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This extension introduces the following resources:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- ``firewall group``. A logical firewall resource that a project can"},{"line_number":29,"context_line":"  create and manage. A firewall group can have two firewall policies,"},{"line_number":30,"context_line":"  one for ingress traffic and the other for egress traffic."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_b880bef8","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":18},"updated":"2016-11-10 08:51:54.000000000","message":"How about aligning \u0027firewall_group\u0027 (adding under score)?\nfirewall_group is used in body as follows:\n\n{\"firewall_group\": {  \"name\": \"aaaa\"}}","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This extension introduces the following resources:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- ``firewall group``. A logical firewall resource that a project can"},{"line_number":29,"context_line":"  create and manage. A firewall group can have two firewall policies,"},{"line_number":30,"context_line":"  one for ingress traffic and the other for egress traffic."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_f23793fc","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":18},"in_reply_to":"9a629dbe_b880bef8","updated":"2016-11-10 18:57:01.000000000","message":"I\u0027ve added the underscore, but am not sure what else needs to be done.  Can you clarify?","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"203b90deab7d1f86dd0e8829c9ec653f01b5cf00","unresolved":false,"context_lines":[{"line_number":140,"context_line":"If ``admin_state_up`` is ``false``, the firewall group would block all"},{"line_number":141,"context_line":"traffic."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Error response codes: 201,401,400"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Request"},{"line_number":146,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_1f3359f7","line":143,"range":{"start_line":143,"start_character":22,"end_line":143,"end_character":25},"updated":"2016-11-09 23:15:57.000000000","message":"201 Created would be a Normal response code, not error, right?","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e7d3134f10469d58433a542df7488633f7718861","unresolved":false,"context_lines":[{"line_number":140,"context_line":"If ``admin_state_up`` is ``false``, the firewall group would block all"},{"line_number":141,"context_line":"traffic."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Error response codes: 201,401,400"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Request"},{"line_number":146,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_38f02ec9","line":143,"range":{"start_line":143,"start_character":22,"end_line":143,"end_character":25},"in_reply_to":"9a629dbe_1f3359f7","updated":"2016-11-10 08:51:54.000000000","message":"Right.  2xx is normal response code.","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":140,"context_line":"If ``admin_state_up`` is ``false``, the firewall group would block all"},{"line_number":141,"context_line":"traffic."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Error response codes: 201,401,400"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Request"},{"line_number":146,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_4d15023e","line":143,"range":{"start_line":143,"start_character":22,"end_line":143,"end_character":25},"in_reply_to":"9a629dbe_38f02ec9","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"203b90deab7d1f86dd0e8829c9ec653f01b5cf00","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Deletes a firewall group."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"Error response codes: 409,404,204,401"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Request"},{"line_number":261,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_ff406536","line":258,"range":{"start_line":258,"start_character":30,"end_line":258,"end_character":33},"updated":"2016-11-09 23:15:57.000000000","message":"204 would be a Normal response code, right?","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Deletes a firewall group."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"Error response codes: 409,404,204,401"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Request"},{"line_number":261,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_23a29f4b","line":258,"range":{"start_line":258,"start_character":30,"end_line":258,"end_character":33},"in_reply_to":"9a629dbe_ff406536","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"203b90deab7d1f86dd0e8829c9ec653f01b5cf00","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"Creates a firewall policy."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"Error response codes: 201,401,400"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"Request"},{"line_number":352,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_bf718daa","line":349,"range":{"start_line":349,"start_character":22,"end_line":349,"end_character":25},"updated":"2016-11-09 23:15:57.000000000","message":"201 is Normal, not Error","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"Creates a firewall policy."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"Error response codes: 201,401,400"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"Request"},{"line_number":352,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_43b23395","line":349,"range":{"start_line":349,"start_character":22,"end_line":349,"end_character":25},"in_reply_to":"9a629dbe_bf718daa","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"203b90deab7d1f86dd0e8829c9ec653f01b5cf00","unresolved":false,"context_lines":[{"line_number":449,"context_line":""},{"line_number":450,"context_line":"Deletes a firewall policy."},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"Error response codes: 409,404,204,401"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"Request"},{"line_number":455,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_ff6785e6","line":452,"range":{"start_line":452,"start_character":30,"end_line":452,"end_character":33},"updated":"2016-11-09 23:15:57.000000000","message":"204 is Normal, not Error","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":449,"context_line":""},{"line_number":450,"context_line":"Deletes a firewall policy."},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"Error response codes: 409,404,204,401"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"Request"},{"line_number":455,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_6f2c7999","line":452,"range":{"start_line":452,"start_character":30,"end_line":452,"end_character":33},"in_reply_to":"9a629dbe_ff6785e6","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"203b90deab7d1f86dd0e8829c9ec653f01b5cf00","unresolved":false,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"Creates a firewall rule."},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"Error response codes: 201,401,400"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"Request"},{"line_number":567,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_1f6199d3","line":564,"range":{"start_line":564,"start_character":22,"end_line":564,"end_character":25},"updated":"2016-11-09 23:15:57.000000000","message":"201 is Normal","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"Creates a firewall rule."},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"Error response codes: 201,401,400"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"Request"},{"line_number":567,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_ef3889d5","line":564,"range":{"start_line":564,"start_character":22,"end_line":564,"end_character":25},"in_reply_to":"9a629dbe_1f6199d3","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":6995,"name":"Sridar Kandaswamy","email":"skandasw@yahoo.com","username":"skandasw"},"change_message_id":"96c9171d4b4752c6dfe8e6c2eb9d2529bccb5380","unresolved":false,"context_lines":[{"line_number":673,"context_line":"   - id: firewall_rule_id_body_required"},{"line_number":674,"context_line":"   - ip_version: firewall_rule_ip_version_body_required"},{"line_number":675,"context_line":"   - name: firewall_rule_name_body_required"},{"line_number":676,"context_line":"   - position: firewall_rule_position_body_required"},{"line_number":677,"context_line":"   - project_id: project_id_body_required"},{"line_number":678,"context_line":"   - protocol: firewall_rule_protocol_body_required"},{"line_number":679,"context_line":"   - public: firewall_rule_shared_body_required"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_ad677eb5","line":676,"updated":"2016-11-10 17:11:03.000000000","message":"no position.","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":673,"context_line":"   - id: firewall_rule_id_body_required"},{"line_number":674,"context_line":"   - ip_version: firewall_rule_ip_version_body_required"},{"line_number":675,"context_line":"   - name: firewall_rule_name_body_required"},{"line_number":676,"context_line":"   - position: firewall_rule_position_body_required"},{"line_number":677,"context_line":"   - project_id: project_id_body_required"},{"line_number":678,"context_line":"   - protocol: firewall_rule_protocol_body_required"},{"line_number":679,"context_line":"   - public: firewall_rule_shared_body_required"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_af469178","line":676,"in_reply_to":"9a629dbe_ad677eb5","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"203b90deab7d1f86dd0e8829c9ec653f01b5cf00","unresolved":false,"context_lines":[{"line_number":693,"context_line":".. rest_method::  DELETE /v2.0/fwaas/firewall_rules/{firewall_rule_id}"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"Deletes a firewall rule."},{"line_number":696,"context_line":"samples/firewall-v2/firewall-policy-create-response.json"},{"line_number":697,"context_line":"Error response codes: 409,404,204,401"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_e2228e51","line":696,"updated":"2016-11-09 23:15:57.000000000","message":"Insert a blank line between 696 and 697 to render correctly.","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":693,"context_line":".. rest_method::  DELETE /v2.0/fwaas/firewall_rules/{firewall_rule_id}"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"Deletes a firewall rule."},{"line_number":696,"context_line":"samples/firewall-v2/firewall-policy-create-response.json"},{"line_number":697,"context_line":"Error response codes: 409,404,204,401"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_6f7ab989","line":696,"in_reply_to":"9a629dbe_e2228e51","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"203b90deab7d1f86dd0e8829c9ec653f01b5cf00","unresolved":false,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":"Deletes a firewall rule."},{"line_number":696,"context_line":"samples/firewall-v2/firewall-policy-create-response.json"},{"line_number":697,"context_line":"Error response codes: 409,404,204,401"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"Request"},{"line_number":700,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_820c72ee","line":697,"range":{"start_line":697,"start_character":30,"end_line":697,"end_character":33},"updated":"2016-11-09 23:15:57.000000000","message":"204 is Normal, not Error","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":"Deletes a firewall rule."},{"line_number":696,"context_line":"samples/firewall-v2/firewall-policy-create-response.json"},{"line_number":697,"context_line":"Error response codes: 409,404,204,401"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"Request"},{"line_number":700,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"9a629dbe_af7051a5","line":697,"range":{"start_line":697,"start_character":30,"end_line":697,"end_character":33},"in_reply_to":"9a629dbe_820c72ee","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09a525ed723c2c609b09c21ed11edbf0633c20c7","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"Deletes a firewall group."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Error response codes: 204"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"Error response codes: 409,404,401"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9a629dbe_72661e52","line":260,"range":{"start_line":260,"start_character":0,"end_line":260,"end_character":5},"updated":"2016-11-10 19:12:54.000000000","message":"Error -\u003e Normal","commit_id":"1928cc45482e84871822864a614f63a8438b7a71"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09a525ed723c2c609b09c21ed11edbf0633c20c7","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"Creates a firewall policy."},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"Error response codes: 201"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"Error response codes: 401,400"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9a629dbe_d257ea55","line":353,"range":{"start_line":353,"start_character":0,"end_line":353,"end_character":5},"updated":"2016-11-10 19:12:54.000000000","message":"Error -\u003e Normal","commit_id":"1928cc45482e84871822864a614f63a8438b7a71"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"02f3c5b78e99e261a4b4231caf0e1a72e4536270","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"Creates a firewall policy."},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"Error response codes: 201"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"Error response codes: 401,400"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9a629dbe_9808312a","line":353,"range":{"start_line":353,"start_character":0,"end_line":353,"end_character":5},"in_reply_to":"9a629dbe_d257ea55","updated":"2016-11-10 19:56:00.000000000","message":"Done","commit_id":"1928cc45482e84871822864a614f63a8438b7a71"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09a525ed723c2c609b09c21ed11edbf0633c20c7","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"Deletes a firewall policy."},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"Error response codes: 204"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"Error response codes: 409,404,401"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9a629dbe_124ec2c0","line":458,"range":{"start_line":458,"start_character":0,"end_line":458,"end_character":5},"updated":"2016-11-10 19:12:54.000000000","message":"Error -\u003e Normal","commit_id":"1928cc45482e84871822864a614f63a8438b7a71"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"02f3c5b78e99e261a4b4231caf0e1a72e4536270","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"Deletes a firewall policy."},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"Error response codes: 204"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"Error response codes: 409,404,401"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9a629dbe_181d0166","line":458,"range":{"start_line":458,"start_character":0,"end_line":458,"end_character":5},"in_reply_to":"9a629dbe_124ec2c0","updated":"2016-11-10 19:56:00.000000000","message":"Done","commit_id":"1928cc45482e84871822864a614f63a8438b7a71"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09a525ed723c2c609b09c21ed11edbf0633c20c7","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"Creates a firewall rule."},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"Error response codes: 201"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"Error response codes: 401,400"},{"line_number":575,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9a629dbe_324906b8","line":572,"range":{"start_line":572,"start_character":0,"end_line":572,"end_character":5},"updated":"2016-11-10 19:12:54.000000000","message":"Error -\u003e Normal","commit_id":"1928cc45482e84871822864a614f63a8438b7a71"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"02f3c5b78e99e261a4b4231caf0e1a72e4536270","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"Creates a firewall rule."},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"Error response codes: 201"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"Error response codes: 401,400"},{"line_number":575,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9a629dbe_b82255a1","line":572,"range":{"start_line":572,"start_character":0,"end_line":572,"end_character":5},"in_reply_to":"9a629dbe_324906b8","updated":"2016-11-10 19:56:00.000000000","message":"Done","commit_id":"1928cc45482e84871822864a614f63a8438b7a71"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09a525ed723c2c609b09c21ed11edbf0633c20c7","unresolved":false,"context_lines":[{"line_number":704,"context_line":"Deletes a firewall rule."},{"line_number":705,"context_line":"samples/firewall-v2/firewall-policy-create-response.json"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"Error response codes: 204"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"Error response codes: 409,404,401"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9a629dbe_92d012cb","line":707,"range":{"start_line":707,"start_character":0,"end_line":707,"end_character":5},"updated":"2016-11-10 19:12:54.000000000","message":"Error -\u003e Normal","commit_id":"1928cc45482e84871822864a614f63a8438b7a71"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"02f3c5b78e99e261a4b4231caf0e1a72e4536270","unresolved":false,"context_lines":[{"line_number":704,"context_line":"Deletes a firewall rule."},{"line_number":705,"context_line":"samples/firewall-v2/firewall-policy-create-response.json"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"Error response codes: 204"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"Error response codes: 409,404,401"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9a629dbe_d844694b","line":707,"range":{"start_line":707,"start_character":0,"end_line":707,"end_character":5},"in_reply_to":"9a629dbe_92d012cb","updated":"2016-11-10 19:56:00.000000000","message":"Done","commit_id":"1928cc45482e84871822864a614f63a8438b7a71"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3ceab1ef4f849d8225a3ccf960421057fd24c5cc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"This extension introduces the following resources:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- ``firewall_group``. A logical firewall resource that a project can"},{"line_number":29,"context_line":"  create and manage. A firewall group can have two firewall policies,"},{"line_number":30,"context_line":"  one for ingress traffic and the other for egress traffic."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- ``firewall_policy``. An ordered collection of firewall rules. You"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_95d5211d","line":29,"updated":"2016-11-12 18:15:04.000000000","message":"Is it limited to 2 ?\nIf so, can we right \" a maximum of 2 Firewall policies\" ?? to avoid any discrepancy?\nIf not,","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d38f1188c8c725acc31d25ec743d9d52ff13081d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"This extension introduces the following resources:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- ``firewall_group``. A logical firewall resource that a project can"},{"line_number":29,"context_line":"  create and manage. A firewall group can have two firewall policies,"},{"line_number":30,"context_line":"  one for ingress traffic and the other for egress traffic."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- ``firewall_policy``. An ordered collection of firewall rules. You"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_ab79e694","line":29,"in_reply_to":"9a629dbe_506b9784","updated":"2016-11-13 00:07:43.000000000","message":"I\u0027ve tried to disambiguate.  See what you think.","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":6995,"name":"Sridar Kandaswamy","email":"skandasw@yahoo.com","username":"skandasw"},"change_message_id":"c55c43ecaee9f37209754aadbb3488a8c4146a8a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"This extension introduces the following resources:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- ``firewall_group``. A logical firewall resource that a project can"},{"line_number":29,"context_line":"  create and manage. A firewall group can have two firewall policies,"},{"line_number":30,"context_line":"  one for ingress traffic and the other for egress traffic."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- ``firewall_policy``. An ordered collection of firewall rules. You"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_506b9784","line":29,"in_reply_to":"9a629dbe_95d5211d","updated":"2016-11-12 20:59:42.000000000","message":"It seems to me that \"can have two firewall policies, on for ingress ... \" seems to be unambiguous enough. To split hairs, it is either none or one for ingress and none or one for egress. Max of 2 may not be the most apt description IMHO.","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5cd76cd70613dfd64add1146fb4e9f425df5ca29","unresolved":false,"context_lines":[{"line_number":26,"context_line":"This extension introduces the following resources:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- ``firewall_group``. A logical firewall resource that a project can"},{"line_number":29,"context_line":"  create and manage. A firewall group can have two firewall policies,"},{"line_number":30,"context_line":"  one for ingress traffic and the other for egress traffic."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- ``firewall_policy``. An ordered collection of firewall rules. You"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_0b7ad2bc","line":29,"in_reply_to":"9a629dbe_ab79e694","updated":"2016-11-13 03:19:06.000000000","message":"It would be great if we can write what Sridar mentioned , in any future version , if required :\n\n Firewall Groups can be associated to One Ingress and One  Egress Firewall Policy","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3ceab1ef4f849d8225a3ccf960421057fd24c5cc","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- ``firewall_policy``. An ordered collection of firewall rules. You"},{"line_number":33,"context_line":"  can share a firewall policy across projects. You can include a"},{"line_number":34,"context_line":"  firewall policy as part of an audit workflow so that an"},{"line_number":35,"context_line":"  authorized relevant entity can audit the firewall policy. This"},{"line_number":36,"context_line":"  entity can differ from the user who created, or the projects"},{"line_number":37,"context_line":"  that use, the firewall policy."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_15eaf1da","line":34,"updated":"2016-11-12 18:15:04.000000000","message":"Is the workflow, kind of a group ?\nI mean , is it a collection of policies like the firewall_group defined above?\n\nIf yes, can we mention the same here?","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":6995,"name":"Sridar Kandaswamy","email":"skandasw@yahoo.com","username":"skandasw"},"change_message_id":"c55c43ecaee9f37209754aadbb3488a8c4146a8a","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- ``firewall_policy``. An ordered collection of firewall rules. You"},{"line_number":33,"context_line":"  can share a firewall policy across projects. You can include a"},{"line_number":34,"context_line":"  firewall policy as part of an audit workflow so that an"},{"line_number":35,"context_line":"  authorized relevant entity can audit the firewall policy. This"},{"line_number":36,"context_line":"  entity can differ from the user who created, or the projects"},{"line_number":37,"context_line":"  that use, the firewall policy."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_b00a33d0","line":34,"in_reply_to":"9a629dbe_15eaf1da","updated":"2016-11-12 20:59:42.000000000","message":"I believe the intent here by \"workflow\" is just to refer to what procedures are followed by the organization if they want to set the audit flag or not. So this reads fine to me.","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5cd76cd70613dfd64add1146fb4e9f425df5ca29","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- ``firewall_policy``. An ordered collection of firewall rules. You"},{"line_number":33,"context_line":"  can share a firewall policy across projects. You can include a"},{"line_number":34,"context_line":"  firewall policy as part of an audit workflow so that an"},{"line_number":35,"context_line":"  authorized relevant entity can audit the firewall policy. This"},{"line_number":36,"context_line":"  entity can differ from the user who created, or the projects"},{"line_number":37,"context_line":"  that use, the firewall policy."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_8b4c229f","line":34,"in_reply_to":"9a629dbe_8b9d02be","updated":"2016-11-13 03:19:06.000000000","message":"Well maybe I am too microscopic in my view ( Looking at the documentation through a Keyhole ) , but what I wanted to convey was:\n\"It is mentioned here that the firewall policy is a part of an Audit Workflow. Now, typically , firewall policies would be a part of a firewall group. So in my understanding, it seems that the workflow is basically a Firewall Group which can be audited as and when required by an authorized entity.\"\n\nAgain, this is not an important thing...","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d38f1188c8c725acc31d25ec743d9d52ff13081d","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- ``firewall_policy``. An ordered collection of firewall rules. You"},{"line_number":33,"context_line":"  can share a firewall policy across projects. You can include a"},{"line_number":34,"context_line":"  firewall policy as part of an audit workflow so that an"},{"line_number":35,"context_line":"  authorized relevant entity can audit the firewall policy. This"},{"line_number":36,"context_line":"  entity can differ from the user who created, or the projects"},{"line_number":37,"context_line":"  that use, the firewall policy."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_8b9d02be","line":34,"in_reply_to":"9a629dbe_b00a33d0","updated":"2016-11-13 00:07:43.000000000","message":"I agree with Sridar and will leave this as is, but Reedip please let me know if you disagree still.","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3ceab1ef4f849d8225a3ccf960421057fd24c5cc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"- ``firewall_rule``. A collection of attributes, such as source and"},{"line_number":40,"context_line":"  destination ports, source and destination IP addresses, protocol,"},{"line_number":41,"context_line":"  and IP version. These attributes define match criteria and an"},{"line_number":42,"context_line":"  action to take, such as allow or deny, on matched data traffic."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"List firewall groups"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_35cc5588","line":42,"updated":"2016-11-12 18:15:04.000000000","message":"Allow, Reject or Deny","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d38f1188c8c725acc31d25ec743d9d52ff13081d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"- ``firewall_rule``. A collection of attributes, such as source and"},{"line_number":40,"context_line":"  destination ports, source and destination IP addresses, protocol,"},{"line_number":41,"context_line":"  and IP version. These attributes define match criteria and an"},{"line_number":42,"context_line":"  action to take, such as allow or deny, on matched data traffic."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"List firewall groups"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_aba006f5","line":42,"in_reply_to":"9a629dbe_35cc5588","updated":"2016-11-13 00:07:43.000000000","message":"Done","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3ceab1ef4f849d8225a3ccf960421057fd24c5cc","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Creates a firewall group."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"The firewall group must be associated with an ingress firewall policy"},{"line_number":138,"context_line":"group and an egress firewall policy group."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"If ``admin_state_up`` is ``false``, the firewall group would block all"},{"line_number":141,"context_line":"traffic."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_3593755c","line":138,"updated":"2016-11-12 18:15:04.000000000","message":"Should it be firewall policy group or firewall policy id?\n\nAlso, it is optional, so MUST can be replaced with SHOULD in line#137","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d38f1188c8c725acc31d25ec743d9d52ff13081d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Creates a firewall group."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"The firewall group must be associated with an ingress firewall policy"},{"line_number":138,"context_line":"group and an egress firewall policy group."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"If ``admin_state_up`` is ``false``, the firewall group would block all"},{"line_number":141,"context_line":"traffic."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a629dbe_cba37afe","line":138,"in_reply_to":"9a629dbe_3593755c","updated":"2016-11-13 00:07:43.000000000","message":"I\u0027ve fixed per your suggestions.  Thank you for your close reading.","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":".. needs:method_verification"},{"line_number":3,"context_line":".. needs:parameter_verification"},{"line_number":4,"context_line":".. needs:example_verification"},{"line_number":5,"context_line":".. needs:body_verification"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"FWaaS v2.0 (CURRENT) (fwaas, firewall_groups, firewall_policies, firewall_rules)"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_871763a2","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":26},"updated":"2016-12-22 21:25:15.000000000","message":"Remove the lines from (2-5) if the corresponding verifications are done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":".. needs:method_verification"},{"line_number":3,"context_line":".. needs:parameter_verification"},{"line_number":4,"context_line":".. needs:example_verification"},{"line_number":5,"context_line":".. needs:body_verification"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"FWaaS v2.0 (CURRENT) (fwaas, firewall_groups, firewall_policies, firewall_rules)"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_625e8913","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":26},"in_reply_to":"da4df55a_871763a2","updated":"2016-12-27 13:58:43.000000000","message":"Done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Lists all firewall groups."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"The list might be empty."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Normal response codes: 200"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Error response codes: 403,401"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_67799ffc","line":53,"updated":"2016-12-22 21:25:15.000000000","message":"Please add the description for fields as mentioned in [1].\n\n\n[1]https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L24-L28","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Lists all firewall groups."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"The list might be empty."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Normal response codes: 200"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Error response codes: 403,401"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_e27fd963","line":53,"in_reply_to":"da4df55a_67799ffc","updated":"2016-12-27 13:58:43.000000000","message":"Done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"44f116c2e6a72b9d3c5d11f4eeb22344010b722d","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Normal response codes: 200"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Error response codes: 403,401"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Request"},{"line_number":59,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"1a6eadb0_6d7e5db0","line":56,"range":{"start_line":56,"start_character":22,"end_line":56,"end_character":29},"updated":"2016-12-21 16:35:55.000000000","message":"Nit (for later): spaces after commas.","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Normal response codes: 200"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Error response codes: 403,401"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Request"},{"line_number":59,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_22964193","line":56,"range":{"start_line":56,"start_character":22,"end_line":56,"end_character":29},"in_reply_to":"1a6eadb0_6d7e5db0","updated":"2016-12-27 13:58:43.000000000","message":"Done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Request"},{"line_number":59,"context_line":"-------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Response Parameters"},{"line_number":62,"context_line":"-------------------"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_c7888bea","line":60,"updated":"2016-12-22 21:25:15.000000000","message":"Please add fields as the request parameter as in [1].\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L37-L39","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Request"},{"line_number":59,"context_line":"-------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Response Parameters"},{"line_number":62,"context_line":"-------------------"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_62684988","line":60,"in_reply_to":"da4df55a_c7888bea","updated":"2016-12-27 13:58:43.000000000","message":"Done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":268,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"   - firewall_group_id: firewall_group_id_path_required"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"List firewall policies"},{"line_number":273,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_6760bf36","line":271,"updated":"2016-12-22 21:25:15.000000000","message":"Can you please add a Response section as in [1]?\n\n[1] https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#L292-L295","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":268,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"   - firewall_group_id: firewall_group_id_path_required"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"List firewall policies"},{"line_number":273,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_02fcddb6","line":271,"in_reply_to":"da4df55a_6760bf36","updated":"2016-12-27 13:58:43.000000000","message":"Done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":277,"context_line":"Lists all firewall policies."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"The list might be empty."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Normal response codes: 200"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"Error response codes: 403,401"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_474c9bc7","line":280,"updated":"2016-12-22 21:25:15.000000000","message":"Same as line 53","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":277,"context_line":"Lists all firewall policies."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"The list might be empty."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Normal response codes: 200"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"Error response codes: 403,401"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_22f9e1c7","line":280,"in_reply_to":"da4df55a_474c9bc7","updated":"2016-12-27 13:58:43.000000000","message":"Done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Request"},{"line_number":286,"context_line":"-------"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"Response Parameters"},{"line_number":289,"context_line":"-------------------"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_a7d1c7cf","line":287,"updated":"2016-12-22 21:25:15.000000000","message":"Same as line 60","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Request"},{"line_number":286,"context_line":"-------"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"Response Parameters"},{"line_number":289,"context_line":"-------------------"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_822e0d41","line":287,"in_reply_to":"da4df55a_a7d1c7cf","updated":"2016-12-27 13:58:43.000000000","message":"Done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":466,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"   - firewall_policy_id: firewall_policy_id_path_required"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"List firewall rules"},{"line_number":471,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_27e6b7b4","line":469,"updated":"2016-12-22 21:25:15.000000000","message":"same as line 271","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":466,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"   - firewall_policy_id: firewall_policy_id_path_required"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"List firewall rules"},{"line_number":471,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_c2dbb54d","line":469,"in_reply_to":"da4df55a_27e6b7b4","updated":"2016-12-27 13:58:43.000000000","message":"Done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":475,"context_line":"Lists all firewall rules."},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"The list might be empty."},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"Normal response codes: 200"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"Error response codes: 403,401"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_e702ef3d","line":478,"updated":"2016-12-22 21:25:15.000000000","message":"same as line 53","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":475,"context_line":"Lists all firewall rules."},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"The list might be empty."},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"Normal response codes: 200"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"Error response codes: 403,401"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_22e72112","line":478,"in_reply_to":"da4df55a_e702ef3d","updated":"2016-12-27 13:58:43.000000000","message":"Done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"Request"},{"line_number":484,"context_line":"-------"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"Response Parameters"},{"line_number":487,"context_line":"-------------------"},{"line_number":488,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_0700d333","line":485,"updated":"2016-12-22 21:25:15.000000000","message":"same as line 60","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"Request"},{"line_number":484,"context_line":"-------"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"Response Parameters"},{"line_number":487,"context_line":"-------------------"},{"line_number":488,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"da4df55a_82bc4ddd","line":485,"in_reply_to":"da4df55a_0700d333","updated":"2016-12-27 13:58:43.000000000","message":"Done","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"69cee258135af4c927c273b661657673c98ce418","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"ba5201f7_4c685bf6","updated":"2016-12-30 18:45:40.000000000","message":"nit: It looks like (with one exception) the error response codes are listed in descending numerical order. That seems a bit odd to me, I would be inclined to list them in ascending order. Of course it doesn\u0027t really matter one way or the other.","commit_id":"101ad36e3c208963b805f200eb2262a81b65610b"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"a38d1bab933cab0b73ece4c0b07da9ac127030b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"ba5201f7_3a8c53d9","in_reply_to":"ba5201f7_4c685bf6","updated":"2017-01-08 17:44:55.000000000","message":"Thank you.  I will fix.","commit_id":"101ad36e3c208963b805f200eb2262a81b65610b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"69cee258135af4c927c273b661657673c98ce418","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"Normal response codes: 200"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"Error response codes: 404, 409, 401, 400"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"Request"},{"line_number":769,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"ba5201f7_8cbb2372","line":766,"range":{"start_line":766,"start_character":22,"end_line":766,"end_character":40},"updated":"2016-12-30 18:45:40.000000000","message":"nit: put these in numerical order","commit_id":"101ad36e3c208963b805f200eb2262a81b65610b"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"a38d1bab933cab0b73ece4c0b07da9ac127030b9","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"Normal response codes: 200"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"Error response codes: 404, 409, 401, 400"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"Request"},{"line_number":769,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"ba5201f7_3a7a93bd","line":766,"range":{"start_line":766,"start_character":22,"end_line":766,"end_character":40},"in_reply_to":"ba5201f7_8cbb2372","updated":"2017-01-08 17:44:55.000000000","message":"Done","commit_id":"101ad36e3c208963b805f200eb2262a81b65610b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"577e1dcb1664485895d19cd03a0feb4e25ee1d62","unresolved":false,"context_lines":[{"line_number":144,"context_line":"The firewall group may be associated with an ingress firewall policy"},{"line_number":145,"context_line":"and/or an egress firewall policy."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"If ``admin_state_up`` is ``false``, the firewall group would block all"},{"line_number":148,"context_line":"traffic."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Normal response codes: 201"}],"source_content_type":"text/x-c++src","patch_set":24,"id":"ba5201f7_ac9b1865","line":147,"range":{"start_line":147,"start_character":55,"end_line":147,"end_character":60},"updated":"2017-01-11 18:43:05.000000000","message":"Nit: \"will block\"","commit_id":"7db9d858d39e0eeb983ec8fc231f50288ea96ad3"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"46635757afc6738f865118683632cce3193da43d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"The firewall group may be associated with an ingress firewall policy"},{"line_number":145,"context_line":"and/or an egress firewall policy."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"If ``admin_state_up`` is ``false``, the firewall group would block all"},{"line_number":148,"context_line":"traffic."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Normal response codes: 201"}],"source_content_type":"text/x-c++src","patch_set":24,"id":"ba5201f7_753810a1","line":147,"range":{"start_line":147,"start_character":55,"end_line":147,"end_character":60},"in_reply_to":"ba5201f7_ac9b1865","updated":"2017-01-11 19:11:23.000000000","message":"Done","commit_id":"7db9d858d39e0eeb983ec8fc231f50288ea96ad3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"577e1dcb1664485895d19cd03a0feb4e25ee1d62","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Updates a firewall group."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"To update a service, the service status cannot be a ``PENDING_*``"},{"line_number":209,"context_line":"status."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Normal response codes: 200"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":24,"id":"ba5201f7_ccf93c82","line":209,"range":{"start_line":208,"start_character":0,"end_line":209,"end_character":7},"updated":"2017-01-11 18:43:05.000000000","message":"Maybe it\u0027s just me, but this reads a little confusing. Is this saying the firewall group\u0027s status can\u0027t be updated when the firewall group is in the PENDING_* status?","commit_id":"7db9d858d39e0eeb983ec8fc231f50288ea96ad3"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"46635757afc6738f865118683632cce3193da43d","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Updates a firewall group."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"To update a service, the service status cannot be a ``PENDING_*``"},{"line_number":209,"context_line":"status."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Normal response codes: 200"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":24,"id":"ba5201f7_d5cc5cbd","line":209,"range":{"start_line":208,"start_character":0,"end_line":209,"end_character":7},"in_reply_to":"ba5201f7_ccf93c82","updated":"2017-01-11 19:11:23.000000000","message":"Yes, I will make this clear.","commit_id":"7db9d858d39e0eeb983ec8fc231f50288ea96ad3"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"c5cba9e737a41a3b9ce28f2b802ef8dd6d769055","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Updates a firewall group."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"To update a service, the service status cannot be a ``PENDING_*``"},{"line_number":209,"context_line":"status."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Normal response codes: 200"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":24,"id":"ba5201f7_7513b0b8","line":209,"range":{"start_line":208,"start_character":0,"end_line":209,"end_character":7},"in_reply_to":"ba5201f7_d5cc5cbd","updated":"2017-01-11 19:17:58.000000000","message":"I realize it\u0027s not quite that.  The firewall group cannot be updated if its status is a PENDING_* status.","commit_id":"7db9d858d39e0eeb983ec8fc231f50288ea96ad3"}],"api-ref/source/v2/index.rst":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"44f116c2e6a72b9d3c5d11f4eeb22344010b722d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"##########################"},{"line_number":58,"context_line":".. include:: lbaas-v1.inc"},{"line_number":59,"context_line":".. include:: lbaas-v2.inc"},{"line_number":60,"context_line":".. include:: fwaas.inc"},{"line_number":61,"context_line":".. include:: fwaas-v2.inc"},{"line_number":62,"context_line":".. include:: vpnaas.inc"}],"source_content_type":"text/x-rst","patch_set":20,"id":"1a6eadb0_10cc1eba","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":23},"updated":"2016-12-21 16:35:55.000000000","message":"fwaas and vpnaas are already included under the \"Security\" section; so I think what\u0027s needed here is to just add the include for fwaas-v2.inc under the \"Security\" section These don\u0027t really seem to make sense under \"Load Balancer as a Service\".","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"##########################"},{"line_number":58,"context_line":".. include:: lbaas-v1.inc"},{"line_number":59,"context_line":".. include:: lbaas-v2.inc"},{"line_number":60,"context_line":".. include:: fwaas.inc"},{"line_number":61,"context_line":".. include:: fwaas-v2.inc"},{"line_number":62,"context_line":".. include:: vpnaas.inc"}],"source_content_type":"text/x-rst","patch_set":20,"id":"da4df55a_42750530","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":23},"in_reply_to":"1a6eadb0_10cc1eba","updated":"2016-12-27 13:58:43.000000000","message":"OK.  It makes sense.  I\u0027ll move it.","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"dee144bb63628518c593680c6a80c77d85675b20","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  type: string"},{"line_number":16,"context_line":"egress_firewall_policy_id:"},{"line_number":17,"context_line":"  description: |"},{"line_number":18,"context_line":"    The UUID of the policy."},{"line_number":19,"context_line":"  in: path"},{"line_number":20,"context_line":"  required: false"},{"line_number":21,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5da102_b86139ab","line":18,"updated":"2016-11-04 05:25:05.000000000","message":"UUID should be changed \u0027ID\u0027.  Please refer following etherpad[1] Line#96.\n\n\n[1]https://etherpad.openstack.org/p/neutron-api-ref-sprint","commit_id":"bb5ad18bac04351eeb19dbdb37687f8a202526e8"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"54f46ca12bd74b6126887caa26365615f6d9035c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  type: string"},{"line_number":16,"context_line":"egress_firewall_policy_id:"},{"line_number":17,"context_line":"  description: |"},{"line_number":18,"context_line":"    The UUID of the policy."},{"line_number":19,"context_line":"  in: path"},{"line_number":20,"context_line":"  required: false"},{"line_number":21,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5da102_bee10f9d","line":18,"in_reply_to":"ba5da102_b86139ab","updated":"2016-11-04 15:18:37.000000000","message":"Done","commit_id":"bb5ad18bac04351eeb19dbdb37687f8a202526e8"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"dee144bb63628518c593680c6a80c77d85675b20","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  type: string"},{"line_number":28,"context_line":"firewall_group_id:"},{"line_number":29,"context_line":"  description: |"},{"line_number":30,"context_line":"    The UUID of the firewall group."},{"line_number":31,"context_line":"  in: path"},{"line_number":32,"context_line":"  required: false"},{"line_number":33,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5da102_386e0997","line":30,"updated":"2016-11-04 05:25:05.000000000","message":"ditto","commit_id":"bb5ad18bac04351eeb19dbdb37687f8a202526e8"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"54f46ca12bd74b6126887caa26365615f6d9035c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  type: string"},{"line_number":28,"context_line":"firewall_group_id:"},{"line_number":29,"context_line":"  description: |"},{"line_number":30,"context_line":"    The UUID of the firewall group."},{"line_number":31,"context_line":"  in: path"},{"line_number":32,"context_line":"  required: false"},{"line_number":33,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5da102_fef1c76b","line":30,"in_reply_to":"ba5da102_386e0997","updated":"2016-11-04 15:18:37.000000000","message":"Done","commit_id":"bb5ad18bac04351eeb19dbdb37687f8a202526e8"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"dee144bb63628518c593680c6a80c77d85675b20","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  type: string"},{"line_number":76,"context_line":"ingress_firewall_policy_id:"},{"line_number":77,"context_line":"  description: |"},{"line_number":78,"context_line":"    The UUID of the policy."},{"line_number":79,"context_line":"  in: path"},{"line_number":80,"context_line":"  required: false"},{"line_number":81,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5da102_586bbd85","line":78,"updated":"2016-11-04 05:25:05.000000000","message":"ditto","commit_id":"bb5ad18bac04351eeb19dbdb37687f8a202526e8"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"54f46ca12bd74b6126887caa26365615f6d9035c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  type: string"},{"line_number":76,"context_line":"ingress_firewall_policy_id:"},{"line_number":77,"context_line":"  description: |"},{"line_number":78,"context_line":"    The UUID of the policy."},{"line_number":79,"context_line":"  in: path"},{"line_number":80,"context_line":"  required: false"},{"line_number":81,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5da102_1ee75bad","line":78,"in_reply_to":"ba5da102_586bbd85","updated":"2016-11-04 15:18:37.000000000","message":"Done","commit_id":"bb5ad18bac04351eeb19dbdb37687f8a202526e8"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"dee144bb63628518c593680c6a80c77d85675b20","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"  type: object"},{"line_number":1360,"context_line":"firewall_groups:"},{"line_number":1361,"context_line":"  description: |"},{"line_number":1362,"context_line":"    A list of ``firewall_groups`` objects."},{"line_number":1363,"context_line":"  in: body"},{"line_number":1364,"context_line":"  required: true"},{"line_number":1365,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5da102_98d1d532","line":1362,"updated":"2016-11-04 05:25:05.000000000","message":"A list of  ``firewall group`` objects.","commit_id":"bb5ad18bac04351eeb19dbdb37687f8a202526e8"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"54f46ca12bd74b6126887caa26365615f6d9035c","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"  type: object"},{"line_number":1360,"context_line":"firewall_groups:"},{"line_number":1361,"context_line":"  description: |"},{"line_number":1362,"context_line":"    A list of ``firewall_groups`` objects."},{"line_number":1363,"context_line":"  in: body"},{"line_number":1364,"context_line":"  required: true"},{"line_number":1365,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5da102_5e01d338","line":1362,"in_reply_to":"ba5da102_98d1d532","updated":"2016-11-04 15:18:37.000000000","message":"Done","commit_id":"bb5ad18bac04351eeb19dbdb37687f8a202526e8"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  type: string"},{"line_number":16,"context_line":"egress_firewall_policy_id:"},{"line_number":17,"context_line":"  description: |"},{"line_number":18,"context_line":"    The ID of the policy."},{"line_number":19,"context_line":"  in: path"},{"line_number":20,"context_line":"  required: false"},{"line_number":21,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5da102_438d577a","line":18,"updated":"2016-11-07 09:54:53.000000000","message":"It is better to indicate that this value is for \u0027egress\u0027.","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  type: string"},{"line_number":16,"context_line":"egress_firewall_policy_id:"},{"line_number":17,"context_line":"  description: |"},{"line_number":18,"context_line":"    The ID of the policy."},{"line_number":19,"context_line":"  in: path"},{"line_number":20,"context_line":"  required: false"},{"line_number":21,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a629dbe_6c13555d","line":18,"in_reply_to":"ba5da102_438d577a","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"ae88165e679c2e2c1491548332dea28b59d1912d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  type: string"},{"line_number":76,"context_line":"ingress_firewall_policy_id:"},{"line_number":77,"context_line":"  description: |"},{"line_number":78,"context_line":"    The ID of the policy."},{"line_number":79,"context_line":"  in: path"},{"line_number":80,"context_line":"  required: false"},{"line_number":81,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5da102_23bea3ff","line":78,"updated":"2016-11-07 09:54:53.000000000","message":"It is better to indicate that this value is for \u0027ingress\u0027.","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"81144ae3c1e5e304c1f566dbdebdb3b4db7fc404","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  type: string"},{"line_number":76,"context_line":"ingress_firewall_policy_id:"},{"line_number":77,"context_line":"  description: |"},{"line_number":78,"context_line":"    The ID of the policy."},{"line_number":79,"context_line":"  in: path"},{"line_number":80,"context_line":"  required: false"},{"line_number":81,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a629dbe_8c10a950","line":78,"in_reply_to":"ba5da102_23bea3ff","updated":"2016-11-08 00:28:40.000000000","message":"Done","commit_id":"68bc26d5bc486610a2895930e26cad1d9de1260d"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"203b90deab7d1f86dd0e8829c9ec653f01b5cf00","unresolved":false,"context_lines":[{"line_number":800,"context_line":"  in: body"},{"line_number":801,"context_line":"  required: false"},{"line_number":802,"context_line":"  type: string"},{"line_number":803,"context_line":"description_1:"},{"line_number":804,"context_line":"  description: |"},{"line_number":805,"context_line":"    A human-readable description for the firewall rule."},{"line_number":806,"context_line":"    The maximum length is 1024 characters. No default."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a629dbe_bc299b39","line":803,"range":{"start_line":803,"start_character":0,"end_line":803,"end_character":13},"updated":"2016-11-09 23:15:57.000000000","message":"I don\u0027t see any of these description_1* parameters being used anywhere. I\u0027m not sure there\u0027s much point in correcting the grammar if they\u0027re not used.","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":800,"context_line":"  in: body"},{"line_number":801,"context_line":"  required: false"},{"line_number":802,"context_line":"  type: string"},{"line_number":803,"context_line":"description_1:"},{"line_number":804,"context_line":"  description: |"},{"line_number":805,"context_line":"    A human-readable description for the firewall rule."},{"line_number":806,"context_line":"    The maximum length is 1024 characters. No default."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a629dbe_4f9ed5b9","line":803,"range":{"start_line":803,"start_character":0,"end_line":803,"end_character":13},"in_reply_to":"9a629dbe_bc299b39","updated":"2016-11-10 18:57:01.000000000","message":"These changes came along for the ride.  :)","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e7d3134f10469d58433a542df7488633f7718861","unresolved":false,"context_lines":[{"line_number":1459,"context_line":"  in: body"},{"line_number":1460,"context_line":"  required: true"},{"line_number":1461,"context_line":"  type: boolean"},{"line_number":1462,"context_line":"firewall_group_status_body_optional:"},{"line_number":1463,"context_line":"  description: |"},{"line_number":1464,"context_line":"    The status of the firewall group. Valid values are ``ACTIVE``,"},{"line_number":1465,"context_line":"    ``INACTIVE``, ``ERROR``, ``PENDING_UPDATE``, or"},{"line_number":1466,"context_line":"    ``PENDING_DELETE``. Default value is ``INACTIVE``."},{"line_number":1467,"context_line":"  in: body"},{"line_number":1468,"context_line":"  required: false"},{"line_number":1469,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a629dbe_e380c6c1","line":1466,"range":{"start_line":1462,"start_character":0,"end_line":1466,"end_character":54},"updated":"2016-11-10 08:51:54.000000000","message":"\u0027status\u0027 is read-only and comes back from the server-side.  So, a user cannot specify this value.  Therefore, \u0027Default value\u0027 doesn\u0027t match for this explanation.  How about removing following sentense?\n\n* Default value is ``INACTIVE``.","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":1459,"context_line":"  in: body"},{"line_number":1460,"context_line":"  required: true"},{"line_number":1461,"context_line":"  type: boolean"},{"line_number":1462,"context_line":"firewall_group_status_body_optional:"},{"line_number":1463,"context_line":"  description: |"},{"line_number":1464,"context_line":"    The status of the firewall group. Valid values are ``ACTIVE``,"},{"line_number":1465,"context_line":"    ``INACTIVE``, ``ERROR``, ``PENDING_UPDATE``, or"},{"line_number":1466,"context_line":"    ``PENDING_DELETE``. Default value is ``INACTIVE``."},{"line_number":1467,"context_line":"  in: body"},{"line_number":1468,"context_line":"  required: false"},{"line_number":1469,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a629dbe_efade9e9","line":1466,"range":{"start_line":1462,"start_character":0,"end_line":1466,"end_character":54},"in_reply_to":"9a629dbe_e380c6c1","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e7d3134f10469d58433a542df7488633f7718861","unresolved":false,"context_lines":[{"line_number":1469,"context_line":"  type: string"},{"line_number":1470,"context_line":"firewall_group_status_body_required:"},{"line_number":1471,"context_line":"  description: |"},{"line_number":1472,"context_line":"    The status of the firewall group. Valid values are ``ACTIVE``,"},{"line_number":1473,"context_line":"    ``INACTIVE``, ``ERROR``, ``PENDING_UPDATE``, or"},{"line_number":1474,"context_line":"    ``PENDING_DELETE``. Default value is ``INACTIVE``."},{"line_number":1475,"context_line":"  in: body"},{"line_number":1476,"context_line":"  required: true"},{"line_number":1477,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a629dbe_8372aa0f","line":1474,"range":{"start_line":1472,"start_character":0,"end_line":1474,"end_character":54},"updated":"2016-11-10 08:51:54.000000000","message":"ditto","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":1469,"context_line":"  type: string"},{"line_number":1470,"context_line":"firewall_group_status_body_required:"},{"line_number":1471,"context_line":"  description: |"},{"line_number":1472,"context_line":"    The status of the firewall group. Valid values are ``ACTIVE``,"},{"line_number":1473,"context_line":"    ``INACTIVE``, ``ERROR``, ``PENDING_UPDATE``, or"},{"line_number":1474,"context_line":"    ``PENDING_DELETE``. Default value is ``INACTIVE``."},{"line_number":1475,"context_line":"  in: body"},{"line_number":1476,"context_line":"  required: true"},{"line_number":1477,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a629dbe_cf7f4513","line":1474,"range":{"start_line":1472,"start_character":0,"end_line":1474,"end_character":54},"in_reply_to":"9a629dbe_8372aa0f","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6eadcfae987883c45ef89ba5ca666fb7f7fd9ce0","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"  type: string"},{"line_number":1478,"context_line":"firewall_groups_body_required:"},{"line_number":1479,"context_line":"  description: |"},{"line_number":1480,"context_line":"    A list of ``firewall group`` objects."},{"line_number":1481,"context_line":"  in: body"},{"line_number":1482,"context_line":"  required: true"},{"line_number":1483,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a629dbe_03ae76e5","line":1480,"range":{"start_line":1480,"start_character":24,"end_line":1480,"end_character":25},"updated":"2016-11-10 20:34:08.000000000","message":"since you added the underscore to \"firewall_group\" in the preamble text I think you need to add it here for consistency. Otherwise, in the rendered web page you have \"firewall_group\" in red highlight in the preamble and \"firewall group\" without the underscore in red highlight in the parameter table.\n\nIt just looks visually inconsistent.","commit_id":"e6621ac66c8fa69eb0c6a4ec06d4c0ec6aa88d8a"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"f36b725212d970835065d6d32ffde08669048976","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"  type: string"},{"line_number":1478,"context_line":"firewall_groups_body_required:"},{"line_number":1479,"context_line":"  description: |"},{"line_number":1480,"context_line":"    A list of ``firewall group`` objects."},{"line_number":1481,"context_line":"  in: body"},{"line_number":1482,"context_line":"  required: true"},{"line_number":1483,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a629dbe_7e0b45d6","line":1480,"range":{"start_line":1480,"start_character":24,"end_line":1480,"end_character":25},"in_reply_to":"9a629dbe_03ae76e5","updated":"2016-11-10 21:09:28.000000000","message":"Removed; no longer needed.","commit_id":"e6621ac66c8fa69eb0c6a4ec06d4c0ec6aa88d8a"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6eadcfae987883c45ef89ba5ca666fb7f7fd9ce0","unresolved":false,"context_lines":[{"line_number":1481,"context_line":"  in: body"},{"line_number":1482,"context_line":"  required: true"},{"line_number":1483,"context_line":"  type: array"},{"line_number":1484,"context_line":"firewall_groups_object:"},{"line_number":1485,"context_line":"  description: |"},{"line_number":1486,"context_line":"    A list of ``firewall group`` objects."},{"line_number":1487,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a629dbe_e39982c5","line":1484,"range":{"start_line":1484,"start_character":0,"end_line":1484,"end_character":22},"updated":"2016-11-10 20:34:08.000000000","message":"what\u0027s the difference between this and the one on line 1478? Do you really need both?","commit_id":"e6621ac66c8fa69eb0c6a4ec06d4c0ec6aa88d8a"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"f36b725212d970835065d6d32ffde08669048976","unresolved":false,"context_lines":[{"line_number":1481,"context_line":"  in: body"},{"line_number":1482,"context_line":"  required: true"},{"line_number":1483,"context_line":"  type: array"},{"line_number":1484,"context_line":"firewall_groups_object:"},{"line_number":1485,"context_line":"  description: |"},{"line_number":1486,"context_line":"    A list of ``firewall group`` objects."},{"line_number":1487,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a629dbe_be84fd0a","line":1484,"range":{"start_line":1484,"start_character":0,"end_line":1484,"end_character":22},"in_reply_to":"9a629dbe_e39982c5","updated":"2016-11-10 21:09:28.000000000","message":"Reflects a mistake I made when I changed approach; the one at 1478 has been removed.  Good eye!","commit_id":"e6621ac66c8fa69eb0c6a4ec06d4c0ec6aa88d8a"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6eadcfae987883c45ef89ba5ca666fb7f7fd9ce0","unresolved":false,"context_lines":[{"line_number":1483,"context_line":"  type: array"},{"line_number":1484,"context_line":"firewall_groups_object:"},{"line_number":1485,"context_line":"  description: |"},{"line_number":1486,"context_line":"    A list of ``firewall group`` objects."},{"line_number":1487,"context_line":"  in: body"},{"line_number":1488,"context_line":"  required: true"},{"line_number":1489,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a629dbe_438b0e68","line":1486,"range":{"start_line":1486,"start_character":24,"end_line":1486,"end_character":25},"updated":"2016-11-10 20:34:08.000000000","message":"If you really need both you should add the underscore here too for consistency.","commit_id":"e6621ac66c8fa69eb0c6a4ec06d4c0ec6aa88d8a"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"f36b725212d970835065d6d32ffde08669048976","unresolved":false,"context_lines":[{"line_number":1483,"context_line":"  type: array"},{"line_number":1484,"context_line":"firewall_groups_object:"},{"line_number":1485,"context_line":"  description: |"},{"line_number":1486,"context_line":"    A list of ``firewall group`` objects."},{"line_number":1487,"context_line":"  in: body"},{"line_number":1488,"context_line":"  required: true"},{"line_number":1489,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a629dbe_3e154de4","line":1486,"range":{"start_line":1486,"start_character":24,"end_line":1486,"end_character":25},"in_reply_to":"9a629dbe_438b0e68","updated":"2016-11-10 21:09:28.000000000","message":"Done","commit_id":"e6621ac66c8fa69eb0c6a4ec06d4c0ec6aa88d8a"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8a6b187a3e3d50ccd4324e365a0cce07bbf0cac0","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"  type: string"},{"line_number":1478,"context_line":"firewall_groups_object:"},{"line_number":1479,"context_line":"  description: |"},{"line_number":1480,"context_line":"    A list of ``firewall_ group`` objects."},{"line_number":1481,"context_line":"  in: body"},{"line_number":1482,"context_line":"  required: true"},{"line_number":1483,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9a629dbe_ae0e8ae2","line":1480,"range":{"start_line":1480,"start_character":25,"end_line":1480,"end_character":26},"updated":"2016-11-10 23:56:30.000000000","message":"so close. ouch. you inserted the underscore instead of replacing the space with an underscore. Now you need to take out the space.","commit_id":"d133c92c7187fa184a77614272ad4cca9378974d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"4edb388283e439d5e3576d70cb4a973e17fc34c8","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"  type: string"},{"line_number":1478,"context_line":"firewall_groups_object:"},{"line_number":1479,"context_line":"  description: |"},{"line_number":1480,"context_line":"    A list of ``firewall_ group`` objects."},{"line_number":1481,"context_line":"  in: body"},{"line_number":1482,"context_line":"  required: true"},{"line_number":1483,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9a629dbe_2f2ee2fa","line":1480,"range":{"start_line":1480,"start_character":25,"end_line":1480,"end_character":26},"in_reply_to":"9a629dbe_ae0e8ae2","updated":"2016-11-11 13:45:46.000000000","message":"Thank you for checking this so carefully.  ouch is right.","commit_id":"d133c92c7187fa184a77614272ad4cca9378974d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3ceab1ef4f849d8225a3ccf960421057fd24c5cc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  type: string"},{"line_number":22,"context_line":"firewall_group_id_path_required:"},{"line_number":23,"context_line":"  description: |"},{"line_number":24,"context_line":"    The ID of the firewall group."},{"line_number":25,"context_line":"  in: path"},{"line_number":26,"context_line":"  required: true"},{"line_number":27,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a629dbe_157f5115","line":24,"updated":"2016-11-12 18:15:04.000000000","message":"Should it be ID or UUID?\nIts a nit, but lets try to keep things consistent, aint it?","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d38f1188c8c725acc31d25ec743d9d52ff13081d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  type: string"},{"line_number":22,"context_line":"firewall_group_id_path_required:"},{"line_number":23,"context_line":"  description: |"},{"line_number":24,"context_line":"    The ID of the firewall group."},{"line_number":25,"context_line":"  in: path"},{"line_number":26,"context_line":"  required: true"},{"line_number":27,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a629dbe_4bb84a2a","line":24,"in_reply_to":"9a629dbe_157f5115","updated":"2016-11-13 00:07:43.000000000","message":"Yes, I believe I\u0027ve changed all of the fwaas-related vars to ID.","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  type: string"},{"line_number":52,"context_line":"firewall_rule_id_path_required:"},{"line_number":53,"context_line":"  description: |"},{"line_number":54,"context_line":"    The UUID for the firewall rule."},{"line_number":55,"context_line":"  in: path"},{"line_number":56,"context_line":"  required: true"},{"line_number":57,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"da4df55a_e7890fcc","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":12},"updated":"2016-12-22 21:25:15.000000000","message":"Can you please change this to ID for consistency?","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  type: string"},{"line_number":52,"context_line":"firewall_rule_id_path_required:"},{"line_number":53,"context_line":"  description: |"},{"line_number":54,"context_line":"    The UUID for the firewall rule."},{"line_number":55,"context_line":"  in: path"},{"line_number":56,"context_line":"  required: true"},{"line_number":57,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"da4df55a_8291ad49","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":12},"in_reply_to":"da4df55a_e7890fcc","updated":"2016-12-27 13:58:43.000000000","message":"Sure!","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c8ec3d31f3616fd45df2f432559e1792de4f9ef","unresolved":false,"context_lines":[{"line_number":1810,"context_line":"  in: body"},{"line_number":1811,"context_line":"  required: true"},{"line_number":1812,"context_line":"  type: string"},{"line_number":1813,"context_line":"firewall_rule_id_1:"},{"line_number":1814,"context_line":"  description: |"},{"line_number":1815,"context_line":"    The ID of the firewall rule."},{"line_number":1816,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"da4df55a_c7724be5","line":1813,"range":{"start_line":1813,"start_character":0,"end_line":1813,"end_character":18},"updated":"2016-12-22 21:25:15.000000000","message":"Can you please rename this and remove _1 from the parameter as we are trying to remove the numbering of the parameters as per this [1]?\n\n[1] https://etherpad.openstack.org/p/neutron-api-ref-sprint","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"3c4c09b4a8fcac394255a4376e39369040158ebf","unresolved":false,"context_lines":[{"line_number":1810,"context_line":"  in: body"},{"line_number":1811,"context_line":"  required: true"},{"line_number":1812,"context_line":"  type: string"},{"line_number":1813,"context_line":"firewall_rule_id_1:"},{"line_number":1814,"context_line":"  description: |"},{"line_number":1815,"context_line":"    The ID of the firewall rule."},{"line_number":1816,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"da4df55a_22cac14e","line":1813,"range":{"start_line":1813,"start_character":0,"end_line":1813,"end_character":18},"in_reply_to":"da4df55a_c7724be5","updated":"2016-12-27 13:58:43.000000000","message":"I think this cleanup is very suitable.  Numbering is really confusing about their usage or meaning.  I realized firewall_rule_id_1 wasn\u0027t used from other documents.  Therefore, I\u0027ll remove it.","commit_id":"19f156cc17ffdb6d0b445274692e985035bcd335"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"69cee258135af4c927c273b661657673c98ce418","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  in: path"},{"line_number":20,"context_line":"  required: true"},{"line_number":21,"context_line":"  type: string"},{"line_number":22,"context_line":"firewall_group_id_path_required:"},{"line_number":23,"context_line":"  description: |"},{"line_number":24,"context_line":"    The ID of the firewall group."},{"line_number":25,"context_line":"  in: path"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ba5201f7_8c49638e","line":22,"range":{"start_line":22,"start_character":17,"end_line":22,"end_character":22},"updated":"2016-12-30 18:45:40.000000000","message":"It looks like -path is preferred rather than _path for disambiguating a parameter that can appear in body or path.","commit_id":"101ad36e3c208963b805f200eb2262a81b65610b"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"a38d1bab933cab0b73ece4c0b07da9ac127030b9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  in: path"},{"line_number":20,"context_line":"  required: true"},{"line_number":21,"context_line":"  type: string"},{"line_number":22,"context_line":"firewall_group_id_path_required:"},{"line_number":23,"context_line":"  description: |"},{"line_number":24,"context_line":"    The ID of the firewall group."},{"line_number":25,"context_line":"  in: path"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ba5201f7_7a809b8b","line":22,"range":{"start_line":22,"start_character":17,"end_line":22,"end_character":22},"in_reply_to":"ba5201f7_8c49638e","updated":"2017-01-08 17:44:55.000000000","message":"Thank you.  Will fix.","commit_id":"101ad36e3c208963b805f200eb2262a81b65610b"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"69cee258135af4c927c273b661657673c98ce418","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  in: path"},{"line_number":38,"context_line":"  required: true"},{"line_number":39,"context_line":"  type: string"},{"line_number":40,"context_line":"firewall_policy_id_path_required:"},{"line_number":41,"context_line":"  description: |"},{"line_number":42,"context_line":"    The ID of the firewall policy."},{"line_number":43,"context_line":"  in: path"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ba5201f7_6c3b5fec","line":40,"range":{"start_line":40,"start_character":18,"end_line":40,"end_character":23},"updated":"2016-12-30 18:45:40.000000000","message":"Here too, and throughout all below, change _path to -path and change _body to -body","commit_id":"101ad36e3c208963b805f200eb2262a81b65610b"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"a38d1bab933cab0b73ece4c0b07da9ac127030b9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  in: path"},{"line_number":38,"context_line":"  required: true"},{"line_number":39,"context_line":"  type: string"},{"line_number":40,"context_line":"firewall_policy_id_path_required:"},{"line_number":41,"context_line":"  description: |"},{"line_number":42,"context_line":"    The ID of the firewall policy."},{"line_number":43,"context_line":"  in: path"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ba5201f7_ba4cc39e","line":40,"range":{"start_line":40,"start_character":18,"end_line":40,"end_character":23},"in_reply_to":"ba5201f7_6c3b5fec","updated":"2017-01-08 17:44:55.000000000","message":"Done.","commit_id":"101ad36e3c208963b805f200eb2262a81b65610b"}],"api-ref/source/v2/samples/firewall-v2/firewall-group-create-request.json":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3ceab1ef4f849d8225a3ccf960421057fd24c5cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"firewall_group\": {"},{"line_number":3,"context_line":"        \"admin_state_up\": true,"},{"line_number":4,"context_line":"        \"egress_firewall_policy_id\": \"14c9d3c1-b472-44f9-8226-30dc4ffd454c\""},{"line_number":5,"context_line":"        \"ingress_firewall_policy_id\": \"c69933c1-b472-44f9-8226-30dc4ffd454c\""},{"line_number":6,"context_line":"    }"}],"source_content_type":"application/json","patch_set":13,"id":"9a629dbe_75708d40","line":3,"updated":"2016-11-12 18:15:04.000000000","message":"This is the default value, right?\nAs per the fwaas_v2.inc it is optional","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d38f1188c8c725acc31d25ec743d9d52ff13081d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"firewall_group\": {"},{"line_number":3,"context_line":"        \"admin_state_up\": true,"},{"line_number":4,"context_line":"        \"egress_firewall_policy_id\": \"14c9d3c1-b472-44f9-8226-30dc4ffd454c\""},{"line_number":5,"context_line":"        \"ingress_firewall_policy_id\": \"c69933c1-b472-44f9-8226-30dc4ffd454c\""},{"line_number":6,"context_line":"    }"}],"source_content_type":"application/json","patch_set":13,"id":"9a629dbe_2badd6e8","line":3,"in_reply_to":"9a629dbe_75708d40","updated":"2016-11-13 00:07:43.000000000","message":"I changed to remove this confusion.","commit_id":"9fe28306d2d82aafca8c26962a58ecdeb7c69974"}],"api-ref/source/v2/samples/firewall-v2/firewall-rule-create-response.json":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e7d3134f10469d58433a542df7488633f7718861","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"id\": \"8722e0e0-9cc9-4490-9660-8c9a5732fbb0\","},{"line_number":10,"context_line":"        \"ip_version\": 4,"},{"line_number":11,"context_line":"        \"name\": \"ALLOW_HTTP\","},{"line_number":12,"context_line":"        \"position\": null,"},{"line_number":13,"context_line":"        \"protocol\": \"tcp\","},{"line_number":14,"context_line":"        \"public\": false,"},{"line_number":15,"context_line":"        \"source_ip_address\": null,"}],"source_content_type":"application/json","patch_set":9,"id":"9a629dbe_464a6027","line":12,"range":{"start_line":12,"start_character":8,"end_line":12,"end_character":25},"updated":"2016-11-10 08:51:54.000000000","message":"Currently, firewall-rules doesn\u0027t return \u0027position\u0027.  I\u0027ll discuss about that at today\u0027s meeting.  Could you keep it on?  IMO, a relation for firewall_policy and firewall_rule and rule position is stored by firewall_policy_rule_associations_v2 so \u0027position\u0027 is not necessary in firewall_rule dict.\n\n{\n    \"firewall_rule\": {\n        \"action\": \"deny\",\n        \"description\": \"\",\n        \"destination_ip_address\": null,\n        \"destination_port\": null,\n        \"enabled\": true,\n        \"id\": \"1fd59b2f-cc87-435f-a244-1df2c0cc3f70\",\n        \"ip_version\": 4,\n        \"name\": \"rule3\",\n        \"project_id\": \"95573613ec554b4b8df9f2679c64557b\",\n        \"protocol\": null,\n        \"public\": false,\n        \"source_ip_address\": null,\n        \"source_port\": null,\n        \"tenant_id\": \"95573613ec554b4b8df9f2679c64557b\"\n    }\n}","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d4f534f757aa3a14cc74451c284acd06e0933e45","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"id\": \"8722e0e0-9cc9-4490-9660-8c9a5732fbb0\","},{"line_number":10,"context_line":"        \"ip_version\": 4,"},{"line_number":11,"context_line":"        \"name\": \"ALLOW_HTTP\","},{"line_number":12,"context_line":"        \"position\": null,"},{"line_number":13,"context_line":"        \"protocol\": \"tcp\","},{"line_number":14,"context_line":"        \"public\": false,"},{"line_number":15,"context_line":"        \"source_ip_address\": null,"}],"source_content_type":"application/json","patch_set":9,"id":"9a629dbe_6f9b9918","line":12,"range":{"start_line":12,"start_character":8,"end_line":12,"end_character":25},"in_reply_to":"9a629dbe_0d3f8a87","updated":"2016-11-10 18:57:01.000000000","message":"Done","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"},{"author":{"_account_id":6995,"name":"Sridar Kandaswamy","email":"skandasw@yahoo.com","username":"skandasw"},"change_message_id":"96c9171d4b4752c6dfe8e6c2eb9d2529bccb5380","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"id\": \"8722e0e0-9cc9-4490-9660-8c9a5732fbb0\","},{"line_number":10,"context_line":"        \"ip_version\": 4,"},{"line_number":11,"context_line":"        \"name\": \"ALLOW_HTTP\","},{"line_number":12,"context_line":"        \"position\": null,"},{"line_number":13,"context_line":"        \"protocol\": \"tcp\","},{"line_number":14,"context_line":"        \"public\": false,"},{"line_number":15,"context_line":"        \"source_ip_address\": null,"}],"source_content_type":"application/json","patch_set":9,"id":"9a629dbe_0d3f8a87","line":12,"range":{"start_line":12,"start_character":8,"end_line":12,"end_character":25},"in_reply_to":"9a629dbe_464a6027","updated":"2016-11-10 17:11:03.000000000","message":"Margaret, we discussed this. And yes we should not have position in the response . Made sense for v1 as a rule could be associated only with a single policy but now that a rule can have be a part of multiple policies - does not make sense here or it we will need to return a dict with position in each policy. \n\nI think this information should be available on a GET of a policy.","commit_id":"846108df6bf4d3ce5105e5b5e0651d9310eeacfe"}]}
