)]}'
{"neutron_lib/tests/unit/utils/test_helpers.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8ec403821989aaf189313d5a9e9691f79eeeae64","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def test_wait_until_true_predicate_fails(self):"},{"line_number":233,"context_line":"        with testtools.ExpectedException(eventlet.timeout.Timeout):"},{"line_number":234,"context_line":"            helpers.wait_until_true(lambda: False, 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_0f2a8f2c","line":234,"updated":"2016-11-16 09:12:44.000000000","message":"please add two more test cases:\n\n* one that ensures passing a custom exception results in that exception being raised\n* one more that sets a high sleep value (e.g. 5) and ensures that the predicate is only evaluated once in a 2 second timeout period.","commit_id":"b312d0e9ef918d778c8c7852a86c3945a5467757"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e5b8fa0f408e7e2553f019216a997a2f502bc85c","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def test_wait_until_true_predicate_fails(self):"},{"line_number":233,"context_line":"        with testtools.ExpectedException(eventlet.timeout.Timeout):"},{"line_number":234,"context_line":"            helpers.wait_until_true(lambda: False, 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_125b962f","line":234,"in_reply_to":"7a77a97e_0f2a8f2c","updated":"2016-11-16 09:24:28.000000000","message":"Done","commit_id":"b312d0e9ef918d778c8c7852a86c3945a5467757"}],"neutron_lib/utils/helpers.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d129f3be5b52619908b6c3d14446c14aa14223fe","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import decimal"},{"line_number":16,"context_line":"import random"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import eventlet"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron_lib._i18n import _"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_e210faaa","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":15},"updated":"2016-11-16 13:39:22.000000000","message":"What about the restriction to not use eventlet in neutron-lib? https://github.com/openstack/neutron-lib/blob/master/doc/source/review-guidelines.rst","commit_id":"afa7aed0d8e67c6bef536a3a2b592929f831e490"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"df239385e2814284903d2d5a4329240975447a75","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import decimal"},{"line_number":16,"context_line":"import random"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import eventlet"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron_lib._i18n import _"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_681a0b70","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":15},"in_reply_to":"7a77a97e_62030a10","updated":"2016-11-16 14:06:48.000000000","message":"I guess our hacking check to check for eventlet imports is useless now.. Maybe we should remove it?","commit_id":"afa7aed0d8e67c6bef536a3a2b592929f831e490"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e2737f52bc455f3833d170af159ee5ea438dac77","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import decimal"},{"line_number":16,"context_line":"import random"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import eventlet"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron_lib._i18n import _"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_62030a10","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":15},"in_reply_to":"7a77a97e_e210faaa","updated":"2016-11-16 13:44:57.000000000","message":"Hmm, I am not sure how we can provide wait_until_true() without it?","commit_id":"afa7aed0d8e67c6bef536a3a2b592929f831e490"}]}
