)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"803412e135cb1d2e96b5a67c6d344bc5f326383e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ryan Tidwell \u003cryan.tidwell@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-29 16:48:11 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Move BGP extension definitions from neutron-dynamic-routing"},{"line_number":8,"context_line":"to neutron-lib."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I864c89d2b91834e5ba0b082da883b3234b522d5c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_8e43cc12","line":7,"updated":"2016-12-09 23:45:47.000000000","message":"needs tests and API-ref obviously :)","commit_id":"323fd175eeeba4ad251b8c42d16b5a7ae196f790"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8f2ff5448ddb40c46162fea14bdd104101aba4e1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2016-11-29 16:46:59 -0800"},{"line_number":4,"context_line":"Commit:     Ryan Tidwell \u003cryan.tidwell@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-05 14:11:41 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move BGP extension definitions from neutron-dynamic-routing to neutron-lib."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I864c89d2b91834e5ba0b082da883b3234b522d5c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba5201f7_9f754d65","line":6,"updated":"2017-01-06 17:45:48.000000000","message":"As per [1] shouldn\u0027t this use the \u0027stadium-implosion\u0027 topic?\n\n\n[1] https://review.openstack.org/#/c/389397/16/specs/stadium/ocata.rst@247","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2f08a54549d0e1fbf6dad675806767c00849a324","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2016-11-29 16:46:59 -0800"},{"line_number":4,"context_line":"Commit:     Ryan Tidwell \u003cryan.tidwell@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-05 14:11:41 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move BGP extension definitions from neutron-dynamic-routing to neutron-lib."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I864c89d2b91834e5ba0b082da883b3234b522d5c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba5201f7_3be0eecc","line":6,"in_reply_to":"ba5201f7_9f754d65","updated":"2017-01-06 21:43:33.000000000","message":"Yes, it should.","commit_id":"6266574287fea5e34e77f89733500139e344529b"}],"api-ref/source/v2/bgp.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8f2ff5448ddb40c46162fea14bdd104101aba4e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba5201f7_bf3db12c","updated":"2017-01-06 17:45:48.000000000","message":"Unless I\u0027m missing something, this file needs to be included in the index.rst; otherwise you can\u0027t find it in the api-ref: http://docs-draft.openstack.org/88/404488/5/check/gate-neutron-lib-api-ref/3902d17//api-ref/build/html/","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2f08a54549d0e1fbf6dad675806767c00849a324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba5201f7_bbfbfe77","in_reply_to":"ba5201f7_bf3db12c","updated":"2017-01-06 21:43:33.000000000","message":"You are correct, that is an oversight on my part.","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8f2ff5448ddb40c46162fea14bdd104101aba4e1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  UUID\u0027s cannot be found."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Error response codes: 400,401,404"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Request"},{"line_number":80,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"ba5201f7_df76f504","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":33},"updated":"2017-01-06 17:45:48.000000000","message":"Do we even need this if we have the codes explained above? If so nit: space after commas.","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2f08a54549d0e1fbf6dad675806767c00849a324","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  UUID\u0027s cannot be found."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Error response codes: 400,401,404"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Request"},{"line_number":80,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"ba5201f7_fbdae615","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":33},"in_reply_to":"ba5201f7_df76f504","updated":"2017-01-06 21:43:33.000000000","message":"Probably not","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"98b62981c42fd13486dfd19e80824b6ddbd5c143","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- ``401`` The operation is not authorized."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"- ``404`` If the extension is not available or one more network or BGP peer"},{"line_number":74,"context_line":"  UUID\u0027s cannot be found."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Request"},{"line_number":77,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"ba5201f7_1c230457","line":74,"range":{"start_line":73,"start_character":67,"end_line":74,"end_character":8},"updated":"2017-01-09 09:31:45.000000000","message":"BGP Peer UUID??? I think there is a separate interface for doing Speaker to Peer binding (PUT /v2.0/bgp-speakers/{bgp_speaker_id}/add-bgp-peer)","commit_id":"7f422f47495e05a833e222037b99525f671b9ac4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"98b62981c42fd13486dfd19e80824b6ddbd5c143","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Request"},{"line_number":77,"context_line":"-------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. rest_parameters.yaml"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   - ip_version: ip_version"},{"line_number":82,"context_line":"   - local_as: local_as"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"ba5201f7_fc36404f","line":79,"updated":"2017-01-09 09:31:45.000000000","message":"I believe you meant \".. rest_parameters:: parameters.yaml\"","commit_id":"7f422f47495e05a833e222037b99525f671b9ac4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"14a52d94b4e71c7da397ffe4f3366006ccf1cf4e","unresolved":false,"context_lines":[{"line_number":350,"context_line":"Request Example"},{"line_number":351,"context_line":"---------------"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":".. literalinclude:: ../v2/samples/bgp/bgp-speaker-remove-network-request.json"},{"line_number":354,"context_line":"   :language: javascript"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"Normal response codes: 200"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"ba5201f7_7ad3c25f","line":353,"range":{"start_line":353,"start_character":38,"end_line":353,"end_character":77},"updated":"2017-01-11 09:00:34.000000000","message":"File unavailable.. Tox complaining...","commit_id":"27e43bfbad5ab2d8c2f7c44bf48d890b774ef274"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"570af2acdf050ff865f812dfded278371eda9722","unresolved":false,"context_lines":[{"line_number":350,"context_line":"Request Example"},{"line_number":351,"context_line":"---------------"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":".. literalinclude:: ../v2/samples/bgp/bgp-speaker-remove-network-request.json"},{"line_number":354,"context_line":"   :language: javascript"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"Normal response codes: 200"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"ba5201f7_acb87876","line":353,"range":{"start_line":353,"start_character":38,"end_line":353,"end_character":77},"in_reply_to":"ba5201f7_7ad3c25f","updated":"2017-01-11 18:45:55.000000000","message":"Doh, forgot to do a \"git add\" on that file.","commit_id":"27e43bfbad5ab2d8c2f7c44bf48d890b774ef274"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"02356e4bfa7290d44c0e9d9dd35c2e8d277bf577","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  for a BGP speaker."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"BGP Speaker"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"* ``id``"},{"line_number":26,"context_line":"  The uuid of BGP Speaker."}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_311316ba","line":23,"updated":"2017-01-20 20:52:55.000000000","message":"What about Dynamic Routing Agents?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  for a BGP speaker."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"BGP Speaker"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"* ``id``"},{"line_number":26,"context_line":"  The uuid of BGP Speaker."}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_6a87b761","line":23,"in_reply_to":"5a3905b3_311316ba","updated":"2017-01-26 04:18:35.000000000","message":"That is a different extension. Those docs probably should go in a different file.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. rest_method::  POST /v2.0/bgp-speakers"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Error codes:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- ``400`` The operation returns this error code if the request is malformed,"},{"line_number":69,"context_line":"  e.g. there are missing or invalid parameters in the request."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- ``401`` The operation is not authorized."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"- ``404`` If the extension is not available."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Request"},{"line_number":76,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_2a878610","line":73,"range":{"start_line":66,"start_character":0,"end_line":73,"end_character":44},"updated":"2017-01-19 08:43:29.000000000","message":"why error codes are documented differently only here?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"02356e4bfa7290d44c0e9d9dd35c2e8d277bf577","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"   - ip_version: ip_version_4"},{"line_number":81,"context_line":"   - local_as: local_as"},{"line_number":82,"context_line":"   - name: name_resource"},{"line_number":83,"context_line":"   - peers: peers"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_71275e64","line":80,"updated":"2017-01-20 20:52:55.000000000","message":"For all these request/responses I think we should be also including a param for the top-level json object. e.g.::\n\n  - bgp_speaker: \u0027The ``bgp_speaker`` object...`\n\n\nPlease see other APIs for examples.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"   - ip_version: ip_version_4"},{"line_number":81,"context_line":"   - local_as: local_as"},{"line_number":82,"context_line":"   - name: name_resource"},{"line_number":83,"context_line":"   - peers: peers"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_aa819f4c","line":80,"in_reply_to":"5a3905b3_71275e64","updated":"2017-01-26 04:18:35.000000000","message":"Will do","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"   - ip_version: ip_version_4"},{"line_number":81,"context_line":"   - local_as: local_as"},{"line_number":82,"context_line":"   - name: name_resource"},{"line_number":83,"context_line":"   - peers: peers"},{"line_number":84,"context_line":"   - networks: network_ids"},{"line_number":85,"context_line":"   - advertise_floating_ip_host_routes: advertise_floating_ip_host_routes"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_4a5e9246","line":82,"range":{"start_line":82,"start_character":11,"end_line":82,"end_character":24},"updated":"2017-01-19 08:43:29.000000000","message":"name-request?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":97,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   - id: id_resource"},{"line_number":100,"context_line":"   - name: name_resource"},{"line_number":101,"context_line":"   - local_as: local_as"},{"line_number":102,"context_line":"   - ip_version: ip_version_4"},{"line_number":103,"context_line":"   - peers: peers"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_2a406656","line":100,"range":{"start_line":100,"start_character":11,"end_line":100,"end_character":24},"updated":"2017-01-19 08:43:29.000000000","message":"name?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":97,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   - id: id_resource"},{"line_number":100,"context_line":"   - name: name_resource"},{"line_number":101,"context_line":"   - local_as: local_as"},{"line_number":102,"context_line":"   - ip_version: ip_version_4"},{"line_number":103,"context_line":"   - peers: peers"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_8af3030a","line":100,"range":{"start_line":100,"start_character":11,"end_line":100,"end_character":24},"in_reply_to":"5a3905b3_2a406656","updated":"2017-01-26 04:18:35.000000000","message":"I thought name_resource was the key. I\u0027ll go double-check","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"02356e4bfa7290d44c0e9d9dd35c2e8d277bf577","unresolved":false,"context_lines":[{"line_number":104,"context_line":"   - networks: network_ids"},{"line_number":105,"context_line":"   - advertise_floating_ip_host_routes: advertise_floating_ip_host_routes"},{"line_number":106,"context_line":"   - advertise_tenant_networks: advertise_tenant_networks"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"List BGP Speakers"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_d1e3b203","line":107,"updated":"2017-01-20 20:52:55.000000000","message":"Nit: would be nice to have a response example.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"   - networks: network_ids"},{"line_number":105,"context_line":"   - advertise_floating_ip_host_routes: advertise_floating_ip_host_routes"},{"line_number":106,"context_line":"   - advertise_tenant_networks: advertise_tenant_networks"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"List BGP Speakers"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_aaf8bfe6","line":107,"in_reply_to":"5a3905b3_d1e3b203","updated":"2017-01-26 04:18:35.000000000","message":"Done","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"02356e4bfa7290d44c0e9d9dd35c2e8d277bf577","unresolved":false,"context_lines":[{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. rest_method::  GET /v2.0/bgp-speakers"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Normal response codes: 200"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Error response codes: 401,404"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_d1cad26d","line":113,"updated":"2017-01-20 20:52:55.000000000","message":"Doesn\u0027t this support querying with \u0027fields\u0027? If so we need to add that; see other api-refs for example.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. rest_method::  GET /v2.0/bgp-speakers"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Normal response codes: 200"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Error response codes: 401,404"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_eadac777","line":113,"in_reply_to":"5a3905b3_d1cad26d","updated":"2017-01-26 04:18:35.000000000","message":"I don\u0027t believe this is supported, but I\u0027ll double-check.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Update BGP Speaker"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".. rest_method::  PUT /v2.0/bgp-speakers/{bgp_speaker_id}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Update attributes of a BGP speaker."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_45af65e3","line":181,"updated":"2017-01-19 08:43:29.000000000","message":"- bgp_speaker_id: bgp_speaker_id","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Update BGP Speaker"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".. rest_method::  PUT /v2.0/bgp-speakers/{bgp_speaker_id}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Update attributes of a BGP speaker."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_4ad03b54","line":181,"in_reply_to":"5a3905b3_3a2a3d2d","updated":"2017-01-26 04:18:35.000000000","message":"Oops. Done","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3854d490d9afad05db2c729dfcc30bbdc8ec81a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Update BGP Speaker"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".. rest_method::  PUT /v2.0/bgp-speakers/{bgp_speaker_id}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Update attributes of a BGP speaker."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_e1e84019","line":181,"in_reply_to":"5a3905b3_45af65e3","updated":"2017-01-19 10:01:38.000000000","message":"What is the comment here?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6512a68c8b307a09c2d8ace16971e8f0dedbf3e6","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Update BGP Speaker"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".. rest_method::  PUT /v2.0/bgp-speakers/{bgp_speaker_id}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Update attributes of a BGP speaker."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_3a2a3d2d","line":181,"in_reply_to":"5a3905b3_e1e84019","updated":"2017-01-20 03:27:46.000000000","message":"i meant the parameter description is missing.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":194,"context_line":"Delete BGP Speaker"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":".. rest_method::  DELETE /v2.0/bgp-speakers/{bgp_speaker_id}"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Normal response codes: 204"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_45968595","line":197,"updated":"2017-01-19 08:43:29.000000000","message":"- bgp_speaker_id: bgp_speaker_id","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":194,"context_line":"Delete BGP Speaker"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":".. rest_method::  DELETE /v2.0/bgp-speakers/{bgp_speaker_id}"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Normal response codes: 204"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_8aca23a0","line":197,"in_reply_to":"5a3905b3_45968595","updated":"2017-01-26 04:18:35.000000000","message":"Ditto","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":307,"context_line":"Remove BGP Peer from a BGP Speaker"},{"line_number":308,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":".. rest_method::  DELETE /v2.0/bgp-speakers/{bgp-speaker-id}/remove-bgp-peer"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Request Example"},{"line_number":313,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_c536f5b3","line":310,"range":{"start_line":310,"start_character":18,"end_line":310,"end_character":24},"updated":"2017-01-19 08:43:29.000000000","message":"isn\u0027t this PUT?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":307,"context_line":"Remove BGP Peer from a BGP Speaker"},{"line_number":308,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":".. rest_method::  DELETE /v2.0/bgp-speakers/{bgp-speaker-id}/remove-bgp-peer"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Request Example"},{"line_number":313,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_2abccf04","line":310,"range":{"start_line":310,"start_character":18,"end_line":310,"end_character":24},"in_reply_to":"5a3905b3_5e5e5346","updated":"2017-01-26 04:18:35.000000000","message":"Correct, this is PUT","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3854d490d9afad05db2c729dfcc30bbdc8ec81a","unresolved":false,"context_lines":[{"line_number":307,"context_line":"Remove BGP Peer from a BGP Speaker"},{"line_number":308,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":".. rest_method::  DELETE /v2.0/bgp-speakers/{bgp-speaker-id}/remove-bgp-peer"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Request Example"},{"line_number":313,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_5e5e5346","line":310,"range":{"start_line":310,"start_character":18,"end_line":310,"end_character":24},"in_reply_to":"5a3905b3_c536f5b3","updated":"2017-01-19 10:01:38.000000000","message":"+1","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":345,"context_line":"Delete Network from a BGP Speaker"},{"line_number":346,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":".. rest_method::  DELETE /v2.0/bgp-speakers/{bgp_speaker_id}/remove_gateway_network"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"Request Example"},{"line_number":351,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_2546d923","line":348,"range":{"start_line":348,"start_character":18,"end_line":348,"end_character":24},"updated":"2017-01-19 08:43:29.000000000","message":"PUT?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3854d490d9afad05db2c729dfcc30bbdc8ec81a","unresolved":false,"context_lines":[{"line_number":345,"context_line":"Delete Network from a BGP Speaker"},{"line_number":346,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":".. rest_method::  DELETE /v2.0/bgp-speakers/{bgp_speaker_id}/remove_gateway_network"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"Request Example"},{"line_number":351,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_9e58bb58","line":348,"range":{"start_line":348,"start_character":18,"end_line":348,"end_character":24},"in_reply_to":"5a3905b3_2546d923","updated":"2017-01-19 10:01:38.000000000","message":"+1","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":345,"context_line":"Delete Network from a BGP Speaker"},{"line_number":346,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":".. rest_method::  DELETE /v2.0/bgp-speakers/{bgp_speaker_id}/remove_gateway_network"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"Request Example"},{"line_number":351,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_aa46ff20","line":348,"range":{"start_line":348,"start_character":18,"end_line":348,"end_character":24},"in_reply_to":"5a3905b3_9e58bb58","updated":"2017-01-26 04:18:35.000000000","message":"Yep, PUT again","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":374,"context_line":"Error response codes: 404,401"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Add BGP Speaker to a Dynamic Routing Agent"},{"line_number":378,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":".. rest_method::  POST /v2.0/agents/{bgp_agent_id}/bgp-drinstances"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_05e71de5","line":377,"updated":"2017-01-19 08:43:29.000000000","message":"i prefer agent stuff separated.  but it might be only me.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3854d490d9afad05db2c729dfcc30bbdc8ec81a","unresolved":false,"context_lines":[{"line_number":374,"context_line":"Error response codes: 404,401"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Add BGP Speaker to a Dynamic Routing Agent"},{"line_number":378,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":".. rest_method::  POST /v2.0/agents/{bgp_agent_id}/bgp-drinstances"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_fe1c5f79","line":377,"in_reply_to":"5a3905b3_05e71de5","updated":"2017-01-19 10:01:38.000000000","message":"I would prefer to have it here..","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":374,"context_line":"Error response codes: 404,401"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Add BGP Speaker to a Dynamic Routing Agent"},{"line_number":378,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":".. rest_method::  POST /v2.0/agents/{bgp_agent_id}/bgp-drinstances"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_4a5e7bea","line":377,"in_reply_to":"5a3905b3_fe1c5f79","updated":"2017-01-26 04:18:35.000000000","message":"I think this probably should be spun out to a different file. These are 2 different extensions.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"02356e4bfa7290d44c0e9d9dd35c2e8d277bf577","unresolved":false,"context_lines":[{"line_number":428,"context_line":".. rest_method::  DELETE /v2.0/agents/{bgp_agent_id}/bgp-drinstances/{bgp_speaker_id}"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Normal response codes: 204"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"Error response codes: 404,401"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a3905b3_b1d2a6fe","line":431,"updated":"2017-01-20 20:52:55.000000000","message":"For those with no response body; would be nice to note that. Please see other api-refs for example.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":428,"context_line":".. rest_method::  DELETE /v2.0/agents/{bgp_agent_id}/bgp-drinstances/{bgp_speaker_id}"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Normal response codes: 204"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"Error response codes: 404,401"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"3a461143_8a5863fc","line":431,"in_reply_to":"5a3905b3_b1d2a6fe","updated":"2017-01-26 04:18:35.000000000","message":"Done","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"}],"api-ref/source/v2/index.rst":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3854d490d9afad05db2c729dfcc30bbdc8ec81a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"###################"},{"line_number":62,"context_line":"BGP Dynamic Routing"},{"line_number":63,"context_line":"###################"},{"line_number":64,"context_line":".. include:: bgp.inc"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5a3905b3_be4bb7af","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":20},"updated":"2017-01-19 10:01:38.000000000","message":"How about placing it inside \"Layer 3 Networking\"?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"50ddad10f9e11c7447fa0f14688b907369f7d8f1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"###################"},{"line_number":62,"context_line":"BGP Dynamic Routing"},{"line_number":63,"context_line":"###################"},{"line_number":64,"context_line":".. include:: bgp.inc"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a461143_c98044fa","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":20},"in_reply_to":"3a461143_aa143ff5","updated":"2017-01-30 06:23:47.000000000","message":"Ok","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"###################"},{"line_number":62,"context_line":"BGP Dynamic Routing"},{"line_number":63,"context_line":"###################"},{"line_number":64,"context_line":".. include:: bgp.inc"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a461143_aa143ff5","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":20},"in_reply_to":"5a3905b3_be4bb7af","updated":"2017-01-26 04:18:35.000000000","message":"This should be treated like LBAAS, QoS, etc. I think this is fine the way it is.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":2672,"context_line":"    Valid values are between 1 and 65535."},{"line_number":2673,"context_line":"  in: body"},{"line_number":2674,"context_line":"  required: true"},{"line_number":2675,"context_line":"  type: string"},{"line_number":2676,"context_line":"local_ep_group_id:"},{"line_number":2677,"context_line":"  description: |"},{"line_number":2678,"context_line":"    The ID for the endpoint group that contains"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a3905b3_ca78c2fb","line":2675,"range":{"start_line":2675,"start_character":8,"end_line":2675,"end_character":14},"updated":"2017-01-19 08:43:29.000000000","message":"integer?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":2672,"context_line":"    Valid values are between 1 and 65535."},{"line_number":2673,"context_line":"  in: body"},{"line_number":2674,"context_line":"  required: true"},{"line_number":2675,"context_line":"  type: string"},{"line_number":2676,"context_line":"local_ep_group_id:"},{"line_number":2677,"context_line":"  description: |"},{"line_number":2678,"context_line":"    The ID for the endpoint group that contains"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a461143_0a0473be","line":2675,"range":{"start_line":2675,"start_character":8,"end_line":2675,"end_character":14},"in_reply_to":"5a3905b3_ca78c2fb","updated":"2017-01-26 04:18:35.000000000","message":"Yep, good catch","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":3256,"context_line":"    A list of network UUID\u0027s."},{"line_number":3257,"context_line":"  in: body"},{"line_number":3258,"context_line":"  required: true"},{"line_number":3259,"context_line":"  type: string"},{"line_number":3260,"context_line":"network_ip_availabilities:"},{"line_number":3261,"context_line":"  description: |"},{"line_number":3262,"context_line":"    The ``network_ip_availabilities`` object."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a3905b3_4a6db231","line":3259,"range":{"start_line":3259,"start_character":8,"end_line":3259,"end_character":14},"updated":"2017-01-19 08:43:29.000000000","message":"array?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":3256,"context_line":"    A list of network UUID\u0027s."},{"line_number":3257,"context_line":"  in: body"},{"line_number":3258,"context_line":"  required: true"},{"line_number":3259,"context_line":"  type: string"},{"line_number":3260,"context_line":"network_ip_availabilities:"},{"line_number":3261,"context_line":"  description: |"},{"line_number":3262,"context_line":"    The ``network_ip_availabilities`` object."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a461143_6a3177a2","line":3259,"range":{"start_line":3259,"start_character":8,"end_line":3259,"end_character":14},"in_reply_to":"5a3905b3_4a6db231","updated":"2017-01-26 04:18:35.000000000","message":"Yes","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"}],"api-ref/source/v2/samples/bgp/bgp-peer-list-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"02356e4bfa7290d44c0e9d9dd35c2e8d277bf577","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"bgp_peers\":["},{"line_number":3,"context_line":"      {"},{"line_number":4,"context_line":"         \"auth_type\":\"none\","},{"line_number":5,"context_line":"         \"remote_as\":1001,"},{"line_number":6,"context_line":"         \"name\":\"bgp-peer\","},{"line_number":7,"context_line":"         \"peer_ip\":\"10.0.0.3\","},{"line_number":8,"context_line":"         \"id\":\"a7193581-a31c-4ea5-8218-b3052758461f\""},{"line_number":9,"context_line":"      }"},{"line_number":10,"context_line":"   ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":15,"id":"5a3905b3_51ba62c1","line":9,"range":{"start_line":2,"start_character":3,"end_line":9,"end_character":7},"updated":"2017-01-20 20:52:55.000000000","message":"Please check the json formatting; it\u0027s not consistent. This one has no space after the \u0027:\u0027 herein.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"bgp_peers\":["},{"line_number":3,"context_line":"      {"},{"line_number":4,"context_line":"         \"auth_type\":\"none\","},{"line_number":5,"context_line":"         \"remote_as\":1001,"},{"line_number":6,"context_line":"         \"name\":\"bgp-peer\","},{"line_number":7,"context_line":"         \"peer_ip\":\"10.0.0.3\","},{"line_number":8,"context_line":"         \"id\":\"a7193581-a31c-4ea5-8218-b3052758461f\""},{"line_number":9,"context_line":"      }"},{"line_number":10,"context_line":"   ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":15,"id":"3a461143_aa2b5f2f","line":9,"range":{"start_line":2,"start_character":3,"end_line":9,"end_character":7},"in_reply_to":"5a3905b3_51ba62c1","updated":"2017-01-26 04:18:35.000000000","message":"Done","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"}],"neutron_lib/api/definitions/bgp.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"803412e135cb1d2e96b5a67c6d344bc5f326383e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"BGP_EXT_ALIAS \u003d \u0027bgp\u0027"},{"line_number":22,"context_line":"BGP_SPEAKER_RESOURCE_NAME \u003d \u0027bgp-speaker\u0027"},{"line_number":23,"context_line":"BGP_SPEAKER_BODY_KEY_NAME \u003d \u0027bgp_speaker\u0027"},{"line_number":24,"context_line":"BGP_PEER_BODY_KEY_NAME \u003d \u0027bgp_peer\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# The alias of the extension."},{"line_number":27,"context_line":"ALIAS \u003d BGP_EXT_ALIAS"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_0eb97c15","line":24,"updated":"2016-12-09 23:45:47.000000000","message":"Please look at [1] to make sure all the right constants are provided. A suggestion is to add LABEL to use it as a key for plugin dictionary lookup, but it\u0027s a soft requirement.\n\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/_dummy.py","commit_id":"323fd175eeeba4ad251b8c42d16b5a7ae196f790"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8f2ff5448ddb40c46162fea14bdd104101aba4e1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"UPDATED_TIMESTAMP \u003d \u00272016-05-10T15:37:00-00:00\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":49,"context_line":"    BGP_SPEAKER_RESOURCE_NAME + \u0027s\u0027: {"},{"line_number":50,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":51,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":52,"context_line":"               \u0027is_visible\u0027: True, \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_dfc7d561","line":49,"updated":"2017-01-06 17:45:48.000000000","message":"As per the discussion in [1] it\u0027s still not clear how we\u0027re going to handle multiple resources in this attribute map.\n\n\n[1] https://review.openstack.org/#/c/394244/","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2f08a54549d0e1fbf6dad675806767c00849a324","unresolved":false,"context_lines":[{"line_number":46,"context_line":"UPDATED_TIMESTAMP \u003d \u00272016-05-10T15:37:00-00:00\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":49,"context_line":"    BGP_SPEAKER_RESOURCE_NAME + \u0027s\u0027: {"},{"line_number":50,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":51,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":52,"context_line":"               \u0027is_visible\u0027: True, \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_3b7c6eeb","line":49,"in_reply_to":"ba5201f7_dfc7d561","updated":"2017-01-06 21:43:33.000000000","message":"I\u0027ll take a look and diget that, thanks for the pointer.","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8f2ff5448ddb40c46162fea14bdd104101aba4e1","unresolved":false,"context_lines":[{"line_number":143,"context_line":"}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# The list of required extensions."},{"line_number":146,"context_line":"REQUIRED_EXTENSIONS \u003d None"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# The list of optional extensions."},{"line_number":149,"context_line":"OPTIONAL_EXTENSIONS \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_bff771d1","line":146,"updated":"2017-01-06 17:45:48.000000000","message":"Nit: these 2 attributes should be [] rather than None.","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2f08a54549d0e1fbf6dad675806767c00849a324","unresolved":false,"context_lines":[{"line_number":143,"context_line":"}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# The list of required extensions."},{"line_number":146,"context_line":"REQUIRED_EXTENSIONS \u003d None"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# The list of optional extensions."},{"line_number":149,"context_line":"OPTIONAL_EXTENSIONS \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_9b371a4c","line":146,"in_reply_to":"ba5201f7_bff771d1","updated":"2017-01-06 21:43:33.000000000","message":"Done","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1904e5044841d825664b10e96242f281c4b967f8","unresolved":false,"context_lines":[{"line_number":149,"context_line":"OPTIONAL_EXTENSIONS \u003d []"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def get_resource_attribute_map():"},{"line_number":153,"context_line":"    return RESOURCE_ATTRIBUTE_MAP"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_26cee7b4","line":152,"updated":"2017-01-09 14:38:19.000000000","message":"this is not needed.","commit_id":"7f422f47495e05a833e222037b99525f671b9ac4"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"02356e4bfa7290d44c0e9d9dd35c2e8d277bf577","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                     \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":80,"context_line":"                     \u0027required_by_policy\u0027: False,"},{"line_number":81,"context_line":"                     \u0027enforce_policy\u0027: True},"},{"line_number":82,"context_line":"        \u0027advertise_floating_ip_host_routes\u0027: {"},{"line_number":83,"context_line":"            \u0027allow_post\u0027: True,"},{"line_number":84,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":85,"context_line":"            \u0027convert_to\u0027: n_conv.convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_5178a28f","line":82,"range":{"start_line":82,"start_character":9,"end_line":82,"end_character":42},"updated":"2017-01-20 20:52:55.000000000","message":"Not familiar with this extension, but does this imply it depends on the l3/router extension for floating IP support?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                     \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":80,"context_line":"                     \u0027required_by_policy\u0027: False,"},{"line_number":81,"context_line":"                     \u0027enforce_policy\u0027: True},"},{"line_number":82,"context_line":"        \u0027advertise_floating_ip_host_routes\u0027: {"},{"line_number":83,"context_line":"            \u0027allow_post\u0027: True,"},{"line_number":84,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":85,"context_line":"            \u0027convert_to\u0027: n_conv.convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_0af2b3d2","line":82,"range":{"start_line":82,"start_character":9,"end_line":82,"end_character":42},"in_reply_to":"5a3905b3_5178a28f","updated":"2017-01-26 04:18:35.000000000","message":"Yes, it does. Should probably add l3/router extension to OPTIONAL_EXTENSIONS. People can implement the extension without the l3/router extension.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a6761854aaca49341242b52ce5fdbf4546076e84","unresolved":false,"context_lines":[{"line_number":46,"context_line":"UPDATED_TIMESTAMP \u003d \u00272016-05-10T15:37:00-00:00\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":49,"context_line":"    BGP_SPEAKER_RESOURCE_NAME + \u0027s\u0027: {"},{"line_number":50,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":51,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":52,"context_line":"               \u0027is_visible\u0027: True, \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa31d9ce_07e8bbb3","line":49,"range":{"start_line":49,"start_character":29,"end_line":49,"end_character":35},"updated":"2017-02-13 05:32:30.000000000","message":"maybe it\u0027s better to have xxx_COLLECTION_NAME constant rather than playing with \"+\".","commit_id":"61d9871d460063c54ece6c3fe6d6e53e741848e5"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"b6a88a646ee151f56de1e3f874561bdef571a705","unresolved":false,"context_lines":[{"line_number":46,"context_line":"UPDATED_TIMESTAMP \u003d \u00272016-05-10T15:37:00-00:00\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":49,"context_line":"    BGP_SPEAKER_RESOURCE_NAME + \u0027s\u0027: {"},{"line_number":50,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":51,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":52,"context_line":"               \u0027is_visible\u0027: True, \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":16,"id":"dfeb2761_d6c42243","line":49,"range":{"start_line":49,"start_character":29,"end_line":49,"end_character":35},"in_reply_to":"fa31d9ce_07e8bbb3","updated":"2017-03-30 20:51:52.000000000","message":"Done","commit_id":"61d9871d460063c54ece6c3fe6d6e53e741848e5"}],"neutron_lib/api/definitions/bgp_dragentscheduler.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"8daf4effa9082f9ed00e6c157b9543f5e40e4241","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# The action map."},{"line_number":43,"context_line":"ACTION_MAP \u003d {"},{"line_number":44,"context_line":"    \u0027agents\u0027: {"},{"line_number":45,"context_line":"        \u0027bgp-speakers\u0027: {"},{"line_number":46,"context_line":"            \u0027add_bgp_speaker_to_dragent\u0027: \u0027PUT\u0027,"},{"line_number":47,"context_line":"            \u0027remove_bgp_speaker_from_dragent\u0027: \u0027PUT\u0027,"},{"line_number":48,"context_line":"            \u0027list_dragent_hosting_bgp_speaker\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_527d50e6","line":45,"range":{"start_line":45,"start_character":9,"end_line":45,"end_character":21},"updated":"2017-01-09 22:10:46.000000000","message":"Should be \u0027bgp-drinstances\u0027","commit_id":"bef3b24d4c209a36434de9ca914a79c087d8847f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dde632bf73b44cc68022e357d23afcac7df980f0","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# The subresource attribute map for the extension.  This extension has only"},{"line_number":43,"context_line":"# top level resources, not child resources, so this is set to an empty dict."},{"line_number":44,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# The action map."}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_c36bbbb7","line":44,"updated":"2017-01-12 00:37:08.000000000","message":"the missing attribute map and testcase seems troubling. This extension with its own wsgi controllers may be a bit of a special case though. I\u0027ll ponder on this some more.","commit_id":"f39f1bb02a7d436d1f2c75cc0a7e9743aed847ce"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"be6ce1061dd044f2412f120101134b982739477f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# The subresource attribute map for the extension.  This extension has only"},{"line_number":43,"context_line":"# top level resources, not child resources, so this is set to an empty dict."},{"line_number":44,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# The action map."}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_54d623c6","line":44,"in_reply_to":"ba5201f7_c36bbbb7","updated":"2017-01-12 18:03:24.000000000","message":"The missing attribute map is an oversight. This extension doesn\u0027t add any attributes, I simply forgot to declare the empty map.\n\nStill noodling on a test case, no attributes are added to any resources by this extension. Some guidance on how to test that case would be helpful.","commit_id":"f39f1bb02a7d436d1f2c75cc0a7e9743aed847ce"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e736049c1de4aaad36aa065338525c9b5a4c1f0d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# The action map."},{"line_number":51,"context_line":"ACTION_MAP \u003d {"},{"line_number":52,"context_line":"    \u0027agents\u0027: {"},{"line_number":53,"context_line":"        \u0027bgp-drinstances\u0027: {"},{"line_number":54,"context_line":"            \u0027add_bgp_speaker_to_dragent\u0027: \u0027POST\u0027,"},{"line_number":55,"context_line":"            \u0027remove_bgp_speaker_from_dragent\u0027: \u0027DELETE\u0027,"},{"line_number":56,"context_line":"            \u0027list_bgp_speaker_on_dragent\u0027: \u0027GET\u0027"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# The list of required extensions."},{"line_number":62,"context_line":"REQUIRED_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_46f2a670","line":59,"range":{"start_line":51,"start_character":0,"end_line":59,"end_character":1},"updated":"2017-01-20 20:32:17.000000000","message":"not sure how this would be mapped on the existing API implementation [1]. If there any way we can revisit [1] to be declarative defined the way other APIs are? Was there any reason why wsgi controllers were defined this way (I suspect dhcp/l3 agents were used as an example)?\n\n[1] https://github.com/openstack/neutron-dynamic-routing/blob/master/neutron_dynamic_routing/extensions/bgp_dragentscheduler.py","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"02356e4bfa7290d44c0e9d9dd35c2e8d277bf577","unresolved":false,"context_lines":[{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# The action map."},{"line_number":51,"context_line":"ACTION_MAP \u003d {"},{"line_number":52,"context_line":"    \u0027agents\u0027: {"},{"line_number":53,"context_line":"        \u0027bgp-drinstances\u0027: {"},{"line_number":54,"context_line":"            \u0027add_bgp_speaker_to_dragent\u0027: \u0027POST\u0027,"},{"line_number":55,"context_line":"            \u0027remove_bgp_speaker_from_dragent\u0027: \u0027DELETE\u0027,"},{"line_number":56,"context_line":"            \u0027list_bgp_speaker_on_dragent\u0027: \u0027GET\u0027"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# The list of required extensions."},{"line_number":62,"context_line":"REQUIRED_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_b1c5468f","line":59,"range":{"start_line":51,"start_character":0,"end_line":59,"end_character":1},"in_reply_to":"5a3905b3_46f2a670","updated":"2017-01-20 20:52:55.000000000","message":"+1","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# The action map."},{"line_number":51,"context_line":"ACTION_MAP \u003d {"},{"line_number":52,"context_line":"    \u0027agents\u0027: {"},{"line_number":53,"context_line":"        \u0027bgp-drinstances\u0027: {"},{"line_number":54,"context_line":"            \u0027add_bgp_speaker_to_dragent\u0027: \u0027POST\u0027,"},{"line_number":55,"context_line":"            \u0027remove_bgp_speaker_from_dragent\u0027: \u0027DELETE\u0027,"},{"line_number":56,"context_line":"            \u0027list_bgp_speaker_on_dragent\u0027: \u0027GET\u0027"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# The list of required extensions."},{"line_number":62,"context_line":"REQUIRED_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_caceeb82","line":59,"range":{"start_line":51,"start_character":0,"end_line":59,"end_character":1},"in_reply_to":"5a3905b3_b1c5468f","updated":"2017-01-26 04:18:35.000000000","message":"I was not a fan of setting up the wsgi controllers in this way. I basically derived this from existing docs and my knowledge of the API. I\u0027m not sure why it was defined that way. Do we need to change that extension at this point? The descriptor will ultimately reside here.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# The list of required extensions."},{"line_number":62,"context_line":"REQUIRED_EXTENSIONS \u003d []"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# The list of optional extensions."},{"line_number":65,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_85206df9","line":62,"range":{"start_line":62,"start_character":22,"end_line":62,"end_character":24},"updated":"2017-01-19 08:43:29.000000000","message":"bgp and agents?","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# The list of required extensions."},{"line_number":62,"context_line":"REQUIRED_EXTENSIONS \u003d []"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# The list of optional extensions."},{"line_number":65,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_eacba770","line":62,"range":{"start_line":62,"start_character":22,"end_line":62,"end_character":24},"in_reply_to":"5a3905b3_06aa5e70","updated":"2017-01-26 04:18:35.000000000","message":"Yes, this is an oversight.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7970a7608d83ff30a41a011ab46a3d792beaf8d9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# The list of required extensions."},{"line_number":62,"context_line":"REQUIRED_EXTENSIONS \u003d []"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# The list of optional extensions."},{"line_number":65,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_06aa5e70","line":62,"range":{"start_line":62,"start_character":22,"end_line":62,"end_character":24},"in_reply_to":"5a3905b3_85206df9","updated":"2017-01-20 20:26:51.000000000","message":"+1, it looks like this is missing from the original definition.","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a6761854aaca49341242b52ce5fdbf4546076e84","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# The action map."},{"line_number":51,"context_line":"ACTION_MAP \u003d {"},{"line_number":52,"context_line":"    \u0027agents\u0027: {"},{"line_number":53,"context_line":"        \u0027bgp-drinstances\u0027: {"},{"line_number":54,"context_line":"            \u0027add_bgp_speaker_to_dragent\u0027: \u0027POST\u0027,"},{"line_number":55,"context_line":"            \u0027remove_bgp_speaker_from_dragent\u0027: \u0027DELETE\u0027,"},{"line_number":56,"context_line":"            \u0027list_bgp_speaker_on_dragent\u0027: \u0027GET\u0027"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"fa31d9ce_47f9d37f","line":57,"range":{"start_line":53,"start_character":0,"end_line":57,"end_character":9},"updated":"2017-02-13 05:32:30.000000000","message":"i wonder why this is not a sub resource.","commit_id":"61d9871d460063c54ece6c3fe6d6e53e741848e5"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"b6a88a646ee151f56de1e3f874561bdef571a705","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# The action map."},{"line_number":51,"context_line":"ACTION_MAP \u003d {"},{"line_number":52,"context_line":"    \u0027agents\u0027: {"},{"line_number":53,"context_line":"        \u0027bgp-drinstances\u0027: {"},{"line_number":54,"context_line":"            \u0027add_bgp_speaker_to_dragent\u0027: \u0027POST\u0027,"},{"line_number":55,"context_line":"            \u0027remove_bgp_speaker_from_dragent\u0027: \u0027DELETE\u0027,"},{"line_number":56,"context_line":"            \u0027list_bgp_speaker_on_dragent\u0027: \u0027GET\u0027"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dfeb2761_f6f5e684","line":57,"range":{"start_line":53,"start_character":0,"end_line":57,"end_character":9},"in_reply_to":"fa31d9ce_47f9d37f","updated":"2017-03-30 20:51:52.000000000","message":"I wasn\u0027t sure how to express the equivalent of ACTION_MAP. It does seem that a subresource is the way to go.","commit_id":"61d9871d460063c54ece6c3fe6d6e53e741848e5"}],"neutron_lib/api/definitions/constants.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dde632bf73b44cc68022e357d23afcac7df980f0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# BGP Constants"},{"line_number":17,"context_line":"BGP_MIN_ASNUM \u003d 1"},{"line_number":18,"context_line":"BGP_MAX_ASNUM \u003d 65535"},{"line_number":19,"context_line":"BGP_SUPPORTED_AUTH_TYPES \u003d [\u0027none\u0027, \u0027md5\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_a3531716","line":16,"range":{"start_line":16,"start_character":3,"end_line":16,"end_character":15},"updated":"2017-01-12 00:37:08.000000000","message":"this is gonna clash with https://review.openstack.org/#/c/389388/","commit_id":"f39f1bb02a7d436d1f2c75cc0a7e9743aed847ce"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"be6ce1061dd044f2412f120101134b982739477f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# BGP Constants"},{"line_number":17,"context_line":"BGP_MIN_ASNUM \u003d 1"},{"line_number":18,"context_line":"BGP_MAX_ASNUM \u003d 65535"},{"line_number":19,"context_line":"BGP_SUPPORTED_AUTH_TYPES \u003d [\u0027none\u0027, \u0027md5\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_f462b715","line":16,"range":{"start_line":16,"start_character":3,"end_line":16,"end_character":15},"in_reply_to":"ba5201f7_a3531716","updated":"2017-01-12 18:03:24.000000000","message":"Yes it will, whoever merges first wins I guess :)\n\nIn all seriousness, could we introduce this file in another review that both of these are dependent on? I saw that too, dealing with the merge conflict won\u0027t be too scary at this point so I was thinking we just play a game of merge chicken for now.","commit_id":"f39f1bb02a7d436d1f2c75cc0a7e9743aed847ce"}],"neutron_lib/constants.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8f2ff5448ddb40c46162fea14bdd104101aba4e1","unresolved":false,"context_lines":[{"line_number":251,"context_line":"IPV6_SLAAC \u003d \u0027slaac\u0027"},{"line_number":252,"context_line":"IPV6_MODES \u003d [DHCPV6_STATEFUL, DHCPV6_STATELESS, IPV6_SLAAC]"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"# BGP Constants"},{"line_number":255,"context_line":"BGP_MIN_ASNUM \u003d 1"},{"line_number":256,"context_line":"BGP_MAX_ASNUM \u003d 65535"},{"line_number":257,"context_line":"BGP_SUPPORTED_AUTH_TYPES \u003d [\u0027none\u0027, \u0027md5\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_5faf657c","line":254,"updated":"2017-01-06 17:45:48.000000000","message":"Not sure how I feel about putting api-def specific constants into this top-level constants.py. I was thinking maybe we have a module such as neutron_lib.api.definitions.constants.py for that purpose. We were discussing this somewhere, but I\u0027ll need to dig up where.","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2f08a54549d0e1fbf6dad675806767c00849a324","unresolved":false,"context_lines":[{"line_number":251,"context_line":"IPV6_SLAAC \u003d \u0027slaac\u0027"},{"line_number":252,"context_line":"IPV6_MODES \u003d [DHCPV6_STATEFUL, DHCPV6_STATELESS, IPV6_SLAAC]"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"# BGP Constants"},{"line_number":255,"context_line":"BGP_MIN_ASNUM \u003d 1"},{"line_number":256,"context_line":"BGP_MAX_ASNUM \u003d 65535"},{"line_number":257,"context_line":"BGP_SUPPORTED_AUTH_TYPES \u003d [\u0027none\u0027, \u0027md5\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_dbd9a2f4","line":254,"in_reply_to":"ba5201f7_114951d0","updated":"2017-01-06 21:43:33.000000000","message":"Good idea. Perhaps I can introduce that new module here, I think that makes a lot of sense. I\u0027d like to see the constants put in the same place, but as you point out the top-level constants.py may not be the appropriate place.","commit_id":"6266574287fea5e34e77f89733500139e344529b"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"85efa9af0ce51c8068b85b060c039e371aeb997c","unresolved":false,"context_lines":[{"line_number":251,"context_line":"IPV6_SLAAC \u003d \u0027slaac\u0027"},{"line_number":252,"context_line":"IPV6_MODES \u003d [DHCPV6_STATEFUL, DHCPV6_STATELESS, IPV6_SLAAC]"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"# BGP Constants"},{"line_number":255,"context_line":"BGP_MIN_ASNUM \u003d 1"},{"line_number":256,"context_line":"BGP_MAX_ASNUM \u003d 65535"},{"line_number":257,"context_line":"BGP_SUPPORTED_AUTH_TYPES \u003d [\u0027none\u0027, \u0027md5\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_114951d0","line":254,"in_reply_to":"ba5201f7_5faf657c","updated":"2017-01-06 18:05:52.000000000","message":"It was here: https://review.openstack.org/#/c/389388/20/neutron_lib/api/definitions/firewall_common.py","commit_id":"6266574287fea5e34e77f89733500139e344529b"}],"releasenotes/notes/bgp-api-definitions-f9be3f4c203aac12.yaml":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"acc2010d8cc8e1c79c71165e73589b34768983b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    - Adds BGP dynamic routing API definitions to neutron-lib."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a3905b3_4554c553","line":3,"updated":"2017-01-19 08:43:29.000000000","message":"better to mention extension names as well","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2bd650291ac1b204193338ab2b1b500bde7245f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    - Adds BGP dynamic routing API definitions to neutron-lib."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a461143_2ac68f67","line":3,"in_reply_to":"5a3905b3_4554c553","updated":"2017-01-26 04:18:35.000000000","message":"Done","commit_id":"82a18e11b8633b1c8d667ec9eb45a8a0e49792c2"}]}
