)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"880f3bf514fc307ed7b7095095fd484e950137ed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-30 18:14:45 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync latest neutron callbacks into lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates neutron_lib._context with the latest"},{"line_number":10,"context_line":"from neutron prior to publishing the module for wider"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_1ace4b83","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":29},"updated":"2016-12-01 02:27:28.000000000","message":"context","commit_id":"4add29d657e0c29233309b52035d4dd239a8bfde"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f6f8d4e94d04cc202ff999bcdb71ec250abf381a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-30 18:14:45 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync latest neutron callbacks into lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates neutron_lib._context with the latest"},{"line_number":10,"context_line":"from neutron prior to publishing the module for wider"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_60b94e2e","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":29},"in_reply_to":"5a74a57a_1ace4b83","updated":"2016-12-01 03:28:44.000000000","message":"where did this come from? deja vu...","commit_id":"4add29d657e0c29233309b52035d4dd239a8bfde"}],"neutron_lib/_context.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"027292e32d12325246bd49f93b5f2835c6c7afb2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                   roles\u003dvalues.get(\u0027roles\u0027),"},{"line_number":98,"context_line":"                   timestamp\u003dvalues.get(\u0027timestamp\u0027),"},{"line_number":99,"context_line":"                   request_id\u003dvalues.get(\u0027request_id\u0027),"},{"line_number":100,"context_line":"                   tenant_name\u003dvalues.get(\u0027tenant_name\u0027),"},{"line_number":101,"context_line":"                   user_name\u003dvalues.get(\u0027user_name\u0027),"},{"line_number":102,"context_line":"                   auth_token\u003dvalues.get(\u0027auth_token\u0027))"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_7bda217a","line":100,"range":{"start_line":100,"start_character":43,"end_line":100,"end_character":54},"updated":"2016-12-01 14:39:33.000000000","message":"I\u0027m trying to understand why tenant_id and project_id are returned but no tenant_name and project_name.","commit_id":"7f6571062792ff0264dd0d6a190b580ce5f35849"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"98ebfdeced316397baec4da9ace2a90dcf68aebf","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                   roles\u003dvalues.get(\u0027roles\u0027),"},{"line_number":98,"context_line":"                   timestamp\u003dvalues.get(\u0027timestamp\u0027),"},{"line_number":99,"context_line":"                   request_id\u003dvalues.get(\u0027request_id\u0027),"},{"line_number":100,"context_line":"                   tenant_name\u003dvalues.get(\u0027tenant_name\u0027),"},{"line_number":101,"context_line":"                   user_name\u003dvalues.get(\u0027user_name\u0027),"},{"line_number":102,"context_line":"                   auth_token\u003dvalues.get(\u0027auth_token\u0027))"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_410f9787","line":100,"range":{"start_line":100,"start_character":43,"end_line":100,"end_character":54},"in_reply_to":"3a71b18c_1c3cc092","updated":"2016-12-06 03:16:57.000000000","message":"It seems like this function is only called by the initialization method of the osprofiler[1] which uses for creation[2] of drivers[3], maybe a messaging driver[4].  So, my conclusion is that this change is fine, but maybe OSProfiler is receiving more arguments than needed.\n\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/common/profiler.py#L39\n[2] https://github.com/openstack/osprofiler/blob/master/osprofiler/drivers/base.py#L41\n[3] https://github.com/openstack/osprofiler/blob/master/osprofiler/drivers/base.py#L56-L63\n[4] https://github.com/openstack/osprofiler/blob/master/osprofiler/drivers/messaging.py#L20-L33","commit_id":"7f6571062792ff0264dd0d6a190b580ce5f35849"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9732787a460e50eca89baec3f36d2785c2a81e74","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                   roles\u003dvalues.get(\u0027roles\u0027),"},{"line_number":98,"context_line":"                   timestamp\u003dvalues.get(\u0027timestamp\u0027),"},{"line_number":99,"context_line":"                   request_id\u003dvalues.get(\u0027request_id\u0027),"},{"line_number":100,"context_line":"                   tenant_name\u003dvalues.get(\u0027tenant_name\u0027),"},{"line_number":101,"context_line":"                   user_name\u003dvalues.get(\u0027user_name\u0027),"},{"line_number":102,"context_line":"                   auth_token\u003dvalues.get(\u0027auth_token\u0027))"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_1c3cc092","line":100,"range":{"start_line":100,"start_character":43,"end_line":100,"end_character":54},"in_reply_to":"3a71b18c_7bda217a","updated":"2016-12-01 16:11:37.000000000","message":"please let me know, this is how the neutron\u0027s replica is like","commit_id":"7f6571062792ff0264dd0d6a190b580ce5f35849"}]}
