)]}'
{"neutron_lib/constants.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"56c2b59db1600e42835e8cd3cf34d9bf7353c440","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"IPv6_LLA_PREFIX \u003d \u0027fe80::/64\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"DHCP_RESPONSE_PORT \u003d 68"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"FLOODING_ENTRY \u003d (\u002700:00:00:00:00:00\u0027, \u00270.0.0.0\u0027)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_9da175ac","side":"PARENT","line":96,"updated":"2016-12-02 13:59:47.000000000","message":"We can\u0027t remove things without a deprecation period, plus this is used in the neutron code base.","commit_id":"12e5f53e53efce682eb4a442fd9ad9b1af281ce2"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"f60e261aee615afbfe4c9014ef46aa0f5f960f4a","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"IPv6_LLA_PREFIX \u003d \u0027fe80::/64\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"DHCP_RESPONSE_PORT \u003d 68"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"FLOODING_ENTRY \u003d (\u002700:00:00:00:00:00\u0027, \u00270.0.0.0\u0027)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_6bb2e207","side":"PARENT","line":96,"in_reply_to":"3a71b18c_3e96693f","updated":"2016-12-05 07:03:00.000000000","message":"ok, thx for your remind:)","commit_id":"12e5f53e53efce682eb4a442fd9ad9b1af281ce2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"42009ab67eced16cbedf5d5153b2f72a8469f4ef","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"IPv6_LLA_PREFIX \u003d \u0027fe80::/64\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"DHCP_RESPONSE_PORT \u003d 68"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"FLOODING_ENTRY \u003d (\u002700:00:00:00:00:00\u0027, \u00270.0.0.0\u0027)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_3e96693f","side":"PARENT","line":96,"in_reply_to":"3a71b18c_9da175ac","updated":"2016-12-05 05:34:17.000000000","message":"+1","commit_id":"12e5f53e53efce682eb4a442fd9ad9b1af281ce2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"44808a6e258680891cbea8d7728caf207b78edff","unresolved":false,"context_lines":[{"line_number":168,"context_line":"PROTO_NUM_UDPLITE \u003d 136"},{"line_number":169,"context_line":"PROTO_NUM_VRRP \u003d 112"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"ARP_OP_TYPE_REQUEST \u003d 1"},{"line_number":172,"context_line":"ARP_OP_TYPE_REPLY \u003d 2"},{"line_number":173,"context_line":"DHCP_CLIENT_PORT \u003d 68"},{"line_number":174,"context_line":"DHCP_SERVER_PORT \u003d 67"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_b7bad0df","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":19},"updated":"2016-12-02 13:29:15.000000000","message":"dragonflow is the only project I see using this [1]. Our current targets are networking-ovn and neutron-dynamic-routing. That said I\u0027m not seeing the justification to move this over. Can you please clarify.\n\n\n[1] http://codesearch.openstack.org/?q\u003dARP_OP_TYPE_REQUEST\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"4d9b80625890404b3ea8836234cb3152134b6af5"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"44808a6e258680891cbea8d7728caf207b78edff","unresolved":false,"context_lines":[{"line_number":169,"context_line":"PROTO_NUM_VRRP \u003d 112"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"ARP_OP_TYPE_REQUEST \u003d 1"},{"line_number":172,"context_line":"ARP_OP_TYPE_REPLY \u003d 2"},{"line_number":173,"context_line":"DHCP_CLIENT_PORT \u003d 68"},{"line_number":174,"context_line":"DHCP_SERVER_PORT \u003d 67"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_97723448","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":17},"updated":"2016-12-02 13:29:15.000000000","message":"I don\u0027t see this even defined [1]. What\u0027s the justification for putting it in lib?\n\n\n[1] http://codesearch.openstack.org/?q\u003dARP_OP_TYPE_REPLY\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"4d9b80625890404b3ea8836234cb3152134b6af5"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"44808a6e258680891cbea8d7728caf207b78edff","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"ARP_OP_TYPE_REQUEST \u003d 1"},{"line_number":172,"context_line":"ARP_OP_TYPE_REPLY \u003d 2"},{"line_number":173,"context_line":"DHCP_CLIENT_PORT \u003d 68"},{"line_number":174,"context_line":"DHCP_SERVER_PORT \u003d 67"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"IP_PROTOCOL_MAP \u003d {PROTO_NAME_AH: PROTO_NUM_AH,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_37cb2055","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":16},"updated":"2016-12-02 13:29:15.000000000","message":"Also not used by ovn or dynamic routing [1], but perhaps justifiable given dragonflow + cisco uses it.\n\n\n[1] http://codesearch.openstack.org/?q\u003dDHCP_CLIENT_PORT\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"4d9b80625890404b3ea8836234cb3152134b6af5"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"b90905e6eee699da9241b86e08dccc570cf479fa","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"ARP_OP_TYPE_REQUEST \u003d 1"},{"line_number":172,"context_line":"ARP_OP_TYPE_REPLY \u003d 2"},{"line_number":173,"context_line":"DHCP_CLIENT_PORT \u003d 68"},{"line_number":174,"context_line":"DHCP_SERVER_PORT \u003d 67"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"IP_PROTOCOL_MAP \u003d {PROTO_NAME_AH: PROTO_NUM_AH,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_e6c0fc7e","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":16},"in_reply_to":"3a71b18c_37cb2055","updated":"2016-12-03 12:45:13.000000000","message":"thx for your reply, I just want to add some common protocol constant values into lib which dragonflow could reuse them, the related patch is:\nhttps://review.openstack.org/#/c/405226/","commit_id":"4d9b80625890404b3ea8836234cb3152134b6af5"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"44808a6e258680891cbea8d7728caf207b78edff","unresolved":false,"context_lines":[{"line_number":171,"context_line":"ARP_OP_TYPE_REQUEST \u003d 1"},{"line_number":172,"context_line":"ARP_OP_TYPE_REPLY \u003d 2"},{"line_number":173,"context_line":"DHCP_CLIENT_PORT \u003d 68"},{"line_number":174,"context_line":"DHCP_SERVER_PORT \u003d 67"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"IP_PROTOCOL_MAP \u003d {PROTO_NAME_AH: PROTO_NUM_AH,"},{"line_number":177,"context_line":"                   PROTO_NAME_DCCP: PROTO_NUM_DCCP,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_57cdfc5b","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":16},"updated":"2016-12-02 13:29:15.000000000","message":"Same comment as the client port. http://codesearch.openstack.org/?q\u003dDHCP_SERVER_PORT\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"4d9b80625890404b3ea8836234cb3152134b6af5"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fd43f34385abc0e25397230dafd4fcc81250febd","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"IPv6_LLA_PREFIX \u003d \u0027fe80::/64\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# Todo(hujie) delete this once neutron accept the renamed constants"},{"line_number":97,"context_line":"DHCP_RESPONSE_PORT \u003d 68"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# Rename the dhcp client and server port"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_7b195022","line":96,"range":{"start_line":96,"start_character":2,"end_line":96,"end_character":13},"updated":"2016-12-07 14:38:07.000000000","message":"Please use \u0027TODO(hujie)\u0027 as per: http://docs.openstack.org/developer/hacking/#general","commit_id":"a5b99e55376e5f6e31354f0b62da85911e6bda7d"}]}
