)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"24ce2b8df5d0a3493b1f1d317d29ccd47d33f11e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Carver \u003cpcarver@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-30 09:10:43 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add API definition for networking-sfc subproject"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds API definition for networking-sfc."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dfeb2761_dd59c7fe","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2017-03-31 12:58:10.000000000","message":"If this patch is ready for review can we please remove the \u0027WIP\u0027 indication?","commit_id":"caa99378b934e91ed3539dcf403599a255dc0e72"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"70eb93486e4a4abdaa026a210b4d2e7da582a305","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Carver \u003cpcarver@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-30 09:10:43 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add API definition for networking-sfc subproject"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds API definition for networking-sfc."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ff52f3f_5a1ee20c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"dfeb2761_dd59c7fe","updated":"2017-04-13 14:14:31.000000000","message":"Done","commit_id":"caa99378b934e91ed3539dcf403599a255dc0e72"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"726a3d1fbd89ba680416ce21a4c84a8fb2e7183b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Thomas Morin \u003cthomas.morin@orange.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-22 22:28:50 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u0027sfc\u0027 and \u0027flowclassifier\u0027 API extension definitions (networking-sfc)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds the API definitions for the \u0027sfc\u0027 and \u0027flow_classifier\u0027 API"},{"line_number":10,"context_line":"extensions from networking-sfc."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"df7087c5_2585a35a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":69},"updated":"2018-03-23 10:05:12.000000000","message":"Hi Thomas, can you add the servicegraph extension too please?","commit_id":"80d89528ba514a4e143d57d585ad816a6a974687"}],"neutron_lib/api/converters.py":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"55bbae8e42961b278a6492dda55c5e6ebabef683","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    \"\"\"Convert value to default if value is None."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    :param value: The value to convert."},{"line_number":141,"context_line":"    :returns: default if \u0027value\u0027 is None, otherwise \u0027value\u0027."},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    return value if value else default"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_f71de20f","line":141,"range":{"start_line":141,"start_character":25,"end_line":141,"end_character":32},"updated":"2017-03-23 23:07:12.000000000","message":"Hmm these single quotes don\u0027t look right..","commit_id":"8e1c2e0d9a9bac6d8a3ccb1766868a683e19c57f"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"83f12b313513302ff4434f0523f7f2645a3d8fc6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    \"\"\"Convert value to default if value is None."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    :param value: The value to convert."},{"line_number":141,"context_line":"    :returns: default if \u0027value\u0027 is None, otherwise \u0027value\u0027."},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    return value if value else default"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_93287ce2","line":141,"range":{"start_line":141,"start_character":25,"end_line":141,"end_character":32},"in_reply_to":"ffe62b97_d8b2a3e6","updated":"2017-03-27 16:19:09.000000000","message":"Yes, the \u0027default\u0027, this is just a nit anyway.","commit_id":"8e1c2e0d9a9bac6d8a3ccb1766868a683e19c57f"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6798ad6fcd6bc4266b5b00425f50e6f4f5871132","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    \"\"\"Convert value to default if value is None."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    :param value: The value to convert."},{"line_number":141,"context_line":"    :returns: default if \u0027value\u0027 is None, otherwise \u0027value\u0027."},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    return value if value else default"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_d8b2a3e6","line":141,"range":{"start_line":141,"start_character":25,"end_line":141,"end_character":32},"in_reply_to":"ffe62b97_f71de20f","updated":"2017-03-27 16:08:30.000000000","message":"Why not? I think I\u0027m using them exactly the same way as on line 150 or 159. Maybe I should quote \u0027default\u0027 for consistency.","commit_id":"8e1c2e0d9a9bac6d8a3ccb1766868a683e19c57f"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6798ad6fcd6bc4266b5b00425f50e6f4f5871132","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \"\"\"Convert value to an empty list if it\u0027s None."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    :param value: The value to convert."},{"line_number":150,"context_line":"    :returns: An empty list of \u0027value\u0027 is None, otherwise \u0027value\u0027."},{"line_number":151,"context_line":"    \"\"\""},{"line_number":152,"context_line":"    return [] if value is None else value"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_18b92bcb","line":150,"range":{"start_line":150,"start_character":28,"end_line":150,"end_character":30},"updated":"2017-03-27 16:08:30.000000000","message":"Does anybody mind if I correct this unrelated typo in this change? I just noticed that this should say \"if\" rather than \"of\".","commit_id":"8e1c2e0d9a9bac6d8a3ccb1766868a683e19c57f"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d08ff1b414c7ddcbe4f65a9be81292277d0c2966","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        raise n_exc.InvalidInput(error_message\u003derror_message)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def convert_to_protocol_if_not_none(data):"},{"line_number":267,"context_line":"    \"\"\"Uses convert_to_protocol() on the data if the data is not None."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    :param data: The data value to convert."}],"source_content_type":"text/x-python","patch_set":13,"id":"ff6b8bd7_11edd0ee","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":42},"updated":"2018-03-06 03:52:11.000000000","message":"What\u0027s different from convert_to_protocol? The convert_to_protocol checks None as well.","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee2b52baec67654076fbb1d13cf5ff01a3e6e173","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        raise n_exc.InvalidInput(error_message\u003derror_message)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def convert_to_protocol_if_not_none(data):"},{"line_number":267,"context_line":"    \"\"\"Uses convert_to_protocol() on the data if the data is not None."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    :param data: The data value to convert."}],"source_content_type":"text/x-python","patch_set":13,"id":"ff6b8bd7_23faff41","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":42},"in_reply_to":"ff6b8bd7_11edd0ee","updated":"2018-03-06 14:08:45.000000000","message":"Seems to be the case to me as well; unless I\u0027m missing something.","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b213bbe347ed8ed7bb38139c76c5368f58bf77c9","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        raise n_exc.InvalidInput(error_message\u003derror_message)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def convert_to_protocol_if_not_none(data):"},{"line_number":267,"context_line":"    \"\"\"Uses convert_to_protocol() on the data if the data is not None."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    :param data: The data value to convert."}],"source_content_type":"text/x-python","patch_set":13,"id":"df7087c5_f042b43d","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":42},"in_reply_to":"ff6b8bd7_23faff41","updated":"2018-03-16 13:46:37.000000000","message":"You\u0027re right folks.\nDunno why I didn\u0027t see that.\nThanks.","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e7e2de9334c39353e9498f6b9869aeba7d79a103","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        return str(data)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"def convert_uppercase_prefix(data, prefix):"},{"line_number":278,"context_line":"    \"\"\"Uppercase \u003cprefix\u003e if present at start of data (case insensitive)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    :param data: The data to convert"}],"source_content_type":"text/x-python","patch_set":31,"id":"9f6a8fd7_395802f9","line":277,"updated":"2018-04-26 18:35:11.000000000","message":"How about a few UTs?","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e7e2de9334c39353e9498f6b9869aeba7d79a103","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    :returns: if data is a string starting with \u003cprefix\u003e case insensitive, then"},{"line_number":282,"context_line":"              the return value is data with the first two letter uppercased"},{"line_number":283,"context_line":"    \"\"\""},{"line_number":284,"context_line":"    # uppercase \"IP\" if data is a string starting with \"ip\" case insensitive"},{"line_number":285,"context_line":"    if (isinstance(data, six.string_types) and"},{"line_number":286,"context_line":"            data[0:2].lower() \u003d\u003d prefix.lower()):"},{"line_number":287,"context_line":"        return data[0:2].upper() + data[2:]"}],"source_content_type":"text/x-python","patch_set":31,"id":"9f6a8fd7_19465e23","line":284,"updated":"2018-04-26 18:35:11.000000000","message":"Not sure this comment applies to this generic function.","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"f977730152a9651127c55267de331b7fbc3d8249","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    :returns: if data is a string starting with \u003cprefix\u003e case insensitive, then"},{"line_number":282,"context_line":"              the return value is data with the first two letter uppercased"},{"line_number":283,"context_line":"    \"\"\""},{"line_number":284,"context_line":"    # uppercase \"IP\" if data is a string starting with \"ip\" case insensitive"},{"line_number":285,"context_line":"    if (isinstance(data, six.string_types) and"},{"line_number":286,"context_line":"            data[0:2].lower() \u003d\u003d prefix.lower()):"},{"line_number":287,"context_line":"        return data[0:2].upper() + data[2:]"}],"source_content_type":"text/x-python","patch_set":31,"id":"9f6a8fd7_3e653be2","line":284,"in_reply_to":"9f6a8fd7_19465e23","updated":"2018-04-27 09:20:49.000000000","message":"Done","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e7e2de9334c39353e9498f6b9869aeba7d79a103","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    \"\"\""},{"line_number":284,"context_line":"    # uppercase \"IP\" if data is a string starting with \"ip\" case insensitive"},{"line_number":285,"context_line":"    if (isinstance(data, six.string_types) and"},{"line_number":286,"context_line":"            data[0:2].lower() \u003d\u003d prefix.lower()):"},{"line_number":287,"context_line":"        return data[0:2].upper() + data[2:]"},{"line_number":288,"context_line":"    return data"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"9f6a8fd7_795e7aea","line":286,"range":{"start_line":286,"start_character":19,"end_line":286,"end_character":20},"updated":"2018-04-26 18:35:11.000000000","message":"I think this needs to be using the len of the prefix rather than the static value 2.","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"f977730152a9651127c55267de331b7fbc3d8249","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    \"\"\""},{"line_number":284,"context_line":"    # uppercase \"IP\" if data is a string starting with \"ip\" case insensitive"},{"line_number":285,"context_line":"    if (isinstance(data, six.string_types) and"},{"line_number":286,"context_line":"            data[0:2].lower() \u003d\u003d prefix.lower()):"},{"line_number":287,"context_line":"        return data[0:2].upper() + data[2:]"},{"line_number":288,"context_line":"    return data"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"9f6a8fd7_7e73b3b2","line":286,"range":{"start_line":286,"start_character":19,"end_line":286,"end_character":20},"in_reply_to":"9f6a8fd7_795e7aea","updated":"2018-04-27 09:20:49.000000000","message":"Done","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2ada841e878ca6213fcb123727c982c8d1c22c43","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    * \u0027FOObaz\u0027 converted into \u0027Foobaz\u0027"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    :param data: The data to convert"},{"line_number":288,"context_line":"    :returns: if data is a string starting with \u003cprefix\u003e in a case insensitive"},{"line_number":289,"context_line":"              comparison, then the return value is data with this prefix"},{"line_number":290,"context_line":"              replaced by \u003cprefix\u003e"},{"line_number":291,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":32,"id":"9f6a8fd7_61d8f37e","line":288,"range":{"start_line":288,"start_character":14,"end_line":288,"end_character":15},"updated":"2018-04-27 13:07:44.000000000","message":"Nit: case","commit_id":"a508fa127c070b25070535e8c26a18f14165f611"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2ada841e878ca6213fcb123727c982c8d1c22c43","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    Can be used for instance to accept both \"ipv4\" and \"IPv4\"."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    :param data: The data to convert"},{"line_number":305,"context_line":"    :returns: if data is a string starting with \"ip\" case insensitive, then"},{"line_number":306,"context_line":"              the return value is data with the first two letter uppercased"},{"line_number":307,"context_line":"    \"\"\""},{"line_number":308,"context_line":"    return convert_prefix_forced_case(data, \"IP\")"}],"source_content_type":"text/x-python","patch_set":32,"id":"9f6a8fd7_01e57738","line":305,"range":{"start_line":305,"start_character":14,"end_line":305,"end_character":15},"updated":"2018-04-27 13:07:44.000000000","message":"Nit: case","commit_id":"a508fa127c070b25070535e8c26a18f14165f611"}],"neutron_lib/api/definitions/constants.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9837ac49a6db4c6063c2b8811874767aec934a3d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                \u0027symmetric\u0027: SFC_DEFAULT_CHAIN_SYMMETRY}"},{"line_number":40,"context_line":"SFC_DEFAULT_SF_PARAMETERS \u003d {\u0027correlation\u0027: None, \u0027weight\u0027: 1}"},{"line_number":41,"context_line":"SFC_DEFAULT_PPG_PARAMETERS \u003d {\u0027lb_fields\u0027: []}"},{"line_number":42,"context_line":"SFC_SUPPORTED_LB_FIELDS \u003d ["},{"line_number":43,"context_line":"    \"eth_src\", \"eth_dst\", \"ip_src\", \"ip_dst\","},{"line_number":44,"context_line":"    \"tcp_src\", \"tcp_dst\", \"udp_src\", \"udp_dst\""},{"line_number":45,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_d34f4390","line":42,"range":{"start_line":42,"start_character":14,"end_line":42,"end_character":16},"updated":"2017-05-19 11:37:54.000000000","message":"What does \u0027LB\u0027 mean? In the neutron/networking world, there are several words which use \u0027lb\u0027 as abbrev: linux bridge, load balancer, .....","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e81a229f78513936704198465722872ce1cebd2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                \u0027symmetric\u0027: SFC_DEFAULT_CHAIN_SYMMETRY}"},{"line_number":40,"context_line":"SFC_DEFAULT_SF_PARAMETERS \u003d {\u0027correlation\u0027: None, \u0027weight\u0027: 1}"},{"line_number":41,"context_line":"SFC_DEFAULT_PPG_PARAMETERS \u003d {\u0027lb_fields\u0027: []}"},{"line_number":42,"context_line":"SFC_SUPPORTED_LB_FIELDS \u003d ["},{"line_number":43,"context_line":"    \"eth_src\", \"eth_dst\", \"ip_src\", \"ip_dst\","},{"line_number":44,"context_line":"    \"tcp_src\", \"tcp_dst\", \"udp_src\", \"udp_dst\""},{"line_number":45,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_b7bab4de","line":42,"range":{"start_line":42,"start_character":14,"end_line":42,"end_character":16},"in_reply_to":"ff0f0b1f_46b4e5f1","updated":"2017-05-26 04:19:05.000000000","message":"I am okay If it is clear to all folks in the SFC community.\nThe API definition already uses \u0027lb_fields\u0027 so it looks an obvious thing in SFC community (including users?).\n\nIf you keep \u0027LB\u0027, some comment would be nice.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b213bbe347ed8ed7bb38139c76c5368f58bf77c9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                \u0027symmetric\u0027: SFC_DEFAULT_CHAIN_SYMMETRY}"},{"line_number":40,"context_line":"SFC_DEFAULT_SF_PARAMETERS \u003d {\u0027correlation\u0027: None, \u0027weight\u0027: 1}"},{"line_number":41,"context_line":"SFC_DEFAULT_PPG_PARAMETERS \u003d {\u0027lb_fields\u0027: []}"},{"line_number":42,"context_line":"SFC_SUPPORTED_LB_FIELDS \u003d ["},{"line_number":43,"context_line":"    \"eth_src\", \"eth_dst\", \"ip_src\", \"ip_dst\","},{"line_number":44,"context_line":"    \"tcp_src\", \"tcp_dst\", \"udp_src\", \"udp_dst\""},{"line_number":45,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_4f53de39","line":42,"range":{"start_line":42,"start_character":14,"end_line":42,"end_character":16},"in_reply_to":"ff0f0b1f_b7bab4de","updated":"2018-03-16 13:46:37.000000000","message":"Done","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f7ed3ae341eaac6229dbe46224d0baff1b3f5e23","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                \u0027symmetric\u0027: SFC_DEFAULT_CHAIN_SYMMETRY}"},{"line_number":40,"context_line":"SFC_DEFAULT_SF_PARAMETERS \u003d {\u0027correlation\u0027: None, \u0027weight\u0027: 1}"},{"line_number":41,"context_line":"SFC_DEFAULT_PPG_PARAMETERS \u003d {\u0027lb_fields\u0027: []}"},{"line_number":42,"context_line":"SFC_SUPPORTED_LB_FIELDS \u003d ["},{"line_number":43,"context_line":"    \"eth_src\", \"eth_dst\", \"ip_src\", \"ip_dst\","},{"line_number":44,"context_line":"    \"tcp_src\", \"tcp_dst\", \"udp_src\", \"udp_dst\""},{"line_number":45,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_46b4e5f1","line":42,"range":{"start_line":42,"start_character":14,"end_line":42,"end_character":16},"in_reply_to":"ff0f0b1f_d34f4390","updated":"2017-05-25 11:29:28.000000000","message":"It stands for load balance and refers to spreading traffic across port pairs in a port pair group. Is there a convention for length of variable names? SFC_SUPPORTED_LOADBALANCING_FIELDS seems like it might be excessively long. Should I just add a comment instead of changing the name?","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"}],"neutron_lib/api/definitions/flowclassifier.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee2b52baec67654076fbb1d13cf5ff01a3e6e173","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron_lib.db import constants as db_const"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# The alias of the extension."},{"line_number":21,"context_line":"ALIAS \u003d \u0027flowclassifier\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# The label to lookup the plugin in the plugin directory. It can match the"},{"line_number":24,"context_line":"# alias, as required."}],"source_content_type":"text/x-python","patch_set":13,"id":"ff6b8bd7_5e9fcc4f","line":21,"range":{"start_line":21,"start_character":9,"end_line":21,"end_character":23},"updated":"2018-03-06 14:08:45.000000000","message":"According to the extension, this should be flow_classifier","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee2b52baec67654076fbb1d13cf5ff01a3e6e173","unresolved":false,"context_lines":[{"line_number":63,"context_line":"PORT_MAX \u003d 2**16 - 1"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def convert_uppercase_ip(value):"},{"line_number":67,"context_line":"    # uppercase \"IP\" if value is a string starting with \"ip\" case insensitive"},{"line_number":68,"context_line":"    if isinstance(value, six.string_types) and value[0:2].lower() \u003d\u003d \"ip\":"},{"line_number":69,"context_line":"        return value[0:2].upper() + value[2:]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff6b8bd7_9eeb24af","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":24},"updated":"2018-03-06 14:08:45.000000000","message":"I think this should go into the converters module if its needed.","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d32659e2fc09ce951dafab8dbc5bd553ac3d24df","unresolved":false,"context_lines":[{"line_number":63,"context_line":"PORT_MAX \u003d 2**16 - 1"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def convert_uppercase_ip(value):"},{"line_number":67,"context_line":"    # uppercase \"IP\" if value is a string starting with \"ip\" case insensitive"},{"line_number":68,"context_line":"    if isinstance(value, six.string_types) and value[0:2].lower() \u003d\u003d \"ip\":"},{"line_number":69,"context_line":"        return value[0:2].upper() + value[2:]"}],"source_content_type":"text/x-python","patch_set":13,"id":"df7087c5_b593a500","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":24},"in_reply_to":"df7087c5_75266d6b","updated":"2018-03-22 21:33:59.000000000","message":"I don\u0027t really have a strong opinion that one.\nStill, can you expand on why you think so...?","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"859b9bc1bfb8388fd30df859f257128d7e55812d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"PORT_MAX \u003d 2**16 - 1"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def convert_uppercase_ip(value):"},{"line_number":67,"context_line":"    # uppercase \"IP\" if value is a string starting with \"ip\" case insensitive"},{"line_number":68,"context_line":"    if isinstance(value, six.string_types) and value[0:2].lower() \u003d\u003d \"ip\":"},{"line_number":69,"context_line":"        return value[0:2].upper() + value[2:]"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf659307_68fa0f43","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":24},"in_reply_to":"df7087c5_8b683df5","updated":"2018-03-26 07:55:40.000000000","message":"Ok.\n\nConverters don\u0027t seem to offer a way to add parameters, but the next PS has a generalized method that can be used to build similar converters to uppercase a prefix.","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cbdbb9e45ad9a3b27f2b31ec6a8dc1d114f96c69","unresolved":false,"context_lines":[{"line_number":63,"context_line":"PORT_MAX \u003d 2**16 - 1"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def convert_uppercase_ip(value):"},{"line_number":67,"context_line":"    # uppercase \"IP\" if value is a string starting with \"ip\" case insensitive"},{"line_number":68,"context_line":"    if isinstance(value, six.string_types) and value[0:2].lower() \u003d\u003d \"ip\":"},{"line_number":69,"context_line":"        return value[0:2].upper() + value[2:]"}],"source_content_type":"text/x-python","patch_set":13,"id":"df7087c5_75266d6b","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":24},"in_reply_to":"df7087c5_903c9893","updated":"2018-03-19 13:21:45.000000000","message":"I tend to disagree and still think this should go into converters.","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"193b448d38a537ff98c84a5062b9dd1a5d0fcc6c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"PORT_MAX \u003d 2**16 - 1"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def convert_uppercase_ip(value):"},{"line_number":67,"context_line":"    # uppercase \"IP\" if value is a string starting with \"ip\" case insensitive"},{"line_number":68,"context_line":"    if isinstance(value, six.string_types) and value[0:2].lower() \u003d\u003d \"ip\":"},{"line_number":69,"context_line":"        return value[0:2].upper() + value[2:]"}],"source_content_type":"text/x-python","patch_set":13,"id":"df7087c5_8b683df5","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":24},"in_reply_to":"df7087c5_b593a500","updated":"2018-03-23 12:31:18.000000000","message":"Today we don\u0027t have a single converter in the API defs and have made an effort to that end; make converter generic and put them in the converters module. I don\u0027t see this being a special case of that rule. Perhaps this can be made generic to accept a prefix to convert and could be used here like:\n\n   \u0027convert_to\u0027: converters.convert_uppercase_prefix(\u0027ip\u0027)","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b213bbe347ed8ed7bb38139c76c5368f58bf77c9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"PORT_MAX \u003d 2**16 - 1"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def convert_uppercase_ip(value):"},{"line_number":67,"context_line":"    # uppercase \"IP\" if value is a string starting with \"ip\" case insensitive"},{"line_number":68,"context_line":"    if isinstance(value, six.string_types) and value[0:2].lower() \u003d\u003d \"ip\":"},{"line_number":69,"context_line":"        return value[0:2].upper() + value[2:]"}],"source_content_type":"text/x-python","patch_set":13,"id":"df7087c5_903c9893","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":24},"in_reply_to":"ff6b8bd7_9eeb24af","updated":"2018-03-16 13:46:37.000000000","message":"It seems to me that this is a very particular behavior for sfc, where we want to preserve what has been implemented until now.\n\nIf we were to design an API from scratch I don\u0027t believe we would choose to use a parameter definition allowing uppercase/lowercase variations.\n\nFor this reason it seems better to me to *not* put this in a place that encourages code reuse.","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee2b52baec67654076fbb1d13cf5ff01a3e6e173","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \u0027ethertype\u0027: {"},{"line_number":97,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":98,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: \"IPv4\","},{"line_number":99,"context_line":"            \u0027validate\u0027: {\u0027type:values\u0027: [\"IPv4\", \"IPv6\"]},"},{"line_number":100,"context_line":"            \u0027convert_to\u0027: convert_uppercase_ip},"},{"line_number":101,"context_line":"        \u0027protocol\u0027: {"},{"line_number":102,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff6b8bd7_be05c87c","line":99,"range":{"start_line":99,"start_character":40,"end_line":99,"end_character":56},"updated":"2018-03-06 14:08:45.000000000","message":"Can\u0027t we just use fc_supported_ethertypes here?","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b213bbe347ed8ed7bb38139c76c5368f58bf77c9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \u0027ethertype\u0027: {"},{"line_number":97,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":98,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: \"IPv4\","},{"line_number":99,"context_line":"            \u0027validate\u0027: {\u0027type:values\u0027: [\"IPv4\", \"IPv6\"]},"},{"line_number":100,"context_line":"            \u0027convert_to\u0027: convert_uppercase_ip},"},{"line_number":101,"context_line":"        \u0027protocol\u0027: {"},{"line_number":102,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":13,"id":"df7087c5_d04d303b","line":99,"range":{"start_line":99,"start_character":40,"end_line":99,"end_character":56},"in_reply_to":"ff6b8bd7_be05c87c","updated":"2018-03-16 13:46:37.000000000","message":"Done","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cbdbb9e45ad9a3b27f2b31ec6a8dc1d114f96c69","unresolved":false,"context_lines":[{"line_number":51,"context_line":"UPDATED_TIMESTAMP \u003d \"2015-10-05T10:00:00-00:00\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"fc_supported_ethertypes \u003d [\u0027IPv4\u0027, \u0027IPv6\u0027]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"RESOURCE_NAME \u003d \u0027flow_classifier\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_b503a5be","line":54,"range":{"start_line":54,"start_character":27,"end_line":54,"end_character":41},"updated":"2018-03-19 13:21:45.000000000","message":"Why can\u0027t we ref constants.IPv4 and constants.IPv6 here?","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d32659e2fc09ce951dafab8dbc5bd553ac3d24df","unresolved":false,"context_lines":[{"line_number":51,"context_line":"UPDATED_TIMESTAMP \u003d \"2015-10-05T10:00:00-00:00\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"fc_supported_ethertypes \u003d [\u0027IPv4\u0027, \u0027IPv6\u0027]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"RESOURCE_NAME \u003d \u0027flow_classifier\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_358795b9","line":54,"range":{"start_line":54,"start_character":27,"end_line":54,"end_character":41},"in_reply_to":"df7087c5_b503a5be","updated":"2018-03-22 21:33:59.000000000","message":"Sure.","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cbdbb9e45ad9a3b27f2b31ec6a8dc1d114f96c69","unresolved":false,"context_lines":[{"line_number":58,"context_line":"COLLECTION_NAME \u003d \u0027flow_classifiers\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# max value for a TCP or UDP port"},{"line_number":61,"context_line":"PORT_MAX \u003d 2**16 - 1"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def convert_uppercase_ip(value):"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_55f489cf","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":8},"updated":"2018-03-19 13:21:45.000000000","message":"Does this make sense as a general constant rather than something sfc def specific?","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d32659e2fc09ce951dafab8dbc5bd553ac3d24df","unresolved":false,"context_lines":[{"line_number":58,"context_line":"COLLECTION_NAME \u003d \u0027flow_classifiers\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# max value for a TCP or UDP port"},{"line_number":61,"context_line":"PORT_MAX \u003d 2**16 - 1"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def convert_uppercase_ip(value):"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_756bcdf0","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":8},"in_reply_to":"df7087c5_55f489cf","updated":"2018-03-22 21:33:59.000000000","message":"Yes.\n\nMy work-in-progress patch set actually has this change, because the value end up to be needed both in sfc.py and flowclassifier.py .","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cbdbb9e45ad9a3b27f2b31ec6a8dc1d114f96c69","unresolved":false,"context_lines":[{"line_number":61,"context_line":"PORT_MAX \u003d 2**16 - 1"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def convert_uppercase_ip(value):"},{"line_number":65,"context_line":"    # uppercase \"IP\" if value is a string starting with \"ip\" case insensitive"},{"line_number":66,"context_line":"    if isinstance(value, six.string_types) and value[0:2].lower() \u003d\u003d \"ip\":"},{"line_number":67,"context_line":"        return value[0:2].upper() + value[2:]"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_95e0e1fc","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":24},"updated":"2018-03-19 13:21:45.000000000","message":"I tend to disagree that this is sfc specific and should live here...","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"}],"neutron_lib/api/definitions/sfc.py":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"55bbae8e42961b278a6492dda55c5e6ebabef683","unresolved":false,"context_lines":[{"line_number":42,"context_line":"UPDATED_TIMESTAMP \u003d \"2015-10-05T10:00:00-00:00\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\u0027\u0027\u0027"},{"line_number":46,"context_line":"def validate_list_of_allowed_values(data, allowed_values\u003dNone):"},{"line_number":47,"context_line":"    if not isinstance(data, list):"},{"line_number":48,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a list\") % data"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_97bb36e4","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":3},"updated":"2017-03-23 23:07:12.000000000","message":"...?","commit_id":"8e1c2e0d9a9bac6d8a3ccb1766868a683e19c57f"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6798ad6fcd6bc4266b5b00425f50e6f4f5871132","unresolved":false,"context_lines":[{"line_number":42,"context_line":"UPDATED_TIMESTAMP \u003d \"2015-10-05T10:00:00-00:00\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\u0027\u0027\u0027"},{"line_number":46,"context_line":"def validate_list_of_allowed_values(data, allowed_values\u003dNone):"},{"line_number":47,"context_line":"    if not isinstance(data, list):"},{"line_number":48,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a list\") % data"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_18648b21","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":3},"in_reply_to":"ffe62b97_97bb36e4","updated":"2017-03-27 16:08:30.000000000","message":"This change is still a work in progress. I\u0027m using triple quotes to comment out parts that I originally copied in from [1]. Eventually I will remove all the triple quoted stuff, but the RESOURCE_ATTRIBUTE_MAP in [1] uses SFC specific converters that throw SFC specific exceptions so I started by copying everything in.\n\nAt the moment this fails tox. I need to either eliminate the SFC specific converters and exceptions or bring some or all of them into neutron-lib.\n\n[1] https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py","commit_id":"8e1c2e0d9a9bac6d8a3ccb1766868a683e19c57f"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9f68475e7011210f9b6894c99bb4b4a3eda217da","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                        \u0027convert_to\u0027: lib_converters.convert_to_int"},{"line_number":207,"context_line":"                    }"},{"line_number":208,"context_line":"                }"},{"line_number":209,"context_line":"            },"},{"line_number":210,"context_line":"        }"},{"line_number":211,"context_line":"    },"},{"line_number":212,"context_line":"    api_const.SFC_PORT_CHAINS: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_fb4e736d","line":209,"updated":"2017-03-27 20:49:25.000000000","message":"Relative to [1] I have completely deleted the \u0027convert_to\u0027 key because the function it calls simply replaces None with DEFAULT_SF_PARAMETERS which appears to already be taken care of on lines 198 and 203 by the \u0027default\u0027 keys.\n\nhttps://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py","commit_id":"e2c5eeac8a26e2a4fb3531c8e2910b1efe9bfba3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9f68475e7011210f9b6894c99bb4b4a3eda217da","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                        \u0027convert_to\u0027: lib_converters.convert_to_boolean"},{"line_number":265,"context_line":"                    }"},{"line_number":266,"context_line":"                }"},{"line_number":267,"context_line":"            },"},{"line_number":268,"context_line":"        }"},{"line_number":269,"context_line":"    },"},{"line_number":270,"context_line":"    api_const.SFC_PORT_PAIR_GROUPS: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_7b9943c2","line":267,"updated":"2017-03-27 20:49:25.000000000","message":"Relative to [1] in the preceding comment I have completely deleted the \u0027convert_to\u0027 key because the function normalize_chain_parameters simply populates the \u0027correlation\u0027 and \u0027symmetric\u0027 if they are missing with the default values. This should already be taken care of by lines 259 and 263","commit_id":"e2c5eeac8a26e2a4fb3531c8e2910b1efe9bfba3"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9f68475e7011210f9b6894c99bb4b4a3eda217da","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                    }"},{"line_number":313,"context_line":"                }"},{"line_number":314,"context_line":"            },"},{"line_number":315,"context_line":"            \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS"},{"line_number":316,"context_line":"        }"},{"line_number":317,"context_line":"    }"},{"line_number":318,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_7bc70398","line":315,"updated":"2017-03-27 20:49:25.000000000","message":"Relative to [1] mentioned above I changed \u0027convert_to\u0027 to \u0027default\u0027 and replaced the function normalize_ppg_parameters with the constant that the function would return if the parameter being validated were None.","commit_id":"e2c5eeac8a26e2a4fb3531c8e2910b1efe9bfba3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"24ce2b8df5d0a3493b1f1d317d29ccd47d33f11e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dfeb2761_e05980fe","updated":"2017-03-31 12:58:10.000000000","message":"We appear to be missing a UT for this def.","commit_id":"caa99378b934e91ed3539dcf403599a255dc0e72"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"70eb93486e4a4abdaa026a210b4d2e7da582a305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9ff52f3f_da32f2a7","in_reply_to":"dfeb2761_e05980fe","updated":"2017-04-13 14:14:31.000000000","message":"Partially done. I\u0027ve added a UT but it isn\u0027t passing yet. Honestly I don\u0027t really understand how exactly unit tests for API definitions work so I\u0027m doing some trial and error. I\u0027ll push a patch set with the not yet working UT.","commit_id":"caa99378b934e91ed3539dcf403599a255dc0e72"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"cb2c1eb395d339a74cde0427d538f514024db269","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        \u0027convert_to\u0027: lib_converters.convert_to_int"},{"line_number":95,"context_line":"                    }"},{"line_number":96,"context_line":"                }"},{"line_number":97,"context_line":"            },"},{"line_number":98,"context_line":"        }"},{"line_number":99,"context_line":"    },"},{"line_number":100,"context_line":"    api_const.SFC_PORT_CHAINS: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_580cba3a","line":97,"updated":"2017-03-30 13:14:26.000000000","message":"Relative to [1] I have completely deleted the \u0027convert_to\u0027 key because the function it calls simply replaces None with DEFAULT_SF_PARAMETERS which appears to already be taken care of on lines 198 and 203 by the \u0027default\u0027 keys.\n\n[1] https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py","commit_id":"caa99378b934e91ed3539dcf403599a255dc0e72"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"cb2c1eb395d339a74cde0427d538f514024db269","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                        \u0027convert_to\u0027: lib_converters.convert_to_boolean"},{"line_number":153,"context_line":"                    }"},{"line_number":154,"context_line":"                }"},{"line_number":155,"context_line":"            },"},{"line_number":156,"context_line":"        }"},{"line_number":157,"context_line":"    },"},{"line_number":158,"context_line":"    api_const.SFC_PORT_PAIR_GROUPS: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_f81a6e6d","line":155,"updated":"2017-03-30 13:14:26.000000000","message":"Relative to [1] in the preceding comment I have completely deleted the \u0027convert_to\u0027 key because the function normalize_chain_parameters simply populates the \u0027correlation\u0027 and \u0027symmetric\u0027 if they are missing with the default values. This should already be taken care of by lines 259 and 263","commit_id":"caa99378b934e91ed3539dcf403599a255dc0e72"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"4d24dd3d5b90ce30a5f3ba5dc41ced01ca37e714","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                        \u0027convert_to\u0027: lib_converters.convert_to_boolean"},{"line_number":153,"context_line":"                    }"},{"line_number":154,"context_line":"                }"},{"line_number":155,"context_line":"            },"},{"line_number":156,"context_line":"        }"},{"line_number":157,"context_line":"    },"},{"line_number":158,"context_line":"    api_const.SFC_PORT_PAIR_GROUPS: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_253f9787","line":155,"in_reply_to":"ffe62b97_f81a6e6d","updated":"2017-05-02 10:23:16.000000000","message":"I\u0027m going back from patchset 7 to understand if the lack of concert_to is troubling. Where are lines 259 and 263?","commit_id":"caa99378b934e91ed3539dcf403599a255dc0e72"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"cb2c1eb395d339a74cde0427d538f514024db269","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                    }"},{"line_number":201,"context_line":"                }"},{"line_number":202,"context_line":"            },"},{"line_number":203,"context_line":"            \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS"},{"line_number":204,"context_line":"        }"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_d817aa45","line":203,"updated":"2017-03-30 13:14:26.000000000","message":"Relative to [1] mentioned above I changed \u0027convert_to\u0027 to \u0027default\u0027 and replaced the function normalize_ppg_parameters with the constant that the function would return if the parameter being validated were None.","commit_id":"caa99378b934e91ed3539dcf403599a255dc0e72"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"1070db06242fd6cc3591ed9cd36f124a8928615a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":131,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":132,"context_line":"            \u0027validate\u0027: {\u0027type:uuid_list\u0027: None},"},{"line_number":133,"context_line":"            \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS"},{"line_number":134,"context_line":"        },"},{"line_number":135,"context_line":"        \u0027flow_classifiers\u0027: {"},{"line_number":136,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_66962241","line":133,"range":{"start_line":133,"start_character":23,"end_line":133,"end_character":59},"updated":"2017-04-20 13:21:25.000000000","message":"Typo error here probably this i snot the correct default? (default is empty, so you can drop this line)\nDropping this, the UT also passes if I had back \u0027port_pair_groups\u0027 to the attributes test list (with the comment below)","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"888592fc301d9f8afb90fc7b0c883a9c7c228869","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":131,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":132,"context_line":"            \u0027validate\u0027: {\u0027type:uuid_list\u0027: None},"},{"line_number":133,"context_line":"            \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS"},{"line_number":134,"context_line":"        },"},{"line_number":135,"context_line":"        \u0027flow_classifiers\u0027: {"},{"line_number":136,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_dc5dc647","line":133,"range":{"start_line":133,"start_character":23,"end_line":133,"end_character":59},"in_reply_to":"7ffa3b31_66962241","updated":"2017-04-20 15:33:19.000000000","message":"For consistency with the ppg resource\u0027s port_pairs attribute, default would be None here.\n\nThe default you specified is for the ppg parameters of the ppg resource.","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5c82213db178400660ad13c105a4f80d714eaa82","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":131,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":132,"context_line":"            \u0027validate\u0027: {\u0027type:uuid_list\u0027: None},"},{"line_number":133,"context_line":"            \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS"},{"line_number":134,"context_line":"        },"},{"line_number":135,"context_line":"        \u0027flow_classifiers\u0027: {"},{"line_number":136,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_158b166e","line":133,"range":{"start_line":133,"start_character":23,"end_line":133,"end_character":59},"in_reply_to":"7ffa3b31_dc5dc647","updated":"2017-04-27 12:37:03.000000000","message":"Done","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"1070db06242fd6cc3591ed9cd36f124a8928615a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                    }"},{"line_number":201,"context_line":"                }"},{"line_number":202,"context_line":"            },"},{"line_number":203,"context_line":"            \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS"},{"line_number":204,"context_line":"        }"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_c6d4d6eb","line":203,"updated":"2017-04-20 13:21:25.000000000","message":"UT fails here as this default is a complex type \"{\u0027lb_fields\u0027: []}\"\nIs this needed, as the validate section before also checks the lb_fields default subfield?","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"26ce721a700bc3fbca084761fec5459db1756059","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                    }"},{"line_number":201,"context_line":"                }"},{"line_number":202,"context_line":"            },"},{"line_number":203,"context_line":"            \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS"},{"line_number":204,"context_line":"        }"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_057ffb65","line":203,"in_reply_to":"5ff73747_758ffa74","updated":"2017-05-02 10:23:21.000000000","message":"And it was there already, so default was duplicated at this point.","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5c82213db178400660ad13c105a4f80d714eaa82","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                    }"},{"line_number":201,"context_line":"                }"},{"line_number":202,"context_line":"            },"},{"line_number":203,"context_line":"            \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS"},{"line_number":204,"context_line":"        }"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_758ffa74","line":203,"in_reply_to":"7ffa3b31_af32baf0","updated":"2017-04-27 12:37:03.000000000","message":"Done","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"888592fc301d9f8afb90fc7b0c883a9c7c228869","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                    }"},{"line_number":201,"context_line":"                }"},{"line_number":202,"context_line":"            },"},{"line_number":203,"context_line":"            \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS"},{"line_number":204,"context_line":"        }"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_af32baf0","line":203,"in_reply_to":"7ffa3b31_c6d4d6eb","updated":"2017-04-20 15:33:19.000000000","message":"Looking at the other resources\u0027 parameters, default here should simply be None.","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"03a1fddde7f128d56c56d06551624594a808d647","unresolved":false,"context_lines":[{"line_number":214,"context_line":"# The action map."},{"line_number":215,"context_line":"ACTION_MAP \u003d {"},{"line_number":216,"context_line":"}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"# The list of required extensions."},{"line_number":219,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":220,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_efaefbe5","line":217,"updated":"2017-04-24 23:37:41.000000000","message":"This needs ACTION_STATUS[1] although it may be empty.\n\n[1]: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/_dummy.py#L114","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5c82213db178400660ad13c105a4f80d714eaa82","unresolved":false,"context_lines":[{"line_number":214,"context_line":"# The action map."},{"line_number":215,"context_line":"ACTION_MAP \u003d {"},{"line_number":216,"context_line":"}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"# The list of required extensions."},{"line_number":219,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":220,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_d5ceceb2","line":217,"in_reply_to":"5ff73747_efaefbe5","updated":"2017-04-27 12:37:03.000000000","message":"Done","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d81ac867b748dbb7785f560730fc701a2392aad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5ff73747_4572feae","updated":"2017-04-27 17:46:49.000000000","message":"There are also a bunch of exceptions in the sfc extn [1]. If any of those are public and potentially used by consumers of the extension then they should also be included under neutron_lib.exceptions.sfc.py.\n\n\n[1] https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py#L71","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f1066de632aa66a669057a8e85bb03d519b81637","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3f044301_3e674528","in_reply_to":"5ff73747_2c5d3be9","updated":"2017-05-08 12:36:26.000000000","message":"If the exceptions are public facing and you expect them to be used by consumers the best place is here in neutron-lib.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9c63abb90bb6bc57dce234fa1e9f311c7f811744","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5ff73747_2c5d3be9","in_reply_to":"5ff73747_4572feae","updated":"2017-05-02 13:37:08.000000000","message":"I tried to minimize the amount of SFC specific stuff I brought in to neutron-lib, but I can copy and paste them in if that\u0027s what\u0027s desired.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d81ac867b748dbb7785f560730fc701a2392aad3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        },"},{"line_number":80,"context_line":"        \u0027service_function_parameters\u0027: {"},{"line_number":81,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":82,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":83,"context_line":"            \u0027validate\u0027: {"},{"line_number":84,"context_line":"                \u0027type:dict\u0027: {"},{"line_number":85,"context_line":"                    \u0027correlation\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_fa22c9b8","line":82,"updated":"2017-04-27 17:46:49.000000000","message":"What about the \u0027convert_to\u0027: normalize_sf_parameters from [1]; isn\u0027t that needed?\n\n\n[1] https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py#L214","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d01b412f3bc9ddb30c0b3db23f0ed72a6defaaa5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        },"},{"line_number":80,"context_line":"        \u0027service_function_parameters\u0027: {"},{"line_number":81,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":82,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":83,"context_line":"            \u0027validate\u0027: {"},{"line_number":84,"context_line":"                \u0027type:dict\u0027: {"},{"line_number":85,"context_line":"                    \u0027correlation\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_99b0fb8d","line":82,"in_reply_to":"1f013ff3_cdbc55de","updated":"2017-05-26 13:08:25.000000000","message":"I see what you did now; thanks for the explanation. Have you tried running SFC with this API def to ensure it works?\n\n\nnormalize_sf_parameters() returns a ref to the global dict DEFAULT_SF_PARAMETERS; whereas herein we just return the values from that global dict. That maybe fine, but in some cases the attrs are actually updated and used during runtime. Since it no longer uses the global dict DEFAULT_SF_PARAMETERS it\u0027s possible the updates are not \"sticking\".","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9c63abb90bb6bc57dce234fa1e9f311c7f811744","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        },"},{"line_number":80,"context_line":"        \u0027service_function_parameters\u0027: {"},{"line_number":81,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":82,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":83,"context_line":"            \u0027validate\u0027: {"},{"line_number":84,"context_line":"                \u0027type:dict\u0027: {"},{"line_number":85,"context_line":"                    \u0027correlation\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_cc3377f6","line":82,"in_reply_to":"5ff73747_452d0393","updated":"2017-05-02 13:37:08.000000000","message":"All the normalize_sf_parameters function does is return either the original value if it\u0027s not None or the default value if the original is None. As far as I can tell, that\u0027s simply specifying a default, so I just specified the defaults on lines 86 and 91. There was no \"conversion\" of anything going on in the convert_to function.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"31f96d5fc2c4805da800c4e5e6e082f3b35b8d09","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        },"},{"line_number":80,"context_line":"        \u0027service_function_parameters\u0027: {"},{"line_number":81,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":82,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":83,"context_line":"            \u0027validate\u0027: {"},{"line_number":84,"context_line":"                \u0027type:dict\u0027: {"},{"line_number":85,"context_line":"                    \u0027correlation\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_cdbc55de","line":82,"in_reply_to":"5ff73747_cc3377f6","updated":"2017-05-16 15:21:05.000000000","message":"OK, and \"validate\" will fail if it does not see a dictionary, even with \"default\u0027: None\" specified, right?","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"142d9e1fcdefc63838e9d2dc76d18870952668d9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        },"},{"line_number":80,"context_line":"        \u0027service_function_parameters\u0027: {"},{"line_number":81,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":82,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":83,"context_line":"            \u0027validate\u0027: {"},{"line_number":84,"context_line":"                \u0027type:dict\u0027: {"},{"line_number":85,"context_line":"                    \u0027correlation\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_452d0393","line":82,"in_reply_to":"5ff73747_fa22c9b8","updated":"2017-05-02 10:21:29.000000000","message":"Hmm, for this one it should at least have \u0027default\u0027: api_const.DEFAULT_SF_PARAMETERS, my -1 will come from this.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"735d8a508989ef1896bca29e602feefe4eb31631","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        },"},{"line_number":80,"context_line":"        \u0027service_function_parameters\u0027: {"},{"line_number":81,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":82,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":83,"context_line":"            \u0027validate\u0027: {"},{"line_number":84,"context_line":"                \u0027type:dict\u0027: {"},{"line_number":85,"context_line":"                    \u0027correlation\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_e364d5bb","line":82,"in_reply_to":"ff0f0b1f_99b0fb8d","updated":"2017-05-30 13:25:37.000000000","message":"It\u0027s definitely the next step to change networking-sfc to import the API-def from neutron-lib and delete the corresponding code from networking-sfc but I haven\u0027t gotten my neutron-lib changes to pass tox tests yet and I getting pulled off to work on other things before I get very far at troubleshooting.\n\nI had been trying not to bring SFC-specific exceptions and validators into neutron-lib, but at this point I\u0027ve decided I probably do need to.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f1066de632aa66a669057a8e85bb03d519b81637","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":131,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":132,"context_line":"            \u0027validate\u0027: {\u0027type:uuid_list\u0027: None},"},{"line_number":133,"context_line":"            \u0027default\u0027: None"},{"line_number":134,"context_line":"        },"},{"line_number":135,"context_line":"        \u0027flow_classifiers\u0027: {"},{"line_number":136,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_9e08992c","line":133,"updated":"2017-05-08 12:36:26.000000000","message":"What about the normalize_port_pair_groups converter here [1]? I\u0027m not seeing how that\u0027s accounted for.\n\n\n[1] https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py#L250","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d01b412f3bc9ddb30c0b3db23f0ed72a6defaaa5","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":131,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":132,"context_line":"            \u0027validate\u0027: {\u0027type:uuid_list\u0027: None},"},{"line_number":133,"context_line":"            \u0027default\u0027: None"},{"line_number":134,"context_line":"        },"},{"line_number":135,"context_line":"        \u0027flow_classifiers\u0027: {"},{"line_number":136,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_3c467d51","line":133,"in_reply_to":"3f044301_9e08992c","updated":"2017-05-26 13:08:25.000000000","message":"Hmm... normalize_port_pair_groups() doesn\u0027t seem to imply the list items are UUIDs, but given the type here I\u0027m guessing they are?\n\n\nAlso, normalize_port_pair_groups() raises a PortPairGroupNotSpecified and I don\u0027t think we\u0027d get that here; is that OK?","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d81ac867b748dbb7785f560730fc701a2392aad3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027convert_to\u0027: lib_converters.convert_to_list"},{"line_number":140,"context_line":"        },"},{"line_number":141,"context_line":"        \u0027chain_parameters\u0027: {"},{"line_number":142,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":143,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":144,"context_line":"            \u0027validate\u0027: {"},{"line_number":145,"context_line":"                \u0027type:dict\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_a500a202","line":142,"updated":"2017-04-27 17:46:49.000000000","message":"What about the \u0027convert_to\u0027: normalize_chain_parameters from the sfc extension [1]?\n\n\n[1] https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py#L273","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9c63abb90bb6bc57dce234fa1e9f311c7f811744","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027convert_to\u0027: lib_converters.convert_to_list"},{"line_number":140,"context_line":"        },"},{"line_number":141,"context_line":"        \u0027chain_parameters\u0027: {"},{"line_number":142,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":143,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":144,"context_line":"            \u0027validate\u0027: {"},{"line_number":145,"context_line":"                \u0027type:dict\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_6c9ea3b9","line":142,"in_reply_to":"5ff73747_a500a202","updated":"2017-05-02 13:37:08.000000000","message":"Same as above, all the normalize_chain_parameters function does is put in a default if the parameter is missing. I simply specified defaults on lines 147 and 151 instead of using a function to put in the defaults. There was no actual conversion happening in the convert_to function.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d81ac867b748dbb7785f560730fc701a2392aad3","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        },"},{"line_number":190,"context_line":"        \u0027port_pair_group_parameters\u0027: {"},{"line_number":191,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":192,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":193,"context_line":"            \u0027validate\u0027: {"},{"line_number":194,"context_line":"                \u0027type:dict\u0027: {"},{"line_number":195,"context_line":"                    \u0027lb_fields\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_3a16f156","line":192,"updated":"2017-04-27 17:46:49.000000000","message":"What about the \u0027convert_to\u0027: normalize_ppg_parameters from [1]?\n\n\n[1] https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py#L319","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9c63abb90bb6bc57dce234fa1e9f311c7f811744","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        },"},{"line_number":190,"context_line":"        \u0027port_pair_group_parameters\u0027: {"},{"line_number":191,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":192,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":193,"context_line":"            \u0027validate\u0027: {"},{"line_number":194,"context_line":"                \u0027type:dict\u0027: {"},{"line_number":195,"context_line":"                    \u0027lb_fields\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_0cc4bf91","line":192,"in_reply_to":"5ff73747_3a16f156","updated":"2017-05-02 13:37:08.000000000","message":"Same here, the alleged \"converter\" was really just populating a default so I added the default on line 196.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f1066de632aa66a669057a8e85bb03d519b81637","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                    \u0027lb_fields\u0027: {"},{"line_number":196,"context_line":"                        \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS["},{"line_number":197,"context_line":"                            \u0027lb_fields\u0027],"},{"line_number":198,"context_line":"                        \u0027type:list_of_allowed_values\u0027:"},{"line_number":199,"context_line":"                            api_const.SFC_SUPPORTED_LB_FIELDS"},{"line_number":200,"context_line":"                    }"},{"line_number":201,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_01266cb8","line":198,"range":{"start_line":198,"start_character":30,"end_line":198,"end_character":52},"updated":"2017-05-08 12:36:26.000000000","message":"Where is this defined? I don\u0027t see this registered in validators and since the UT is passing we may have a bug in the api-def logic since its not catching this.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f7ed3ae341eaac6229dbe46224d0baff1b3f5e23","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                    \u0027lb_fields\u0027: {"},{"line_number":196,"context_line":"                        \u0027default\u0027: api_const.SFC_DEFAULT_PPG_PARAMETERS["},{"line_number":197,"context_line":"                            \u0027lb_fields\u0027],"},{"line_number":198,"context_line":"                        \u0027type:list_of_allowed_values\u0027:"},{"line_number":199,"context_line":"                            api_const.SFC_SUPPORTED_LB_FIELDS"},{"line_number":200,"context_line":"                    }"},{"line_number":201,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_269a1161","line":198,"range":{"start_line":198,"start_character":30,"end_line":198,"end_character":52},"in_reply_to":"3f044301_01266cb8","updated":"2017-05-25 11:29:28.000000000","message":"I think it was defined at one point but seems to have gotten lost. I\u0027ll have to figure out what it was.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9837ac49a6db4c6063c2b8811874767aec934a3d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"}"},{"line_number":220,"context_line":"# The list of required extensions."},{"line_number":221,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":222,"context_line":"]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# The list of optional extensions."},{"line_number":225,"context_line":"OPTIONAL_EXTENSIONS \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_13e01b96","line":222,"updated":"2017-05-19 11:37:54.000000000","message":"IIUC, \u0027sfc\u0027 extension requires \u0027flow_classifier\u0027 extension.\nDo we need to add \u0027flow_classifier\u0027 extension into neutron-lib API definitions first, or bring flow_classifier ext together?","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f7ed3ae341eaac6229dbe46224d0baff1b3f5e23","unresolved":false,"context_lines":[{"line_number":219,"context_line":"}"},{"line_number":220,"context_line":"# The list of required extensions."},{"line_number":221,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":222,"context_line":"]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# The list of optional extensions."},{"line_number":225,"context_line":"OPTIONAL_EXTENSIONS \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_c6759533","line":222,"in_reply_to":"ff0f0b1f_13e01b96","updated":"2017-05-25 11:29:28.000000000","message":"Hmm, I guess I need to add another entire API definition for flow_classifier.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e81a229f78513936704198465722872ce1cebd2","unresolved":false,"context_lines":[{"line_number":219,"context_line":"}"},{"line_number":220,"context_line":"# The list of required extensions."},{"line_number":221,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":222,"context_line":"]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# The list of optional extensions."},{"line_number":225,"context_line":"OPTIONAL_EXTENSIONS \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_b72cf44a","line":222,"in_reply_to":"ff0f0b1f_c6759533","updated":"2017-05-26 04:19:05.000000000","message":"The reason I think so is SFC extension uses flow_classifier field, so I think it is a dependency. Can SFC API work without flow classifier API?\nwe are trying to have a working set of API definitions in neutron-lib.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee2b52baec67654076fbb1d13cf5ff01a3e6e173","unresolved":false,"context_lines":[{"line_number":230,"context_line":"}"},{"line_number":231,"context_line":"# The list of required extensions."},{"line_number":232,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":233,"context_line":"    \u0027flowclassifier\u0027"},{"line_number":234,"context_line":"]"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"# The list of optional extensions."}],"source_content_type":"text/x-python","patch_set":13,"id":"ff6b8bd7_de18bcd4","line":233,"range":{"start_line":233,"start_character":5,"end_line":233,"end_character":19},"updated":"2018-03-06 14:08:45.000000000","message":"can\u0027t we just use the flowclassifier module\u0027s ALIAS attribute? e.g.\n\n   flowclassifier.ALIAS","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cbdbb9e45ad9a3b27f2b31ec6a8dc1d114f96c69","unresolved":false,"context_lines":[{"line_number":230,"context_line":"}"},{"line_number":231,"context_line":"# The list of required extensions."},{"line_number":232,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":233,"context_line":"    \u0027flowclassifier\u0027"},{"line_number":234,"context_line":"]"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"# The list of optional extensions."}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_b59f2564","line":233,"range":{"start_line":233,"start_character":5,"end_line":233,"end_character":19},"updated":"2018-03-19 13:21:45.000000000","message":"As mentioned before; can\u0027t we just use the ALIAS from flowclassifier module?","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d32659e2fc09ce951dafab8dbc5bd553ac3d24df","unresolved":false,"context_lines":[{"line_number":230,"context_line":"}"},{"line_number":231,"context_line":"# The list of required extensions."},{"line_number":232,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":233,"context_line":"    \u0027flowclassifier\u0027"},{"line_number":234,"context_line":"]"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"# The list of optional extensions."}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_357555cd","line":233,"range":{"start_line":233,"start_character":5,"end_line":233,"end_character":19},"in_reply_to":"df7087c5_b59f2564","updated":"2018-03-22 21:33:59.000000000","message":"Ack.\nSorry if I missed it.","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"}],"neutron_lib/api/validators/__init__.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e7e2de9334c39353e9498f6b9869aeba7d79a103","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"9f6a8fd7_19909e4e","updated":"2018-04-26 18:35:11.000000000","message":"Probably need a few UTs.","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"f977730152a9651127c55267de331b7fbc3d8249","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"9f6a8fd7_32500fd5","in_reply_to":"9f6a8fd7_19909e4e","updated":"2018-04-27 09:20:49.000000000","message":"This injonction got me a bit creative: I realized that introducing validate_list_of_allowed_values is in fact not necessary for sfc...","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e7e2de9334c39353e9498f6b9869aeba7d79a103","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a list\") % data"},{"line_number":105,"context_line":"        return msg"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    if kwargs.pop(\u0027check_non_empty\u0027, False) and len(data) \u003d\u003d 0:"},{"line_number":108,"context_line":"        msg \u003d _(\"List should not be empty\")"},{"line_number":109,"context_line":"        return msg"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"9f6a8fd7_3926c26a","line":107,"updated":"2018-04-26 18:35:11.000000000","message":"IIUC, this seems a bit like a 1-off.. Aren\u0027t the kwargs intended to pass onto the item_validator?","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"f977730152a9651127c55267de331b7fbc3d8249","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a list\") % data"},{"line_number":105,"context_line":"        return msg"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    if kwargs.pop(\u0027check_non_empty\u0027, False) and len(data) \u003d\u003d 0:"},{"line_number":108,"context_line":"        msg \u003d _(\"List should not be empty\")"},{"line_number":109,"context_line":"        return msg"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"9f6a8fd7_be314ba5","line":107,"in_reply_to":"9f6a8fd7_3926c26a","updated":"2018-04-27 09:20:49.000000000","message":"Yes, in API declarations, one parameter can be passed as a kwarg to the validator.  This change does not prevent that: such a parameters will be passed to the validator.  This is only currenlyt possible for one kwarg though IIRC.\n\nI would think that there is no intrinsic drawback in having, additionally to these kwargs coming from API declaration,  a kwarg  that remains internal to how a validator function validate_uuid_list_non_empty) uses a internal method to achieve its goal.\n\nThat said, I made another pass at it, to have the code be less surprising...","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"}],"neutron_lib/tests/unit/api/definitions/test_flowclassifier.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee2b52baec67654076fbb1d13cf5ff01a3e6e173","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.tests.unit.api.definitions import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d flowclassifier"},{"line_number":19,"context_line":"    extension_resources \u003d (flowclassifier.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d (\u0027ethertype\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff6b8bd7_3e277815","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":12},"updated":"2018-03-06 14:08:45.000000000","message":"Flowclassifier","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cbdbb9e45ad9a3b27f2b31ec6a8dc1d114f96c69","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.tests.unit.api.definitions import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d flowclassifier"},{"line_number":19,"context_line":"    extension_resources \u003d (flowclassifier.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d (\u0027ethertype\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_95aea196","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":12},"updated":"2018-03-19 13:21:45.000000000","message":"FlowClassifier","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d32659e2fc09ce951dafab8dbc5bd553ac3d24df","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.tests.unit.api.definitions import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d flowclassifier"},{"line_number":19,"context_line":"    extension_resources \u003d (flowclassifier.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d (\u0027ethertype\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_9549c18c","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":12},"in_reply_to":"df7087c5_95aea196","updated":"2018-03-22 21:33:59.000000000","message":"Good catch, thx!","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"}],"neutron_lib/tests/unit/api/definitions/test_sfc.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"1070db06242fd6cc3591ed9cd36f124a8928615a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                           \u0027port_chains\u0027,)"},{"line_number":21,"context_line":"    extension_attributes \u003d (\u0027ingress\u0027, \u0027egress\u0027,"},{"line_number":22,"context_line":"                            \u0027service_function_parameters\u0027,"},{"line_number":23,"context_line":"                            \u0027chain_id\u0027,"},{"line_number":24,"context_line":"                            \u0027flow_classifiers\u0027,"},{"line_number":25,"context_line":"                            \u0027chain_parameters\u0027,"},{"line_number":26,"context_line":"                            \u0027port_pair_group_parameters\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_063d1e2a","line":23,"updated":"2017-04-20 13:21:25.000000000","message":"chains have \u0027port_pair_groups\u0027","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5c82213db178400660ad13c105a4f80d714eaa82","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                           \u0027port_chains\u0027,)"},{"line_number":21,"context_line":"    extension_attributes \u003d (\u0027ingress\u0027, \u0027egress\u0027,"},{"line_number":22,"context_line":"                            \u0027service_function_parameters\u0027,"},{"line_number":23,"context_line":"                            \u0027chain_id\u0027,"},{"line_number":24,"context_line":"                            \u0027flow_classifiers\u0027,"},{"line_number":25,"context_line":"                            \u0027chain_parameters\u0027,"},{"line_number":26,"context_line":"                            \u0027port_pair_group_parameters\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_d5adae9b","line":23,"in_reply_to":"7ffa3b31_063d1e2a","updated":"2017-04-27 12:37:03.000000000","message":"Done","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"1070db06242fd6cc3591ed9cd36f124a8928615a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                            \u0027flow_classifiers\u0027,"},{"line_number":25,"context_line":"                            \u0027chain_parameters\u0027,"},{"line_number":26,"context_line":"                            \u0027port_pair_group_parameters\u0027,"},{"line_number":27,"context_line":"                            \u0027port_pairs\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_2605ba46","line":27,"updated":"2017-04-20 13:21:25.000000000","message":"and missing \u0027group_id\u0027 for port pair groups","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"5c82213db178400660ad13c105a4f80d714eaa82","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                            \u0027flow_classifiers\u0027,"},{"line_number":25,"context_line":"                            \u0027chain_parameters\u0027,"},{"line_number":26,"context_line":"                            \u0027port_pair_group_parameters\u0027,"},{"line_number":27,"context_line":"                            \u0027port_pairs\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_f5a8aa8c","line":27,"in_reply_to":"7ffa3b31_2605ba46","updated":"2017-04-27 12:37:03.000000000","message":"Done","commit_id":"7f9ac94e1e33ced32d4530a06143b9b27b007ee7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9837ac49a6db4c6063c2b8811874767aec934a3d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SfcDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d sfc"},{"line_number":19,"context_line":"    extension_resources \u003d (\u0027port_pairs\u0027, \u0027port_pair_groups\u0027,"},{"line_number":20,"context_line":"                           \u0027port_chains\u0027,)"},{"line_number":21,"context_line":"    extension_attributes \u003d (\u0027chain_id\u0027,"},{"line_number":22,"context_line":"                            \u0027chain_parameters\u0027,"},{"line_number":23,"context_line":"                            \u0027egress\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_5320d3b0","line":20,"range":{"start_line":19,"start_character":26,"end_line":20,"end_character":42},"updated":"2017-05-19 11:37:54.000000000","message":"Could change this to one line or one entry per line?","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f7ed3ae341eaac6229dbe46224d0baff1b3f5e23","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SfcDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d sfc"},{"line_number":19,"context_line":"    extension_resources \u003d (\u0027port_pairs\u0027, \u0027port_pair_groups\u0027,"},{"line_number":20,"context_line":"                           \u0027port_chains\u0027,)"},{"line_number":21,"context_line":"    extension_attributes \u003d (\u0027chain_id\u0027,"},{"line_number":22,"context_line":"                            \u0027chain_parameters\u0027,"},{"line_number":23,"context_line":"                            \u0027egress\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_a6a501a1","line":20,"range":{"start_line":19,"start_character":26,"end_line":20,"end_character":42},"in_reply_to":"ff0f0b1f_5320d3b0","updated":"2017-05-25 11:29:28.000000000","message":"Sure, I guess.","commit_id":"86663072a99234e8b14e83cc5f614544cd88796c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee2b52baec67654076fbb1d13cf5ff01a3e6e173","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.tests.unit.api.definitions import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d sfc"},{"line_number":19,"context_line":"    extension_resources \u003d tuple(sfc.RESOURCE_ATTRIBUTE_MAP.keys())"},{"line_number":20,"context_line":"    extension_attributes \u003d (  # port_pair"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff6b8bd7_de7d1ce8","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":12},"updated":"2018-03-06 14:08:45.000000000","message":"Sfc","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee2b52baec67654076fbb1d13cf5ff01a3e6e173","unresolved":false,"context_lines":[{"line_number":17,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d sfc"},{"line_number":19,"context_line":"    extension_resources \u003d tuple(sfc.RESOURCE_ATTRIBUTE_MAP.keys())"},{"line_number":20,"context_line":"    extension_attributes \u003d (  # port_pair"},{"line_number":21,"context_line":"                              \u0027type\u0027, \u0027ingress\u0027, \u0027egress\u0027,"},{"line_number":22,"context_line":"                              \u0027service_function_parameters\u0027,"},{"line_number":23,"context_line":"                              # port_pair_group"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff6b8bd7_7e82d0ca","line":20,"range":{"start_line":20,"start_character":30,"end_line":20,"end_character":41},"updated":"2018-03-06 14:08:45.000000000","message":"Why include these commented out?","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cbdbb9e45ad9a3b27f2b31ec6a8dc1d114f96c69","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.tests.unit.api.definitions import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d sfc"},{"line_number":19,"context_line":"    extension_resources \u003d tuple(sfc.RESOURCE_ATTRIBUTE_MAP.keys())"},{"line_number":20,"context_line":"    extension_attributes \u003d (  # port_pair"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_3593155f","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":12},"updated":"2018-03-19 13:21:45.000000000","message":"SFC","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d32659e2fc09ce951dafab8dbc5bd553ac3d24df","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.tests.unit.api.definitions import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d sfc"},{"line_number":19,"context_line":"    extension_resources \u003d tuple(sfc.RESOURCE_ATTRIBUTE_MAP.keys())"},{"line_number":20,"context_line":"    extension_attributes \u003d (  # port_pair"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_f557dd25","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":12},"in_reply_to":"df7087c5_3593155f","updated":"2018-03-22 21:33:59.000000000","message":"Done","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cbdbb9e45ad9a3b27f2b31ec6a8dc1d114f96c69","unresolved":false,"context_lines":[{"line_number":17,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d sfc"},{"line_number":19,"context_line":"    extension_resources \u003d tuple(sfc.RESOURCE_ATTRIBUTE_MAP.keys())"},{"line_number":20,"context_line":"    extension_attributes \u003d (  # port_pair"},{"line_number":21,"context_line":"                              \u0027type\u0027, \u0027ingress\u0027, \u0027egress\u0027,"},{"line_number":22,"context_line":"                              \u0027service_function_parameters\u0027,"},{"line_number":23,"context_line":"                              # port_pair_group"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_5590094f","line":20,"range":{"start_line":20,"start_character":30,"end_line":20,"end_character":40},"updated":"2018-03-19 13:21:45.000000000","message":"Why are these commented out?","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d32659e2fc09ce951dafab8dbc5bd553ac3d24df","unresolved":false,"context_lines":[{"line_number":17,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d sfc"},{"line_number":19,"context_line":"    extension_resources \u003d tuple(sfc.RESOURCE_ATTRIBUTE_MAP.keys())"},{"line_number":20,"context_line":"    extension_attributes \u003d (  # port_pair"},{"line_number":21,"context_line":"                              \u0027type\u0027, \u0027ingress\u0027, \u0027egress\u0027,"},{"line_number":22,"context_line":"                              \u0027service_function_parameters\u0027,"},{"line_number":23,"context_line":"                              # port_pair_group"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_552009b1","line":20,"range":{"start_line":20,"start_character":30,"end_line":20,"end_character":40},"in_reply_to":"df7087c5_5590094f","updated":"2018-03-22 21:33:59.000000000","message":"This is node commented out code, but just comments, indicating from which resource the attribute come from.","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"}],"releasenotes/notes/sfc-api-def-4f46632eadfe895a.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"24ce2b8df5d0a3493b1f1d317d29ccd47d33f11e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the networking-sfc API definition to neutron-lib"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_600210b7","line":2,"updated":"2017-03-31 12:58:10.000000000","message":"Nit; missing period at the end of the sentence.","commit_id":"caa99378b934e91ed3539dcf403599a255dc0e72"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"70eb93486e4a4abdaa026a210b4d2e7da582a305","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the networking-sfc API definition to neutron-lib"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ff52f3f_ab66c750","line":2,"in_reply_to":"dfeb2761_600210b7","updated":"2017-04-13 14:14:31.000000000","message":"Done","commit_id":"caa99378b934e91ed3539dcf403599a255dc0e72"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d08ff1b414c7ddcbe4f65a9be81292277d0c2966","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the networking-sfc API definition"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ff6b8bd7_31949444","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":42},"updated":"2018-03-06 03:52:11.000000000","message":"Could you add more descriptions? This patch doesn\u0027t add all extensions of networking-sfc(It includes sfc and flowclassifier only). It\u0027s better to describe added definition names and converters.","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee2b52baec67654076fbb1d13cf5ff01a3e6e173","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the networking-sfc API definition"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ff6b8bd7_5e690c23","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":42},"in_reply_to":"ff6b8bd7_31949444","updated":"2018-03-06 14:08:45.000000000","message":"+1","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b213bbe347ed8ed7bb38139c76c5368f58bf77c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the networking-sfc API definition"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"df7087c5_10ac08eb","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":42},"in_reply_to":"ff6b8bd7_31949444","updated":"2018-03-16 13:46:37.000000000","message":"Done","commit_id":"0d3566af7da057e17ee8d34ec7e17347e5de2c2d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cbdbb9e45ad9a3b27f2b31ec6a8dc1d114f96c69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"df7087c5_d58df931","line":5,"updated":"2018-03-19 13:21:45.000000000","message":"Seems we could add the converter too.","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d32659e2fc09ce951dafab8dbc5bd553ac3d24df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"df7087c5_3590f495","line":5,"in_reply_to":"df7087c5_d58df931","updated":"2018-03-22 21:33:59.000000000","message":"Done","commit_id":"26b0b697fe25cf66308ead95dfe20f957b1f0c1d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e7e2de9334c39353e9498f6b9869aeba7d79a103","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add the definitions for the ``sfc`` and ``flowclassifier`` API extensions"},{"line_number":4,"context_line":"    of the networking-sfc project."},{"line_number":5,"context_line":"  - Add a ``convert_uppercase_ip`` converter, convenient to easily accept for"},{"line_number":6,"context_line":"    instance ``Ipv4``, ``IPv4`` and ``ipv4`` independently of the case of the"},{"line_number":7,"context_line":"    first two letters."},{"line_number":8,"context_line":"  - Add a ``uuid_list_non_empty`` validator, that will validate that the"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9f6a8fd7_f97b6a26","line":5,"updated":"2018-04-26 18:35:11.000000000","message":"And adds convert_uppercase_prefix converter","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"f977730152a9651127c55267de331b7fbc3d8249","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add the definitions for the ``sfc`` and ``flowclassifier`` API extensions"},{"line_number":4,"context_line":"    of the networking-sfc project."},{"line_number":5,"context_line":"  - Add a ``convert_uppercase_ip`` converter, convenient to easily accept for"},{"line_number":6,"context_line":"    instance ``Ipv4``, ``IPv4`` and ``ipv4`` independently of the case of the"},{"line_number":7,"context_line":"    first two letters."},{"line_number":8,"context_line":"  - Add a ``uuid_list_non_empty`` validator, that will validate that the"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9f6a8fd7_d2baf3df","line":5,"in_reply_to":"9f6a8fd7_f97b6a26","updated":"2018-04-27 09:20:49.000000000","message":"Done","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2ada841e878ca6213fcb123727c982c8d1c22c43","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Add a ``convert_uppercase_ip`` converter, convenient to easily accept for"},{"line_number":6,"context_line":"    instance ``Ipv4``, ``IPv4`` and ``ipv4`` independently of the case of the"},{"line_number":7,"context_line":"    first two letters."},{"line_number":8,"context_line":"  - Add a ``uuid_list_non_empty`` validator, that will validate that the"},{"line_number":9,"context_line":"    value is a non-empty list of UUIDs"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9f6a8fd7_99926e4b","line":8,"updated":"2018-04-27 13:07:44.000000000","message":"It adds 2 validators.","commit_id":"db6771e1c30c21f3a15e762ffbe01a7cb757783c"}]}
