)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"28a9743d2bd0c02f65b51f00fd4ecd31aa7d9825","unresolved":false,"context_lines":[{"line_number":14,"context_line":"and use it everywhere."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1]. https://bugs.launchpad.net/neutron/+bug/1653780"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ifd13f6d85bd7c7f5f803eaa8aac0e16c0f0edff7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5201f7_844ca171","line":17,"updated":"2017-01-03 22:29:36.000000000","message":"Please add \"Related-Bug\" to help tracking of all changes.","commit_id":"df38982338f45679977d282a4c3dbe7364d44588"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"023dd33d11eb9b24e1acac116c59a2030c7660ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add FQDN_MAX_LEN constant"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"FQDN_MAX_LEN has been defined at multiple locations"},{"line_number":10,"context_line":"in neutron tree, I encountered a situation where use"},{"line_number":11,"context_line":"of this constant from neutron/extensions/dns.py ended"},{"line_number":12,"context_line":"up in cyclic import. The better solution would be to"},{"line_number":13,"context_line":"have it in neutron lib and use it everywhere."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba5201f7_3096b2f0","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":15},"updated":"2017-01-04 14:37:41.000000000","message":"If its only used in neutron, does it really make sense to put it into neutron-lib?","commit_id":"98e9d5b84242b87f03f0b2c325dd4355046c5f81"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"4d16dc8db527c6f135c66ed77ef33ca00983f43b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add FQDN_MAX_LEN constant"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"FQDN_MAX_LEN has been defined at multiple locations"},{"line_number":10,"context_line":"in neutron tree, I encountered a situation where use"},{"line_number":11,"context_line":"of this constant from neutron/extensions/dns.py ended"},{"line_number":12,"context_line":"up in cyclic import. The better solution would be to"},{"line_number":13,"context_line":"have it in neutron lib and use it everywhere."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba5201f7_a021714f","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":15},"in_reply_to":"ba5201f7_3096b2f0","updated":"2017-01-04 15:36:42.000000000","message":"I think FQDN_FIELD_SIZE could be used by sub-projects if it is available in neutron-lib. For example,\n\nhttps://github.com/openstack/vmware-nsx/blob/master/vmware_nsx/db/nsxv_models.py#L342","commit_id":"98e9d5b84242b87f03f0b2c325dd4355046c5f81"}],"neutron_lib/constants.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"28a9743d2bd0c02f65b51f00fd4ecd31aa7d9825","unresolved":false,"context_lines":[{"line_number":291,"context_line":"CORE \u003d \u0027CORE\u0027"},{"line_number":292,"context_line":"# The alias for the L3 plugin."},{"line_number":293,"context_line":"L3 \u003d \u0027L3_ROUTER_NAT\u0027"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"##################################"},{"line_number":296,"context_line":"# Size or length related constants"},{"line_number":297,"context_line":"##################################"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_0458b131","line":294,"updated":"2017-01-03 22:29:36.000000000","message":"Extra new line needed","commit_id":"df38982338f45679977d282a4c3dbe7364d44588"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"019685aebeb0ae0758db1615981ef1ffd4dae94d","unresolved":false,"context_lines":[{"line_number":291,"context_line":"CORE \u003d \u0027CORE\u0027"},{"line_number":292,"context_line":"# The alias for the L3 plugin."},{"line_number":293,"context_line":"L3 \u003d \u0027L3_ROUTER_NAT\u0027"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"##################################"},{"line_number":296,"context_line":"# Size or length related constants"},{"line_number":297,"context_line":"##################################"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_4469d9bd","line":294,"updated":"2017-01-03 22:30:07.000000000","message":"Extra newline needed :)","commit_id":"ad9c80d8887abf0da6fc701e65504f23e29b0f80"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7b6cc43e9363ad6a1a2d97dc209b5f745333db9d","unresolved":false,"context_lines":[{"line_number":298,"context_line":"##################################"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"# Domain name length size"},{"line_number":301,"context_line":"FQDN_MAX_LEN \u003d 255"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"# Linux interface max length"},{"line_number":304,"context_line":"DEVICE_NAME_MAX_LEN \u003d 15"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_3721654e","line":301,"updated":"2017-01-03 23:10:52.000000000","message":"It\u0027s used for the size of numerous columns in db tables (fields in \u0027networkdnsdomains\u0027, \u0027floatingipdnses\u0027, \u0027portdnses\u0027, as well as the \u0027dns_name\u0027 column of the \u0027ports\u0027 table, etc.).\n\nSo therefore I think you should define FQDN_FIELD_SIZE in neutron_lib/db/constants.py .\n\nIn neutron core you should then do like https://review.openstack.org/399891 for this constant.","commit_id":"f0f8ff0eb3bb84632c9b5cca18beab78f41775af"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dc1fb81e07180c5be70beb5cc0c1668097e3f7f2","unresolved":false,"context_lines":[{"line_number":298,"context_line":"##################################"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"# Domain name length size"},{"line_number":301,"context_line":"FQDN_MAX_LEN \u003d 255"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"# Linux interface max length"},{"line_number":304,"context_line":"DEVICE_NAME_MAX_LEN \u003d 15"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_75dcc512","line":301,"in_reply_to":"ba5201f7_3721654e","updated":"2017-01-04 00:31:02.000000000","message":"Done","commit_id":"f0f8ff0eb3bb84632c9b5cca18beab78f41775af"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7b6cc43e9363ad6a1a2d97dc209b5f745333db9d","unresolved":false,"context_lines":[{"line_number":301,"context_line":"FQDN_MAX_LEN \u003d 255"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"# Linux interface max length"},{"line_number":304,"context_line":"DEVICE_NAME_MAX_LEN \u003d 15"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_771bed1b","line":304,"updated":"2017-01-03 23:10:52.000000000","message":"Do we want linux constants to be in this file?","commit_id":"f0f8ff0eb3bb84632c9b5cca18beab78f41775af"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0c1479a809cc4b3bc8b9574ae7286872c4ecd7ae","unresolved":false,"context_lines":[{"line_number":301,"context_line":"FQDN_MAX_LEN \u003d 255"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"# Linux interface max length"},{"line_number":304,"context_line":"DEVICE_NAME_MAX_LEN \u003d 15"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_15aff994","line":304,"in_reply_to":"ba5201f7_771bed1b","updated":"2017-01-04 00:24:46.000000000","message":"This was moved from upper part of file, just for grouping size or length type constants, it was already in this file","commit_id":"f0f8ff0eb3bb84632c9b5cca18beab78f41775af"}],"neutron_lib/db/constants.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0e67cc20c2b3ed0cd0ec5b8e4fb4a764a86c2a5a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"IP_ADDR_FIELD_SIZE \u003d 64  # large enough to hold a v4 or v6 address"},{"line_number":23,"context_line":"MAC_ADDR_FIELD_SIZE \u003d 32"},{"line_number":24,"context_line":"RESOURCE_TYPE_FIELD_SIZE \u003d 255"},{"line_number":25,"context_line":"FQDN_MAX_LEN \u003d 255"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Alembic branches"},{"line_number":28,"context_line":"EXPAND_BRANCH \u003d \u0027expand\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_0d10cd4d","line":25,"updated":"2017-01-04 04:24:50.000000000","message":"I suggest name it FQDN_FIELD_SIZE like the others in this file.\n\nTo avoid too much code churn in neutron core, you can set up FQDN_MAX_LEN \u003d FQDN_FIELD_SIZE in a strategic place or two there.","commit_id":"98e9d5b84242b87f03f0b2c325dd4355046c5f81"}]}
