)]}'
{"neutron_lib/tests/unit/api/definitions/base.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"11ba07592318b0a278adc64bb64b58ae79b1f3a4","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def assert_converter(tester, attribute, attribute_dict, keyword, value):"},{"line_number":26,"context_line":"    if attribute_dict[\u0027default\u0027] is constants.ATTR_NOT_SPECIFIED:"},{"line_number":27,"context_line":"        return"},{"line_number":28,"context_line":"    try:"},{"line_number":29,"context_line":"        attribute_dict[\u0027convert_to\u0027](attribute_dict[\u0027default\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_4f745435","line":26,"updated":"2017-01-11 22:34:24.000000000","message":"what issue were you facing? check on line 34 was added in case the default for the attribute was indeed ATTR_NOT_SPECIFIED.","commit_id":"c082efd419062d40e3f23f6500c09870e3f68bdc"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"87bf5fb1f27a90d5ca31a0d87c033aaa6fe71ab8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def assert_converter(tester, attribute, attribute_dict, keyword, value):"},{"line_number":26,"context_line":"    if attribute_dict[\u0027default\u0027] is constants.ATTR_NOT_SPECIFIED:"},{"line_number":27,"context_line":"        return"},{"line_number":28,"context_line":"    try:"},{"line_number":29,"context_line":"        attribute_dict[\u0027convert_to\u0027](attribute_dict[\u0027default\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_2217b352","line":26,"in_reply_to":"ba5201f7_4f745435","updated":"2017-01-12 13:06:33.000000000","message":"This is the error I get when without this if check for ATTR_NOT_SPECIFIED::\n\n  neutron_lib.tests.unit.api.definitions.test_provider_net._ProviderNetTestCase.test_resource_map\n-----------------------------------------------------------------------------------------------\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n      File \"neutron_lib/tests/unit/api/definitions/base.py\", line 118, in test_resource_map\n        keyword, value)\n      File \"neutron_lib/tests/unit/api/definitions/base.py\", line 29, in assert_converter\n        attribute_dict[\u0027convert_to\u0027](attribute_dict[\u0027default\u0027])\n      File \"neutron_lib/api/converters.py\", line 61, in convert_to_int\n        raise n_exc.InvalidInput(error_message\u003dmsg)\n    neutron_lib.exceptions.InvalidInput: Invalid input for operation: \u0027\u003cneutron_lib.constants.Sentinel object at 0x7f7b51896c90\u003e\u0027 is not an integer.","commit_id":"c082efd419062d40e3f23f6500c09870e3f68bdc"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2470655bb212b1f115ef120fbfc665fd553d4d66","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def assert_converter(tester, attribute, attribute_dict, keyword, value):"},{"line_number":26,"context_line":"    if attribute_dict[\u0027default\u0027] is constants.ATTR_NOT_SPECIFIED:"},{"line_number":27,"context_line":"        return"},{"line_number":28,"context_line":"    try:"},{"line_number":29,"context_line":"        attribute_dict[\u0027convert_to\u0027](attribute_dict[\u0027default\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_ef9b4864","line":26,"updated":"2017-01-11 22:34:39.000000000","message":"question on PS1","commit_id":"97d05ae3a4bebdfe0c71041c967311093b775cbe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"386a6f4c87d38f5b7a4aec8080744cc248c50155","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def assert_converter(tester, attribute, attribute_dict, keyword, value):"},{"line_number":26,"context_line":"    if attribute_dict[\u0027default\u0027] is constants.ATTR_NOT_SPECIFIED:"},{"line_number":27,"context_line":"        return"},{"line_number":28,"context_line":"    try:"},{"line_number":29,"context_line":"        attribute_dict[\u0027convert_to\u0027](attribute_dict[\u0027default\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a57fde8_3d8992cb","line":26,"in_reply_to":"ba5201f7_ef9b4864","updated":"2017-01-12 13:21:13.000000000","message":"The problem is that the constants.ATTR_NOT_SPECIFIED is a class so it is a pointer. So all of the places that use this need to point to the same place. We had these issues when first using neutron lib and the ATTR_NOT_SPECIFIED was defined in more than one place","commit_id":"97d05ae3a4bebdfe0c71041c967311093b775cbe"}]}
