)]}'
{"neutron_lib/api/definitions/firewall.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ae07f283d2c393cc4c370be1441c68fba3d22e51","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# The action map."},{"line_number":165,"context_line":"ACTION_MAP \u003d {"},{"line_number":166,"context_line":"    \u0027firewall_policy\u0027: {\u0027insert_rule\u0027: \u0027PUT\u0027, \u0027remove_rule\u0027: \u0027PUT\u0027},"},{"line_number":167,"context_line":"}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# The list of required extensions."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_e0f3759c","line":166,"range":{"start_line":166,"start_character":5,"end_line":166,"end_character":20},"updated":"2017-01-20 21:38:34.000000000","message":"Make this a constant in neutron_lib.api.definitions.constants??","commit_id":"5e6c287d7a1455575aee7960dc9184f650cca67d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8e948c2f9dda2d365463a5c41345c399db3c5144","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# The action map."},{"line_number":165,"context_line":"ACTION_MAP \u003d {"},{"line_number":166,"context_line":"    \u0027firewall_policy\u0027: {\u0027insert_rule\u0027: \u0027PUT\u0027, \u0027remove_rule\u0027: \u0027PUT\u0027},"},{"line_number":167,"context_line":"}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# The list of required extensions."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_fcb715f3","line":166,"range":{"start_line":166,"start_character":5,"end_line":166,"end_character":20},"in_reply_to":"5a3905b3_90999ad3","updated":"2017-01-24 19:03:56.000000000","message":"After looking at other API definitions, only the fwaas definition uses api.definitions.constants. IMHO constants module should have only constants which are common across many APIs. FWaaS specific constants should be moved into here. So I think it is okay.","commit_id":"5e6c287d7a1455575aee7960dc9184f650cca67d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e37b927c51b30879f119146f4327fb94615a32e0","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# The action map."},{"line_number":165,"context_line":"ACTION_MAP \u003d {"},{"line_number":166,"context_line":"    \u0027firewall_policy\u0027: {\u0027insert_rule\u0027: \u0027PUT\u0027, \u0027remove_rule\u0027: \u0027PUT\u0027},"},{"line_number":167,"context_line":"}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# The list of required extensions."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_90999ad3","line":166,"range":{"start_line":166,"start_character":5,"end_line":166,"end_character":20},"in_reply_to":"5a3905b3_e0f3759c","updated":"2017-01-24 17:37:46.000000000","message":"Dont think its absolutely required, but its ok if done","commit_id":"5e6c287d7a1455575aee7960dc9184f650cca67d"}]}