)]}'
{"neutron_lib/api/definitions/provider_net.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"03ec7fda460506bcde65d549e603e2a7b824676f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    if any(validators.is_attr_set(attrs.get(a))"},{"line_number":124,"context_line":"           for a in ATTRIBUTES):"},{"line_number":125,"context_line":"        msg \u003d _(\"Plugin does not support updating provider attributes\")"},{"line_number":126,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_9b640ee6","line":126,"updated":"2017-02-06 07:05:48.000000000","message":"are these modules supposed to have this kind of code?\ni\u0027m not sure what\u0027s should be here and what should be in the extension module.","commit_id":"4764c09a6bd1c33886fbec38e3ac4694e72f1f4c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4fc9e11466c363e4e67a19679f6b43a235a93541","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    if any(validators.is_attr_set(attrs.get(a))"},{"line_number":124,"context_line":"           for a in ATTRIBUTES):"},{"line_number":125,"context_line":"        msg \u003d _(\"Plugin does not support updating provider attributes\")"},{"line_number":126,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_a9df23d4","line":126,"in_reply_to":"1a430d35_11630843","updated":"2017-02-09 08:30:50.000000000","message":"We have had many complaints about the fact that update is not supported.","commit_id":"4764c09a6bd1c33886fbec38e3ac4694e72f1f4c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ea6a68f1c2f97ae44269319edd56fe4ed5e1275c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    if any(validators.is_attr_set(attrs.get(a))"},{"line_number":124,"context_line":"           for a in ATTRIBUTES):"},{"line_number":125,"context_line":"        msg \u003d _(\"Plugin does not support updating provider attributes\")"},{"line_number":126,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_11630843","line":126,"in_reply_to":"1a430d35_51dcb045","updated":"2017-02-09 01:30:42.000000000","message":"actually there are some complaints. bug 1428062\ni guess it\u0027s reasonable to make it allow_put\u003dFalse to reflect the reality for now and consider an extension for updates if necessary though.","commit_id":"4764c09a6bd1c33886fbec38e3ac4694e72f1f4c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"aa8de3b60de5bedd8509d80b57d3af4195b4adce","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    if any(validators.is_attr_set(attrs.get(a))"},{"line_number":124,"context_line":"           for a in ATTRIBUTES):"},{"line_number":125,"context_line":"        msg \u003d _(\"Plugin does not support updating provider attributes\")"},{"line_number":126,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_51dcb045","line":126,"in_reply_to":"1a430d35_63788bf3","updated":"2017-02-09 01:10:20.000000000","message":"The real question is: are plugins supposed to do this? The answer is no. This is a violation of the API contract. It\u0027s even arguable that a plugin responds with a 400, because in reality the request is legit. The fact that this method was private should add to the smell. \n\nThis is legacy code that should have been addressed by now. If no plugin can ever be able to handle an update of these fields, honestly that begs the question as to why we \u0027allow_put\u0027 of these attributes in the first place. To my knowledge no-one has ever complained about lack of an update for provider network attributes, so is it now the time to have a discussion and decide whether or not we screwed up this API?","commit_id":"4764c09a6bd1c33886fbec38e3ac4694e72f1f4c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"acde1530f5ff1919639811dcd39d97c873bc63d3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    if any(validators.is_attr_set(attrs.get(a))"},{"line_number":124,"context_line":"           for a in ATTRIBUTES):"},{"line_number":125,"context_line":"        msg \u003d _(\"Plugin does not support updating provider attributes\")"},{"line_number":126,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_63788bf3","line":126,"in_reply_to":"1a430d35_9b640ee6","updated":"2017-02-06 13:51:07.000000000","message":"I guess we\u0027ll see what everyone thinks. IMO it makes sense given multiple subprojects use this [1] and it seems logical to live with the api-def.\n\n\n[1] http://codesearch.openstack.org/?q\u003draise_if_updates_provider_attributes","commit_id":"4764c09a6bd1c33886fbec38e3ac4694e72f1f4c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7a46aaca465533008fd8b0be534ea79e2961d9c2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    if any(validators.is_attr_set(attrs.get(a))"},{"line_number":124,"context_line":"           for a in ATTRIBUTES):"},{"line_number":125,"context_line":"        msg \u003d _(\"Plugin does not support updating provider attributes\")"},{"line_number":126,"context_line":"        raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_3a219db5","line":126,"in_reply_to":"1a430d35_a9df23d4","updated":"2017-02-09 16:09:25.000000000","message":"Let\u0027s fix it then!","commit_id":"4764c09a6bd1c33886fbec38e3ac4694e72f1f4c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6345c575bf13df6fbd8facf9ef1892ef6e8beb8e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from neutron_lib.api import converters"},{"line_number":16,"context_line":"from neutron_lib import constants"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# The alias of the extension."},{"line_number":20,"context_line":"ALIAS \u003d \u0027provider\u0027"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_585b1bf6","line":18,"updated":"2017-02-14 18:51:16.000000000","message":"this seems extraneous","commit_id":"81873939a727a9762bd9005667e4218411147777"}]}
