)]}'
{"neutron_lib/tests/unit/api/definitions/base.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"053091e943d081463b628a718a383b1f1395211b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        except KeyError:"},{"line_number":34,"context_line":"            if value \u003d\u003d []:"},{"line_number":35,"context_line":"                return"},{"line_number":36,"context_line":"            if validators.is_attr_set(value) and not isinstance(value, str):"},{"line_number":37,"context_line":"                tester.fail(\"Default value \u0027%s\u0027 cannot be converted for \""},{"line_number":38,"context_line":"                            \"attribute %s.\" % (value, attribute))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_acb8f8e9","line":36,"updated":"2017-02-01 16:42:23.000000000","message":"what about tweaking the latter condition with isinstance(value, (list, str))","commit_id":"b343afbbdb842079046b7915530e1ed52cb92fd8"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8ea74b6bdfdc141a55bad24de2eb8cff7176185c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        except KeyError:"},{"line_number":34,"context_line":"            if value \u003d\u003d []:"},{"line_number":35,"context_line":"                return"},{"line_number":36,"context_line":"            if validators.is_attr_set(value) and not isinstance(value, str):"},{"line_number":37,"context_line":"                tester.fail(\"Default value \u0027%s\u0027 cannot be converted for \""},{"line_number":38,"context_line":"                            \"attribute %s.\" % (value, attribute))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_acdb9820","line":36,"in_reply_to":"3a461143_acb8f8e9","updated":"2017-02-01 16:47:32.000000000","message":"To me the extra if provided here is easier to read than yet another condition in later if, but whatever works.","commit_id":"b343afbbdb842079046b7915530e1ed52cb92fd8"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"35390839a60e1ed5130e2d0664adefb6d03758f7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        except KeyError:"},{"line_number":34,"context_line":"            if value \u003d\u003d []:"},{"line_number":35,"context_line":"                return"},{"line_number":36,"context_line":"            if validators.is_attr_set(value) and not isinstance(value, str):"},{"line_number":37,"context_line":"                tester.fail(\"Default value \u0027%s\u0027 cannot be converted for \""},{"line_number":38,"context_line":"                            \"attribute %s.\" % (value, attribute))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_c7243db4","line":36,"in_reply_to":"3a461143_acdb9820","updated":"2017-02-01 16:58:31.000000000","message":"My bad: I misread and thought a new condition was needed. See PS2.","commit_id":"b343afbbdb842079046b7915530e1ed52cb92fd8"}]}