)]}'
{"neutron_lib/api/definitions/base.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ee034d085c62369dc770e8fee63e65e3ba96ce3e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # Add here list of extensions with pointers to the project repo, e.g."},{"line_number":83,"context_line":"    # \u0027bgp\u0027,  # http://git.openstack.org/cgit/openstack/neutron-dynamic-routing"},{"line_number":84,"context_line":"    \u0027fw\u0027,  # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":85,"context_line":"    \u0027fwaas\u0027,  # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# The following is a short reference for understanding attribute info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_a7547154","side":"PARENT","line":85,"updated":"2017-02-03 22:39:23.000000000","message":"These are the aliases as defined in [1,2]. You have them right in [3]\n\n[1] https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/services/firewall/fwaas_plugin.py#L147\n[2] https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/services/firewall/fwaas_plugin_v2.py#L140\n[3]","commit_id":"cf72bd10e60b172f03be6db2001e36b2cc2d7304"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6c493ef53084ca3fbbbf114ccc7c6d8d563806b7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # Add here list of extensions with pointers to the project repo, e.g."},{"line_number":83,"context_line":"    # \u0027bgp\u0027,  # http://git.openstack.org/cgit/openstack/neutron-dynamic-routing"},{"line_number":84,"context_line":"    \u0027fw\u0027,  # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":85,"context_line":"    \u0027fwaas\u0027,  # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# The following is a short reference for understanding attribute info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_4e647d48","side":"PARENT","line":85,"in_reply_to":"1a430d35_13effeb0","updated":"2017-02-06 22:48:20.000000000","message":"Yeah, I think that was an oversight. We tend to mix alias with the constant for plugin lookup, that itself may different from the entrypoint. In same cases they are the same, in some other they are not and that adds to the confusion :/","commit_id":"cf72bd10e60b172f03be6db2001e36b2cc2d7304"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3999bc7d789db71ea07b342107bfd30fe915990c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # Add here list of extensions with pointers to the project repo, e.g."},{"line_number":83,"context_line":"    # \u0027bgp\u0027,  # http://git.openstack.org/cgit/openstack/neutron-dynamic-routing"},{"line_number":84,"context_line":"    \u0027fw\u0027,  # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":85,"context_line":"    \u0027fwaas\u0027,  # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# The following is a short reference for understanding attribute info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_13effeb0","side":"PARENT","line":85,"in_reply_to":"1a430d35_2896604c","updated":"2017-02-06 22:13:04.000000000","message":"just because they are broken but unused yet?","commit_id":"cf72bd10e60b172f03be6db2001e36b2cc2d7304"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"15e5ff53dfb2bd3536663eb33dc7ca7a33ea88a4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # Add here list of extensions with pointers to the project repo, e.g."},{"line_number":83,"context_line":"    # \u0027bgp\u0027,  # http://git.openstack.org/cgit/openstack/neutron-dynamic-routing"},{"line_number":84,"context_line":"    \u0027fw\u0027,  # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":85,"context_line":"    \u0027fwaas\u0027,  # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# The following is a short reference for understanding attribute info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_2896604c","side":"PARENT","line":85,"in_reply_to":"1a430d35_9d56cbd0","updated":"2017-02-06 13:28:49.000000000","message":"So now I\u0027m confused. I see [1] and [2]. Why are these different from what Armando pointed out? I feel like I\u0027m missing something obvious here.\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/firewall.py#L19\n[2] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/firewall_v2.py#L19","commit_id":"cf72bd10e60b172f03be6db2001e36b2cc2d7304"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"863242d3c6f87bedb6d8fbece167165f3602141e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # Add here list of extensions with pointers to the project repo, e.g."},{"line_number":83,"context_line":"    # \u0027bgp\u0027,  # http://git.openstack.org/cgit/openstack/neutron-dynamic-routing"},{"line_number":84,"context_line":"    \u0027fw\u0027,  # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":85,"context_line":"    \u0027fwaas\u0027,  # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# The following is a short reference for understanding attribute info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_9d56cbd0","side":"PARENT","line":85,"in_reply_to":"1a430d35_a7547154","updated":"2017-02-05 23:09:29.000000000","message":"oops, i fixed the wrong ones.","commit_id":"cf72bd10e60b172f03be6db2001e36b2cc2d7304"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"af5057a89f683acac2857ee2d54572aef97adc23","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    # \u0027bgp\u0027,  # http://git.openstack.org/cgit/openstack/neutron-dynamic-routing"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":86,"context_line":"    \u0027fwaas\u0027,"},{"line_number":87,"context_line":"    \u0027fwaasrouterinsertion\u0027,"},{"line_number":88,"context_line":"    \u0027fwaas_v2\u0027,"},{"line_number":89,"context_line":")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_ce8bf6c1","line":86,"updated":"2017-02-07 11:40:01.000000000","message":"Shouldn\u0027t we also update the api-ref to reflect the proper extn name: https://developer.openstack.org/api-ref/networking/v2/#fwaas-v1-0-deprecated-fw-firewalls-firewall-policies-firewall-rules","commit_id":"645479ce1c2365e6397ac86f80253119186fe5c3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0351dc1dcd111580079e6702eb08c2b198190eb0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    # \u0027bgp\u0027,  # http://git.openstack.org/cgit/openstack/neutron-dynamic-routing"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":86,"context_line":"    \u0027fwaas\u0027,"},{"line_number":87,"context_line":"    \u0027fwaasrouterinsertion\u0027,"},{"line_number":88,"context_line":"    \u0027fwaas_v2\u0027,"},{"line_number":89,"context_line":")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_24fe11ae","line":86,"in_reply_to":"1a430d35_acc14856","updated":"2017-02-08 18:57:37.000000000","message":"IIUC, if you look at the API ref [1]; the FWaaS v1 and v2 sections, it appears the sections include the API extension \u0027alias\u0027 in the title.\n\n\nSo today [1] we have:\n- \"FWaaS v1.0 (DEPRECATED) (fw, firewalls, firewall_policies, firewall_rules)\"\n- \"FWaaS v2.0 (CURRENT) (fwaas, firewall_groups, firewall_policies, firewall_rules)\"\n\nBased on this change, should \u0027fw\u0027 in the v1 ref be \u0027fwaas\u0027 and \u0027fwaas\u0027 in v2 be \u0027fwaas_v2\u0027?\n\nAlso shouldn\u0027t we list the \u0027fwaasrouterinsertion\u0027 extension alias to indicate it provides respective APIs?\n\n\n[1] https://developer.openstack.org/api-ref/networking/v2/index.html#security","commit_id":"645479ce1c2365e6397ac86f80253119186fe5c3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"decb4effd86b7c9c58461f92fddb317f446de83e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    # \u0027bgp\u0027,  # http://git.openstack.org/cgit/openstack/neutron-dynamic-routing"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":86,"context_line":"    \u0027fwaas\u0027,"},{"line_number":87,"context_line":"    \u0027fwaasrouterinsertion\u0027,"},{"line_number":88,"context_line":"    \u0027fwaas_v2\u0027,"},{"line_number":89,"context_line":")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_acc14856","line":86,"in_reply_to":"1a430d35_ce8bf6c1","updated":"2017-02-07 15:50:03.000000000","message":"what do you mean, exactly? They seem correct to me.","commit_id":"645479ce1c2365e6397ac86f80253119186fe5c3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"af5057a89f683acac2857ee2d54572aef97adc23","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    # http://git.openstack.org/cgit/openstack/neutron-fwaas"},{"line_number":86,"context_line":"    \u0027fwaas\u0027,"},{"line_number":87,"context_line":"    \u0027fwaasrouterinsertion\u0027,"},{"line_number":88,"context_line":"    \u0027fwaas_v2\u0027,"},{"line_number":89,"context_line":")"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# The following is a short reference for understanding attribute info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_0e925ef6","line":88,"updated":"2017-02-07 11:40:01.000000000","message":"Ditto.","commit_id":"645479ce1c2365e6397ac86f80253119186fe5c3"}]}