)]}'
{"neutron_lib/api/definitions/base.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"18e0be31f33bbf96c1b110b471eb729a6e898281","unresolved":false,"context_lines":[{"line_number":48,"context_line":"KNOWN_RESOURCES \u003d ("},{"line_number":49,"context_line":"    \u0027networks\u0027,"},{"line_number":50,"context_line":"    \u0027ports\u0027,"},{"line_number":51,"context_line":"    \u0027subnets\u0027,"},{"line_number":52,"context_line":"    \u0027routers\u0027,"},{"line_number":53,"context_line":")"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_b4fb4a77","line":51,"updated":"2017-03-28 07:56:48.000000000","message":"Could you add subnetpools?","commit_id":"328b6346e828cf9d1f9504272eb2077c5f54353e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"99a2362b7a7663a781f360dd37c3a8565f9b29a4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"KNOWN_RESOURCES \u003d ("},{"line_number":49,"context_line":"    \u0027networks\u0027,"},{"line_number":50,"context_line":"    \u0027ports\u0027,"},{"line_number":51,"context_line":"    \u0027subnets\u0027,"},{"line_number":52,"context_line":"    \u0027routers\u0027,"},{"line_number":53,"context_line":")"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_c720f2fa","line":51,"in_reply_to":"ffe62b97_b4fb4a77","updated":"2017-03-30 18:08:59.000000000","message":"Done","commit_id":"328b6346e828cf9d1f9504272eb2077c5f54353e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f9f4258015ae97b58e66e9b8ed7b942769595b31","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"KNOWN_ATTRIBUTES \u003d ("},{"line_number":14,"context_line":"    \u0027admin_state_up\u0027,"},{"line_number":15,"context_line":"    \u0027allocation_pools\u0027,"},{"line_number":16,"context_line":"    \u0027cidr\u0027,"},{"line_number":17,"context_line":"    \u0027default_prefixlen\u0027,"},{"line_number":18,"context_line":"    \u0027default_quota\u0027,"},{"line_number":19,"context_line":"    \u0027device_owner\u0027,"},{"line_number":20,"context_line":"    \u0027dns_nameservers\u0027,"},{"line_number":21,"context_line":"    \u0027id\u0027,"},{"line_number":22,"context_line":"    \u0027description\u0027,"},{"line_number":23,"context_line":"    \u0027device_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_12794dfb","line":20,"range":{"start_line":15,"start_character":2,"end_line":20,"end_character":22},"updated":"2017-04-06 11:03:35.000000000","message":"nit : If we are going to keep the attributes alphabetically, then lets do it with the exising attributes as well, i.e. move description from Line#22 to Line#20","commit_id":"37d60e67a79159df822b41517e52cf9fe3c947d6"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ddb1846e70b71d124a6b18382107eac5cbf331b0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"KNOWN_ATTRIBUTES \u003d ("},{"line_number":14,"context_line":"    \u0027admin_state_up\u0027,"},{"line_number":15,"context_line":"    \u0027allocation_pools\u0027,"},{"line_number":16,"context_line":"    \u0027cidr\u0027,"},{"line_number":17,"context_line":"    \u0027default_prefixlen\u0027,"},{"line_number":18,"context_line":"    \u0027default_quota\u0027,"},{"line_number":19,"context_line":"    \u0027device_owner\u0027,"},{"line_number":20,"context_line":"    \u0027dns_nameservers\u0027,"},{"line_number":21,"context_line":"    \u0027id\u0027,"},{"line_number":22,"context_line":"    \u0027description\u0027,"},{"line_number":23,"context_line":"    \u0027device_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_ce3aeb32","line":20,"range":{"start_line":15,"start_character":2,"end_line":20,"end_character":22},"in_reply_to":"bff0334d_12794dfb","updated":"2017-04-07 13:51:27.000000000","message":"Done","commit_id":"37d60e67a79159df822b41517e52cf9fe3c947d6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f9f4258015ae97b58e66e9b8ed7b942769595b31","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u0027ports\u0027,"},{"line_number":51,"context_line":"    \u0027subnets\u0027,"},{"line_number":52,"context_line":"    \u0027subnetpools\u0027,"},{"line_number":53,"context_line":"    \u0027routers\u0027,"},{"line_number":54,"context_line":")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"KNOWN_HTTP_ACTIONS \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_b28741d8","line":53,"range":{"start_line":53,"start_character":5,"end_line":53,"end_character":12},"updated":"2017-04-06 11:03:35.000000000","message":"ditto","commit_id":"37d60e67a79159df822b41517e52cf9fe3c947d6"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ddb1846e70b71d124a6b18382107eac5cbf331b0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u0027ports\u0027,"},{"line_number":51,"context_line":"    \u0027subnets\u0027,"},{"line_number":52,"context_line":"    \u0027subnetpools\u0027,"},{"line_number":53,"context_line":"    \u0027routers\u0027,"},{"line_number":54,"context_line":")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"KNOWN_HTTP_ACTIONS \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_ae49e7d0","line":53,"range":{"start_line":53,"start_character":5,"end_line":53,"end_character":12},"in_reply_to":"bff0334d_b28741d8","updated":"2017-04-07 13:51:27.000000000","message":"Done","commit_id":"37d60e67a79159df822b41517e52cf9fe3c947d6"}],"neutron_lib/api/definitions/subnetpool.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f9f4258015ae97b58e66e9b8ed7b942769595b31","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                          \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":53,"context_line":"                          \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"        \u0027ip_version\u0027: {\u0027allow_post\u0027: False,"},{"line_number":55,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":56,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":57,"context_line":"        \u0027default_prefixlen\u0027: {\u0027allow_post\u0027: True,"},{"line_number":58,"context_line":"                              \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_b2a3c14f","line":55,"updated":"2017-04-06 11:03:35.000000000","message":"should we validate this ?","commit_id":"37d60e67a79159df822b41517e52cf9fe3c947d6"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ddb1846e70b71d124a6b18382107eac5cbf331b0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                          \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":53,"context_line":"                          \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"        \u0027ip_version\u0027: {\u0027allow_post\u0027: False,"},{"line_number":55,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":56,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":57,"context_line":"        \u0027default_prefixlen\u0027: {\u0027allow_post\u0027: True,"},{"line_number":58,"context_line":"                              \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_ce68ab22","line":55,"in_reply_to":"bff0334d_b2a3c14f","updated":"2017-04-07 13:51:27.000000000","message":"Sorry, I\u0027m not following your comment. Can you please clarify?","commit_id":"37d60e67a79159df822b41517e52cf9fe3c947d6"}],"neutron_lib/tests/unit/api/definitions/base.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"30b5cc5c7950f2420d8fdcaff1309eca038acfed","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        \u0027%s must be a boolean for %s.\u0027 % (keyword, attribute))"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def assert_converter(tester, attribute, attribute_dict, keyword, value):"},{"line_number":30,"context_line":"    try:"},{"line_number":31,"context_line":"        if attribute_dict[\u0027default\u0027] is constants.ATTR_NOT_SPECIFIED:"},{"line_number":32,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_337bd2f5","line":29,"updated":"2017-04-04 20:37:27.000000000","message":"I guess that the following is better than expanding try-statement.\n\n def assert_converter(tester, attribute, attribute_dict, keyword, value):\n     if not \u0027default\u0027 in attribute_dict:\n         return","commit_id":"f566582a44b516dfc5544da2ecc0bc4b6f6e0ece"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a428634a0882d4d9b08417ee1121e559dd43506a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        \u0027%s must be a boolean for %s.\u0027 % (keyword, attribute))"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def assert_converter(tester, attribute, attribute_dict, keyword, value):"},{"line_number":30,"context_line":"    try:"},{"line_number":31,"context_line":"        if attribute_dict[\u0027default\u0027] is constants.ATTR_NOT_SPECIFIED:"},{"line_number":32,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_0e0d41a0","line":29,"in_reply_to":"dfeb2761_337bd2f5","updated":"2017-04-04 21:03:59.000000000","message":"Seems like maybe we\u0027re splitting hairs here given this is a UT, but OK.","commit_id":"f566582a44b516dfc5544da2ecc0bc4b6f6e0ece"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8a09284aa055033489b45f40d57627cba6783cfc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            attribute_dict[\u0027convert_list_to\u0027](attribute_dict[\u0027default\u0027])"},{"line_number":38,"context_line":"        except KeyError:"},{"line_number":39,"context_line":"            if validators.is_attr_set(value) and not isinstance("},{"line_number":40,"context_line":"                    value, (str, list)) and \u0027default\u0027 in attribute_dict:"},{"line_number":41,"context_line":"                tester.fail(\"Default value \u0027%s\u0027 cannot be converted for \""},{"line_number":42,"context_line":"                            \"attribute %s.\" % (value, attribute))"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_e84c5043","line":40,"range":{"start_line":40,"start_character":39,"end_line":40,"end_character":71},"updated":"2017-04-04 22:49:57.000000000","message":"This change should be removed because it\u0027s already checked on L30.","commit_id":"4fcc0d0cf923bd7c40e640850372300a65ab7287"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d2de17e108a106b4237edd0e744a251af9ae6a20","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            attribute_dict[\u0027convert_list_to\u0027](attribute_dict[\u0027default\u0027])"},{"line_number":38,"context_line":"        except KeyError:"},{"line_number":39,"context_line":"            if validators.is_attr_set(value) and not isinstance("},{"line_number":40,"context_line":"                    value, (str, list)) and \u0027default\u0027 in attribute_dict:"},{"line_number":41,"context_line":"                tester.fail(\"Default value \u0027%s\u0027 cannot be converted for \""},{"line_number":42,"context_line":"                            \"attribute %s.\" % (value, attribute))"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_b9085e28","line":40,"range":{"start_line":40,"start_character":39,"end_line":40,"end_character":71},"in_reply_to":"dfeb2761_e84c5043","updated":"2017-04-05 21:52:54.000000000","message":"Good point.","commit_id":"4fcc0d0cf923bd7c40e640850372300a65ab7287"}],"neutron_lib/tests/unit/api/definitions/test_network.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"18e0be31f33bbf96c1b110b471eb729a6e898281","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class NetworkDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d network"},{"line_number":19,"context_line":"    extension_resources \u003d (network.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_14e436e0","line":19,"range":{"start_line":19,"start_character":27,"end_line":19,"end_character":50},"updated":"2017-03-28 07:56:48.000000000","message":"The \u0027networks\u0027 is not a extension resource.","commit_id":"328b6346e828cf9d1f9504272eb2077c5f54353e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"99a2362b7a7663a781f360dd37c3a8565f9b29a4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class NetworkDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d network"},{"line_number":19,"context_line":"    extension_resources \u003d (network.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_8761ca3c","line":19,"range":{"start_line":19,"start_character":27,"end_line":19,"end_character":50},"in_reply_to":"ffe62b97_14e436e0","updated":"2017-03-30 18:08:59.000000000","message":"Done","commit_id":"328b6346e828cf9d1f9504272eb2077c5f54353e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"30b5cc5c7950f2420d8fdcaff1309eca038acfed","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class NetworkDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d network"},{"line_number":19,"context_line":"    extension_attributes \u003d ()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_53f89647","line":18,"updated":"2017-04-04 20:37:27.000000000","message":"nit(not need to reflect): this still says \"network\" resource is extension. It\u0027s confused a little. Let\u0027s give appropriate name for core resources after this patch has been merged.","commit_id":"f566582a44b516dfc5544da2ecc0bc4b6f6e0ece"}],"neutron_lib/tests/unit/api/definitions/test_port.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"18e0be31f33bbf96c1b110b471eb729a6e898281","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class PortDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d port"},{"line_number":19,"context_line":"    extension_resources \u003d (port.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_94cf2655","line":19,"range":{"start_line":19,"start_character":27,"end_line":19,"end_character":47},"updated":"2017-03-28 07:56:48.000000000","message":"The \u0027ports\u0027 is not a extension resource.","commit_id":"328b6346e828cf9d1f9504272eb2077c5f54353e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"99a2362b7a7663a781f360dd37c3a8565f9b29a4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class PortDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d port"},{"line_number":19,"context_line":"    extension_resources \u003d (port.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_2760be32","line":19,"range":{"start_line":19,"start_character":27,"end_line":19,"end_character":47},"in_reply_to":"ffe62b97_94cf2655","updated":"2017-03-30 18:08:59.000000000","message":"Done","commit_id":"328b6346e828cf9d1f9504272eb2077c5f54353e"}],"neutron_lib/tests/unit/api/definitions/test_subnet.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"18e0be31f33bbf96c1b110b471eb729a6e898281","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SubnetDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d subnet"},{"line_number":19,"context_line":"    extension_resources \u003d (subnet.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_34085a90","line":19,"range":{"start_line":19,"start_character":27,"end_line":19,"end_character":49},"updated":"2017-03-28 07:56:48.000000000","message":"The \u0027subnets\u0027 is not a extension resource.","commit_id":"328b6346e828cf9d1f9504272eb2077c5f54353e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"99a2362b7a7663a781f360dd37c3a8565f9b29a4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SubnetDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d subnet"},{"line_number":19,"context_line":"    extension_resources \u003d (subnet.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_c74eb2c0","line":19,"range":{"start_line":19,"start_character":27,"end_line":19,"end_character":49},"in_reply_to":"ffe62b97_34085a90","updated":"2017-03-30 18:08:59.000000000","message":"Done","commit_id":"328b6346e828cf9d1f9504272eb2077c5f54353e"}],"neutron_lib/tests/unit/api/definitions/test_subnetpool.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"18e0be31f33bbf96c1b110b471eb729a6e898281","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SubnetPoolDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d subnetpool"},{"line_number":19,"context_line":"    extension_resources \u003d (subnetpool.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_140d56a0","line":19,"range":{"start_line":19,"start_character":27,"end_line":19,"end_character":53},"updated":"2017-03-28 07:56:48.000000000","message":"The \u0027subnetpools\u0027 is not a extension resource.","commit_id":"328b6346e828cf9d1f9504272eb2077c5f54353e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"99a2362b7a7663a781f360dd37c3a8565f9b29a4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SubnetPoolDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d subnetpool"},{"line_number":19,"context_line":"    extension_resources \u003d (subnetpool.COLLECTION_NAME,)"},{"line_number":20,"context_line":"    extension_attributes \u003d ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_67cb661e","line":19,"range":{"start_line":19,"start_character":27,"end_line":19,"end_character":53},"in_reply_to":"ffe62b97_140d56a0","updated":"2017-03-30 18:08:59.000000000","message":"Done","commit_id":"328b6346e828cf9d1f9504272eb2077c5f54353e"}]}
