)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cb98b82b898c2890acd27395cd935ecaf048019a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hirofumi Ichihara \u003cichihara.hirofumi@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-26 22:33:33 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rehome tag extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If61c108d2eeee858b9c49bf6b7ea8574972e26c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_70d195fb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"updated":"2017-03-26 13:40:15.000000000","message":"Lets add some more details about the migration","commit_id":"ddbef2809011a206706f188bc69f1ff0205c0e00"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5257fbe8f742bb72265d2248659ac115fba80382","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hirofumi Ichihara \u003cichihara.hirofumi@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-26 22:33:33 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rehome tag extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If61c108d2eeee858b9c49bf6b7ea8574972e26c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_703f5525","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"in_reply_to":"ffe62b97_70d195fb","updated":"2017-03-26 13:45:46.000000000","message":"I will :)","commit_id":"ddbef2809011a206706f188bc69f1ff0205c0e00"}],"neutron_lib/api/definitions/tag.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8cda80b1685a709f016eb165604537b7877104d7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"API_PREFIX \u003d \u0027\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# The description of the extension (mandatory)."},{"line_number":39,"context_line":"DESCRIPTION \u003d \"Enables to set tag on resources.\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# A timestamp of when the extension was introduced (mandatory)."},{"line_number":42,"context_line":"UPDATED_TIMESTAMP \u003d \"2016-01-01T00:00:00-00:00\""}],"source_content_type":"text/x-python","patch_set":6,"id":"dfeb2761_6e1f2db7","line":39,"range":{"start_line":39,"start_character":15,"end_line":39,"end_character":47},"updated":"2017-04-04 21:16:31.000000000","message":"What about something like \"Enables tagging of networking resources.\"?","commit_id":"66105dcc7fae81538bd30a1fd18e5300e4bbf8ad"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9c53c553e324cbc0e589fcb8b50431c2fbdfd651","unresolved":false,"context_lines":[{"line_number":36,"context_line":"API_PREFIX \u003d \u0027\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# The description of the extension (mandatory)."},{"line_number":39,"context_line":"DESCRIPTION \u003d \"Enables to set tag on resources.\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# A timestamp of when the extension was introduced (mandatory)."},{"line_number":42,"context_line":"UPDATED_TIMESTAMP \u003d \"2016-01-01T00:00:00-00:00\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_87e9b681","line":39,"range":{"start_line":39,"start_character":15,"end_line":39,"end_character":47},"in_reply_to":"dfeb2761_6e1f2db7","updated":"2017-04-05 22:01:39.000000000","message":"Is the change important? If so, I can change. However I basically don\u0027t want to change because this is \"rehome\" patch and I think that it\u0027s better to change in neutron-tree first if it\u0027s needed.","commit_id":"66105dcc7fae81538bd30a1fd18e5300e4bbf8ad"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8cda80b1685a709f016eb165604537b7877104d7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"TAGS \u003d TAG + \u0027s\u0027"},{"line_number":46,"context_line":"MAX_TAG_LEN \u003d 60"},{"line_number":47,"context_line":"TAG_PLUGIN_TYPE \u003d \u0027TAG\u0027"},{"line_number":48,"context_line":"TAG_SUPPORTED_RESOURCES \u003d {"},{"line_number":49,"context_line":"    # We shouldn\u0027t add new resources here. If more resources need to be tagged,"},{"line_number":50,"context_line":"    # we must add them in new extension."},{"line_number":51,"context_line":"    \u0027networks\u0027: \u0027network\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfeb2761_cea19948","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":23},"updated":"2017-04-04 21:16:31.000000000","message":"This doesn\u0027t seem like something we\u0027d want to make public in lib; I don\u0027t see it used outside of the extension code in neutron [1]. I\u0027m thinking this one stays in neutron and is made private to indicate we don\u0027t want consumers using it.\n\n\n[1] http://codesearch.openstack.org/?q\u003dTAG_SUPPORTED_RESOURCES","commit_id":"66105dcc7fae81538bd30a1fd18e5300e4bbf8ad"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9c53c553e324cbc0e589fcb8b50431c2fbdfd651","unresolved":false,"context_lines":[{"line_number":45,"context_line":"TAGS \u003d TAG + \u0027s\u0027"},{"line_number":46,"context_line":"MAX_TAG_LEN \u003d 60"},{"line_number":47,"context_line":"TAG_PLUGIN_TYPE \u003d \u0027TAG\u0027"},{"line_number":48,"context_line":"TAG_SUPPORTED_RESOURCES \u003d {"},{"line_number":49,"context_line":"    # We shouldn\u0027t add new resources here. If more resources need to be tagged,"},{"line_number":50,"context_line":"    # we must add them in new extension."},{"line_number":51,"context_line":"    \u0027networks\u0027: \u0027network\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_279f8a51","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":23},"in_reply_to":"dfeb2761_cea19948","updated":"2017-04-05 22:01:39.000000000","message":"Now it\u0027s not used but it doesn\u0027t mean it never be used in future. It\u0027s the only information what resource does this extension support. I believe that it\u0027s useful if sub-project supports tag mechanism.","commit_id":"66105dcc7fae81538bd30a1fd18e5300e4bbf8ad"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8cda80b1685a709f016eb165604537b7877104d7","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    # we must add them in new extension."},{"line_number":51,"context_line":"    \u0027networks\u0027: \u0027network\u0027"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":"NETWORKS \u003d \u0027networks\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# The resource attribute map for the extension. It is effectively the"},{"line_number":56,"context_line":"# bulk of the API contract alongside ACTION_MAP (mandatory)."}],"source_content_type":"text/x-python","patch_set":6,"id":"dfeb2761_eee7bdab","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":8},"updated":"2017-04-04 21:16:31.000000000","message":"For consistency I think this should be COLLECTION_NAME. For example see how neutron_lib.api.definitions.portbindings is done.","commit_id":"66105dcc7fae81538bd30a1fd18e5300e4bbf8ad"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9c53c553e324cbc0e589fcb8b50431c2fbdfd651","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    # we must add them in new extension."},{"line_number":51,"context_line":"    \u0027networks\u0027: \u0027network\u0027"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":"NETWORKS \u003d \u0027networks\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# The resource attribute map for the extension. It is effectively the"},{"line_number":56,"context_line":"# bulk of the API contract alongside ACTION_MAP (mandatory)."}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_59c27287","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":8},"in_reply_to":"dfeb2761_eee7bdab","updated":"2017-04-05 22:01:39.000000000","message":"Done","commit_id":"66105dcc7fae81538bd30a1fd18e5300e4bbf8ad"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"815e997a7cec5f59a512729754b2058fc012af1e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"API_PREFIX \u003d \u0027\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# The description of the extension (mandatory)."},{"line_number":39,"context_line":"DESCRIPTION \u003d \"Enables to set tag on resources.\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# A timestamp of when the extension was introduced (mandatory)."},{"line_number":42,"context_line":"UPDATED_TIMESTAMP \u003d \"2016-01-01T00:00:00-00:00\""}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_310653d0","line":39,"range":{"start_line":39,"start_character":15,"end_line":39,"end_character":47},"updated":"2017-04-07 15:26:14.000000000","message":"Would something like \"Enables support for tagging of networking resources.\" read easier?","commit_id":"7699e70b58fca782bb97e5446fc972970374acc7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"815e997a7cec5f59a512729754b2058fc012af1e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"TAG_SUPPORTED_RESOURCES \u003d {"},{"line_number":49,"context_line":"    # We shouldn\u0027t add new resources here. If more resources need to be tagged,"},{"line_number":50,"context_line":"    # we must add them in new extension."},{"line_number":51,"context_line":"    \u0027networks\u0027: \u0027network\u0027"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"COLLECTION_NAME \u003d \u0027networks\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_d12ba72d","line":51,"updated":"2017-04-07 15:26:14.000000000","message":"Once [1] lands, IMO it\u0027s worth updating this to use the constant from the network api-def.\n\n\n[1] I549bd94852395c62b5c73fb3c9681206d734e559","commit_id":"7699e70b58fca782bb97e5446fc972970374acc7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"815e997a7cec5f59a512729754b2058fc012af1e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"ACTION_STATUS \u003d {\u0027index\u0027: 200, \u0027show\u0027: 204, \u0027update\u0027: 201, \u0027update_all\u0027: 200,"},{"line_number":80,"context_line":"                 \u0027delete\u0027: 204, \u0027delete_all\u0027: 204}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# The list of required extensions (mandatory)."}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_b1e70313","line":79,"updated":"2017-04-07 15:26:14.000000000","message":"We don\u0027t really have \"support\" this yet until [1] lands.\n\n[1] https://review.openstack.org/#/c/450015/","commit_id":"7699e70b58fca782bb97e5446fc972970374acc7"}],"neutron_lib/exceptions/tag.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"815e997a7cec5f59a512729754b2058fc012af1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bff0334d_f1b22be6","updated":"2017-04-07 15:26:14.000000000","message":"Do we really think it\u0027s necessary to rehome these exceptions? I don\u0027t see them used outside neutron, so perhaps we should just leave them there and make them private (to discourage use)?","commit_id":"7699e70b58fca782bb97e5446fc972970374acc7"}],"releasenotes/notes/tag-apidef-72e247e218b735be.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8cda80b1685a709f016eb165604537b7877104d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The ``tag`` API definition from ``neutron.extensions.tag`` have been"},{"line_number":4,"context_line":"    rehomed to ``neutron_lib.api.definitions`` as the module ``tag``."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfeb2761_2e65a51e","line":3,"range":{"start_line":3,"start_character":63,"end_line":3,"end_character":67},"updated":"2017-04-04 21:16:31.000000000","message":"Nit: \"has\"","commit_id":"66105dcc7fae81538bd30a1fd18e5300e4bbf8ad"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9c53c553e324cbc0e589fcb8b50431c2fbdfd651","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The ``tag`` API definition from ``neutron.extensions.tag`` have been"},{"line_number":4,"context_line":"    rehomed to ``neutron_lib.api.definitions`` as the module ``tag``."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_59703273","line":3,"range":{"start_line":3,"start_character":63,"end_line":3,"end_character":67},"in_reply_to":"dfeb2761_2e65a51e","updated":"2017-04-05 22:01:39.000000000","message":"Done","commit_id":"66105dcc7fae81538bd30a1fd18e5300e4bbf8ad"}]}