)]}'
{"api-ref/source/v2/fwaas-v2.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"367f7832cfdc5df52d29d2818ac89eae1f737b31","unresolved":false,"context_lines":[{"line_number":85,"context_line":"Response Example"},{"line_number":86,"context_line":"----------------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. literalinclude:: samples/firewall-v2/firewall-groups-list-response.json"},{"line_number":89,"context_line":"   :language: javascript"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Show firewall group details"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"bff0334d_91519f65","line":88,"updated":"2017-04-07 15:33:18.000000000","message":"Doesn\u0027t this example json need updating as well?","commit_id":"ebe880bed1751ac544e9cd5cb1884132187765d7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a3c7b95e930473be05a4529504e7172b62f766ea","unresolved":false,"context_lines":[{"line_number":85,"context_line":"Response Example"},{"line_number":86,"context_line":"----------------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. literalinclude:: samples/firewall-v2/firewall-groups-list-response.json"},{"line_number":89,"context_line":"   :language: javascript"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Show firewall group details"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"bff0334d_1d0c27a3","line":88,"in_reply_to":"bff0334d_91519f65","updated":"2017-04-11 15:54:42.000000000","message":"Done","commit_id":"ebe880bed1751ac544e9cd5cb1884132187765d7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"367f7832cfdc5df52d29d2818ac89eae1f737b31","unresolved":false,"context_lines":[{"line_number":220,"context_line":"   - firewall_group: firewall_group_object"},{"line_number":221,"context_line":"   - admin_state_up: firewall_group_admin_state_up-body-optional"},{"line_number":222,"context_line":"   - description: firewall_group_description-body-optional"},{"line_number":223,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id-body-optional"},{"line_number":224,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id-body-optional"},{"line_number":225,"context_line":"   - name: firewall_group_name-body-optional"},{"line_number":226,"context_line":"   - ports: firewall_group_ports-body-optional"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"bff0334d_518e77d0","line":223,"updated":"2017-04-07 15:33:18.000000000","message":"Can\u0027t update \u0027shared\u0027 here? or maybe that\u0027s coming in a later patch?","commit_id":"ebe880bed1751ac544e9cd5cb1884132187765d7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a3c7b95e930473be05a4529504e7172b62f766ea","unresolved":false,"context_lines":[{"line_number":220,"context_line":"   - firewall_group: firewall_group_object"},{"line_number":221,"context_line":"   - admin_state_up: firewall_group_admin_state_up-body-optional"},{"line_number":222,"context_line":"   - description: firewall_group_description-body-optional"},{"line_number":223,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id-body-optional"},{"line_number":224,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id-body-optional"},{"line_number":225,"context_line":"   - name: firewall_group_name-body-optional"},{"line_number":226,"context_line":"   - ports: firewall_group_ports-body-optional"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"bff0334d_fdfe2369","line":223,"in_reply_to":"bff0334d_518e77d0","updated":"2017-04-11 15:54:42.000000000","message":"Done","commit_id":"ebe880bed1751ac544e9cd5cb1884132187765d7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"367f7832cfdc5df52d29d2818ac89eae1f737b31","unresolved":false,"context_lines":[{"line_number":253,"context_line":"Response Example"},{"line_number":254,"context_line":"----------------"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":".. literalinclude:: samples/firewall-v2/firewall-group-update-response.json"},{"line_number":257,"context_line":"   :language: javascript"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Delete firewall group"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"bff0334d_51f9d74a","line":256,"updated":"2017-04-07 15:33:18.000000000","message":"Don\u0027t we need to update this sample json?","commit_id":"ebe880bed1751ac544e9cd5cb1884132187765d7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a3c7b95e930473be05a4529504e7172b62f766ea","unresolved":false,"context_lines":[{"line_number":253,"context_line":"Response Example"},{"line_number":254,"context_line":"----------------"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":".. literalinclude:: samples/firewall-v2/firewall-group-update-response.json"},{"line_number":257,"context_line":"   :language: javascript"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Delete firewall group"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"bff0334d_dd011f6c","line":256,"in_reply_to":"bff0334d_51f9d74a","updated":"2017-04-11 15:54:42.000000000","message":"Done","commit_id":"ebe880bed1751ac544e9cd5cb1884132187765d7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0e6e4d804d316a56fa686981c86a04d1a82487","unresolved":false,"context_lines":[{"line_number":219,"context_line":"   - firewall_group_id: firewall_group_id-path-required"},{"line_number":220,"context_line":"   - firewall_group: firewall_group_object"},{"line_number":221,"context_line":"   - admin_state_up: firewall_group_admin_state_up-body-optional"},{"line_number":222,"context_line":"   - description: firewall_group_description-body-optional"},{"line_number":223,"context_line":"   - egress_firewall_policy_id: egress_firewall_policy_id-body-optional"},{"line_number":224,"context_line":"   - ingress_firewall_policy_id: ingress_firewall_policy_id-body-optional"},{"line_number":225,"context_line":"   - name: firewall_group_name-body-optional"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bff0334d_76643f4a","line":222,"updated":"2017-04-12 20:22:05.000000000","message":"Can shared by updated here??","commit_id":"10e71ffac2a7da1f2eeb229158a1a983ec67c4d1"}],"api-ref/source/v2/samples/firewall-v2/firewall-rule-update-request.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"69bcc92fadf3a9f01b9256bb3a2759b4c03c6646","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"firewall_rule\": {"},{"line_number":3,"context_line":"        \"shared\": \"true\""},{"line_number":4,"context_line":"    }"},{"line_number":5,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"9ff52f3f_1a929ff7","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":23},"updated":"2017-04-13 12:18:15.000000000","message":"true is a boolean, not a string so should just be::\n\n  true","commit_id":"ef1249c8aa9c1bbe62a84337b09c8d111b206e47"}],"neutron_lib/api/definitions/firewall_v2.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3f0e6e4d804d316a56fa686981c86a04d1a82487","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                           \u0027convert_to\u0027: converters.convert_to_boolean},"},{"line_number":121,"context_line":"        \u0027status\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":122,"context_line":"                   \u0027is_visible\u0027: True},"},{"line_number":123,"context_line":"        \u0027shared\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True, \u0027default\u0027: False,"},{"line_number":124,"context_line":"                   \u0027convert_to\u0027: converters.convert_to_boolean,"},{"line_number":125,"context_line":"                   \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"},{"line_number":126,"context_line":"                   \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_360c7792","line":123,"updated":"2017-04-12 20:22:05.000000000","message":"These APIs support both public and shared for now??","commit_id":"10e71ffac2a7da1f2eeb229158a1a983ec67c4d1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7882b95730acd98006fd93969182463077b2b47d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                           \u0027convert_to\u0027: converters.convert_to_boolean},"},{"line_number":121,"context_line":"        \u0027status\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":122,"context_line":"                   \u0027is_visible\u0027: True},"},{"line_number":123,"context_line":"        \u0027shared\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True, \u0027default\u0027: False,"},{"line_number":124,"context_line":"                   \u0027convert_to\u0027: converters.convert_to_boolean,"},{"line_number":125,"context_line":"                   \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"},{"line_number":126,"context_line":"                   \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ff52f3f_bcdcd818","line":123,"in_reply_to":"bff0334d_360c7792","updated":"2017-04-13 09:15:55.000000000","message":"No, earlier it was decided that if FWaaS takes time, then we can support both Shared and Public in the API for now, but as the FWaaS patch merged, therefore public has been removed in the next PS","commit_id":"10e71ffac2a7da1f2eeb229158a1a983ec67c4d1"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"69bcc92fadf3a9f01b9256bb3a2759b4c03c6646","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                   \u0027convert_to\u0027: converters.convert_to_boolean,"},{"line_number":162,"context_line":"                   \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"},{"line_number":163,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":164,"context_line":"        \u0027firewall_rules\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":165,"context_line":"                           \u0027validate\u0027: {\u0027type:uuid_list\u0027: None},"},{"line_number":166,"context_line":"                           \u0027convert_to\u0027: converters.convert_none_to_empty_list,"},{"line_number":167,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ff52f3f_5a3ee729","side":"PARENT","line":164,"updated":"2017-04-13 12:18:15.000000000","message":"Did we intend to remove the \u0027firewall_rules\u0027 attribute?","commit_id":"24ea6f3529de0f93e2c760f0954acfe55e04f24d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8f363d63748c44ca8f01f75e1ceb99444cb48fe7","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                   \u0027convert_to\u0027: converters.convert_to_boolean,"},{"line_number":162,"context_line":"                   \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"},{"line_number":163,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":164,"context_line":"        \u0027firewall_rules\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":165,"context_line":"                           \u0027validate\u0027: {\u0027type:uuid_list\u0027: None},"},{"line_number":166,"context_line":"                           \u0027convert_to\u0027: converters.convert_none_to_empty_list,"},{"line_number":167,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ffa3b31_e12080b3","side":"PARENT","line":164,"in_reply_to":"9ff52f3f_5a3ee729","updated":"2017-04-13 20:54:44.000000000","message":"This change was wrong","commit_id":"24ea6f3529de0f93e2c760f0954acfe55e04f24d"}],"releasenotes/notes/migrate-public-to-shared-0c67b32f9c37c751.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"69bcc92fadf3a9f01b9256bb3a2759b4c03c6646","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    FWaaS has renamed the ``Public`` attribute to ``Shared`` to be"},{"line_number":5,"context_line":"    in-sunc with Openstack nomenclature based on the functionality"},{"line_number":6,"context_line":"    the ``shared`` attribute provides."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ff52f3f_3a24430d","line":4,"range":{"start_line":4,"start_character":52,"end_line":4,"end_character":53},"updated":"2017-04-13 12:18:15.000000000","message":"Ditto.","commit_id":"ef1249c8aa9c1bbe62a84337b09c8d111b206e47"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"69bcc92fadf3a9f01b9256bb3a2759b4c03c6646","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    FWaaS has renamed the ``Public`` attribute to ``Shared`` to be"},{"line_number":5,"context_line":"    in-sunc with Openstack nomenclature based on the functionality"},{"line_number":6,"context_line":"    the ``shared`` attribute provides."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ff52f3f_5a270714","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":29},"updated":"2017-04-13 12:18:15.000000000","message":"``public``: no capital \u0027P\u0027.","commit_id":"ef1249c8aa9c1bbe62a84337b09c8d111b206e47"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"69bcc92fadf3a9f01b9256bb3a2759b4c03c6646","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    FWaaS has renamed the ``Public`` attribute to ``Shared`` to be"},{"line_number":5,"context_line":"    in-sunc with Openstack nomenclature based on the functionality"},{"line_number":6,"context_line":"    the ``shared`` attribute provides."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ff52f3f_1a217ffc","line":5,"range":{"start_line":5,"start_character":7,"end_line":5,"end_character":11},"updated":"2017-04-13 12:18:15.000000000","message":"sync?","commit_id":"ef1249c8aa9c1bbe62a84337b09c8d111b206e47"}]}