)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17597317393d845084988c8fa18964fece8bd70c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  to a BGPVPN; this is implemented thanks to the ``advertise_extra_routes``"},{"line_number":39,"context_line":"  attribute of a BGPVPN router association"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implements: blueprint port-routes"},{"line_number":42,"context_line":"Implements: blueprint port-association"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Change-Id: Ib2cefcb6a345887435b754fbdcff3584329d45d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"df140735_a231090e","line":41,"updated":"2017-05-31 19:51:48.000000000","message":"Unless I\u0027m missing something these BPs are still in discussion state. It seems they should be approved before we start dropping code, no?","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"afe63db66290db9457277645512987672f8c719e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  to a BGPVPN; this is implemented thanks to the ``advertise_extra_routes``"},{"line_number":39,"context_line":"  attribute of a BGPVPN router association"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implements: blueprint port-routes"},{"line_number":42,"context_line":"Implements: blueprint port-association"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Change-Id: Ib2cefcb6a345887435b754fbdcff3584329d45d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"df140735_da2858e3","line":41,"in_reply_to":"df140735_267f4868","updated":"2017-06-01 07:13:49.000000000","message":"Yes, the idea was to consolidate and get agreement on the API details, via the discussion around this change.\n\nboden, you are perfectly right that the LP BP status is not consistent, which I\u0027m going to fix right away","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"27a621a80defc59f4854cf890eaae362c2b48883","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  to a BGPVPN; this is implemented thanks to the ``advertise_extra_routes``"},{"line_number":39,"context_line":"  attribute of a BGPVPN router association"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implements: blueprint port-routes"},{"line_number":42,"context_line":"Implements: blueprint port-association"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Change-Id: Ib2cefcb6a345887435b754fbdcff3584329d45d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"df140735_267f4868","line":41,"in_reply_to":"df140735_a231090e","updated":"2017-05-31 22:13:20.000000000","message":"This is code, but it\u0027s basically just the API specification. Unless there\u0027s significant objection to the entire concept of port associations, I think this review is a better place to have the discussion than on Launchpad or Etherpad. It looks like the most recent Etherpad update was May 23rd, so moving the discussion to a Gerrit review seems like a good idea to me.\n\nIt would make sense to make sure we get enough review time on this API spec before putting much work into implementation code.","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ba49e0d79bd6974985b5abca9edb10d4aed6c166","unresolved":false,"context_lines":[{"line_number":17,"context_line":"neutron_lib/api-ref/source/v2/bgpvpn-overview.inc:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"With the ``bgpvpn`` extension, when associations between networks or routers"},{"line_number":20,"context_line":"and BGVPNs are defined, the routes corresponding to fixed IPs of neutron ports"},{"line_number":21,"context_line":"will be advertised to BGPVPNs.  For router associations, extra routes of the"},{"line_number":22,"context_line":"router (\u0027routes\u0027 attribute of a ``router`` resource) may also be advertized"},{"line_number":23,"context_line":"to BGPVPNs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"df140735_652268bb","line":20,"range":{"start_line":20,"start_character":72,"end_line":20,"end_character":78},"updated":"2017-06-05 13:52:54.000000000","message":"Nit: some of these lines are too long","commit_id":"b38124dbe4cf76a548d6c2e061cf5b65ac37968c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9cabdc88b6f2bfef401c21b7079a6f803b4cd468","unresolved":false,"context_lines":[{"line_number":17,"context_line":"neutron_lib/api-ref/source/v2/bgpvpn-overview.inc:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"With the ``bgpvpn`` extension, when associations between networks or routers"},{"line_number":20,"context_line":"and BGVPNs are defined, the routes corresponding to fixed IPs of neutron ports"},{"line_number":21,"context_line":"will be advertised to BGPVPNs.  For router associations, extra routes of the"},{"line_number":22,"context_line":"router (\u0027routes\u0027 attribute of a ``router`` resource) may also be advertized"},{"line_number":23,"context_line":"to BGPVPNs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"df140735_e5665dbb","line":20,"range":{"start_line":20,"start_character":72,"end_line":20,"end_character":78},"in_reply_to":"df140735_652268bb","updated":"2017-06-06 08:04:06.000000000","message":"Done","commit_id":"b38124dbe4cf76a548d6c2e061cf5b65ac37968c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ba49e0d79bd6974985b5abca9edb10d4aed6c166","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  to a BGPVPN; this is implemented thanks to the ``advertise_extra_routes``"},{"line_number":39,"context_line":"  attribute of a BGPVPN router association"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implements: blueprint port-routes"},{"line_number":42,"context_line":"Implements: blueprint port-association"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Change-Id: Ib2cefcb6a345887435b754fbdcff3584329d45d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"df140735_a53c00e1","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":38},"updated":"2017-06-05 13:52:54.000000000","message":"Shouldn\u0027t these be \"Partially Implements\" so this patch doesn\u0027t close out the BP?","commit_id":"b38124dbe4cf76a548d6c2e061cf5b65ac37968c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9cabdc88b6f2bfef401c21b7079a6f803b4cd468","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  to a BGPVPN; this is implemented thanks to the ``advertise_extra_routes``"},{"line_number":39,"context_line":"  attribute of a BGPVPN router association"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implements: blueprint port-routes"},{"line_number":42,"context_line":"Implements: blueprint port-association"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Change-Id: Ib2cefcb6a345887435b754fbdcff3584329d45d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"df140735_a50aa5ce","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":38},"in_reply_to":"df140735_a53c00e1","updated":"2017-06-06 08:04:06.000000000","message":"Done","commit_id":"b38124dbe4cf76a548d6c2e061cf5b65ac37968c"}],"api-ref/source/v2/bgpvpn-bgpvpns.inc":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76c9c0a445fad6a51bf61b6429433dc4d96b4fba","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Deletes a BGP VPN and its network and/or router associations."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"Normal response codes: 202, 204"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Error response codes: 401, 403, 404"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"df140735_6977913c","line":227,"range":{"start_line":227,"start_character":26,"end_line":227,"end_character":31},"updated":"2017-05-30 04:24:21.000000000","message":"Why did you add it?","commit_id":"b80ed9bd58043194763f2bd16e99f5022b469965"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09458c8912be17cf43ecf49ce970b59bde8c5464","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Deletes a BGP VPN and its network and/or router associations."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"Normal response codes: 202, 204"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Error response codes: 401, 403, 404"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"df140735_4665ceb4","line":227,"updated":"2017-05-30 14:56:31.000000000","message":"Do we make a clear distinction between when we return 202 vs 204?","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bf17dd73da0e5dc77b7b6d6a76117731762626c9","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Deletes a BGP VPN and its network and/or router associations."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"Normal response codes: 202, 204"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Error response codes: 401, 403, 404"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"df140735_f72c8e48","line":227,"in_reply_to":"df140735_4665ceb4","updated":"2017-05-30 16:04:33.000000000","message":"202 means deletion request is accepted but not effective yet, and 204 means that the deletion is effective. I thought that the two could happen depending on the driver, some drivers possibly acknowledging the request before the deletion is effective.","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"480a1ab986dffe3aca76e7f23491a6ed2dbcfbcb","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Deletes a BGP VPN and its network and/or router associations."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"Normal response codes: 202, 204"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Error response codes: 401, 403, 404"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_a69358fa","line":227,"range":{"start_line":227,"start_character":23,"end_line":227,"end_character":31},"updated":"2017-05-31 22:52:09.000000000","message":"I understand that the response code differs from drivers (although I feel strange that we have different API depends on drivers...) Users expects to recieve just a response code when the API succeeds. Could you add an explanation about the behavior?","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Deletes a BGP VPN and its network and/or router associations."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"Normal response codes: 202, 204"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Error response codes: 401, 403, 404"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_fa70bcde","line":227,"range":{"start_line":227,"start_character":23,"end_line":227,"end_character":31},"in_reply_to":"df140735_a69358fa","updated":"2017-06-01 07:47:41.000000000","message":"I\u0027ve looked at the neutron code, and there does not seem to be any code used anywhere to control the code returned for a delete.  So, while in theory we could make use of the distinction between 202 and 204, there is no point in enriching the documentation about something so theoretical.\n\nSo I updated this change to document 204 for all delete operation in bgpvpn, consistently with other parts of Neutron API.","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d7ea0e1695a4ed64007a28644cdde93d42b339ab","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   - export_targets: bgpvpn-export_targets-required"},{"line_number":52,"context_line":"   - networks: bgpvpn-networks-required"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers-required"},{"line_number":54,"context_line":"   - ports: bgpvpn-ports"},{"line_number":55,"context_line":"   - tenant_id: project_id"},{"line_number":56,"context_line":"   - project_id: project_id"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_dfd9cc22","line":54,"range":{"start_line":54,"start_character":5,"end_line":54,"end_character":24},"updated":"2017-06-08 00:56:17.000000000","message":"In response, parameters should be \"required: true\".","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5d46afdce5af21fced197f28b13925182db5d593","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   - export_targets: bgpvpn-export_targets-required"},{"line_number":52,"context_line":"   - networks: bgpvpn-networks-required"},{"line_number":53,"context_line":"   - routers: bgpvpn-routers-required"},{"line_number":54,"context_line":"   - ports: bgpvpn-ports"},{"line_number":55,"context_line":"   - tenant_id: project_id"},{"line_number":56,"context_line":"   - project_id: project_id"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_1e73bbe9","line":54,"range":{"start_line":54,"start_character":5,"end_line":54,"end_character":24},"in_reply_to":"bf091321_dfd9cc22","updated":"2017-06-08 08:53:50.000000000","message":"I changed the definition of bgpvpn-routes to required:true, but adding a comment that it is present only when the bgpvpn-routes-control extension is present.","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d7ea0e1695a4ed64007a28644cdde93d42b339ab","unresolved":false,"context_lines":[{"line_number":107,"context_line":"   - export_targets: bgpvpn-export_targets-required"},{"line_number":108,"context_line":"   - networks: bgpvpn-networks-required"},{"line_number":109,"context_line":"   - routers: bgpvpn-routers-required"},{"line_number":110,"context_line":"   - ports: bgpvpn-ports"},{"line_number":111,"context_line":"   - tenant_id: project_id"},{"line_number":112,"context_line":"   - project_id: project_id"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_dff2ec9a","line":110,"range":{"start_line":110,"start_character":5,"end_line":110,"end_character":24},"updated":"2017-06-08 00:56:17.000000000","message":"ditto","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d7ea0e1695a4ed64007a28644cdde93d42b339ab","unresolved":false,"context_lines":[{"line_number":150,"context_line":"   - export_targets: bgpvpn-export_targets-required"},{"line_number":151,"context_line":"   - networks: bgpvpn-networks-required"},{"line_number":152,"context_line":"   - routers: bgpvpn-routers-required"},{"line_number":153,"context_line":"   - ports: bgpvpn-ports"},{"line_number":154,"context_line":"   - tenant_id: project_id"},{"line_number":155,"context_line":"   - project_id: project_id"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_9f2a34e5","line":153,"range":{"start_line":153,"start_character":5,"end_line":153,"end_character":24},"updated":"2017-06-08 00:56:17.000000000","message":"ditto","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d7ea0e1695a4ed64007a28644cdde93d42b339ab","unresolved":false,"context_lines":[{"line_number":207,"context_line":"   - export_targets: bgpvpn-export_targets-required"},{"line_number":208,"context_line":"   - networks: bgpvpn-networks-required"},{"line_number":209,"context_line":"   - routers: bgpvpn-routers-required"},{"line_number":210,"context_line":"   - ports: bgpvpn-ports"},{"line_number":211,"context_line":"   - tenant_id: project_id"},{"line_number":212,"context_line":"   - project_id: project_id"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_5f349c4a","line":210,"range":{"start_line":210,"start_character":5,"end_line":210,"end_character":24},"updated":"2017-06-08 00:56:17.000000000","message":"ditto","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"ffdb98527f6e53322b2557ff11e6de1bd1a406a8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"BGP-based VPN."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"A BGPVPN is created by the admin and given to a tenant who can then associate"},{"line_number":11,"context_line":"it to Networks, Routers or Ports (the later when the ``bgpvpn-routes-control``"},{"line_number":12,"context_line":"extension is available)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The BGP VPNs API lists, shows details for, creates, updates, and deletes"}],"source_content_type":"text/x-c++src","patch_set":27,"id":"7f231b9d_a1a6aa52","line":11,"range":{"start_line":11,"start_character":38,"end_line":11,"end_character":43},"updated":"2017-06-13 14:13:35.000000000","message":"nit: later -\u003e latter (later means afterwards, latter means the one at the end of the list)","commit_id":"325bb68a709db2399358d2dce794ce142818911e"}],"api-ref/source/v2/bgpvpn-overview.inc":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"ffdb98527f6e53322b2557ff11e6de1bd1a406a8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"With the ``bgpvpn`` extension, when associations between networks or routers"},{"line_number":57,"context_line":"and BGVPNs are defined, the routes corresponding to fixed IPs of neutron ports"},{"line_number":58,"context_line":"will be advertised to BGPVPNs.  For router associations, extra routes of the"},{"line_number":59,"context_line":"router (\u0027routes\u0027 attribute of a ``router`` resource) may also be advertized"},{"line_number":60,"context_line":"to BGPVPNs."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"To provide more flexibility, the ``bgpvpn-routes-control`` extension provides"}],"source_content_type":"text/x-c++src","patch_set":27,"id":"7f231b9d_d3b3bd4c","line":59,"range":{"start_line":59,"start_character":65,"end_line":59,"end_character":75},"updated":"2017-06-13 14:13:35.000000000","message":"advertized -\u003e advertised","commit_id":"325bb68a709db2399358d2dce794ce142818911e"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"ffdb98527f6e53322b2557ff11e6de1bd1a406a8","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  is implemented thanks to the ``advertise_fixed_ips`` attribute of a BGPVPN"},{"line_number":72,"context_line":"  port association"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- explictly control whether extra routes of a router are to be advertized"},{"line_number":75,"context_line":"  to a BGPVPN; this is implemented thanks to the ``advertise_extra_routes``"},{"line_number":76,"context_line":"  attribute of a BGPVPN router association"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":27,"id":"7f231b9d_139375a5","line":74,"range":{"start_line":74,"start_character":63,"end_line":74,"end_character":73},"updated":"2017-06-13 14:13:35.000000000","message":"advertized -\u003e advertised","commit_id":"325bb68a709db2399358d2dce794ce142818911e"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"ffdb98527f6e53322b2557ff11e6de1bd1a406a8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  to a BGPVPN; this is implemented thanks to the ``advertise_extra_routes``"},{"line_number":76,"context_line":"  attribute of a BGPVPN router association"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- optionally control the value of the LOCAL_PREF BGP attribute of advertized"},{"line_number":79,"context_line":"  routes, for all routes of a BGPVPN (thanks to the ``local_pref`` attribute"},{"line_number":80,"context_line":"  of a BGPVPN resource) and/or per route (thanks to the ``local_pref``"},{"line_number":81,"context_line":"  in a port association route)"}],"source_content_type":"text/x-c++src","patch_set":27,"id":"7f231b9d_13d8157d","line":78,"range":{"start_line":78,"start_character":66,"end_line":78,"end_character":76},"updated":"2017-06-13 14:13:35.000000000","message":"advertized -\u003e advertised","commit_id":"325bb68a709db2399358d2dce794ce142818911e"}],"api-ref/source/v2/bgpvpn-port_associations.inc":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":25,"context_line":"20.1.0.0/16 is reachable via port A and should be advertised"},{"line_number":26,"context_line":"accordingly in BGPVPN X,  a port association is defined between port A"},{"line_number":27,"context_line":"and BGPVPN X, with the ``routes`` attribute set to ``[ {\u0027type\u0027: \u0027prefix\u0027,"},{"line_number":28,"context_line":"\u0027prefix\u0027: \u002720.1.0.0/16\u0027 ]``."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Route leaking of the routes of a given BGPVPN into another BGPVPN belonging"},{"line_number":31,"context_line":"to the same tenant, is supported similarily: to indicate that all the prefixes"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ff0f0b1f_8342000e","line":28,"range":{"start_line":28,"start_character":23,"end_line":28,"end_character":24},"updated":"2017-05-24 23:14:36.000000000","message":"missing \"}\"?","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"20.1.0.0/16 is reachable via port A and should be advertised"},{"line_number":26,"context_line":"accordingly in BGPVPN X,  a port association is defined between port A"},{"line_number":27,"context_line":"and BGPVPN X, with the ``routes`` attribute set to ``[ {\u0027type\u0027: \u0027prefix\u0027,"},{"line_number":28,"context_line":"\u0027prefix\u0027: \u002720.1.0.0/16\u0027 ]``."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Route leaking of the routes of a given BGPVPN into another BGPVPN belonging"},{"line_number":31,"context_line":"to the same tenant, is supported similarily: to indicate that all the prefixes"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_db72f511","line":28,"range":{"start_line":28,"start_character":23,"end_line":28,"end_character":24},"in_reply_to":"ff0f0b1f_8342000e","updated":"2017-05-30 09:03:41.000000000","message":"Done","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":33,"context_line":"least an RT belonging to ``route_targets`` or ``import_targets`` of BGPVPN Y),"},{"line_number":34,"context_line":"and that they should be leaked into BGPVPN X, a port association is defined"},{"line_number":35,"context_line":"between port A and BGPVPN X, with the ``routes`` attribute set to"},{"line_number":36,"context_line":"``[ {\u0027type\u0027: \u0027bgpvpn\u0027, \u0027bgpvpn\u0027: \u003cuuid of BGPVPN Y\u003e ]``."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"List Port Associations"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ff0f0b1f_a35864f9","line":36,"range":{"start_line":36,"start_character":51,"end_line":36,"end_character":52},"updated":"2017-05-24 23:14:36.000000000","message":"ditto","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"least an RT belonging to ``route_targets`` or ``import_targets`` of BGPVPN Y),"},{"line_number":34,"context_line":"and that they should be leaked into BGPVPN X, a port association is defined"},{"line_number":35,"context_line":"between port A and BGPVPN X, with the ``routes`` attribute set to"},{"line_number":36,"context_line":"``[ {\u0027type\u0027: \u0027bgpvpn\u0027, \u0027bgpvpn\u0027: \u003cuuid of BGPVPN Y\u003e ]``."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"List Port Associations"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_bb61813c","line":36,"range":{"start_line":36,"start_character":51,"end_line":36,"end_character":52},"in_reply_to":"ff0f0b1f_a35864f9","updated":"2017-05-30 09:03:41.000000000","message":"Done","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Normal response codes: 200"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Request"},{"line_number":50,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ff0f0b1f_23c4543f","line":47,"range":{"start_line":47,"start_character":22,"end_line":47,"end_character":25},"updated":"2017-05-24 23:14:36.000000000","message":"When does 400 happen?","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Normal response codes: 200"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Request"},{"line_number":50,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_bbc62116","line":47,"range":{"start_line":47,"start_character":22,"end_line":47,"end_character":25},"in_reply_to":"ff0f0b1f_23c4543f","updated":"2017-05-30 09:03:41.000000000","message":"In fact, 400 should not happen.","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   - id: bgpvpn-port_association_id"},{"line_number":64,"context_line":"   - port_id: bgpvpn-port_id"},{"line_number":65,"context_line":"   - project_id: project_id"},{"line_number":66,"context_line":"   - routes: bgpvpn-routes"},{"line_number":67,"context_line":"   - advertise_fixed_ips: bgpvpn-advertise_fixed_ips"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Response Example"},{"line_number":70,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ff0f0b1f_83ac409f","line":67,"range":{"start_line":66,"start_character":0,"end_line":67,"end_character":52},"updated":"2017-05-24 23:14:36.000000000","message":"In response body we don\u0027t expect optional parameter because that\u0027s always visible although the value is None(Null).","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   - id: bgpvpn-port_association_id"},{"line_number":64,"context_line":"   - port_id: bgpvpn-port_id"},{"line_number":65,"context_line":"   - project_id: project_id"},{"line_number":66,"context_line":"   - routes: bgpvpn-routes"},{"line_number":67,"context_line":"   - advertise_fixed_ips: bgpvpn-advertise_fixed_ips"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Response Example"},{"line_number":70,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_560d9c35","line":67,"range":{"start_line":66,"start_character":0,"end_line":67,"end_character":52},"in_reply_to":"ff0f0b1f_83ac409f","updated":"2017-05-30 09:03:41.000000000","message":"It is not intentional that this ends up rendered as (\u0027Optional\u0027). I\u0027ll try to fix that.","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":109,"context_line":"   - id: bgpvpn-port_association_id"},{"line_number":110,"context_line":"   - port_id: bgpvpn-port_id"},{"line_number":111,"context_line":"   - project_id: project_id"},{"line_number":112,"context_line":"   - routes: bgpvpn-routes"},{"line_number":113,"context_line":"   - advertise_fixed_ips: bgpvpn-advertise_fixed_ips"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Response Example"},{"line_number":116,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ff0f0b1f_e391bc48","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":52},"updated":"2017-05-24 23:14:36.000000000","message":"ditto","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"   - id: bgpvpn-port_association_id"},{"line_number":110,"context_line":"   - port_id: bgpvpn-port_id"},{"line_number":111,"context_line":"   - project_id: project_id"},{"line_number":112,"context_line":"   - routes: bgpvpn-routes"},{"line_number":113,"context_line":"   - advertise_fixed_ips: bgpvpn-advertise_fixed_ips"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Response Example"},{"line_number":116,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_f6495060","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":52},"in_reply_to":"ff0f0b1f_e391bc48","updated":"2017-05-30 09:03:41.000000000","message":"Done","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":146,"context_line":"   - id: bgpvpn-port_association_id"},{"line_number":147,"context_line":"   - port_id: bgpvpn-port_id"},{"line_number":148,"context_line":"   - project_id: project_id"},{"line_number":149,"context_line":"   - routes: bgpvpn-routes"},{"line_number":150,"context_line":"   - advertise_fixed_ips: bgpvpn-advertise_fixed_ips"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Response Example"},{"line_number":153,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ff0f0b1f_63d36c05","line":150,"range":{"start_line":149,"start_character":0,"end_line":150,"end_character":52},"updated":"2017-05-24 23:14:36.000000000","message":"ditto","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":146,"context_line":"   - id: bgpvpn-port_association_id"},{"line_number":147,"context_line":"   - port_id: bgpvpn-port_id"},{"line_number":148,"context_line":"   - project_id: project_id"},{"line_number":149,"context_line":"   - routes: bgpvpn-routes"},{"line_number":150,"context_line":"   - advertise_fixed_ips: bgpvpn-advertise_fixed_ips"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Response Example"},{"line_number":153,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_b675189b","line":150,"range":{"start_line":149,"start_character":0,"end_line":150,"end_character":52},"in_reply_to":"ff0f0b1f_63d36c05","updated":"2017-05-30 09:03:41.000000000","message":"Done","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":158,"context_line":"Update a Port Association"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":".. rest_method::  UPDATE /v2.0/bgpvpn/bgpvpns/{bgpvpn_id}/port_associations/{port_association_id}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Updates a port Association."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ff0f0b1f_8301e06c","line":161,"range":{"start_line":161,"start_character":18,"end_line":161,"end_character":24},"updated":"2017-05-24 23:14:36.000000000","message":"PUT","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":158,"context_line":"Update a Port Association"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":".. rest_method::  UPDATE /v2.0/bgpvpn/bgpvpns/{bgpvpn_id}/port_associations/{port_association_id}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Updates a port Association."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_366908be","line":161,"range":{"start_line":161,"start_character":18,"end_line":161,"end_character":24},"in_reply_to":"ff0f0b1f_8301e06c","updated":"2017-05-30 09:03:41.000000000","message":"Done","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":191,"context_line":"   - id: bgpvpn-port_association_id"},{"line_number":192,"context_line":"   - port_id: bgpvpn-port_id"},{"line_number":193,"context_line":"   - project_id: project_id"},{"line_number":194,"context_line":"   - routes: bgpvpn-routes"},{"line_number":195,"context_line":"   - advertise_fixed_ips: bgpvpn-advertise_fixed_ips"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Response Example"},{"line_number":198,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ff0f0b1f_63fc8c6f","line":195,"range":{"start_line":194,"start_character":0,"end_line":195,"end_character":52},"updated":"2017-05-24 23:14:36.000000000","message":"ditto","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":191,"context_line":"   - id: bgpvpn-port_association_id"},{"line_number":192,"context_line":"   - port_id: bgpvpn-port_id"},{"line_number":193,"context_line":"   - project_id: project_id"},{"line_number":194,"context_line":"   - routes: bgpvpn-routes"},{"line_number":195,"context_line":"   - advertise_fixed_ips: bgpvpn-advertise_fixed_ips"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Response Example"},{"line_number":198,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_166604ef","line":195,"range":{"start_line":194,"start_character":0,"end_line":195,"end_character":52},"in_reply_to":"ff0f0b1f_63fc8c6f","updated":"2017-05-30 09:03:41.000000000","message":"Done","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Deletes a port association."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Normal response codes: 202, 204"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ff0f0b1f_a333c461","line":211,"range":{"start_line":211,"start_character":23,"end_line":211,"end_character":31},"updated":"2017-05-24 23:14:36.000000000","message":"Which does response return?","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b5cb2cf48673b25bbe53ecbfa2adf959d91bdc7d","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Deletes a port association."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Normal response codes: 202, 204"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_26a53a05","line":211,"range":{"start_line":211,"start_character":23,"end_line":211,"end_character":31},"in_reply_to":"df140735_16c28486","updated":"2017-05-30 14:19:52.000000000","message":"I see. Could you add the discription to this section? It\u0027s useful for users.","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Deletes a port association."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Normal response codes: 202, 204"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_16c28486","line":211,"range":{"start_line":211,"start_character":23,"end_line":211,"end_character":31},"in_reply_to":"ff0f0b1f_a333c461","updated":"2017-05-30 09:03:41.000000000","message":"The base driver will return 204, but some other drivers may return 202.","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Normal response codes: 202, 204"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Request"},{"line_number":216,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ff0f0b1f_23f2149b","line":213,"range":{"start_line":213,"start_character":22,"end_line":213,"end_character":25},"updated":"2017-05-24 23:14:36.000000000","message":"When does 400 happen?","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Normal response codes: 202, 204"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Error response codes: 400, 401, 403, 404"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Request"},{"line_number":216,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"df140735_364a2827","line":213,"range":{"start_line":213,"start_character":22,"end_line":213,"end_character":25},"in_reply_to":"ff0f0b1f_23f2149b","updated":"2017-05-30 09:03:41.000000000","message":"It should not.","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76c9c0a445fad6a51bf61b6429433dc4d96b4fba","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Deletes a port association."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Normal response codes: 202, 204"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Error response codes: 401, 403, 404"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"df140735_09949536","line":211,"range":{"start_line":211,"start_character":26,"end_line":211,"end_character":31},"updated":"2017-05-30 04:24:21.000000000","message":"Could you reply my question on previous PS?","commit_id":"b80ed9bd58043194763f2bd16e99f5022b469965"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17597317393d845084988c8fa18964fece8bd70c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. rest_method::  GET /v2.0/bgpvpn/bgpvpns/{bgpvpn_id}/port_associations"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Lists port associations for a given BGP VPN."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Normal response codes: 200"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_7de034cd","line":43,"updated":"2017-05-31 19:51:48.000000000","message":"If fields is supported, it\u0027s customary to include the blurb about filtering::\n\n   Use the fields query parameter to control which fields are returned in the response body. Additionally, you can filter results by using query string parameters. For information, see Filtering and Column Selection.","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. rest_method::  GET /v2.0/bgpvpn/bgpvpns/{bgpvpn_id}/port_associations"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Lists port associations for a given BGP VPN."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Normal response codes: 200"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_bad6c4c2","line":43,"in_reply_to":"df140735_7de034cd","updated":"2017-06-01 07:47:41.000000000","message":"Done","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"480a1ab986dffe3aca76e7f23491a6ed2dbcfbcb","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Deletes a port association."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Normal response codes: 202, 204"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Error response codes: 401, 403, 404"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_c6ad2c32","line":211,"range":{"start_line":211,"start_character":23,"end_line":211,"end_character":31},"updated":"2017-05-31 22:52:09.000000000","message":"ditto","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4c193576df8e96f65c44a4afe9d0322d984f0502","unresolved":false,"context_lines":[{"line_number":42,"context_line":"between port A and BGPVPN X, with the ``routes`` attribute set to"},{"line_number":43,"context_line":"``[ {\u0027type\u0027: \u0027bgpvpn\u0027, \u0027bgpvpn_id\u0027: \u003cuuid of BGPVPN Y\u003e} ]``."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Control of BGP LOCAL_PREF attribute"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The BGP LOCAL_PREF for a specific route can be controlled to take a different"},{"line_number":49,"context_line":"value than the one defined in the BGPVPN ``local_pref`` attribute, by"},{"line_number":50,"context_line":"adding a ``\u0027local_pref\u0027: VALUE`` in a route in the ``routes`` attribute (see"},{"line_number":51,"context_line":"example in port association Update request)."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"List Port Associations"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":27,"id":"7f231b9d_87dd1444","line":51,"range":{"start_line":45,"start_character":0,"end_line":51,"end_character":44},"updated":"2017-06-12 23:51:41.000000000","message":"This attribute is a part of \"Port routers\" so I think that we can merge into above section.","commit_id":"325bb68a709db2399358d2dce794ce142818911e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"fff442168376afb6b6e6526f7dd4190ae2620bc3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"between port A and BGPVPN X, with the ``routes`` attribute set to"},{"line_number":43,"context_line":"``[ {\u0027type\u0027: \u0027bgpvpn\u0027, \u0027bgpvpn_id\u0027: \u003cuuid of BGPVPN Y\u003e} ]``."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Control of BGP LOCAL_PREF attribute"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The BGP LOCAL_PREF for a specific route can be controlled to take a different"},{"line_number":49,"context_line":"value than the one defined in the BGPVPN ``local_pref`` attribute, by"},{"line_number":50,"context_line":"adding a ``\u0027local_pref\u0027: VALUE`` in a route in the ``routes`` attribute (see"},{"line_number":51,"context_line":"example in port association Update request)."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"List Port Associations"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":27,"id":"7f231b9d_8cbc0ddd","line":51,"range":{"start_line":45,"start_character":0,"end_line":51,"end_character":44},"in_reply_to":"7f231b9d_87dd1444","updated":"2017-06-13 09:30:33.000000000","message":"We have two things:\n- a \u0027local_pref\u0027 attribute for the BGPVPN resource\n- a \u0027local_pref\u0027 key in one of the dict inside the \u0027routes\u0027 attribute of a \"port association\" resource\n\nAre you suggesting to merge both attribute or to merge the documentation about the two ?","commit_id":"325bb68a709db2399358d2dce794ce142818911e"}],"api-ref/source/v2/bgpvpn-router_associations.inc":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76c9c0a445fad6a51bf61b6429433dc4d96b4fba","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Deletes a router association."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Normal response codes: 202, 204"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Error response codes: 401, 403, 404"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"df140735_a9a24999","line":160,"range":{"start_line":160,"start_character":26,"end_line":160,"end_character":31},"updated":"2017-05-30 04:24:21.000000000","message":"Why did you add it?","commit_id":"b80ed9bd58043194763f2bd16e99f5022b469965"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17597317393d845084988c8fa18964fece8bd70c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"routes defined in the ``routes`` attribute of a router when the ``extraroute``"},{"line_number":22,"context_line":"extension is available)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The \u0027advertise_extra_routes\u0027 attribute can in this case be set on a"},{"line_number":25,"context_line":"router_association:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- True: the extra routes defined in the ``routes`` attribute of"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_3d119cad","line":24,"range":{"start_line":24,"start_character":5,"end_line":24,"end_character":27},"updated":"2017-05-31 19:51:48.000000000","message":"Should we use ``advertise_extra_routes`` here?","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"routes defined in the ``routes`` attribute of a router when the ``extraroute``"},{"line_number":22,"context_line":"extension is available)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The \u0027advertise_extra_routes\u0027 attribute can in this case be set on a"},{"line_number":25,"context_line":"router_association:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- True: the extra routes defined in the ``routes`` attribute of"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_3af4f45a","line":24,"range":{"start_line":24,"start_character":5,"end_line":24,"end_character":27},"in_reply_to":"df140735_3d119cad","updated":"2017-06-01 07:47:41.000000000","message":"Done","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17597317393d845084988c8fa18964fece8bd70c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"The \u0027advertise_extra_routes\u0027 attribute can in this case be set on a"},{"line_number":25,"context_line":"router_association:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- True: the extra routes defined in the ``routes`` attribute of"},{"line_number":28,"context_line":"  the router will be advertised to the BGPVPN (default value)"},{"line_number":29,"context_line":"- False: the extra routes defined in the ``routes`` attribute of"},{"line_number":30,"context_line":"  the router will **not** be advertised to the BGPVPN"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_5d8330cd","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":6},"updated":"2017-05-31 19:51:48.000000000","message":"Is this JSON or Python? If JSON maybe use \u0027true\u0027 for clarity.","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"The \u0027advertise_extra_routes\u0027 attribute can in this case be set on a"},{"line_number":25,"context_line":"router_association:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- True: the extra routes defined in the ``routes`` attribute of"},{"line_number":28,"context_line":"  the router will be advertised to the BGPVPN (default value)"},{"line_number":29,"context_line":"- False: the extra routes defined in the ``routes`` attribute of"},{"line_number":30,"context_line":"  the router will **not** be advertised to the BGPVPN"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_faed5c8b","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":6},"in_reply_to":"df140735_5d8330cd","updated":"2017-06-01 07:47:41.000000000","message":"Done","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17597317393d845084988c8fa18964fece8bd70c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- True: the extra routes defined in the ``routes`` attribute of"},{"line_number":28,"context_line":"  the router will be advertised to the BGPVPN (default value)"},{"line_number":29,"context_line":"- False: the extra routes defined in the ``routes`` attribute of"},{"line_number":30,"context_line":"  the router will **not** be advertised to the BGPVPN"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"List Router Associations"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_fd67a450","line":29,"range":{"start_line":29,"start_character":2,"end_line":29,"end_character":7},"updated":"2017-05-31 19:51:48.000000000","message":"Ditto.","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- True: the extra routes defined in the ``routes`` attribute of"},{"line_number":28,"context_line":"  the router will be advertised to the BGPVPN (default value)"},{"line_number":29,"context_line":"- False: the extra routes defined in the ``routes`` attribute of"},{"line_number":30,"context_line":"  the router will **not** be advertised to the BGPVPN"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"List Router Associations"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_da04d84c","line":29,"range":{"start_line":29,"start_character":2,"end_line":29,"end_character":7},"in_reply_to":"df140735_fd67a450","updated":"2017-06-01 07:47:41.000000000","message":"Done","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"39cf62e8186b6c0279deccbf5740832d2037df06","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Response Example"},{"line_number":69,"context_line":"----------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":".. literalinclude:: samples/bgpvpn/router_associations/router_association-list-response.json"},{"line_number":72,"context_line":"   :language: javascript"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Create Router Association"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_e3c6f049","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":92},"updated":"2017-05-31 14:24:44.000000000","message":"You should patch that response to include default value of new attribut \u0027advertise_extra_routes\u0027","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Response Example"},{"line_number":69,"context_line":"----------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":".. literalinclude:: samples/bgpvpn/router_associations/router_association-list-response.json"},{"line_number":72,"context_line":"   :language: javascript"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Create Router Association"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_3ac2b4ea","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":92},"in_reply_to":"df140735_e3c6f049","updated":"2017-06-01 07:47:41.000000000","message":"Done","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"39cf62e8186b6c0279deccbf5740832d2037df06","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Response Example"},{"line_number":112,"context_line":"----------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":".. literalinclude:: samples/bgpvpn/router_associations/router_association-create-response.json"},{"line_number":115,"context_line":"   :language: javascript"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Show Router Association details"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_03fa0474","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":94},"updated":"2017-05-31 14:24:44.000000000","message":"ditto","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Response Example"},{"line_number":112,"context_line":"----------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":".. literalinclude:: samples/bgpvpn/router_associations/router_association-create-response.json"},{"line_number":115,"context_line":"   :language: javascript"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Show Router Association details"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_fabb1c6f","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":94},"in_reply_to":"df140735_03fa0474","updated":"2017-06-01 07:47:41.000000000","message":"Done","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"39cf62e8186b6c0279deccbf5740832d2037df06","unresolved":false,"context_lines":[{"line_number":147,"context_line":"Response Example"},{"line_number":148,"context_line":"----------------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":".. literalinclude:: samples/bgpvpn/router_associations/router_association-show-response.json"},{"line_number":151,"context_line":"   :language: javascript"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Delete Router Association"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_e378302c","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":92},"updated":"2017-05-31 14:24:44.000000000","message":"ditto","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"Response Example"},{"line_number":148,"context_line":"----------------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":".. literalinclude:: samples/bgpvpn/router_associations/router_association-show-response.json"},{"line_number":151,"context_line":"   :language: javascript"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Delete Router Association"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df140735_baada432","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":92},"in_reply_to":"df140735_e378302c","updated":"2017-06-01 07:47:41.000000000","message":"Done","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d7ea0e1695a4ed64007a28644cdde93d42b339ab","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":".. rest_method::  PUT /v2.0/bgpvpn/bgpvpns/{bgpvpn_id}/router_associations/{router_association_id}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Updates a router Association."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Normal response codes: 201"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_1f24e4c5","line":162,"range":{"start_line":162,"start_character":17,"end_line":162,"end_character":28},"updated":"2017-06-08 00:56:17.000000000","message":"very nit: association","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5d46afdce5af21fced197f28b13925182db5d593","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":".. rest_method::  PUT /v2.0/bgpvpn/bgpvpns/{bgpvpn_id}/router_associations/{router_association_id}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Updates a router Association."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Normal response codes: 201"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_3e7d5f1c","line":162,"range":{"start_line":162,"start_character":17,"end_line":162,"end_character":28},"in_reply_to":"bf091321_1f24e4c5","updated":"2017-06-08 08:53:50.000000000","message":"Done","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d7ea0e1695a4ed64007a28644cdde93d42b339ab","unresolved":false,"context_lines":[{"line_number":173,"context_line":"   - bgpvpn_id: bgpvpn-id-path"},{"line_number":174,"context_line":"   - router_association_id: bgpvpn-router_association_id-path"},{"line_number":175,"context_line":"   - advertise_extra_routes: bgpvpn-advertise_extra_routes-request"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Request Example"},{"line_number":178,"context_line":"---------------"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_ff5b7051","line":176,"updated":"2017-06-08 00:56:17.000000000","message":"This seems lack \u0027router_association\u0027. We also cannot update \u0027router_id\u0027 here?","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"05369831b2d4c74798dd69b488674dae9ebc9e23","unresolved":false,"context_lines":[{"line_number":173,"context_line":"   - bgpvpn_id: bgpvpn-id-path"},{"line_number":174,"context_line":"   - router_association_id: bgpvpn-router_association_id-path"},{"line_number":175,"context_line":"   - advertise_extra_routes: bgpvpn-advertise_extra_routes-request"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Request Example"},{"line_number":178,"context_line":"---------------"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_60dc4d74","line":176,"in_reply_to":"bf091321_1e3bbb38","updated":"2017-06-08 12:36:37.000000000","message":"OK about \u0027router_id\u0027 but \u0027router_association\u0027 is needed here because I can see it in router_association-update-request.json.","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a0e6840a23bf7bb7ad73d1db1f778dea453c397","unresolved":false,"context_lines":[{"line_number":173,"context_line":"   - bgpvpn_id: bgpvpn-id-path"},{"line_number":174,"context_line":"   - router_association_id: bgpvpn-router_association_id-path"},{"line_number":175,"context_line":"   - advertise_extra_routes: bgpvpn-advertise_extra_routes-request"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Request Example"},{"line_number":178,"context_line":"---------------"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_1a8a991a","line":176,"in_reply_to":"bf091321_60dc4d74","updated":"2017-06-08 15:16:52.000000000","message":"Ah yes, sorry.\nFixed now!\n\nMany thanks for your attention to detail!","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5d46afdce5af21fced197f28b13925182db5d593","unresolved":false,"context_lines":[{"line_number":173,"context_line":"   - bgpvpn_id: bgpvpn-id-path"},{"line_number":174,"context_line":"   - router_association_id: bgpvpn-router_association_id-path"},{"line_number":175,"context_line":"   - advertise_extra_routes: bgpvpn-advertise_extra_routes-request"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Request Example"},{"line_number":178,"context_line":"---------------"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":19,"id":"bf091321_1e3bbb38","line":176,"in_reply_to":"bf091321_ff5b7051","updated":"2017-06-08 08:53:50.000000000","message":"in a router association, router_id is read-only(advertise_extra_routes is the only attribute that is not read-only), which is why it is not present in the request body","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09458c8912be17cf43ecf49ce970b59bde8c5464","unresolved":false,"context_lines":[{"line_number":642,"context_line":"      ``routes`` attribute of the router will be advertised to the BGPVPN"},{"line_number":643,"context_line":"      (default: True)."},{"line_number":644,"context_line":"  in: body"},{"line_number":645,"context_line":"  required: true"},{"line_number":646,"context_line":"  type: boolean"},{"line_number":647,"context_line":"bgpvpn-advertise_extra_routes-request:"},{"line_number":648,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_e6274212","line":645,"range":{"start_line":645,"start_character":12,"end_line":645,"end_character":16},"updated":"2017-05-30 14:56:31.000000000","message":"If the attribute is required then there\u0027s not such thing as a default (line 643)","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bf17dd73da0e5dc77b7b6d6a76117731762626c9","unresolved":false,"context_lines":[{"line_number":642,"context_line":"      ``routes`` attribute of the router will be advertised to the BGPVPN"},{"line_number":643,"context_line":"      (default: True)."},{"line_number":644,"context_line":"  in: body"},{"line_number":645,"context_line":"  required: true"},{"line_number":646,"context_line":"  type: boolean"},{"line_number":647,"context_line":"bgpvpn-advertise_extra_routes-request:"},{"line_number":648,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_170ee28c","line":645,"range":{"start_line":645,"start_character":12,"end_line":645,"end_character":16},"in_reply_to":"df140735_e6274212","updated":"2017-05-30 16:04:33.000000000","message":"This \"bgpvpn-advertise_extra_routes\" definition is only used for API responses, and marking the attribute as required: false\" result in the attribute being rendered with \"(Optional)\" which is bogus in a response because the field is always there.\n\n(the above summarizes the conclusion I reached after trying to address a comment from Hirofumi)","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09458c8912be17cf43ecf49ce970b59bde8c5464","unresolved":false,"context_lines":[{"line_number":657,"context_line":"      Boolean flag controlling whether or not the fixed IPs of a port will"},{"line_number":658,"context_line":"      be advertised to the BGPVPN (default: True)."},{"line_number":659,"context_line":"  in: body"},{"line_number":660,"context_line":"  required: true"},{"line_number":661,"context_line":"  type: boolean"},{"line_number":662,"context_line":"bgpvpn-advertise_fixed_ips-request:"},{"line_number":663,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_e6daa2e7","line":660,"range":{"start_line":660,"start_character":12,"end_line":660,"end_character":16},"updated":"2017-05-30 14:56:31.000000000","message":"As above, if there\u0027s a default then required should be false, if required then there\u0027s no such thing as a default.","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bf17dd73da0e5dc77b7b6d6a76117731762626c9","unresolved":false,"context_lines":[{"line_number":657,"context_line":"      Boolean flag controlling whether or not the fixed IPs of a port will"},{"line_number":658,"context_line":"      be advertised to the BGPVPN (default: True)."},{"line_number":659,"context_line":"  in: body"},{"line_number":660,"context_line":"  required: true"},{"line_number":661,"context_line":"  type: boolean"},{"line_number":662,"context_line":"bgpvpn-advertise_fixed_ips-request:"},{"line_number":663,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_771e3ebb","line":660,"range":{"start_line":660,"start_character":12,"end_line":660,"end_character":16},"in_reply_to":"df140735_e6daa2e7","updated":"2017-05-30 16:04:33.000000000","message":"(same as above)","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ba49e0d79bd6974985b5abca9edb10d4aed6c166","unresolved":false,"context_lines":[{"line_number":851,"context_line":"      which routes will be readvertised with the association port as the"},{"line_number":852,"context_line":"      nexthop (any route carrying an RT among ``route_targets`` or"},{"line_number":853,"context_line":"      ``import_targets`` of this BGPVPN, will be re-announced toward the RTs"},{"line_number":854,"context_line":"      of the associated BGPVPN ``export_targets``+``route_targets``, with"},{"line_number":855,"context_line":"      their next-hop/label pointing to this port)."},{"line_number":856,"context_line":"  in: body"},{"line_number":857,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"df140735_e8ee4d20","line":854,"range":{"start_line":854,"start_character":49,"end_line":854,"end_character":50},"updated":"2017-06-05 13:52:54.000000000","message":"This is formatting odd; perhaps we need a space around the \u0027+\u0027","commit_id":"b38124dbe4cf76a548d6c2e061cf5b65ac37968c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9cabdc88b6f2bfef401c21b7079a6f803b4cd468","unresolved":false,"context_lines":[{"line_number":851,"context_line":"      which routes will be readvertised with the association port as the"},{"line_number":852,"context_line":"      nexthop (any route carrying an RT among ``route_targets`` or"},{"line_number":853,"context_line":"      ``import_targets`` of this BGPVPN, will be re-announced toward the RTs"},{"line_number":854,"context_line":"      of the associated BGPVPN ``export_targets``+``route_targets``, with"},{"line_number":855,"context_line":"      their next-hop/label pointing to this port)."},{"line_number":856,"context_line":"  in: body"},{"line_number":857,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"df140735_4524e95d","line":854,"range":{"start_line":854,"start_character":49,"end_line":854,"end_character":50},"in_reply_to":"df140735_e8ee4d20","updated":"2017-06-06 08:04:06.000000000","message":"Done","commit_id":"b38124dbe4cf76a548d6c2e061cf5b65ac37968c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ba49e0d79bd6974985b5abca9edb10d4aed6c166","unresolved":false,"context_lines":[{"line_number":868,"context_line":"      which routes will be readvertised with the association port as the"},{"line_number":869,"context_line":"      nexthop (any route carrying an RT among ``route_targets`` or"},{"line_number":870,"context_line":"      ``import_targets`` of this BGPVPN, will be re-announced toward the RTs"},{"line_number":871,"context_line":"      of the associated BGPVPN ``export_targets``+``route_targets``, with"},{"line_number":872,"context_line":"      their next-hop/label pointing to this port)."},{"line_number":873,"context_line":"  in: body"},{"line_number":874,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"df140735_88dfd167","line":871,"range":{"start_line":871,"start_character":49,"end_line":871,"end_character":50},"updated":"2017-06-05 13:52:54.000000000","message":"Ditto.","commit_id":"b38124dbe4cf76a548d6c2e061cf5b65ac37968c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9cabdc88b6f2bfef401c21b7079a6f803b4cd468","unresolved":false,"context_lines":[{"line_number":868,"context_line":"      which routes will be readvertised with the association port as the"},{"line_number":869,"context_line":"      nexthop (any route carrying an RT among ``route_targets`` or"},{"line_number":870,"context_line":"      ``import_targets`` of this BGPVPN, will be re-announced toward the RTs"},{"line_number":871,"context_line":"      of the associated BGPVPN ``export_targets``+``route_targets``, with"},{"line_number":872,"context_line":"      their next-hop/label pointing to this port)."},{"line_number":873,"context_line":"  in: body"},{"line_number":874,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"df140735_65292d35","line":871,"range":{"start_line":871,"start_character":49,"end_line":871,"end_character":50},"in_reply_to":"df140735_88dfd167","updated":"2017-06-06 08:04:06.000000000","message":"Done","commit_id":"b38124dbe4cf76a548d6c2e061cf5b65ac37968c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"ffdb98527f6e53322b2557ff11e6de1bd1a406a8","unresolved":false,"context_lines":[{"line_number":697,"context_line":"  type: array"},{"line_number":698,"context_line":"bgpvpn-local_pref:"},{"line_number":699,"context_line":"  description: |"},{"line_number":700,"context_line":"      The default BGP LOCAL_PREF of routes that will be advertized to the"},{"line_number":701,"context_line":"      BGPVPN (unless overriden per-route)."},{"line_number":702,"context_line":"  in: body"},{"line_number":703,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7f231b9d_96bf73cf","line":700,"range":{"start_line":700,"start_character":56,"end_line":700,"end_character":66},"updated":"2017-06-13 14:13:35.000000000","message":"advertized -\u003e advertised","commit_id":"325bb68a709db2399358d2dce794ce142818911e"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"ffdb98527f6e53322b2557ff11e6de1bd1a406a8","unresolved":false,"context_lines":[{"line_number":704,"context_line":"  type: string"},{"line_number":705,"context_line":"bgpvpn-local_pref-request:"},{"line_number":706,"context_line":"  description: |"},{"line_number":707,"context_line":"      The default BGP LOCAL_PREF of routes that will be advertized to the"},{"line_number":708,"context_line":"      BGPVPN (unless overriden per-route)."},{"line_number":709,"context_line":"  in: body"},{"line_number":710,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7f231b9d_d6c4cb61","line":707,"range":{"start_line":707,"start_character":56,"end_line":707,"end_character":66},"updated":"2017-06-13 14:13:35.000000000","message":"advertized -\u003e advertised","commit_id":"325bb68a709db2399358d2dce794ce142818911e"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"ffdb98527f6e53322b2557ff11e6de1bd1a406a8","unresolved":false,"context_lines":[{"line_number":780,"context_line":"    of MPLS networks to Neutron ports."},{"line_number":781,"context_line":"  in: body"},{"line_number":782,"context_line":"  required: true"},{"line_number":783,"context_line":"  type: object"},{"line_number":784,"context_line":"bgpvpn-port_id:"},{"line_number":785,"context_line":"  description: |"},{"line_number":786,"context_line":"      The ID of a Neutron port with which to associate the BGP VPN."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7f231b9d_f648e7cc","line":783,"range":{"start_line":783,"start_character":8,"end_line":783,"end_character":14},"updated":"2017-06-13 14:13:35.000000000","message":"I think this would be array","commit_id":"325bb68a709db2399358d2dce794ce142818911e"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"ffdb98527f6e53322b2557ff11e6de1bd1a406a8","unresolved":false,"context_lines":[{"line_number":877,"context_line":"      their next-hop/label pointing to this port)."},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"      For both types, the ``local_pref`` key can be used to control the"},{"line_number":880,"context_line":"      value of the BGP LOCAL_PREF of the routes that will be advertized."},{"line_number":881,"context_line":"  in: body"},{"line_number":882,"context_line":"  required: true"},{"line_number":883,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7f231b9d_d6716b0e","line":880,"range":{"start_line":880,"start_character":61,"end_line":880,"end_character":71},"updated":"2017-06-13 14:13:35.000000000","message":"advertized -\u003e advertised","commit_id":"325bb68a709db2399358d2dce794ce142818911e"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"ffdb98527f6e53322b2557ff11e6de1bd1a406a8","unresolved":false,"context_lines":[{"line_number":897,"context_line":"      their next-hop/label pointing to this port)."},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"      For both types, the ``local_pref`` key can be used to control the"},{"line_number":900,"context_line":"      value of the BGP LOCAL_PREF of the routes that will be advertized."},{"line_number":901,"context_line":"  in: body"},{"line_number":902,"context_line":"  required: false"},{"line_number":903,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7f231b9d_36565f5e","line":900,"range":{"start_line":900,"start_character":61,"end_line":900,"end_character":71},"updated":"2017-06-13 14:13:35.000000000","message":"advertized -\u003e advertised","commit_id":"325bb68a709db2399358d2dce794ce142818911e"}],"api-ref/source/v2/samples/bgpvpn/port_associations/port_association-create-request.json":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":6,"context_line":"                \"type\": \"prefix\","},{"line_number":7,"context_line":"                \"prefix\": \"20.1.0.0/16\""},{"line_number":8,"context_line":"            }"},{"line_number":9,"context_line":"        ]"},{"line_number":10,"context_line":"    }"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"ff0f0b1f_2347b4be","line":9,"updated":"2017-05-24 23:14:36.000000000","message":"advertise_fixed_ips?","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"                \"type\": \"prefix\","},{"line_number":7,"context_line":"                \"prefix\": \"20.1.0.0/16\""},{"line_number":8,"context_line":"            }"},{"line_number":9,"context_line":"        ]"},{"line_number":10,"context_line":"    }"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"df140735_16704472","line":9,"in_reply_to":"ff0f0b1f_2347b4be","updated":"2017-05-30 09:03:41.000000000","message":"I don\u0027t think we need to provide all possible optional parameters in the example, do we ?\n\nI will add it to the update request example, though.","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"}],"api-ref/source/v2/samples/bgpvpn/port_associations/port_association-create-response.json":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":9,"context_line":"                \"type\": \"prefix\","},{"line_number":10,"context_line":"                \"prefix\": \"20.1.0.0/16\""},{"line_number":11,"context_line":"            }"},{"line_number":12,"context_line":"        ]"},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"ff0f0b1f_a30ce493","line":12,"updated":"2017-05-24 23:14:36.000000000","message":"advertise_fixed_ips?","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"                \"type\": \"prefix\","},{"line_number":10,"context_line":"                \"prefix\": \"20.1.0.0/16\""},{"line_number":11,"context_line":"            }"},{"line_number":12,"context_line":"        ]"},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"df140735_d6176ced","line":12,"in_reply_to":"ff0f0b1f_a30ce493","updated":"2017-05-30 09:03:41.000000000","message":"Done","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09458c8912be17cf43ecf49ce970b59bde8c5464","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"id\": \"c63149a0-a0b3-4ca7-aba4-9aaa1b39d7f3\","},{"line_number":4,"context_line":"        \"port_id\": \"46a1a80b-7c42-4c45-88fd-b531e636969f\","},{"line_number":5,"context_line":"        \"project_id\": \"b7549121395844bea941bb92feb3fad9\","},{"line_number":6,"context_line":"        \"tenant_id\": \"b7549121395844bea941bb92feb3fad9\","},{"line_number":7,"context_line":"        \"routes\": ["},{"line_number":8,"context_line":"            {"},{"line_number":9,"context_line":"                \"type\": \"prefix\","}],"source_content_type":"application/json","patch_set":11,"id":"df140735_e60d023f","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":18},"updated":"2017-05-30 14:56:31.000000000","message":"If you\u0027re going to include tenant_id in the response example you should include it in the tables as well. Do we need to include tenant_id in a new API call? I thought it was only needed for backwards compatibility.","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bf17dd73da0e5dc77b7b6d6a76117731762626c9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"id\": \"c63149a0-a0b3-4ca7-aba4-9aaa1b39d7f3\","},{"line_number":4,"context_line":"        \"port_id\": \"46a1a80b-7c42-4c45-88fd-b531e636969f\","},{"line_number":5,"context_line":"        \"project_id\": \"b7549121395844bea941bb92feb3fad9\","},{"line_number":6,"context_line":"        \"tenant_id\": \"b7549121395844bea941bb92feb3fad9\","},{"line_number":7,"context_line":"        \"routes\": ["},{"line_number":8,"context_line":"            {"},{"line_number":9,"context_line":"                \"type\": \"prefix\","}],"source_content_type":"application/json","patch_set":11,"id":"df140735_d7550a52","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":18},"in_reply_to":"df140735_e60d023f","updated":"2017-05-30 16:04:33.000000000","message":"Correct!","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"}],"api-ref/source/v2/samples/bgpvpn/port_associations/port_association-list-response.json":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":10,"context_line":"                    \"type\": \"prefix\","},{"line_number":11,"context_line":"                    \"prefix\": \"20.1.0.0/16\""},{"line_number":12,"context_line":"                }"},{"line_number":13,"context_line":"            ]"},{"line_number":14,"context_line":"        }"},{"line_number":15,"context_line":"    ]"},{"line_number":16,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"ff0f0b1f_4392a858","line":13,"updated":"2017-05-24 23:14:36.000000000","message":"advertise_fixed_ips?","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"                    \"type\": \"prefix\","},{"line_number":11,"context_line":"                    \"prefix\": \"20.1.0.0/16\""},{"line_number":12,"context_line":"                }"},{"line_number":13,"context_line":"            ]"},{"line_number":14,"context_line":"        }"},{"line_number":15,"context_line":"    ]"},{"line_number":16,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"df140735_96d7b424","line":13,"in_reply_to":"ff0f0b1f_4392a858","updated":"2017-05-30 09:03:41.000000000","message":"Done","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"}],"api-ref/source/v2/samples/bgpvpn/port_associations/port_association-show-response.json":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e240892dab6f85720b1d22c034faf5ccccc249","unresolved":false,"context_lines":[{"line_number":9,"context_line":"                \"type\": \"prefix\","},{"line_number":10,"context_line":"                \"prefix\": \"20.1.0.0/16\""},{"line_number":11,"context_line":"            }"},{"line_number":12,"context_line":"        ]"},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"ff0f0b1f_830fa086","line":12,"updated":"2017-05-24 23:14:36.000000000","message":"advertise_fixed_ips?","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bae6955600bfcd7b67e3a3fe85785590419406f2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"                \"type\": \"prefix\","},{"line_number":10,"context_line":"                \"prefix\": \"20.1.0.0/16\""},{"line_number":11,"context_line":"            }"},{"line_number":12,"context_line":"        ]"},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"df140735_76dc2046","line":12,"in_reply_to":"ff0f0b1f_830fa086","updated":"2017-05-30 09:03:41.000000000","message":"Done","commit_id":"0d4d865326270c06dc63057694d4bf77a5491351"}],"api-ref/source/v2/samples/bgpvpn/port_associations/port_association-update-request.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c74b3c7c9995a4b61bfca52bc82a2f78583e318d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            {"},{"line_number":6,"context_line":"                \"type\": \"bgpvpn\","},{"line_number":7,"context_line":"                \"bgpvpn_id\": \"180630e3-9eae-4ba7-9939-d5f47966e1f0\","},{"line_number":8,"context_line":"                \"local_pref\": 111"},{"line_number":9,"context_line":"            }"},{"line_number":10,"context_line":"        ],"},{"line_number":11,"context_line":"        \"advertise_fixed_ips\": false"}],"source_content_type":"application/json","patch_set":28,"id":"7f231b9d_35198a21","line":8,"range":{"start_line":8,"start_character":30,"end_line":8,"end_character":33},"updated":"2017-06-14 15:44:47.000000000","message":"The params docs this as type string, but it\u0027s int here.","commit_id":"000a250f1e8191ff1c288c0ed5c6ab1c9d865998"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ee39c6f2f3716b15a804daa7680e070f4e8461ec","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            {"},{"line_number":6,"context_line":"                \"type\": \"bgpvpn\","},{"line_number":7,"context_line":"                \"bgpvpn_id\": \"180630e3-9eae-4ba7-9939-d5f47966e1f0\","},{"line_number":8,"context_line":"                \"local_pref\": 111"},{"line_number":9,"context_line":"            }"},{"line_number":10,"context_line":"        ],"},{"line_number":11,"context_line":"        \"advertise_fixed_ips\": false"}],"source_content_type":"application/json","patch_set":28,"id":"7f231b9d_a010b6a9","line":8,"range":{"start_line":8,"start_character":30,"end_line":8,"end_character":33},"in_reply_to":"7f231b9d_35198a21","updated":"2017-06-14 16:20:50.000000000","message":"good catch, thanks!\nI fixed to integer in the parameters doc file.","commit_id":"000a250f1e8191ff1c288c0ed5c6ab1c9d865998"}],"api-ref/source/v2/samples/bgpvpn/port_associations/port_association-update-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c74b3c7c9995a4b61bfca52bc82a2f78583e318d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"            {"},{"line_number":8,"context_line":"                \"type\": \"bgpvpn\","},{"line_number":9,"context_line":"                \"bgpvpn_id\": \"180630e3-9eae-4ba7-9939-d5f47966e1f0\","},{"line_number":10,"context_line":"                \"local_pref\": 111"},{"line_number":11,"context_line":"            }"},{"line_number":12,"context_line":"        ],"},{"line_number":13,"context_line":"        \"advertise_fixed_ips\": false"}],"source_content_type":"application/json","patch_set":28,"id":"7f231b9d_15168ef2","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":33},"updated":"2017-06-14 15:44:47.000000000","message":"The params docs this as type string, but it\u0027s int here.","commit_id":"000a250f1e8191ff1c288c0ed5c6ab1c9d865998"}],"api-ref/source/v2/samples/bgpvpn/router_associations/router_association-update-response.json":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d7ea0e1695a4ed64007a28644cdde93d42b339ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_association\": {"},{"line_number":3,"context_line":"        \"id\": \"c63149a0-a0b3-4ca7-aba4-9aaa1b39d7f3\","},{"line_number":4,"context_line":"        \"project_id\": \"b7549121395844bea941bb92feb3fad9\","},{"line_number":5,"context_line":"        \"router_id\": \"46a1a80b-7c42-4c45-88fd-b531e636969f\","}],"source_content_type":"application/json","patch_set":19,"id":"bf091321_9f30f409","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":21},"updated":"2017-06-08 00:56:17.000000000","message":"router_association","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5d46afdce5af21fced197f28b13925182db5d593","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"port_association\": {"},{"line_number":3,"context_line":"        \"id\": \"c63149a0-a0b3-4ca7-aba4-9aaa1b39d7f3\","},{"line_number":4,"context_line":"        \"project_id\": \"b7549121395844bea941bb92feb3fad9\","},{"line_number":5,"context_line":"        \"router_id\": \"46a1a80b-7c42-4c45-88fd-b531e636969f\","}],"source_content_type":"application/json","patch_set":19,"id":"bf091321_bebbafe3","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":21},"in_reply_to":"bf091321_9f30f409","updated":"2017-06-08 08:53:50.000000000","message":"Done","commit_id":"ca0808f80ed67578735f8403bf382d51b77d5168"}],"neutron_lib/api/definitions/bgpvpn_routes_control.py":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09458c8912be17cf43ecf49ce970b59bde8c5464","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# A declaration of a dummy neutron extension: this may have a number of"},{"line_number":27,"context_line":"# constants being defined, and their aim is to document as much about"},{"line_number":28,"context_line":"# the extension as possible."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# The alias of the extension."},{"line_number":31,"context_line":"ALIAS \u003d \u0027bgpvpn-routes-control\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_a9b8fb29","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":28},"updated":"2017-05-30 14:56:31.000000000","message":"This comment can probably be deleted.","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bf17dd73da0e5dc77b7b6d6a76117731762626c9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# A declaration of a dummy neutron extension: this may have a number of"},{"line_number":27,"context_line":"# constants being defined, and their aim is to document as much about"},{"line_number":28,"context_line":"# the extension as possible."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# The alias of the extension."},{"line_number":31,"context_line":"ALIAS \u003d \u0027bgpvpn-routes-control\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_b26624ed","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":28},"in_reply_to":"df140735_a9b8fb29","updated":"2017-05-30 16:04:33.000000000","message":"Done","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09458c8912be17cf43ecf49ce970b59bde8c5464","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# The subresource attribute map for the extension. It adds child resources"},{"line_number":99,"context_line":"# to main extension\u0027s resource. The subresource map must have a parent and"},{"line_number":100,"context_line":"# a parameters entry. If an extension does not need such a map, None can"},{"line_number":101,"context_line":"# be specified (mandatory). For example:"},{"line_number":102,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":103,"context_line":"    PORT_ASSOCIATIONS: {"},{"line_number":104,"context_line":"        \u0027parent\u0027: {"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_e94a7325","line":101,"range":{"start_line":99,"start_character":32,"end_line":101,"end_character":40},"updated":"2017-05-30 14:56:31.000000000","message":"Some of this comment can be deleted. At least the \"For example:\" part.","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bf17dd73da0e5dc77b7b6d6a76117731762626c9","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# The subresource attribute map for the extension. It adds child resources"},{"line_number":99,"context_line":"# to main extension\u0027s resource. The subresource map must have a parent and"},{"line_number":100,"context_line":"# a parameters entry. If an extension does not need such a map, None can"},{"line_number":101,"context_line":"# be specified (mandatory). For example:"},{"line_number":102,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":103,"context_line":"    PORT_ASSOCIATIONS: {"},{"line_number":104,"context_line":"        \u0027parent\u0027: {"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_529b48c8","line":101,"range":{"start_line":99,"start_character":32,"end_line":101,"end_character":40},"in_reply_to":"df140735_e94a7325","updated":"2017-05-30 16:04:33.000000000","message":"Done","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d899a9cfa2ec614ce81b74233ef78275b295c985","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            ROUTES: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":122,"context_line":"                     \u0027default\u0027: [],"},{"line_number":123,"context_line":"                     \u0027convert_list_to\u0027: converters.convert_kvp_list_to_dict,"},{"line_number":124,"context_line":"                     \u0027validate\u0027: {\u0027type:bgpvpn_routes\u0027: None},"},{"line_number":125,"context_line":"                     \u0027enforce_policy\u0027: True,"},{"line_number":126,"context_line":"                     \u0027is_visible\u0027: True},"},{"line_number":127,"context_line":"            ADV_FIXED_IPS: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_06f8f6e2","line":124,"range":{"start_line":124,"start_character":33,"end_line":124,"end_character":62},"updated":"2017-05-30 14:32:10.000000000","message":"Consider using type:dict: { ...spec of what is inside dict ... }","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"09458c8912be17cf43ecf49ce970b59bde8c5464","unresolved":false,"context_lines":[{"line_number":143,"context_line":"}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# The action map: it associates verbs with methods to be performed on"},{"line_number":147,"context_line":"# the API resource (mandatory). For example:"},{"line_number":148,"context_line":"#"},{"line_number":149,"context_line":"# ACTION_MAP \u003d {"},{"line_number":150,"context_line":"#     RESOURCE_NAME: {"},{"line_number":151,"context_line":"#        \u0027add_my_foo_bars\u0027: \u0027PUT\u0027,"},{"line_number":152,"context_line":"#        \u0027remove_my_foo_bars\u0027: \u0027PUT\u0027,"},{"line_number":153,"context_line":"#        \u0027get_my_foo_bars\u0027: \u0027GET\u0027"},{"line_number":154,"context_line":"#    }"},{"line_number":155,"context_line":"# }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# TODO(tmorin): consider using actions_map to add/remove routes ?"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_692e6344","line":155,"range":{"start_line":146,"start_character":0,"end_line":155,"end_character":3},"updated":"2017-05-30 14:56:31.000000000","message":"Delete this comment.","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bf17dd73da0e5dc77b7b6d6a76117731762626c9","unresolved":false,"context_lines":[{"line_number":143,"context_line":"}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# The action map: it associates verbs with methods to be performed on"},{"line_number":147,"context_line":"# the API resource (mandatory). For example:"},{"line_number":148,"context_line":"#"},{"line_number":149,"context_line":"# ACTION_MAP \u003d {"},{"line_number":150,"context_line":"#     RESOURCE_NAME: {"},{"line_number":151,"context_line":"#        \u0027add_my_foo_bars\u0027: \u0027PUT\u0027,"},{"line_number":152,"context_line":"#        \u0027remove_my_foo_bars\u0027: \u0027PUT\u0027,"},{"line_number":153,"context_line":"#        \u0027get_my_foo_bars\u0027: \u0027GET\u0027"},{"line_number":154,"context_line":"#    }"},{"line_number":155,"context_line":"# }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# TODO(tmorin): consider using actions_map to add/remove routes ?"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_12a5d004","line":155,"range":{"start_line":146,"start_character":0,"end_line":155,"end_character":3},"in_reply_to":"df140735_692e6344","updated":"2017-05-30 16:04:33.000000000","message":"Done","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0127a21440c33144a188ff1a0c1cd6b23cdb8211","unresolved":false,"context_lines":[{"line_number":168,"context_line":"OPTIONAL_EXTENSIONS \u003d []"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def validate_bgpvpn_routes(data, valid_values\u003dNone):"},{"line_number":172,"context_line":"    \"\"\"Validate data is a list of valid bgpvpn route dicts."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    :param data: The data to validate."}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_0627d6b5","line":171,"updated":"2017-05-30 14:21:25.000000000","message":"Could you follow a patch[1]? We\u0027re discussing that extension specific validator is put as new validator in validators directory.\n\n[1]: https://review.openstack.org/#/c/467236/","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d899a9cfa2ec614ce81b74233ef78275b295c985","unresolved":false,"context_lines":[{"line_number":168,"context_line":"OPTIONAL_EXTENSIONS \u003d []"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def validate_bgpvpn_routes(data, valid_values\u003dNone):"},{"line_number":172,"context_line":"    \"\"\"Validate data is a list of valid bgpvpn route dicts."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    :param data: The data to validate."}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_069eb655","line":171,"in_reply_to":"df140735_0627d6b5","updated":"2017-05-30 14:32:10.000000000","message":"I\u0027m actually considering using type:dict instead of this.\n\nBut if I have to keep this, then I\u0027ll follow your advice.","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"a222be26de058de44a72b00bbc638a01f5ddeb4c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"OPTIONAL_EXTENSIONS \u003d []"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def validate_bgpvpn_routes(data, valid_values\u003dNone):"},{"line_number":172,"context_line":"    \"\"\"Validate data is a list of valid bgpvpn route dicts."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    :param data: The data to validate."}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_8d5d2ceb","line":171,"in_reply_to":"df140735_069eb655","updated":"2017-05-31 08:15:54.000000000","message":"I managed to completely avoid the introduction of a new validator, reusing an existing one that does the job perfectly.","commit_id":"a1a61280f4371a06e0de45c0d4b5f0b4b14d6152"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17597317393d845084988c8fa18964fece8bd70c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron_lib.api.definitions import bgpvpn"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# The alias of the extension."}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_0220b5af","line":21,"updated":"2017-05-31 19:51:48.000000000","message":"What\u0027s the log needed for?","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron_lib.api.definitions import bgpvpn"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# The alias of the extension."}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_d5a38b9d","line":21,"in_reply_to":"df140735_0220b5af","updated":"2017-06-01 07:47:41.000000000","message":"Leftover, now removed...","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17597317393d845084988c8fa18964fece8bd70c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# can be used instead."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# The name of the resource introduced or being extended (later case)"},{"line_number":58,"context_line":"RESOURCE_NAME \u003d \u0027bgpvpn\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# The plural for the resource introduced or being extended (later case)"},{"line_number":61,"context_line":"COLLECTION_NAME \u003d \u0027bgpvpns\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_6214114f","line":58,"updated":"2017-05-31 19:51:48.000000000","message":"IMHO it might be cleaner to just use the RESOURCE_NAME and COLLECTION_NAME from the bgpvpn api-def rather than re-define.","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# can be used instead."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# The name of the resource introduced or being extended (later case)"},{"line_number":58,"context_line":"RESOURCE_NAME \u003d \u0027bgpvpn\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# The plural for the resource introduced or being extended (later case)"},{"line_number":61,"context_line":"COLLECTION_NAME \u003d \u0027bgpvpns\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_f5b56fce","line":58,"in_reply_to":"df140735_6214114f","updated":"2017-06-01 07:47:41.000000000","message":"Better indeed.","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17597317393d845084988c8fa18964fece8bd70c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                   \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":110,"context_line":"                   \u0027is_visible\u0027: True,"},{"line_number":111,"context_line":"                   \u0027primary_key\u0027: True},"},{"line_number":112,"context_line":"            \u0027project_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":113,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":114,"context_line":"                           \u0027required_by_policy\u0027: True,"},{"line_number":115,"context_line":"                           \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_3d5abc29","line":112,"range":{"start_line":112,"start_character":13,"end_line":112,"end_character":23},"updated":"2017-05-31 19:51:48.000000000","message":"Shouldn\u0027t we cap this with db_const.PROJECT_ID_FIELD_SIZE?","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                   \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":110,"context_line":"                   \u0027is_visible\u0027: True,"},{"line_number":111,"context_line":"                   \u0027primary_key\u0027: True},"},{"line_number":112,"context_line":"            \u0027project_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":113,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":114,"context_line":"                           \u0027required_by_policy\u0027: True,"},{"line_number":115,"context_line":"                           \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_95c63348","line":112,"range":{"start_line":112,"start_character":13,"end_line":112,"end_character":23},"in_reply_to":"df140735_3d5abc29","updated":"2017-06-01 07:47:41.000000000","message":"Yes.","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"17597317393d845084988c8fa18964fece8bd70c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"ACTION_STATUS \u003d {}"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":154,"context_line":"    \u0027bgpvpn\u0027"},{"line_number":155,"context_line":"]"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_9d7668a4","line":154,"range":{"start_line":154,"start_character":5,"end_line":154,"end_character":11},"updated":"2017-05-31 19:51:48.000000000","message":"IMHO it\u0027d be clearer to just use the ALIAS of the bgpvpn api-def.","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cac8e9b795e55bae1bfb17b192e5c164456bccb3","unresolved":false,"context_lines":[{"line_number":151,"context_line":"ACTION_STATUS \u003d {}"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":154,"context_line":"    \u0027bgpvpn\u0027"},{"line_number":155,"context_line":"]"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_35f4075b","line":154,"range":{"start_line":154,"start_character":5,"end_line":154,"end_character":11},"in_reply_to":"df140735_9d7668a4","updated":"2017-06-01 07:47:41.000000000","message":"Done","commit_id":"685c8317edb246bfde57cbd8ec7f6832f5d9b60e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ba49e0d79bd6974985b5abca9edb10d4aed6c166","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# The label to lookup the plugin in the plugin directory. It can match the"},{"line_number":24,"context_line":"# alias, as required."},{"line_number":25,"context_line":"LABEL \u003d \u0027bgpvpn-routes-control\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Whether or not this extension is simply signaling behavior to the user"},{"line_number":28,"context_line":"# or it actively modifies the attribute map (mandatory)."}],"source_content_type":"text/x-python","patch_set":18,"id":"df140735_25011007","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":31},"updated":"2017-06-05 13:52:54.000000000","message":"I think you can leave this empty if using the ALIAS, or just use ALIAS rather than redefining the string again.","commit_id":"b38124dbe4cf76a548d6c2e061cf5b65ac37968c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9cabdc88b6f2bfef401c21b7079a6f803b4cd468","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# The label to lookup the plugin in the plugin directory. It can match the"},{"line_number":24,"context_line":"# alias, as required."},{"line_number":25,"context_line":"LABEL \u003d \u0027bgpvpn-routes-control\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Whether or not this extension is simply signaling behavior to the user"},{"line_number":28,"context_line":"# or it actively modifies the attribute map (mandatory)."}],"source_content_type":"text/x-python","patch_set":18,"id":"df140735_65decd3e","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":31},"in_reply_to":"df140735_25011007","updated":"2017-06-06 08:04:06.000000000","message":"Done","commit_id":"b38124dbe4cf76a548d6c2e061cf5b65ac37968c"}]}
