)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"82a8ce59b5568189931953ac74f193307d7e5bd8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The qos policy parameter was missing from the request and the"},{"line_number":10,"context_line":"response of the different port operations."},{"line_number":11,"context_line":"This change ads them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8c665a9eec4f627b97af4d937f49afdd7bd60fc7"},{"line_number":14,"context_line":"Signed-off-by: csatari \u003cgergely.csatari@nokia.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f287b81_ca2039af","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":15},"updated":"2017-08-29 10:56:21.000000000","message":"nit: \"adds\"","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cb1cafb2c225c2de36485c1ec89f5af962d41b5a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The qos policy parameter was missing from the request and the"},{"line_number":10,"context_line":"response of the different port operations."},{"line_number":11,"context_line":"This change adds them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8c665a9eec4f627b97af4d937f49afdd7bd60fc7"},{"line_number":14,"context_line":"Signed-off-by: csatari \u003cgergely.csatari@nokia.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ff82abbf_a3006eac","line":12,"updated":"2017-11-29 22:25:24.000000000","message":"This patch is probably related to bug: https://bugs.launchpad.net/neutron/+bug/1735093 so please add \"Closes-Bug\" to Your commit message if this is it :)","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"11cdd966f02699b4a09918d86251f143ffc76b27","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The qos policy parameter was missing from the request and the"},{"line_number":10,"context_line":"response of the different port operations."},{"line_number":11,"context_line":"This change adds them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8c665a9eec4f627b97af4d937f49afdd7bd60fc7"},{"line_number":14,"context_line":"Signed-off-by: csatari \u003cgergely.csatari@nokia.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"df87a7cf_7602c80b","line":12,"in_reply_to":"ff82abbf_a3006eac","updated":"2017-12-05 16:34:51.000000000","message":"Good catch. Thanks.","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"}],"api-ref/source/v2/networks.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"baeead0a6cc91db36d58b0948353a9983e5bb67e","unresolved":false,"context_lines":[{"line_number":361,"context_line":"in a response. In this example, a network ``net1`` is mapped to a single"},{"line_number":362,"context_line":"network segment and a network ``net2`` is mapped to multiple network segments."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":".. literalinclude:: samples/networks/networks-provider-list-response.json"},{"line_number":365,"context_line":"   :language: javascript"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"Create network"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"df87a7cf_248b6f6e","line":364,"range":{"start_line":364,"start_character":20,"end_line":364,"end_character":73},"updated":"2017-12-07 13:24:31.000000000","message":"It appears the 1st json network object in this response is missing a sample qos_policy_id https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/samples/networks/networks-provider-list-response.json","commit_id":"75def79b6efaab133872de3d2735b8a4ec718569"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"03b08d9048e5df47563168b71b7cbf4efb3da0d8","unresolved":false,"context_lines":[{"line_number":361,"context_line":"in a response. In this example, a network ``net1`` is mapped to a single"},{"line_number":362,"context_line":"network segment and a network ``net2`` is mapped to multiple network segments."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":".. literalinclude:: samples/networks/networks-provider-list-response.json"},{"line_number":365,"context_line":"   :language: javascript"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"Create network"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"df87a7cf_ce25f95d","line":364,"range":{"start_line":364,"start_character":20,"end_line":364,"end_character":73},"in_reply_to":"df87a7cf_248b6f6e","updated":"2017-12-07 16:59:45.000000000","message":"Done","commit_id":"75def79b6efaab133872de3d2735b8a4ec718569"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b533a1d7926e2946d8d134f77e2f3a60335aa61e","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Auto Allocated Topology"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"The ``auto-allocated-topology`` extension adds the ``is_default`` boolean"},{"line_number":113,"context_line":"attribute to networks. This value indicates the network should be used when"},{"line_number":114,"context_line":"auto allocating topologies."}],"source_content_type":"text/x-c++src","patch_set":21,"id":"1f9dbf25_13e94019","side":"PARENT","line":111,"updated":"2018-03-01 05:24:30.000000000","message":"Do you need this change?","commit_id":"503273b4483b53444b86882115bab9b14636d0c9"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"a8d3caaab3d5b107c894540c627ff4aa9f3660ab","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Auto Allocated Topology"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"The ``auto-allocated-topology`` extension adds the ``is_default`` boolean"},{"line_number":113,"context_line":"attribute to networks. This value indicates the network should be used when"},{"line_number":114,"context_line":"auto allocating topologies."}],"source_content_type":"text/x-c++src","patch_set":21,"id":"1f9dbf25_082d8a94","side":"PARENT","line":111,"in_reply_to":"1f9dbf25_13e94019","updated":"2018-03-01 09:42:29.000000000","message":"The chapter is coming from a rebase?\nThe empty line I added for consistency.","commit_id":"503273b4483b53444b86882115bab9b14636d0c9"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f9bf91a32b88e1e23fa2191b6c1095bde822c08d","unresolved":false,"context_lines":[{"line_number":4225,"context_line":"  in: body"},{"line_number":4226,"context_line":"  required: true"},{"line_number":4227,"context_line":"  type: string"},{"line_number":4228,"context_line":"qos_policy_id-port-request:"},{"line_number":4229,"context_line":"  description: |"},{"line_number":4230,"context_line":"    The ID of the QoS policy to be used."},{"line_number":4231,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_3b4c43c6","line":4228,"range":{"start_line":4228,"start_character":0,"end_line":4228,"end_character":26},"updated":"2017-05-30 00:43:00.000000000","message":"How different is this from qos_policy_id-request?","commit_id":"b6554a5b85062688ce332e0b7863b13e0d8efe9e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7354a148982a263c3ba9292f0f6c2d4a93065024","unresolved":false,"context_lines":[{"line_number":4225,"context_line":"  in: body"},{"line_number":4226,"context_line":"  required: true"},{"line_number":4227,"context_line":"  type: string"},{"line_number":4228,"context_line":"qos_policy_id-port-request:"},{"line_number":4229,"context_line":"  description: |"},{"line_number":4230,"context_line":"    The ID of the QoS policy to be used."},{"line_number":4231,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f436f4f_98a1c2ac","line":4228,"range":{"start_line":4228,"start_character":0,"end_line":4228,"end_character":26},"in_reply_to":"7f231b9d_6dee8b89","updated":"2017-08-10 16:30:29.000000000","message":"Sorry, I don\u0027t understand the reply. What does \"policy shall be used\" mean? By other port? Or does it mean that this policy could be in use now in this port?","commit_id":"b6554a5b85062688ce332e0b7863b13e0d8efe9e"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"04c8f3ff91fdd0f26871aca70b7df27598a455e0","unresolved":false,"context_lines":[{"line_number":4225,"context_line":"  in: body"},{"line_number":4226,"context_line":"  required: true"},{"line_number":4227,"context_line":"  type: string"},{"line_number":4228,"context_line":"qos_policy_id-port-request:"},{"line_number":4229,"context_line":"  description: |"},{"line_number":4230,"context_line":"    The ID of the QoS policy to be used."},{"line_number":4231,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f436f4f_2f8dd37a","line":4228,"range":{"start_line":4228,"start_character":0,"end_line":4228,"end_character":26},"in_reply_to":"9f436f4f_98a1c2ac","updated":"2017-11-04 23:15:59.000000000","message":"It means that the policy should be used in this port.","commit_id":"b6554a5b85062688ce332e0b7863b13e0d8efe9e"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"b7a01b729266256b8a24bf51761a21be3afcb8f7","unresolved":false,"context_lines":[{"line_number":4225,"context_line":"  in: body"},{"line_number":4226,"context_line":"  required: true"},{"line_number":4227,"context_line":"  type: string"},{"line_number":4228,"context_line":"qos_policy_id-port-request:"},{"line_number":4229,"context_line":"  description: |"},{"line_number":4230,"context_line":"    The ID of the QoS policy to be used."},{"line_number":4231,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f231b9d_6dee8b89","line":4228,"range":{"start_line":4228,"start_character":0,"end_line":4228,"end_character":26},"in_reply_to":"df140735_3b4c43c6","updated":"2017-08-10 15:09:22.000000000","message":"qos_policy_id-request does not mention that this qos policy shall be used.","commit_id":"b6554a5b85062688ce332e0b7863b13e0d8efe9e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f9bf91a32b88e1e23fa2191b6c1095bde822c08d","unresolved":false,"context_lines":[{"line_number":4231,"context_line":"  in: body"},{"line_number":4232,"context_line":"  required: false"},{"line_number":4233,"context_line":"  type: string"},{"line_number":4234,"context_line":"qos_policy_id-port-response:"},{"line_number":4235,"context_line":"  description: |"},{"line_number":4236,"context_line":"    The ID of the used QoS policy."},{"line_number":4237,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_1bc73f15","line":4234,"range":{"start_line":4234,"start_character":0,"end_line":4234,"end_character":27},"updated":"2017-05-30 00:43:00.000000000","message":"How different is this from qos_policy_id-body?","commit_id":"b6554a5b85062688ce332e0b7863b13e0d8efe9e"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"b7a01b729266256b8a24bf51761a21be3afcb8f7","unresolved":false,"context_lines":[{"line_number":4231,"context_line":"  in: body"},{"line_number":4232,"context_line":"  required: false"},{"line_number":4233,"context_line":"  type: string"},{"line_number":4234,"context_line":"qos_policy_id-port-response:"},{"line_number":4235,"context_line":"  description: |"},{"line_number":4236,"context_line":"    The ID of the used QoS policy."},{"line_number":4237,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f231b9d_0dfdd739","line":4234,"range":{"start_line":4234,"start_character":0,"end_line":4234,"end_character":27},"in_reply_to":"df140735_1bc73f15","updated":"2017-08-10 15:09:22.000000000","message":"qos_policy_id-body does not mention, that this is the used qos policy.","commit_id":"b6554a5b85062688ce332e0b7863b13e0d8efe9e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f9bf91a32b88e1e23fa2191b6c1095bde822c08d","unresolved":false,"context_lines":[{"line_number":4235,"context_line":"  description: |"},{"line_number":4236,"context_line":"    The ID of the used QoS policy."},{"line_number":4237,"context_line":"  in: body"},{"line_number":4238,"context_line":"  required: false"},{"line_number":4239,"context_line":"  type: string"},{"line_number":4240,"context_line":"qos_policy_id-request:"},{"line_number":4241,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_7b699b23","line":4238,"range":{"start_line":4238,"start_character":12,"end_line":4238,"end_character":17},"updated":"2017-05-30 00:43:00.000000000","message":"In response, it should be true.","commit_id":"b6554a5b85062688ce332e0b7863b13e0d8efe9e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"49ebf417885077a655c15bc284f9d3d627ec52b4","unresolved":false,"context_lines":[{"line_number":4657,"context_line":"  type: string"},{"line_number":4658,"context_line":"qos_policy_id-port-request:"},{"line_number":4659,"context_line":"  description: |"},{"line_number":4660,"context_line":"    The ID of the QoS policy to be used."},{"line_number":4661,"context_line":"  in: body"},{"line_number":4662,"context_line":"  required: false"},{"line_number":4663,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f4b6375_ecb75420","line":4660,"range":{"start_line":4660,"start_character":35,"end_line":4660,"end_character":39},"updated":"2017-11-07 14:11:30.000000000","message":"used works for me, but would it be cleaner to say \"QoS policy associated with the port.\"?","commit_id":"22fb3e5207aaa2495245d81f5e3fe7b495f02cea"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"12c69df3b02afc22ca4471904a98a53a4d6cf4d2","unresolved":false,"context_lines":[{"line_number":4657,"context_line":"  type: string"},{"line_number":4658,"context_line":"qos_policy_id-port-request:"},{"line_number":4659,"context_line":"  description: |"},{"line_number":4660,"context_line":"    The ID of the QoS policy to be used."},{"line_number":4661,"context_line":"  in: body"},{"line_number":4662,"context_line":"  required: false"},{"line_number":4663,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f4b6375_a7960eef","line":4660,"range":{"start_line":4660,"start_character":35,"end_line":4660,"end_character":39},"in_reply_to":"3f4b6375_ecb75420","updated":"2017-11-07 22:31:18.000000000","message":"Done","commit_id":"22fb3e5207aaa2495245d81f5e3fe7b495f02cea"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"49ebf417885077a655c15bc284f9d3d627ec52b4","unresolved":false,"context_lines":[{"line_number":4663,"context_line":"  type: string"},{"line_number":4664,"context_line":"qos_policy_id-port-response:"},{"line_number":4665,"context_line":"  description: |"},{"line_number":4666,"context_line":"    The ID of the used QoS policy."},{"line_number":4667,"context_line":"  in: body"},{"line_number":4668,"context_line":"  required: true"},{"line_number":4669,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f4b6375_4cc78897","line":4666,"range":{"start_line":4666,"start_character":18,"end_line":4666,"end_character":22},"updated":"2017-11-07 14:11:30.000000000","message":"used works for me, but would \"associated\" be a better choice?","commit_id":"22fb3e5207aaa2495245d81f5e3fe7b495f02cea"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"12c69df3b02afc22ca4471904a98a53a4d6cf4d2","unresolved":false,"context_lines":[{"line_number":4663,"context_line":"  type: string"},{"line_number":4664,"context_line":"qos_policy_id-port-response:"},{"line_number":4665,"context_line":"  description: |"},{"line_number":4666,"context_line":"    The ID of the used QoS policy."},{"line_number":4667,"context_line":"  in: body"},{"line_number":4668,"context_line":"  required: true"},{"line_number":4669,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f4b6375_8799d21f","line":4666,"range":{"start_line":4666,"start_character":18,"end_line":4666,"end_character":22},"in_reply_to":"3f4b6375_4cc78897","updated":"2017-11-07 22:31:18.000000000","message":"Done","commit_id":"22fb3e5207aaa2495245d81f5e3fe7b495f02cea"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"535c5def367c8d1cada48fadf732ef097a90f9fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# variables in header"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# variables in path"},{"line_number":4,"context_line":"agent_id-path:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff82abbf_f494b9ea","line":1,"updated":"2017-11-21 14:04:19.000000000","message":"?? whats this change for?","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"11cdd966f02699b4a09918d86251f143ffc76b27","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# variables in header"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# variables in path"},{"line_number":4,"context_line":"agent_id-path:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df87a7cf_bbdfd9d4","line":1,"in_reply_to":"ff82abbf_f494b9ea","updated":"2017-12-05 16:34:51.000000000","message":"Just consitency with the other similar comments. I\u0027ve added the space back.","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a3a93f142e401d5708f4fa84e7d148425cb3610c","unresolved":false,"context_lines":[{"line_number":3397,"context_line":"  in: body"},{"line_number":3398,"context_line":"  required: true"},{"line_number":3399,"context_line":"  type: string"},{"line_number":3400,"context_line":"qos_policy_id-body:"},{"line_number":3401,"context_line":"  description: |"},{"line_number":3402,"context_line":"    The ID of the QoS policy."},{"line_number":3403,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1f9dbf25_6adc6718","line":3400,"updated":"2018-02-27 14:18:04.000000000","message":"I think that this one is now not used anywhere so maybe You should delete it?","commit_id":"802fbc7835ed2c32c7e07006877274ef7f785f6d"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"6d847ed02060d79a50a3e895ad689680f63f14f7","unresolved":false,"context_lines":[{"line_number":3397,"context_line":"  in: body"},{"line_number":3398,"context_line":"  required: true"},{"line_number":3399,"context_line":"  type: string"},{"line_number":3400,"context_line":"qos_policy_id-body:"},{"line_number":3401,"context_line":"  description: |"},{"line_number":3402,"context_line":"    The ID of the QoS policy."},{"line_number":3403,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1f9dbf25_e418ab76","line":3400,"in_reply_to":"1f9dbf25_6adc6718","updated":"2018-02-27 15:48:34.000000000","message":"Done","commit_id":"802fbc7835ed2c32c7e07006877274ef7f785f6d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"404f0590198d359d34d72a7178a5ff50122bd8da","unresolved":false,"context_lines":[{"line_number":4199,"context_line":"  in: body"},{"line_number":4200,"context_line":"  required: true"},{"line_number":4201,"context_line":"  type: string"},{"line_number":4202,"context_line":"qos_policy_id-port-request:"},{"line_number":4203,"context_line":"  description: |"},{"line_number":4204,"context_line":"    QoS policy associated with the port."},{"line_number":4205,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9f6a8fd7_038ee4cf","line":4202,"updated":"2018-04-27 07:18:32.000000000","message":"I\u0027m not sure if You need this new variable. It is used in description of \"port update\" but similar description for \"network update\" uses only \"qos_policy_id-request\" which is defined just below.\nMaybe You could use the same for port or introduce also new parameter for network to make it more consistent.","commit_id":"ed41c94558e0aacf7088261617f73ae434743d6b"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"b662d8fceef7679b16f7c2504a46cfd92e5f3692","unresolved":false,"context_lines":[{"line_number":4199,"context_line":"  in: body"},{"line_number":4200,"context_line":"  required: true"},{"line_number":4201,"context_line":"  type: string"},{"line_number":4202,"context_line":"qos_policy_id-port-request:"},{"line_number":4203,"context_line":"  description: |"},{"line_number":4204,"context_line":"    QoS policy associated with the port."},{"line_number":4205,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9f6a8fd7_7c035f43","line":4202,"in_reply_to":"9f6a8fd7_038ee4cf","updated":"2018-05-03 04:54:24.000000000","message":"I think it is important to mention the target of the QoS settings, so I would prefer to have a port and a network specific variable.","commit_id":"ed41c94558e0aacf7088261617f73ae434743d6b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4e0357bff024e2146b74cc5a6d51b21307a142c9","unresolved":false,"context_lines":[{"line_number":4199,"context_line":"  in: body"},{"line_number":4200,"context_line":"  required: true"},{"line_number":4201,"context_line":"  type: string"},{"line_number":4202,"context_line":"qos_policy_id-port-request:"},{"line_number":4203,"context_line":"  description: |"},{"line_number":4204,"context_line":"    QoS policy associated with the port."},{"line_number":4205,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5f7c97a3_fed910f4","line":4202,"in_reply_to":"9f6a8fd7_7c035f43","updated":"2018-05-03 09:39:55.000000000","message":"that\u0027s fine for me. Thanks","commit_id":"ed41c94558e0aacf7088261617f73ae434743d6b"}],"api-ref/source/v2/ports.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13161193d3c6c067d93a4977575db9b0e31e09b4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"QoS extension"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The QoS extension (``qos``) makes it possible to define QoS policies and"},{"line_number":41,"context_line":"associate these to the ports. The policies should be created, before they are"},{"line_number":42,"context_line":"associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f436f4f_ecd5b0b8","line":40,"range":{"start_line":40,"start_character":56,"end_line":40,"end_character":59},"updated":"2017-08-10 19:11:25.000000000","message":"Maybe this should link to the \"Quality of Service\" section of the API ref?","commit_id":"ff9e52474fc817833287876a116800bb2bad6cf3"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"0fdc126e29462d94f7756bed3b6c3d520e08ee0c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"QoS extension"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The QoS extension (``qos``) makes it possible to define QoS policies and"},{"line_number":41,"context_line":"associate these to the ports. The policies should be created, before they are"},{"line_number":42,"context_line":"associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f436f4f_145fbf0e","line":40,"range":{"start_line":40,"start_character":56,"end_line":40,"end_character":59},"in_reply_to":"9f436f4f_ecd5b0b8","updated":"2017-08-11 15:14:36.000000000","message":"Done","commit_id":"ff9e52474fc817833287876a116800bb2bad6cf3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aa6692a228f5dee794a80a5df7dbe727fe51a686","unresolved":false,"context_lines":[{"line_number":42,"context_line":"associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- ``bandwidth_limit``: Limits the bandwith available for the port."},{"line_number":45,"context_line":"-  ``dscp_marking``: Adds DSCP making to the port."},{"line_number":46,"context_line":"-  ``minimum_bandwidth``: Provides guaranteed minimum bandwith to the port."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"|"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f436f4f_9b065c86","line":45,"updated":"2017-08-10 17:26:19.000000000","message":"nit: one space at the beginning of the line is not necessary IMHO","commit_id":"ff9e52474fc817833287876a116800bb2bad6cf3"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"0fdc126e29462d94f7756bed3b6c3d520e08ee0c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- ``bandwidth_limit``: Limits the bandwith available for the port."},{"line_number":45,"context_line":"-  ``dscp_marking``: Adds DSCP making to the port."},{"line_number":46,"context_line":"-  ``minimum_bandwidth``: Provides guaranteed minimum bandwith to the port."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"|"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f436f4f_8f74bf69","line":45,"in_reply_to":"9f436f4f_9b065c86","updated":"2017-08-11 15:14:36.000000000","message":"Done","commit_id":"ff9e52474fc817833287876a116800bb2bad6cf3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aa6692a228f5dee794a80a5df7dbe727fe51a686","unresolved":false,"context_lines":[{"line_number":44,"context_line":"- ``bandwidth_limit``: Limits the bandwith available for the port."},{"line_number":45,"context_line":"-  ``dscp_marking``: Adds DSCP making to the port."},{"line_number":46,"context_line":"-  ``minimum_bandwidth``: Provides guaranteed minimum bandwith to the port."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"|"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Show port details"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f436f4f_7b097893","line":47,"updated":"2017-08-10 17:26:19.000000000","message":"nit: here also space at the beginning is probably not necessary,\nAlso please note that this rule is not guarantee minimum bandwidth - it\u0027s best effor rule currently","commit_id":"ff9e52474fc817833287876a116800bb2bad6cf3"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"0fdc126e29462d94f7756bed3b6c3d520e08ee0c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"- ``bandwidth_limit``: Limits the bandwith available for the port."},{"line_number":45,"context_line":"-  ``dscp_marking``: Adds DSCP making to the port."},{"line_number":46,"context_line":"-  ``minimum_bandwidth``: Provides guaranteed minimum bandwith to the port."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"|"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Show port details"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f436f4f_cf5ac7f1","line":47,"in_reply_to":"9f436f4f_7b097893","updated":"2017-08-11 15:14:36.000000000","message":"Done","commit_id":"ff9e52474fc817833287876a116800bb2bad6cf3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13161193d3c6c067d93a4977575db9b0e31e09b4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Response Example"},{"line_number":108,"context_line":"----------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":".. literalinclude:: samples/ports/port-show-response.json"},{"line_number":111,"context_line":"   :language: javascript"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Response Example (admin user)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f436f4f_8c9504e7","line":110,"updated":"2017-08-10 19:11:25.000000000","message":"This comment applies to all requests that have policy id in the response; should we show it in the same response JSON?","commit_id":"ff9e52474fc817833287876a116800bb2bad6cf3"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"0fdc126e29462d94f7756bed3b6c3d520e08ee0c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Response Example"},{"line_number":108,"context_line":"----------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":".. literalinclude:: samples/ports/port-show-response.json"},{"line_number":111,"context_line":"   :language: javascript"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Response Example (admin user)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f436f4f_b26da305","line":110,"in_reply_to":"9f436f4f_8c9504e7","updated":"2017-08-11 15:14:36.000000000","message":"Done","commit_id":"ff9e52474fc817833287876a116800bb2bad6cf3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3ce12c8434dbe094f555d4527abdbbdff7f6a57b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"QoS extension"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The :ref:`QoS \u003cqos-rule-types\u003e` extension (``qos``) makes it possible to define QoS"},{"line_number":41,"context_line":"policies and associate these to the ports. The policies should be created,"},{"line_number":42,"context_line":"before they are associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"9f436f4f_4fe909b5","line":40,"range":{"start_line":40,"start_character":10,"end_line":40,"end_character":30},"updated":"2017-08-14 13:42:32.000000000","message":"The link generated from this doesn\u0027t seem to work right. Is it working for you in: http://docs-draft.openstack.org/60/468660/3/check/gate-neutron-lib-api-ref/f8d07c5//api-ref/build/html/v2/index.html#qos-extension","commit_id":"8107e0c4c8212d1c4d1b4bd77b35fba2bff052fb"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d919dd1fb9e40da3826781b876a8a6d73fc06e21","unresolved":false,"context_lines":[{"line_number":37,"context_line":"QoS extension"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The :ref:`QoS \u003cqos_rule_types\u003e` extension (``qos``) makes it possible to define QoS"},{"line_number":41,"context_line":"policies and associate these to the ports. The policies should be created,"},{"line_number":42,"context_line":"before they are associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"7f287b81_df62e4d8","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":29},"updated":"2017-08-22 16:06:19.000000000","message":"Maybe this is a nit, but is it best to ref the rule types rather than just the QoS section (index.html#quality-of-service)?","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"9be743f6b8f1dd5139b900b45bdd659d1b602b27","unresolved":false,"context_lines":[{"line_number":37,"context_line":"QoS extension"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The :ref:`QoS \u003cqos_rule_types\u003e` extension (``qos``) makes it possible to define QoS"},{"line_number":41,"context_line":"policies and associate these to the ports. The policies should be created,"},{"line_number":42,"context_line":"before they are associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"7f287b81_b3a8d08b","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":29},"in_reply_to":"7f287b81_df62e4d8","updated":"2017-08-29 07:08:12.000000000","message":"Done","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"57ad13134e426af6e678cac84028ecabf490fb15","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The :ref:`QoS \u003cqos_rule_types\u003e` extension (``qos``) makes it possible to define QoS"},{"line_number":41,"context_line":"policies and associate these to the ports. The policies should be created,"},{"line_number":42,"context_line":"before they are associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- ``bandwidth_limit``: Limits the bandwith available for the port."},{"line_number":45,"context_line":"- ``dscp_marking``: Adds DSCP making to the port."}],"source_content_type":"text/x-c++src","patch_set":4,"id":"7f287b81_7bd9af81","line":42,"updated":"2017-08-23 09:38:01.000000000","message":"Policy can contains rules from more than one rule type. It even can contains 2 rules with same type but different direction (bw_limit rule)","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"9be743f6b8f1dd5139b900b45bdd659d1b602b27","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The :ref:`QoS \u003cqos_rule_types\u003e` extension (``qos``) makes it possible to define QoS"},{"line_number":41,"context_line":"policies and associate these to the ports. The policies should be created,"},{"line_number":42,"context_line":"before they are associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- ``bandwidth_limit``: Limits the bandwith available for the port."},{"line_number":45,"context_line":"- ``dscp_marking``: Adds DSCP making to the port."}],"source_content_type":"text/x-c++src","patch_set":4,"id":"7f287b81_d3959c34","line":42,"in_reply_to":"7f287b81_7bd9af81","updated":"2017-08-29 07:08:12.000000000","message":"Done","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"57ad13134e426af6e678cac84028ecabf490fb15","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- ``bandwidth_limit``: Limits the bandwith available for the port."},{"line_number":45,"context_line":"- ``dscp_marking``: Adds DSCP making to the port."},{"line_number":46,"context_line":"- ``minimum_bandwidth``: Provides guaranteed minimum bandwith to the port."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"|"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"7f287b81_5be6f346","line":46,"updated":"2017-08-23 09:38:01.000000000","message":"I agree with boden here, IMHO it\u0027s not necessary to put this info here","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d919dd1fb9e40da3826781b876a8a6d73fc06e21","unresolved":false,"context_lines":[{"line_number":41,"context_line":"policies and associate these to the ports. The policies should be created,"},{"line_number":42,"context_line":"before they are associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- ``bandwidth_limit``: Limits the bandwith available for the port."},{"line_number":45,"context_line":"- ``dscp_marking``: Adds DSCP making to the port."},{"line_number":46,"context_line":"- ``minimum_bandwidth``: Provides guaranteed minimum bandwith to the port."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"|"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"7f287b81_1fc50c8f","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":74},"updated":"2017-08-22 16:06:19.000000000","message":"These are rule types associated with QoS Policies correct?\nIf so do we really want to get into talking about such details here? From a user perspective IMHO the important info for this section is to know the qos extn allows you to associated a QoS policy with a port which is given by the qos_policy_id.","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"9be743f6b8f1dd5139b900b45bdd659d1b602b27","unresolved":false,"context_lines":[{"line_number":41,"context_line":"policies and associate these to the ports. The policies should be created,"},{"line_number":42,"context_line":"before they are associated to the ports, with one of the following rule types:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- ``bandwidth_limit``: Limits the bandwith available for the port."},{"line_number":45,"context_line":"- ``dscp_marking``: Adds DSCP making to the port."},{"line_number":46,"context_line":"- ``minimum_bandwidth``: Provides guaranteed minimum bandwith to the port."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"|"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"7f287b81_b396903d","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":74},"in_reply_to":"7f287b81_1fc50c8f","updated":"2017-08-29 07:08:12.000000000","message":"Done","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"9be743f6b8f1dd5139b900b45bdd659d1b602b27","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- ``bandwidth_limit``: Limits the bandwith available for the port."},{"line_number":45,"context_line":"- ``dscp_marking``: Adds DSCP making to the port."},{"line_number":46,"context_line":"- ``minimum_bandwidth``: Provides guaranteed minimum bandwith to the port."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"|"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"7f287b81_939b9464","line":46,"in_reply_to":"7f287b81_5be6f346","updated":"2017-08-29 07:08:12.000000000","message":"Done","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"82a8ce59b5568189931953ac74f193307d7e5bd8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"- ``DOWN``: no traffic can flow from/to the port"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"|"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"DNS integration"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"7f287b81_25336ef8","line":36,"updated":"2017-08-29 10:56:21.000000000","message":"Why add extra lines here?","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"1b043491526e24ce42e41b597223390b99e7a2cf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"- ``DOWN``: no traffic can flow from/to the port"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"|"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"DNS integration"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"7f287b81_f7de3dd8","line":36,"in_reply_to":"7f287b81_25336ef8","updated":"2017-09-04 05:56:41.000000000","message":"As it is in between \"Port binding extended attributes\" and \"Data plane status extension\" I\u0027ve added empty lines for consitency. \n\nMaybe we should have all extensions under a subchapter. How do you like this options?","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"82a8ce59b5568189931953ac74f193307d7e5bd8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The :ref:`QoS \u003cquality-of-service\u003e` extension (``qos``) makes it possible to define QoS"},{"line_number":57,"context_line":"policies and associate these to the ports. The policies should be created,"},{"line_number":58,"context_line":"before they are associated to the ports. One policy can contain more than one"},{"line_number":59,"context_line":"rule type."},{"line_number":60,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"7f287b81_05175247","line":57,"range":{"start_line":57,"start_character":73,"end_line":57,"end_character":74},"updated":"2017-08-29 10:56:21.000000000","message":"Nit: I don\u0027t think there\u0027s a need for a comma here is there?","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"1b043491526e24ce42e41b597223390b99e7a2cf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The :ref:`QoS \u003cquality-of-service\u003e` extension (``qos``) makes it possible to define QoS"},{"line_number":57,"context_line":"policies and associate these to the ports. The policies should be created,"},{"line_number":58,"context_line":"before they are associated to the ports. One policy can contain more than one"},{"line_number":59,"context_line":"rule type."},{"line_number":60,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"7f287b81_57051145","line":57,"range":{"start_line":57,"start_character":73,"end_line":57,"end_character":74},"in_reply_to":"7f287b81_05175247","updated":"2017-09-04 05:56:41.000000000","message":"I trust in your English more than in mine, so I remove it.","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5580653ab4ec7ee60a85dd26e801e504e7e795bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"branch 0.. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Ports"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"7f287b81_3e8520d0","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":8},"updated":"2017-09-05 14:40:37.000000000","message":"Is this intended?\nSeems like a copy/paste or editor error to me.","commit_id":"4602b8f7dbd1fe0d5ed84f7eb57933c25d8c6957"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"189e2ff5c3169cfb003c6008782bcb7e5793d34b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"branch 0.. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Ports"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"7f287b81_5e1b331a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":8},"in_reply_to":"7f287b81_3e8520d0","updated":"2017-09-06 09:29:44.000000000","message":"Done","commit_id":"4602b8f7dbd1fe0d5ed84f7eb57933c25d8c6957"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5580653ab4ec7ee60a85dd26e801e504e7e795bd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Lists, shows details for, creates, updates, and deletes ports."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extensions"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Port binding extended attributes"},{"line_number":13,"context_line":"--------------------------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"7f287b81_deaa9c17","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":10},"updated":"2017-09-05 14:40:37.000000000","message":"I\u0027m not sure we should change the formatting as such herein. The other resource sections (Networks for example) don\u0027t have the Extensions subhead like this so if we want to make such a change we should propose it for all sections for the doc, not just ports. Moreover that would probably be a separate patch so we can discuss that topic by itself rather than intermingled with this change.","commit_id":"4602b8f7dbd1fe0d5ed84f7eb57933c25d8c6957"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"189e2ff5c3169cfb003c6008782bcb7e5793d34b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Lists, shows details for, creates, updates, and deletes ports."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extensions"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Port binding extended attributes"},{"line_number":13,"context_line":"--------------------------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"7f287b81_9e7d1b1e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":10},"in_reply_to":"7f287b81_deaa9c17","updated":"2017-09-06 09:29:44.000000000","message":"I think it is more straightforward to list the extensions in a separate subchapter, but I agree that that should be consistent across the whole api-ref (of Neutron at least). Maybe I will propose this as a separate change.","commit_id":"4602b8f7dbd1fe0d5ed84f7eb57933c25d8c6957"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5580653ab4ec7ee60a85dd26e801e504e7e795bd","unresolved":false,"context_lines":[{"line_number":51,"context_line":"-------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"The :ref:`QoS \u003cquality-of-service\u003e` extension (``qos``) makes it possible to define QoS"},{"line_number":54,"context_line":"policies and associate these to the ports. The policies should be created"},{"line_number":55,"context_line":"before they are associated to the ports. One policy can contain more than one"},{"line_number":56,"context_line":"rule type."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"7f287b81_7e1cc876","line":54,"range":{"start_line":54,"start_character":41,"end_line":54,"end_character":42},"updated":"2017-09-05 14:40:37.000000000","message":"It might be nice to add a blurb about what attribute this ext adds. EX::\n\n  ...to the ports by introducing the ``qos_policy_id`` attribute.","commit_id":"4602b8f7dbd1fe0d5ed84f7eb57933c25d8c6957"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"189e2ff5c3169cfb003c6008782bcb7e5793d34b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"-------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"The :ref:`QoS \u003cquality-of-service\u003e` extension (``qos``) makes it possible to define QoS"},{"line_number":54,"context_line":"policies and associate these to the ports. The policies should be created"},{"line_number":55,"context_line":"before they are associated to the ports. One policy can contain more than one"},{"line_number":56,"context_line":"rule type."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"7f287b81_deff2365","line":54,"range":{"start_line":54,"start_character":41,"end_line":54,"end_character":42},"in_reply_to":"7f287b81_7e1cc876","updated":"2017-09-06 09:29:44.000000000","message":"Done","commit_id":"4602b8f7dbd1fe0d5ed84f7eb57933c25d8c6957"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"49ebf417885077a655c15bc284f9d3d627ec52b4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"The :ref:`QoS \u003cquality-of-service\u003e` extension (``qos``) makes it possible to"},{"line_number":71,"context_line":"define QoS policies and associate these to the ports by introducing the"},{"line_number":72,"context_line":"``qos_policy_id`` attribute. The policies should be created before they are"},{"line_number":73,"context_line":"associated to the ports. One policy can contain more than one rule type."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Show port details"},{"line_number":76,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f4b6375_acd6fc4d","line":73,"range":{"start_line":73,"start_character":25,"end_line":73,"end_character":72},"updated":"2017-11-07 14:11:30.000000000","message":"I\u0027d opt just to leave this detail on the QoS policy API ref section.","commit_id":"22fb3e5207aaa2495245d81f5e3fe7b495f02cea"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"12c69df3b02afc22ca4471904a98a53a4d6cf4d2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"The :ref:`QoS \u003cquality-of-service\u003e` extension (``qos``) makes it possible to"},{"line_number":71,"context_line":"define QoS policies and associate these to the ports by introducing the"},{"line_number":72,"context_line":"``qos_policy_id`` attribute. The policies should be created before they are"},{"line_number":73,"context_line":"associated to the ports. One policy can contain more than one rule type."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Show port details"},{"line_number":76,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f4b6375_f90eea2f","line":73,"range":{"start_line":73,"start_character":25,"end_line":73,"end_character":72},"in_reply_to":"3f4b6375_acd6fc4d","updated":"2017-11-07 22:31:18.000000000","message":"Done","commit_id":"22fb3e5207aaa2495245d81f5e3fe7b495f02cea"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"49ebf417885077a655c15bc284f9d3d627ec52b4","unresolved":false,"context_lines":[{"line_number":145,"context_line":".. literalinclude:: samples/ports/port-bind-show-response.json"},{"line_number":146,"context_line":"   :language: javascript"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Response Example (QoS)"},{"line_number":149,"context_line":"----------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":".. literalinclude:: samples/ports/port-qos-show-response.json"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f4b6375_0c52b0de","line":148,"updated":"2017-11-07 14:11:30.000000000","message":"I know it was suggested to use a separate example for these, but IMHO it\u0027s cleaner to just add to the existing. IIUC these \"new\" example responses aren\u0027t really any different than the port-show and port-bind above are they?\n\n\nI guess I don\u0027t see the value in yet another sample response, and I\u0027d prefer to not get into the business of having separate responses for each extension.","commit_id":"22fb3e5207aaa2495245d81f5e3fe7b495f02cea"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"12c69df3b02afc22ca4471904a98a53a4d6cf4d2","unresolved":false,"context_lines":[{"line_number":145,"context_line":".. literalinclude:: samples/ports/port-bind-show-response.json"},{"line_number":146,"context_line":"   :language: javascript"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Response Example (QoS)"},{"line_number":149,"context_line":"----------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":".. literalinclude:: samples/ports/port-qos-show-response.json"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f4b6375_476d1a01","line":148,"in_reply_to":"3f4b6375_0c52b0de","updated":"2017-11-07 22:31:18.000000000","message":"Ookay. How about adding back the qos examples to the orgirinal ones and describe, that this parameter is there only if the qos extension is used?","commit_id":"22fb3e5207aaa2495245d81f5e3fe7b495f02cea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d65158f08c0ea0d2b71245f28f706e336f414453","unresolved":false,"context_lines":[{"line_number":213,"context_line":"----------------------------"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. literalinclude:: samples/ports/port-bind-update-request.json"},{"line_number":216,"context_line":" :language: javascript"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Response Parameters"},{"line_number":219,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"1f485f77_221b4eca","line":216,"updated":"2017-11-18 08:39:20.000000000","message":"how this is related to Your change?","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"11cdd966f02699b4a09918d86251f143ffc76b27","unresolved":false,"context_lines":[{"line_number":213,"context_line":"----------------------------"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. literalinclude:: samples/ports/port-bind-update-request.json"},{"line_number":216,"context_line":" :language: javascript"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Response Parameters"},{"line_number":219,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df87a7cf_3be0a9fa","line":216,"in_reply_to":"1f485f77_221b4eca","updated":"2017-12-05 16:34:51.000000000","message":"It is not related. Did I made any change here??","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e2afc20a6320f52c0d16420e7ef74beccf355b3d","unresolved":false,"context_lines":[{"line_number":213,"context_line":"----------------------------"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. literalinclude:: samples/ports/port-bind-update-request.json"},{"line_number":216,"context_line":" :language: javascript"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Response Parameters"},{"line_number":219,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df87a7cf_097eb618","line":216,"in_reply_to":"df87a7cf_3be0a9fa","updated":"2017-12-05 20:55:13.000000000","message":"it looks like You removed spaces from beginning of this line","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"535c5def367c8d1cada48fadf732ef097a90f9fa","unresolved":false,"context_lines":[{"line_number":251,"context_line":"   - tenant_id: project_id"},{"line_number":252,"context_line":"   - updated_at: updated_at"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Response Example"},{"line_number":255,"context_line":"----------------"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":".. literalinclude:: samples/ports/port-update-response.json"},{"line_number":258,"context_line":"   :language: javascript"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Response Example (admin user)"},{"line_number":261,"context_line":"-----------------------------"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":".. literalinclude:: samples/ports/port-bind-update-response.json"},{"line_number":264,"context_line":"   :language: javascript"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"Delete port"},{"line_number":267,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"ff82abbf_5456c52b","line":264,"range":{"start_line":254,"start_character":0,"end_line":264,"end_character":24},"updated":"2017-11-21 14:04:19.000000000","message":"I think both of these sample responses need the qos_policy_id in the sample response, don\u0027t they?","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"11cdd966f02699b4a09918d86251f143ffc76b27","unresolved":false,"context_lines":[{"line_number":251,"context_line":"   - tenant_id: project_id"},{"line_number":252,"context_line":"   - updated_at: updated_at"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Response Example"},{"line_number":255,"context_line":"----------------"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":".. literalinclude:: samples/ports/port-update-response.json"},{"line_number":258,"context_line":"   :language: javascript"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Response Example (admin user)"},{"line_number":261,"context_line":"-----------------------------"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":".. literalinclude:: samples/ports/port-bind-update-response.json"},{"line_number":264,"context_line":"   :language: javascript"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"Delete port"},{"line_number":267,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df87a7cf_5b06cd88","line":264,"range":{"start_line":254,"start_character":0,"end_line":264,"end_character":24},"in_reply_to":"ff82abbf_5456c52b","updated":"2017-12-05 16:34:51.000000000","message":"Yes, they need. I\u0027ve added it.","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"535c5def367c8d1cada48fadf732ef097a90f9fa","unresolved":false,"context_lines":[{"line_number":353,"context_line":"   - tenant_id: project_id"},{"line_number":354,"context_line":"   - updated_at: updated_at"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"Response Example"},{"line_number":357,"context_line":"----------------"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":".. literalinclude:: samples/ports/ports-list-response.json"},{"line_number":360,"context_line":"   :language: javascript"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"Response Example (admin user)"},{"line_number":363,"context_line":"-----------------------------"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":".. literalinclude:: samples/ports/ports-bind-list-response.json"},{"line_number":366,"context_line":"   :language: javascript"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"Create port"},{"line_number":369,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"ff82abbf_b43ab1e4","line":366,"range":{"start_line":356,"start_character":0,"end_line":366,"end_character":24},"updated":"2017-11-21 14:04:19.000000000","message":"I think we need the qos_policy_id in these sample responses too.","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"11cdd966f02699b4a09918d86251f143ffc76b27","unresolved":false,"context_lines":[{"line_number":353,"context_line":"   - tenant_id: project_id"},{"line_number":354,"context_line":"   - updated_at: updated_at"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"Response Example"},{"line_number":357,"context_line":"----------------"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":".. literalinclude:: samples/ports/ports-list-response.json"},{"line_number":360,"context_line":"   :language: javascript"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"Response Example (admin user)"},{"line_number":363,"context_line":"-----------------------------"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":".. literalinclude:: samples/ports/ports-bind-list-response.json"},{"line_number":366,"context_line":"   :language: javascript"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"Create port"},{"line_number":369,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df87a7cf_7b095193","line":366,"range":{"start_line":356,"start_character":0,"end_line":366,"end_character":24},"in_reply_to":"ff82abbf_b43ab1e4","updated":"2017-12-05 16:34:51.000000000","message":"Correct, I\u0027ve added them.","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"535c5def367c8d1cada48fadf732ef097a90f9fa","unresolved":false,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"Response Example (admin user)"},{"line_number":464,"context_line":"-----------------------------"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":".. literalinclude:: samples/ports/port-bind-create-response.json"},{"line_number":467,"context_line":"   :language: javascript"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"Bulk create ports"},{"line_number":470,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"ff82abbf_542b2593","line":467,"range":{"start_line":465,"start_character":0,"end_line":467,"end_character":24},"updated":"2017-11-21 14:04:19.000000000","message":"I think we need the qos_policy_id in this response too.","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"11cdd966f02699b4a09918d86251f143ffc76b27","unresolved":false,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"Response Example (admin user)"},{"line_number":464,"context_line":"-----------------------------"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":".. literalinclude:: samples/ports/port-bind-create-response.json"},{"line_number":467,"context_line":"   :language: javascript"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"Bulk create ports"},{"line_number":470,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df87a7cf_dbf97d80","line":467,"range":{"start_line":465,"start_character":0,"end_line":467,"end_character":24},"in_reply_to":"ff82abbf_542b2593","updated":"2017-12-05 16:34:51.000000000","message":"Yes, I\u0027ve added it.","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"535c5def367c8d1cada48fadf732ef097a90f9fa","unresolved":false,"context_lines":[{"line_number":551,"context_line":"Response Example"},{"line_number":552,"context_line":"----------------"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":".. literalinclude:: samples/ports/ports-bulk-create-response.json"},{"line_number":555,"context_line":"   :language: javascript"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"ff82abbf_3407811f","line":555,"range":{"start_line":554,"start_character":0,"end_line":555,"end_character":24},"updated":"2017-11-21 14:04:19.000000000","message":"I think we need qos_policy_id in this sample response too.","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"11cdd966f02699b4a09918d86251f143ffc76b27","unresolved":false,"context_lines":[{"line_number":551,"context_line":"Response Example"},{"line_number":552,"context_line":"----------------"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":".. literalinclude:: samples/ports/ports-bulk-create-response.json"},{"line_number":555,"context_line":"   :language: javascript"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df87a7cf_9bf3f59e","line":555,"range":{"start_line":554,"start_character":0,"end_line":555,"end_character":24},"in_reply_to":"ff82abbf_3407811f","updated":"2017-12-05 16:34:51.000000000","message":"Correct, I\u0027ve added it.","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d65158f08c0ea0d2b71245f28f706e336f414453","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":".. literalinclude:: samples/ports/ports-bulk-create-response.json"},{"line_number":555,"context_line":"   :language: javascript"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"1f485f77_027cd2e9","line":556,"updated":"2017-11-18 08:39:20.000000000","message":"is this new line necessary?","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"11cdd966f02699b4a09918d86251f143ffc76b27","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":".. literalinclude:: samples/ports/ports-bulk-create-response.json"},{"line_number":555,"context_line":"   :language: javascript"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"df87a7cf_bbeef9b1","line":556,"in_reply_to":"1f485f77_027cd2e9","updated":"2017-12-05 16:34:51.000000000","message":"Nope, I\u0027ve deleted it.","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e2afc20a6320f52c0d16420e7ef74beccf355b3d","unresolved":false,"context_lines":[{"line_number":203,"context_line":"----------------------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":".. literalinclude:: samples/ports/port-bind-update-request.json"},{"line_number":206,"context_line":"   :language: javascript"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Response Parameters"},{"line_number":209,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"df87a7cf_a9e0eacd","side":"PARENT","line":206,"range":{"start_line":206,"start_character":1,"end_line":206,"end_character":3},"updated":"2017-12-05 20:55:13.000000000","message":"why You removed those spaces from beginning of the line?","commit_id":"ca47ee87e602f906f3d1c1d063b8e83a346adf89"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"68b53550b745d0cda5e87f265c29b08393031d9b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"``ip_address`` is required in each allowed address pair, the ``mac_address``"},{"line_number":65,"context_line":"is optional and will be taken from the port if not specified."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"QoS extension"},{"line_number":68,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The :ref:`QoS \u003cquality-of-service\u003e` extension (``qos``) makes it possible to"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"df87a7cf_ad28e4e1","line":67,"updated":"2017-12-06 12:39:08.000000000","message":"I mentioned this on an earlier comment, but it appears we also need to do this for the network resource [1]. As the title of this patch is to update the different port operations, it seems we should also address the network resource herein.\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/qos.py#L94","commit_id":"876e527e96c1d31031faa99ccbe5e1d5068646da"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"104911c5ade02c7e9ee26ea0168e9f7e4ef00ff0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"``ip_address`` is required in each allowed address pair, the ``mac_address``"},{"line_number":65,"context_line":"is optional and will be taken from the port if not specified."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"QoS extension"},{"line_number":68,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The :ref:`QoS \u003cquality-of-service\u003e` extension (``qos``) makes it possible to"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"df87a7cf_77a3869f","line":67,"in_reply_to":"df87a7cf_ad28e4e1","updated":"2017-12-06 16:31:06.000000000","message":"Correct. Most probably I overlooked your previous comment.","commit_id":"876e527e96c1d31031faa99ccbe5e1d5068646da"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cdffbebc339c8bccfb9e38adc4e5227ddf1c40e2","unresolved":false,"context_lines":[{"line_number":151,"context_line":"   - port_security_enabled: port_security_enabled"},{"line_number":152,"context_line":"   - project_id: project_id"},{"line_number":153,"context_line":"   - revision_number: revision_number"},{"line_number":154,"context_line":"   - qos_policy_id: qos_policy_id-port-response"},{"line_number":155,"context_line":"   - security_groups: port-security_groups"},{"line_number":156,"context_line":"   - status: port-status"},{"line_number":157,"context_line":"   - tenant_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":19,"id":"3fa0c359_c3181a1f","line":154,"updated":"2018-02-26 12:20:27.000000000","message":"can\u0027t You use \"qos_policy_id\" parameter as it is done in networks.inc? Or change in networks.inc also to be something like here so \"Qos policy associated with network\"","commit_id":"5153ac00a370ab972fa18188e5d7ed83107ffb6f"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"58422c1fdcc8e2d6e6eae51a60d7c6ec6f9d007c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"   - port_security_enabled: port_security_enabled"},{"line_number":152,"context_line":"   - project_id: project_id"},{"line_number":153,"context_line":"   - revision_number: revision_number"},{"line_number":154,"context_line":"   - qos_policy_id: qos_policy_id-port-response"},{"line_number":155,"context_line":"   - security_groups: port-security_groups"},{"line_number":156,"context_line":"   - status: port-status"},{"line_number":157,"context_line":"   - tenant_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":19,"id":"1f9dbf25_01382ed1","line":154,"in_reply_to":"3fa0c359_c3181a1f","updated":"2018-02-27 11:53:05.000000000","message":"Done","commit_id":"5153ac00a370ab972fa18188e5d7ed83107ffb6f"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b533a1d7926e2946d8d134f77e2f3a60335aa61e","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"IP Substring Filtering"},{"line_number":86,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"The ``ip-substring-filtering`` extension adds support for filtering ports by"},{"line_number":89,"context_line":"using part of an IP address."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":21,"id":"1f9dbf25_d3f2f806","side":"PARENT","line":87,"updated":"2018-03-01 05:24:30.000000000","message":"Do you need this change?","commit_id":"503273b4483b53444b86882115bab9b14636d0c9"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"a8d3caaab3d5b107c894540c627ff4aa9f3660ab","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"IP Substring Filtering"},{"line_number":86,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"The ``ip-substring-filtering`` extension adds support for filtering ports by"},{"line_number":89,"context_line":"using part of an IP address."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":21,"id":"1f9dbf25_08a02af4","side":"PARENT","line":87,"in_reply_to":"1f9dbf25_d3f2f806","updated":"2018-03-01 09:42:29.000000000","message":"I\u0027ve added the empty line for consistency.","commit_id":"503273b4483b53444b86882115bab9b14636d0c9"}],"api-ref/source/v2/qos.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d919dd1fb9e40da3826781b876a8a6d73fc06e21","unresolved":false,"context_lines":[{"line_number":862,"context_line":""},{"line_number":863,"context_line":"Normal response codes: 204"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"Error response codes: 400, 401ss, 404"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"Request"},{"line_number":868,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"7f287b81_64136368","line":865,"range":{"start_line":865,"start_character":27,"end_line":865,"end_character":32},"updated":"2017-08-22 16:06:19.000000000","message":"Is 401ss a new HTTP response code?? :)","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"9be743f6b8f1dd5139b900b45bdd659d1b602b27","unresolved":false,"context_lines":[{"line_number":862,"context_line":""},{"line_number":863,"context_line":"Normal response codes: 204"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"Error response codes: 400, 401ss, 404"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"Request"},{"line_number":868,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"7f287b81_33aaa070","line":865,"range":{"start_line":865,"start_character":27,"end_line":865,"end_character":32},"in_reply_to":"7f287b81_64136368","updated":"2017-08-29 07:08:12.000000000","message":":) (silly lagging VM)\nDone","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d65158f08c0ea0d2b71245f28f706e336f414453","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Creates a QoS policy."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":138,"context_line":"the request object. One policy can contain more than one rule type. "},{"line_number":139,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"1f485f77_e27e56e2","line":138,"updated":"2017-11-18 08:39:20.000000000","message":"please remove trailing space","commit_id":"9e44b5922f8e3fc6875ee97b8242c5e853170039"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e2afc20a6320f52c0d16420e7ef74beccf355b3d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Creates a QoS policy."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":138,"context_line":"the request object. One policy can contain more than one rule type. "},{"line_number":139,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"df87a7cf_89b886c8","line":138,"range":{"start_line":138,"start_character":67,"end_line":138,"end_character":68},"updated":"2017-12-05 20:55:13.000000000","message":"Please remove this trailing space","commit_id":"2240449a8825b1b2d0c09aeccd2dbbb6cf5926d6"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"9e54169c9097fc6f7876d1d1c58556c0181a954e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Creates a QoS policy."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":138,"context_line":"the request object. One policy can contain more than one rule type. "},{"line_number":139,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"df87a7cf_aac52f5d","line":138,"range":{"start_line":138,"start_character":67,"end_line":138,"end_character":68},"in_reply_to":"df87a7cf_89b886c8","updated":"2017-12-06 08:46:41.000000000","message":"Done","commit_id":"2240449a8825b1b2d0c09aeccd2dbbb6cf5926d6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b533a1d7926e2946d8d134f77e2f3a60335aa61e","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Creates a QoS policy."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":158,"context_line":"the request object. One policy can contain more than one rule type."},{"line_number":159,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"1f9dbf25_53bfc8fa","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":67},"updated":"2018-03-01 05:24:30.000000000","message":"Why do you add this line in descriptions of create method? This may confuse users like policy can be created with some rules(actually it cannot).","commit_id":"d3ad0f29915832ffcd151bfd2ef41b56b16d9076"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"a8d3caaab3d5b107c894540c627ff4aa9f3660ab","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Creates a QoS policy."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":158,"context_line":"the request object. One policy can contain more than one rule type."},{"line_number":159,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"1f9dbf25_a80ed6e2","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":67},"in_reply_to":"1f9dbf25_53bfc8fa","updated":"2018-03-01 09:42:29.000000000","message":"Humm, so you mean that one policy can contain only one rule type? Maybe I just misunderstood something....","commit_id":"d3ad0f29915832ffcd151bfd2ef41b56b16d9076"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8dedaffb04cabc75f8be966aa0d38270e00df596","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Creates a QoS policy."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":158,"context_line":"the request object. One policy can contain more than one rule type."},{"line_number":159,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"ff6b8bd7_20ff6e68","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":67},"in_reply_to":"1f9dbf25_a80ed6e2","updated":"2018-03-05 08:42:33.000000000","message":"No, policy can contain different types of rules. Basically it can contain only one type of rule for one direction (if direction attribute is present for rule type).\nSo for example QoS policy can contain:\n\n- one dscp marking rule type\n- one bw limit with ingress direction\n- one bw limit with egress direction","commit_id":"d3ad0f29915832ffcd151bfd2ef41b56b16d9076"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"33d9e7176ec9f111f38c04b90217cd41af1875ae","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Creates a QoS policy."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":158,"context_line":"the request object. One policy can contain more than one rule type."},{"line_number":159,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"ff6b8bd7_ae04c1c7","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":67},"in_reply_to":"ff6b8bd7_20ff6e68","updated":"2018-03-06 01:46:04.000000000","message":"I meant that we cannot create a policy with rules but the description sounds like we can create a policy with rules. Why not move the description into GET method so that uses don\u0027t misunderstand?","commit_id":"d3ad0f29915832ffcd151bfd2ef41b56b16d9076"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"27742c8d4f0162a43ff2d08c93421fdf091490d2","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Creates a QoS policy."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":158,"context_line":"the request object. One policy can contain more than one rule type."},{"line_number":159,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"df7087c5_ccaa6218","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":67},"in_reply_to":"ff6b8bd7_ae04c1c7","updated":"2018-03-07 12:53:17.000000000","message":"Done","commit_id":"d3ad0f29915832ffcd151bfd2ef41b56b16d9076"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d60f57e3990c1e9a98f6a338b5b5ac937f26fa4f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Creates a QoS policy."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":158,"context_line":"the request object. One policy can contain more than one rule type."},{"line_number":159,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"ff6b8bd7_a24cd076","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":67},"in_reply_to":"ff6b8bd7_ae04c1c7","updated":"2018-03-06 07:50:13.000000000","message":"I understood Your point Hirofumi and I agree that it would be better as You said","commit_id":"d3ad0f29915832ffcd151bfd2ef41b56b16d9076"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d2fe29418bed47529eb7f5fc26b2ba7ce38252f7","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Creates a QoS policy."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":173,"context_line":"the request object."},{"line_number":174,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":23,"id":"9f6a8fd7_b9e4123e","line":173,"updated":"2018-04-26 18:20:51.000000000","message":"Not sure why we changed this formatting, but OK.","commit_id":"ed41c94558e0aacf7088261617f73ae434743d6b"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"b662d8fceef7679b16f7c2504a46cfd92e5f3692","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Creates a QoS policy."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Creates a QoS policy by using the configuration that you define in"},{"line_number":173,"context_line":"the request object."},{"line_number":174,"context_line":"A response object is returned. The object contains a unique ID."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"By the default policy configuration, if the caller is not an administrative"}],"source_content_type":"text/x-c++src","patch_set":23,"id":"9f6a8fd7_bcffb765","line":173,"in_reply_to":"9f6a8fd7_b9e4123e","updated":"2018-05-03 04:54:24.000000000","message":"I can revert it to the original formating if you think.","commit_id":"ed41c94558e0aacf7088261617f73ae434743d6b"}],"api-ref/source/v2/samples/ports/ports-bind-list-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d919dd1fb9e40da3826781b876a8a6d73fc06e21","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \"project_id\": \"d397de8a63f341818f198abb0966f6f3\","},{"line_number":64,"context_line":"            \"security_groups\": [],"},{"line_number":65,"context_line":"            \"status\": \"ACTIVE\","},{"line_number":66,"context_line":"            \"tenant_id\": \"d397de8a63f341818f198abb0966f6f3\""},{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":"    ]"},{"line_number":69,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"7f287b81_ff6fe08f","line":66,"updated":"2017-08-22 16:06:19.000000000","message":"Don\u0027t we need qos_policy_id down here too?","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"9be743f6b8f1dd5139b900b45bdd659d1b602b27","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \"project_id\": \"d397de8a63f341818f198abb0966f6f3\","},{"line_number":64,"context_line":"            \"security_groups\": [],"},{"line_number":65,"context_line":"            \"status\": \"ACTIVE\","},{"line_number":66,"context_line":"            \"tenant_id\": \"d397de8a63f341818f198abb0966f6f3\""},{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":"    ]"},{"line_number":69,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"7f287b81_93b4b4d2","line":66,"in_reply_to":"7f287b81_ff6fe08f","updated":"2017-08-29 07:08:12.000000000","message":"I want to show, that some ports have qos_policy_id and some does not.","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"82a8ce59b5568189931953ac74f193307d7e5bd8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"project_id\": \"d397de8a63f341818f198abb0966f6f3\","},{"line_number":78,"context_line":"            \"security_groups\": [],"},{"line_number":79,"context_line":"            \"status\": \"ACTIVE\","},{"line_number":80,"context_line":"            \"tenant_id\": \"d397de8a63f341818f198abb0966f6f3\""},{"line_number":81,"context_line":"        }"},{"line_number":82,"context_line":"    ]"},{"line_number":83,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7f287b81_05e1922a","line":80,"updated":"2017-08-29 10:56:21.000000000","message":"In PS4 you mentioned \"I want to show, that some ports have qos_policy_id and some does not.\", but IIUC qos_policy_id is a required response param. That said even if its not set it should be in the response and will have a default value (likely \"\" or null).","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"1b043491526e24ce42e41b597223390b99e7a2cf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"project_id\": \"d397de8a63f341818f198abb0966f6f3\","},{"line_number":78,"context_line":"            \"security_groups\": [],"},{"line_number":79,"context_line":"            \"status\": \"ACTIVE\","},{"line_number":80,"context_line":"            \"tenant_id\": \"d397de8a63f341818f198abb0966f6f3\""},{"line_number":81,"context_line":"        }"},{"line_number":82,"context_line":"    ]"},{"line_number":83,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7f287b81_d7646124","line":80,"in_reply_to":"7f287b81_05e1922a","updated":"2017-09-04 05:56:41.000000000","message":"Yes, you are right. \nI\u0027ve added it.","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"}],"api-ref/source/v2/samples/ports/ports-bulk-create-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"82a8ce59b5568189931953ac74f193307d7e5bd8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            ],"},{"line_number":54,"context_line":"            \"status\": \"DOWN\","},{"line_number":55,"context_line":"            \"tenant_id\": \"d6700c0c9ffa4f1cb322cd4a1f3906fa\""},{"line_number":56,"context_line":"        }"},{"line_number":57,"context_line":"    ]"},{"line_number":58,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7f287b81_c53dca8f","line":56,"updated":"2017-08-29 10:56:21.000000000","message":"Same comment I made about including qos_policy_id in the response.","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"1b043491526e24ce42e41b597223390b99e7a2cf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            ],"},{"line_number":54,"context_line":"            \"status\": \"DOWN\","},{"line_number":55,"context_line":"            \"tenant_id\": \"d6700c0c9ffa4f1cb322cd4a1f3906fa\""},{"line_number":56,"context_line":"        }"},{"line_number":57,"context_line":"    ]"},{"line_number":58,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"7f287b81_d5ca9c4d","line":56,"in_reply_to":"7f287b81_c53dca8f","updated":"2017-09-04 05:56:41.000000000","message":"Done","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"}],"api-ref/source/v2/samples/ports/ports-list-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5580653ab4ec7ee60a85dd26e801e504e7e795bd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            \"project_id\": \"d397de8a63f341818f198abb0966f6f3\","},{"line_number":60,"context_line":"            \"security_groups\": [],"},{"line_number":61,"context_line":"            \"status\": \"ACTIVE\","},{"line_number":62,"context_line":"            \"tenant_id\": \"d397de8a63f341818f198abb0966f6f3\""},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"    ]"},{"line_number":65,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"7f287b81_f10c693a","line":62,"updated":"2017-09-05 14:40:37.000000000","message":"What about the qos_policy_id down here in this port object?? Seems like its needed.","commit_id":"4602b8f7dbd1fe0d5ed84f7eb57933c25d8c6957"}],"tools/tox_install.sh":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7b36b8f314bc47b4f724b7b6899183edc0f354dd","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":46,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":47,"context_line":"# install will be constrained and we need to unconstrain it"},{"line_number":48,"context_line":"edit-constraints $localfile $LIB_NAME"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"$install_cmd -U $*"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f287b81_7996c94e","line":47,"updated":"2017-08-29 08:23:27.000000000","message":"Is this necessary?","commit_id":"acbce092eeb7f8353d3504b67aec9294acc7ac02"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"04fb468536fe70722786385e5a1702707a8d9e98","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":46,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":47,"context_line":"# install will be constrained and we need to unconstrain it"},{"line_number":48,"context_line":"edit-constraints $localfile $LIB_NAME"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"$install_cmd -U $*"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f287b81_b938b1ed","line":47,"in_reply_to":"7f287b81_7996c94e","updated":"2017-08-29 08:50:20.000000000","message":"This was coming during a rebase with master.","commit_id":"acbce092eeb7f8353d3504b67aec9294acc7ac02"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7b36b8f314bc47b4f724b7b6899183edc0f354dd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":47,"context_line":"# install will be constrained and we need to unconstrain it"},{"line_number":48,"context_line":"edit-constraints $localfile $LIB_NAME"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"$install_cmd -U $*"},{"line_number":51,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f287b81_59930d5c","line":49,"updated":"2017-08-29 08:23:27.000000000","message":"ditto","commit_id":"acbce092eeb7f8353d3504b67aec9294acc7ac02"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"04fb468536fe70722786385e5a1702707a8d9e98","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":47,"context_line":"# install will be constrained and we need to unconstrain it"},{"line_number":48,"context_line":"edit-constraints $localfile $LIB_NAME"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"$install_cmd -U $*"},{"line_number":51,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f287b81_392cc1aa","line":49,"in_reply_to":"7f287b81_59930d5c","updated":"2017-08-29 08:50:20.000000000","message":"This was coming during a rebase with master.\nIt was also my change [1] merged. \n\n[1]: https://review.openstack.org/#/c/492158/","commit_id":"acbce092eeb7f8353d3504b67aec9294acc7ac02"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"82a8ce59b5568189931953ac74f193307d7e5bd8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":47,"context_line":"# install will be constrained and we need to unconstrain it"},{"line_number":48,"context_line":"edit-constraints $localfile $LIB_NAME"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"$install_cmd -U $*"},{"line_number":51,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":7,"id":"7f287b81_054f5234","line":49,"updated":"2017-08-29 10:56:21.000000000","message":"Is there a need for this new empty line?","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"1b043491526e24ce42e41b597223390b99e7a2cf","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":47,"context_line":"# install will be constrained and we need to unconstrain it"},{"line_number":48,"context_line":"edit-constraints $localfile $LIB_NAME"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"$install_cmd -U $*"},{"line_number":51,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":7,"id":"7f287b81_75c1a82e","line":49,"in_reply_to":"7f287b81_054f5234","updated":"2017-09-04 05:56:41.000000000","message":"Done","commit_id":"6b644ec1ffd1f6436eb90d724b24e9354464240e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5580653ab4ec7ee60a85dd26e801e504e7e795bd","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":46,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":47,"context_line":"# install will be constrained and we need to unconstrain it"},{"line_number":48,"context_line":"edit-constraints $localfile $LIB_NAME"},{"line_number":49,"context_line":"$install_cmd -U $*"},{"line_number":50,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":8,"id":"7f287b81_de4e1cc0","line":47,"updated":"2017-09-05 14:40:37.000000000","message":"I would opt just to leave this file as-is; this seems unrelated to the patch at hand.","commit_id":"4602b8f7dbd1fe0d5ed84f7eb57933c25d8c6957"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4a9d67b0e9b75f186f89c686c8556feda81bab0a","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":46,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":47,"context_line":"# install will be constrained and we need to unconstrain it"},{"line_number":48,"context_line":"edit-constraints $localfile $LIB_NAME"},{"line_number":49,"context_line":"$install_cmd -U $*"},{"line_number":50,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":9,"id":"7f287b81_a4de763b","line":47,"updated":"2017-09-06 18:11:20.000000000","message":"this change doesn\u0027t belong to this patch.","commit_id":"52a7c2b62ce51d038a03bafadb1b4c9b9328fe9d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"49ebf417885077a655c15bc284f9d3d627ec52b4","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":46,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":47,"context_line":"# install will be constrained and we need to unconstrain it"},{"line_number":48,"context_line":"edit-constraints $localfile $LIB_NAME"},{"line_number":49,"context_line":"$install_cmd -U $*"},{"line_number":50,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3f4b6375_ccea580d","line":47,"updated":"2017-11-07 14:11:30.000000000","message":"Is this intended?\nNot seeing how its related, but I suppose OK.","commit_id":"22fb3e5207aaa2495245d81f5e3fe7b495f02cea"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"12c69df3b02afc22ca4471904a98a53a4d6cf4d2","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":46,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":47,"context_line":"# install will be constrained and we need to unconstrain it"},{"line_number":48,"context_line":"edit-constraints $localfile $LIB_NAME"},{"line_number":49,"context_line":"$install_cmd -U $*"},{"line_number":50,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3f4b6375_0773a2e8","line":47,"in_reply_to":"3f4b6375_ccea580d","updated":"2017-11-07 22:31:18.000000000","message":"Ups, not intended and not related.","commit_id":"22fb3e5207aaa2495245d81f5e3fe7b495f02cea"}],"tox.ini":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d919dd1fb9e40da3826781b876a8a6d73fc06e21","unresolved":false,"context_lines":[{"line_number":39,"context_line":"whitelist_externals \u003d rm"},{"line_number":40,"context_line":"commands \u003d"},{"line_number":41,"context_line":"  rm -rf api-ref/build"},{"line_number":42,"context_line":"  sphinx-build -E -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[testenv:debug]"},{"line_number":45,"context_line":"commands \u003d oslo_debug_helper -t neutron_lib/tests/unit {posargs}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"7f287b81_e42d13a9","line":42,"updated":"2017-08-22 16:06:19.000000000","message":"Is this really related to this patchset?\nIf not it might be best to just have this tox update in its own patch.","commit_id":"4d00cc4c35db0dd6ae9ec7c6861b151f12e68f87"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7b36b8f314bc47b4f724b7b6899183edc0f354dd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  {toxinidir}/tools/check_samples.sh"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[testenv:releasenotes]"},{"line_number":25,"context_line":"commands \u003d sphinx-build -a -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[testenv:venv]"},{"line_number":28,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"7f287b81_99b855e5","line":25,"updated":"2017-08-29 08:23:27.000000000","message":"As said by Boden in PS4, this should be in other patchset. This is not related, is it?","commit_id":"acbce092eeb7f8353d3504b67aec9294acc7ac02"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"04fb468536fe70722786385e5a1702707a8d9e98","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  {toxinidir}/tools/check_samples.sh"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[testenv:releasenotes]"},{"line_number":25,"context_line":"commands \u003d sphinx-build -a -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[testenv:venv]"},{"line_number":28,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"7f287b81_4411e051","line":25,"in_reply_to":"7f287b81_99b855e5","updated":"2017-08-29 08:50:20.000000000","message":"Damn. I\u0027ve mixed the two -E -s.\nAdding back it to here.","commit_id":"acbce092eeb7f8353d3504b67aec9294acc7ac02"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7b36b8f314bc47b4f724b7b6899183edc0f354dd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"whitelist_externals \u003d rm"},{"line_number":40,"context_line":"commands \u003d"},{"line_number":41,"context_line":"  rm -rf api-ref/build"},{"line_number":42,"context_line":"  sphinx-build -E -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[testenv:debug]"},{"line_number":45,"context_line":"commands \u003d oslo_debug_helper -t neutron_lib/tests/unit {posargs}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"7f287b81_59ce6d82","line":42,"updated":"2017-08-29 08:23:27.000000000","message":"ditto","commit_id":"acbce092eeb7f8353d3504b67aec9294acc7ac02"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"04fb468536fe70722786385e5a1702707a8d9e98","unresolved":false,"context_lines":[{"line_number":39,"context_line":"whitelist_externals \u003d rm"},{"line_number":40,"context_line":"commands \u003d"},{"line_number":41,"context_line":"  rm -rf api-ref/build"},{"line_number":42,"context_line":"  sphinx-build -E -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[testenv:debug]"},{"line_number":45,"context_line":"commands \u003d oslo_debug_helper -t neutron_lib/tests/unit {posargs}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"7f287b81_643dfcc2","line":42,"in_reply_to":"7f287b81_59ce6d82","updated":"2017-08-29 08:50:20.000000000","message":"Removing from here.","commit_id":"acbce092eeb7f8353d3504b67aec9294acc7ac02"}]}