)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"01b69387dec4d10aa184342edfff3406e8530b09","unresolved":false,"context_lines":[{"line_number":10,"context_line":"that are used outside of neutron and are thus candidates for rehoming."},{"line_number":11,"context_line":"The remaining public attributes from neutron.common.constants will"},{"line_number":12,"context_line":"be made private upon consumption of this rehome patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I360545b6ee4291547e0c5c8e668ad03d3efa4725"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_16ce3159","line":13,"updated":"2017-06-06 04:26:03.000000000","message":"I agree this patch but I have a question. Are we sporadically going to continue to move constants from neutron.common.constants? Why don\u0027t we move all constants of neutron.common.constants?","commit_id":"d8938799c7f313bbf7795d5c8a58cbc2d42fdf99"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d0c75a2773c61d05f66a8579096184e5b5ebd22c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"that are used outside of neutron and are thus candidates for rehoming."},{"line_number":11,"context_line":"The remaining public attributes from neutron.common.constants will"},{"line_number":12,"context_line":"be made private upon consumption of this rehome patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I360545b6ee4291547e0c5c8e668ad03d3efa4725"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_bfd85f1e","line":13,"in_reply_to":"df140735_16ce3159","updated":"2017-06-06 17:53:04.000000000","message":"The have been coming over as part of the work to specifically decouple networking-ovn from neutron [1]. If someone has time to go through all constants and rehome that\u0027s great, but my focus has been getting as much of ovn\u0027s dependencies rehomed as possible; thus the sporadic nature.\n\n\n[1] https://blueprints.launchpad.net/neutron/+spec/neutron-lib-networking-ovn","commit_id":"d8938799c7f313bbf7795d5c8a58cbc2d42fdf99"}],"neutron_lib/constants.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"07c3c521103e62faf2973edc3084c62aee7b3284","unresolved":false,"context_lines":[{"line_number":40,"context_line":"INACTIVE \u003d \"INACTIVE\""},{"line_number":41,"context_line":"ERROR \u003d \"ERROR\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"ROUTER_STATUS_ACTIVE \u003d ACTIVE"},{"line_number":44,"context_line":"ROUTER_STATUS_ERROR \u003d ERROR"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"DEVICE_OWNER_COMPUTE_PREFIX \u003d \"compute:\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_b0979a3a","line":43,"updated":"2017-06-16 19:56:40.000000000","message":"if we rehome those anyway, meaning users will need to adopt, why not just switching them to ACTIVE and ERROR?","commit_id":"4f711557432aa279f9500b82c2fe63dad4bccd9c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4894b5fe1eab75d1d6e7e34e431a85dcf5d09c0e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"INACTIVE \u003d \"INACTIVE\""},{"line_number":41,"context_line":"ERROR \u003d \"ERROR\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"ROUTER_STATUS_ACTIVE \u003d ACTIVE"},{"line_number":44,"context_line":"ROUTER_STATUS_ERROR \u003d ERROR"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"DEVICE_OWNER_COMPUTE_PREFIX \u003d \"compute:\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_9d2ed289","line":43,"in_reply_to":"7f231b9d_34b35eeb","updated":"2017-06-19 14:56:33.000000000","message":"I agree; let\u0027s just go ahead to start moving to consolidated constants.","commit_id":"4f711557432aa279f9500b82c2fe63dad4bccd9c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b1a1dcad5c2021d9071ddc17c12cbb8f61300c11","unresolved":false,"context_lines":[{"line_number":40,"context_line":"INACTIVE \u003d \"INACTIVE\""},{"line_number":41,"context_line":"ERROR \u003d \"ERROR\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"ROUTER_STATUS_ACTIVE \u003d ACTIVE"},{"line_number":44,"context_line":"ROUTER_STATUS_ERROR \u003d ERROR"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"DEVICE_OWNER_COMPUTE_PREFIX \u003d \"compute:\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_34b35eeb","line":43,"in_reply_to":"7f231b9d_b0979a3a","updated":"2017-06-19 12:30:40.000000000","message":"I thought about that, but unfortunately this is the pattern we\u0027ve adopted herein. For example: \n- NET_STATUS_ACTIVE\n- PORT_STATUS_ACTIVE\n\nI was thinking we after we get all the constants rehomed we could work on consolidating such constants, but perhaps it makes more sense to address as we rehome?","commit_id":"4f711557432aa279f9500b82c2fe63dad4bccd9c"}],"releasenotes/notes/rehome-common-constants-8ac9580e52fd3618.yaml":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"01b69387dec4d10aa184342edfff3406e8530b09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Externally consumed constants from ``neutron.common.constants`` are now"},{"line_number":4,"context_line":"    available in neutron-lib."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_b6c0a5e2","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":33},"updated":"2017-06-06 04:26:03.000000000","message":"In view of release note, it might be extravagant advertisement. I think that we cannot assure developers that all such constants are rehomed because we may miss some such constants now or such constants will be produced in future. On the other hand, it may be verbose for me that all constants of this patch are enumerated. Well, I prefer the latter if anything.","commit_id":"d8938799c7f313bbf7795d5c8a58cbc2d42fdf99"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d0c75a2773c61d05f66a8579096184e5b5ebd22c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Externally consumed constants from ``neutron.common.constants`` are now"},{"line_number":4,"context_line":"    available in neutron-lib."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_9f435bb0","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":33},"in_reply_to":"df140735_b6c0a5e2","updated":"2017-06-06 17:53:04.000000000","message":"Sure I can reword. I used \"hound\" to grep the code which AFAIK includes all openstack projects.","commit_id":"d8938799c7f313bbf7795d5c8a58cbc2d42fdf99"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0def2463c5a430f1df295815efc7e6b6b97cb3ae","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Constants from ``neutron.common.constants`` are now available in"},{"line_number":4,"context_line":"    neutron-lib. Note that consumers using ``ROUTER_STATUS_ACTIVE`` or"},{"line_number":5,"context_line":"    ``ROUTER_STATUS_ERROR`` should now just use ``ACTIVE`` and ``ERROR``"},{"line_number":6,"context_line":"    from ``neutron_lib.constants``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f1d235d_fea903df","line":6,"updated":"2017-06-30 11:39:48.000000000","message":"I think we should just get everyone using ACTIVE/ERROR/BUILD etc and say they are valid states for any regular Neutron resource. Whether or not the interim one (e.g. BUILD/ERROR) will be used depends on the plugin.","commit_id":"eb7a55bdcade3e9ceda0d3b6506a1014ee939f6d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4e70c1569b3630a769b03201c038e1c96702f22b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Constants from ``neutron.common.constants`` are now available in"},{"line_number":4,"context_line":"    neutron-lib. Note that consumers using ``ROUTER_STATUS_ACTIVE`` or"},{"line_number":5,"context_line":"    ``ROUTER_STATUS_ERROR`` should now just use ``ACTIVE`` and ``ERROR``"},{"line_number":6,"context_line":"    from ``neutron_lib.constants``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f201791_ac867cda","line":6,"range":{"start_line":4,"start_character":17,"end_line":6,"end_character":35},"updated":"2017-06-23 22:50:36.000000000","message":"what\u0027s the plan for others like PORT_STATUS_ACTIVE?","commit_id":"eb7a55bdcade3e9ceda0d3b6506a1014ee939f6d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d52228bc77f0a65474c9cba7e6623ba24325002d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Constants from ``neutron.common.constants`` are now available in"},{"line_number":4,"context_line":"    neutron-lib. Note that consumers using ``ROUTER_STATUS_ACTIVE`` or"},{"line_number":5,"context_line":"    ``ROUTER_STATUS_ERROR`` should now just use ``ACTIVE`` and ``ERROR``"},{"line_number":6,"context_line":"    from ``neutron_lib.constants``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f201791_48b6388c","line":6,"range":{"start_line":4,"start_character":17,"end_line":6,"end_character":35},"in_reply_to":"5f201791_3f01fd6a","updated":"2017-06-28 17:16:35.000000000","message":"I see. If it becomes confusing couldn\u0027t we define status sets for resources in the constants? for example::\n\n    ROUTER_STATUSES \u003d {ACTIVE, DOWN...}\n\n\n\nWould be nice for Ihar or someone else to provide input here too :)","commit_id":"eb7a55bdcade3e9ceda0d3b6506a1014ee939f6d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c239bba81326689ab2d8a99a3ec627fe0de4d141","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Constants from ``neutron.common.constants`` are now available in"},{"line_number":4,"context_line":"    neutron-lib. Note that consumers using ``ROUTER_STATUS_ACTIVE`` or"},{"line_number":5,"context_line":"    ``ROUTER_STATUS_ERROR`` should now just use ``ACTIVE`` and ``ERROR``"},{"line_number":6,"context_line":"    from ``neutron_lib.constants``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f201791_ff914553","line":6,"range":{"start_line":4,"start_character":17,"end_line":6,"end_character":35},"in_reply_to":"5f201791_45c99656","updated":"2017-06-28 13:20:24.000000000","message":"Maybe I\u0027m not following, but how is a valid state of ACTIVE less clear than say ROUTER_STATUS_ACTIVE?","commit_id":"eb7a55bdcade3e9ceda0d3b6506a1014ee939f6d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"02caa1be3c5da4898319414ab0673b9900c09ec6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Constants from ``neutron.common.constants`` are now available in"},{"line_number":4,"context_line":"    neutron-lib. Note that consumers using ``ROUTER_STATUS_ACTIVE`` or"},{"line_number":5,"context_line":"    ``ROUTER_STATUS_ERROR`` should now just use ``ACTIVE`` and ``ERROR``"},{"line_number":6,"context_line":"    from ``neutron_lib.constants``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f201791_45c99656","line":6,"range":{"start_line":4,"start_character":17,"end_line":6,"end_character":35},"in_reply_to":"5f201791_a7108e4f","updated":"2017-06-28 07:25:29.000000000","message":"ok. it makes sense.\n\ni have a vague concern.\neach \"status\" fields have different sets of valid values.\nthis change makes it less clear.\nhow do you think?","commit_id":"eb7a55bdcade3e9ceda0d3b6506a1014ee939f6d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"623a3d19bb0dd4ca11dd2f4f0a41d3872f96005a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Constants from ``neutron.common.constants`` are now available in"},{"line_number":4,"context_line":"    neutron-lib. Note that consumers using ``ROUTER_STATUS_ACTIVE`` or"},{"line_number":5,"context_line":"    ``ROUTER_STATUS_ERROR`` should now just use ``ACTIVE`` and ``ERROR``"},{"line_number":6,"context_line":"    from ``neutron_lib.constants``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f201791_a7108e4f","line":6,"range":{"start_line":4,"start_character":17,"end_line":6,"end_character":35},"in_reply_to":"5f201791_ac867cda","updated":"2017-06-27 13:36:43.000000000","message":"IMO the longer-term plan should be to move everyone over to the single constants (ACTIVE, ERROR, etc.) as suggested by Ihar.","commit_id":"eb7a55bdcade3e9ceda0d3b6506a1014ee939f6d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8d196c0bc16af9270c726db5cbc122f48c979628","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Constants from ``neutron.common.constants`` are now available in"},{"line_number":4,"context_line":"    neutron-lib. Note that consumers using ``ROUTER_STATUS_ACTIVE`` or"},{"line_number":5,"context_line":"    ``ROUTER_STATUS_ERROR`` should now just use ``ACTIVE`` and ``ERROR``"},{"line_number":6,"context_line":"    from ``neutron_lib.constants``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f201791_3f01fd6a","line":6,"range":{"start_line":4,"start_character":17,"end_line":6,"end_character":35},"in_reply_to":"5f201791_ff914553","updated":"2017-06-28 13:25:43.000000000","message":"with ROUTER_STATUS_xxx, it\u0027s clear xxx is a valid status for routers.\nwith just xxx, it isn\u0027t obvious xxx can be used for a resource yyy.","commit_id":"eb7a55bdcade3e9ceda0d3b6506a1014ee939f6d"}]}