)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bd06bd837930cf254ce53ae2ff61108cf4545126","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* remove spurious comma in range definition for \u0027local_pref\u0027"},{"line_number":10,"context_line":"* add validator to allow a field to be an integer in a range or none"},{"line_number":11,"context_line":"  and use it for the local_pref parameter"},{"line_number":12,"context_line":"* the port association \u0027routes\u0027 attribute can be udpated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Needed-By: I263e1ee6cf4e1a91be91a4a78f4a160f64d33cc6"},{"line_number":15,"context_line":"Change-Id: I7995209459d5efa020a5e6c6335f4116df7f9f3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f1d235d_40922a4d","line":12,"range":{"start_line":12,"start_character":49,"end_line":12,"end_character":56},"updated":"2017-07-11 15:40:54.000000000","message":"updated","commit_id":"86b2fe98847e84d278ddf99f14ab5905781ee088"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"72203b4b004dc9b95b015c4b0fdf53e8a7682759","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* remove spurious comma in range definition for \u0027local_pref\u0027"},{"line_number":10,"context_line":"* add validator to allow a field to be an integer in a range or none"},{"line_number":11,"context_line":"  and use it for the local_pref parameter"},{"line_number":12,"context_line":"* the port association \u0027routes\u0027 attribute can be udpated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Needed-By: I263e1ee6cf4e1a91be91a4a78f4a160f64d33cc6"},{"line_number":15,"context_line":"Change-Id: I7995209459d5efa020a5e6c6335f4116df7f9f3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f1d235d_20d16ece","line":12,"range":{"start_line":12,"start_character":49,"end_line":12,"end_character":56},"in_reply_to":"3f1d235d_40922a4d","updated":"2017-07-11 15:47:48.000000000","message":"Done","commit_id":"86b2fe98847e84d278ddf99f14ab5905781ee088"}],"neutron_lib/api/definitions/bgpvpn_routes_control.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"116a990009f532a600a35a837065d35d7124ebdf","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027enforce_policy\u0027: True}"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"PORT_ASSOCIATION \u003d \u0027port_association\u0027"},{"line_number":78,"context_line":"PORT_ASSOCIATIONS \u003d \u0027port_associations\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_f6472a1c","line":75,"updated":"2017-07-07 05:05:56.000000000","message":"This change is unnecessary?","commit_id":"4518d5b526897f78f8cb4cf96c2e0931f06f29aa"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"59e364dd791f5540f2ff8e78e447f39a46c20d95","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027enforce_policy\u0027: True}"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"PORT_ASSOCIATION \u003d \u0027port_association\u0027"},{"line_number":78,"context_line":"PORT_ASSOCIATIONS \u003d \u0027port_associations\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_b68bf2bd","line":75,"in_reply_to":"3f1d235d_f6472a1c","updated":"2017-07-07 05:25:53.000000000","message":"Done","commit_id":"4518d5b526897f78f8cb4cf96c2e0931f06f29aa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ae822e7359c9f376506e411cb7ca373ee07f2068","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":69,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":70,"context_line":"            \u0027default\u0027: None,"},{"line_number":71,"context_line":"            \u0027validate\u0027: {\u0027type:range_or_none\u0027: LOCAL_PREF_RANGE},"},{"line_number":72,"context_line":"            \u0027enforce_policy\u0027: True}"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_f7dc6f19","line":71,"updated":"2017-07-11 06:38:14.000000000","message":"The corresponding API definition needs to be updated.","commit_id":"aaad97d612a4a956d667c04c12cfbd738e716501"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"412412947b06cb4593975e36f2a2df83cad1a65b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":69,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":70,"context_line":"            \u0027default\u0027: None,"},{"line_number":71,"context_line":"            \u0027validate\u0027: {\u0027type:range_or_none\u0027: LOCAL_PREF_RANGE},"},{"line_number":72,"context_line":"            \u0027enforce_policy\u0027: True}"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_cd9d66bc","line":71,"in_reply_to":"3f1d235d_f7dc6f19","updated":"2017-07-11 07:26:24.000000000","message":"Done","commit_id":"aaad97d612a4a956d667c04c12cfbd738e716501"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1cd1a3f59d25e3e1c5f88fd57854088aabb9ffc1","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":130,"context_line":"                        \u0027is_visible\u0027: True,"},{"line_number":131,"context_line":"                        \u0027enforce_policy\u0027: True},"},{"line_number":132,"context_line":"            ROUTES: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":133,"context_line":"                     \u0027default\u0027: [],"},{"line_number":134,"context_line":"                     \u0027convert_list_to\u0027: converters.convert_kvp_list_to_dict,"},{"line_number":135,"context_line":"                     \u0027validate\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_22e192fd","line":132,"updated":"2017-07-10 21:30:25.000000000","message":"Technically speaking this is an API change, should this be documented in [1]? Was this an oversight during the definition migration or is this a change in behavior?\n\n[1] https://developer.openstack.org/api-ref/networking/v2/#port-routes","commit_id":"aaad97d612a4a956d667c04c12cfbd738e716501"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"412412947b06cb4593975e36f2a2df83cad1a65b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":130,"context_line":"                        \u0027is_visible\u0027: True,"},{"line_number":131,"context_line":"                        \u0027enforce_policy\u0027: True},"},{"line_number":132,"context_line":"            ROUTES: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":133,"context_line":"                     \u0027default\u0027: [],"},{"line_number":134,"context_line":"                     \u0027convert_list_to\u0027: converters.convert_kvp_list_to_dict,"},{"line_number":135,"context_line":"                     \u0027validate\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_d21621a8","line":132,"in_reply_to":"3f1d235d_17c48b5e","updated":"2017-07-11 07:26:24.000000000","message":"Yes, Akihiro\u0027s understanding is correct.\n\nBy the way, since it\u0027s now very unlikely that we will land the different implementation changes before the looming feature freeze, I plan to submit a change to remove the API documentation for this API extension, so that it\u0027s not published until implemented.","commit_id":"aaad97d612a4a956d667c04c12cfbd738e716501"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ae822e7359c9f376506e411cb7ca373ee07f2068","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":130,"context_line":"                        \u0027is_visible\u0027: True,"},{"line_number":131,"context_line":"                        \u0027enforce_policy\u0027: True},"},{"line_number":132,"context_line":"            ROUTES: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":133,"context_line":"                     \u0027default\u0027: [],"},{"line_number":134,"context_line":"                     \u0027convert_list_to\u0027: converters.convert_kvp_list_to_dict,"},{"line_number":135,"context_line":"                     \u0027validate\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_17c48b5e","line":132,"in_reply_to":"3f1d235d_22e192fd","updated":"2017-07-11 06:38:14.000000000","message":"The actual implementation of the API has not been merged yet. In my understanding, there was a mistake in the initial API definition and he wants to fix it, so this patch actually affects nothing for existing API user and I think this patch is okay.\n\nIn the API definition, it is already documented. \u0027routes\u0027 attribute is listed\nin the PUT request fields.\nhttps://developer.openstack.org/api-ref/networking/v2/?expanded\u003dlist-port-associations-detail,update-a-port-association-detail#update-a-port-association","commit_id":"aaad97d612a4a956d667c04c12cfbd738e716501"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"237168491c8a55fbd2fc389c98bc0d56edcbb212","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":130,"context_line":"                        \u0027is_visible\u0027: True,"},{"line_number":131,"context_line":"                        \u0027enforce_policy\u0027: True},"},{"line_number":132,"context_line":"            ROUTES: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":133,"context_line":"                     \u0027default\u0027: [],"},{"line_number":134,"context_line":"                     \u0027convert_list_to\u0027: converters.convert_kvp_list_to_dict,"},{"line_number":135,"context_line":"                     \u0027validate\u0027: {"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_6dcf727f","line":132,"range":{"start_line":132,"start_character":41,"end_line":132,"end_character":58},"updated":"2017-07-11 07:31:18.000000000","message":"Does this requires to be mentioned in the release notes?","commit_id":"86b2fe98847e84d278ddf99f14ab5905781ee088"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"72ac91b697b3dd5353f999e7148c1b84dd9e632d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":130,"context_line":"                        \u0027is_visible\u0027: True,"},{"line_number":131,"context_line":"                        \u0027enforce_policy\u0027: True},"},{"line_number":132,"context_line":"            ROUTES: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":133,"context_line":"                     \u0027default\u0027: [],"},{"line_number":134,"context_line":"                     \u0027convert_list_to\u0027: converters.convert_kvp_list_to_dict,"},{"line_number":135,"context_line":"                     \u0027validate\u0027: {"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_4d1f1670","line":132,"range":{"start_line":132,"start_character":41,"end_line":132,"end_character":58},"in_reply_to":"3f1d235d_6dcf727f","updated":"2017-07-11 07:45:01.000000000","message":"I don\u0027t think so, this is not a change to an API that was present in any neutron-lib release, but a fix in something that will appear in next release.","commit_id":"86b2fe98847e84d278ddf99f14ab5905781ee088"}],"neutron_lib/tests/unit/api/validators/test_validators.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"df574e496cb6765be511e49f354e61029174262d","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    @mock.patch(\"neutron_lib.api.validators.validate_range\")"},{"line_number":323,"context_line":"    def test_validate_range_or_none(self, mock_validate_range):"},{"line_number":324,"context_line":"        msg \u003d validators.validate_range_or_none(None, [1, 9])"},{"line_number":325,"context_line":"        self.assertIsNone(msg)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        validators.validate_range_or_none(1, [1, 9])"},{"line_number":328,"context_line":"        mock_validate_range.assert_called_once_with(1, [1, 9])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_cd68e322","line":325,"updated":"2017-07-10 13:24:14.000000000","message":"Ideally it is better to check validate_range is not called\n\n self.assertFalse(mock_validate_range.called)\n\nbut it is optional as if mock_validate_range is called, mock.Mock object is returned and L.325 will fail.","commit_id":"e70981c3578d46e82422a76a2eb2f69e459b0af2"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"e5c74e8c9946be6a2d83d65125929339629965fc","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    @mock.patch(\"neutron_lib.api.validators.validate_range\")"},{"line_number":323,"context_line":"    def test_validate_range_or_none(self, mock_validate_range):"},{"line_number":324,"context_line":"        msg \u003d validators.validate_range_or_none(None, [1, 9])"},{"line_number":325,"context_line":"        self.assertIsNone(msg)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        validators.validate_range_or_none(1, [1, 9])"},{"line_number":328,"context_line":"        mock_validate_range.assert_called_once_with(1, [1, 9])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_b3b7443b","line":325,"in_reply_to":"3f1d235d_cd68e322","updated":"2017-07-10 13:49:16.000000000","message":"Done","commit_id":"e70981c3578d46e82422a76a2eb2f69e459b0af2"}],"releasenotes/notes/new-validator-range-or-none-dc8d557ec1f2622a.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c0ace1613e3fa6682d68dde45995dcd1cb46dec7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added validator range_or_none"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f1d235d_9499047b","line":3,"range":{"start_line":3,"start_character":20,"end_line":3,"end_character":33},"updated":"2017-07-07 11:59:22.000000000","message":"Nit: use ``range_or_none`` and also include a period at the end of sentence.","commit_id":"387dec3cc1ec5b7aa8f9c1ffc12140ed2cbdcebf"}]}
