)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"243537cd016b45920b52138b7bd92ededaf329c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chiew Yee Xin \u003cinternship_17020@recruit.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-10 13:21:31 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update API examples in Networks section"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I25bc1f5c3753e13eab42043663e06e7f6c62cec9"},{"line_number":10,"context_line":"Closes-Bug: #1702636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_c70c4c3d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":39},"updated":"2017-07-10 04:52:54.000000000","message":"Please add some contents under this title.","commit_id":"7843d9101d6a3c137991fb9271824613fa2803a0"},{"author":{"_account_id":26341,"name":"Chiew Yee Xin","email":"yeexinc@gmail.com","username":"yeexinc"},"change_message_id":"f2f0fb10a6f809b22215e1cb2d63a0a78ab2aa89","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chiew Yee Xin \u003cinternship_17020@recruit.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-10 13:21:31 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update API examples in Networks section"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I25bc1f5c3753e13eab42043663e06e7f6c62cec9"},{"line_number":10,"context_line":"Closes-Bug: #1702636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_a7e5d00c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":39},"in_reply_to":"3f1d235d_c70c4c3d","updated":"2017-07-10 05:20:19.000000000","message":"Done","commit_id":"7843d9101d6a3c137991fb9271824613fa2803a0"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"243537cd016b45920b52138b7bd92ededaf329c7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update API examples in Networks section"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I25bc1f5c3753e13eab42043663e06e7f6c62cec9"},{"line_number":10,"context_line":"Closes-Bug: #1702636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_272780b9","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":20},"updated":"2017-07-10 04:52:54.000000000","message":"Bug number mismatch? should be #1702637?","commit_id":"7843d9101d6a3c137991fb9271824613fa2803a0"},{"author":{"_account_id":26341,"name":"Chiew Yee Xin","email":"yeexinc@gmail.com","username":"yeexinc"},"change_message_id":"f2f0fb10a6f809b22215e1cb2d63a0a78ab2aa89","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update API examples in Networks section"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I25bc1f5c3753e13eab42043663e06e7f6c62cec9"},{"line_number":10,"context_line":"Closes-Bug: #1702636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_c7e0ccfd","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":20},"in_reply_to":"3f1d235d_272780b9","updated":"2017-07-10 05:20:19.000000000","message":"Hi Luo-san, thank you for the review, the commit message has been updated.","commit_id":"7843d9101d6a3c137991fb9271824613fa2803a0"}],"api-ref/source/v2/samples/networks/network-multi-create-response.json":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"522f3a2b3351adf8c8dd08e9f5946301f9a84ac6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        \"availability_zone_hints\": [],"},{"line_number":9,"context_line":"        \"availability_zones\": [],"},{"line_number":10,"context_line":"        \"segments\": ["},{"line_number":11,"context_line":"            {   "},{"line_number":12,"context_line":"            \"provider:network_type\": \"vlan\","},{"line_number":13,"context_line":"            \"provider:physical_network\": \"public\","},{"line_number":14,"context_line":"            \"provider:segmentation_id\": 2"}],"source_content_type":"application/json","patch_set":2,"id":"3f1d235d_cced938c","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":16},"updated":"2017-07-10 04:32:05.000000000","message":"Please remove whitespace","commit_id":"7843d9101d6a3c137991fb9271824613fa2803a0"},{"author":{"_account_id":26341,"name":"Chiew Yee Xin","email":"yeexinc@gmail.com","username":"yeexinc"},"change_message_id":"f2f0fb10a6f809b22215e1cb2d63a0a78ab2aa89","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        \"availability_zone_hints\": [],"},{"line_number":9,"context_line":"        \"availability_zones\": [],"},{"line_number":10,"context_line":"        \"segments\": ["},{"line_number":11,"context_line":"            {   "},{"line_number":12,"context_line":"            \"provider:network_type\": \"vlan\","},{"line_number":13,"context_line":"            \"provider:physical_network\": \"public\","},{"line_number":14,"context_line":"            \"provider:segmentation_id\": 2"}],"source_content_type":"application/json","patch_set":2,"id":"3f1d235d_871d3411","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":16},"in_reply_to":"3f1d235d_cced938c","updated":"2017-07-10 05:20:19.000000000","message":"Done","commit_id":"7843d9101d6a3c137991fb9271824613fa2803a0"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"522f3a2b3351adf8c8dd08e9f5946301f9a84ac6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"availability_zones\": [],"},{"line_number":10,"context_line":"        \"segments\": ["},{"line_number":11,"context_line":"            {   "},{"line_number":12,"context_line":"            \"provider:network_type\": \"vlan\","},{"line_number":13,"context_line":"            \"provider:physical_network\": \"public\","},{"line_number":14,"context_line":"            \"provider:segmentation_id\": 2"},{"line_number":15,"context_line":"            },"},{"line_number":16,"context_line":"            {"},{"line_number":17,"context_line":"            \"provider:network_type\": \"flat\","},{"line_number":18,"context_line":"            \"provider:physical_network\": \"default\","},{"line_number":19,"context_line":"            \"provider:segmentation_id\": null"},{"line_number":20,"context_line":"            }"},{"line_number":21,"context_line":"        ],"},{"line_number":22,"context_line":"        \"ipv4_address_scope\": null,"},{"line_number":23,"context_line":"        \"shared\": false,"}],"source_content_type":"application/json","patch_set":2,"id":"3f1d235d_0cf4ab5a","line":20,"range":{"start_line":12,"start_character":0,"end_line":20,"end_character":13},"updated":"2017-07-10 04:32:05.000000000","message":"Missing indent.  It should be \n\n  {\n      \"provider:network_type\": \"vlan\",\n      \"provider:physical_network\": \"public\",\n      \"provider:segmentation_id\": 2\n  },\n  {\n      \"provider:network_type\": \"flat\",\n      \"provider:physical_network\": \"default\",\n      \"provider:segmentation_id\": null\n  }","commit_id":"7843d9101d6a3c137991fb9271824613fa2803a0"},{"author":{"_account_id":26341,"name":"Chiew Yee Xin","email":"yeexinc@gmail.com","username":"yeexinc"},"change_message_id":"f2f0fb10a6f809b22215e1cb2d63a0a78ab2aa89","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"availability_zones\": [],"},{"line_number":10,"context_line":"        \"segments\": ["},{"line_number":11,"context_line":"            {   "},{"line_number":12,"context_line":"            \"provider:network_type\": \"vlan\","},{"line_number":13,"context_line":"            \"provider:physical_network\": \"public\","},{"line_number":14,"context_line":"            \"provider:segmentation_id\": 2"},{"line_number":15,"context_line":"            },"},{"line_number":16,"context_line":"            {"},{"line_number":17,"context_line":"            \"provider:network_type\": \"flat\","},{"line_number":18,"context_line":"            \"provider:physical_network\": \"default\","},{"line_number":19,"context_line":"            \"provider:segmentation_id\": null"},{"line_number":20,"context_line":"            }"},{"line_number":21,"context_line":"        ],"},{"line_number":22,"context_line":"        \"ipv4_address_scope\": null,"},{"line_number":23,"context_line":"        \"shared\": false,"}],"source_content_type":"application/json","patch_set":2,"id":"3f1d235d_272d4046","line":20,"range":{"start_line":12,"start_character":0,"end_line":20,"end_character":13},"in_reply_to":"3f1d235d_0cf4ab5a","updated":"2017-07-10 05:20:19.000000000","message":"Hi Furukawa-san, thank you for the review.\nThe indentation has been corrected.","commit_id":"7843d9101d6a3c137991fb9271824613fa2803a0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2359bf5ee61a3341ae2d93d2829fe9d69ecf83a1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        \"port_security_enabled\": true,"},{"line_number":6,"context_line":"        \"id\": \"cddc2738-fc1e-4ba0-94d8-90c4044ab0ac\","},{"line_number":7,"context_line":"        \"router:external\": false,"},{"line_number":8,"context_line":"        \"availability_zone_hints\": [],"},{"line_number":9,"context_line":"        \"availability_zones\": [],"},{"line_number":10,"context_line":"        \"segments\": ["},{"line_number":11,"context_line":"            {"}],"source_content_type":"application/json","patch_set":4,"id":"3f1d235d_cd7223e4","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":32},"updated":"2017-07-10 13:19:39.000000000","message":"While I\u0027m all for making these request/responses complete and up to date, some of the attributes added in this patch are from extensions that are not doc\u0027d.\n\n\nFor example [1] calls out a few extensions such as provider, etc., but it doesn\u0027t talk about tags/AZs/etc.\n\n\nWith that in mind it seems like we should be consistent and call out the extensions in [1] so that the attributes shown are understood by our users. Perhaps someone with more api-ref experience can comment on this topic.\n\n\n[1] https://developer.openstack.org/api-ref/networking/v2/?expanded\u003d#layer-2-networking","commit_id":"33c5a2c1a49a32f7b332289a079c61d961fb051a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"99403b7acf7112f974ab63de3d6b2673d7bd5599","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        \"port_security_enabled\": true,"},{"line_number":6,"context_line":"        \"id\": \"cddc2738-fc1e-4ba0-94d8-90c4044ab0ac\","},{"line_number":7,"context_line":"        \"router:external\": false,"},{"line_number":8,"context_line":"        \"availability_zone_hints\": [],"},{"line_number":9,"context_line":"        \"availability_zones\": [],"},{"line_number":10,"context_line":"        \"segments\": ["},{"line_number":11,"context_line":"            {"}],"source_content_type":"application/json","patch_set":4,"id":"1f1a1f67_f1895126","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":32},"in_reply_to":"3f1d235d_0b91119a","updated":"2017-07-12 19:35:28.000000000","message":"IMHO if we want to add new extension attributes to sample responses we should go ahead and doc the extension and include details on the new api request/response param(s). Otherwise we have some 1-offs in the response json that doesn\u0027t have proper request/response docs.\n\nFor example address scopes.","commit_id":"33c5a2c1a49a32f7b332289a079c61d961fb051a"},{"author":{"_account_id":26341,"name":"Chiew Yee Xin","email":"yeexinc@gmail.com","username":"yeexinc"},"change_message_id":"60d419d6da5593e0458dd67aeb7ba4b18be9169e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        \"port_security_enabled\": true,"},{"line_number":6,"context_line":"        \"id\": \"cddc2738-fc1e-4ba0-94d8-90c4044ab0ac\","},{"line_number":7,"context_line":"        \"router:external\": false,"},{"line_number":8,"context_line":"        \"availability_zone_hints\": [],"},{"line_number":9,"context_line":"        \"availability_zones\": [],"},{"line_number":10,"context_line":"        \"segments\": ["},{"line_number":11,"context_line":"            {"}],"source_content_type":"application/json","patch_set":4,"id":"3f1d235d_0b91119a","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":32},"in_reply_to":"3f1d235d_cd7223e4","updated":"2017-07-11 01:19:23.000000000","message":"Hi Boden, thank you for your review. I agree that the attributes shown should be understood by the users.\n\nWhile the new attributes added are not explained in [1] that you have provided, their descriptions are listed under the parameters section. For this file in particular, the attributes are explained in [2], under \"Response Parameters\".\n\nThough, I do notice that some of the attributes are still missing a description (e.g. revision_number). What do you think?\n\n[2] https://developer.openstack.org/api-ref/networking/v2/?expanded\u003dcreate-network-detail#create-network","commit_id":"33c5a2c1a49a32f7b332289a079c61d961fb051a"}]}