)]}'
{"tools/tox_install.sh":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9ac181f81417272bb8cf7ab12e1e65f27ff2c5ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Library constraint file contains this library version pin that is in conflict"},{"line_number":4,"context_line":"# with installing the library from source. We should replace the version pin in"},{"line_number":5,"context_line":"# the constraints file before applying it for from-source installation."},{"line_number":6,"context_line":"set -x"},{"line_number":7,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":8,"context_line":"BRANCH_NAME\u003dmaster"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f436f4f_ae2c00ac","line":5,"range":{"start_line":4,"start_character":43,"end_line":5,"end_character":71},"updated":"2017-08-14 10:55:38.000000000","message":"This comment will be no longer correct once this change is merged.","commit_id":"87a12b1838db2bea3c5566d1f2bf760ebf3d5469"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"90bab1bd65f46d859ef69fd1c76eea705ef8e390","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Library constraint file contains this library version pin that is in conflict"},{"line_number":4,"context_line":"# with installing the library from source. We should replace the version pin in"},{"line_number":5,"context_line":"# the constraints file before applying it for from-source installation."},{"line_number":6,"context_line":"set -x"},{"line_number":7,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":8,"context_line":"BRANCH_NAME\u003dmaster"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f287b81_eeadffea","line":5,"range":{"start_line":4,"start_character":43,"end_line":5,"end_character":71},"in_reply_to":"9f436f4f_ae2c00ac","updated":"2017-08-22 08:05:26.000000000","message":"Done","commit_id":"87a12b1838db2bea3c5566d1f2bf760ebf3d5469"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9ac181f81417272bb8cf7ab12e1e65f27ff2c5ea","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Library constraint file contains this library version pin that is in conflict"},{"line_number":4,"context_line":"# with installing the library from source. We should replace the version pin in"},{"line_number":5,"context_line":"# the constraints file before applying it for from-source installation."},{"line_number":6,"context_line":"set -x"},{"line_number":7,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":8,"context_line":"BRANCH_NAME\u003dmaster"},{"line_number":9,"context_line":"LIB_NAME\u003dneutron-lib"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f436f4f_ee2688ce","line":6,"updated":"2017-08-14 10:55:38.000000000","message":"I would like to see blank lines around this like L.12.","commit_id":"87a12b1838db2bea3c5566d1f2bf760ebf3d5469"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"90bab1bd65f46d859ef69fd1c76eea705ef8e390","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Library constraint file contains this library version pin that is in conflict"},{"line_number":4,"context_line":"# with installing the library from source. We should replace the version pin in"},{"line_number":5,"context_line":"# the constraints file before applying it for from-source installation."},{"line_number":6,"context_line":"set -x"},{"line_number":7,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":8,"context_line":"BRANCH_NAME\u003dmaster"},{"line_number":9,"context_line":"LIB_NAME\u003dneutron-lib"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f287b81_0ef72bf8","line":6,"in_reply_to":"9f436f4f_ee2688ce","updated":"2017-08-22 08:05:26.000000000","message":"I only put this to debug what is happening. I think we can remove it from the production code.","commit_id":"87a12b1838db2bea3c5566d1f2bf760ebf3d5469"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"27d5f02bcd6cb530992deef6066bcfb2ab5557e5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"curl $CONSTRAINTS_FILE -k -o $localfile"},{"line_number":25,"context_line":"install_cmd\u003d\"$install_cmd -c$localfile\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"if [ $requirements_installed -eq 0 ]; then"},{"line_number":28,"context_line":"    echo \"Requirements already installed; using existing package\""},{"line_number":29,"context_line":"elif [ -x \"$ZUUL_CLONER\" ]; then"},{"line_number":30,"context_line":"    pushd $mydir"},{"line_number":31,"context_line":"    $ZUUL_CLONER --cache-dir \\"},{"line_number":32,"context_line":"        /opt/git \\"},{"line_number":33,"context_line":"        --branch $BRANCH_NAME \\"},{"line_number":34,"context_line":"        git://git.openstack.org \\"},{"line_number":35,"context_line":"        openstack/requirements"},{"line_number":36,"context_line":"    cd openstack/requirements"},{"line_number":37,"context_line":"    $install_cmd -e ."},{"line_number":38,"context_line":"    popd"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"    if [ -z \"$REQUIREMENTS_PIP_LOCATION\" ]; then"},{"line_number":41,"context_line":"        REQUIREMENTS_PIP_LOCATION\u003d\"git+https://git.openstack.org/openstack/requirements@$BRANCH_NAME#egg\u003drequirements\""},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":"    $install_cmd -U -e ${REQUIREMENTS_PIP_LOCATION}"},{"line_number":44,"context_line":"fi"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":47,"context_line":"# the current repo. It is listed in constraints file and thus any"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f436f4f_fb757ffb","line":44,"range":{"start_line":27,"start_character":0,"end_line":44,"end_character":2},"updated":"2017-08-21 02:40:51.000000000","message":"This can be reduced to pip install openstack_requirements in a future change.","commit_id":"87a12b1838db2bea3c5566d1f2bf760ebf3d5469"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fe3e30c9aa89f2a50e05c5ebb826ce295475154f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":47,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":48,"context_line":"# install will be constrained and we need to unconstrain it."},{"line_number":49,"context_line":"edit-constraints $localfile $LIB_NAME --"},{"line_number":50,"context_line":"$install_cmd -U $*"},{"line_number":51,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f436f4f_e49f6d4d","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":40},"updated":"2017-08-17 09:30:58.000000000","message":"Actually \u0027--\u0027 is unnecessary.","commit_id":"87a12b1838db2bea3c5566d1f2bf760ebf3d5469"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9cbbf8cf1f94dc90f9114f97f3e157326e22f4cc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":47,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":48,"context_line":"# install will be constrained and we need to unconstrain it."},{"line_number":49,"context_line":"edit-constraints $localfile $LIB_NAME --"},{"line_number":50,"context_line":"$install_cmd -U $*"},{"line_number":51,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f436f4f_8183a604","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":40},"in_reply_to":"9f436f4f_db1bdbc7","updated":"2017-08-21 05:18:43.000000000","message":"The help of edit-constraints says \u0027If \"replacement\" is missing or empty, remove \"name\" from the from\u0027 [1]. The current version is fine, but I believe it is better to follow the help message for easy understanding.\n\n[1] https://github.com/openstack/requirements/blob/master/openstack_requirements/cmds/edit_constraint.py#L60-L61","commit_id":"87a12b1838db2bea3c5566d1f2bf760ebf3d5469"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"90bab1bd65f46d859ef69fd1c76eea705ef8e390","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":47,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":48,"context_line":"# install will be constrained and we need to unconstrain it."},{"line_number":49,"context_line":"edit-constraints $localfile $LIB_NAME --"},{"line_number":50,"context_line":"$install_cmd -U $*"},{"line_number":51,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f287b81_4e6413ba","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":40},"in_reply_to":"9f436f4f_e49f6d4d","updated":"2017-08-22 08:05:26.000000000","message":"Done","commit_id":"87a12b1838db2bea3c5566d1f2bf760ebf3d5469"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"27d5f02bcd6cb530992deef6066bcfb2ab5557e5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# This is the main purpose of the script: Allow local installation of"},{"line_number":47,"context_line":"# the current repo. It is listed in constraints file and thus any"},{"line_number":48,"context_line":"# install will be constrained and we need to unconstrain it."},{"line_number":49,"context_line":"edit-constraints $localfile $LIB_NAME --"},{"line_number":50,"context_line":"$install_cmd -U $*"},{"line_number":51,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f436f4f_db1bdbc7","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":40},"in_reply_to":"9f436f4f_e49f6d4d","updated":"2017-08-21 02:40:51.000000000","message":"Why so it is.  To statify my curiosity it\u0027s removed here:\n\nhttps://github.com/python/cpython/blob/2.7/Lib/optparse.py#L1435-L1437","commit_id":"87a12b1838db2bea3c5566d1f2bf760ebf3d5469"}]}