)]}'
{"neutron_lib/api/definitions/qos.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bf40388a9736bfd052a5e74ba2f51d85b46c5154","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            _QOS_RULE_COMMON_FIELDS,"},{"line_number":113,"context_line":"            **{\u0027max_kbps\u0027: {"},{"line_number":114,"context_line":"                \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":115,"context_line":"                \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":116,"context_line":"                \u0027validate\u0027: {"},{"line_number":117,"context_line":"                    \u0027type:range\u0027: [0, db_const.DB_INTEGER_MAX_VALUE]}"},{"line_number":118,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_46884670","line":115,"updated":"2017-08-18 20:48:52.000000000","message":"Default shouldn\u0027t be set here IMHO (or should be added also in min_kbps parameter for MIN_BANDWIDTH_RULE\nAnd second thing: why there is no convertion to int here?","commit_id":"f75e6ec6f2778e2cc8478fefc3a79cbba8588548"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"500d6e9a77942bd3d5081e59aadaf863bd8d5412","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            _QOS_RULE_COMMON_FIELDS,"},{"line_number":113,"context_line":"            **{\u0027max_kbps\u0027: {"},{"line_number":114,"context_line":"                \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":115,"context_line":"                \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":116,"context_line":"                \u0027validate\u0027: {"},{"line_number":117,"context_line":"                    \u0027type:range\u0027: [0, db_const.DB_INTEGER_MAX_VALUE]}"},{"line_number":118,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_3f71e8e1","line":115,"in_reply_to":"9f436f4f_46884670","updated":"2017-08-22 16:26:10.000000000","message":"Good catches. I removed the default. As for the convert to int; I copied from neutron qos ext and it\u0027s not there; I\u0027ve added.","commit_id":"f75e6ec6f2778e2cc8478fefc3a79cbba8588548"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bf40388a9736bfd052a5e74ba2f51d85b46c5154","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                    \u0027type:range\u0027: [0, db_const.DB_INTEGER_MAX_VALUE]}},"},{"line_number":147,"context_line":"                \u0027direction\u0027: {"},{"line_number":148,"context_line":"                    \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":149,"context_line":"                    \u0027is_visible\u0027: True, \u0027default\u0027: \u0027egress\u0027,"},{"line_number":150,"context_line":"                    \u0027validate\u0027: {"},{"line_number":151,"context_line":"                        \u0027type:values\u0027: [constants.EGRESS_DIRECTION]}}})"},{"line_number":152,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_267d426e","line":149,"updated":"2017-08-18 20:48:52.000000000","message":"as default You should use same contstant as in L151","commit_id":"f75e6ec6f2778e2cc8478fefc3a79cbba8588548"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"500d6e9a77942bd3d5081e59aadaf863bd8d5412","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                    \u0027type:range\u0027: [0, db_const.DB_INTEGER_MAX_VALUE]}},"},{"line_number":147,"context_line":"                \u0027direction\u0027: {"},{"line_number":148,"context_line":"                    \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":149,"context_line":"                    \u0027is_visible\u0027: True, \u0027default\u0027: \u0027egress\u0027,"},{"line_number":150,"context_line":"                    \u0027validate\u0027: {"},{"line_number":151,"context_line":"                        \u0027type:values\u0027: [constants.EGRESS_DIRECTION]}}})"},{"line_number":152,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_ff7240e3","line":149,"in_reply_to":"9f436f4f_267d426e","updated":"2017-08-22 16:26:10.000000000","message":"good point","commit_id":"f75e6ec6f2778e2cc8478fefc3a79cbba8588548"}]}
